Page MenuHomePhabricator
Feed Advanced Search

Apr 5 2019

CodaFi added inline comments to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.
Apr 5 2019, 1:41 PM · Restricted Project
CodaFi committed rGb4baa5602d15: [LLVM-C] Add bindings to insert basic blocks (authored by CodaFi).
[LLVM-C] Add bindings to insert basic blocks
Apr 5 2019, 1:33 PM
CodaFi committed rL357812: [LLVM-C] Add bindings to insert basic blocks.
[LLVM-C] Add bindings to insert basic blocks
Apr 5 2019, 1:32 PM
CodaFi closed D59658: [LLVM-C] Add bindings to insert basic blocks.
Apr 5 2019, 1:32 PM · Restricted Project
CodaFi updated the diff for D59658: [LLVM-C] Add bindings to insert basic blocks.
Apr 5 2019, 1:13 PM · Restricted Project
CodaFi added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

A (verbose) compromise: LLVMInsertExistingBasicBlockAfterInsertBlock?

Apr 5 2019, 1:03 PM · Restricted Project
CodaFi added inline comments to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.
Apr 5 2019, 12:47 PM · Restricted Project
CodaFi added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

I think the names are confusing. Why not something like LLVMInsertExistingBasicBlock and LLVMAppendExistingBasicBlock?

Apr 5 2019, 12:44 PM · Restricted Project
CodaFi added a comment to D60322: [LLVM-C] Begin to Expose A More General Binary Interface.

The ObjectFile APIs seem to have rotted a bit. There's a bunch of pitfalls when working with the thing like the fact that it goes out of its way to move the input buffer despite the create APIs taking non-owning references to the buffer in C++, accessors that no longer do anything useful (LLVMGetRelocationValueString) and inconsistent error handling routines (some functions return NULL, LLVMGetSymbolName and LLVMGetSymbolName reports a fatal error). On top of that, it's not actually a general interface to ObjectFile - it can't handle Mach-O Universal binaries as inputs for one.

Apr 5 2019, 12:38 PM · Restricted Project
CodaFi updated the diff for D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.

Remove support for Efficiency Sanitizer

Apr 5 2019, 8:56 AM · Restricted Project
CodaFi added a comment to D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.

Looks like ESan is dead https://reviews.llvm.org/rL355862. I'll update this patch.

Apr 5 2019, 8:55 AM · Restricted Project
CodaFi added a comment to D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets.

@mehdi_amini @kristina Ping.

Apr 5 2019, 8:50 AM · Restricted Project
CodaFi added a comment to D59658: [LLVM-C] Add bindings to insert basic blocks.

@whitequark Could I get your sign off on this too?

Apr 5 2019, 8:49 AM · Restricted Project
CodaFi created D60322: [LLVM-C] Begin to Expose A More General Binary Interface.
Apr 5 2019, 8:48 AM · Restricted Project

Mar 25 2019

CodaFi committed rG9d94a684040f: [LLVM-C] Add binding to look up intrinsic by name (authored by CodaFi).
[LLVM-C] Add binding to look up intrinsic by name
Mar 25 2019, 1:58 PM
CodaFi committed rL356948: [LLVM-C] Add binding to look up intrinsic by name.
[LLVM-C] Add binding to look up intrinsic by name
Mar 25 2019, 1:58 PM
CodaFi closed D59697: [LLVM-C] Add binding to look up intrinsic by name.
Mar 25 2019, 1:58 PM · Restricted Project

Mar 22 2019

CodaFi created D59697: [LLVM-C] Add binding to look up intrinsic by name.
Mar 22 2019, 7:31 AM · Restricted Project

Mar 21 2019

CodaFi created D59658: [LLVM-C] Add bindings to insert basic blocks.
Mar 21 2019, 11:28 AM · Restricted Project

Mar 15 2019

CodaFi created D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets.
Mar 15 2019, 11:56 AM · Restricted Project
CodaFi committed rG2f1ebe6ee81b: [LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C (authored by CodaFi).
[LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C
Mar 15 2019, 9:58 AM
CodaFi committed rL356272: [LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C.
[LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C
Mar 15 2019, 9:56 AM
CodaFi closed D58624: [LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C.
Mar 15 2019, 9:56 AM · Restricted Project

Feb 27 2019

CodaFi created D58733: [LLVM-C] Move and Clean Up The Instrumentation Pass Bindings.
Feb 27 2019, 12:06 PM · Restricted Project

Feb 25 2019

CodaFi created D58624: [LLVM-C] Expose the "Add Discriminators" Pass To LLVM-C.
Feb 25 2019, 7:30 AM · Restricted Project

Feb 17 2019

CodaFi added inline comments to D58334: [LLVM-C] Add bindings to create macro debug info.
Feb 17 2019, 8:48 PM · Restricted Project
CodaFi committed rGa82b613c8dee: [LLVM-C] Add bindings to create enumerators (authored by CodaFi).
[LLVM-C] Add bindings to create enumerators
Feb 17 2019, 1:26 PM
CodaFi committed rL354237: [LLVM-C] Add bindings to create enumerators.
[LLVM-C] Add bindings to create enumerators
Feb 17 2019, 1:25 PM
CodaFi closed D58323: [LLVM-C] Add bindings to create enumerators.
Feb 17 2019, 1:25 PM · Restricted Project
CodaFi added a comment to D58323: [LLVM-C] Add bindings to create enumerators.

I keep a running list of the APIs we have wrapped if that helps. I would love a hand getting us all the way there https://github.com/llvm-swift/LLVMSwift/issues/131

Feb 17 2019, 1:02 PM · Restricted Project

Feb 16 2019

CodaFi accepted D58323: [LLVM-C] Add bindings to create enumerators.

I concur. Looks good.

Feb 16 2019, 6:09 PM · Restricted Project

Feb 13 2019

CodaFi committed rG04306d62a032: Restore Check for Unreachable Exit Block in -Winfinite-recursion (authored by CodaFi).
Restore Check for Unreachable Exit Block in -Winfinite-recursion
Feb 13 2019, 2:23 PM
CodaFi committed rC353984: Restore Check for Unreachable Exit Block in -Winfinite-recursion.
Restore Check for Unreachable Exit Block in -Winfinite-recursion
Feb 13 2019, 2:22 PM
CodaFi committed rL353984: Restore Check for Unreachable Exit Block in -Winfinite-recursion.
Restore Check for Unreachable Exit Block in -Winfinite-recursion
Feb 13 2019, 2:22 PM
CodaFi closed D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion.
Feb 13 2019, 2:21 PM · Restricted Project, Restricted Project

Feb 12 2019

CodaFi created D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion.
Feb 12 2019, 7:39 AM · Restricted Project, Restricted Project

Feb 5 2019

CodaFi committed rGd5444ccf17cb: [LLVM-C] Add Bindings to GlobalIFunc (authored by CodaFi).
[LLVM-C] Add Bindings to GlobalIFunc
Feb 5 2019, 10:06 AM
CodaFi committed rL353193: [LLVM-C] Add Bindings to GlobalIFunc.
[LLVM-C] Add Bindings to GlobalIFunc
Feb 5 2019, 10:06 AM
CodaFi closed D56177: [LLVM-C] Add Bindings to GlobalIFunc.
Feb 5 2019, 10:05 AM · Restricted Project

Jan 25 2019

CodaFi added a comment to D56177: [LLVM-C] Add Bindings to GlobalIFunc.

@whitequark No worries. Always glad to have your review on these things since they can be hairy at times.

Jan 25 2019, 3:10 PM · Restricted Project

Jan 20 2019

CodaFi added a comment to D56177: [LLVM-C] Add Bindings to GlobalIFunc.

@whitequark Ping.

Jan 20 2019, 10:26 AM · Restricted Project

Jan 7 2019

CodaFi committed rL350608: [LLVM-C] Allow For Creating a BasicBlock without a Parent Function.
[LLVM-C] Allow For Creating a BasicBlock without a Parent Function
Jan 7 2019, 10:31 PM
CodaFi closed D56279: [LLVM-C] Allow For Creating a BasicBlock without a Parent Function.
Jan 7 2019, 10:30 PM
CodaFi committed rL350607: [LLVM-C] Allow Specifying Signedness in Int Cast.
[LLVM-C] Allow Specifying Signedness in Int Cast
Jan 7 2019, 10:30 PM
CodaFi closed D56280: [LLVM-C] Allow Specifying Signedness in Int Cast.
Jan 7 2019, 10:30 PM

Jan 3 2019

CodaFi created D56280: [LLVM-C] Allow Specifying Signedness in Int Cast.
Jan 3 2019, 10:55 AM
CodaFi updated the diff for D56279: [LLVM-C] Allow For Creating a BasicBlock without a Parent Function.
Jan 3 2019, 10:49 AM
CodaFi created D56279: [LLVM-C] Allow For Creating a BasicBlock without a Parent Function.
Jan 3 2019, 10:27 AM

Jan 2 2019

CodaFi committed rL350279: [LLVM-C] Expand LLVMRelocMode.
[LLVM-C] Expand LLVMRelocMode
Jan 2 2019, 4:37 PM
CodaFi closed D56187: [LLVM-C] Expand LLVMRelocMode.
Jan 2 2019, 4:37 PM

Jan 1 2019

CodaFi created D56187: [LLVM-C] Expand LLVMRelocMode.
Jan 1 2019, 11:12 AM
CodaFi committed rL350197: [LLVM-C] bool -> LLVMBool.
[LLVM-C] bool -> LLVMBool
Jan 1 2019, 11:07 AM
CodaFi committed rL350196: [LLVM-C] Add Accessors for Discarding Value Names in the IR.
[LLVM-C] Add Accessors for Discarding Value Names in the IR
Jan 1 2019, 11:01 AM
CodaFi closed D56179: [LLVM-C] Add Accessors for Discarding Value Names in the IR.
Jan 1 2019, 11:01 AM

Dec 31 2018

CodaFi created D56179: [LLVM-C] Add Accessors for Discarding Value Names in the IR.
Dec 31 2018, 12:48 PM
CodaFi created D56177: [LLVM-C] Add Bindings to GlobalIFunc.
Dec 31 2018, 12:03 PM · Restricted Project

Nov 8 2018

CodaFi added a comment to D52239: [OCaml] Add OCaml APIs to access DebugLoc info.

@whitequark I meant to comment here, I'm not sure how I wound up on that other issue. Reposting for visibility:

Nov 8 2018, 1:32 PM · Restricted Project

Nov 5 2018

CodaFi committed rL346197: [LLVM-C] Fix Windows Build of Core.
[LLVM-C] Fix Windows Build of Core
Nov 5 2018, 5:56 PM
CodaFi committed rL346195: [LLVM-C] Improve Intrinsics Bindings.
[LLVM-C] Improve Intrinsics Bindings
Nov 5 2018, 5:40 PM
CodaFi closed D53626: [LLVM-C] Improve Intrinsics Bindings.
Nov 5 2018, 5:40 PM
CodaFi added a comment to D53841: [OCaml] Fix incorrect use of CAMLlocal in nested blocks.

Apologies for not bringing this up in the earlier patch, but is there a reason this isn't using/building on the existing DI C bindings we have?

Nov 5 2018, 5:37 PM

Oct 29 2018

CodaFi updated the diff for D53626: [LLVM-C] Improve Intrinsics Bindings.
Oct 29 2018, 8:38 AM
CodaFi committed rL345508: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.
[LLVM-C] Add Builder Bindings to Common Memory Intrinsics
Oct 29 2018, 8:34 AM
CodaFi closed D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.
Oct 29 2018, 8:34 AM

Oct 23 2018

CodaFi added a comment to D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.

The infrastructure to test this isn't yet in place. I will merge accessors for MemSetBase and MemTransferBase in a later patch then special-case the echo test to call out to these build functions with those arguments. It's not a particularly attractive plan, but it should work fine.

Oct 23 2018, 5:49 PM
CodaFi created D53626: [LLVM-C] Improve Intrinsics Bindings.
Oct 23 2018, 5:36 PM

Oct 22 2018

CodaFi retitled D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics from [LLVM-C] Add Builder Bindings to Common Memory Intrinsic to [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.
Oct 22 2018, 9:55 PM
CodaFi created D53555: [LLVM-C] Add Builder Bindings to Common Memory Intrinsics.
Oct 22 2018, 9:55 PM

Oct 1 2018

CodaFi committed rL343469: [LLVM-C] Add an accessor for the kind of a Metadata Node.
[LLVM-C] Add an accessor for the kind of a Metadata Node
Oct 1 2018, 6:17 AM
CodaFi closed D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Oct 1 2018, 6:17 AM

Sep 29 2018

CodaFi added a comment to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.

@whitequark Done.

Sep 29 2018, 2:40 PM
CodaFi updated the diff for D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 2:24 PM
CodaFi added inline comments to D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 8:47 AM
CodaFi created D52693: [LLVM-C] Add an accessor for the kind of a Metadata Node.
Sep 29 2018, 8:38 AM

Sep 28 2018

CodaFi committed rL343363: [LLVM-C] Add an accessor for the "value type" of a global.
[LLVM-C] Add an accessor for the "value type" of a global
Sep 28 2018, 1:56 PM
CodaFi closed D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Sep 28 2018, 1:56 PM
CodaFi updated the summary of D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Sep 28 2018, 9:25 AM
CodaFi updated the summary of D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Sep 28 2018, 9:25 AM
CodaFi created D52659: [LLVM-C] Add an accessor for the "value type" of a global.
Sep 28 2018, 9:24 AM
CodaFi committed rL343334: [LLVM-C] Fix broken build bots.
[LLVM-C] Fix broken build bots
Sep 28 2018, 9:05 AM
CodaFi closed D52657: [LLVM-C] Fix broken build bots.
Sep 28 2018, 9:05 AM
CodaFi created D52657: [LLVM-C] Fix broken build bots.
Sep 28 2018, 9:00 AM
CodaFi committed rL343330: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
[LLVM-C] Add more debug information accessors to GlobalObject and Instruction
Sep 28 2018, 8:39 AM
CodaFi closed D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Sep 28 2018, 8:39 AM
CodaFi abandoned D46166: [LLVM-C] Add accessor to retrieve DINode's tag.

Abandoning this revision to keep it out of the review queue.

Sep 28 2018, 8:35 AM
CodaFi added a comment to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

@whitequark Ping

Sep 28 2018, 8:00 AM

Sep 10 2018

CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

The regression tests are only against the text of the driver's cc1 commands. It's not actually testing if we can compile.

Sep 10 2018, 5:36 PM
CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

@kristina They're having linker troubles because this driver is hardcoding an incorrect linker flag for libbuiltin on the arm-baremetal triple. D33259 introduced this behavior by smashing together the -lclang_rt.builtins-$ARCH flag with the proper resource-directory-relative absolute path <RESOURCE_DIR>/lib/libclang_rt.builtins-$ARCH.a which resulted in the incorrect flag -libclang_rt.builtins-$ARCH.a. With that path, the linker is going to try to look for "libclang_rt.builtins-$ARCH.a.a" in the link libraries search paths. The driver should be forming an exact path to this library relative to the resource directory. If users wish to override this behavior, they need to pass -nostdlib or -nodefaultlibs

Sep 10 2018, 5:32 PM
CodaFi added a comment to D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal..

Two things:

Sep 10 2018, 5:11 PM

Aug 31 2018

CodaFi updated the diff for D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Aug 31 2018, 10:22 AM

Aug 30 2018

CodaFi added a comment to D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.

How is a user of this API supposed to map the unsigned Kind values to something meaningful? We don't have an enum LLVMMetadataKind, do we?

Aug 30 2018, 8:40 PM
CodaFi created D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction.
Aug 30 2018, 4:03 PM
CodaFi committed rL341085: [LLVM-C] Add Bindings For Named Metadata.
[LLVM-C] Add Bindings For Named Metadata
Aug 30 2018, 10:13 AM
CodaFi closed D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 30 2018, 10:12 AM
CodaFi added a comment to D47179: [LLVM-C] Add Bindings For Named Metadata.

@whitequark Could I get another once-over on the C API here?

Aug 30 2018, 9:46 AM

Aug 27 2018

CodaFi updated the diff for D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 11:44 AM
CodaFi added inline comments to D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 11:36 AM
CodaFi added inline comments to D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 27 2018, 10:21 AM

Aug 25 2018

CodaFi updated the diff for D47179: [LLVM-C] Add Bindings For Named Metadata.

Spoke with @aprantl in person about this, and we came to the conclusion that named metadata nodes are different enough that the original TODO doesn't make any sense. For one, it would mean that you could use named metadata nodes to create more kinds of cycles. It would also mean the verifier would have to be extended to reject any usage of named metadata nodes as operand metadata.

Aug 25 2018, 4:33 PM
CodaFi updated the summary of D47179: [LLVM-C] Add Bindings For Named Metadata.
Aug 25 2018, 4:25 PM