Page MenuHomePhabricator
Feed Advanced Search

Nov 23 2021

sheldonneuberger-sc added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

Made suggested changes, ready for another review.

Nov 23 2021, 3:07 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • revert whitespace change
Nov 23 2021, 3:06 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • inline test helper for readability
  • fix indentation
Nov 23 2021, 3:03 PM · Restricted Project, Restricted Project

Nov 17 2021

sheldonneuberger-sc retitled D114058: [clangd] Add ObjC method support to prepareCallHierarchy from [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate to [clangd] Add ObjC method support to prepareCallHierarchy.
Nov 17 2021, 9:00 PM · Restricted Project, Restricted Project
sheldonneuberger-sc added a comment to D114058: [clangd] Add ObjC method support to prepareCallHierarchy.

Thanks for the detailed comments. I moved the patch into the clangd callsite. I also added a couple ObjC tests for CallHierarchy (I basically parameterized two of the existing tests).

Nov 17 2021, 8:36 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • fix test name
Nov 17 2021, 8:35 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • clang-format
Nov 17 2021, 8:32 PM · Restricted Project, Restricted Project
sheldonneuberger-sc updated the diff for D114058: [clangd] Add ObjC method support to prepareCallHierarchy.
  • move change to clangd callsite
  • add tests
Nov 17 2021, 8:31 PM · Restricted Project, Restricted Project

Nov 16 2021

sheldonneuberger-sc published D114058: [clangd] Add ObjC method support to prepareCallHierarchy for review.
Nov 16 2021, 11:24 PM · Restricted Project, Restricted Project