Page MenuHomePhabricator
Feed Advanced Search

Aug 5 2021

lunasorcery added a comment to D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag.

Yes, that would be "Luna Kirkby <llvm@moonbase.lgbt>"

Aug 5 2021, 2:41 PM · Restricted Project

Aug 4 2021

lunasorcery updated the diff for D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag.

Ah, that's much cleaner! I hadn't realized the test framework could do that.
I've updated the diff accordingly - your example works perfectly, so I've taken that and ditched the now-unnecessary other test.

Aug 4 2021, 4:45 PM · Restricted Project

Aug 2 2021

lunasorcery updated the diff for D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag.

How does this look? I've got a 'control' test to demonstrate the diagnostic as a child of ignored-qualifiers, as well as a test to demonstrate this diagnostic can be disabled in isolation.

Aug 2 2021, 2:52 PM · Restricted Project

Jul 31 2021

lunasorcery added a comment to D106349: [clang-format] respect AfterEnum for enums.

Copying over the comment I left on D99840 explaining it - my existing change only works because it gets bailed out by further code in TokenAnnotator.cpp.
I think your change still is valuable since it's more correct.

Jul 31 2021, 8:42 AM · Restricted Project

Jul 30 2021

lunasorcery added a comment to D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag.

Sure thing - would the suite in /clang/test/SemaCXX/ be the right place to put that?

Jul 30 2021, 2:59 PM · Restricted Project

Jul 29 2021

lunasorcery added a reviewer for D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag: aaron.ballman.
Jul 29 2021, 6:31 PM · Restricted Project
lunasorcery updated the summary of D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag.
Jul 29 2021, 6:15 PM · Restricted Project
lunasorcery requested review of D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag.
Jul 29 2021, 6:12 PM · Restricted Project
lunasorcery added a comment to D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled.

Looking at this again I think the change is flawed. The InitialToken is taken *after* the enum token, and additionally the invocation of ShouldBreakBeforeBrace is falling through to the return false; case every time. As such the call to addUnwrappedLine() is _always_ skipped. This removes the newline for both the Attach and Break styles - but the Break style is then fixed up by some code in TokenAnnotator.cpp that I don't fully understand, which adds the newline back in.

Jul 29 2021, 3:43 PM · Restricted Project, Restricted Project
lunasorcery added a comment to D106349: [clang-format] respect AfterEnum for enums.

Note also there's significant overlap with the now-committed D99840, though that's missing the change inside ShouldBreakBeforeBrace().
In retrospect I'm a little confused as to why D99840 appears to work without it.

Jul 29 2021, 1:14 PM · Restricted Project

Jul 27 2021

lunasorcery updated the diff for D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled.

Sorry it took me so long to get back to this - fell off my radar somewhat.
I've updated the release notes, I think it's ready to commit now?
I lack commit rights (first time contributor!) so for attribution it'd be "Luna Kirkby <llvm@moonbase.lgbt>"

Jul 27 2021, 4:35 PM · Restricted Project, Restricted Project

Apr 3 2021

lunasorcery requested review of D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled.
Apr 3 2021, 9:19 AM · Restricted Project, Restricted Project

Mar 30 2021

lunasorcery updated subscribers of D99618: Docs: Update dead links to SVN in Contributing.rst.

Looks like this has been separately addressed by @jroelofs, linking to the updated urls on the Phabricator rather than off-site to GitHub.

Mar 30 2021, 2:43 PM · Restricted Project