Page MenuHomePhabricator
Feed Advanced Search

Nov 15 2018

eklepilkina added a comment to D53565: Configure only needed part of test-suite during running subtests.

I tried out -DTEST_SUITE_SUBDIRS=SingleSource/Benchmarks/Misc. It gets the desired smaller build tree, but ends up missing lit.local.cfg in SingleSouce so the tests fail.

Nov 15 2018, 3:05 AM
eklepilkina updated the diff for D53565: Configure only needed part of test-suite during running subtests.
Nov 15 2018, 2:57 AM
eklepilkina updated the diff for D53565: Configure only needed part of test-suite during running subtests.
Nov 15 2018, 2:50 AM
eklepilkina added inline comments to D53565: Configure only needed part of test-suite during running subtests.
Nov 15 2018, 2:47 AM

Nov 14 2018

eklepilkina added a comment to D53565: Configure only needed part of test-suite during running subtests.

Please, could someone review these changes?
Or may be add other reviewers if I choose wrong people?

Nov 14 2018, 7:20 AM

Oct 23 2018

eklepilkina added a parent revision for D53568: [LNT] Setting CMake variable to support test-suite feature from D53565 : D53565: Configure only needed part of test-suite during running subtests.
Oct 23 2018, 6:31 AM
eklepilkina added a child revision for D53565: Configure only needed part of test-suite during running subtests: D53568: [LNT] Setting CMake variable to support test-suite feature from D53565 .
Oct 23 2018, 6:31 AM
eklepilkina created D53568: [LNT] Setting CMake variable to support test-suite feature from D53565 .
Oct 23 2018, 6:27 AM
eklepilkina added inline comments to D53565: Configure only needed part of test-suite during running subtests.
Oct 23 2018, 5:57 AM
eklepilkina created D53565: Configure only needed part of test-suite during running subtests.
Oct 23 2018, 5:53 AM

Sep 26 2016

eklepilkina added a comment to D22501: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.

This patch brings up a number of questions:

  1. What's your use case? Optimizing tests by replacing a known number of check lines with repeated patterns? Or is the number of patterns you expect not known in advance?

Both first and second case.

  1. Are there possible usages of this feature in LLVM tests already?

I don't know LLVM tests well to answer this question.

  1. How is this going to interact with [[@LINE]]?

I used FileCheck Match function in loop, so it will be real LINE value. I don't change matching.

Sep 26 2016, 12:02 AM
eklepilkina added a comment to D22501: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.
Sep 26 2016, 12:00 AM

Sep 25 2016

eklepilkina added inline comments to D22454: FileCheck Enhancement - repeats in regular expressions.
Sep 25 2016, 11:50 PM

Sep 19 2016

eklepilkina edited reviewers for D22503: FileCheck Enhancement - prefixes-regular expressions, added: alexfh; removed: dblaikie.
Sep 19 2016, 1:43 AM
eklepilkina edited reviewers for D22502: FileCheck Enhancement - CHECK-LABEL-DAG, added: alexfh; removed: dblaikie.
Sep 19 2016, 1:43 AM
eklepilkina edited reviewers for D22501: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT, added: alexfh; removed: dblaikie.
Sep 19 2016, 1:42 AM
eklepilkina edited reviewers for D22500: FileCheck Enhancement - Including files, added: alexfh; removed: dblaikie.
Sep 19 2016, 1:42 AM
eklepilkina edited reviewers for D22454: FileCheck Enhancement - repeats in regular expressions, added: alexfh; removed: dblaikie.
Sep 19 2016, 1:41 AM
eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

There is problem with STL, their realization of regular expressions doesn't match start and end of line in basic mode and there is no multiline mode. There is the issue 2343 in http://cplusplus.github.io/LWG/lwg-toc.html.
There is opportunity to split text by lines and match each line separately, but I think this is a hack, and I think it'll slow FileCheck.

Sep 19 2016, 12:28 AM

Sep 16 2016

eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

Ok, I'll try to use STL regex.

Sep 16 2016, 6:09 AM

Sep 15 2016

eklepilkina updated the diff for D22403: FileCheck Enhancement - pattern templates..

Patch without modifiers for pattern parameters and using pattern and variables inside definition of other patterns.

Sep 15 2016, 6:03 AM
eklepilkina added inline comments to D22403: FileCheck Enhancement - pattern templates..
Sep 15 2016, 1:47 AM

Sep 14 2016

eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

As I understood most of users prefer to change library to have support of \b assert. But, I think, this decision is quite important and can be made only by he contributor of FileCheck. I don't know how this suggestion can be done. Or I can try to change library and create a patch with this changes?

Sep 14 2016, 11:30 PM

Sep 13 2016

eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

What are our options with the regex library? Is there a newer version of the one we are currently using that we could upgrade to (and that supports \b)?

Sep 13 2016, 7:41 AM

Sep 10 2016

eklepilkina added a comment to D22403: FileCheck Enhancement - pattern templates..

Are quotes necessary for parameters? Everything is string in FileCheck.
Using patterns and variables was in old grammer. I thought that we only change syntax, so I added this feature too.
Ok, I'll remove this from this patch. But then I want to add using patterns and variables in definitions later. On my opinion these features are quite useful.

Sep 10 2016, 10:58 AM

Sep 8 2016

eklepilkina updated the diff for D22403: FileCheck Enhancement - pattern templates..

Change syntax to new one suggested by Vedant Kumar.

Sep 8 2016, 7:12 AM
eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

Why not add more words to check lines to make them more strict? BTW, does FileCheck support {{\b}}?

Sep 8 2016, 12:59 AM

Sep 1 2016

eklepilkina updated the diff for D22353: FileCheck Enhancement - CHECK-WORD.
Sep 1 2016, 1:28 AM
eklepilkina updated the diff for D22353: FileCheck Enhancement - CHECK-WORD.
Sep 1 2016, 12:26 AM

Jul 21 2016

eklepilkina added a comment to D22403: FileCheck Enhancement - pattern templates..

They are also both placeholders for a pattern. Can you give an example where it is useful to tell the difference between a use of a pattern and a use of a plain old variable? Does it make the test more readable?
I'm not saying that we have to share the syntax, but adding more syntax increases the cognitive load on testcase authors and we should make sure we are doing it for the right reasons.

Jul 21 2016, 11:55 PM
eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

I made new mode and made experiment turned it on for all LLVM tests.
Result:

Expected Passes    : 15810
Expected Failures  : 125
Unsupported Tests  : 195
Unexpected Passes  : 4
Unexpected Failures: 1128
Jul 21 2016, 1:42 AM
eklepilkina updated the diff for D22353: FileCheck Enhancement - CHECK-WORD.

Replace set of new CHECK directives to new -check-word option

Jul 21 2016, 1:30 AM

Jul 20 2016

eklepilkina added a comment to D22403: FileCheck Enhancement - pattern templates..

Is there a benefit in (or need for) distinguishing between variable uses and pattern uses, or could we piggyback the existing syntax?

There is difference between patterns and variables so we should understand where variable is, where pattern is.

As for pattern variables, I really think this review would benefit if we could split out pattern variables into a separate review. I didn't yet understand how pattern variables are supposed to work: Is \:(variable)\=(value) supposed to be an argument to a pattern use that immediately precedes it? Or is it modifying global state similar to regular variable definition in FileCheck? If the latter is the case, why does it come after the pattern in the example? In the former case, wouldn't it be better to have syntax that looks more like passing in an argument?

Jul 20 2016, 11:25 PM
eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

There is a suggestion to add new option, which will change standart behaviour to word-matchinf instead of addding new set of CHECKs directives. What about this idea?

Jul 20 2016, 6:57 AM
eklepilkina updated the diff for D22403: FileCheck Enhancement - pattern templates..
Jul 20 2016, 6:40 AM
eklepilkina added a comment to D22403: FileCheck Enhancement - pattern templates..

About syntax.
There is an idea to do as you advised.
Suggested new syntax:
[['#template_name]] - use of template 'template_name'. It can occur in CHECK-PATTERN line, when description of one template includes other templates described before. (Without quote, I don't know how escape # here)
[[:Variable_name]] - template variable with name 'variable_name'
[[:variable_name=value]] - current value of template variable(it's needed when you use template with variables).
Is this syntax better? Should I do such way?

Jul 20 2016, 6:29 AM
eklepilkina updated the diff for D22403: FileCheck Enhancement - pattern templates..
Jul 20 2016, 6:06 AM
eklepilkina added inline comments to D22403: FileCheck Enhancement - pattern templates..
Jul 20 2016, 6:03 AM
eklepilkina added inline comments to D22403: FileCheck Enhancement - pattern templates..
Jul 20 2016, 1:28 AM
eklepilkina added a comment to D22403: FileCheck Enhancement - pattern templates..

Using CHECK-lines to define meta-variables without checking anything diverges from FileCheck's usual behavior.

Jul 20 2016, 12:08 AM

Jul 19 2016

eklepilkina updated the diff for D22403: FileCheck Enhancement - pattern templates..
Jul 19 2016, 6:33 AM
eklepilkina updated subscribers of D22403: FileCheck Enhancement - pattern templates..
Jul 19 2016, 6:10 AM
eklepilkina added inline comments to D22403: FileCheck Enhancement - pattern templates..
Jul 19 2016, 6:09 AM
eklepilkina added inline comments to D22403: FileCheck Enhancement - pattern templates..
Jul 19 2016, 5:15 AM
eklepilkina abandoned D22401: FileCheck Enhancement - prefixes-regular expressions.
Jul 19 2016, 12:33 AM
eklepilkina retitled D22503: FileCheck Enhancement - prefixes-regular expressions from to FileCheck Enhancement - prefixes-regular expressions.
Jul 19 2016, 12:33 AM
eklepilkina updated the diff for D22353: FileCheck Enhancement - CHECK-WORD.
Jul 19 2016, 12:01 AM

Jul 18 2016

eklepilkina updated subscribers of D22353: FileCheck Enhancement - CHECK-WORD.
Jul 18 2016, 11:48 PM
eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

We won't know until somebody tries. It should not be too hard to do the experiment, I've done that kind of thing twice already.

Jul 18 2016, 11:47 PM
eklepilkina added inline comments to D22353: FileCheck Enhancement - CHECK-WORD.
Jul 18 2016, 11:42 PM
eklepilkina abandoned D22348: FileCheck Enhancement - CHECK-LABEL-DAG.
Jul 18 2016, 11:20 PM
eklepilkina retitled D22502: FileCheck Enhancement - CHECK-LABEL-DAG from to FileCheck Enhancement - CHECK-LABEL-DAG.
Jul 18 2016, 11:20 PM
eklepilkina abandoned D22345: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.
Jul 18 2016, 10:51 PM
eklepilkina retitled D22501: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT from to FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.
Jul 18 2016, 10:50 PM
eklepilkina abandoned D22344: FileCheck Enhancement - Including files.
Jul 18 2016, 10:47 PM
eklepilkina retitled D22500: FileCheck Enhancement - Including files from to FileCheck Enhancement - Including files.
Jul 18 2016, 10:46 PM
eklepilkina updated the diff for D22345: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.
Jul 18 2016, 6:14 AM
eklepilkina updated subscribers of D22345: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.
Jul 18 2016, 6:04 AM
eklepilkina updated the diff for D22344: FileCheck Enhancement - Including files.
Jul 18 2016, 5:32 AM
eklepilkina updated subscribers of D22344: FileCheck Enhancement - Including files.
Jul 18 2016, 5:04 AM
eklepilkina added inline comments to D22344: FileCheck Enhancement - Including files.
Jul 18 2016, 5:04 AM
eklepilkina abandoned D22342: FileCheck Enhancement - repeats in regular expressions.
Jul 18 2016, 1:22 AM
eklepilkina retitled D22454: FileCheck Enhancement - repeats in regular expressions from to FileCheck Enhancement - repeats in regular expressions.
Jul 18 2016, 1:22 AM

Jul 17 2016

eklepilkina abandoned D20668: FileCheck Enhancements.
Jul 17 2016, 10:52 PM

Jul 15 2016

eklepilkina added a comment to D22403: FileCheck Enhancement - pattern templates..

I'll glad if there will be some suggestions how make syntax better. The main idea of this syntax was to use characters with \ for avoiding escaping these characters in standart patterns.

Jul 15 2016, 2:40 AM
eklepilkina retitled D22403: FileCheck Enhancement - pattern templates. from to FileCheck Enhancement - pattern templates..
Jul 15 2016, 2:35 AM
eklepilkina added a comment to D22353: FileCheck Enhancement - CHECK-WORD.

"I think either users should use "\b" to check that the edge of the match is at the beginning/end of a word" - Problem is that current regexp library doesn't support \b assertion. And question about changing library appears again.
I think, if change the meaning of CHECK there will be a lot of work of changing LLVM tests and private tests of FileCheck users.

Jul 15 2016, 12:00 AM

Jul 14 2016

eklepilkina updated the diff for D22342: FileCheck Enhancement - repeats in regular expressions.
Jul 14 2016, 11:52 PM
eklepilkina added inline comments to D22342: FileCheck Enhancement - repeats in regular expressions.
Jul 14 2016, 11:51 PM
eklepilkina retitled D22401: FileCheck Enhancement - prefixes-regular expressions from to FileCheck Enhancement - prefixes-regular expressions.
Jul 14 2016, 11:33 PM
eklepilkina updated subscribers of D22353: FileCheck Enhancement - CHECK-WORD.
Jul 14 2016, 6:53 AM
eklepilkina retitled D22353: FileCheck Enhancement - CHECK-WORD from to FileCheck Enhancement - CHECK-WORD.
Jul 14 2016, 6:52 AM
eklepilkina retitled D22348: FileCheck Enhancement - CHECK-LABEL-DAG from to FileCheck Enhancement - CHECK-LABEL-DAG.
Jul 14 2016, 5:50 AM
eklepilkina retitled D22345: FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT from to FileCheck Enhancement - Expressions repeat for CHECK and CHECK-NEXT.
Jul 14 2016, 4:55 AM
eklepilkina updated D22344: FileCheck Enhancement - Including files.
Jul 14 2016, 3:16 AM
eklepilkina updated the diff for D22344: FileCheck Enhancement - Including files.
Jul 14 2016, 3:07 AM
eklepilkina retitled D22344: FileCheck Enhancement - Including files from to FileCheck Enhancement - Including files.
Jul 14 2016, 3:04 AM
eklepilkina retitled D22342: FileCheck Enhancement - repeats in regular expressions from to FileCheck Enhancement - repeats in regular expressions.
Jul 14 2016, 1:04 AM

May 26 2016

eklepilkina added reviewers for D20668: FileCheck Enhancements: probinson, jyknight, dblaikie, dexonsmith.
May 26 2016, 5:07 AM
eklepilkina retitled D20668: FileCheck Enhancements from to FileCheck Enhancements.
May 26 2016, 2:06 AM