Page MenuHomePhabricator
Feed Advanced Search

Today

mgorny updated the diff for D61074: [lldb] [lit] Add register read tests for YMM registers (AVX).

Added a 32-bit version of the test, and constexpr.

Thu, Apr 25, 1:11 PM
mgorny committed rG3bf8d7639f49: [lldb] [lit] Use constexpr and better constraints in Register tests (authored by mgorny).
[lldb] [lit] Use constexpr and better constraints in Register tests
Thu, Apr 25, 12:55 PM
mgorny committed rLLDB359228: [lldb] [lit] Use constexpr and better constraints in Register tests.
[lldb] [lit] Use constexpr and better constraints in Register tests
Thu, Apr 25, 12:55 PM
mgorny committed rL359228: [lldb] [lit] Use constexpr and better constraints in Register tests.
[lldb] [lit] Use constexpr and better constraints in Register tests
Thu, Apr 25, 12:55 PM
mgorny committed rG8879bba67981: [lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin (authored by mgorny).
[lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin
Thu, Apr 25, 11:37 AM
mgorny committed rL359221: [lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin.
[lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin
Thu, Apr 25, 11:36 AM
mgorny committed rLLDB359221: [lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin.
[lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin
Thu, Apr 25, 11:36 AM
mgorny committed rG19376ebd1aa0: [lldb] [lit] Add tests for reading new x86_64 registers (authored by mgorny).
[lldb] [lit] Add tests for reading new x86_64 registers
Thu, Apr 25, 10:44 AM
mgorny committed rGec3f09f30fb7: [lldb] [lit] Remove unnecessary array use in XMM reading test (authored by mgorny).
[lldb] [lit] Remove unnecessary array use in XMM reading test
Thu, Apr 25, 10:44 AM
mgorny committed rLLDB359210: [lldb] [lit] Add tests for reading new x86_64 registers.
[lldb] [lit] Add tests for reading new x86_64 registers
Thu, Apr 25, 10:43 AM
mgorny committed rL359210: [lldb] [lit] Add tests for reading new x86_64 registers.
[lldb] [lit] Add tests for reading new x86_64 registers
Thu, Apr 25, 10:43 AM
mgorny closed D61072: [lldb] [lit] Add tests for reading new x86_64 registers.
Thu, Apr 25, 10:43 AM · Restricted Project, Restricted Project
mgorny committed rLLDB359208: [lldb] [lit] Remove unnecessary array use in XMM reading test.
[lldb] [lit] Remove unnecessary array use in XMM reading test
Thu, Apr 25, 10:43 AM
mgorny committed rL359208: [lldb] [lit] Remove unnecessary array use in XMM reading test.
[lldb] [lit] Remove unnecessary array use in XMM reading test
Thu, Apr 25, 10:43 AM
mgorny closed D61085: [lldb] [lit] Remove unnecessary array use in XMM reading test.
Thu, Apr 25, 10:43 AM · Restricted Project
mgorny updated the diff for D61073: [lldb] [lit] Add feature flags for native CPU features.

Added warnings for missing or failed lit-cpuid. Not that there any failure conditions in the program right now ;-).

Thu, Apr 25, 10:39 AM
mgorny added a comment to D61074: [lldb] [lit] Add register read tests for YMM registers (AVX).

This test is pretty much a reimplementation of TestYMMRegisters dotest test. I like this one more for several reasons, but if we're going to check this in, we should also delete the other one.

Thu, Apr 25, 10:35 AM
mgorny added inline comments to D61073: [lldb] [lit] Add feature flags for native CPU features.
Thu, Apr 25, 9:27 AM
mgorny added inline comments to D61072: [lldb] [lit] Add tests for reading new x86_64 registers.
Thu, Apr 25, 9:13 AM · Restricted Project, Restricted Project

Yesterday

mgorny updated the diff for D61074: [lldb] [lit] Add register read tests for YMM registers (AVX).

Fixed unnecessary array in ymm_t decls.

Wed, Apr 24, 12:58 PM
mgorny updated the diff for D61072: [lldb] [lit] Add tests for reading new x86_64 registers.

Fixed unnecessary array in xmm_t decls.

Wed, Apr 24, 12:58 PM · Restricted Project, Restricted Project
mgorny created D61085: [lldb] [lit] Remove unnecessary array use in XMM reading test.
Wed, Apr 24, 12:58 PM · Restricted Project
mgorny added a child revision for D61073: [lldb] [lit] Add feature flags for native CPU features: D61074: [lldb] [lit] Add register read tests for YMM registers (AVX).
Wed, Apr 24, 8:56 AM
mgorny added a parent revision for D61074: [lldb] [lit] Add register read tests for YMM registers (AVX): D61073: [lldb] [lit] Add feature flags for native CPU features.
Wed, Apr 24, 8:56 AM
mgorny created D61074: [lldb] [lit] Add register read tests for YMM registers (AVX).
Wed, Apr 24, 8:56 AM
mgorny created D61073: [lldb] [lit] Add feature flags for native CPU features.
Wed, Apr 24, 8:53 AM
mgorny created D61072: [lldb] [lit] Add tests for reading new x86_64 registers.
Wed, Apr 24, 8:52 AM · Restricted Project, Restricted Project
mgorny added reviewers for D60942: Emit diagnostic if inline asm "n" constraint isn't an immediate: efriedma, rsmith.

I can confirm that it fixes our issue but I don't feel confident reviewing the code itself. Copying reviewers from the original diff.

Wed, Apr 24, 8:52 AM · Restricted Project

Thu, Apr 18

mgorny committed rG36d6bf8841c4: [lldb] [test] Mark three more tests flakey/xfail on NetBSD (authored by mgorny).
[lldb] [test] Mark three more tests flakey/xfail on NetBSD
Thu, Apr 18, 5:31 AM
mgorny committed rLLDB358660: [lldb] [test] Mark three more tests flakey/xfail on NetBSD.
[lldb] [test] Mark three more tests flakey/xfail on NetBSD
Thu, Apr 18, 5:31 AM
mgorny committed rL358660: [lldb] [test] Mark three more tests flakey/xfail on NetBSD.
[lldb] [test] Mark three more tests flakey/xfail on NetBSD
Thu, Apr 18, 5:31 AM

Wed, Apr 17

mgorny updated the diff for D60728: [clang] [test] Add a (xfailing) test for PR41027.

Updated per request.

Wed, Apr 17, 1:14 AM

Tue, Apr 16

mgorny added a comment to D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Tue, Apr 16, 10:12 AM
Herald added a project to D55616: Emit ASM input in a constant context: Restricted Project.

This change apparently introduced a regression: https://bugs.llvm.org/show_bug.cgi?id=41027

Tue, Apr 16, 12:24 AM · Restricted Project

Mon, Apr 15

mgorny created D60728: [clang] [test] Add a (xfailing) test for PR41027.
Mon, Apr 15, 11:28 AM

Sat, Apr 13

mgorny committed rGfb70bc65fe18: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test (authored by mgorny).
[lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test
Sat, Apr 13, 2:51 AM
mgorny committed rLLDB358329: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test.
[lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test
Sat, Apr 13, 2:50 AM
mgorny committed rL358329: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test.
[lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test
Sat, Apr 13, 2:50 AM
mgorny closed D60648: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test.
Sat, Apr 13, 2:50 AM · Restricted Project
mgorny created D60648: [lldb] [lit/SymbolFile] Avoid -nostdlib in target-symbols-add-unwind.test.
Sat, Apr 13, 1:14 AM · Restricted Project

Thu, Apr 11

mgorny committed rGa318a7f6651e: [lldb] [lit/Register] XFAIL on Darwin (authored by mgorny).
[lldb] [lit/Register] XFAIL on Darwin
Thu, Apr 11, 1:46 PM
mgorny committed rLLDB358224: [lldb] [lit/Register] XFAIL on Darwin.
[lldb] [lit/Register] XFAIL on Darwin
Thu, Apr 11, 1:46 PM
mgorny committed rL358224: [lldb] [lit/Register] XFAIL on Darwin.
[lldb] [lit/Register] XFAIL on Darwin
Thu, Apr 11, 1:46 PM
mgorny committed rGb971b5970907: [lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows (authored by mgorny).
[lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows
Thu, Apr 11, 9:05 AM
mgorny committed rLLDB358188: [lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows.
[lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows
Thu, Apr 11, 9:05 AM
mgorny committed rL358188: [lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows.
[lldb] [lit/Register] Mark x86-mm-xmm-read XFAIL on Windows
Thu, Apr 11, 9:05 AM
mgorny committed rG53373432cfc8: [lldb] [lit/Register] Fix test to use %clangxx (authored by mgorny).
[lldb] [lit/Register] Fix test to use %clangxx
Thu, Apr 11, 8:12 AM
mgorny committed rLLDB358184: [lldb] [lit/Register] Fix test to use %clangxx.
[lldb] [lit/Register] Fix test to use %clangxx
Thu, Apr 11, 8:12 AM
mgorny committed rL358184: [lldb] [lit/Register] Fix test to use %clangxx.
[lldb] [lit/Register] Fix test to use %clangxx
Thu, Apr 11, 8:11 AM
mgorny committed rG40733618bd27: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers (authored by mgorny).
[lldb] [Process/NetBSD] Fix wrongly mapping mm* registers
Thu, Apr 11, 7:58 AM
mgorny committed rG3ec58c4ef618: [llvm] [lit] Add target-x86* features (authored by mgorny).
[llvm] [lit] Add target-x86* features
Thu, Apr 11, 7:58 AM
mgorny committed rL358178: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
[lldb] [Process/NetBSD] Fix wrongly mapping mm* registers
Thu, Apr 11, 7:58 AM
mgorny committed rLLDB358178: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
[lldb] [Process/NetBSD] Fix wrongly mapping mm* registers
Thu, Apr 11, 7:58 AM
mgorny committed rL358177: [llvm] [lit] Add target-x86* features.
[llvm] [lit] Add target-x86* features
Thu, Apr 11, 7:58 AM
mgorny closed D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Thu, Apr 11, 7:58 AM · Restricted Project
mgorny closed D60474: [llvm] [lit] Add target-x86* features.
Thu, Apr 11, 7:58 AM · Restricted Project
mgorny added a comment to D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.

Will do, thanks.

Thu, Apr 11, 7:51 AM · Restricted Project

Wed, Apr 10

mgorny updated the diff for D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Wed, Apr 10, 1:13 AM · Restricted Project
mgorny updated the diff for D60474: [llvm] [lit] Add target-x86* features.
Wed, Apr 10, 1:13 AM · Restricted Project
mgorny added inline comments to D60474: [llvm] [lit] Add target-x86* features.
Wed, Apr 10, 1:09 AM · Restricted Project

Tue, Apr 9

mgorny added a child revision for D60474: [llvm] [lit] Add target-x86* features: D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Tue, Apr 9, 10:48 AM · Restricted Project
mgorny created D60474: [llvm] [lit] Add target-x86* features.
Tue, Apr 9, 10:48 AM · Restricted Project
mgorny added a parent revision for D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers: D60474: [llvm] [lit] Add target-x86* features.
Tue, Apr 9, 10:48 AM · Restricted Project
mgorny updated the diff for D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.

Updated 'REQUIRES'. I've looked through other LLVM tests, and noticed there's already 'native' concept (when host==target), and some 'target*' features for systems. I've chosen to combine the former with new 'target-x86'. I'll link the other patch in a minute.

Tue, Apr 9, 10:46 AM · Restricted Project

Mon, Apr 8

mgorny updated the diff for D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.

Rewritten the test to C++ with inline assembly, and switched to CHECK-DAG. Still need to figure out how to filter it for correct platform.

Mon, Apr 8, 11:18 AM · Restricted Project
mgorny added a comment to D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.

Thanks. I'll try converting it to C now.

Mon, Apr 8, 10:35 AM · Restricted Project
mgorny accepted D60046: [python, tests] Disable Clang Python tests on SPARC.

Thanks, looks good. Do you have commit access or do you need me to commit it for you?

Mon, Apr 8, 7:51 AM · Restricted Project

Fri, Apr 5

mgorny created D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Fri, Apr 5, 10:02 AM · Restricted Project
mgorny requested changes to D60046: [python, tests] Disable Clang Python tests on SPARC.

Just add it to the regex above.

Fri, Apr 5, 2:57 AM · Restricted Project

Thu, Apr 4

mgorny committed rG1f68002cb725: [llvm] [cmake] Add additional headers only if they exist (authored by mgorny).
[llvm] [cmake] Add additional headers only if they exist
Thu, Apr 4, 7:22 AM
mgorny committed rL357701: [llvm] [cmake] Add additional headers only if they exist.
[llvm] [cmake] Add additional headers only if they exist
Thu, Apr 4, 7:22 AM
mgorny closed D59632: [llvm] [cmake] Add additional headers only if they exist.
Thu, Apr 4, 7:21 AM · Restricted Project

Wed, Apr 3

mgorny added inline comments to D59632: [llvm] [cmake] Add additional headers only if they exist.
Wed, Apr 3, 11:31 PM · Restricted Project
mgorny added inline comments to D59632: [llvm] [cmake] Add additional headers only if they exist.
Wed, Apr 3, 10:06 AM · Restricted Project
mgorny added a comment to D59632: [llvm] [cmake] Add additional headers only if they exist.

Ping.

Wed, Apr 3, 8:49 AM · Restricted Project

Mon, Apr 1

mgorny committed rGd8519f4a7db9: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps (authored by mgorny).
[lldb] [Process/elf-core] Support aarch64 NetBSD core dumps
Mon, Apr 1, 8:08 AM
mgorny committed rL357399: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.
[lldb] [Process/elf-core] Support aarch64 NetBSD core dumps
Mon, Apr 1, 8:08 AM
mgorny committed rLLDB357399: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.
[lldb] [Process/elf-core] Support aarch64 NetBSD core dumps
Mon, Apr 1, 8:08 AM
mgorny closed D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.
Mon, Apr 1, 8:07 AM · Restricted Project

Sun, Mar 31

mgorny updated the diff for D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.

Reordered as requested.

Sun, Mar 31, 10:03 AM · Restricted Project

Sat, Mar 30

mgorny created D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.
Sat, Mar 30, 2:04 PM · Restricted Project

Fri, Mar 29

mgorny added a comment to D59972: [Python] Remove readline module.

WFM. We've been stripping it in Gentoo since the inception.

Fri, Mar 29, 12:00 AM · Restricted Project, Restricted Project

Tue, Mar 26

mgorny added a comment to D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary.

Is there a reason you can't reuse/extend DynamicLibrary from LLVMSupport?

Tue, Mar 26, 10:27 PM · Restricted Project

Mar 26 2019

mgorny added a comment to D59816: [Support] Implement zlib independent crc32 computation.

Is there really any good case to build LLVM without zlib? Maybe it'd be better to just require zlib unconditionally (or mark building it really unsupported) rather than bundling extra algorithms that will be used only conditionally (until someone mistakenly uses it unconditionally, and LLVM would start using different CRC32 impls in different places) like this.

Mar 26 2019, 7:21 AM · Restricted Project

Mar 25 2019

mgorny committed rGc5d7bc86b89d: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction (authored by mgorny).
[lldb] [Process/NetBSD] Use nullptr to fix template arg deduction
Mar 25 2019, 3:29 PM
mgorny committed rLLDB356960: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction.
[lldb] [Process/NetBSD] Use nullptr to fix template arg deduction
Mar 25 2019, 3:28 PM
mgorny committed rL356960: [lldb] [Process/NetBSD] Use nullptr to fix template arg deduction.
[lldb] [Process/NetBSD] Use nullptr to fix template arg deduction
Mar 25 2019, 3:28 PM

Mar 21 2019

mgorny committed rG2819136f0a3d: [lldb] Add missing EINTR handling (authored by mgorny).
[lldb] Add missing EINTR handling
Mar 21 2019, 12:37 PM
mgorny committed rLLDB356703: [lldb] Add missing EINTR handling.
[lldb] Add missing EINTR handling
Mar 21 2019, 12:36 PM
mgorny committed rL356703: [lldb] Add missing EINTR handling.
[lldb] Add missing EINTR handling
Mar 21 2019, 12:36 PM
mgorny closed D59606: [lldb] Add missing EINTR handling.
Mar 21 2019, 12:36 PM · Restricted Project, Restricted Project
mgorny added a comment to D59606: [lldb] Add missing EINTR handling.

Now, the curious thing is that so far I have 2 more test failures with this. I'll investigate closer, maybe it's just flakiness.

Mar 21 2019, 4:01 AM · Restricted Project, Restricted Project
mgorny added inline comments to D59606: [lldb] Add missing EINTR handling.
Mar 21 2019, 4:01 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Applied requested changes.

Mar 21 2019, 4:01 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Thanks for the review. Addressed comments.

Mar 21 2019, 1:39 AM · Restricted Project, Restricted Project
mgorny added inline comments to D59606: [lldb] Add missing EINTR handling.
Mar 21 2019, 1:39 AM · Restricted Project, Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Covered more callsites.

Mar 21 2019, 12:15 AM · Restricted Project, Restricted Project

Mar 20 2019

mgorny created D59632: [llvm] [cmake] Add additional headers only if they exist.
Mar 20 2019, 11:18 PM · Restricted Project
mgorny updated the diff for D59606: [lldb] Add missing EINTR handling.

Got rid of close() and fclose() wrapping, for now.

Mar 20 2019, 12:08 PM · Restricted Project, Restricted Project
mgorny added a comment to D59606: [lldb] Add missing EINTR handling.

Hmm, I also see that LLVM has signal-safe Process::SafelyCloseFileDescriptor(). Should I use that, or just ignore potential issues with close()?

Mar 20 2019, 11:58 AM · Restricted Project, Restricted Project