Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Feed Advanced Search

Jun 15 2017

zinob added a comment to D33653: [Polly] Iterate over explicit instruction list in CodeGen for block statements. NFC.

Why is Stmt.getInstruction() is introduced?

Jun 15 2017, 6:07 PM

Jan 10 2017

zinob added reviewers for D28493: [zorg] Add Polly builder for ARM target: fpetrogalli, kristof.beyls.
Jan 10 2017, 10:51 AM

Oct 20 2016

zinob added a comment to D25807: Check latch block terminator instruction is a branch instruction.

Yes unit test misses this path. I will try to narrow down a test for it.

Oct 20 2016, 10:28 AM

Oct 19 2016

zinob retitled D25807: Check latch block terminator instruction is a branch instruction from to Check latch block terminator instruction is a branch instruction.
Oct 19 2016, 5:13 PM

Apr 14 2016

zinob added a comment to D18878: [Polly] Allow overflow of indices with constant dimensions size.

looks good to me

Apr 14 2016, 9:49 AM · Restricted Project

Apr 13 2016

zinob added a comment to D14351: [Refactor] Replace RegionPasses by FunctionPasses.

Johannes, what is the motivation to have this past?

Apr 13 2016, 10:38 AM
zinob added a comment to D18878: [Polly] Allow overflow of indices with constant dimensions size.

What is the assume context? can we check them in the testcase?

Apr 13 2016, 10:24 AM · Restricted Project

Nov 30 2015

zinob added a comment to D14886: Fix the MSVC C compatibility of "inline" keyword in ISL.

Looks good to me.

Nov 30 2015, 12:16 PM

Mar 4 2015

zinob added a comment to D7986: [Refactor] Replace RegionPasses by FunctionPasses.

Ok we will post it shortly.

Mar 4 2015, 10:57 AM
zinob added a comment to D7986: [Refactor] Replace RegionPasses by FunctionPasses.

Johannes and Tobias,

Mar 4 2015, 10:18 AM