Page MenuHomePhabricator
Feed Advanced Search

Jun 11 2019

Meinersbur accepted D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

Shall I do it in the same patch, or can I do it in the next patch? I prefer to do it in the next patch just to keep patches as small as possible.

Jun 11 2019, 12:53 PM · Restricted Project
Meinersbur added inline comments to D63066: [Polly][NFC][ScopBuilder] Move getNonHoistableCtx to ScopBuilder.
Jun 11 2019, 12:53 PM · Restricted Project

Jun 10 2019

Meinersbur added a comment to D63035: LoopDistribute/LAA: Add tests to catch regressions.

As I understand the language reference, ("The optimizers may change the order of volatile operations relative to non-volatile operations.") the loop can be distributed as long as there all volatile operations stay in the same loop. I this is meant to test the current implementation, can you add a comment to make this clear (such as "TODO: distribution of volatile may be possible under some circumstance, but the current implementation does not touch them")

Jun 10 2019, 12:41 PM
Meinersbur requested changes to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

That's what I tried to do when always adding Polly.cpp to PollyCore, but it doesn't seem to be enough, I still need to invstigate why (it is actually enough when using BUILD_SHARED_LIBS=ON)

Jun 10 2019, 12:26 PM · Restricted Project, Restricted Project

Jun 7 2019

Meinersbur added a comment to D62989: [Unroll] Do NOT unroll a loop with small runtime upperbound.

Unwanted (or excessive) unrolling of loops with small runtime trip count upper bound.

Jun 7 2019, 4:41 PM · Restricted Project
Meinersbur requested changes to D62607: LoopDistribute/LAA: Respect convergent.
Jun 7 2019, 3:02 PM
Meinersbur accepted D63008: LoopDistribute: Add testcase where SCEV wants to insert a runtime check. .
Jun 7 2019, 2:49 PM
Meinersbur added a comment to D62989: [Unroll] Do NOT unroll a loop with small runtime upperbound.

What problem is this solving?

Jun 7 2019, 1:36 PM · Restricted Project
Meinersbur accepted D63016: LoopVersioning: Respect convergent.

Would an assertion in LoopVersioning checking whether it accidentally copies a convergent operation make sense?

Jun 7 2019, 1:10 PM
Meinersbur accepted D63015: LoopLoadElim: Respect convergent.

LGTM

Jun 7 2019, 1:06 PM

Jun 6 2019

Meinersbur updated the diff for D55290: [docs] Update llvm.loop metadata documentation..
Jun 6 2019, 11:59 AM · Restricted Project
Meinersbur added inline comments to D55290: [docs] Update llvm.loop metadata documentation..
Jun 6 2019, 11:59 AM · Restricted Project
Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in opt/bugpoint/clang by adding Polly.cpp as a source file or object library to the executables. This would guarantee that its static initializer is called without dynamic library.

Jun 6 2019, 11:42 AM · Restricted Project, Restricted Project
Meinersbur committed rGbd9e810b23b7: [ScheduleTreeTransform] Silence compiler warning. NFC. (authored by Meinersbur).
[ScheduleTreeTransform] Silence compiler warning. NFC.
Jun 6 2019, 10:16 AM
Meinersbur committed rL362724: [ScheduleTreeTransform] Silence compiler warning. NFC..
[ScheduleTreeTransform] Silence compiler warning. NFC.
Jun 6 2019, 10:16 AM
Meinersbur added a comment to D62925: [Polly][NFC][ScopBuilder] Move hoistInvariantLoads to ScopBuilder.

Can you move getNonHoistableCtx/addInvariantLoads to ScopBuilder as well? they contain logic only relevant for hoisting.

Jun 6 2019, 10:00 AM · Restricted Project

Jun 5 2019

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Sorry, you might have tested it with LLVM_LINK_POLLY_INTO_TOOLS=OFF and/or BUILD_SHARED_LIBS/LLVM_LINK_LLVM_DYLIV where it might work, but unfortunately not with the default configuration using static component libraries.

Jun 5 2019, 10:11 AM · Restricted Project, Restricted Project
Meinersbur requested changes to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Jun 5 2019, 10:04 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

This fails with Polly/Linux regression tests:

********************
FAIL: Polly :: Simplify/gemm.ll (1148 of 1149)
******************** TEST 'Polly :: Simplify/gemm.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   opt  -polly-process-unprofitable  -polly-remarks-minimal  -polly-use-llvm-names  -polly-import-jscop-dir=/home/meinersbur/src/llvm/tools/polly/test/Simplify  -polly-codegen-verify  -polly-import-jscop    -polly-import-jscop-postfix=transformed -polly-simplify -analyze < /home/meinersbur/src/llvm/tools/polly/test/Simplify/gemm.ll    | FileCheck /home/meinersbur/src/llvm/tools/polly/test/Simplify/gemm.ll
--
Exit Code: 2
Jun 5 2019, 10:04 AM · Restricted Project, Restricted Project

Jun 4 2019

Meinersbur committed rG06c801e15334: [ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo. NFC. (authored by Meinersbur).
[ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo. NFC.
Jun 4 2019, 2:57 PM
Meinersbur committed rL362554: [ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo. NFC..
[ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo. NFC.
Jun 4 2019, 2:56 PM
Meinersbur closed D62781: [Polly][NFC][ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo.
Jun 4 2019, 2:56 PM · Restricted Project

Jun 3 2019

Meinersbur accepted D62781: [Polly][NFC][ScopBuilder] Move canonicalizeDynamicsBasePtrs from ScopInfo.

Do you want me to commit?

Jun 3 2019, 3:35 PM · Restricted Project
Meinersbur requested changes to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

It still fails with the same error. LINK_POLLY_INTO_TOOLS is only set after the polly subdirectory is processed. Because it is an option, the ON value will be stored in the CMakeCache.txt and be available during the next run, it actually works after running the cmake configure step a second time. We should not expect users to do so. Because of this, any option(...) or set(... CACHED) should be done at the beginning of the file.

Jun 3 2019, 3:09 PM · Restricted Project, Restricted Project

May 31 2019

Meinersbur committed rGc16ab9dd8869: [ScopBuilder] Move verifyInvariantLoads function from ScopInfo. NFC. (authored by Meinersbur).
[ScopBuilder] Move verifyInvariantLoads function from ScopInfo. NFC.
May 31 2019, 12:39 PM
Meinersbur committed rL362258: [ScopBuilder] Move verifyInvariantLoads function from ScopInfo. NFC..
[ScopBuilder] Move verifyInvariantLoads function from ScopInfo. NFC.
May 31 2019, 12:39 PM
Meinersbur closed D62628: [Polly][NFC][ScopBuilder] Move verifyInvariantLoads function from ScopInfo.
May 31 2019, 12:39 PM · Restricted Project
Meinersbur committed rGaa8a976174c7: [ScheduleOptimizer] Hoist extension nodes after schedule optimization. (authored by Meinersbur).
[ScheduleOptimizer] Hoist extension nodes after schedule optimization.
May 31 2019, 12:25 PM
Meinersbur committed rL362257: [ScheduleOptimizer] Hoist extension nodes after schedule optimization..
[ScheduleOptimizer] Hoist extension nodes after schedule optimization.
May 31 2019, 12:24 PM
Meinersbur closed D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..
May 31 2019, 12:24 PM · Restricted Project

May 30 2019

Meinersbur accepted D62610: [DA] Add an option to control delinearization validity checks.
May 30 2019, 2:14 PM · Restricted Project
Meinersbur accepted D62628: [Polly][NFC][ScopBuilder] Move verifyInvariantLoads function from ScopInfo.

Do you want me to commit?

May 30 2019, 2:02 PM · Restricted Project

May 29 2019

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

For LTO, the llvm_extensions might need to be linked into lld as well. The recent polly-dev thread: https://groups.google.com/d/msg/polly-dev/BeC_v_oJIVM/LAA7vVT9AwAJ

May 29 2019, 1:38 PM · Restricted Project, Restricted Project
Meinersbur accepted D62587: LoopVersioningLICM: Respect convergent.

LGTM

May 29 2019, 12:53 PM
Meinersbur added inline comments to D62607: LoopDistribute/LAA: Respect convergent.
May 29 2019, 10:03 AM

May 28 2019

Meinersbur committed rG26212da5553a: [ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo. NFC. (authored by Meinersbur).
[ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo. NFC.
May 28 2019, 4:46 PM
Meinersbur committed rL361902: [ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo. NFC..
[ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo. NFC.
May 28 2019, 4:45 PM
Meinersbur closed D62351: [Polly][NFC][ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo.
May 28 2019, 4:45 PM · Restricted Project
Meinersbur accepted D62351: [Polly][NFC][ScopBuilder] Move buildInvariantEquivalenceClasses function from ScopInfo.

LGTM. Thanks for the patch.

May 28 2019, 11:54 AM · Restricted Project
Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Fail the regression tests under Linux:

May 28 2019, 9:37 AM · Restricted Project, Restricted Project

May 22 2019

Meinersbur added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
  1. I too think it likely makes sense to adjust them all eventually. But do people think it's important to write patches adjusting all pragmas before pushing the adjustment for any of them?

I am not sure I understand. Do you mean whether you need all patches for each pragma to be accepted before you can commit the first? This is not that case.

@lebedev.ri expressed concern that it might not be acceptable to migrate all pragmas in the same way. That would suggest we must handle them all before committing any.

IMHO you can even put all of it into a single patch as it should be very straightforward. The most work is adapting the tests.

I would think different people would want to review different pragmas, so separate patches would be better, but I'm happy to be corrected as I haven't explored who owns what here.

May 22 2019, 12:36 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D62265: [ScopBuilder] Move buildContext function from ScopInfo.

Thank you for your contribution. A few remarks for your first upload for Polly on Phabricator:

May 22 2019, 12:20 PM · Restricted Project
Meinersbur added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
  1. I too think it likely makes sense to adjust them all eventually. But do people think it's important to write patches adjusting all pragmas before pushing the adjustment for any of them?
May 22 2019, 9:33 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D61509: [OpenMP] Set pragma start loc to `#pragma` loc.
  1. Is there a diagnostic that would point to the omp token? As much as I like complete info (such as SourceLoc of semicolons), I cannot think of a use case for it.
  2. I would like to see all of them all adjusted. There is an immediate improvement in that improves the diagnostic output.
May 22 2019, 9:05 AM · Restricted Project, Restricted Project

May 21 2019

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

This didn't work for me, neither on Windows nor on Linux.

May 21 2019, 4:25 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D61643: [PragmaHandler] Expose `#pragma` location.

Such a solution also came up in https://bugs.llvm.org/show_bug.cgi?id=41514#c1

May 21 2019, 12:48 PM · Restricted Project
Meinersbur committed rG467069688d0a: [DeLICM] Use polly::singleton to allow empty result. (authored by Meinersbur).
[DeLICM] Use polly::singleton to allow empty result.
May 21 2019, 12:21 PM
Meinersbur committed rL361290: [DeLICM] Use polly::singleton to allow empty result..
[DeLICM] Use polly::singleton to allow empty result.
May 21 2019, 12:20 PM
Meinersbur accepted D61081: LLVM OpenMP Backend -- Fix "static chunked" scheduling.

LGTM. Can I commit for you?

May 21 2019, 11:40 AM · Restricted Project

May 20 2019

Meinersbur committed rGc4c679c2324b: [CodeGen] Fix order of PHINode and MA Write generation. (authored by Meinersbur).
[CodeGen] Fix order of PHINode and MA Write generation.
May 20 2019, 3:29 PM
Meinersbur committed rGac5c8318d769: [DependenceInfo] Remove dead initialization. NFC. (authored by Meinersbur).
[DependenceInfo] Remove dead initialization. NFC.
May 20 2019, 1:53 PM
Meinersbur committed rL361196: [DependenceInfo] Remove dead initialization. NFC..
[DependenceInfo] Remove dead initialization. NFC.
May 20 2019, 1:51 PM

May 10 2019

Meinersbur committed rG2698390c68b5: [ZoneAlgo] Fix PHI inconsistency in invalid contexts. (authored by Meinersbur).
[ZoneAlgo] Fix PHI inconsistency in invalid contexts.
May 10 2019, 11:37 AM
Meinersbur committed rL360454: [ZoneAlgo] Fix PHI inconsistency in invalid contexts..
[ZoneAlgo] Fix PHI inconsistency in invalid contexts.
May 10 2019, 11:37 AM

May 9 2019

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur, I've tested and reviewed this patch, I'm curious about Polly's team opinion on the changes in current state?

May 9 2019, 8:33 PM · Restricted Project, Restricted Project

May 2 2019

Meinersbur added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Do you intent to use this interface for a specific external project, or is it to avoid direct references to Polly?

May 2 2019, 8:07 PM · Restricted Project, Restricted Project

Apr 30 2019

Meinersbur added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Generally, I'd prefer to use ScalarEvolution over inspecting (and expecting specific) instructions in a loop, whenever possible. Some canonicalization passes are designed for this. In particular, IndVarSimplify used to make canonical loops (i.e. start at zero, increment by one). r133502 introduced -disable-iv-rewrite to rely more on ScalarEvolution instead of "opcode/pattern matching" (cite from the commit message). -enable-iv-rewrite=false was made the default in r139579 after finding that it slows down many benchmarks. It was completely removed in r153260.

Apr 30 2019, 1:07 PM · Restricted Project
Meinersbur added reviewers for D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only: homerdin, MatzeB.
Apr 30 2019, 11:19 AM · Restricted Project
Meinersbur added a comment to D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only.

llvm_multisource has an option "PREFIX" that can be used to disambiguate target names. However, in my experience when using it collecting metrics does not work as reliable with this options.

Apr 30 2019, 11:19 AM · Restricted Project

Apr 24 2019

Meinersbur added a comment to D61091: Enable LoopVectorization by default..

Having both -- -disable-loop-vectorization and -vectorize-loops -- is somewhat confusing. Could we have a tri-state cl::opt which, when not specified, uses OptLevel > 1 && SizeLevel < 2 dis-/enable the vectorizer? Similar to -disable-loop-unrolling.

Apr 24 2019, 4:27 PM · Restricted Project
Meinersbur added inline comments to D61081: LLVM OpenMP Backend -- Fix "static chunked" scheduling.
Apr 24 2019, 12:49 PM · Restricted Project

Apr 23 2019

Meinersbur accepted D61035: Fix unused variable warning in LoopFusion pass.

LGTM

Apr 23 2019, 2:37 PM · Restricted Project

Apr 19 2019

Meinersbur added inline comments to D55851: Implement basic loop fusion pass.
Apr 19 2019, 9:05 AM · Restricted Project

Apr 18 2019

Meinersbur added inline comments to D59723: [NewPassManager] Adding pass tuning options: loop vectorize..
Apr 18 2019, 10:41 AM · Restricted Project
Meinersbur added a comment to D60872: Add new warning knob for unknown attribute namespaces.

Thanks for coming up with this patch.

Apr 18 2019, 10:22 AM

Apr 16 2019

Meinersbur added inline comments to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..
Apr 16 2019, 5:26 PM · Restricted Project
Meinersbur committed rGf73bba3b1409: [Test] Remove obsolete test. (authored by Meinersbur).
[Test] Remove obsolete test.
Apr 16 2019, 9:44 AM
Meinersbur committed rL358507: [Test] Remove obsolete test..
[Test] Remove obsolete test.
Apr 16 2019, 9:43 AM
Meinersbur committed rC358507: [Test] Remove obsolete test..
[Test] Remove obsolete test.
Apr 16 2019, 9:43 AM
Meinersbur closed D60749: [Test] Remove obsolete test..
Apr 16 2019, 9:43 AM · Restricted Project
Meinersbur added a comment to D55290: [docs] Update llvm.loop metadata documentation..

ping

Apr 16 2019, 9:31 AM · Restricted Project
Meinersbur added a comment to D58202: [Polly][ScheduleOptimizer] Hoist extension nodes after schedule optimization..

ping

Apr 16 2019, 9:30 AM · Restricted Project
Meinersbur added a comment to D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, and loop induction variable..

Are you planning to add more users of this interface?

Apr 16 2019, 8:45 AM · Restricted Project

Apr 15 2019

Meinersbur created D60749: [Test] Remove obsolete test..
Apr 15 2019, 8:24 PM · Restricted Project

Apr 11 2019

Meinersbur added a comment to D51963: [Polly] Really fix Windows builds..

When applying this patch to the current trunk, I get:

CMake Error at tools/polly/lib/CMakeLists.txt:116 (add_llvm_loadable_module):
  Unknown CMake command "add_llvm_loadable_module".
Apr 11 2019, 2:27 PM · Restricted Project
Meinersbur accepted D55851: Implement basic loop fusion pass.

Generally, LGTM; with some smaller suggestions.

Apr 11 2019, 12:00 PM · Restricted Project

Apr 5 2019

Meinersbur added a comment to D60266: [LoopUnroll] Rotate loop, when optimizing for size and can fully unroll a loop..

Like D59832, #pragma clang loop unroll/#pragma unroll might require a loop rotation as well to successfully unroll?

Apr 5 2019, 6:28 AM · Restricted Project

Apr 1 2019

Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

@dmgreen Thank you for the review!

Apr 1 2019, 11:41 AM · Restricted Project, Restricted Project
Meinersbur committed rG58e7642669bf: [CodeGen] Generate follow-up metadata for loops with more than one… (authored by Meinersbur).
[CodeGen] Generate follow-up metadata for loops with more than one…
Apr 1 2019, 10:51 AM
Meinersbur committed rL357415: [CodeGen] Generate follow-up metadata for loops with more than one….
[CodeGen] Generate follow-up metadata for loops with more than one…
Apr 1 2019, 10:50 AM
Meinersbur committed rC357415: [CodeGen] Generate follow-up metadata for loops with more than one….
[CodeGen] Generate follow-up metadata for loops with more than one…
Apr 1 2019, 10:50 AM
Meinersbur closed D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..
Apr 1 2019, 10:50 AM · Restricted Project, Restricted Project

Mar 28 2019

Meinersbur committed rG031bb1655664: Apply include-what-you-use #include removal suggestions. NFC. (authored by Meinersbur).
Apply include-what-you-use #include removal suggestions. NFC.
Mar 28 2019, 1:19 PM
Meinersbur committed rL357209: Apply include-what-you-use #include removal suggestions. NFC..
Apply include-what-you-use #include removal suggestions. NFC.
Mar 28 2019, 1:18 PM

Mar 27 2019

Meinersbur added a comment to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.

If you feel strongly about this I can explore rotating the loop in the vectorizer when I have a bit more time.

Mar 27 2019, 10:07 AM · Restricted Project
Meinersbur added a comment to D59832: [LoopRotation] Allow loop header duplication if vectorization is forced.

This might be a more general problem, other passes might expect a normalized form as well, such as UnrollAndJam and LoopDistribute.

Mar 27 2019, 9:00 AM · Restricted Project

Mar 26 2019

Meinersbur committed rOMP356998: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
[libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option.
Mar 26 2019, 8:19 AM
Meinersbur committed rGd97d5ebcfa4b: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option. (authored by Meinersbur).
[libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option.
Mar 26 2019, 8:19 AM
Meinersbur added a comment to D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..

@grokos Thank you for the review!

Mar 26 2019, 8:19 AM · Restricted Project, Restricted Project
Meinersbur committed rL356998: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
[libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option.
Mar 26 2019, 8:18 AM
Meinersbur closed D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
Mar 26 2019, 8:17 AM · Restricted Project, Restricted Project

Mar 25 2019

Meinersbur added a comment to D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.

Done. Thanks for the patch!

Mar 25 2019, 4:30 PM · Restricted Project, Restricted Project
Meinersbur committed rGea40d5b05b8b: Moving ManagedMemoryRewritePass when hybrid option is selected (authored by Meinersbur).
Moving ManagedMemoryRewritePass when hybrid option is selected
Mar 25 2019, 4:26 PM
Meinersbur committed rL356965: Moving ManagedMemoryRewritePass when hybrid option is selected.
Moving ManagedMemoryRewritePass when hybrid option is selected
Mar 25 2019, 4:26 PM
Meinersbur closed D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.
Mar 25 2019, 4:26 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

This could maybe do with a few extra tests. Am I correct in saying something like this:

#pragma unroll_and_jam(4)
for(int j = 0; j < n; j++) {
  #pragma unroll(4)
  for(int k = 0; k < n; k++) {
    x[j*n+k] = 10;
  }
}

would end up with a llvm.loop.unroll_and_jam.followup_inner with a llvm.loop.unroll_count?

Mar 25 2019, 1:41 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..
  • Rebase
  • Add two test cases for all attributes combined (as inner and outer loop for of an unroll-and-jam)
  • Of two nested unroll-and-jams, apply the inner first
  • Typos and comment clarification
  • Add missing llvm.loop.isvectorized when attributes are split between BeforeJam and AfterJam
Mar 25 2019, 1:39 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D59263: Moving ManagedMemoryRewritePass when hybrid option is selected.

Do you need help with landing the patch?

Mar 25 2019, 9:08 AM · Restricted Project, Restricted Project

Mar 24 2019

Meinersbur added inline comments to D55952: [libomptarget] Introduce LIBOMPTARGET_ENABLE_DEBUG cmake option..
Mar 24 2019, 1:28 PM · Restricted Project, Restricted Project

Mar 19 2019

Meinersbur added a comment to D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation..

ping

Mar 19 2019, 1:50 PM · Restricted Project, Restricted Project