Page MenuHomePhabricator
Feed Advanced Search

Today

Meinersbur committed rG62afc3129dc2: [flang][msvc] Explicitly reference "this" inside closure. NFC. (authored by Meinersbur).
[flang][msvc] Explicitly reference "this" inside closure. NFC.
Tue, Sep 22, 12:23 PM
Meinersbur committed rG97ca41e1ddfb: [flang][msvc] Add explicit function template argument to applyLamda. NFC. (authored by Meinersbur).
[flang][msvc] Add explicit function template argument to applyLamda. NFC.
Tue, Sep 22, 12:23 PM
Meinersbur committed rG2bc589bbb8d7: [flang][msvc] Add explicit function template argument to applyFunction. NFC. (authored by Meinersbur).
[flang][msvc] Add explicit function template argument to applyFunction. NFC.
Tue, Sep 22, 12:23 PM
Meinersbur closed D88052: [flang][msvc] Explicitly reference "this" inside closure. NFC..
Tue, Sep 22, 12:23 PM · Restricted Project, Restricted Project
Meinersbur closed D88001: [flang][msvc] Add explicit function template argument to applyLamda. NFC..
Tue, Sep 22, 12:23 PM · Restricted Project
Meinersbur closed D87961: [flang][msvc] Add explicit function template argument to applyFunction. NFC..
Tue, Sep 22, 12:22 PM · Restricted Project, Restricted Project
Meinersbur accepted D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().
Tue, Sep 22, 12:13 PM · Restricted Project
Meinersbur added a comment to D88109: [flang][msvc] Avoid ReferenceVariantBase ctor ambiguity. NFC..

Microsoft bug report: https://developercommunity.visualstudio.com/content/problem/1193950/ambiguous-constructor-in-vector-copy.html

Tue, Sep 22, 11:40 AM · Restricted Project, Restricted Project
Meinersbur requested review of D88109: [flang][msvc] Avoid ReferenceVariantBase ctor ambiguity. NFC..
Tue, Sep 22, 11:39 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D76342: [OpenMP] Implement '#pragma omp tile'.

Thank you

Tue, Sep 22, 6:54 AM · Restricted Project, Restricted Project

Yesterday

Meinersbur added a comment to D88052: [flang][msvc] Explicitly reference "this" inside closure. NFC..

Visual Studio bug report: https://developercommunity.visualstudio.com/content/problem/1192775/ambiguous-constnon-const-method-call-in-implicit-t.html

Mon, Sep 21, 5:36 PM · Restricted Project, Restricted Project
Meinersbur requested review of D88052: [flang][msvc] Explicitly reference "this" inside closure. NFC..
Mon, Sep 21, 3:40 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D87328: [Polly][NewPM] Port Simplify to the new pass manager.

Thank you

Mon, Sep 21, 10:50 AM · Restricted Project
Meinersbur requested review of D88001: [flang][msvc] Add explicit function template argument to applyLamda. NFC..
Mon, Sep 21, 12:06 AM · Restricted Project

Sun, Sep 20

Meinersbur accepted D87328: [Polly][NewPM] Port Simplify to the new pass manager.

A single test test file would be enough to check that the new pass manager pipeline is working. Checking all tests with both pass manager doubles the execution time for check-polly without improving test coverage. There are not too many tests for the simplify pass, but please consider testing it only once with the scalability tests, as these take the most time.

Sun, Sep 20, 5:57 PM · Restricted Project
Meinersbur added inline comments to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().
Sun, Sep 20, 5:50 PM · Restricted Project

Fri, Sep 18

Meinersbur requested review of D87961: [flang][msvc] Add explicit function template argument to applyFunction. NFC..
Fri, Sep 18, 11:35 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

@baziotis Are you going to update this diff?

Fri, Sep 18, 11:27 PM · Restricted Project
Meinersbur added a comment to D87328: [Polly][NewPM] Port Simplify to the new pass manager.

Could you add a test that invokes the pass with the new pass manage? E.g. take an existing test for the SimplifyPass, and add a RUN: line that does the same thing with NPM?

Fri, Sep 18, 11:22 PM · Restricted Project

Thu, Sep 17

Meinersbur accepted D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..
Thu, Sep 17, 10:17 AM · Restricted Project
Meinersbur added a comment to D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..

Thanks for the fix!

Thu, Sep 17, 10:17 AM · Restricted Project

Wed, Sep 16

Meinersbur committed rGdee468622784: [flang][msvc] Work around if constexpr (false) evaluation. NFC. (authored by Meinersbur).
[flang][msvc] Work around if constexpr (false) evaluation. NFC.
Wed, Sep 16, 1:02 PM
Meinersbur closed D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC..
Wed, Sep 16, 1:01 PM · Restricted Project
Meinersbur added a comment to D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC..

Thank you.

Wed, Sep 16, 1:01 PM · Restricted Project
Meinersbur added a comment to D87786: [LoopUnrollAndJam] Allow unroll and jam loops forced by user..

Why is this specific to the PowerPC-backend. Doesn't the LoopUnrollAndJamPass pick-up the transformation metadata already?

Wed, Sep 16, 12:49 PM · Restricted Project
Meinersbur added a comment to D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC..

Do you have a suggestion for a large Fortran file that I could measure? I think my measurements would not be accurate enough to show a difference between inlining and non-inlining of this function. If you know how to do it yourself, I would be grateful.

Wed, Sep 16, 9:04 AM · Restricted Project

Tue, Sep 15

Meinersbur added a comment to D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC..

The function should be inlined, in which case there is no performance difference.

Tue, Sep 15, 5:18 PM · Restricted Project
Meinersbur added a comment to D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC..

Microsoft bug report: https://developercommunity.visualstudio.com/content/problem/1185857/if-constexpr-false-body-evaluated-in-variadic-temp.html

Tue, Sep 15, 4:23 PM · Restricted Project
Meinersbur requested review of D87728: [flang][msvc] Work around if constexpr (false) evaluation. NFC..
Tue, Sep 15, 4:22 PM · Restricted Project
Meinersbur added a comment to D87524: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows.

Thank you for the patch!

Tue, Sep 15, 8:05 AM · Restricted Project, Restricted Project

Sun, Sep 13

Meinersbur added a comment to D87524: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows.

I was thinking about something that explains the difference between the state before and after the patch.

Sun, Sep 13, 3:48 PM · Restricted Project, Restricted Project

Fri, Sep 11

Meinersbur accepted D87524: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows.

Could you fix the title+description? It fixes that the limitation is imposed by Windows, not by the MSVC compiler. Cygwin would be affected as well.

Fri, Sep 11, 4:44 PM · Restricted Project, Restricted Project

Tue, Sep 8

Meinersbur committed rGc58dfbdc8182: [flang][msvc] Avoid range-based for over initializer_list. NFC. (authored by Meinersbur).
[flang][msvc] Avoid range-based for over initializer_list. NFC.
Tue, Sep 8, 10:23 PM
Meinersbur closed D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC..
Tue, Sep 8, 10:22 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC..

Apply @tskeith's style recommendation

Tue, Sep 8, 7:58 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D76342: [OpenMP] Implement '#pragma omp tile'.

Rebase after D83261

Tue, Sep 8, 6:11 PM · Restricted Project, Restricted Project
Meinersbur accepted D87329: Insert missing bracket in docs..

Thanks for catching.

Tue, Sep 8, 2:48 PM · Restricted Project

Tue, Sep 1

Meinersbur abandoned D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

Yes, abandon in favor of D86551.

Tue, Sep 1, 3:58 PM · Restricted Project, Restricted Project
Meinersbur committed rG137dfd616aaf: [LangRef] Fix condition for when a loop is considered parallel. (authored by Meinersbur).
[LangRef] Fix condition for when a loop is considered parallel.
Tue, Sep 1, 1:42 PM
Meinersbur closed D83781: [LangRef] Fix condition for when a loop is considered parallel..
Tue, Sep 1, 1:42 PM · Restricted Project

Mon, Aug 31

Meinersbur accepted D86551: [flang] Make `TypeParamInquiry` monomorphic.

As much as I can say without having a lot of experience with the flang codebase, this looks good to me.

Mon, Aug 31, 1:26 PM · Restricted Project, Restricted Project

Wed, Aug 26

Meinersbur accepted D85627: [polly][cmake] Don't build LLVMPolly.so without PIC.
In D85627#2226214, @ro wrote:

What do you mean by intended solution? My intent was to avoid breaking the build with PIC code turned off. Just as Windows doesn't support loadable modules and thus creation of LLVMPolly.so is disabled, it's just not possible to build a loadable module/shared object without PIC code, so there's no choice but to disable it.

Wed, Aug 26, 11:58 AM · Restricted Project, Restricted Project
Meinersbur committed rG6538fff37245: [Polly] Inline ShoulDelete lambda. NFC. (authored by Meinersbur).
[Polly] Inline ShoulDelete lambda. NFC.
Wed, Aug 26, 11:16 AM
Meinersbur committed rGc971b53b22a5: [Polly] Use llvm::function_ref. NFC. (authored by Meinersbur).
[Polly] Use llvm::function_ref. NFC.
Wed, Aug 26, 11:16 AM

Mon, Aug 24

Meinersbur added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

According to CODE_OWNERS.TXT, that @sscalpone

Mon, Aug 24, 6:13 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

I can confirm that shape.cpp compiles with your patch.

Mon, Aug 24, 2:18 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

I am not familiar with TypeParameterInquiry. Since this solution works, a restructure might not be necessary unless you plan to do the change anyway.

Mon, Aug 24, 12:01 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

Use explicit method specializations in base class.

Mon, Aug 24, 11:57 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

Is the MSVC bug peculiar to template member functions like template <int K> operator()(const TypeParamInquiry<K> &) const? If so, is it peculiar to *just* TypeParamInquiry, or does it affect other templatized expression nodes as well?

Mon, Aug 24, 10:01 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

What is your alternative suggestion to fix the compiler error?

Mon, Aug 24, 8:51 AM · Restricted Project, Restricted Project

Sun, Aug 23

Meinersbur added a comment to D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC..

Bug was was already reported (but no yet fixed) at https://developercommunity.visualstudio.com/content/problem/1067774/ice-internal-compiler-error-on-constexpr-range-bas.html.

Sun, Aug 23, 8:06 PM · Restricted Project, Restricted Project
Meinersbur requested review of D86425: [flang][msvc] Avoid range-based for over initializer_list. NFC..
Sun, Aug 23, 8:05 PM · Restricted Project, Restricted Project

Aug 23 2020

Meinersbur updated the diff for D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

Fix missing helpers

Aug 23 2020, 2:25 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

Bug report: https://developercommunity.visualstudio.com/content/problem/1159566/ambiguous-call-to-template-method-from-using-decla.html

Aug 23 2020, 1:22 PM · Restricted Project, Restricted Project
Meinersbur updated the summary of D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..
Aug 23 2020, 12:15 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..

Considering more occurrences in check-expressions.cpp

Aug 23 2020, 10:29 AM · Restricted Project, Restricted Project

Aug 22 2020

Meinersbur requested review of D86410: [flang][msvc] Avoid ambiguous overload from base class. NFC..
Aug 22 2020, 4:12 PM · Restricted Project, Restricted Project
Meinersbur added a reverting change for rG8e06bf6b3a2e: [Polly] Ensure consistent Scop::InstStmtMap. NFC.: rG8b14db636dec: Revert "[Polly] Ensure consistent Scop::InstStmtMap. NFC.".
Aug 22 2020, 1:10 PM
Meinersbur committed rG8b14db636dec: Revert "[Polly] Ensure consistent Scop::InstStmtMap. NFC." (authored by Meinersbur).
Revert "[Polly] Ensure consistent Scop::InstStmtMap. NFC."
Aug 22 2020, 1:10 PM
Meinersbur committed rG207d4499dfab: [flang][msvc] Split class declaration and constexpr variable definition. NFC. (authored by Meinersbur).
[flang][msvc] Split class declaration and constexpr variable definition. NFC.
Aug 22 2020, 1:06 PM
Meinersbur closed D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
Aug 22 2020, 1:05 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

Reverting to the version without ifdefs

Aug 22 2020, 10:22 AM · Restricted Project, Restricted Project
Meinersbur committed rG2aaa5a546ea0: [flang][msvc] Disambiguate injected class name. (authored by Meinersbur).
[flang][msvc] Disambiguate injected class name.
Aug 22 2020, 10:16 AM
Meinersbur closed D85646: [flang][msvc] Disambiguate injected class name..
Aug 22 2020, 10:16 AM · Restricted Project, Restricted Project
Meinersbur committed rG8e06bf6b3a2e: [Polly] Ensure consistent Scop::InstStmtMap. NFC. (authored by Meinersbur).
[Polly] Ensure consistent Scop::InstStmtMap. NFC.
Aug 22 2020, 8:22 AM
Meinersbur committed rG6983741eaa84: [Polly] Fix use-after-free. (authored by Meinersbur).
[Polly] Fix use-after-free.
Aug 22 2020, 8:22 AM

Aug 20 2020

Meinersbur committed rGa54eb9b7c509: [Polly] Update isl to isl-0.22.1-416-g61d6dc75. (authored by Meinersbur).
[Polly] Update isl to isl-0.22.1-416-g61d6dc75.
Aug 20 2020, 10:30 PM

Aug 14 2020

Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

@klausler I updated the patch before I noticed you accepted the version without the requested change that you defended vigorously. Which version do you want?

Aug 14 2020, 4:46 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
  • Make workaround conditional to msvc (requested by @klausler)
Aug 14 2020, 4:34 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?

Aug 14 2020, 4:04 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

Aug 14 2020, 1:36 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

Add missed constexpr

Aug 14 2020, 1:34 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

The pre-merge check

clang-tidy: warning: variable 'digitString64' defined in a header file; variable definitions in header files can lead to ODR violations [misc-definitions-in-headers]

is correct: I forgot the constexpr for the variable declaration here. Going to update the patch.

Aug 14 2020, 1:25 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

Reported here: https://developercommunity.visualstudio.com/content/problem/1151042/class-with-constexpr-constructor-and-variable-declaration-in-same-declarator.html

Aug 14 2020, 1:23 PM · Restricted Project, Restricted Project

Aug 13 2020

Meinersbur requested review of D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
Aug 13 2020, 2:33 PM · Restricted Project, Restricted Project
Meinersbur committed rG8199cd8a550d: [flang] Compilation fix. (authored by Meinersbur).
[flang] Compilation fix.
Aug 13 2020, 1:06 AM
Meinersbur committed rG18e9482e44ed: [flang][msvc] Use platform-independent primitives in temporary f18 driver. (authored by Meinersbur).
[flang][msvc] Use platform-independent primitives in temporary f18 driver.
Aug 13 2020, 12:17 AM
Meinersbur closed D85660: [flang][msvc] Use platform-independent primitives in temporary f18 driver..
Aug 13 2020, 12:17 AM · Restricted Project, Restricted Project

Aug 12 2020

Meinersbur updated the summary of D85646: [flang][msvc] Disambiguate injected class name..
Aug 12 2020, 2:58 PM · Restricted Project, Restricted Project
Meinersbur committed rG62ef1cb20791: [flang][msvc] Remove default arguments for function specializations. (authored by Meinersbur).
[flang][msvc] Remove default arguments for function specializations.
Aug 12 2020, 2:46 PM
Meinersbur closed D85657: [flang][msvc] Remove default arguments for function specializations..
Aug 12 2020, 2:46 PM · Restricted Project
Meinersbur committed rGe3d38b7b8898: [flang][msvc] Tell windows.h to not define min/max macros. (authored by Meinersbur).
[flang][msvc] Tell windows.h to not define min/max macros.
Aug 12 2020, 12:36 PM
Meinersbur closed D85656: [flang][msvc] Tell windows.h to not define min/max macros..
Aug 12 2020, 12:36 PM · Restricted Project, Restricted Project

Aug 10 2020

Meinersbur updated the diff for D85660: [flang][msvc] Use platform-independent primitives in temporary f18 driver..
  • Use llvm::report_fatal_error
Aug 10 2020, 9:48 AM · Restricted Project, Restricted Project
Meinersbur requested review of D85660: [flang][msvc] Use platform-independent primitives in temporary f18 driver..
Aug 10 2020, 9:34 AM · Restricted Project, Restricted Project
Meinersbur requested review of D85657: [flang][msvc] Remove default arguments for function specializations..
Aug 10 2020, 8:39 AM · Restricted Project
Meinersbur retitled D85656: [flang][msvc] Tell windows.h to not define min/max macros. from [flang][msvc] Teach windows.h not to define min/max macros. to [flang][msvc] Tell windows.h to not define min/max macros..
Aug 10 2020, 8:20 AM · Restricted Project, Restricted Project
Meinersbur requested review of D85656: [flang][msvc] Tell windows.h to not define min/max macros..
Aug 10 2020, 8:20 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D85627: [polly][cmake] Don't build LLVMPolly.so without PIC.

Could you outline your intended solution? If I read correctly, with LLVM_ENABLE_PIC=OFF, no Polly module will be built, making Polly useless unless Polly is built in-tree and LLVM_POLLY_LINK_INTO_TOOLS is used.

Aug 10 2020, 6:32 AM · Restricted Project, Restricted Project
Meinersbur updated the summary of D85646: [flang][msvc] Disambiguate injected class name..
Aug 10 2020, 6:18 AM · Restricted Project, Restricted Project
Meinersbur updated the summary of D85646: [flang][msvc] Disambiguate injected class name..
Aug 10 2020, 6:13 AM · Restricted Project, Restricted Project
Meinersbur requested review of D85646: [flang][msvc] Disambiguate injected class name..
Aug 10 2020, 6:11 AM · Restricted Project, Restricted Project

Aug 9 2020

Meinersbur accepted D85280: [Polly] Reuse LLVM's build rules for gtest/gmock.

(I think this code was once copied from clang; clang's CMakeLists.txt now also reuses LLVM's gtest CMakeLists.txt)

Aug 9 2020, 3:45 AM · Restricted Project
Meinersbur resigned from D85299: [llvm] Support autoloading vendor-defined plugins.

The scenario sounds too specific for a single user requiring too much effort to maintain it across build configurations and platforms. Additionally, it makes clang's behavior dependent on the system configuration, which in the past the LLVM community was not in favor of. See http://lists.llvm.org/pipermail/cfe-dev/2016-September/050795.html.

Aug 9 2020, 3:30 AM · Restricted Project

Aug 7 2020

Meinersbur added a comment to D85299: [llvm] Support autoloading vendor-defined plugins.

If it is passes that (like Polly) using the in-tree static plugin mechanism, I recommend using the LLVM_<plugin>_LINK_INTO_TOOLS=ON flag.

Aug 7 2020, 9:40 PM · Restricted Project

Aug 6 2020

Meinersbur accepted D85281: [Polly] Support linking ScopPassManager against LLVM dylib.

LGTM

Aug 6 2020, 7:36 PM · Restricted Project
Meinersbur added a comment to D84763: DomTree: Make PostDomTree immune to block successors swap.

This also broke the Polly buildbot twice: http://lab.llvm.org:8011/builders/polly-x86_64-linux/builds/3542 and http://lab.llvm.org:8011/builders/polly-x86_64-linux/builds/3547. Please also fix the Polly tests when you get notifications from the Polly buildbot.

Aug 6 2020, 7:20 PM · Restricted Project
Meinersbur committed rG1139d899d589: [polly] Unbreak buildbot. (authored by Meinersbur).
[polly] Unbreak buildbot.
Aug 6 2020, 7:18 PM
Meinersbur added a comment to D85465: [flang] Remove extra CMAKE_CXX_FLAGS in Lower and Optimizer.

Independently on whether it is decided whether these lines are needed at all, I commited D85355. Hence this will need a rebase (which should be trivial: just remove the added lines as well).

Aug 6 2020, 1:48 PM · Restricted Project, Restricted Project
Meinersbur committed rGf81bae9ff42f: [flang][msvc] Do not use gcc/clang command line options for msvc. (authored by Meinersbur).
[flang][msvc] Do not use gcc/clang command line options for msvc.
Aug 6 2020, 1:47 PM