Thats what I get for not having coffee before responding. objdump is used quite a bit in tests as well (objdump -t | grep ..., objdump -h | grep ..., etc).
objcopy is often used in autotools to run tests of what the compiler is doing. I'm afraid that changing that behaviour will break the autoconf tests which rely on the behaviour (a.out is what the compiler generates by default, and that is why the tool defaults to that filename). So, if you have something like the following:
Yeah, mutations of the hashtable during iteration would be bad. LGTM.
This breaks compatibility with objdump. Please ensure that the original behavior is preserved when invoked as objdump rather than llvm-objdump.
Fri, Jul 12
Seems that all the comments have been addressed and this is purely code motion. LGTM
Thu, Jul 11
Tue, Jul 9
I don't see any cases where [[clang::required]] is tested, am I missing something?
@ldionne - that was exactly the motivation for this change - it always takes me a couple of reads to figure out what we are trying to do here.
Mon, Jul 8
Sun, Jul 7
Sat, Jul 6
Fri, Jul 5
I'm happy to see this finally happening, it makes much more sense.
Thu, Jul 4
Generally, it is nicer to have some more context in the uploaded diff, although, in this case, it doesn't really matter.
Tue, Jul 2
The explicit list I think is way better for readability, this is a nice starting point for cleaning this up.
Thu, Jun 27
I don't understand the change for the PRIVATE to PUBLIC. That doesn't make a different to the import library handling, which is baked right into CMake, so that will always be handled properly irrespective of the link dependency's visibility. I think the only thing that may be needed is the Core dependency on the TestPlugin.
Wed, Jun 26
Tue, Jun 25
@craig.topper, hmm, what happens in terms of CG when LAHF/SAHF are not available? I assume its just worse CG as you could spill AH onto the stack and do a load/store. This actually results in library calls which may not be possible to fulfill.
Move test case around
add additional context and test case
@lebedev.ri - sure, I will add a driver test to ensure that the feature is set on the command line when invoked from the driver, however, I don't think that there is really much in terms of testing that you can do for this type of stuff other than throw a large corpus at it.
Sat, Jun 22
Fri, Jun 21
Wed, Jun 19
Mon, Jun 17
Could you please add a test to ensure that Darwin defaults to the old behaviour?
Jun 14 2019
Jun 12 2019
What I am imagining is basically having a variable which specifies the distribution targets, and having variables which will be constructed based upon those names (similar to how variables for the runtimes are passed today).
Jun 11 2019
Jun 10 2019
Jun 9 2019
Jun 6 2019
Jun 3 2019
Jun 2 2019
This should get the build working again, so lets get this fixed, we can improve it later
Generally, clang-format the changes, it will catch the formatting things.
Jun 1 2019
May 31 2019
Oops! Nice catch. This matches the specification.
Actually, I think that we should extend CompilerType and TypeSystem to expose Clang's knowledge of whether a type is passed in a register by means of using clang::RecordDecl::isPassInRegisters
May 30 2019
Thanks for adding the test case!
Thanks, this looks much better.