Page MenuHomePhabricator
Feed Advanced Search

Today

compnerd added inline comments to D64668: [llvm-lipo] Implement -info.
Mon, Jul 15, 10:45 AM · Restricted Project
compnerd added inline comments to D64668: [llvm-lipo] Implement -info.
Mon, Jul 15, 10:31 AM · Restricted Project
compnerd added a comment to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.

Thats what I get for not having coffee before responding. objdump is used quite a bit in tests as well (objdump -t | grep ..., objdump -h | grep ..., etc).

Mon, Jul 15, 10:13 AM · Restricted Project
compnerd added a comment to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.

objcopy is often used in autotools to run tests of what the compiler is doing. I'm afraid that changing that behaviour will break the autoconf tests which rely on the behaviour (a.out is what the compiler generates by default, and that is why the tool defaults to that filename). So, if you have something like the following:

Mon, Jul 15, 8:49 AM · Restricted Project

Yesterday

compnerd accepted D64641: PDB HashTable: Make iterator type const.

Yeah, mutations of the hashtable during iteration would be bad. LGTM.

Sun, Jul 14, 6:46 PM · Restricted Project
compnerd requested changes to D64706: [tools] [llvm-objdump] Default to reading from stdin not a.out.

This breaks compatibility with objdump. Please ensure that the original behavior is preserved when invoked as objdump rather than llvm-objdump.

Sun, Jul 14, 6:46 PM · Restricted Project
compnerd added inline comments to D64668: [llvm-lipo] Implement -info.
Sun, Jul 14, 6:42 PM · Restricted Project

Fri, Jul 12

compnerd accepted D64159: [Core] Generalize ValueObject::MaybeCalculateCompleteType.

Seems that all the comments have been addressed and this is purely code motion. LGTM

Fri, Jul 12, 10:12 AM · Restricted Project

Thu, Jul 11

compnerd added inline comments to D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin.
Thu, Jul 11, 2:32 PM · Restricted Project
compnerd added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Thu, Jul 11, 9:51 AM · Restricted Project

Tue, Jul 9

compnerd added a comment to D64380: Add 'require_designated_init' and 'required' attribute to clang.

I don't see any cases where [[clang::required]] is tested, am I missing something?

Tue, Jul 9, 5:07 PM · Restricted Project
compnerd committed rG97d6fcce4ec6: build: use multiple `install` rather than building up a list (authored by compnerd).
build: use multiple `install` rather than building up a list
Tue, Jul 9, 2:48 PM
compnerd committed rL365562: build: use multiple `install` rather than building up a list.
build: use multiple `install` rather than building up a list
Tue, Jul 9, 2:43 PM
compnerd closed D64383: build: use multiple `install` rather than building up a list.

SVN r365562

Tue, Jul 9, 2:43 PM
compnerd added a comment to D64383: build: use multiple `install` rather than building up a list.

@ldionne - that was exactly the motivation for this change - it always takes me a couple of reads to figure out what we are trying to do here.

Tue, Jul 9, 8:02 AM

Mon, Jul 8

compnerd created D64383: build: use multiple `install` rather than building up a list.
Mon, Jul 8, 6:10 PM
compnerd added inline comments to D64380: Add 'require_designated_init' and 'required' attribute to clang.
Mon, Jul 8, 6:00 PM · Restricted Project
compnerd added reviewers for D64380: Add 'require_designated_init' and 'required' attribute to clang: aaron.ballman, rsmith.
Mon, Jul 8, 5:41 PM · Restricted Project

Sun, Jul 7

compnerd committed rG842f55f3efe4: Process: generalise Windows thread setup (authored by compnerd).
Process: generalise Windows thread setup
Sun, Jul 7, 11:01 AM
compnerd committed rL365282: Process: generalise Windows thread setup.
Process: generalise Windows thread setup
Sun, Jul 7, 11:00 AM

Sat, Jul 6

compnerd accepted D64292: [ARM] Add support for MSVC stack cookie checking.
Sat, Jul 6, 7:46 PM · Restricted Project

Fri, Jul 5

compnerd accepted D64109: Standardize on MSVC behavior for triples with no environment.

I'm happy to see this finally happening, it makes much more sense.

Fri, Jul 5, 9:17 AM · Restricted Project

Thu, Jul 4

compnerd committed rG1522073fedc2: Plugins: permit building on Windows ARM64 (authored by compnerd).
Plugins: permit building on Windows ARM64
Thu, Jul 4, 12:29 PM
compnerd committed rL365155: Plugins: permit building on Windows ARM64.
Plugins: permit building on Windows ARM64
Thu, Jul 4, 12:29 PM
compnerd committed rGbce9d8b138ca: docs: add documentation for `LIBCXX_INCLUDE_TESTS` (authored by compnerd).
docs: add documentation for `LIBCXX_INCLUDE_TESTS`
Thu, Jul 4, 12:09 PM
compnerd committed rL365154: docs: add documentation for `LIBCXX_INCLUDE_TESTS`.
docs: add documentation for `LIBCXX_INCLUDE_TESTS`
Thu, Jul 4, 12:08 PM
compnerd closed D64214: Add documentation for LIBCXX_INCLUDE_TESTS option.

SVN r365154

Thu, Jul 4, 12:08 PM
compnerd accepted D64214: Add documentation for LIBCXX_INCLUDE_TESTS option.

Generally, it is nicer to have some more context in the uploaded diff, although, in this case, it doesn't really matter.

Thu, Jul 4, 11:47 AM

Tue, Jul 2

compnerd added inline comments to D64102: [llvm-lipo] Implement -create part 1.
Tue, Jul 2, 2:45 PM · Restricted Project
compnerd added inline comments to D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..
Tue, Jul 2, 2:23 PM · Restricted Project
compnerd added reviewers for D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table.: rsmith, aaron.ballman.
Tue, Jul 2, 2:06 PM · Restricted Project
compnerd added a comment to D64098: [NFC][clang] Refactor getCompilationPhases step 1: Move list of phases into Types.def table..

The explicit list I think is way better for readability, this is a nice starting point for cleaning this up.

Tue, Jul 2, 2:06 PM · Restricted Project

Thu, Jun 27

compnerd added a comment to D63881: [cmake] Fix build with BUILD_SHARED_LIBS=ON .

I don't understand the change for the PRIVATE to PUBLIC. That doesn't make a different to the import library handling, which is baked right into CMake, so that will always be handled properly irrespective of the link dependency's visibility. I think the only thing that may be needed is the Core dependency on the TestPlugin.

Thu, Jun 27, 10:10 AM · Restricted Project
compnerd added inline comments to D63735: [MachOObjectFile]Added Valid Architecture Function.
Thu, Jun 27, 10:03 AM · Restricted Project

Wed, Jun 26

compnerd accepted D63834: [cmake] Allow config.guess to be run with MSYS on Windows.
Wed, Jun 26, 2:39 PM · Restricted Project

Tue, Jun 25

compnerd committed rG06036dbc6e91: MC: correct the emission of weak aliases in COFF (authored by compnerd).
MC: correct the emission of weak aliases in COFF
Tue, Jun 25, 6:11 PM
compnerd committed rL364370: MC: correct the emission of weak aliases in COFF.
MC: correct the emission of weak aliases in COFF
Tue, Jun 25, 6:10 PM
compnerd committed rGc32d307a49f5: android: enable double-word CAS on x64 (authored by compnerd).
android: enable double-word CAS on x64
Tue, Jun 25, 2:45 PM
compnerd committed rL364352: android: enable double-word CAS on x64.
android: enable double-word CAS on x64
Tue, Jun 25, 2:43 PM
compnerd closed D63774: android: enable double-word CAS on x86_64.

SVN r364352

Tue, Jun 25, 2:43 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@craig.topper, hmm, what happens in terms of CG when LAHF/SAHF are not available? I assume its just worse CG as you could spill AH onto the stack and do a load/store. This actually results in library calls which may not be possible to fulfill.

Tue, Jun 25, 1:44 PM · Restricted Project
compnerd updated the diff for D63774: android: enable double-word CAS on x86_64.

Move test case around

Tue, Jun 25, 1:21 PM · Restricted Project
compnerd updated the diff for D63774: android: enable double-word CAS on x86_64.

add additional context and test case

Tue, Jun 25, 12:50 PM · Restricted Project
compnerd added a comment to D63774: android: enable double-word CAS on x86_64.

@lebedev.ri - sure, I will add a driver test to ensure that the feature is set on the command line when invoked from the driver, however, I don't think that there is really much in terms of testing that you can do for this type of stuff other than throw a large corpus at it.

Tue, Jun 25, 12:47 PM · Restricted Project
compnerd created D63774: android: enable double-word CAS on x86_64.
Tue, Jun 25, 8:54 AM · Restricted Project

Sat, Jun 22

compnerd committed rG6281ccea02d3: Revert "builtins: relax __iso_volatile_{load,store}32" (authored by compnerd).
Revert "builtins: relax __iso_volatile_{load,store}32"
Sat, Jun 22, 7:57 PM
compnerd committed rL364147: Revert "builtins: relax __iso_volatile_{load,store}32".
Revert "builtins: relax __iso_volatile_{load,store}32"
Sat, Jun 22, 7:56 PM
compnerd committed rGebae85bc4a31: builtins: relax __iso_volatile_{load,store}32 (authored by compnerd).
builtins: relax __iso_volatile_{load,store}32
Sat, Jun 22, 11:57 AM
compnerd committed rL364137: builtins: relax __iso_volatile_{load,store}32.
builtins: relax __iso_volatile_{load,store}32
Sat, Jun 22, 11:57 AM

Fri, Jun 21

compnerd added inline comments to D63622: [Target] Hoist LanguageRuntime::GetDeclVendor.
Fri, Jun 21, 9:21 AM · Restricted Project

Wed, Jun 19

compnerd accepted D63584: [clang][AST] Refactoring ASTNameGenerator to use pimpl pattern (NFC)..
Wed, Jun 19, 6:51 PM · Restricted Project, Restricted Project
compnerd accepted D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 11:21 AM · Restricted Project, Restricted Project
compnerd added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 10:19 AM · Restricted Project, Restricted Project
compnerd added inline comments to D63535: [clang][AST] ASTNameGenerator: A refactoring of CodegenNameGeneratorImpl (NFC)..
Wed, Jun 19, 8:57 AM · Restricted Project, Restricted Project

Mon, Jun 17

compnerd added a comment to D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.

Could you please add a test to ensure that Darwin defaults to the old behaviour?

Mon, Jun 17, 9:09 PM · Restricted Project
compnerd accepted D60974: Clang IFSO driver action..
Mon, Jun 17, 1:00 PM · Restricted Project, Restricted Project

Jun 14 2019

compnerd accepted D63357: [Process] Remove unused field from HistoryThread.
Jun 14 2019, 7:53 PM · Restricted Project
compnerd accepted D63368: [compiler-rt] Respect CMAKE_NM.
Jun 14 2019, 7:47 PM · Restricted Project, Restricted Project
compnerd added inline comments to D63341: [llvm-lipo] Implement -thin.
Jun 14 2019, 11:30 AM · Restricted Project
compnerd committed rG2b9f6caa71f7: build: extract LLVM distribution target handling (authored by compnerd).
build: extract LLVM distribution target handling
Jun 14 2019, 11:27 AM
compnerd committed rL363440: build: extract LLVM distribution target handling.
build: extract LLVM distribution target handling
Jun 14 2019, 11:25 AM
compnerd closed D62982: build: extract LLVM distribution target handling.

SVN r363440

Jun 14 2019, 11:25 AM · Restricted Project
compnerd committed rG2874d285b9f3: build: don't attempt to run config.guess on Windows (authored by compnerd).
build: don't attempt to run config.guess on Windows
Jun 14 2019, 9:45 AM
compnerd committed rL363420: build: don't attempt to run config.guess on Windows.
build: don't attempt to run config.guess on Windows
Jun 14 2019, 9:44 AM

Jun 12 2019

compnerd added inline comments to D63239: [llvm-objcopy][NFC] Refactor output target parsing.
Jun 12 2019, 7:26 PM · Restricted Project
compnerd accepted D63238: [llvm-objcopy] Add elf32-sparc and elf32-sparcel target.
Jun 12 2019, 7:23 PM · Restricted Project
compnerd added a comment to D62982: build: extract LLVM distribution target handling.

What I am imagining is basically having a variable which specifies the distribution targets, and having variables which will be constructed based upon those names (similar to how variables for the runtimes are passed today).

Jun 12 2019, 7:21 PM · Restricted Project
compnerd added inline comments to D60974: Clang IFSO driver action..
Jun 12 2019, 9:59 AM · Restricted Project, Restricted Project

Jun 11 2019

compnerd added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Jun 11 2019, 4:02 PM · Restricted Project

Jun 10 2019

compnerd added inline comments to D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections.
Jun 10 2019, 2:53 PM · Restricted Project
compnerd accepted D63052: [Target] Remove Process::GetObjCLanguageRuntime.
Jun 10 2019, 1:37 PM · Restricted Project
compnerd committed rG9aff1ddc14f3: ABI: reflow the table text (NFC) (authored by compnerd).
ABI: reflow the table text (NFC)
Jun 10 2019, 9:30 AM
compnerd committed rL362961: ABI: reflow the table text (NFC).
ABI: reflow the table text (NFC)
Jun 10 2019, 9:29 AM

Jun 9 2019

compnerd added inline comments to D63052: [Target] Remove Process::GetObjCLanguageRuntime.
Jun 9 2019, 12:49 PM · Restricted Project

Jun 6 2019

compnerd created D62982: build: extract LLVM distribution target handling.
Jun 6 2019, 2:32 PM · Restricted Project

Jun 3 2019

compnerd accepted D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl.

Would be nice to get someone like @clayborg to chime in, but, I think that @labath also seems to think that this is fine.

Jun 3 2019, 5:56 PM · Restricted Project
compnerd committed rG197a7c01e6bf: tools: add `llvm-nm` and `llvm-objcopy` to tools (authored by compnerd).
tools: add `llvm-nm` and `llvm-objcopy` to tools
Jun 3 2019, 10:15 AM
compnerd committed rL362425: tools: add `llvm-nm` and `llvm-objcopy` to tools.
tools: add `llvm-nm` and `llvm-objcopy` to tools
Jun 3 2019, 10:15 AM
compnerd closed D61082: llvm-nm and llvm-objcopy belong to toolchain.

SVN r362425

Jun 3 2019, 10:15 AM · Restricted Project
compnerd accepted D61082: llvm-nm and llvm-objcopy belong to toolchain.
Jun 3 2019, 10:06 AM · Restricted Project
compnerd committed rGaad5d518823b: builtins: correct function name for AEABI (authored by compnerd).
builtins: correct function name for AEABI
Jun 3 2019, 10:06 AM
compnerd committed rL362424: builtins: correct function name for AEABI.
builtins: correct function name for AEABI
Jun 3 2019, 10:06 AM
compnerd closed D62723: [compiler-rt][builtins] Fix typo in definition of __aeabi_fcmpun.

SVN r362424

Jun 3 2019, 10:06 AM · Restricted Project, Restricted Project
compnerd added inline comments to D62812: [llvm] [CodeView] Move Triple::ArchType → CPUType mapping from LLDB.
Jun 3 2019, 9:59 AM · Restricted Project

Jun 2 2019

compnerd accepted D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames.

This should get the build working again, so lets get this fixed, we can improve it later

Jun 2 2019, 5:29 PM · Restricted Project, Restricted Project
compnerd added inline comments to D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl.
Jun 2 2019, 5:28 PM · Restricted Project
compnerd requested changes to D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames.
Jun 2 2019, 10:47 AM · Restricted Project, Restricted Project
compnerd accepted D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb.

Generally, clang-format the changes, it will catch the formatting things.

Jun 2 2019, 10:46 AM · Restricted Project

Jun 1 2019

compnerd added inline comments to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
Jun 1 2019, 10:02 AM · Restricted Project, Restricted Project

May 31 2019

compnerd added inline comments to D62753: [llvm-lipo] Implement -archs.
May 31 2019, 3:13 PM · Restricted Project
compnerd accepted D62723: [compiler-rt][builtins] Fix typo in definition of __aeabi_fcmpun.

Oops! Nice catch. This matches the specification.

May 31 2019, 2:55 PM · Restricted Project, Restricted Project
compnerd requested changes to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

Actually, I think that we should extend CompilerType and TypeSystem to expose Clang's knowledge of whether a type is passed in a register by means of using clang::RecordDecl::isPassInRegisters

May 31 2019, 2:41 PM · Restricted Project, Restricted Project
compnerd accepted D62740: [MIR-Canon] Don't do vreg skip for independent instructions if there are none..
May 31 2019, 10:10 AM · Restricted Project

May 30 2019

compnerd accepted D62717: [MIR-Canon] Skip the first N vreg names lazily..
May 30 2019, 10:37 PM · Restricted Project
compnerd accepted D62713: [MIR-Canon] Hardening propagateLocalCopies..

Thanks for adding the test case!

May 30 2019, 9:31 PM · Restricted Project
compnerd accepted D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.

Thanks, this looks much better.

May 30 2019, 6:50 PM · Restricted Project, Restricted Project
compnerd added inline comments to D62713: [MIR-Canon] Hardening propagateLocalCopies..
May 30 2019, 6:36 PM · Restricted Project
compnerd added inline comments to D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register.
May 30 2019, 4:38 PM · Restricted Project, Restricted Project
compnerd added a reviewer for D62022: [lit] Improve globbing in Windows with long paths: thakis.
May 30 2019, 4:38 PM · Restricted Project
compnerd added a reviewer for D62022: [lit] Improve globbing in Windows with long paths: rnk.
May 30 2019, 4:38 PM · Restricted Project