- All Stories
- Advanced Search
- Transaction Logs
Aug 31 2022
Jun 1 2022
Looks good to me.
Nov 3 2021
I'm guessing that this won't pass "git clang-format" (although I don't know if test files are checked. I'll check and let you know offline.
Oct 4 2021
Sep 29 2021
Update based on changes in https://reviews.llvm.org/D110356. Cleaned up tests.
Sep 28 2021
In D110356#3026290, @klausler wrote:In D110356#3026230, @craig.rasmussen wrote:In D110356#3021316, @klausler wrote:
Craig R.: any comments?
Oh, you actually want me to comment on the change? I think you probably want me to use it. I need to take some time to digest the changes.
Would you like me to wait for your review comments before landing this patch?
Sep 27 2021
This needs to be updated for changes in https://reviews.llvm.org/D110356
In D110356#3021316, @klausler wrote:
Craig R.: any comments?
Inlined implementation of call to semantics::IsTeamType. This is necessary because the semantics::IsTeamType symbol in undefined at the time libFortranEvalute is built.
Sep 21 2021
Sep 20 2021
Implemented TEAM_NUMBER intrinsic function without use of MissingDerivedType() hack.
Sep 16 2021
Hopefully this will open the issue and is the correct way to correct a push that was reverted.
Inlined call to Fortran::semantics::IsCoarray (one line change) to fix link error.
Sep 13 2021
Peter Klausler wrote:
Or you could have two entry points, one with a team number and one without, and avoid exposing this kind of trick in the API. It could still be used as a hidden part of a common implementation.
Added comments explaining why team_number=0 is a good default value when NUM_IMAGES is called without an actual argument for TEAM_NUMBER.
Changed location of header file to flang/include/flang/Runtime/coarray.h.
Sep 9 2021
In a response @klausler asked:
Sep 3 2021
@klausler, are any further changes required to get this approved?
Aug 18 2021
Aug 13 2021
Aug 2 2021
- Added "! REQUIRES: shell" to test file so as not to trip on windows
- Ran git clang-format
Jul 26 2021
How do I ping? I have another pull request that is also in limbo.
Jul 21 2021
Requesting review (is there a better way to request a review)
Made simplification suggested by reviewer:
Jul 8 2021
Fixed patch and added reviewer.
Forgot to commit changes so patch/diff was not correct.
Jul 7 2021
Added line comments.
Added the static function MissingDerivedType() to allow the creation of a DynamicType with TypeCategory::Derived when a semantics::DerivedTypeSpec is not directly available. This allows a missing actual argument for an optional dummy.
Apr 28 2021
I forgot to add that there is one test failing at the moment which makes no sense to me.
- Fixed team argument in call to team_number so that it is optional.
- Fixed teamType kind in flang/lib/Evaluate/intrinsics.cpp
- Added team_number test to flang/unittests/Evaluate/intrinsics.cpp