Page MenuHomePhabricator
Feed Advanced Search

Mar 9 2021

serge-sans-paille accepted D97633: [cmake] Link socket/nsl on SunOS in llvm-jitlink.

LGTM then, obviously I trust you on the portability aspect ;-)

Mar 9 2021, 12:15 AM · Restricted Project

Mar 8 2021

serge-sans-paille added a comment to D96004: [AArch64] Stack probing for function prologues.

@ostannard I've done the best I can for this review, but I have no ARM background so I can't be sure for the arch-specific parts @kristof.beyls can you please have a look?

Mar 8 2021, 11:59 PM · Restricted Project
serge-sans-paille added a comment to D96787: Make clangd CompletionModel usable even with non-standard (but supported) layout.

@usaxena95 ping?

Mar 8 2021, 10:54 PM · Restricted Project
serge-sans-paille added a comment to D98175: [NFC] Remove duplicate isNoBuiltinFunc method.

Well, it's not exactly a non functional change as it changes the API. A downstream user may need to update its code after this commit, right?

Mar 8 2021, 10:53 PM · Restricted Project
serge-sans-paille requested review of D98190: [NFC] Use SmallString instead of std::string for the AttrBuilder.
Mar 8 2021, 8:53 AM · Restricted Project
serge-sans-paille committed rG08d9e2ceec60: [NFC] Avoid useless BitVector move (authored by serge-sans-paille).
[NFC] Avoid useless BitVector move
Mar 8 2021, 6:16 AM
serge-sans-paille updated the diff for D98176: Introduce a generic operator to apply complex operations to BitVector.

Fix formatting

Mar 8 2021, 6:13 AM · Restricted Project
serge-sans-paille requested review of D98176: Introduce a generic operator to apply complex operations to BitVector.
Mar 8 2021, 6:11 AM · Restricted Project
serge-sans-paille updated the diff for D98175: [NFC] Remove duplicate isNoBuiltinFunc method.
Mar 8 2021, 5:54 AM · Restricted Project
serge-sans-paille requested review of D98175: [NFC] Remove duplicate isNoBuiltinFunc method.
Mar 8 2021, 5:50 AM · Restricted Project
serge-sans-paille committed rG1f1b15508618: [NFC] Use ranged loop iteration instead of explicit looping (authored by serge-sans-paille).
[NFC] Use ranged loop iteration instead of explicit looping
Mar 8 2021, 2:51 AM
serge-sans-paille added a comment to D97846: Allow __ieee128 as an alias to __float128 on ppc.

This should be ppc specific now.

Mar 8 2021, 2:47 AM · Restricted Project
serge-sans-paille updated the diff for D97846: Allow __ieee128 as an alias to __float128 on ppc.

Update description, and update implementation to more closely match gcc behavior.

Mar 8 2021, 2:47 AM · Restricted Project

Mar 3 2021

serge-sans-paille updated subscribers of D97846: Allow __ieee128 as an alias to __float128 on ppc.
Mar 3 2021, 5:19 AM · Restricted Project
serge-sans-paille added a reviewer for D97846: Allow __ieee128 as an alias to __float128 on ppc: qshanz.
Mar 3 2021, 3:03 AM · Restricted Project
serge-sans-paille requested review of D97846: Allow __ieee128 as an alias to __float128 on ppc.
Mar 3 2021, 3:02 AM · Restricted Project

Mar 1 2021

serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

@rnk : are you happy with how the patch looks now?

Mar 1 2021, 5:49 AM · Restricted Project
serge-sans-paille committed rG7b319df29bf4: Revert "Use the default seed value for djb hash for StringMap" (authored by serge-sans-paille).
Revert "Use the default seed value for djb hash for StringMap"
Mar 1 2021, 5:06 AM
serge-sans-paille added a reverting change for rGd84440ec9190: Use the default seed value for djb hash for StringMap: rG7b319df29bf4: Revert "Use the default seed value for djb hash for StringMap".
Mar 1 2021, 5:06 AM
serge-sans-paille added a reverting change for D97396: Use the default seed value for djb hash for StringMap: rG7b319df29bf4: Revert "Use the default seed value for djb hash for StringMap".
Mar 1 2021, 5:05 AM · Restricted Project
serge-sans-paille committed rGd84440ec9190: Use the default seed value for djb hash for StringMap (authored by serge-sans-paille).
Use the default seed value for djb hash for StringMap
Mar 1 2021, 4:22 AM
serge-sans-paille closed D97396: Use the default seed value for djb hash for StringMap.
Mar 1 2021, 4:21 AM · Restricted Project
serge-sans-paille committed rG80e8efd563fd: Use a fast path when initializing LineOffsetMapping (authored by serge-sans-paille).
Use a fast path when initializing LineOffsetMapping
Mar 1 2021, 1:24 AM
serge-sans-paille closed D97320: Use a fast path when initializing LineOffsetMapping.
Mar 1 2021, 1:23 AM · Restricted Project
serge-sans-paille added a comment to D97320: Use a fast path when initializing LineOffsetMapping.

Same generated assembly:

Mar 1 2021, 12:57 AM · Restricted Project
serge-sans-paille added inline comments to D97633: [cmake] Link socket/nsl on SunOS in llvm-jitlink.
Mar 1 2021, 12:25 AM · Restricted Project

Feb 26 2021

serge-sans-paille accepted D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

Now that https://reviews.llvm.org/D96536 landed, we can remove the assert with some more confidence.

Feb 26 2021, 2:27 AM · Restricted Project

Feb 25 2021

serge-sans-paille committed rGf0e461057221: Support standalone build of clang-tidy unittest (authored by serge-sans-paille).
Support standalone build of clang-tidy unittest
Feb 25 2021, 2:51 AM
serge-sans-paille closed D96788: Support standalone build of clang-tidy unittest.
Feb 25 2021, 2:51 AM · Restricted Project
serge-sans-paille added a comment to D97320: Use a fast path when initializing LineOffsetMapping.

Interesting optimization! How much speedup does this provide?

Feb 25 2021, 1:18 AM · Restricted Project

Feb 24 2021

serge-sans-paille added a comment to D97396: Use the default seed value for djb hash for StringMap.

The performance gain was worth doing the test update.

How did you measure this and what were the results?

Feb 24 2021, 12:59 PM · Restricted Project
serge-sans-paille added a comment to D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

Also not sure why the attempt to replace llvm:: with std:: has failed (probably some weird mix of obsolete STL with a newer patched GCC), although if it's the ABI we want, it doesn't matter.

Feb 24 2021, 11:35 AM · Restricted Project
serge-sans-paille committed rGca0bb0e88750: Make sure some types are indeed trivially_copyable per llvm… (authored by serge-sans-paille).
Make sure some types are indeed trivially_copyable per llvm…
Feb 24 2021, 9:25 AM
serge-sans-paille closed D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.
Feb 24 2021, 9:25 AM · Restricted Project
serge-sans-paille added a comment to D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

It's better, I just still not completely get why that assert was necessary in the first place. I.e. what exact scenario is it trying to prevent? If we just want all trivially_copyable uses to be consistent across compilers, then that assert won't help (at the very least since std:: is not consistent across compiler/std versions).

Feb 24 2021, 9:24 AM · Restricted Project
serge-sans-paille requested review of D97396: Use the default seed value for djb hash for StringMap.
Feb 24 2021, 9:15 AM · Restricted Project

Feb 23 2021

serge-sans-paille added a comment to D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.

@danilaml This is certainly not complete, but that's much better than just removing an assert as proposed in https://reviews.llvm.org/D86126. Once that one is accepted, we can move forward and commit https://reviews.llvm.org/D86126

Feb 23 2021, 12:33 PM · Restricted Project
serge-sans-paille requested review of D97320: Use a fast path when initializing LineOffsetMapping.
Feb 23 2021, 11:53 AM · Restricted Project
serge-sans-paille accepted D97116: Reduce the number of attributes attached to each function.

I checked the usage of this attribute, and it's indeed ignored when set to zero, so yeah, let's just not generate it in that case.

Feb 23 2021, 8:30 AM · Restricted Project

Feb 16 2021

serge-sans-paille committed rG3c8bf29f14e4: Reduce the number of attributes attached to each function (authored by serge-sans-paille).
Reduce the number of attributes attached to each function
Feb 16 2021, 7:20 AM
serge-sans-paille closed D96400: Reduce the number of attributes attached to each function.
Feb 16 2021, 7:20 AM · Restricted Project
serge-sans-paille requested review of D96788: Support standalone build of clang-tidy unittest.
Feb 16 2021, 7:09 AM · Restricted Project
serge-sans-paille requested review of D96787: Make clangd CompletionModel usable even with non-standard (but supported) layout.
Feb 16 2021, 7:01 AM · Restricted Project

Feb 11 2021

serge-sans-paille added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

@danilaml I've submited https://reviews.llvm.org/D96536 that provides some replacement checks for the previous std::is_trivially_copiable <> llvm::is_trivially_copyable check. Once that one (or a similar one / a revised version) is in, I'm 100% in favor of landing that one.

Feb 11 2021, 12:41 PM · Restricted Project
serge-sans-paille requested review of D96536: Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable.
Feb 11 2021, 12:38 PM · Restricted Project

Feb 10 2021

serge-sans-paille requested review of D96400: Reduce the number of attributes attached to each function.
Feb 10 2021, 12:46 AM · Restricted Project

Feb 3 2021

serge-sans-paille accepted D93494: [Support] Indent multi-line descr of enum cli options..

LGTM, thanks for providing a test case!

Feb 3 2021, 3:18 PM · Restricted Project

Jan 29 2021

serge-sans-paille added a comment to D93095: Introduce -Wreserved-identifier.

@rsmith I did my bet to address your comments. What do you think of current state?

Jan 29 2021, 2:07 PM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Extra test cases

Jan 29 2021, 2:05 PM · Restricted Project
serge-sans-paille committed rG27f2fe9163ec: Adapt lldb-instr to d47ee525f9e92898 APi change (authored by serge-sans-paille).
Adapt lldb-instr to d47ee525f9e92898 APi change
Jan 29 2021, 2:06 AM
serge-sans-paille committed rGd47ee525f9e9: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option (authored by serge-sans-paille).
[clang-tooling] Prevent llvm::fatal_error on invalid CLI option
Jan 29 2021, 1:21 AM
serge-sans-paille closed D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.
Jan 29 2021, 1:21 AM · Restricted Project
serge-sans-paille added a comment to D95666: [CMake] Remove some dead code in llvm_install_library_symlink().

I'm 100% in favor of removing code, but can you explain why it's dead?

Jan 29 2021, 1:00 AM · Restricted Project

Jan 28 2021

serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Jan 28 2021, 12:53 PM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Back to the previous version, as suggested by @rsmith . I made a few updates to NamedDecl::isReserved which get me close to the expected result, without too much overhead.

Jan 28 2021, 12:11 PM · Restricted Project

Jan 27 2021

serge-sans-paille added a comment to D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.

@alexfh gentle ping?

Jan 27 2021, 2:31 AM · Restricted Project
serge-sans-paille added inline comments to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".
Jan 27 2021, 2:27 AM · Restricted Project
serge-sans-paille added inline comments to D94387: Add new LLVMComponents CMake module..
Jan 27 2021, 2:19 AM · Restricted Project

Jan 26 2021

serge-sans-paille added a comment to D93494: [Support] Indent multi-line descr of enum cli options..

Would be good to have a test entry for that new pretty printer . That would also make the review easier ;-)

Jan 26 2021, 1:09 AM · Restricted Project

Jan 20 2021

serge-sans-paille added a comment to D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.

Thanks @alexfh ! Should be good now.

Jan 20 2021, 4:06 AM · Restricted Project
serge-sans-paille updated the diff for D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.

Address doc + tool-extra issues

Jan 20 2021, 4:04 AM · Restricted Project

Jan 19 2021

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

As suggested by @aaron.ballman base the detection of top-level-ness on Sema::LookupName to avoid re-implementing the wheel.

Jan 19 2021, 1:40 PM · Restricted Project
serge-sans-paille added a comment to D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.

ping ? This change looks harmless to me, I'd appreciate an ack though.

Jan 19 2021, 4:32 AM · Restricted Project
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Jan 19 2021, 2:00 AM · Restricted Project
serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Up ?

Jan 19 2021, 1:36 AM · Restricted Project
serge-sans-paille committed rGfb5b12e42ef2: [lit] Harmonize lit and llvm versionning (authored by serge-sans-paille).
[lit] Harmonize lit and llvm versionning
Jan 19 2021, 1:27 AM
serge-sans-paille closed D94157: [lit] Harmonize lit and llvm versionning.
Jan 19 2021, 1:27 AM · Restricted Project

Jan 14 2021

serge-sans-paille added a comment to D94734: [lit] Use os.cpu_count() to cleanup TODO.
In D94734#2499865, @yln wrote:

Does the following mean that Python3 is now okay to use for lit?
https://lists.llvm.org/pipermail/llvm-dev/2020-December/147372.html
https://reviews.llvm.org/D93097

Jan 14 2021, 10:32 PM · Restricted Project

Jan 12 2021

serge-sans-paille added a comment to D94387: Add new LLVMComponents CMake module..

First review round. I'm pretty excited by this work, thanks for handling this!

Jan 12 2021, 12:42 AM · Restricted Project

Jan 11 2021

serge-sans-paille requested review of D94420: [clang-tooling] Prevent llvm::fatal_error on invalid CLI option.
Jan 11 2021, 8:12 AM · Restricted Project

Jan 8 2021

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Ignore forward declaration of tagdecl

Jan 8 2021, 7:14 AM · Restricted Project
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Jan 8 2021, 6:44 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Update codebase and testbed to reflect recent discussion.

Jan 8 2021, 6:38 AM · Restricted Project
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Jan 8 2021, 2:16 AM · Restricted Project
serge-sans-paille added a comment to D94157: [lit] Harmonize lit and llvm versionning.

Up?

Jan 8 2021, 2:11 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Address some of the review

Jan 8 2021, 1:33 AM · Restricted Project

Jan 5 2021

serge-sans-paille requested review of D94157: [lit] Harmonize lit and llvm versionning.
Jan 5 2021, 11:18 PM · Restricted Project

Jan 4 2021

serge-sans-paille updated the diff for D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

Rebased on main.

Jan 4 2021, 1:13 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Rebased on main.

Jan 4 2021, 1:03 AM · Restricted Project

Dec 22 2020

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Instead of pretending to be smart, just consider that if the considered decl is at the top level, then it's a top-level decl, otherwise it's not. There may be some interpretation wrt. the standard, but this seems both simple and conservative to me. It gies a few false negative, but it's a warning here, so that should be fine.

Dec 22 2020, 7:07 AM · Restricted Project
serge-sans-paille accepted D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS.

LGTM, thanks!

Dec 22 2020, 2:47 AM · Restricted Project, Restricted Project
serge-sans-paille closed D93097: Remove Python2 fallback and only advertise Python3 in the doc.
Dec 22 2020, 2:05 AM · Restricted Project
serge-sans-paille committed rG6fcb03995648: Fold comparison of __builtin_object_size expression with -1 for non-const size (authored by siddhesh).
Fold comparison of __builtin_object_size expression with -1 for non-const size
Dec 22 2020, 1:57 AM
serge-sans-paille closed D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Dec 22 2020, 1:56 AM · Restricted Project

Dec 21 2020

serge-sans-paille added a comment to D93097: Remove Python2 fallback and only advertise Python3 in the doc.

Commited as of 5e31e226b5b2b682607a6578ff5adb33daf4fe39, I totally messed the differential revision :-)

Dec 21 2020, 11:46 AM · Restricted Project
serge-sans-paille accepted D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

lgtm, thanks!

Dec 21 2020, 5:48 AM · Restricted Project

Dec 18 2020

serge-sans-paille added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

@siddhesh what anout the following?

Dec 18 2020, 6:51 AM · Restricted Project

Dec 17 2020

serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Take review into account, some extra tests suggested by @aaron.ballman and the according modification in Decl.cpp

Dec 17 2020, 12:47 PM · Restricted Project
serge-sans-paille committed rG5e31e226b5b2: Remove Python2 fallback and only advertise Python3 in the doc (authored by serge-sans-paille).
Remove Python2 fallback and only advertise Python3 in the doc
Dec 17 2020, 6:41 AM

Dec 16 2020

serge-sans-paille added inline comments to D93351: [llvm-shlib] Build backend libraries as loadable modules.
Dec 16 2020, 8:59 AM · Restricted Project
serge-sans-paille added inline comments to D93351: [llvm-shlib] Build backend libraries as loadable modules.
Dec 16 2020, 8:41 AM · Restricted Project
serge-sans-paille added a comment to D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.

@rnk what do you find of this approach?

Dec 16 2020, 7:32 AM · Restricted Project
serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Dec 16 2020, 7:21 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

Take review into account and add more tests

Dec 16 2020, 7:18 AM · Restricted Project

Dec 15 2020

serge-sans-paille added a comment to D93095: Introduce -Wreserved-identifier.

I do think it would be good for this to somehow handle macros with reserved names, since macros are one of the primary dangers of using reserved names (if I #define _Tp 0 and then later #include <vector>

Dec 15 2020, 8:38 AM · Restricted Project
serge-sans-paille added inline comments to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.
Dec 15 2020, 2:27 AM · Restricted Project
serge-sans-paille added a comment to D93015: Fold comparison of __builtin_object_size expression with -1 for non-const size.

When __builtin_dynamic_object_size returns a non-constant expression, it cannot be -1 since that is an invalid return value for object size

Dec 15 2020, 2:02 AM · Restricted Project

Dec 14 2020

serge-sans-paille added inline comments to D93095: Introduce -Wreserved-identifier.
Dec 14 2020, 10:41 AM · Restricted Project
serge-sans-paille updated the diff for D93095: Introduce -Wreserved-identifier.

More test cases and updated reserved isReserved()

Dec 14 2020, 10:40 AM · Restricted Project
serge-sans-paille updated the summary of D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE.
Dec 14 2020, 5:54 AM · Restricted Project