Page MenuHomePhabricator
Feed Advanced Search

Yesterday

serge-sans-paille added a comment to D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

@foad / @jdoerfert up ? This is the last missing piece before I can land the pass return status expensive check, aka https://reviews.llvm.org/D80916

Sun, Jul 5, 11:47 PM · Restricted Project

Fri, Jul 3

serge-sans-paille created D83148: Fix cpu architecture detection on x86 during cmake configuration.
Fri, Jul 3, 2:41 PM
serge-sans-paille committed rGc8ef3d5a2f19: Fix stack-clash probing for large static alloca (authored by serge-sans-paille).
Fix stack-clash probing for large static alloca
Fri, Jul 3, 12:30 AM
serge-sans-paille closed D82867: Fix tail allocation for large static alloca.
Fri, Jul 3, 12:30 AM · Restricted Project

Thu, Jul 2

serge-sans-paille added a comment to D82867: Fix tail allocation for large static alloca.

@cupiver. It should be okay for static allocations now.

Thu, Jul 2, 5:20 AM · Restricted Project

Wed, Jul 1

serge-sans-paille committed rGffee80405344: Correctly track GCOVProfiling IR update (authored by serge-sans-paille).
Correctly track GCOVProfiling IR update
Wed, Jul 1, 1:03 AM
serge-sans-paille closed D82742: Correctly track gcov update.
Wed, Jul 1, 1:02 AM · Restricted Project

Tue, Jun 30

serge-sans-paille updated the diff for D82867: Fix tail allocation for large static alloca.

Take review into account: fix check.

Tue, Jun 30, 2:41 PM · Restricted Project
serge-sans-paille added inline comments to D82867: Fix tail allocation for large static alloca.
Tue, Jun 30, 11:56 AM · Restricted Project
serge-sans-paille updated the diff for D82742: Correctly track gcov update.
Tue, Jun 30, 11:24 AM · Restricted Project
serge-sans-paille added a comment to D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

Up!

Tue, Jun 30, 7:00 AM · Restricted Project
serge-sans-paille committed rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB (authored by serge-sans-paille).
Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB
Tue, Jun 30, 6:29 AM
serge-sans-paille closed D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB.
Tue, Jun 30, 6:28 AM · Restricted Project
serge-sans-paille created D82867: Fix tail allocation for large static alloca.
Tue, Jun 30, 5:23 AM · Restricted Project
serge-sans-paille added inline comments to D82867: Fix tail allocation for large static alloca.
Tue, Jun 30, 5:23 AM · Restricted Project

Mon, Jun 29

serge-sans-paille accepted D81762: [CMake] Fix incorrect handling of get_target_property failure.

LGTM, under the assumption you validated it under the relevant setup.

Mon, Jun 29, 2:12 PM · Restricted Project
serge-sans-paille committed rGb4130e6e9964: Correctly report Changed status in FoldBranchToCommonDest (authored by serge-sans-paille).
Correctly report Changed status in FoldBranchToCommonDest
Mon, Jun 29, 9:43 AM
serge-sans-paille closed D82753: Correctly report Changed status in FoldBranchToCommonDest.
Mon, Jun 29, 9:43 AM · Restricted Project
serge-sans-paille created D82753: Correctly report Changed status in FoldBranchToCommonDest.
Mon, Jun 29, 4:17 AM · Restricted Project
serge-sans-paille created D82742: Correctly track gcov update.
Mon, Jun 29, 2:06 AM · Restricted Project

Fri, Jun 26

serge-sans-paille added a comment to D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

@foad should look better now, right?

Fri, Jun 26, 1:08 PM · Restricted Project
serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 26, 12:35 PM · Restricted Project
serge-sans-paille committed rG44f06db43941: Fix pass return status for loop extractor (authored by serge-sans-paille).
Fix pass return status for loop extractor
Fri, Jun 26, 7:04 AM
serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 26, 6:30 AM · Restricted Project
serge-sans-paille committed rG55fe7b79bb7f: Improve LegacyPassManager API to correctly report modified status (authored by serge-sans-paille).
Improve LegacyPassManager API to correctly report modified status
Fri, Jun 26, 5:25 AM
serge-sans-paille closed D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 26, 5:25 AM · Restricted Project
serge-sans-paille added a comment to D82454: [ADT] Add Bitfield utilities - design #3.

LGTM.

Fri, Jun 26, 4:52 AM · Restricted Project
serge-sans-paille added a comment to D82454: [ADT] Add Bitfield utilities - design #3.

@serge-sans-paille let me know what you think of this version.
It's not object oriented but I find it pretty compelling.

Fri, Jun 26, 4:20 AM · Restricted Project

Thu, Jun 25

serge-sans-paille added inline comments to D81762: [CMake] Fix incorrect handling of get_target_property failure.
Thu, Jun 25, 5:14 AM · Restricted Project
serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Thu, Jun 25, 2:40 AM · Restricted Project

Wed, Jun 24

serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

@ekatz any thoughts on this version?

Wed, Jun 24, 9:09 AM · Restricted Project
serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

I think this is the existing behavior and I'm reluctant to define it after years to be invalid without a really good reason (and it's the old PM so it might not be worth it).

Wed, Jun 24, 3:12 AM · Restricted Project
serge-sans-paille added inline comments to D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.
Wed, Jun 24, 3:12 AM · Restricted Project
serge-sans-paille updated the diff for D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

Apply fix suggested in review

Wed, Jun 24, 3:12 AM · Restricted Project

Tue, Jun 23

serge-sans-paille updated the diff for D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

Address reviewer comment.

Tue, Jun 23, 6:53 AM · Restricted Project
serge-sans-paille updated the diff for D81236: Improve LegacyPassManager API to correctly report modified status.

Address @foad remarks

Tue, Jun 23, 6:22 AM · Restricted Project
serge-sans-paille added a comment to D82058: [ADT] Add Bitfield utilities - design #2.

Additional thoughts: even though there wasn't a lot of answers to your initial thread on llvm-dev, I'd post a followup with a few examples of the two approaches to gather some feedback from the community. I personally like this one, obviously :-)

Tue, Jun 23, 6:21 AM · Restricted Project

Mon, Jun 22

serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

Up? This looks in pretty good shape to me.

Mon, Jun 22, 11:04 PM · Restricted Project
serge-sans-paille created D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB.
Mon, Jun 22, 5:52 AM · Restricted Project
serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Mon, Jun 22, 12:29 AM · Restricted Project

Sun, Jun 21

serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Sun, Jun 21, 3:41 AM · Restricted Project

Fri, Jun 19

serge-sans-paille updated the diff for D81236: Improve LegacyPassManager API to correctly report modified status.

Update docstring according to reviews

Fri, Jun 19, 4:49 AM · Restricted Project
serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 19, 4:17 AM · Restricted Project
serge-sans-paille added inline comments to D81236: Improve LegacyPassManager API to correctly report modified status.
Fri, Jun 19, 1:34 AM · Restricted Project
serge-sans-paille updated the diff for D81236: Improve LegacyPassManager API to correctly report modified status.

Update docstring

Fri, Jun 19, 1:34 AM · Restricted Project

Thu, Jun 18

serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

@ekatz I've updated the review title description to better reflect what it actually does. I've kept the review as a single bug to better showcase the usage, but once accepted I'll split it in two commits.

Thu, Jun 18, 11:23 PM · Restricted Project
serge-sans-paille retitled D81236: Improve LegacyPassManager API to correctly report modified status from Improve LegacyPassManager API t correctly report modified status to Improve LegacyPassManager API to correctly report modified status.
Thu, Jun 18, 11:23 PM · Restricted Project
serge-sans-paille retitled D81236: Improve LegacyPassManager API to correctly report modified status from Correctly report modified status for LoopExtractor to Improve LegacyPassManager API t correctly report modified status.
Thu, Jun 18, 11:23 PM · Restricted Project
serge-sans-paille committed rG4dd332723de9: Fix return status of LoopDistribute (authored by serge-sans-paille).
Fix return status of LoopDistribute
Thu, Jun 18, 11:29 AM
serge-sans-paille closed D81225: Correctly report modified status for LoopDistribute.
Thu, Jun 18, 11:27 AM · Restricted Project
serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

Improve the approach by updating the pass manager API to allow to get the pass return status when computing a Lazy analysis.

Thu, Jun 18, 11:26 AM · Restricted Project
serge-sans-paille updated the diff for D81236: Improve LegacyPassManager API to correctly report modified status.

Improve the approach by updating the pass manager API to allow to get the pass return status when computing a Lazy analysis.

Thu, Jun 18, 10:54 AM · Restricted Project
serge-sans-paille updated the diff for D81236: Improve LegacyPassManager API to correctly report modified status.

The legacy pass manager on-the-fly computation isn't meant to report status, which is the origin of the error this patch is trying to fix. Make that more explicit through member function renaming.

Thu, Jun 18, 6:30 AM · Restricted Project
serge-sans-paille committed rGf9c7e3136ed9: Correctly report modified status for HWAddressSanitizer (authored by serge-sans-paille).
Correctly report modified status for HWAddressSanitizer
Thu, Jun 18, 1:36 AM
serge-sans-paille closed D81238: Correctly report modified status for HWAddressSanitizer.
Thu, Jun 18, 1:36 AM · Restricted Project

Wed, Jun 17

serge-sans-paille added a comment to D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

@foad / @nikic does that look good to you?

Wed, Jun 17, 10:13 AM · Restricted Project
serge-sans-paille added a comment to D81238: Correctly report modified status for HWAddressSanitizer.

@vitalybuka I removed the extra part of the patch, is it ok now?

Wed, Jun 17, 10:13 AM · Restricted Project
serge-sans-paille added a comment to D81225: Correctly report modified status for LoopDistribute.

up?

Wed, Jun 17, 10:13 AM · Restricted Project
serge-sans-paille committed rG1cafd8a5d1a3: Fix LoopIdiomRecognize pass return status (authored by serge-sans-paille).
Fix LoopIdiomRecognize pass return status
Wed, Jun 17, 2:40 AM
serge-sans-paille closed D81230: Correctly report modified status for LoopIdiomRecognize.
Wed, Jun 17, 2:40 AM · Restricted Project
serge-sans-paille added inline comments to D81580: [ADT] Add Bitfield utilities - design #1.
Wed, Jun 17, 2:39 AM · Restricted Project
serge-sans-paille added a comment to D81230: Correctly report modified status for LoopIdiomRecognize.

Final comments addressed in the actual commit.

Wed, Jun 17, 2:39 AM · Restricted Project

Tue, Jun 16

serge-sans-paille updated the diff for D81236: Improve LegacyPassManager API to correctly report modified status.

Try another approach and fix the fact that the return status of a lazy transformation is simply ignored.

Tue, Jun 16, 2:18 PM · Restricted Project

Mon, Jun 15

serge-sans-paille added a comment to D81762: [CMake] Fix incorrect handling of get_target_property failure.

Can you share the setup that triggers the error, so that we can reproduce it locally to test the patch?

Mon, Jun 15, 10:32 PM · Restricted Project
serge-sans-paille added a comment to D81230: Correctly report modified status for LoopIdiomRecognize.

@efriedma I believe @serge-sans-paille had D80916 in mind here

Mon, Jun 15, 6:28 AM · Restricted Project
serge-sans-paille updated the diff for D81230: Correctly report modified status for LoopIdiomRecognize.

Use destructor to syndicate cleanup code, as suggested in the review.

Mon, Jun 15, 6:28 AM · Restricted Project
serge-sans-paille updated the diff for D81238: Correctly report modified status for HWAddressSanitizer.

Remove irrelevant part of the patch to focus on HWAdressSanitizer. Sorry for the noise.

Mon, Jun 15, 3:46 AM · Restricted Project

Fri, Jun 12

serge-sans-paille added a comment to D81230: Correctly report modified status for LoopIdiomRecognize.

I'm not against trying to clean up the code; I'm just against asserting that we successfully managed to clean up the memory representation to exactly the same form it was in before we called expandCodeFor.

Fri, Jun 12, 2:40 AM · Restricted Project
serge-sans-paille added a reviewer for D81662: [NFC] Use ADT/Bitfields in Instructions: serge-sans-paille.
Fri, Jun 12, 12:30 AM · Restricted Project
serge-sans-paille added a comment to D81662: [NFC] Use ADT/Bitfields in Instructions.

I really like the extra abstraction layer! Some reviews inline.

Fri, Jun 12, 12:30 AM · Restricted Project

Thu, Jun 11

serge-sans-paille updated the diff for D81238: Correctly report modified status for HWAddressSanitizer.

Take review into account

Thu, Jun 11, 8:46 AM · Restricted Project
serge-sans-paille committed rGbff09876d7cd: Fix return status of DataFlowSanitizer pass (authored by serge-sans-paille).
Fix return status of DataFlowSanitizer pass
Thu, Jun 11, 7:09 AM
serge-sans-paille closed D81239: Correctly report modified status for DataFlowSanitizer.
Thu, Jun 11, 7:09 AM · Restricted Project
serge-sans-paille updated the diff for D81238: Correctly report modified status for HWAddressSanitizer.

Take review into account.

Thu, Jun 11, 1:14 AM · Restricted Project
serge-sans-paille updated the diff for D81239: Correctly report modified status for DataFlowSanitizer.

Take review into account.

Thu, Jun 11, 12:37 AM · Restricted Project

Wed, Jun 10

serge-sans-paille added a comment to D81230: Correctly report modified status for LoopIdiomRecognize.

I'd prefer to conservatively return true, rather than worry about whether calling expandCodeFor and cleaning it up is actually a pure no-op in terms of use-lists etc.

Wed, Jun 10, 11:12 PM · Restricted Project
serge-sans-paille committed rG60fe25cb0c73: Fix dynamic probing scheme (authored by serge-sans-paille).
Fix dynamic probing scheme
Wed, Jun 10, 12:49 PM
serge-sans-paille closed D81067: Fix dynamic probing scheme.
Wed, Jun 10, 12:49 PM · Restricted Project
serge-sans-paille added a comment to D81067: Fix dynamic probing scheme.

Thanks o/

Wed, Jun 10, 12:47 PM · Restricted Project
serge-sans-paille committed rG9daccb7a477b: Correctly update Changed status for SimplifyCFG (authored by serge-sans-paille).
Correctly update Changed status for SimplifyCFG
Wed, Jun 10, 8:15 AM
serge-sans-paille closed D81237: Correctly report modified status for SimplifyCFG and LoopSimplify.
Wed, Jun 10, 8:13 AM · Restricted Project
serge-sans-paille committed rG63489c39deef: Fix version of c-general.profdata.v5 test case (authored by serge-sans-paille).
Fix version of c-general.profdata.v5 test case
Wed, Jun 10, 7:38 AM
serge-sans-paille added a comment to D79961: [PGO] Fix computation of fuction Hash.

It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read as v6 rather than v5. Can you double check?

Wed, Jun 10, 7:37 AM · Restricted Project, Restricted Project
serge-sans-paille accepted D81540: [MemCpyOptimizer] Simplify API of processStore and processMem* functions.

I really like this cleanup step, thanks!

Wed, Jun 10, 4:52 AM · Restricted Project
serge-sans-paille added a comment to D81067: Fix dynamic probing scheme.

@craig.topper ping?

Wed, Jun 10, 1:36 AM · Restricted Project

Tue, Jun 9

serge-sans-paille updated the diff for D81237: Correctly report modified status for SimplifyCFG and LoopSimplify.

Rework FoldBranchToCommonDest to correctly report status, so that we don't make its signature too complex.

Tue, Jun 9, 2:21 PM · Restricted Project
serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

It looks like a limitation of the PM to me, I wonder what's the best approach there... Maybe just a big inline comment, that's gonna be removed once LegacyPM goes out?

Tue, Jun 9, 9:19 AM · Restricted Project
serge-sans-paille added a comment to D81236: Improve LegacyPassManager API to correctly report modified status.

Agreed. I tried to find out where LoopInfoWrapperPass would do this but I didn't spot it right away. @serge-sans-paille do you know where the modification happens or do you happen to have the reproducer?

Tue, Jun 9, 8:46 AM · Restricted Project
serge-sans-paille added inline comments to D81238: Correctly report modified status for HWAddressSanitizer.
Tue, Jun 9, 7:39 AM · Restricted Project
serge-sans-paille updated the diff for D81238: Correctly report modified status for HWAddressSanitizer.

Take remarks into account.

Tue, Jun 9, 7:39 AM · Restricted Project
serge-sans-paille added a comment to D81229: Correctly report modified status for MemCpyOptimizer.

Sorry for the late review, but I think the code is getting really confusing now: processMemCpy returns a "repeat instruction" flag, but sometimes returns true, but also increments BI so that the instruction is not repeated at al???

How about changing all of processMemSet/Cpy/Move so that they return a simple "changed" flag, and set BI to the next instruction to be processed (i.e. either the current instruction if we want to repeat it, otherwise the next instruction).

Tue, Jun 9, 7:05 AM · Restricted Project
serge-sans-paille updated the diff for D81239: Correctly report modified status for DataFlowSanitizer.
Tue, Jun 9, 7:05 AM · Restricted Project
serge-sans-paille added inline comments to D81239: Correctly report modified status for DataFlowSanitizer.
Tue, Jun 9, 7:05 AM · Restricted Project
serge-sans-paille added a comment to D81256: Upgrade TypePromotionTransaction to be able to report changes in CodeGenPrepare.

up?

Tue, Jun 9, 5:59 AM · Restricted Project
serge-sans-paille committed rG5b08bd0eb488: Fix MemCpyOptimizer return status (authored by serge-sans-paille).
Fix MemCpyOptimizer return status
Tue, Jun 9, 5:27 AM
serge-sans-paille committed rGef1a7f2f01db: Update pass status for GCOVProfiling (authored by serge-sans-paille).
Update pass status for GCOVProfiling
Tue, Jun 9, 5:27 AM
serge-sans-paille closed D81229: Correctly report modified status for MemCpyOptimizer.
Tue, Jun 9, 5:27 AM · Restricted Project
serge-sans-paille closed D81227: Correctly report modified status for GCOVProfiling.
Tue, Jun 9, 5:27 AM · Restricted Project

Mon, Jun 8

serge-sans-paille updated the diff for D81230: Correctly report modified status for LoopIdiomRecognize.

Introduce an helper class to aggregate the cleanup in case of rollback.

Mon, Jun 8, 12:42 PM · Restricted Project
serge-sans-paille updated the diff for D81225: Correctly report modified status for LoopDistribute.

Ooops™ uploaded the wrong patch, restoring the correct version.

Mon, Jun 8, 12:41 PM · Restricted Project