Page MenuHomePhabricator
Feed Advanced Search

Today

serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

up!

Tue, Jan 22, 9:31 AM
serge-sans-paille added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

@uabelho top-of-tree should be fine now.

Tue, Jan 22, 6:40 AM
serge-sans-paille added a comment to D56429: fix python3 compability issue.

@roxma: do you want me to commit this on your behalf?

Tue, Jan 22, 5:22 AM
serge-sans-paille added a comment to D56781: Use response file when generating LLVM-C.dll.

@Wallbraker if you don't have commit rights I can commit this one for you.

Tue, Jan 22, 5:22 AM
serge-sans-paille added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

Yeah, I do a final test round and I'll push that one. It's a very touchy piece of code, so I don't want to make all builders fail again...

Tue, Jan 22, 4:59 AM
serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.

Slightly cleaner implementation, added comments and tested with polly.

Tue, Jan 22, 2:30 AM

Yesterday

serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.
Mon, Jan 21, 11:16 PM
serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.

A few comments missing but I'd like to know if this now works correctly on gcc 4.9, @fedor.sergeev , @Anastasia and @sylvestre.ledru . I successfully passed test on a dedicated setup so I guess it's ok...

Mon, Jan 21, 2:37 PM
serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.
Mon, Jan 21, 8:44 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

Patch to be tested available on https://reviews.llvm.org/D57018

Mon, Jan 21, 7:25 AM
serge-sans-paille created D57018: Fix lvm::is_trivially_copyable portability issues.
Mon, Jan 21, 7:24 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

https://godbolt.org/z/KaJ2is seems to be aportable implementaiton of `std::is_copy_assignable`. I'm investigating that.

Mon, Jan 21, 5:51 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

Yeah, I knew from the start that compiling with gcc 8 and clang 6 was not enough for my tests. I've already fixed a few issues with gcc 6, let me try to move forward.

Mon, Jan 21, 5:40 AM

Fri, Jan 18

serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

@rsmith thanks a lot for the final review. I rebased the patch, did a final check with both GCC and Clang, and everything looks fine now. Waiting for a green light!

Fri, Jan 18, 6:32 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.
Fri, Jan 18, 6:25 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.
Fri, Jan 18, 6:20 AM

Thu, Jan 17

serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.

For some reason, all the specialization were not required, so we end up with a very clean implementation. Thanks a lot @rsmith for pointing that out!

Thu, Jan 17, 7:18 AM
serge-sans-paille accepted D56781: Use response file when generating LLVM-C.dll.

LGTM, thanks

Thu, Jan 17, 2:50 AM
serge-sans-paille added a comment to D55782: Fix isInSystemMacro to handle pasted token.

@rsmith up!

Thu, Jan 17, 1:41 AM
serge-sans-paille added inline comments to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Thu, Jan 17, 1:41 AM
serge-sans-paille requested changes to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Thu, Jan 17, 1:41 AM
serge-sans-paille added inline comments to D56781: Use response file when generating LLVM-C.dll.
Thu, Jan 17, 1:11 AM
serge-sans-paille added inline comments to D56819: Document toolchain update policy.
Thu, Jan 17, 1:06 AM

Wed, Jan 16

serge-sans-paille updated the diff for D56437: Support blank flag in SHT_GROUP sections for ELF.

Partial support of SHT_GROUP without flag

Wed, Jan 16, 1:04 PM
serge-sans-paille added inline comments to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Wed, Jan 16, 7:09 AM
serge-sans-paille added inline comments to D56781: Use response file when generating LLVM-C.dll.
Wed, Jan 16, 6:22 AM
serge-sans-paille requested changes to D56781: Use response file when generating LLVM-C.dll.
Wed, Jan 16, 6:22 AM
serge-sans-paille added inline comments to D56781: Use response file when generating LLVM-C.dll.
Wed, Jan 16, 6:18 AM
serge-sans-paille added inline comments to D54472: Disable invalid isPodLike<> specialization.
Wed, Jan 16, 6:02 AM
serge-sans-paille added inline comments to D54472: Disable invalid isPodLike<> specialization.
Wed, Jan 16, 5:59 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.

Take into account @rsmith review.

Wed, Jan 16, 5:59 AM
serge-sans-paille accepted D56429: fix python3 compability issue.
Wed, Jan 16, 1:57 AM
serge-sans-paille updated the diff for D56437: Support blank flag in SHT_GROUP sections for ELF.

Added rough support for dependencies withing a group.

Wed, Jan 16, 1:52 AM

Mon, Jan 14

serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

@ruiu I'm not that fmailiar with ldd codebase but I'll happily give it a try!

Mon, Jan 14, 11:59 PM
serge-sans-paille updated the diff for D55782: Fix isInSystemMacro to handle pasted token.
Mon, Jan 14, 1:15 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

@rsmith: up

Mon, Jan 14, 1:11 AM
serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

@ruiu given you answer to the thread above, I understand we can go on with that review. Anything you're expecting in addition to the current patch?

Mon, Jan 14, 1:09 AM
serge-sans-paille added inline comments to D55523: [clang-tidy] Linting .rst documentation.
Mon, Jan 14, 1:07 AM · Restricted Project
serge-sans-paille resigned from D55827: Update current working directory to avoid test crashes.
Mon, Jan 14, 12:37 AM · Restricted Project
serge-sans-paille added inline comments to D56429: fix python3 compability issue.
Mon, Jan 14, 12:35 AM
serge-sans-paille accepted D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.

LGTM, but only from the point of view of python 2/3 compatibility :-)

Mon, Jan 14, 12:34 AM

Fri, Jan 11

serge-sans-paille accepted D56579: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of writing to stdout..
Fri, Jan 11, 5:29 AM
serge-sans-paille added a comment to D56579: sanitizer_common: Change gen_dynamic_list.py to take a -o argument instead of writing to stdout..

LGTM. I would have kept the default behavior of printing to stdout if -o is not specified, but it's not critical.

Fri, Jan 11, 5:28 AM
serge-sans-paille accepted D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py.

LGTM.

Fri, Jan 11, 5:13 AM

Thu, Jan 10

serge-sans-paille added a comment to D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py.

@Romain-Geissler-1A sure thing. Can you rebase your patch on master first?

Thu, Jan 10, 12:49 AM

Wed, Jan 9

serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

@bd1976llvm interesting. Unfortunately I failed to find this thread :-/

Wed, Jan 9, 10:18 AM
serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

As a follow up to this review (and the original bug), a thread started on the binutils mlist: https://www.sourceware.org/ml/binutils/2019-01/msg00046.html

Wed, Jan 9, 7:40 AM
serge-sans-paille accepted D56422: gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory..
Wed, Jan 9, 7:13 AM
serge-sans-paille resigned from D55376: Generate LLDB website/documentation from rst with Sphinx.
Wed, Jan 9, 7:06 AM

Tue, Jan 8

serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

Thanks @psmith for the context. I just found the culprit line in gas assembler: https://github.com/bminor/binutils-gdb/blob/502c64b9ac12cf2a35d3cb55c51e2eefd33a2494/bfd/elf.c#L3590

Tue, Jan 8, 11:53 PM
serge-sans-paille added a reviewer for D56437: Support blank flag in SHT_GROUP sections for ELF: ruiu.
Tue, Jan 8, 8:32 AM
serge-sans-paille created D56437: Support blank flag in SHT_GROUP sections for ELF.
Tue, Jan 8, 6:41 AM
serge-sans-paille added inline comments to D56429: fix python3 compability issue.
Tue, Jan 8, 12:51 AM

Mon, Jan 7

serge-sans-paille added inline comments to D56422: gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory..
Mon, Jan 7, 10:47 PM
serge-sans-paille accepted D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.
Mon, Jan 7, 10:38 PM
serge-sans-paille updated the diff for D55782: Fix isInSystemMacro to handle pasted token.

Test case added

Mon, Jan 7, 6:03 AM
serge-sans-paille resigned from D54429: [analyzer] Creating standard Sphinx documentation.
Mon, Jan 7, 1:52 AM · Restricted Project
serge-sans-paille added inline comments to D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py.
Mon, Jan 7, 1:51 AM · Restricted Project

Sat, Jan 5

serge-sans-paille accepted D56341: [python] Make the collections import future-proof.

LGTM

Sat, Jan 5, 12:56 AM

Fri, Jan 4

serge-sans-paille resigned from D55917: Introduce Fuchsia builder.
Fri, Jan 4, 1:23 AM
serge-sans-paille accepted D56195: [gn build] Add check-llvm target and make it work.

LGTM, but *only* with respect to the Python 2/3 compatibility of the modification, which is just a drop in the ocean of this patch.

Fri, Jan 4, 1:17 AM

Thu, Jan 3

serge-sans-paille resigned from D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Just wanted to review the change to the Python script to ensure it remains compatible with Python2 and Python3, which is indeed the case; so LGTM on that aspect.

Thu, Jan 3, 8:29 AM
serge-sans-paille updated the diff for D56250: python compat - iterator protocol.
Thu, Jan 3, 7:41 AM
serge-sans-paille updated the diff for D56250: python compat - iterator protocol.
Thu, Jan 3, 7:04 AM
serge-sans-paille added inline comments to D56250: python compat - iterator protocol.
Thu, Jan 3, 6:42 AM
serge-sans-paille updated the diff for D56250: python compat - iterator protocol.
Thu, Jan 3, 6:41 AM
serge-sans-paille updated the diff for D56258: python compat - encode/decode.
Thu, Jan 3, 6:05 AM
serge-sans-paille updated the diff for D56250: python compat - iterator protocol.
Thu, Jan 3, 6:04 AM
serge-sans-paille updated the diff for D56249: python compat - print statement.
Thu, Jan 3, 6:03 AM
serge-sans-paille updated the diff for D56251: python compat - assertraisesregex.
Thu, Jan 3, 6:00 AM
serge-sans-paille added inline comments to D56251: python compat - assertraisesregex.
Thu, Jan 3, 5:42 AM
serge-sans-paille added a comment to D56249: python compat - print statement.

@lebedev.ri : it turns out the only print statement in the two files involved in gbench only have one argument, and they already have the required parethesis. This means that as such, even without the import from future, they work the same in Python2 and Python3. So I will just remove these imports to avoid extra noise.

Thu, Jan 3, 5:34 AM
serge-sans-paille updated the diff for D55196: Python2/3 compatibility - StringIO.
Thu, Jan 3, 4:42 AM
serge-sans-paille updated the diff for D55989: Modernize Python script.
Thu, Jan 3, 3:34 AM
serge-sans-paille created D56262: Python compat - isinstance(x, long).
Thu, Jan 3, 3:27 AM
serge-sans-paille created D56261: Python compat - urllib.
Thu, Jan 3, 3:26 AM
serge-sans-paille created D56260: python compat - has_key.
Thu, Jan 3, 3:26 AM
serge-sans-paille created D56259: python compat - map/filter.
Thu, Jan 3, 3:25 AM
serge-sans-paille created D56258: python compat - encode/decode.
Thu, Jan 3, 3:25 AM
serge-sans-paille created D56257: Python compat - iteritems.
Thu, Jan 3, 3:23 AM
serge-sans-paille created D56256: Python compat - exception.
Thu, Jan 3, 3:23 AM
serge-sans-paille created D56254: remove unused python import.
Thu, Jan 3, 3:22 AM
serge-sans-paille created D56252: python compat - no explicit reference to python version.
Thu, Jan 3, 3:21 AM
serge-sans-paille created D56253: Python compat - range.
Thu, Jan 3, 3:21 AM
serge-sans-paille created D56251: python compat - assertraisesregex.
Thu, Jan 3, 3:20 AM
serge-sans-paille created D56250: python compat - iterator protocol.
Thu, Jan 3, 3:19 AM
serge-sans-paille created D56249: python compat - print statement.
Thu, Jan 3, 3:18 AM

Wed, Jan 2

serge-sans-paille updated the diff for D40249: Copy Function's calling convention by default when creating a new Call.

restoring previous diff, I accidentally uploaded an incorrect one on that review :-/

Wed, Jan 2, 1:28 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

@chandlerc: thanks for the final review! everything should be okay right now, waiting for @rsmith for the final call.

Wed, Jan 2, 1:25 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.
Wed, Jan 2, 1:21 AM
serge-sans-paille updated the diff for D40249: Copy Function's calling convention by default when creating a new Call.
Wed, Jan 2, 1:19 AM

Dec 21 2018

serge-sans-paille added a comment to D55829: LLVM Test suite Python 2/3 compatibility.

@michaelplatings I've split this patch in two so that it's easier to review, see https://reviews.llvm.org/D55989 for the companion patch.

Dec 21 2018, 2:12 AM
serge-sans-paille created D55989: Modernize Python script.
Dec 21 2018, 2:07 AM
serge-sans-paille updated the diff for D55829: LLVM Test suite Python 2/3 compatibility.
Dec 21 2018, 2:07 AM

Dec 20 2018

serge-sans-paille updated the diff for D55196: Python2/3 compatibility - StringIO.
Dec 20 2018, 6:24 AM
serge-sans-paille updated the diff for D55196: Python2/3 compatibility - StringIO.
Dec 20 2018, 6:14 AM

Dec 19 2018

serge-sans-paille added inline comments to D54472: Disable invalid isPodLike<> specialization.
Dec 19 2018, 12:00 PM
serge-sans-paille added inline comments to D54472: Disable invalid isPodLike<> specialization.
Dec 19 2018, 9:37 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

@Quuxplusone this patch has been rebuilt without NDEBUG, which triggered a few minor changes I have commented above. If @chandlerc is fine with current state, we should be able to merge it. Then move on to the llvm::Optional special case.

Dec 19 2018, 5:21 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.
Dec 19 2018, 5:18 AM