Page MenuHomePhabricator
Feed Advanced Search

Today

serge-sans-paille added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Mon, Jun 17, 9:39 AM · Restricted Project

Thu, Jun 13

serge-sans-paille added a comment to D63254: [lit] Fix UnicodeEncodeError when test commands contain non-ASCII chars.

LGTM. Can you add a test case in lit/tests for that?

Thu, Jun 13, 6:18 AM · Restricted Project

Wed, Jun 12

serge-sans-paille committed rG4548c1cfca45: Sanitize llvm-extract -help output (authored by serge-sans-paille).
Sanitize llvm-extract -help output
Wed, Jun 12, 2:06 PM

Tue, Jun 11

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Tue, Jun 11, 8:14 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@beanz : In addition to your suggested changes, I've renamed the cmake utility into add_llvm_pass_plugin to match other functions from AddLLVM.cmake

Tue, Jun 11, 8:14 AM · Restricted Project, Restricted Project

Sat, Jun 8

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Using @beanz idea, provide an option to add_llvm_executable to declare it as receiving plugins, which provides lower coupling with actual plugins

Sat, Jun 8, 8:54 AM · Restricted Project, Restricted Project

Thu, Jun 6

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Just an idea: We could avoid the explicit calls to 'initializeXYZPass' in opt/bugpoint/clang by adding Polly.cpp as a source file or object library to the executables. This would guarantee that its static initializer is called without dynamic library.

Thu, Jun 6, 1:35 PM · Restricted Project, Restricted Project

Wed, Jun 5

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur Itested with the following configuration

Wed, Jun 5, 12:05 PM · Restricted Project, Restricted Project
serge-sans-paille committed rGdaeeb33f8601: Sanitize llvm-size help (authored by serge-sans-paille).
Sanitize llvm-size help
Wed, Jun 5, 3:30 AM
serge-sans-paille updated the diff for D62482: Sanitize llvm-size help.
  • do not set category for positional argument
Wed, Jun 5, 1:09 AM · Restricted Project
serge-sans-paille updated the diff for D62511: Sanitize llvm-extract -help output.

remove category of positional argument

Wed, Jun 5, 12:47 AM · Restricted Project
serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up :-)

Wed, Jun 5, 12:33 AM · Restricted Project
serge-sans-paille added inline comments to D62511: Sanitize llvm-extract -help output.
Wed, Jun 5, 12:21 AM · Restricted Project

Tue, Jun 4

serge-sans-paille committed rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille).
Reduce memory consumption of coverage dumps
Tue, Jun 4, 11:34 PM
serge-sans-paille closed D62623: Reduce memory consumption of coverage dumps.
Tue, Jun 4, 11:34 PM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • get Rid of the constraint on initializePasses : it can be registered suing a static constructor, no need to clutter the API with it
Tue, Jun 4, 11:33 PM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D62623: Reduce memory consumption of coverage dumps.
Tue, Jun 4, 2:46 PM · Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • make it possible for client code to speicify the registration function for new PM, thanks @philip.pfaffe for the hint. @Meinersbur this should be ok now.
Tue, Jun 4, 2:46 PM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Take into account @philip.pfaffe remarks and improve support for new PM.

Tue, Jun 4, 8:43 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@beanz turns out the depdendency problem was just a matter of moving the register_llvm_extension call at the top of the file.

Tue, Jun 4, 4:57 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@philip.pfaffe : NewPM integeration actually works thanks to `Register${Name}Passes(llvm::PassBuilder &PB)`. It's already used by Polly for NewPM integration and we mimic that.

Tue, Jun 4, 4:55 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
  • reorder registration to make sure options are correctly taken into account
  • make LINK_POLLY_INTO_TOOLS obsolete in favor of just using LLVM_LINK_POLLY_INTO_TOOLS
Tue, Jun 4, 4:47 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D62623: Reduce memory consumption of coverage dumps.

Update comment + force reduced memory consumption.

Tue, Jun 4, 3:35 AM · Restricted Project

Mon, Jun 3

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Mon, Jun 3, 2:01 PM · Restricted Project, Restricted Project

Fri, May 31

serge-sans-paille accepted D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..

LGTM

Fri, May 31, 9:59 AM · Restricted Project
serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

I wonder if the LTO pass pipeline shouldn't honor the existing EP_EarlyAsPossible extension point?

Fri, May 31, 12:51 AM · Restricted Project
serge-sans-paille updated the diff for D61738: Provide basic LTO extension points.

Diff updated with context

Fri, May 31, 12:50 AM · Restricted Project

Thu, May 30

serge-sans-paille added a comment to D61738: Provide basic LTO extension points.

@mehdi_amini up :-)

Thu, May 30, 11:34 PM · Restricted Project
serge-sans-paille added a comment to D62623: Reduce memory consumption of coverage dumps.

@kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info.

Thu, May 30, 1:18 AM · Restricted Project

Wed, May 29

serge-sans-paille updated the summary of D62623: Reduce memory consumption of coverage dumps.
Wed, May 29, 1:15 PM · Restricted Project
serge-sans-paille created D62623: Reduce memory consumption of coverage dumps.
Wed, May 29, 1:15 PM · Restricted Project

Tue, May 28

serge-sans-paille added a comment to D62511: Sanitize llvm-extract -help output.

For reference, the output before filtering (but after categorization)

Tue, May 28, 1:37 AM · Restricted Project
serge-sans-paille created D62511: Sanitize llvm-extract -help output.
Tue, May 28, 1:27 AM · Restricted Project

Mon, May 27

serge-sans-paille added a comment to D62482: Sanitize llvm-size help.

For reference, unfiltered output:

Mon, May 27, 5:17 AM · Restricted Project
serge-sans-paille created D62482: Sanitize llvm-size help.
Mon, May 27, 5:17 AM · Restricted Project
serge-sans-paille added a comment to D57830: Add functionality to trace a function within lldb.

LGTM with respect to Python 2/3 compat, can't tell for the functionality though.

Mon, May 27, 1:27 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur up!

Mon, May 27, 1:27 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG6e379e2b68a0: Make llvm-as --help great again (authored by serge-sans-paille).
Make llvm-as --help great again
Mon, May 27, 1:22 AM

Thu, May 23

serge-sans-paille added inline comments to D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class..
Thu, May 23, 10:55 AM · Restricted Project

Wed, May 22

serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

@jhenderson , @ddunbar : I've checked the callgraph of llvm-as, and none of theses flags are actually reachable:

Wed, May 22, 5:48 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur thanks a lot for the feedback. I was only testing with the new project layout, so it's nice you tested with the legacy layout.
I've updated the diff accordingly, it now compiles fine on my Linux box with both old-style and new-style layout.

Wed, May 22, 1:45 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
Wed, May 22, 1:45 AM · Restricted Project, Restricted Project

Tue, May 21

serge-sans-paille added inline comments to D62225: [clang][NewPM] Fixing remaining -O0 tests that are broken under new PM.
Tue, May 21, 11:35 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG94c36fa15ba3: Properly categorize llvm-objdump options (authored by serge-sans-paille).
Properly categorize llvm-objdump options
Tue, May 21, 11:30 PM
serge-sans-paille added a comment to D62195: Properly categorize llvm-objdump options.

Following a remark from @jhenderson , and in order to make sure the options filtered out are not relevant, I've been running a clang-based script to compute the application callgraph, registering all calls to `llvm::cl` commands and their parent.

Tue, May 21, 7:12 AM · Restricted Project
serge-sans-paille added a comment to D62195: Properly categorize llvm-objdump options.

For reference, toe output of -help with and without filtering:

Tue, May 21, 7:09 AM · Restricted Project
serge-sans-paille created D62195: Properly categorize llvm-objdump options.
Tue, May 21, 7:07 AM · Restricted Project

May 17 2019

serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 17 2019, 2:14 PM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 17 2019, 10:28 AM · Restricted Project
serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

Therefore, I recommend removing the SubCommand parameter from this API and always using cl::TopLevelSubCommand.

May 17 2019, 9:55 AM · Restricted Project
serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda / @beanz : I've been thinking about this, and I'm now convinced that this review is probably not the good approach. What we need is a good way to track which options are actually important for a given binary, correctly set the categories of each option and *reallyhide* the others. So I'll pause this review and start working on sanitizing the output of several tools until I get a better understanding of the actual API needs.

May 17 2019, 8:40 AM · Restricted Project

May 16 2019

serge-sans-paille committed rGab155469835a: Fix isInSystemMacro in presence of macro and pasted token (authored by serge-sans-paille).
Fix isInSystemMacro in presence of macro and pasted token
May 16 2019, 5:40 AM

May 15 2019

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@beanz

I expect that we will want to use cl::HideUnrelatedOptions in a lot more places to clean up other tool help messages.

That's indeed the plan.

May 15 2019, 12:46 PM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.

@lebedev.ri doc updated.

May 15 2019, 6:26 AM · Restricted Project
serge-sans-paille updated the diff for D59413: Fix isInSystemMacro in presence of macro and pasted token.

Updated with clang-formated diff

May 15 2019, 5:17 AM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda I've updated the patch taking your advices into account. I took a step ahead and applied the non-conservative signature change for cl::HideUnrelatedOptions

May 15 2019, 5:04 AM · Restricted Project

May 14 2019

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

@hintonda this looks better that way, for sure.

May 14 2019, 6:45 AM · Restricted Project
serge-sans-paille updated the diff for D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 14 2019, 6:44 AM · Restricted Project

May 13 2019

serge-sans-paille added a comment to D61870: Make cl::HideUnrelatedOptionsless error-prone.

It was added in D7100, and I think the rational was to hide implementation details.

May 13 2019, 10:13 PM · Restricted Project
serge-sans-paille created D61870: Make cl::HideUnrelatedOptionsless error-prone.
May 13 2019, 1:23 PM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur I'll be happy to read your feedback on windows compilation!

May 13 2019, 11:34 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG2cabb4dc5baa: Simplify llvm-cat help (authored by serge-sans-paille).
Simplify llvm-cat help
May 13 2019, 4:30 AM
serge-sans-paille closed D61740: Simplify llvm-cat -help.
May 13 2019, 4:30 AM · Restricted Project
serge-sans-paille added a comment to D61740: Simplify llvm-cat -help.

For reference, and following the idea that we should not filter out relevant options, her eis the original output:

May 13 2019, 3:47 AM · Restricted Project

May 10 2019

serge-sans-paille updated the diff for D61740: Simplify llvm-cat -help.

Include full context

May 10 2019, 3:17 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

I will have to try out the patch, e.g. on Windows. Please ping me if it takes to long.

Thanks @Meinersbur

May 10 2019, 1:21 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 10 2019, 1:11 AM · Restricted Project, Restricted Project

May 9 2019

serge-sans-paille added a comment to D59948: Support providing pass schedule to new passmanager as a YAML input.

Up!

May 9 2019, 10:39 AM · Restricted Project
serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

Up!

May 9 2019, 10:37 AM · Restricted Project
serge-sans-paille created D61740: Simplify llvm-cat -help.
May 9 2019, 9:09 AM · Restricted Project
serge-sans-paille created D61738: Provide basic LTO extension points.
May 9 2019, 8:51 AM · Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@mehdi_amini I've updated the .tgz sample so that one could see that the expected CMakelists.txt for third-party compiler extensions is now super-simple.

May 9 2019, 1:07 AM · Restricted Project, Restricted Project

May 8 2019

serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 8 2019, 12:17 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Update diff to make it less intrusive: using a declarative approach, each compiler extension registers itself as an extension, and thanks to cmake-generator-expression, it's possible to delay the evaluation of linked extensions until all extensions registered.

May 8 2019, 12:13 AM · Restricted Project, Restricted Project

May 7 2019

serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

@Meinersbur, I've tested and reviewed this patch, I'm curious about Polly's team opinion on the changes in current state?
@mehdi_amini, Did I correctly capture your remarks on llvm-projects?

May 7 2019, 9:34 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Tested withe the following dummy project: https://sergesanspaille.fedorapeople.org/bye.tgz

May 7 2019, 6:52 AM · Restricted Project, Restricted Project

May 6 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 6 2019, 5:40 AM · Restricted Project, Restricted Project
serge-sans-paille added inline comments to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 6 2019, 4:42 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Update diff to make it compatible with llvm projects.

May 6 2019, 4:42 AM · Restricted Project, Restricted Project

May 3 2019

serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 3 2019, 8:15 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Do you intent to use this interface for a specific external project, or is it to avoid direct references to Polly?

May 3 2019, 1:40 AM · Restricted Project, Restricted Project
serge-sans-paille updated the diff for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.

Patch update:

  • make it possible for extension to register extra tool dependency
  • accept the all target to automatically detect official extensions (namely Polly as of now)
  • ship clang patch
May 3 2019, 1:25 AM · Restricted Project, Restricted Project

May 2 2019

serge-sans-paille added a reviewer for D61446: Generalize the pass registration mechanism used by Polly to any third-party tool: Meinersbur.
May 2 2019, 9:18 AM · Restricted Project, Restricted Project
serge-sans-paille created D61446: Generalize the pass registration mechanism used by Polly to any third-party tool.
May 2 2019, 9:11 AM · Restricted Project, Restricted Project

Apr 30 2019

serge-sans-paille added a comment to D59413: Fix isInSystemMacro in presence of macro and pasted token.

@rsmith : up :-)

Apr 30 2019, 1:55 AM · Restricted Project

Apr 12 2019

serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

@jhenderson I've added a few potential reviewers based on the file history.

Apr 12 2019, 3:26 AM · Restricted Project
serge-sans-paille added reviewers for D60603: Make llvm-as --help great again: tejohnson, ddunbar.
Apr 12 2019, 3:26 AM · Restricted Project
serge-sans-paille updated the diff for D60603: Make llvm-as --help great again.

Including test case

Apr 12 2019, 2:50 AM · Restricted Project
serge-sans-paille created D60603: Make llvm-as --help great again.
Apr 12 2019, 2:46 AM · Restricted Project
serge-sans-paille added a comment to D60603: Make llvm-as --help great again.

Without category filtered:

Apr 12 2019, 2:46 AM · Restricted Project

Apr 11 2019

serge-sans-paille committed rG3742bb89f83f: Make llvm-nm -help great again (authored by serge-sans-paille).
Make llvm-nm -help great again
Apr 11 2019, 8:22 AM
serge-sans-paille updated the diff for D60411: Filter out irrelevant llvm-nm option.

Fun fact: when --help is active, no error is reported for invalid options :-) Fixed.

Apr 11 2019, 6:14 AM · Restricted Project
serge-sans-paille added a comment to D60411: Filter out irrelevant llvm-nm option.

Splitting on a character would make a lot of sense. Most tools use '=' or similar for multi-string arguments.

Apr 11 2019, 5:14 AM · Restricted Project
serge-sans-paille updated the diff for D60411: Filter out irrelevant llvm-nm option.

Update test

Apr 11 2019, 5:12 AM · Restricted Project

Apr 10 2019

serge-sans-paille updated the diff for D60411: Filter out irrelevant llvm-nm option.

alias don"t need to be marked as part of a category, this makes the diff shorter. Same for positional argument. New output:

Apr 10 2019, 1:19 PM · Restricted Project
serge-sans-paille added inline comments to D60411: Filter out irrelevant llvm-nm option.
Apr 10 2019, 4:59 AM · Restricted Project
serge-sans-paille added a comment to D60411: Filter out irrelevant llvm-nm option.
% ./bin/llvm-nm --help
OVERVIEW: llvm symbol table dumper
Apr 10 2019, 4:59 AM · Restricted Project

Apr 8 2019

serge-sans-paille created D60411: Filter out irrelevant llvm-nm option.
Apr 8 2019, 8:52 AM · Restricted Project

Apr 5 2019

serge-sans-paille added a comment to D59948: Support providing pass schedule to new passmanager as a YAML input.

@chandlerc up!

Apr 5 2019, 1:55 AM · Restricted Project

Apr 3 2019

serge-sans-paille abandoned D59810: Always support masm syntax when intel dialect is active.

GNU as compatibility totally makes sense, dropping the patch, and thanks for the detailed answer!

Apr 3 2019, 12:19 AM · Restricted Project