Page MenuHomePhabricator
Feed Advanced Search

Fri, Mar 15

serge-sans-paille created D59413: Fix isInSystemMacro in presence of macro and pasted token.
Fri, Mar 15, 6:58 AM · Restricted Project

Wed, Mar 6

serge-sans-paille abandoned D58117: Workaround std::thread begin not copy-constructible.

I confirm the bug has been fixed in trunk gcc and in fedora rawhide's gcc, closing the issue.

Wed, Mar 6, 5:03 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D58546: [lit] Honor PYTHONPATH for llvm tests.

I'd rather have it here than in lit. As a test environment, I love it when there's as few environment values that depends on the launch site as possible. It makes reproducibility easier.

Wed, Mar 6, 4:56 AM · Restricted Project
serge-sans-paille accepted D58803: Corrected some typos..

LGTM, do you have commit rights?

Wed, Mar 6, 4:53 AM

Thu, Feb 28

serge-sans-paille committed rG54be909aa08d: Add Support for Creating and Deleting Unicode Files and Directories in Lit (authored by serge-sans-paille).
Add Support for Creating and Deleting Unicode Files and Directories in Lit
Thu, Feb 28, 11:16 AM

Tue, Feb 26

serge-sans-paille added a comment to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.

@jmittert sorry for the long delay, but I'm finally fine with this patch now. I like how it explicitly emphasizes on the Windows/Linux difference. However the patch needs to be rebased against master, can you update it?

Tue, Feb 26, 2:41 AM · Restricted Project
serge-sans-paille added a comment to D58117: Workaround std::thread begin not copy-constructible.

I've reported this strange behavior to gcc https://bugzilla.redhat.com/show_bug.cgi?id=1678613

Tue, Feb 26, 2:33 AM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D58118: Fix llvm-config behavior when LLVM_TOOLS_INSTALL_DIR has a depth greater than one.

@sylvestre.ledru up :-)

Tue, Feb 26, 2:27 AM · Restricted Project

Mon, Feb 25

serge-sans-paille abandoned D58193: Do not explicitly depend on llvm tools during standalone build.

@sgraenitz It's fixed! I'm dropping this patch then, thanks for investigating o/

Mon, Feb 25, 5:20 AM · Restricted Project

Wed, Feb 20

serge-sans-paille committed rG77ac7028b4d4: Revert r354546 (authored by serge-sans-paille).
Revert r354546
Wed, Feb 20, 10:59 PM
serge-sans-paille committed rG1380c6bf28a3: Fix typo in r354546 (authored by serge-sans-paille).
Fix typo in r354546
Wed, Feb 20, 10:13 PM
serge-sans-paille added a comment to D58193: Do not explicitly depend on llvm tools during standalone build.

@sgraenitz : it's possible that r352382 fixes my issue. I'll double check that first!

Wed, Feb 20, 9:33 PM · Restricted Project
serge-sans-paille committed rG7cfd5b663462: [NFC] Always initialize all members in ABIArgInfo (authored by serge-sans-paille).
[NFC] Always initialize all members in ABIArgInfo
Wed, Feb 20, 8:58 PM
serge-sans-paille added a comment to D57523: Fix uninitialized value in ABIArgInfo.

@hans agreed; Thanks for taking the time to try to reproduce the original issue o/

Wed, Feb 20, 8:50 PM · Restricted Project, Restricted Project

Tue, Feb 19

serge-sans-paille committed rG3d13ed978ab8: [NFC] Remove unused headers in Optional.h (authored by serge-sans-paille).
[NFC] Remove unused headers in Optional.h
Tue, Feb 19, 10:04 AM
serge-sans-paille added a comment to D58117: Workaround std::thread begin not copy-constructible.

Fedora is currently using gcc-9.0.1, svn revision 268719 (see https://src.fedoraproject.org/rpms/gcc/blob/master/f/gcc.spec) which triggers this issue. I'll forward the test case to the gcc team and report here.

Tue, Feb 19, 12:17 AM · Restricted Project, Restricted Project

Mon, Feb 18

serge-sans-paille added a comment to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

Some follow-up on this review: I had to revert the associated commit because it was breaking on buildbot, on test case I failed to reproduce locally.

Mon, Feb 18, 1:16 PM · Restricted Project
serge-sans-paille added a comment to D58117: Workaround std::thread begin not copy-constructible.

There should be an rvalue overload of std::vector<T>::push_back - is there not? ( https://en.cppreference.com/w/cpp/container/vector/push_back )

Mon, Feb 18, 1:06 PM · Restricted Project, Restricted Project
serge-sans-paille added a comment to D58193: Do not explicitly depend on llvm tools during standalone build.

@sgraenitz I currently have this patch applied to LLVM 8rc1 source tree for fedora, because it wasn't working automagically otherwise. Reading the discussion, I don't think I missed some configuration stuff, or what did I miss when configuring the build of lldb in standalone mode?

Mon, Feb 18, 6:33 AM · Restricted Project
serge-sans-paille committed rG6e0b562bf6e0: [NFC] Make Optional<T> trivially copyable when T is trivially copyable (authored by serge-sans-paille).
[NFC] Make Optional<T> trivially copyable when T is trivially copyable
Mon, Feb 18, 4:07 AM
serge-sans-paille committed rGfb9730575086: Recommit [NFC] Better encapsulation of llvm::Optional Storage (authored by serge-sans-paille).
Recommit [NFC] Better encapsulation of llvm::Optional Storage
Mon, Feb 18, 12:48 AM

Sun, Feb 17

serge-sans-paille added a comment to D58117: Workaround std::thread begin not copy-constructible.

Yeah, especially as he copy constructor is deleted, push_back implies a copy, so relying on the compiler to optimize to a move seems fragile.

Sun, Feb 17, 9:56 PM · Restricted Project, Restricted Project
serge-sans-paille committed rG649e3d01c6e5: Revert [NFC] Better encapsulation of llvm::Optional Storage (authored by serge-sans-paille).
Revert [NFC] Better encapsulation of llvm::Optional Storage
Sun, Feb 17, 3:03 PM
serge-sans-paille committed rGf54981c56749: [NFC] Better encapsulation of llvm::Optional Storage, part II (authored by serge-sans-paille).
[NFC] Better encapsulation of llvm::Optional Storage, part II
Sun, Feb 17, 2:54 PM
serge-sans-paille committed rG028fc58028ec: [NFC] Better encapsulation of llvm::Optional Storage (authored by serge-sans-paille).
[NFC] Better encapsulation of llvm::Optional Storage
Sun, Feb 17, 2:46 PM
serge-sans-paille committed rGd37afc92aa52: Revert [NFC] Better encapsulation of llvm::Optional Storage (authored by serge-sans-paille).
Revert [NFC] Better encapsulation of llvm::Optional Storage
Sun, Feb 17, 7:04 AM
serge-sans-paille committed rG07df86c3774a: [NFC] Better encapsulation of llvm::Optional Storage (authored by serge-sans-paille).
[NFC] Better encapsulation of llvm::Optional Storage
Sun, Feb 17, 5:13 AM

Feb 16 2019

serge-sans-paille committed rG099cbc3e468d: Revert r354199: Make Optional<T> Trivially Copyable when T is trivially copyable (authored by serge-sans-paille).
Revert r354199: Make Optional<T> Trivially Copyable when T is trivially copyable
Feb 16 2019, 1:47 AM
serge-sans-paille committed rG98b4fd82b72f: Make Optional<T> Trivially Copyable when T is trivially copyable (authored by serge-sans-paille).
Make Optional<T> Trivially Copyable when T is trivially copyable
Feb 16 2019, 1:20 AM

Feb 15 2019

serge-sans-paille committed rGb5d00c9b73ef: Revert r354137 - OptionalStorage implementation for trivial type, take III (authored by serge-sans-paille).
Revert r354137 - OptionalStorage implementation for trivial type, take III
Feb 15 2019, 8:15 AM
serge-sans-paille committed rGfb4df68f4870: OptionalStorage implementation for trivial type, take III (authored by serge-sans-paille).
OptionalStorage implementation for trivial type, take III
Feb 15 2019, 7:17 AM

Feb 14 2019

serge-sans-paille committed rG794b53673667: Optional specialization for trivially copyable types, part2 (authored by serge-sans-paille).
Optional specialization for trivially copyable types, part2
Feb 14 2019, 11:46 AM
serge-sans-paille committed rG4d0934c48f36: Recommit Optional specialization for trivially copyable types (authored by serge-sans-paille).
Recommit Optional specialization for trivially copyable types
Feb 14 2019, 11:19 AM

Feb 13 2019

serge-sans-paille committed rG221c39165da5: Revert r353962 (authored by serge-sans-paille).
Revert r353962
Feb 13 2019, 2:12 PM
serge-sans-paille committed rGf688293393f1: Re-commit rL353927, patch included (authored by serge-sans-paille).
Re-commit rL353927, patch included
Feb 13 2019, 10:12 AM
serge-sans-paille created D58193: Do not explicitly depend on llvm tools during standalone build.
Feb 13 2019, 10:08 AM · Restricted Project
serge-sans-paille added inline comments to D58177: Fix lldb-server test suite for python3.
Feb 13 2019, 7:11 AM · Restricted Project
serge-sans-paille committed rG699c22839a45: Revert r353927 (authored by serge-sans-paille).
Revert r353927
Feb 13 2019, 3:36 AM
serge-sans-paille committed rGf8ffb926e206: Missing header (authored by serge-sans-paille).
Missing header
Feb 13 2019, 2:19 AM
serge-sans-paille committed rGab061d351eaa: Make llvm::Optional<T> trivially copyable when T is trivially copyable (authored by serge-sans-paille).
Make llvm::Optional<T> trivially copyable when T is trivially copyable
Feb 13 2019, 1:31 AM

Feb 12 2019

serge-sans-paille created D58118: Fix llvm-config behavior when LLVM_TOOLS_INSTALL_DIR has a depth greater than one.
Feb 12 2019, 6:46 AM · Restricted Project
serge-sans-paille created D58117: Workaround std::thread begin not copy-constructible.
Feb 12 2019, 6:40 AM · Restricted Project, Restricted Project

Feb 11 2019

serge-sans-paille added a comment to D57528: [tools] Fix python DeprecationWarning: invalid escape sequence.

@MarcoFalke it's in, thanks for the patch o/

Feb 11 2019, 7:05 AM · Restricted Project, Restricted Project
serge-sans-paille committed rG3331b6eab397: [tools] Fix python DeprecationWarning: invalid escape sequence (authored by serge-sans-paille).
[tools] Fix python DeprecationWarning: invalid escape sequence
Feb 11 2019, 7:03 AM
serge-sans-paille accepted D57528: [tools] Fix python DeprecationWarning: invalid escape sequence.

LGTM, do you have commit right?

Feb 11 2019, 12:20 AM · Restricted Project, Restricted Project

Feb 9 2019

serge-sans-paille added a comment to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

@chandlerc patch updated, using inheritance to avoid too much duplication.

Feb 9 2019, 4:18 AM · Restricted Project
serge-sans-paille updated the diff for D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.
Feb 9 2019, 4:18 AM · Restricted Project

Feb 8 2019

serge-sans-paille added a comment to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.

@jmittert I tried the following (simpler) patch on Linux and it seems to work nice for both Python2 and Python3

Feb 8 2019, 2:47 AM · Restricted Project
serge-sans-paille added a comment to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

@chandlerc there's indeed some redundancy that can be removed unfortunately, as you feared, defaulting seems incompatible with per-member specialization, or at least it hits my c++ knowledge limit.

Feb 8 2019, 12:10 AM · Restricted Project

Feb 5 2019

Herald added a project to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable: Restricted Project.

up!

Feb 5 2019, 5:06 AM · Restricted Project
serge-sans-paille added a comment to D57505: gn build: Fix Python 3 write_vcsrevision script compatibility.

@andrew-boyarshin : It's in! Thanks for the contribution o/

Feb 5 2019, 5:01 AM · Restricted Project
serge-sans-paille committed rGcad6336675b5: gn build: Fix Python 3 write_vcsrevision script compatibility (authored by serge-sans-paille).
gn build: Fix Python 3 write_vcsrevision script compatibility
Feb 5 2019, 5:01 AM
serge-sans-paille updated the diff for D57744: Python3 support: print-statement.
Feb 5 2019, 4:56 AM · Restricted Project
serge-sans-paille created D57744: Python3 support: print-statement.
Feb 5 2019, 3:59 AM · Restricted Project
serge-sans-paille added a comment to D57505: gn build: Fix Python 3 write_vcsrevision script compatibility.

@andrew-boyarshin do you have commit right?

Feb 5 2019, 3:55 AM · Restricted Project

Jan 31 2019

serge-sans-paille added a comment to D55782: Fix isInSystemMacro to handle pasted token.

It's in, thanks @rsmith for the review.

Jan 31 2019, 10:36 PM · Restricted Project
serge-sans-paille added a reviewer for D57523: Fix uninitialized value in ABIArgInfo: majnemer.
Jan 31 2019, 12:16 PM · Restricted Project, Restricted Project
serge-sans-paille created D57523: Fix uninitialized value in ABIArgInfo.
Jan 31 2019, 9:35 AM · Restricted Project, Restricted Project

Jan 30 2019

serge-sans-paille added inline comments to D55782: Fix isInSystemMacro to handle pasted token.
Jan 30 2019, 4:42 AM · Restricted Project
serge-sans-paille updated the diff for D55782: Fix isInSystemMacro to handle pasted token.

Patch updated to take into account @rsmith remarks. Test case added as an illustration.

Jan 30 2019, 4:39 AM · Restricted Project

Jan 28 2019

serge-sans-paille added reviewers for D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable: rsmith, chandlerc.
Jan 28 2019, 11:13 PM · Restricted Project

Jan 24 2019

serge-sans-paille accepted D56774: Build LLVM-C.dll by default on windows and enable in release package.
Jan 24 2019, 6:38 AM
serge-sans-paille added inline comments to D56774: Build LLVM-C.dll by default on windows and enable in release package.
Jan 24 2019, 5:31 AM
serge-sans-paille added a comment to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

Also validates ok with clang 6.0.1 and gcc 4.8.5

Jan 24 2019, 4:45 AM · Restricted Project
serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

@ruiu It works fine, I just moved the comdat-related insertion after the flag check. It compiles and validates fine on my setup.

Jan 24 2019, 3:00 AM
serge-sans-paille updated the diff for D56437: Support blank flag in SHT_GROUP sections for ELF.
Jan 24 2019, 2:59 AM
serge-sans-paille added inline comments to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Jan 24 2019, 2:43 AM · Restricted Project
serge-sans-paille added a comment to D56429: fix python3 compability issue.

Thanks @roxma for the patch!

Jan 24 2019, 2:35 AM

Jan 23 2019

serge-sans-paille added a comment to D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.

This validates with gcc 8.2. Given the history of llvm::Optional, I'm going to try to build with other compilers too.

Jan 23 2019, 9:48 AM · Restricted Project
serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

@ruiu is this minimal patch ok to you?

Jan 23 2019, 6:45 AM
serge-sans-paille created D57097: Make llvm::Optional<T> trivially copyable when T is trivially copyable.
Jan 23 2019, 6:12 AM · Restricted Project

Jan 22 2019

serge-sans-paille requested changes to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Jan 22 2019, 11:34 AM · Restricted Project
serge-sans-paille accepted D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Jan 22 2019, 11:34 AM · Restricted Project
serge-sans-paille added a comment to D56437: Support blank flag in SHT_GROUP sections for ELF.

up!

Jan 22 2019, 9:31 AM
serge-sans-paille added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

@uabelho top-of-tree should be fine now.

Jan 22 2019, 6:40 AM
serge-sans-paille added a comment to D56429: fix python3 compability issue.

@roxma: do you want me to commit this on your behalf?

Jan 22 2019, 5:22 AM
serge-sans-paille added a comment to D56781: Use response file when generating LLVM-C.dll.

@Wallbraker if you don't have commit rights I can commit this one for you.

Jan 22 2019, 5:22 AM
serge-sans-paille added a comment to D57018: Fix lvm::is_trivially_copyable portability issues.

Yeah, I do a final test round and I'll push that one. It's a very touchy piece of code, so I don't want to make all builders fail again...

Jan 22 2019, 4:59 AM
serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.

Slightly cleaner implementation, added comments and tested with polly.

Jan 22 2019, 2:30 AM

Jan 21 2019

serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.
Jan 21 2019, 11:16 PM
serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.

A few comments missing but I'd like to know if this now works correctly on gcc 4.9, @fedor.sergeev , @Anastasia and @sylvestre.ledru . I successfully passed test on a dedicated setup so I guess it's ok...

Jan 21 2019, 2:37 PM
serge-sans-paille updated the diff for D57018: Fix lvm::is_trivially_copyable portability issues.
Jan 21 2019, 8:44 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

Patch to be tested available on https://reviews.llvm.org/D57018

Jan 21 2019, 7:25 AM
serge-sans-paille created D57018: Fix lvm::is_trivially_copyable portability issues.
Jan 21 2019, 7:24 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

https://godbolt.org/z/KaJ2is seems to be aportable implementaiton of `std::is_copy_assignable`. I'm investigating that.

Jan 21 2019, 5:51 AM
serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

Yeah, I knew from the start that compiling with gcc 8 and clang 6 was not enough for my tests. I've already fixed a few issues with gcc 6, let me try to move forward.

Jan 21 2019, 5:40 AM

Jan 18 2019

serge-sans-paille added a comment to D54472: Disable invalid isPodLike<> specialization.

@rsmith thanks a lot for the final review. I rebased the patch, did a final check with both GCC and Clang, and everything looks fine now. Waiting for a green light!

Jan 18 2019, 6:32 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.
Jan 18 2019, 6:25 AM
serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.
Jan 18 2019, 6:20 AM

Jan 17 2019

serge-sans-paille updated the diff for D54472: Disable invalid isPodLike<> specialization.

For some reason, all the specialization were not required, so we end up with a very clean implementation. Thanks a lot @rsmith for pointing that out!

Jan 17 2019, 7:18 AM
serge-sans-paille accepted D56781: Use response file when generating LLVM-C.dll.

LGTM, thanks

Jan 17 2019, 2:50 AM
serge-sans-paille added a comment to D55782: Fix isInSystemMacro to handle pasted token.

@rsmith up!

Jan 17 2019, 1:41 AM · Restricted Project
serge-sans-paille added inline comments to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Jan 17 2019, 1:41 AM · Restricted Project
serge-sans-paille requested changes to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Jan 17 2019, 1:41 AM · Restricted Project
serge-sans-paille added inline comments to D56781: Use response file when generating LLVM-C.dll.
Jan 17 2019, 1:11 AM
serge-sans-paille added inline comments to D56819: Document toolchain update policy.
Jan 17 2019, 1:06 AM

Jan 16 2019

serge-sans-paille updated the diff for D56437: Support blank flag in SHT_GROUP sections for ELF.

Partial support of SHT_GROUP without flag

Jan 16 2019, 1:04 PM
serge-sans-paille added inline comments to D56754: Add Support for Creating and Deleting Unicode Files and Directories in Lit.
Jan 16 2019, 7:09 AM · Restricted Project
serge-sans-paille added inline comments to D56781: Use response file when generating LLVM-C.dll.
Jan 16 2019, 6:22 AM
serge-sans-paille requested changes to D56781: Use response file when generating LLVM-C.dll.
Jan 16 2019, 6:22 AM