Page MenuHomePhabricator
Feed Advanced Search

Today

CarolineConcatto added reviewers for D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register.: sdesmalen, SjoerdMeijer, c-rhodes.
Mon, Oct 26, 6:59 AM · Restricted Project
CarolineConcatto requested review of D90153: [AArch64][AsmParser] Remove 'x31' alias for 'sp/xzr' register..
Mon, Oct 26, 6:50 AM · Restricted Project

Fri, Oct 23

CarolineConcatto committed rG241563647555: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms (authored by CarolineConcatto).
[SVE]Clarify TypeSize comparisons in llvm/lib/Transforms
Fri, Oct 23, 1:16 AM
CarolineConcatto closed D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Fri, Oct 23, 1:15 AM · Restricted Project

Wed, Oct 21

CarolineConcatto retitled D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms from [SVE][ValueTracking] Clarify TypeSize comparisons in llvm/lib/Transforms to [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Wed, Oct 21, 8:11 AM · Restricted Project
CarolineConcatto added a comment to D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.

Thank you Sander and David.
I've changed the points you've raised.
I had to run some test to make sure no scalable vectors would reach the places you've raised.
We can relax, atm no scalable vectors can reach the paths where we are using getFixedSize().

Wed, Oct 21, 7:59 AM · Restricted Project
CarolineConcatto updated the diff for D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.

-address review's comments

Wed, Oct 21, 7:54 AM · Restricted Project

Mon, Oct 19

CarolineConcatto added reviewers for D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms: david-arm, sdesmalen.
Mon, Oct 19, 8:16 AM · Restricted Project
CarolineConcatto requested review of D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Mon, Oct 19, 8:12 AM · Restricted Project

Fri, Oct 16

CarolineConcatto committed rGe8d9ee9c7cfe: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang (authored by CarolineConcatto).
[SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang
Fri, Oct 16, 3:23 AM
CarolineConcatto closed D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Fri, Oct 16, 3:22 AM · Restricted Project

Thu, Oct 15

CarolineConcatto committed rG145e44bb1885: [SVE]Fix implicit TypeSize casts in EmitCheckValue (authored by CarolineConcatto).
[SVE]Fix implicit TypeSize casts in EmitCheckValue
Thu, Oct 15, 5:31 AM
CarolineConcatto closed D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Thu, Oct 15, 5:30 AM · Restricted Project

Tue, Oct 13

CarolineConcatto retitled D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang from [SVE][CodeGen]Use TypeSize comparison functions in clang to [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Tue, Oct 13, 9:22 AM · Restricted Project
CarolineConcatto updated the diff for D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.

-Use getFixedSize instead of isKnowXY

Tue, Oct 13, 9:20 AM · Restricted Project
CarolineConcatto updated the summary of D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Tue, Oct 13, 7:21 AM · Restricted Project
CarolineConcatto updated the summary of D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Tue, Oct 13, 7:19 AM · Restricted Project
CarolineConcatto retitled D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue from Fix implicit TypeSize casts in EmitCheckValue to [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Tue, Oct 13, 6:53 AM · Restricted Project
CarolineConcatto added a reviewer for D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue: sdesmalen.
Tue, Oct 13, 6:52 AM · Restricted Project
CarolineConcatto retitled D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang from [SVE][CodeGen]Use TypeSize comparison operators in clang to [SVE][CodeGen]Use TypeSize comparison functions in clang.
Tue, Oct 13, 6:52 AM · Restricted Project
CarolineConcatto added a reviewer for D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue: david-arm.
Tue, Oct 13, 6:15 AM · Restricted Project
CarolineConcatto requested review of D89313: [SVE]Fix implicit TypeSize casts in EmitCheckValue.
Tue, Oct 13, 6:14 AM · Restricted Project
CarolineConcatto added a reviewer for D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang: david-arm.
Tue, Oct 13, 5:43 AM · Restricted Project
CarolineConcatto requested review of D89312: [SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang.
Tue, Oct 13, 5:43 AM · Restricted Project

Fri, Oct 9

CarolineConcatto accepted D89030: flang-aarch64: Refine the number of parallel jobs.

Thank you @awarzynski.

Fri, Oct 9, 12:06 AM

Tue, Oct 6

CarolineConcatto accepted D88874: flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs.

Thank you @awarzynski for making the slave faster.

Tue, Oct 6, 2:51 AM

Mon, Oct 5

CarolineConcatto accepted D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you @awarzynski for working on this.
It is good because now we do not depend on clang frontend to build flang frontend.
LGTM

Mon, Oct 5, 2:27 AM · Restricted Project
CarolineConcatto accepted D88811: flang-aarch64-ubuntu-clang: Refine the set-up for `-WError`.

LGTM

Mon, Oct 5, 1:09 AM

Sun, Oct 4

CarolineConcatto added a reviewer for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: sameeranjoshi.
Sun, Oct 4, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@awarzynski patch updated.

Sun, Oct 4, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

address reviews comment

Sun, Oct 4, 11:47 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 28

CarolineConcatto added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Hi Folks,
@awarzynski and @kiranchandramohan, Diana was working in an out-of-tree build.

Mon, Sep 28, 11:58 PM · Restricted Project
CarolineConcatto added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you @awarzynski for updating the patch.
It looks good to me. I've build it locally and played a little bit.
It works fine with gcc9.3. I did not try to build out-of-tree. But I don't see any reason it should not work.
I have two minor comments. But besides that the patch looks good to me.
If you fix them it is all fine for me.

Mon, Sep 28, 1:27 AM · Restricted Project
CarolineConcatto retitled D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O from [Flang][Driver] Add InputOutputTest frontend action with new -test-IO flag to [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
Mon, Sep 28, 1:03 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Remove -E from FlangOptions

Mon, Sep 28, 12:09 AM · Restricted Project, Restricted Project

Sun, Sep 27

CarolineConcatto added a reviewer for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction: awarzynski.
Sun, Sep 27, 10:41 AM · Restricted Project, Restricted Project
CarolineConcatto updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Fix typos

Sun, Sep 27, 10:40 AM · Restricted Project, Restricted Project
CarolineConcatto requested review of D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.
Sun, Sep 27, 10:33 AM · Restricted Project, Restricted Project

Sep 25 2020

CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Rebase on top of master

Sep 25 2020, 9:53 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@awarzynski thank you for the review.
It is a big patch to review at once.
I accepted almost all of your changes.

Sep 25 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Solve review comments

Sep 25 2020, 5:42 AM · Restricted Project, Restricted Project, Restricted Project

Sep 24 2020

CarolineConcatto added inline comments to D88219: [flang][driver] Remove unnecessary includes in the unittest.
Sep 24 2020, 5:15 AM · Restricted Project

Sep 23 2020

CarolineConcatto accepted D88108: [flang][driver] Fix options flang in the frontend driver.

Thank you @awarzynski.
I've missed that on the previous patch.

Sep 23 2020, 2:23 AM · Restricted Project

Sep 22 2020

CarolineConcatto added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you @awarzynski for this patch.
Very good that you added color feature for Fortran.
It is just a shame that we do not test. Is there a way to add a regression test for it?
I don't see any inconsistency with what we have on clang side, so it is good.
My comments are in the code, but two things that need an overall look:
1- style is not yet according to Flang, mainly functions and variables in the classes
2 -I believe that the name space is Fortran::frontend to be consistent with the other files at Frontend.

Sep 22 2020, 2:24 AM · Restricted Project

Sep 21 2020

CarolineConcatto committed rZORG965bd9eb785e: Update recipe for flang-aarch64 slaves (authored by CarolineConcatto).
Update recipe for flang-aarch64 slaves
Sep 21 2020, 11:55 PM
CarolineConcatto closed D87125: Update recipe for flang-aarch64 slaves.
Sep 21 2020, 11:55 PM
CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

@gkistanova is now fine?

Sep 21 2020, 6:37 AM

Sep 20 2020

CarolineConcatto updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
  • remove changes from cmakefiles
Sep 20 2020, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a reviewer for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: awarzynski.
Sep 20 2020, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto requested review of D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
Sep 20 2020, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the summary of D87125: Update recipe for flang-aarch64 slaves.
Sep 20 2020, 10:12 AM
CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

Update compile location for flang-aarch64-ubuntu{clang and gcc10}

Sep 20 2020, 10:11 AM

Sep 11 2020

CarolineConcatto committed rG257b29715bb2: [flang][driver] Add the new flang compiler and frontend drivers (authored by CarolineConcatto).
[flang][driver] Add the new flang compiler and frontend drivers
Sep 11 2020, 3:01 AM
CarolineConcatto closed D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Sep 11 2020, 3:00 AM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2020

CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

Thank you @gkistanova, I did miss that.
It was updated on my local repo, but not in here.

Sep 10 2020, 11:42 PM
CarolineConcatto retitled D87125: Update recipe for flang-aarch64 slaves from Add extra recipient mail for flang-aarch64 slaves to Update recipe for flang-aarch64 slaves.
Sep 10 2020, 11:40 PM

Sep 9 2020

CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

Add the build of the new driver as default for flang-aarch64 slaves

Sep 9 2020, 5:43 AM
CarolineConcatto committed rG0fd425af071a: [flang]Add Semantic Checks for OpenMP Allocate Clause (authored by Rin).
[flang]Add Semantic Checks for OpenMP Allocate Clause
Sep 9 2020, 4:09 AM
CarolineConcatto closed D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Sep 9 2020, 4:09 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a comment to D87125: Update recipe for flang-aarch64 slaves.

@gkistanova is it fine for me to push?

Sep 9 2020, 1:21 AM

Sep 4 2020

CarolineConcatto updated the diff for D87125: Update recipe for flang-aarch64 slaves.

-correct mail for flang

Sep 4 2020, 12:19 AM
CarolineConcatto requested review of D87125: Update recipe for flang-aarch64 slaves.
Sep 4 2020, 12:16 AM

Aug 23 2020

CarolineConcatto added a comment to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Hey Folks,
Fist of all, thank you very much for your review.
I have answered some questions and update some of the requests.
There are some that I did not had time to go inside yet.
I have the week of 24th off. IN my return I will tackle all the reviews as:
out of build tree
and some question about the driver

Aug 23 2020, 1:55 PM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the diff for D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Address review comments

Aug 23 2020, 1:15 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

CarolineConcatto committed rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive (authored by CarolineConcatto).
[clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive
Aug 19 2020, 9:55 AM
CarolineConcatto closed D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.
Aug 19 2020, 9:55 AM · Restricted Project
CarolineConcatto added a comment to D85622: Separate the Registration from Loading dialects in the Context.

@mehdi_amini this patch is breaking flang buildbot.
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu/builds/2928
Do you mind to revert?

Aug 19 2020, 9:51 AM · Restricted Project

Aug 18 2020

CarolineConcatto updated the diff for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.

Missing a -

Aug 18 2020, 5:21 AM · Restricted Project
CarolineConcatto added a reviewer for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: echristo.
Aug 18 2020, 3:57 AM · Restricted Project
CarolineConcatto removed a reviewer for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: kiranchandramohan.
Aug 18 2020, 3:50 AM · Restricted Project
CarolineConcatto added a reviewer for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: peterwaller-arm.
Aug 18 2020, 3:50 AM · Restricted Project
CarolineConcatto added reviewers for D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive: DavidTruby, kiranchandramohan.
Aug 18 2020, 3:46 AM · Restricted Project
CarolineConcatto requested review of D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive.
Aug 18 2020, 3:46 AM · Restricted Project

Aug 17 2020

CarolineConcatto added a project to D86089: [flang][driver]Add experimental flang driver and frontend with help screen: Restricted Project.
Aug 17 2020, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto retitled D86089: [flang][driver]Add experimental flang driver and frontend with help screen from Add experimental flang driver and frontend with help screen to [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 17 2020, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto updated the summary of D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 17 2020, 9:22 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto added a reviewer for D86089: [flang][driver]Add experimental flang driver and frontend with help screen: Andrzej.
Aug 17 2020, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
CarolineConcatto requested review of D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 17 2020, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

Aug 14 2020

CarolineConcatto committed rZORG3be3cca19be8: Fix binaries directory for flang slaves gcc10 and clang10 (authored by CarolineConcatto).
Fix binaries directory for flang slaves gcc10 and clang10
Aug 14 2020, 3:37 AM
CarolineConcatto closed D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 14 2020, 3:37 AM

Aug 12 2020

CarolineConcatto updated the diff for D85816: Fix binaries directory for flang slaves gcc10 and clang10.

Keep consistency between the names for clang

Aug 12 2020, 5:57 AM
CarolineConcatto added inline comments to D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 12 2020, 5:48 AM
CarolineConcatto requested review of D85816: Fix binaries directory for flang slaves gcc10 and clang10.
Aug 12 2020, 1:10 AM

Aug 11 2020

CarolineConcatto committed rZORGb06887ba004d: Add flang slaves builds with clang10 and gcc10 (authored by CarolineConcatto).
Add flang slaves builds with clang10 and gcc10
Aug 11 2020, 1:08 AM
CarolineConcatto closed D85529: Add flang slaves builds with clang10 and gcc10.
Aug 11 2020, 1:08 AM

Aug 7 2020

CarolineConcatto requested review of D85529: Add flang slaves builds with clang10 and gcc10.
Aug 7 2020, 8:27 AM

Aug 4 2020

CarolineConcatto added a comment to D69257: Outline non returning functions unless a longjmp.

So the build has as a target: cmake -DLLVM_TARGETS_TO_BUILD=AArch64

Aug 4 2020, 8:44 AM · Restricted Project

Aug 3 2020

CarolineConcatto added a comment to D69257: Outline non returning functions unless a longjmp.

@hiraditya
We believe that this patch has caused the Flang buildbots to fail:
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu/builds/2437
http://lab.llvm.org:8011/builders/flang-aarch64-ubuntu-clang/builds/579
It would be nice if someone could take and action to revert of fix it ASAP.
Otherwise we cannot verify the other patches properly.

Aug 3 2020, 6:11 AM · Restricted Project

Jul 24 2020

CarolineConcatto accepted D83946: [flang] Run non-gtest unit tests with lit..
Jul 24 2020, 6:45 AM · Restricted Project

Jul 20 2020

CarolineConcatto added a comment to D83946: [flang] Run non-gtest unit tests with lit..

Thank you David for these patch.
Do you mind to explain why you had to create this new non-gtest unit in the patch.

Jul 20 2020, 6:59 AM · Restricted Project

Jun 23 2020

CarolineConcatto abandoned D81002: Fix individual tests with lit when building out of tree.

This was re-implemented by :
https://reviews.llvm.org/D82120

Jun 23 2020, 12:29 AM · Restricted Project

Jun 15 2020

CarolineConcatto abandoned D79092: [Flang][Driver]Add new flang driver main() entrypoint.

I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.

Jun 15 2020, 7:00 AM · Restricted Project, Restricted Project
CarolineConcatto added a comment to D81828: [MLIR][NFC] Inline lambda to workaround gcc 9.1/9.2 bug.

It now works with gcc9.2. I did not try with other compilers.
Is is too much to ask to write the reason it is implemented the way it is?
Maybe say that this was a lambda function that needed to be expanded.
But otherwise it looks fine to me

Jun 15 2020, 5:56 AM · Restricted Project

Jun 8 2020

CarolineConcatto abandoned D73951: [Clang] [Driver]Add logic to search for flang frontend.

I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.

Jun 8 2020, 7:38 AM · Restricted Project
CarolineConcatto added a comment to D73951: [Clang] [Driver]Add logic to search for flang frontend.

I'll close this PR as we believe we will not need this flag for Flang driver.
There are some development happening in:
https://github.com/banach-space/llvm-project
for now.

Jun 8 2020, 7:38 AM · Restricted Project

Jun 3 2020

CarolineConcatto committed rZORG87b206fe85e7: Add aarch64 machine slave to build flang with clang-8 (authored by CarolineConcatto).
Add aarch64 machine slave to build flang with clang-8
Jun 3 2020, 6:33 AM
CarolineConcatto closed D80983: Add aarch64 machine slave to build flang with clang-8.
Jun 3 2020, 6:33 AM

Jun 2 2020

CarolineConcatto added a comment to D81002: Fix individual tests with lit when building out of tree.

It looks like that for in tree the lit needs to be like this:
add_lit_testsuites(FLANG ${CMAKE_CURRENT_SOURCE_DIR}
and out of tree like this:
add_lit_testsuites(FLANG ${CMAKE_CURRENT_BINARY_DIR}

Jun 2 2020, 10:58 AM · Restricted Project
CarolineConcatto added a reviewer for D81002: Fix individual tests with lit when building out of tree: tskeith.
Jun 2 2020, 7:08 AM · Restricted Project
CarolineConcatto added a reviewer for D81002: Fix individual tests with lit when building out of tree: sameeranjoshi.
Jun 2 2020, 7:08 AM · Restricted Project