Page MenuHomePhabricator
Feed Advanced Search

Aug 14 2022

qingyunqu added a comment to D131480: [mlir] add missing pessimistic setting.

Matches the comment and what was there before (https://github.com/llvm/llvm-project/blob/2c384c37727660f11f63fda461210d1a6f5d2afe/mlir/lib/Transforms/SCCP.cpp#L84). Seems SCCP has some missing test coverage.

Do you have a test case that triggers for this one?

I trigger this when working on mhlo.reduce op. But I think I could create a test like https://reviews.llvm.org/D130453

Thanks that would be great.

Aug 14 2022, 7:59 PM · Restricted Project, Restricted Project
qingyunqu updated the diff for D131480: [mlir] add missing pessimistic setting.
Aug 14 2022, 7:57 PM · Restricted Project, Restricted Project

Aug 9 2022

qingyunqu added a comment to D131480: [mlir] add missing pessimistic setting.

Matches the comment and what was there before (https://github.com/llvm/llvm-project/blob/2c384c37727660f11f63fda461210d1a6f5d2afe/mlir/lib/Transforms/SCCP.cpp#L84). Seems SCCP has some missing test coverage.

Do you have a test case that triggers for this one?

Aug 9 2022, 6:51 PM · Restricted Project, Restricted Project
qingyunqu requested review of D131480: [mlir] add missing pessimistic setting.
Aug 9 2022, 3:13 AM · Restricted Project, Restricted Project

Aug 3 2022

qingyunqu abandoned D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 11:47 PM · Restricted Project, Restricted Project
qingyunqu added inline comments to D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 11:25 PM · Restricted Project, Restricted Project
qingyunqu added inline comments to D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 9:37 PM · Restricted Project, Restricted Project
qingyunqu added inline comments to D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 9:16 PM · Restricted Project, Restricted Project
qingyunqu updated the summary of D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 8:34 PM · Restricted Project, Restricted Project
qingyunqu updated the diff for D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.

Also remove Linalg pass declaration which is not cleaned.

Aug 3 2022, 8:33 PM · Restricted Project, Restricted Project
qingyunqu retitled D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin from [MLIR/GPUToNVVM] lowering aritch.maxf/minf to __nv_fmaxf/__nv_fminf to [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 8:24 PM · Restricted Project, Restricted Project
qingyunqu set the repository for D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin to rG LLVM Github Monorepo.
Aug 3 2022, 8:23 PM · Restricted Project, Restricted Project
qingyunqu requested review of D131135: [MLIR/GPUToNVVM] lowering arith.maxf/minf to __nv_fmax/__nv_fmin.
Aug 3 2022, 8:21 PM · Restricted Project, Restricted Project

Jun 8 2022

qingyunqu added a comment to D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors.

Do you have commit access or do you need someone to push this for you?

I don't really get the point. What should I do between these two methods.

Regular contributors have direct write access to the repository and take care themselves to git push their changes to the main branch. On the other hand new contributors don't have write access and rely on the reviewer to push the change for them after approving.

Jun 8 2022, 6:54 PM · Restricted Project, Restricted Project
qingyunqu added a comment to D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors.

Do you have commit access or do you need someone to push this for you?

Jun 8 2022, 11:45 AM · Restricted Project, Restricted Project
qingyunqu added a comment to D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors.

LG, thanks

Jun 8 2022, 11:42 AM · Restricted Project, Restricted Project
qingyunqu edited reviewers for D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors, added: herhut; removed: joker-eph-DISABLED. qingyunqu removed 1 blocking reviewer(s) for D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors: jpienaar.
Jun 8 2022, 10:35 AM · Restricted Project, Restricted Project
qingyunqu added a reviewer for D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors: joker-eph-DISABLED.
Jun 8 2022, 10:16 AM · Restricted Project, Restricted Project
qingyunqu requested review of D127321: [MLIR][Shape] Generalize `shape.concat` to extent tensors.
Jun 8 2022, 10:12 AM · Restricted Project, Restricted Project