Rebase & Run tests.
Sep 16 2019
Sep 11 2019
Sorry, I see some patterns like /* LowerCase */ true elsewhere, and have no idea that this is not a proper pattern.
Sep 10 2019
Addressed @jhenderson 's comments.
Yes, I mean this is a bug of llvm-readobj. Sorry for my unclear expression.
Sep 9 2019
Addressed @grimar 's comments
Sep 8 2019
Sep 7 2019
Sep 6 2019
Friendly ping @StephenTozer? Seems that this patch has been accepted long time ago. Is this patch still valid? Could you please commit this?
Sep 5 2019
Jun 12 2019
May 28 2019
LGTM, I was coping with my graduation essay these days, so I did not finished my revision in time :) Thank you @rupprecht for informing me.
Apr 23 2019
Hi, could you please fix this typo in this patch as well?
Apr 16 2019
As I'll be away next week, I've added a couple of others to help with reviewing this too.
I'm not certain that the approach you've taken is quite right. There should be no need to query the opts::Output member from within the dumper. That's the purpose of the individual dump styles. There's barely any common code you've actually pulled out. What is the purpose of what you have done?
Sure, I will try to get rid of it.
Sorry for not respounding on this patch for a long time.
Apr 15 2019
Apr 14 2019
Apr 13 2019
rC314838 (included in clang 6) suppressed -Wmissing-braces (enabled by -Wmost and -Wall) warning for the idiomatic brace elision.
http://lists.llvm.org/pipermail/llvm-dev/2019-April/131486.html llvm will migrate to C++14 soon... (though clang < 6 will continue warning the case; I'm not sure if we want to make code less idiomatic just to suppress warnings for old clang; gcc -Wall doesn't enable -Wmissing-braces)
Apr 12 2019
Apr 10 2019
Apr 9 2019
Addressed @ruiu 's comments.
- Add commit message.
Apr 8 2019
This patch breaks some tests, I will modify this later
Apr 6 2019
Apr 5 2019
Move VersymBuf out of printVersionSymbol().
Fix one small nit.
Apr 3 2019
Seems that this patch breaks some tests, I will take a look
- Using uint64_t instead of uint32_t
Apr 2 2019
Addressed @jhenderson 's comments
Mar 29 2019
Mar 28 2019
Change SymbolVersionRefSection to SymbolVersionNeedSection
Sorry, this is my first time use git-svn, I pushed 3 times for a patch ...
- Addressed comments
- Addressed @jhenderson 's comments
- Format patch
Mar 27 2019
Very cool. It looks like -V also prints a definition/needed section that this patch doesn't support yet. Is that coming in a later patch?
- Add test file