Page MenuHomePhabricator
Feed Advanced Search

Tue, Apr 13

Higuoxing added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Tue, Apr 13, 6:10 PM · Unknown Object (Project)

Mon, Mar 29

Higuoxing added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Mon, Mar 29, 8:04 PM · Unknown Object (Project)

Mar 16 2021

Higuoxing added a comment to D97186: [XCOFF][llvm-dwarfdump] support llvm-dwarfdump for XCOFF DWARF.

@Higuoxing added more support to yaml2obj last year for DWARF emission via YAML. Maybe it would be best to wait on basic XCOFF yaml2obj support to be finished, add DWARF emission support to that, and then use yaml2obj to generate the DWARF output as required?

Also, the pre-merge checks claim your tests are failing.

Finally, how does this actually add support for llvm-dwarfdump + XCOFF? It's not particularly obvious to me, but I'm not all that familiar about what llvm-dwarfdump requires for this support.

Mar 16 2021, 5:19 AM · Unknown Object (Project)

Feb 15 2021

Higuoxing added inline comments to D96602: [llvm-nm][test] Add additional test coverage for llvm-nm options.
Feb 15 2021, 2:13 AM · Unknown Object (Project)

Feb 12 2021

Higuoxing accepted D96602: [llvm-nm][test] Add additional test coverage for llvm-nm options.

I only have one inline comment. Otherwise LGTM :)

Feb 12 2021, 7:23 AM · Unknown Object (Project)
Higuoxing accepted D96601: [llvm-nm] Tidy up error messages.

LGTM. Thanks!

Feb 12 2021, 6:56 AM · Unknown Object (Project)

Nov 2 2020

Higuoxing accepted D87179: Fix debug_abbrev emitter to only assign table id once.

LGTM, thanks!

Nov 2 2020, 2:41 AM · Unknown Object (Project)

Oct 16 2020

Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Oct 16 2020, 4:06 AM · Unknown Object (Project)

Oct 13 2020

Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Oct 13 2020, 1:30 AM · Unknown Object (Project)

Oct 8 2020

Higuoxing committed rGc1489ee5a773: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC. (authored by Higuoxing).
[llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC.
Oct 8 2020, 8:14 PM
Higuoxing closed D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..
Oct 8 2020, 8:13 PM · Unknown Object (Project)
Higuoxing committed rGdd554994729b: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields… (authored by Higuoxing).
[DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields…
Oct 8 2020, 8:10 PM
Higuoxing closed D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Oct 8 2020, 8:10 PM · Unknown Object (Project)
Higuoxing updated the summary of D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Oct 8 2020, 8:09 PM · Unknown Object (Project)
Higuoxing added inline comments to D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Oct 8 2020, 1:52 AM · Unknown Object (Project)
Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
  • Test the default opcode_base field and the standard_opcode_lengths array of DWARFv2-DWARFv4 (DWARFv5 isn't supported yet).
  • Add missing comment.
Oct 8 2020, 1:43 AM · Unknown Object (Project)

Oct 4 2020

Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..

Use Version to determine the default opcode_base and standard_opcode_lengths fields.

Oct 4 2020, 11:42 PM · Unknown Object (Project)

Sep 28 2020

Higuoxing added inline comments to D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Sep 28 2020, 5:57 AM · Unknown Object (Project)
Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
  • Make getStandardOpcodeLengths() return the standard_opcode_lengths according to the latest DWARF spec by default.
  • Add one test case where the opcode_base is greater than 13.
  • Address some inline comments.
Sep 28 2020, 5:57 AM · Unknown Object (Project)

Sep 26 2020

Higuoxing updated the diff for D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..

Update.

Sep 26 2020, 6:09 AM · Unknown Object (Project)
Higuoxing requested review of D88355: [DWARFYAML] Make the opcode_base and the standard_opcode_lengths fields optional..
Sep 26 2020, 5:19 AM · Unknown Object (Project)

Sep 24 2020

Higuoxing updated the diff for D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..

Split commands.

Sep 24 2020, 1:09 AM · Unknown Object (Project)
Higuoxing requested review of D88200: [llvm-dwarfdump][test] Rewrite verify_die_ranges.s in YAML. NFC..
Sep 24 2020, 12:50 AM · Unknown Object (Project)

Sep 23 2020

Higuoxing committed rG505ac22f1a1a: [DWARFYAML] Make the ExtLen field of extended opcodes optional. (authored by Higuoxing).
[DWARFYAML] Make the ExtLen field of extended opcodes optional.
Sep 23 2020, 11:20 PM
Higuoxing closed D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Sep 23 2020, 11:20 PM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Append --strict-whitespace option.
Use {{ }} to match more (2) spaces.

Sep 23 2020, 3:19 AM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Thanks!

Sep 23 2020, 2:05 AM · Unknown Object (Project)
Higuoxing added inline comments to D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Sep 23 2020, 1:49 AM · Unknown Object (Project)
Higuoxing updated the diff for D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..

Address review comments.

Sep 23 2020, 1:49 AM · Unknown Object (Project)

Sep 22 2020

Higuoxing requested review of D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional..
Sep 22 2020, 11:47 PM · Unknown Object (Project)
Higuoxing committed rG64435a427a01: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC. (authored by Higuoxing).
[DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC.
Sep 22 2020, 5:43 PM
Higuoxing closed D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..
Sep 22 2020, 5:43 PM · Unknown Object (Project)
Higuoxing requested review of D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..
Sep 22 2020, 12:18 AM · Unknown Object (Project)

Sep 21 2020

Higuoxing added inline comments to D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children..
Sep 21 2020, 7:58 PM · Unknown Object (Project)
Higuoxing added a comment to D88048: [dwarfdump] Add verifier check to find DIEs with DW_CHILDREN_yes but without children..

maybe slightly long test case - could do this with the CU DIE itself? (perhaps a case where hand-crafted/substantially hand-modified assembly is OK, because it can be made /so/ simple - or maybe yaml2obj dwarf support is adequate for this use case?)

Sep 21 2020, 7:57 PM · Unknown Object (Project)

Sep 20 2020

Higuoxing added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 20 2020, 10:50 PM · Unknown Object (Project)
Higuoxing added inline comments to rG6bb912336804: DWARFYAML::emitDebugSections - fix use after std::move warnings. NFCI..
Sep 20 2020, 9:44 AM

Sep 18 2020

Higuoxing committed rG2d35092cd258: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the… (authored by Higuoxing).
[DWARFYAML] Make the include_directories, file_names and opcodes fields of the…
Sep 18 2020, 5:22 AM
Higuoxing closed D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..
Sep 18 2020, 5:22 AM · Unknown Object (Project), Restricted Project
Higuoxing committed rGa761e81e2202: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC. (authored by Higuoxing).
[DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC.
Sep 18 2020, 5:20 AM
Higuoxing closed D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Sep 18 2020, 5:20 AM · Unknown Object (Project)
Higuoxing retitled D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC. from [DWARFYAML][test] Make checkers stricter. NFC. to [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Sep 18 2020, 1:32 AM · Unknown Object (Project)
Higuoxing updated the diff for D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..

I might be missing it, but do you have direct testing showing that the default for IncludeDirs\Files\Opcodes is an empty output, when the output is written? I think it's important that this is tested.

Sep 18 2020, 1:30 AM · Unknown Object (Project), Restricted Project

Sep 17 2020

Higuoxing requested review of D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional..
Sep 17 2020, 8:03 PM · Unknown Object (Project), Restricted Project
Higuoxing updated the diff for D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..

Check the DWARF: tag.

Sep 17 2020, 7:49 PM · Unknown Object (Project)
Higuoxing requested review of D87876: [DWARFYAML][test] Use 'CHECK-NEXT:' to make checkers stricter. NFC..
Sep 17 2020, 7:46 PM · Unknown Object (Project)

Sep 15 2020

Higuoxing committed rG4171d5c30ad3: [obj2yaml] Add support for dumping the .debug_addr(v5) section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_addr(v5) section.
Sep 15 2020, 11:49 PM
Higuoxing closed D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Sep 15 2020, 11:48 PM · Unknown Object (Project)
Higuoxing added inline comments to D87656: [llvm-dwarfdump] --show-sources option to show all sources.
Sep 15 2020, 11:36 PM · Unknown Object (Project)
Higuoxing updated the diff for D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..

Address comments.

Sep 15 2020, 12:21 AM · Unknown Object (Project)

Sep 14 2020

Higuoxing added inline comments to D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Sep 14 2020, 11:06 PM · Unknown Object (Project)
Higuoxing updated the diff for D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..

Address review comments.

Sep 14 2020, 11:06 PM · Unknown Object (Project)
Higuoxing requested review of D87601: [obj2yaml] Add support for dumping the .debug_addr(v5) section..
Sep 14 2020, 1:30 AM · Unknown Object (Project)

Sep 13 2020

Higuoxing added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

@Higuoxing I didn't realize the DWARF section was completely new until I read your GSOC project. Thanks a lot for this work otherwise it would have been impossible for me to create the tests I needed for my other diff!

Sep 13 2020, 6:47 PM · Unknown Object (Project)
Higuoxing accepted D87179: Fix debug_abbrev emitter to only assign table id once.

LGTM with nit.

Sep 13 2020, 6:11 PM · Unknown Object (Project)

Sep 10 2020

Higuoxing committed rG0e47a8d17fe8: [obj2yaml] Add support for dumping the .debug_ranges section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_ranges section.
Sep 10 2020, 5:49 PM
Higuoxing closed D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Sep 10 2020, 5:48 PM · Unknown Object (Project)
Higuoxing updated the diff for D87429: [obj2yaml] Add support for dumping the .debug_ranges section..

Address comments.

Sep 10 2020, 5:45 PM · Unknown Object (Project)
Higuoxing added inline comments to D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Sep 10 2020, 2:09 AM · Unknown Object (Project)
Higuoxing updated the diff for D87429: [obj2yaml] Add support for dumping the .debug_ranges section..

Address review comments.

Sep 10 2020, 2:09 AM · Unknown Object (Project)

Sep 9 2020

Higuoxing requested review of D87429: [obj2yaml] Add support for dumping the .debug_ranges section..
Sep 9 2020, 8:18 PM · Unknown Object (Project)
Higuoxing committed rG25f3cc0ced17: [elf2yaml] Fix dumping a debug section whose name is not recognized. (authored by Higuoxing).
[elf2yaml] Fix dumping a debug section whose name is not recognized.
Sep 9 2020, 5:08 AM
Higuoxing closed D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Sep 9 2020, 5:08 AM · Unknown Object (Project)
Higuoxing updated the diff for D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..

Address review comments.

Sep 9 2020, 3:07 AM · Unknown Object (Project)
Higuoxing updated the summary of D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Sep 9 2020, 1:37 AM · Unknown Object (Project)
Higuoxing updated the summary of D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Sep 9 2020, 1:36 AM · Unknown Object (Project)
Higuoxing added inline comments to D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Sep 9 2020, 1:36 AM · Unknown Object (Project)
Higuoxing updated the diff for D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..

Address review comments.

Sep 9 2020, 1:36 AM · Unknown Object (Project)

Sep 8 2020

Higuoxing requested review of D87346: [elf2yaml] Fix dumping a debug section whose name is not recognized..
Sep 8 2020, 11:14 PM · Unknown Object (Project)
Higuoxing committed rG4682f654031c: [obj2yaml][test] Test generating and dumping a broken debug_ranges section. (authored by Higuoxing).
[obj2yaml][test] Test generating and dumping a broken debug_ranges section.
Sep 8 2020, 5:49 PM
Higuoxing closed D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..
Sep 8 2020, 5:49 PM · Unknown Object (Project)
Higuoxing committed rG25c3fa3f1333: [DWARFYAML] Make the debug_ranges section optional. (authored by Higuoxing).
[DWARFYAML] Make the debug_ranges section optional.
Sep 8 2020, 4:56 AM
Higuoxing closed D87263: [DWARFYAML] Make the debug_ranges section optional..
Sep 8 2020, 4:56 AM · Unknown Object (Project)
Higuoxing retitled D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section. from [obj2yaml] Test generating and dumping a broken debug_ranges section. to [obj2yaml][test] Test generating and dumping a broken debug_ranges section..
Sep 8 2020, 4:07 AM · Unknown Object (Project)
Higuoxing updated the diff for D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..

Reflow comments.

Sep 8 2020, 4:07 AM · Unknown Object (Project)
Higuoxing requested review of D87275: [obj2yaml][test] Test generating and dumping a broken debug_ranges section..
Sep 8 2020, 1:34 AM · Unknown Object (Project)
Higuoxing updated the diff for D87263: [DWARFYAML] Make the debug_ranges section optional..

Rebase.

Sep 8 2020, 1:33 AM · Unknown Object (Project)
Higuoxing committed rG3cda69872362: [obj2yaml] Stop parsing the debug_str section when it encounters a string… (authored by Higuoxing).
[obj2yaml] Stop parsing the debug_str section when it encounters a string…
Sep 8 2020, 1:11 AM
Higuoxing closed D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..
Sep 8 2020, 1:10 AM · Unknown Object (Project)
Higuoxing added inline comments to D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..
Sep 8 2020, 1:02 AM · Unknown Object (Project)
Higuoxing updated the diff for D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..

Update comment.

Sep 8 2020, 1:02 AM · Unknown Object (Project)
Higuoxing added inline comments to D87263: [DWARFYAML] Make the debug_ranges section optional..
Sep 8 2020, 12:55 AM · Unknown Object (Project)
Higuoxing updated the diff for D87263: [DWARFYAML] Make the debug_ranges section optional..

Address review comments.

Sep 8 2020, 12:55 AM · Unknown Object (Project)
Higuoxing updated the diff for D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..

Address review comments.

Sep 8 2020, 12:46 AM · Unknown Object (Project)

Sep 7 2020

Higuoxing requested review of D87263: [DWARFYAML] Make the debug_ranges section optional..
Sep 7 2020, 7:19 PM · Unknown Object (Project)
Higuoxing updated the diff for D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..

Remove a header.

Sep 7 2020, 6:36 PM · Unknown Object (Project)
Higuoxing requested review of D87261: [obj2yaml] Stop parsing the debug_str section when it encounters a string without the null terminator..
Sep 7 2020, 6:29 PM · Unknown Object (Project)
Higuoxing committed rG3097427f93dd: [obj2yaml] Add support for dumping the .debug_str section. (authored by Higuoxing).
[obj2yaml] Add support for dumping the .debug_str section.
Sep 7 2020, 4:47 AM
Higuoxing closed D86867: [obj2yaml] Add support for dumping the .debug_str section..
Sep 7 2020, 4:47 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Avoid using Flags.getValueOr() twice.

Sep 7 2020, 2:29 AM · Unknown Object (Project)
Higuoxing committed rG40f4131fce78: [DWARFYAML] Make the debug_addr section optional. (authored by Higuoxing).
[DWARFYAML] Make the debug_addr section optional.
Sep 7 2020, 1:19 AM
Higuoxing closed D87205: [DWARFYAML] Make the debug_addr section optional..
Sep 7 2020, 1:18 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

Explicitly check the sh_flag.

Sep 7 2020, 1:15 AM · Unknown Object (Project)
Higuoxing added inline comments to D87205: [DWARFYAML] Make the debug_addr section optional..
Sep 7 2020, 1:02 AM · Unknown Object (Project)
Higuoxing updated the diff for D87205: [DWARFYAML] Make the debug_addr section optional..

Address review comment.

Sep 7 2020, 1:02 AM · Unknown Object (Project)

Sep 6 2020

Higuoxing requested review of D87205: [DWARFYAML] Make the debug_addr section optional..
Sep 6 2020, 7:15 AM · Unknown Object (Project)
Higuoxing added inline comments to D86867: [obj2yaml] Add support for dumping the .debug_str section..
Sep 6 2020, 3:48 AM · Unknown Object (Project)
Higuoxing updated the diff for D86867: [obj2yaml] Add support for dumping the .debug_str section..

I modified the getDefaultShEntSize() function in this revision. If the section name is '.debug_str', the default value of sh_entsize is 1 rather than 0.

Sep 6 2020, 3:48 AM · Unknown Object (Project)

Sep 5 2020

Higuoxing added inline comments to D87179: Fix debug_abbrev emitter to only assign table id once.
Sep 5 2020, 6:48 PM · Restricted Project
Higuoxing added a comment to D87179: Fix debug_abbrev emitter to only assign table id once.

I think the problem is caused by misplacing the line Y.DebugAbbrev.back().ID = AbbrevTableID++;. It should be placed in an outer loop.

Sep 5 2020, 10:41 AM · Restricted Project