Page MenuHomePhabricator
Feed Advanced Search

Yesterday

Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Ok. So we have D77289 and this one connected, I'd start from landing this one first.
(I have no comments regarding this one)

Thu, Apr 2, 9:13 AM · Restricted Project
Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Hi @grimar, the build log of this patch shows that we actually have a checker that complains sh_size isn't a multiple of sh_entsize (llvm/include/Object/ELF.h: Line 401). But I have no idea why it wasn't triggered on my machine. I use a release build because I do not have enough memory for debug build ...

I've missed this question/thread somehow, sorry.

Ahhhh, After enable -DLLVM_ENABLE_ASSERTIONS=ON,

there's an error: section [index 2] has an invalid sh_size (33) which is not a multiple of its sh_entsize (16)Stack dump. But this error won't show up in a release build. I think we should at least warn user about this?

Where abouts does this message come from?

I do not think that `LLVM_ENABLE_ASSERTIONS` should affect on whether we print or not something like this message..

@Higuoxing, if you still have problems with it, please clarify how to reproduce the misbehavior you observe (e.g.. which yaml you use).

Thu, Apr 2, 8:38 AM · Restricted Project
Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Correct grammatical mistakes. I will try my best to avoid these mistakes next time ...

Thu, Apr 2, 7:33 AM · Restricted Project
Higuoxing updated the diff for D77289: [Object] Fix crash caused by unhandled error..

Addressed comment.

  • Add one more test for .dynsym section. llvm-nm --dynamic's behavior will be fixed until D76081 lands.
Thu, Apr 2, 7:01 AM · Restricted Project
Higuoxing added inline comments to D77289: [Object] Fix crash caused by unhandled error..
Thu, Apr 2, 5:56 AM · Restricted Project
Higuoxing updated the diff for D77289: [Object] Fix crash caused by unhandled error..

Addressed comments.

  • Rename test file name to invalid-symtab-size.test
  • Generalize CheckSymbol()
Thu, Apr 2, 4:51 AM · Restricted Project
Higuoxing updated the diff for D77289: [Object] Fix crash caused by unhandled error..

.

Thu, Apr 2, 4:51 AM · Restricted Project
Higuoxing updated the diff for D77289: [Object] Fix crash caused by unhandled error..

Apply clang-format

Thu, Apr 2, 2:08 AM · Restricted Project
Higuoxing updated the diff for D77289: [Object] Fix crash caused by unhandled error..

Addressed comments.

  • Use Expected<Elf_Sym_Range> instead of auto.
  • Add TODO label for future improvement.
  • Move test to Object folder.
Thu, Apr 2, 2:08 AM · Restricted Project
Higuoxing updated the diff for D77289: [Object] Fix crash caused by unhandled error..

Addressed @MaskRay 's comment.

Thu, Apr 2, 12:30 AM · Restricted Project

Wed, Apr 1

Higuoxing updated the summary of D77289: [Object] Fix crash caused by unhandled error..
Wed, Apr 1, 11:23 PM · Restricted Project
Higuoxing created D77289: [Object] Fix crash caused by unhandled error..
Wed, Apr 1, 11:23 PM · Restricted Project

Sat, Mar 28

Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Ahhhh, After enable -DLLVM_ENABLE_ASSERTIONS=ON,

Sat, Mar 28, 9:28 PM · Restricted Project
Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Hi @grimar, the build log of this patch shows that we actually have a checker that complains sh_size isn't a multiple of sh_entsize (llvm/include/Object/ELF.h: Line 401). But I have no idea why it wasn't triggered on my machine. I use a release build because I do not have enough memory for debug build ...

Sat, Mar 28, 8:04 AM · Restricted Project
Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Addressed comments.

Sat, Mar 28, 6:27 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
  • Remove duplicated comments.
  • Get rid of --match-full-lines and --strict-whitespace
Sat, Mar 28, 4:19 AM · Restricted Project

Tue, Mar 24

Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

I do not have a good answer right now. Seems the API could be revisited and refined.
section_begin() and section_end() just ignore errors now.
symbol_begin() has a different logic from dynamic_symbol_begin that does not look ideal to me either:

DataRefImpl Sym =
    toDRI(DotSymtabSec,
          DotSymtabSec && DotSymtabSec->sh_size >= sizeof(Elf_Sym) ? 1 : 0);

(it is unclear to me how it works when sh_size==1, for example)

Tue, Mar 24, 9:07 AM · Restricted Project
Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
  • Make llvm-nm imitate gnu-nm's behavior.

    To make llvm-nm behave like gnu-nm, I have to remove sh_size % sizeof(Elf_Sym) check in dynamic_symbol_begin(), I'm wondering if @grimar is happy with this, since you are concerned about this.

Probably I am not, because this is the patch for Object and not for llvm-nm. What is good for llvm-nm might not work for other tools.
When sh_size % sizeof(Elf_Sym) != 0 it means we have a error.
I guess such things should be fixed on llvm-nm side and not in libObject. We can probably adjust this later though as this patch is still an improvement.

@jhenderson, what do you think?

Tue, Mar 24, 7:29 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Indent for continuous lines.

Tue, Mar 24, 6:24 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Addressed comment.

Tue, Mar 24, 6:24 AM · Restricted Project
Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Addressed comments.

  • Rename test case to dynamic.test.
  • Add genral comment for whole test.
  • Indent continuous lines in test.
  • Group local symbols, and remove nonsense Binding for local symbol.
  • Move check tags right below RUN instruction.
  • Rename EMPTY check tag to NO-SYMS
Tue, Mar 24, 5:52 AM · Restricted Project
Higuoxing added inline comments to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Tue, Mar 24, 3:12 AM · Restricted Project
Higuoxing added inline comments to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
Tue, Mar 24, 3:12 AM · Restricted Project

Mon, Mar 23

Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Rebase.

Mon, Mar 23, 10:50 PM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
  • Use [[FILE]] to check file name.
Mon, Mar 23, 10:17 PM · Restricted Project
Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Addressed comments.

  • Good ELF file -> ELF file with valid .dynsym section.
  • Remove nonsense --debug-syms option.
  • Format check tags.
  • Group local symbols in YAML file.
  • Replace {{.*}} by [[FILE]].
  • Merge check tags with similar content.
  • Add ELF 32-bit test

Thanks a lot for taking time reviewing :)

Mon, Mar 23, 8:09 PM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Rename isSTAB to IsSTAB, attampt to make clang-tidy check happy (Fix builds).

Mon, Mar 23, 6:31 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Format YAML.

Mon, Mar 23, 4:53 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
  • Move unimplemented features test to unimplemented-features.test.
  • Improve warning message.
  • Format codes.
Mon, Mar 23, 4:53 AM · Restricted Project
Higuoxing added inline comments to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Mon, Mar 23, 3:15 AM · Restricted Project
Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Add one more test.

Mon, Mar 23, 12:31 AM · Restricted Project

Sun, Mar 22

Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
  • Add some test cases.
Sun, Mar 22, 7:27 AM · Restricted Project

Fri, Mar 20

Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Fix nits.

Fri, Mar 20, 1:03 AM · Restricted Project

Thu, Mar 19

Higuoxing added a comment to D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.

LGTM. @Higuoxing, would you mind writing a separate dedicated test for --dynamic? It would allow for testing the corner cases, which are outside the scope of this test file. It can be a separate patch, no problem.

Thu, Mar 19, 5:54 AM · Restricted Project
Higuoxing added a comment to D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

This need test cases I think.

Thu, Mar 19, 5:21 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Great! I didn't get it just now 🤣

Thu, Mar 19, 4:17 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

.

Thu, Mar 19, 4:17 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Remove irrevelent format change.

Thu, Mar 19, 3:45 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Add printSymbol() helper function.

Thu, Mar 19, 3:44 AM · Restricted Project
Higuoxing added a comment to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Can we do this in next few patches? It seems that we have to resolve some continue; and break; statements.

I think we should commit the nice code from start. If we can't because of a minor refactoring needed, this refactoring should be done first.

Thu, Mar 19, 3:11 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Fix lint warning.

Thu, Mar 19, 3:11 AM · Restricted Project
Higuoxing added a parent revision for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.: D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
Thu, Mar 19, 1:35 AM · Restricted Project
Higuoxing added a child revision for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0: D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Thu, Mar 19, 1:35 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Break long # RUN: lines.

Thu, Mar 19, 1:35 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Addressed comments.

Thu, Mar 19, 1:35 AM · Restricted Project

Wed, Mar 18

Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Update comments.

Wed, Mar 18, 4:51 AM · Restricted Project

Tue, Mar 17

Higuoxing updated the diff for D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.

Addressed comments.

  • Remove test for --debug-syms -D (Leave it to a --dynamic dedicated test file)
  • Use --implicit-check-not {{.}} for a more stringent check.
Tue, Mar 17, 11:58 PM · Restricted Project

Mon, Mar 16

Higuoxing updated the diff for D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.

Fix Harbormaster build

Mon, Mar 16, 5:17 AM · Restricted Project
Higuoxing added inline comments to D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.
Mon, Mar 16, 5:17 AM · Restricted Project
Higuoxing updated the diff for D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.

Addressed comment.

  • Use a single YAML file.
  • Test --dynamic/-D
  • Remove unrelated/unwanted fields (Default binding, Section)
Mon, Mar 16, 3:53 AM · Restricted Project
Higuoxing updated the diff for D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.

.

Mon, Mar 16, 12:15 AM · Restricted Project
Higuoxing added a child revision for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0: D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.
Mon, Mar 16, 12:15 AM · Restricted Project
Higuoxing added a parent revision for D76213: [llvm-nm] Add test for `--debug-syms --dynamic`: D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
Mon, Mar 16, 12:15 AM · Restricted Project
Higuoxing created D76213: [llvm-nm] Add test for `--debug-syms --dynamic`.
Mon, Mar 16, 12:15 AM · Restricted Project

Sun, Mar 15

Higuoxing updated the diff for D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.

Addressed comment.

  • Ignore malformed .dynsym section.
Sun, Mar 15, 10:51 PM · Restricted Project

Thu, Mar 12

Higuoxing updated the summary of D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
Thu, Mar 12, 11:23 AM · Restricted Project
Higuoxing added inline comments to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Thu, Mar 12, 11:23 AM · Restricted Project
Higuoxing created D76081: [Object] object::ELFObjectFile::dynamic_symbol_begin(): skip symbol index 0.
Thu, Mar 12, 11:23 AM · Restricted Project
Higuoxing added inline comments to D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Thu, Mar 12, 3:46 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Addressed @grimar 's comments

  • Change DumpDynamicSymbol to DumpDynamic
  • I have to use this pattern, due to there doesn't exist a default constructor for basic_symbol_iterator
Thu, Mar 12, 12:52 AM · Restricted Project

Tue, Mar 10

Higuoxing created D75899: [llvm-objdump] Simplify conditional statements (isa<...>(Obj) => Obj->isSomeFile()).
Tue, Mar 10, 3:46 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Rebase & Update doc.

Tue, Mar 10, 3:02 AM · Restricted Project

Sat, Mar 7

Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Addressed @MaskRay 's comments.

  • Dump dynamic symbol as 'D'
  • Move tests to ELF/ (Shall I wait until D75798 lands?)
Sat, Mar 7, 9:08 AM · Restricted Project
Higuoxing updated the summary of D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Sat, Mar 7, 8:35 AM · Restricted Project
Higuoxing updated the diff for D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..

Addressed @MaskRay 's comment.

Sat, Mar 7, 6:20 AM · Restricted Project

Fri, Mar 6

Higuoxing accepted D75793: [llvm-objdump] --syms: print 'i' for STT_GNU_IFUNC.

LGTM

Fri, Mar 6, 10:57 PM · Restricted Project
Higuoxing created D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols..
Fri, Mar 6, 8:49 AM · Restricted Project

Sep 8 2019

Higuoxing committed rGacf81f4210cd: [StackMap] Current stackmap version should be 3. NFC. (authored by Higuoxing).
[StackMap] Current stackmap version should be 3. NFC.
Sep 8 2019, 4:42 AM
Higuoxing committed rL371327: [StackMap] Current stackmap version should be 3. NFC..
[StackMap] Current stackmap version should be 3. NFC.
Sep 8 2019, 4:42 AM

Sep 7 2019

Higuoxing added inline comments to D67317: [PowerPC][NFC] Update test assertions using update_llc_test_checks.py.
Sep 7 2019, 6:44 AM · Restricted Project
Higuoxing added inline comments to D67317: [PowerPC][NFC] Update test assertions using update_llc_test_checks.py.
Sep 7 2019, 5:56 AM · Restricted Project

Sep 6 2019

Higuoxing committed rGed20dcb88b72: Revert [CodeGen] Fix typos to run tests. NFC. (authored by Higuoxing).
Revert [CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 10:16 PM
Higuoxing committed rL371289: Revert [CodeGen] Fix typos to run tests. NFC..
Revert [CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 10:16 PM
Higuoxing added a comment to D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.

Friendly ping @StephenTozer? Seems that this patch has been accepted long time ago. Is this patch still valid? Could you please commit this?

Sep 6 2019, 10:06 PM · Restricted Project
Higuoxing committed rGb38105bbd0f7: [CodeGen] Fix typos to run tests. NFC. (authored by Higuoxing).
[CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 9:59 PM
Higuoxing committed rL371286: [CodeGen] Fix typos to run tests. NFC..
[CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 9:59 PM

Sep 5 2019

Higuoxing committed rL371165: Request commit access for higuoxing.
Request commit access for higuoxing
Sep 5 2019, 8:41 PM

Jun 12 2019

Higuoxing committed rG7a15e99f3a9d: [DOC] Fix `load` instructions' syntax, function definition. (authored by Higuoxing).
[DOC] Fix `load` instructions' syntax, function definition.
Jun 12 2019, 4:23 AM
Higuoxing committed rL363142: [DOC] Fix `load` instructions' syntax, function definition..
[DOC] Fix `load` instructions' syntax, function definition.
Jun 12 2019, 4:21 AM
Higuoxing closed D63186: [DOC] Fix `load` instructions' syntax, function definition..
Jun 12 2019, 4:21 AM · Restricted Project
Higuoxing retitled D63186: [DOC] Fix `load` instructions' syntax, function definition. from [DOC] Fix `load` instructions' syntex, function definition. to [DOC] Fix `load` instructions' syntax, function definition..
Jun 12 2019, 1:36 AM · Restricted Project
Higuoxing retitled D63186: [DOC] Fix `load` instructions' syntax, function definition. from Fix `load` instructions' syntex, function definition. to [DOC] Fix `load` instructions' syntex, function definition..
Jun 12 2019, 1:11 AM · Restricted Project
Higuoxing created D63186: [DOC] Fix `load` instructions' syntax, function definition..
Jun 12 2019, 1:11 AM · Restricted Project

May 28 2019

Higuoxing abandoned D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.
May 28 2019, 11:02 PM · Restricted Project
Higuoxing added a comment to D62520: [llvm-readobj/llvm-readelf] - Implement GNU style dumper of the SHT_GNU_verdef section..

LGTM, I was coping with my graduation essay these days, so I did not finished my revision in time :) Thank you @rupprecht for informing me.

May 28 2019, 11:02 PM · Restricted Project
Higuoxing abandoned D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section.

Abandon Revision. @grimar has implemented it in https://reviews.llvm.org/D62520

May 28 2019, 11:02 PM · Restricted Project

Apr 23 2019

Higuoxing accepted D61021: Fix typos: (re)?sor?uce -> (re)?source.

Hi, could you please fix this typo in this patch as well?

Apr 23 2019, 10:11 AM · Restricted Project

Apr 16 2019

Higuoxing planned changes to D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

As I'll be away next week, I've added a couple of others to help with reviewing this too.

I'm not certain that the approach you've taken is quite right. There should be no need to query the opts::Output member from within the dumper. That's the purpose of the individual dump styles. There's barely any common code you've actually pulled out. What is the purpose of what you have done?

Sure, I will try to get rid of it.

Apr 16 2019, 9:05 AM · Restricted Project
Higuoxing updated the diff for D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

Sorry for not respounding on this patch for a long time.

Apr 16 2019, 4:43 AM · Restricted Project

Apr 15 2019

Higuoxing accepted D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.

LGTM.

Apr 15 2019, 4:03 AM · Restricted Project

Apr 14 2019

Higuoxing abandoned D60646: [lld] Add double-braces for std::array to suppress warnings. NFC..
Apr 14 2019, 10:44 PM · Restricted Project

Apr 13 2019

Higuoxing added a comment to D60646: [lld] Add double-braces for std::array to suppress warnings. NFC..

rC314838 (included in clang 6) suppressed -Wmissing-braces (enabled by -Wmost and -Wall) warning for the idiomatic brace elision.

http://lists.llvm.org/pipermail/llvm-dev/2019-April/131486.html llvm will migrate to C++14 soon... (though clang < 6 will continue warning the case; I'm not sure if we want to make code less idiomatic just to suppress warnings for old clang; gcc -Wall doesn't enable -Wmissing-braces)

Apr 13 2019, 5:48 AM · Restricted Project
Higuoxing created D60646: [lld] Add double-braces for std::array to suppress warnings. NFC..
Apr 13 2019, 12:26 AM · Restricted Project

Apr 12 2019

Higuoxing committed rGe855e2ebfc79: [llvm-readobj] Change variables' name to match LLVM-style. NFC. (authored by Higuoxing).
[llvm-readobj] Change variables' name to match LLVM-style. NFC.
Apr 12 2019, 12:09 AM
Higuoxing committed rL358259: [llvm-readobj] Change variables' name to match LLVM-style. NFC..
[llvm-readobj] Change variables' name to match LLVM-style. NFC.
Apr 12 2019, 12:08 AM

Apr 10 2019

Higuoxing committed rG8ab74145808b: [llvm-readobj] Should declare `ListScope` for `verneed` entries. (authored by Higuoxing).
[llvm-readobj] Should declare `ListScope` for `verneed` entries.
Apr 10 2019, 5:46 AM
Higuoxing committed rL358078: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
[llvm-readobj] Should declare `ListScope` for `verneed` entries.
Apr 10 2019, 5:46 AM
Higuoxing committed rLLD358078: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
[llvm-readobj] Should declare `ListScope` for `verneed` entries.
Apr 10 2019, 5:45 AM
Higuoxing closed D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
Apr 10 2019, 5:45 AM · Restricted Project

Apr 9 2019

Higuoxing updated the summary of D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
Apr 9 2019, 6:33 AM · Restricted Project