Page MenuHomePhabricator
Feed Advanced Search

Sep 16 2019

Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

Rebase & Run tests.

Sep 16 2019, 6:42 PM · Restricted Project

Sep 11 2019

Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

Sorry, I see some patterns like /* LowerCase */ true elsewhere, and have no idea that this is not a proper pattern.

Sep 11 2019, 2:35 AM · Restricted Project

Sep 10 2019

Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

Addressed @jhenderson 's comments.

Sep 10 2019, 9:38 AM · Restricted Project
Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

Yes, I mean this is a bug of llvm-readobj. Sorry for my unclear expression.

Sep 10 2019, 8:50 AM · Restricted Project
Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

Thank you @grimar, @jhenderson and @MaskRay .

Sep 10 2019, 5:17 AM · Restricted Project

Sep 9 2019

Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

.

Sep 9 2019, 8:48 PM · Restricted Project
Higuoxing updated the diff for D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..

Addressed @grimar 's comments

Sep 9 2019, 8:40 PM · Restricted Project

Sep 8 2019

Higuoxing created D67328: [llvm-readobj] Warn user when dumping not supported version of stack map (PR38278)..
Sep 8 2019, 8:29 AM · Restricted Project
Higuoxing committed rGacf81f4210cd: [StackMap] Current stackmap version should be 3. NFC. (authored by Higuoxing).
[StackMap] Current stackmap version should be 3. NFC.
Sep 8 2019, 4:42 AM
Higuoxing committed rL371327: [StackMap] Current stackmap version should be 3. NFC..
[StackMap] Current stackmap version should be 3. NFC.
Sep 8 2019, 4:42 AM

Sep 7 2019

Higuoxing added inline comments to D67317: [PowerPC][NFC] Update test assertions using update_llc_test_checks.py.
Sep 7 2019, 6:44 AM · Restricted Project
Higuoxing added inline comments to D67317: [PowerPC][NFC] Update test assertions using update_llc_test_checks.py.
Sep 7 2019, 5:56 AM · Restricted Project

Sep 6 2019

Higuoxing committed rGed20dcb88b72: Revert [CodeGen] Fix typos to run tests. NFC. (authored by Higuoxing).
Revert [CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 10:16 PM
Higuoxing committed rL371289: Revert [CodeGen] Fix typos to run tests. NFC..
Revert [CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 10:16 PM
Higuoxing added a comment to D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.

Friendly ping @StephenTozer? Seems that this patch has been accepted long time ago. Is this patch still valid? Could you please commit this?

Sep 6 2019, 10:06 PM · Restricted Project
Higuoxing committed rGb38105bbd0f7: [CodeGen] Fix typos to run tests. NFC. (authored by Higuoxing).
[CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 9:59 PM
Higuoxing committed rL371286: [CodeGen] Fix typos to run tests. NFC..
[CodeGen] Fix typos to run tests. NFC.
Sep 6 2019, 9:59 PM

Sep 5 2019

Higuoxing committed rL371165: Request commit access for higuoxing.
Request commit access for higuoxing
Sep 5 2019, 8:41 PM

Jun 12 2019

Higuoxing committed rG7a15e99f3a9d: [DOC] Fix `load` instructions' syntax, function definition. (authored by Higuoxing).
[DOC] Fix `load` instructions' syntax, function definition.
Jun 12 2019, 4:23 AM
Higuoxing committed rL363142: [DOC] Fix `load` instructions' syntax, function definition..
[DOC] Fix `load` instructions' syntax, function definition.
Jun 12 2019, 4:21 AM
Higuoxing closed D63186: [DOC] Fix `load` instructions' syntax, function definition..
Jun 12 2019, 4:21 AM · Restricted Project
Higuoxing retitled D63186: [DOC] Fix `load` instructions' syntax, function definition. from [DOC] Fix `load` instructions' syntex, function definition. to [DOC] Fix `load` instructions' syntax, function definition..
Jun 12 2019, 1:36 AM · Restricted Project
Higuoxing retitled D63186: [DOC] Fix `load` instructions' syntax, function definition. from Fix `load` instructions' syntex, function definition. to [DOC] Fix `load` instructions' syntex, function definition..
Jun 12 2019, 1:11 AM · Restricted Project
Higuoxing created D63186: [DOC] Fix `load` instructions' syntax, function definition..
Jun 12 2019, 1:11 AM · Restricted Project

May 28 2019

Higuoxing abandoned D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.
May 28 2019, 11:02 PM · Restricted Project
Higuoxing added a comment to D62520: [llvm-readobj/llvm-readelf] - Implement GNU style dumper of the SHT_GNU_verdef section..

LGTM, I was coping with my graduation essay these days, so I did not finished my revision in time :) Thank you @rupprecht for informing me.

May 28 2019, 11:02 PM · Restricted Project
Higuoxing abandoned D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section.

Abandon Revision. @grimar has implemented it in https://reviews.llvm.org/D62520

May 28 2019, 11:02 PM · Restricted Project

Apr 23 2019

Higuoxing accepted D61021: Fix typos: (re)?sor?uce -> (re)?source.

Hi, could you please fix this typo in this patch as well?

Apr 23 2019, 10:11 AM · Restricted Project

Apr 16 2019

Higuoxing planned changes to D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

As I'll be away next week, I've added a couple of others to help with reviewing this too.

I'm not certain that the approach you've taken is quite right. There should be no need to query the opts::Output member from within the dumper. That's the purpose of the individual dump styles. There's barely any common code you've actually pulled out. What is the purpose of what you have done?

Sure, I will try to get rid of it.

Apr 16 2019, 9:05 AM · Restricted Project
Higuoxing updated the diff for D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

Sorry for not respounding on this patch for a long time.

Apr 16 2019, 4:43 AM · Restricted Project

Apr 15 2019

Higuoxing accepted D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.

LGTM.

Apr 15 2019, 4:03 AM · Restricted Project

Apr 14 2019

Higuoxing abandoned D60646: [lld] Add double-braces for std::array to suppress warnings. NFC..
Apr 14 2019, 10:44 PM · Restricted Project

Apr 13 2019

Higuoxing added a comment to D60646: [lld] Add double-braces for std::array to suppress warnings. NFC..

rC314838 (included in clang 6) suppressed -Wmissing-braces (enabled by -Wmost and -Wall) warning for the idiomatic brace elision.

http://lists.llvm.org/pipermail/llvm-dev/2019-April/131486.html llvm will migrate to C++14 soon... (though clang < 6 will continue warning the case; I'm not sure if we want to make code less idiomatic just to suppress warnings for old clang; gcc -Wall doesn't enable -Wmissing-braces)

Apr 13 2019, 5:48 AM · Restricted Project
Higuoxing created D60646: [lld] Add double-braces for std::array to suppress warnings. NFC..
Apr 13 2019, 12:26 AM · Restricted Project

Apr 12 2019

Higuoxing committed rGe855e2ebfc79: [llvm-readobj] Change variables' name to match LLVM-style. NFC. (authored by Higuoxing).
[llvm-readobj] Change variables' name to match LLVM-style. NFC.
Apr 12 2019, 12:09 AM
Higuoxing committed rL358259: [llvm-readobj] Change variables' name to match LLVM-style. NFC..
[llvm-readobj] Change variables' name to match LLVM-style. NFC.
Apr 12 2019, 12:08 AM

Apr 10 2019

Higuoxing committed rG8ab74145808b: [llvm-readobj] Should declare `ListScope` for `verneed` entries. (authored by Higuoxing).
[llvm-readobj] Should declare `ListScope` for `verneed` entries.
Apr 10 2019, 5:46 AM
Higuoxing committed rL358078: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
[llvm-readobj] Should declare `ListScope` for `verneed` entries.
Apr 10 2019, 5:46 AM
Higuoxing committed rLLD358078: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
[llvm-readobj] Should declare `ListScope` for `verneed` entries.
Apr 10 2019, 5:45 AM
Higuoxing closed D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
Apr 10 2019, 5:45 AM · Restricted Project

Apr 9 2019

Higuoxing updated the summary of D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
Apr 9 2019, 6:33 AM · Restricted Project
Higuoxing updated the diff for D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..

Addressed @ruiu 's comments.

  • Add commit message.
Apr 9 2019, 6:30 AM · Restricted Project

Apr 8 2019

Higuoxing added a comment to D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..

Can you mention that in the commit message?

Apr 8 2019, 8:53 PM · Restricted Project
Higuoxing created D60438: [llvm-readobj] Should declare `ListScope` for `verneed` entries..
Apr 8 2019, 8:34 PM · Restricted Project
Higuoxing planned changes to D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

This patch breaks some tests, I will modify this later

Apr 8 2019, 5:50 AM · Restricted Project
Higuoxing updated the diff for D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

Rebase.

Apr 8 2019, 5:11 AM · Restricted Project
Higuoxing committed rG0df95d2d3127: [llvm-readobj] Use `reinterpret_cast` instead of C-style casting. NFC. (authored by Higuoxing).
[llvm-readobj] Use `reinterpret_cast` instead of C-style casting. NFC.
Apr 8 2019, 4:48 AM
Higuoxing committed rL357903: [llvm-readobj] Use `reinterpret_cast` instead of C-style casting. NFC..
[llvm-readobj] Use `reinterpret_cast` instead of C-style casting. NFC.
Apr 8 2019, 4:47 AM

Apr 6 2019

Higuoxing added inline comments to D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.
Apr 6 2019, 8:38 PM · Restricted Project

Apr 5 2019

Higuoxing updated the diff for D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

Move VersymBuf out of printVersionSymbol().

Apr 5 2019, 8:58 AM · Restricted Project
Higuoxing updated the diff for D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.

Fix one small nit.

Apr 5 2019, 8:48 AM · Restricted Project
Higuoxing created D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`.
Apr 5 2019, 8:45 AM · Restricted Project
Higuoxing planned changes to D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section.
Apr 5 2019, 3:15 AM · Restricted Project
Higuoxing added inline comments to D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section.
Apr 5 2019, 3:04 AM · Restricted Project
Higuoxing added inline comments to D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section.
Apr 5 2019, 2:28 AM · Restricted Project
Higuoxing created D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section.
Apr 5 2019, 2:21 AM · Restricted Project

Apr 3 2019

Higuoxing added a comment to D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.

Seems that this patch breaks some tests, I will take a look

It was me. Fixed in https://reviews.llvm.org/rL357598

Apr 3 2019, 8:26 AM · Restricted Project
Higuoxing added a comment to D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.

Seems that this patch breaks some tests, I will take a look

Apr 3 2019, 8:20 AM · Restricted Project
Higuoxing committed rG8f6166a72eb4: [llvm-readobj] Add GNU style dumper for .gnu.version section (authored by Higuoxing).
[llvm-readobj] Add GNU style dumper for .gnu.version section
Apr 3 2019, 6:34 AM
Higuoxing committed rL357578: [llvm-readobj] Add GNU style dumper for .gnu.version section.
[llvm-readobj] Add GNU style dumper for .gnu.version section
Apr 3 2019, 6:31 AM
Higuoxing closed D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
Apr 3 2019, 6:31 AM · Restricted Project
Higuoxing added a comment to D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.

LGTM.

Apr 3 2019, 6:28 AM · Restricted Project
Higuoxing added inline comments to D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
Apr 3 2019, 6:28 AM · Restricted Project
Higuoxing updated the diff for D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
  • Using uint64_t instead of uint32_t
Apr 3 2019, 6:25 AM · Restricted Project
Higuoxing committed rG884c29e9ae4c: Fix typos in tests. NFC. (authored by Higuoxing).
Fix typos in tests. NFC.
Apr 3 2019, 6:16 AM
Higuoxing committed rCRT357577: Fix typos in tests. NFC..
Fix typos in tests. NFC.
Apr 3 2019, 6:16 AM
Higuoxing committed rL357577: Fix typos in tests. NFC..
Fix typos in tests. NFC.
Apr 3 2019, 6:15 AM
Higuoxing committed rC357577: Fix typos in tests. NFC..
Fix typos in tests. NFC.
Apr 3 2019, 6:15 AM
Higuoxing closed D60183: Fix typos in tests. NFC..
Apr 3 2019, 6:15 AM · Restricted Project, Restricted Project, Restricted Project
Higuoxing accepted D60183: Fix typos in tests. NFC..
Apr 3 2019, 5:57 AM · Restricted Project, Restricted Project, Restricted Project
Higuoxing created D60183: Fix typos in tests. NFC..
Apr 3 2019, 12:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 2 2019

Higuoxing updated the diff for D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.

.

Apr 2 2019, 7:42 PM · Restricted Project
Higuoxing added inline comments to D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
Apr 2 2019, 7:23 PM · Restricted Project
Higuoxing updated the diff for D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.

Addressed @jhenderson 's comments

Apr 2 2019, 7:21 PM · Restricted Project

Mar 29 2019

Higuoxing accepted D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 6:29 AM · Restricted Project

Mar 28 2019

Higuoxing committed rG09a77fec7595: [llvm-readobj] Change variable names to match LLVM-style. NFC. (authored by Higuoxing).
[llvm-readobj] Change variable names to match LLVM-style. NFC.
Mar 28 2019, 6:26 PM
Higuoxing committed rL357230: [llvm-readobj] Change variable names to match LLVM-style. NFC..
[llvm-readobj] Change variable names to match LLVM-style. NFC.
Mar 28 2019, 6:26 PM
Higuoxing closed D59931: [llvm-readobj] Change variable names to match LLVM-style. NFC..
Mar 28 2019, 6:26 PM · Restricted Project
Higuoxing accepted D59931: [llvm-readobj] Change variable names to match LLVM-style. NFC..
Mar 28 2019, 6:23 PM · Restricted Project
Higuoxing updated the diff for D59931: [llvm-readobj] Change variable names to match LLVM-style. NFC..

Rebase.

Mar 28 2019, 6:22 PM · Restricted Project
Higuoxing retitled D59931: [llvm-readobj] Change variable names to match LLVM-style. NFC. from [llvm-readobj] Change variable names to match LLVM-style to [llvm-readobj] Change variable names to match LLVM-style. NFC..
Mar 28 2019, 6:18 PM · Restricted Project
Higuoxing updated the diff for D59931: [llvm-readobj] Change variable names to match LLVM-style. NFC..

Change SymbolVersionRefSection to SymbolVersionNeedSection

Mar 28 2019, 9:38 AM · Restricted Project
Higuoxing created D59931: [llvm-readobj] Change variable names to match LLVM-style. NFC..
Mar 28 2019, 6:50 AM · Restricted Project
Higuoxing committed rG12632c761be5: - Addressed comments (authored by Higuoxing).
- Addressed comments
Mar 28 2019, 5:53 AM
Higuoxing added a comment to D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.

Sorry, this is my first time use git-svn, I pushed 3 times for a patch ...

Mar 28 2019, 5:53 AM · Restricted Project
Higuoxing committed rG7ffd91124bc8: - Addressed @jhenderson 's comments - Format patch (authored by Higuoxing).
- Addressed @jhenderson 's comments - Format patch
Mar 28 2019, 5:51 AM
Higuoxing committed rG137315e7d43f: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()` (authored by Higuoxing).
[llvm-readobj] Add new helper function `getSymbolVersionByIndex()`
Mar 28 2019, 5:51 AM
Higuoxing committed rL357166: - Addressed comments.
- Addressed comments
Mar 28 2019, 5:50 AM
Higuoxing committed rL357165: - Addressed @jhenderson 's comments.
- Addressed @jhenderson 's comments
Mar 28 2019, 5:50 AM
Higuoxing committed rL357164: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
[llvm-readobj] Add new helper function `getSymbolVersionByIndex()`
Mar 28 2019, 5:50 AM
Higuoxing closed D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
Mar 28 2019, 5:50 AM · Restricted Project
Higuoxing updated the diff for D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
  • Addressed comments
Mar 28 2019, 5:12 AM · Restricted Project
Higuoxing updated the diff for D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
Mar 28 2019, 4:39 AM · Restricted Project

Mar 27 2019

Higuoxing retitled D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section from [llvm-readobj][WIP] Add GNU style dumper for .gnu.version section to [llvm-readobj] Add GNU style dumper for .gnu.version section.
Mar 27 2019, 6:29 PM · Restricted Project
Higuoxing added a comment to D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.

Very cool. It looks like -V also prints a definition/needed section that this patch doesn't support yet. Is that coming in a later patch?

Mar 27 2019, 6:26 PM · Restricted Project
Higuoxing updated the diff for D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
  • Add test file
Mar 27 2019, 7:19 AM · Restricted Project
Higuoxing added a parent revision for D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section: D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.
Mar 27 2019, 6:53 AM · Restricted Project
Higuoxing added a child revision for D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`: D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
Mar 27 2019, 6:53 AM · Restricted Project
Higuoxing created D59877: [llvm-readobj] Add GNU style dumper for .gnu.version section.
Mar 27 2019, 6:52 AM · Restricted Project
Higuoxing updated the diff for D59545: [llvm-readobj] Add new helper function `getSymbolVersionByIndex()`.

Little cleanup.

Mar 27 2019, 6:24 AM · Restricted Project