Page MenuHomePhabricator
Feed Advanced Search

Thu, Jun 10

asaadaldien committed rG20daedacca80: 2d Arm Neon sdot op, and lowering to the intrinsic. (authored by Benoit).
2d Arm Neon sdot op, and lowering to the intrinsic.
Thu, Jun 10, 2:37 PM
asaadaldien closed D102504: 2d Arm Neon sdot op, and lowering to the intrinsic..
Thu, Jun 10, 2:36 PM · Restricted Project

Wed, Jun 9

asaadaldien committed rGb9d7ffd9cf5f: Folds linalg.pad_tensor with zero padding (authored by asaadaldien).
Folds linalg.pad_tensor with zero padding
Wed, Jun 9, 3:44 PM
asaadaldien closed D103984: Folds linalg.pad_tensor with zero padding.
Wed, Jun 9, 3:43 PM · Restricted Project
asaadaldien requested review of D103984: Folds linalg.pad_tensor with zero padding.
Wed, Jun 9, 12:06 PM · Restricted Project

Fri, Jun 4

asaadaldien added a comment to D103724: Revert "Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns".

Apologies for pushing the revert without justifications. The original commit wasn't ready to land at the time it landed.

Fri, Jun 4, 4:42 PM · Restricted Project
asaadaldien added a reverting change for rGa52959401d95: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns: rGbba8d8c1868d: Revert "Add memref.dim canonicalization patterns to….
Fri, Jun 4, 3:44 PM
asaadaldien committed rGbba8d8c1868d: Revert "Add memref.dim canonicalization patterns to… (authored by asaadaldien).
Revert "Add memref.dim canonicalization patterns to…
Fri, Jun 4, 3:44 PM
asaadaldien added a reverting change for D103715: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns: rGbba8d8c1868d: Revert "Add memref.dim canonicalization patterns to….
Fri, Jun 4, 3:44 PM · Restricted Project
asaadaldien closed D103724: Revert "Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns".
Fri, Jun 4, 3:44 PM · Restricted Project
asaadaldien added a reverting change for rGa52959401d95: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns: D103724: Revert "Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns".
Fri, Jun 4, 3:41 PM
asaadaldien requested review of D103724: Revert "Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns".
Fri, Jun 4, 3:41 PM · Restricted Project
asaadaldien added a reverting change for D103715: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns: D103724: Revert "Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns".
Fri, Jun 4, 3:41 PM · Restricted Project
asaadaldien committed rGa52959401d95: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns (authored by asaadaldien).
Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns
Fri, Jun 4, 1:41 PM
asaadaldien closed D103715: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns.
Fri, Jun 4, 1:41 PM · Restricted Project
asaadaldien requested review of D103715: Add memref.dim canonicalization patterns to TilingCanonicalizationPatterns.
Fri, Jun 4, 1:33 PM · Restricted Project

May 12 2021

asaadaldien accepted D102301: [mlir][Linalg] Add interface methods to get lhs and rhs of contraction op..
May 12 2021, 11:07 AM · Restricted Project

May 3 2021

asaadaldien accepted D101795: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering.
May 3 2021, 4:09 PM · Restricted Project

Apr 30 2021

asaadaldien committed rG499e89fc9119: Add patterns to lower vector.multi_reduction into a sequence of vector.reduction (authored by asaadaldien).
Add patterns to lower vector.multi_reduction into a sequence of vector.reduction
Apr 30 2021, 10:53 AM
asaadaldien closed D101570: Add patterns to lower vector.multi_reduction into a sequence of vector.reduction.
Apr 30 2021, 10:53 AM · Restricted Project
asaadaldien updated the diff for D101570: Add patterns to lower vector.multi_reduction into a sequence of vector.reduction.

rebase & fix transpose indexing bug

Apr 30 2021, 10:34 AM · Restricted Project

Apr 29 2021

asaadaldien updated the summary of D101570: Add patterns to lower vector.multi_reduction into a sequence of vector.reduction.
Apr 29 2021, 2:18 PM · Restricted Project
asaadaldien added a reviewer for D101570: Add patterns to lower vector.multi_reduction into a sequence of vector.reduction: ThomasRaoux.
Apr 29 2021, 2:17 PM · Restricted Project
asaadaldien requested review of D101570: Add patterns to lower vector.multi_reduction into a sequence of vector.reduction.
Apr 29 2021, 2:16 PM · Restricted Project

Apr 28 2021

asaadaldien added a comment to D101165: [mlir][Linalg] Generalize linalg vectorization.

LGTM! I benchmarked this on IREE's CPU backend and its causing no regression.

Apr 28 2021, 3:46 PM · Restricted Project
asaadaldien added inline comments to D101165: [mlir][Linalg] Generalize linalg vectorization.
Apr 28 2021, 2:14 PM · Restricted Project

Apr 27 2021

asaadaldien committed rG7fe20634460a: Handle the case of tile and pad a subset of the dimensions (authored by asaadaldien).
Handle the case of tile and pad a subset of the dimensions
Apr 27 2021, 5:42 PM
asaadaldien closed D101319: Handle the case of tile and pad a subset of the dimensions.
Apr 27 2021, 5:41 PM · Restricted Project

Apr 26 2021

asaadaldien requested review of D101319: Handle the case of tile and pad a subset of the dimensions.
Apr 26 2021, 12:36 PM · Restricted Project

Apr 21 2021

asaadaldien committed rG10d7924581f8: Fix FoldReshapeOpWithUnitExtent generating illegal reshape (authored by asaadaldien).
Fix FoldReshapeOpWithUnitExtent generating illegal reshape
Apr 21 2021, 11:32 AM
asaadaldien closed D100805: Fix FoldReshapeOpWithUnitExtent generating illegal reshape.
Apr 21 2021, 11:31 AM · Restricted Project

Apr 20 2021

asaadaldien added inline comments to D100805: Fix FoldReshapeOpWithUnitExtent generating illegal reshape.
Apr 20 2021, 3:26 PM · Restricted Project
asaadaldien updated the diff for D100805: Fix FoldReshapeOpWithUnitExtent generating illegal reshape.

Move validation within folding loop

Apr 20 2021, 3:25 PM · Restricted Project

Apr 19 2021

asaadaldien updated the summary of D100805: Fix FoldReshapeOpWithUnitExtent generating illegal reshape.
Apr 19 2021, 4:59 PM · Restricted Project
asaadaldien requested review of D100805: Fix FoldReshapeOpWithUnitExtent generating illegal reshape.
Apr 19 2021, 4:56 PM · Restricted Project

Apr 15 2021

asaadaldien committed rG0e2f9b61fd9a: Fix tile-and-pad when padding doesn't span all dimension (authored by asaadaldien).
Fix tile-and-pad when padding doesn't span all dimension
Apr 15 2021, 8:18 PM
asaadaldien closed D97720: Fix tile-and-pad when padding doesn't span all dimension.
Apr 15 2021, 8:18 PM · Restricted Project
asaadaldien updated the diff for D97720: Fix tile-and-pad when padding doesn't span all dimension.

Rebase...

Apr 15 2021, 5:31 PM · Restricted Project

Apr 11 2021

asaadaldien accepted D100272: [mlir][Linalg] Disable const -> linalg.generic when fused op is illegal..
Apr 11 2021, 4:56 PM · Restricted Project

Mar 17 2021

asaadaldien committed rGf5963944d97d: Add arm_neon.sdot operation (authored by asaadaldien).
Add arm_neon.sdot operation
Mar 17 2021, 8:26 AM
asaadaldien closed D98198: Add arm_neon.intr.sdot operation.
Mar 17 2021, 8:26 AM · Restricted Project

Mar 12 2021

asaadaldien accepted D98523: [mlir][linalg] Extend linalg vectorization to support non-identity input maps.
Mar 12 2021, 12:52 PM · Restricted Project
asaadaldien added inline comments to D98523: [mlir][linalg] Extend linalg vectorization to support non-identity input maps.
Mar 12 2021, 11:04 AM · Restricted Project

Mar 10 2021

asaadaldien retitled D98198: Add arm_neon.intr.sdot operation from Add arm_neon.sdot operation to Add arm_neon.intr.sdot operation.
Mar 10 2021, 11:23 AM · Restricted Project
asaadaldien added inline comments to D98198: Add arm_neon.intr.sdot operation.
Mar 10 2021, 11:16 AM · Restricted Project
asaadaldien updated the diff for D98198: Add arm_neon.intr.sdot operation.

Move ISA compatible ops into neon.intr.*

Mar 10 2021, 10:58 AM · Restricted Project

Mar 9 2021

asaadaldien added inline comments to D98198: Add arm_neon.intr.sdot operation.
Mar 9 2021, 11:16 AM · Restricted Project
asaadaldien updated the diff for D98198: Add arm_neon.intr.sdot operation.

Constrain elements and change assembly format

Mar 9 2021, 11:09 AM · Restricted Project
asaadaldien added inline comments to D98198: Add arm_neon.intr.sdot operation.
Mar 9 2021, 10:15 AM · Restricted Project

Mar 8 2021

asaadaldien updated the diff for D98198: Add arm_neon.intr.sdot operation.

Comments...

Mar 8 2021, 9:58 PM · Restricted Project
asaadaldien added reviewers for D98198: Add arm_neon.intr.sdot operation: ftynse, nicolasvasilache, aartbik.
Mar 8 2021, 10:25 AM · Restricted Project
asaadaldien requested review of D98198: Add arm_neon.intr.sdot operation.
Mar 8 2021, 10:18 AM · Restricted Project

Mar 4 2021

asaadaldien committed rGda1e37a8b06b: Fold full-size subview of static shapes. (authored by asaadaldien).
Fold full-size subview of static shapes.
Mar 4 2021, 9:52 AM
asaadaldien closed D97429: Fold full-size subview of static shapes..
Mar 4 2021, 9:52 AM · Restricted Project

Mar 3 2021

asaadaldien added inline comments to D97429: Fold full-size subview of static shapes..
Mar 3 2021, 9:25 PM · Restricted Project
asaadaldien updated the diff for D97429: Fold full-size subview of static shapes..

Use shaped-type equality

Mar 3 2021, 9:23 PM · Restricted Project
asaadaldien accepted D97798: [mlir][linalg] Add depthwise_conv_2d_input_nhwc_filter_hwcf to Linalg TC ops..

LGTM for depthwise op_def. the ods changes aren't needed for this change, right ? if yes feel free to split and submit the op_def part.

Mar 3 2021, 11:02 AM · Restricted Project

Mar 1 2021

asaadaldien added inline comments to D97429: Fold full-size subview of static shapes..
Mar 1 2021, 8:38 PM · Restricted Project
asaadaldien added a reviewer for D97429: Fold full-size subview of static shapes.: rriddle.
Mar 1 2021, 3:56 PM · Restricted Project
asaadaldien abandoned D96891: Support tile-and-pad when padding doesn't span all dimension.

split into others started( https://reviews.llvm.org/D97720)

Mar 1 2021, 12:40 PM · Restricted Project
asaadaldien added inline comments to D96891: Support tile-and-pad when padding doesn't span all dimension.
Mar 1 2021, 12:39 PM · Restricted Project
asaadaldien requested review of D97720: Fix tile-and-pad when padding doesn't span all dimension.
Mar 1 2021, 12:38 PM · Restricted Project
asaadaldien updated the diff for D97429: Fold full-size subview of static shapes..

Use local {result|source}shapedType variables

Mar 1 2021, 11:37 AM · Restricted Project
asaadaldien updated the diff for D97429: Fold full-size subview of static shapes..

Fix check-label name

Mar 1 2021, 11:18 AM · Restricted Project
asaadaldien committed rGea7f211b2e6c: [mlir] Add polynomial approximation for math::ExpOp (authored by asaadaldien).
[mlir] Add polynomial approximation for math::ExpOp
Mar 1 2021, 11:02 AM
asaadaldien closed D97599: [mlir] Add polynomial approximation for math::ExpOp.
Mar 1 2021, 11:02 AM · Restricted Project
asaadaldien updated the diff for D97599: [mlir] Add polynomial approximation for math::ExpOp.

Rebase...

Mar 1 2021, 9:46 AM · Restricted Project
asaadaldien updated the diff for D97599: [mlir] Add polynomial approximation for math::ExpOp.

Comments...

Mar 1 2021, 9:26 AM · Restricted Project

Feb 26 2021

asaadaldien added a reviewer for D97599: [mlir] Add polynomial approximation for math::ExpOp: ezhulenev.
Feb 26 2021, 5:20 PM · Restricted Project
asaadaldien requested review of D97599: [mlir] Add polynomial approximation for math::ExpOp.
Feb 26 2021, 5:13 PM · Restricted Project

Feb 24 2021

asaadaldien requested review of D97429: Fold full-size subview of static shapes..
Feb 24 2021, 5:25 PM · Restricted Project
asaadaldien updated the diff for D96891: Support tile-and-pad when padding doesn't span all dimension.

Fix test

Feb 24 2021, 4:29 PM · Restricted Project
asaadaldien updated the diff for D96891: Support tile-and-pad when padding doesn't span all dimension.

Use tile-sizes-for-padding test argument

Feb 24 2021, 4:23 PM · Restricted Project

Feb 23 2021

asaadaldien added inline comments to D97304: [mlir] Add polynomial approximation for math::LogOp (using builders API).
Feb 23 2021, 10:20 PM · Restricted Project
asaadaldien accepted D97304: [mlir] Add polynomial approximation for math::LogOp (using builders API).

LGTM, The log-approximation looks very similar to another implementation I am familiar with (https://github.com/halide/Halide/blob/master/src/IROperator.cpp#L1147)
Some (approximation precision - performance) trade off can be revisited later IMO.

Feb 23 2021, 10:16 PM · Restricted Project

Feb 22 2021

asaadaldien added inline comments to D96891: Support tile-and-pad when padding doesn't span all dimension.
Feb 22 2021, 5:54 PM · Restricted Project
asaadaldien added inline comments to D97146: [mlir] Add polynomial approximation for math::LogOp.
Feb 22 2021, 2:36 PM · Restricted Project
asaadaldien added a reviewer for D96891: Support tile-and-pad when padding doesn't span all dimension: hanchung.
Feb 22 2021, 11:29 AM · Restricted Project

Feb 17 2021

asaadaldien updated the summary of D96891: Support tile-and-pad when padding doesn't span all dimension.
Feb 17 2021, 12:41 PM · Restricted Project
asaadaldien added a reviewer for D96891: Support tile-and-pad when padding doesn't span all dimension: maheshkhanwalkar.
Feb 17 2021, 12:41 PM · Restricted Project
asaadaldien retitled D96891: Support tile-and-pad when padding doesn't span all dimension from Support tile-and-pad when padding doesn't all dimension to Support tile-and-pad when padding doesn't span all dimension.
Feb 17 2021, 12:34 PM · Restricted Project
asaadaldien requested review of D96891: Support tile-and-pad when padding doesn't span all dimension.
Feb 17 2021, 12:28 PM · Restricted Project

Feb 16 2021

asaadaldien accepted D96635: [mlir][Linalg] Add utility method to reshape ops to express output shape in terms of input shape..
Feb 16 2021, 11:13 AM · Restricted Project

Jan 26 2021

asaadaldien accepted D95305: [mlir][Linalg] Add canonicalization for init_tensor -> subtensor op..

LGTM!

Jan 26 2021, 1:52 PM · Restricted Project
asaadaldien added a reviewer for D95305: [mlir][Linalg] Add canonicalization for init_tensor -> subtensor op.: asaadaldien.
Jan 26 2021, 1:08 PM · Restricted Project

Nov 19 2020

asaadaldien accepted D91796: Revert "Reorder linalg.conv indexing_maps loop order".

Thanks @antiagainst! A pass added to in IREE to convert linalg.conv to linalg.generic then apply loop interchange.

Nov 19 2020, 9:32 AM · Restricted Project

Nov 18 2020

asaadaldien accepted D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Nov 18 2020, 4:55 PM · Restricted Project
asaadaldien accepted D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops.
Nov 18 2020, 4:38 PM · Restricted Project

Oct 8 2020

asaadaldien accepted D89002: [mlir][Linalg] Rethink fusion ot linalg ops with reshape ops..

L(very)GTM, thanks Mahesh!. I will leave the pattern splitting/refactoring discussion between you and Nicolas.

Oct 8 2020, 1:30 PM · Restricted Project

Oct 7 2020

asaadaldien added a comment to D89002: [mlir][Linalg] Rethink fusion ot linalg ops with reshape ops..

First pass...

Oct 7 2020, 9:39 PM · Restricted Project

Oct 6 2020

asaadaldien committed rG7060920bd1f7: Relax FuseTensorReshapeOpAsproducer identity mapping constraint (authored by asaadaldien).
Relax FuseTensorReshapeOpAsproducer identity mapping constraint
Oct 6 2020, 3:32 PM
asaadaldien closed D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.
Oct 6 2020, 3:32 PM · Restricted Project
asaadaldien updated the diff for D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.

enable premutations for tensor_reshape as consumer

Oct 6 2020, 1:00 PM · Restricted Project
asaadaldien added a comment to D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.

Thanks Ahmed, just one minor comment.

Oct 6 2020, 12:52 PM · Restricted Project
asaadaldien added inline comments to D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.
Oct 6 2020, 10:13 AM · Restricted Project
asaadaldien updated the diff for D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.

comments...

Oct 6 2020, 10:12 AM · Restricted Project

Oct 5 2020

asaadaldien updated the summary of D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.
Oct 5 2020, 8:57 PM · Restricted Project
asaadaldien requested review of D88869: Relax FuseTensorReshapeOpAsproducer identity mapping constraint.
Oct 5 2020, 8:55 PM · Restricted Project

Sep 30 2020

asaadaldien accepted D88521: [mlir][Linalg] Generalize the logic to compute reassociation mapswhile folding tensor_reshape op..

LGTM! Thanks for fixing this @maheshkhanwalkar.

Sep 30 2020, 7:54 AM · Restricted Project

Sep 29 2020

asaadaldien abandoned D88465: Fix FoldReshapeOpWithUnitExtent when parentSrcType is rank-1.

Abandoned instead https://reviews.llvm.org/D88521

Sep 29 2020, 4:25 PM · Restricted Project