Page MenuHomePhabricator
Feed Advanced Search

Thu, Apr 15

lkail retitled D100290: [PowerPC] Make sure the first probe is full size or is the last probe from [PowerPC] Make sure the first probe is full size or the last probe to [PowerPC] Make sure the first probe is full size or is the last probe.
Thu, Apr 15, 1:10 AM · Restricted Project
lkail added inline comments to D100290: [PowerPC] Make sure the first probe is full size or is the last probe.
Thu, Apr 15, 12:59 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe.
Thu, Apr 15, 12:57 AM · Restricted Project

Wed, Apr 14

lkail planned changes to D100290: [PowerPC] Make sure the first probe is full size or is the last probe.

Current solution hasn't guaranteed back-chain pointer is updated atomically, I have another solution for this and guarantee safety and atomic.

Wed, Apr 14, 7:45 PM · Restricted Project
lkail requested review of D100453: [MIR][NFC] Introduce a new method to check a MachineInstr contains implicit register.
Wed, Apr 14, 12:52 AM · Restricted Project

Tue, Apr 13

lkail added a comment to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

implicit $x5 is in the explicit operand list.

Should it be an issue that the implicit $x5 should not be in the explicit operand list? Since when we have implicit $x5 as an explicit operand?

Tue, Apr 13, 10:45 PM · Restricted Project

Mon, Apr 12

lkail updated the diff for D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Mon, Apr 12, 3:18 AM · Restricted Project
lkail updated the summary of D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Mon, Apr 12, 3:03 AM · Restricted Project
lkail updated the summary of D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Mon, Apr 12, 3:01 AM · Restricted Project
lkail requested review of D100293: [PowerPC][AIX] Enable sibling call optimization on AIX.
Mon, Apr 12, 3:01 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe.
Mon, Apr 12, 2:43 AM · Restricted Project
lkail updated the diff for D100290: [PowerPC] Make sure the first probe is full size or is the last probe.
Mon, Apr 12, 2:30 AM · Restricted Project
lkail requested review of D100290: [PowerPC] Make sure the first probe is full size or is the last probe.
Mon, Apr 12, 2:08 AM · Restricted Project

Fri, Apr 9

lkail added a comment to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

Ping

Fri, Apr 9, 3:16 AM · Restricted Project
lkail added inline comments to D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Fri, Apr 9, 3:15 AM · Restricted Project
lkail updated the diff for D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.

Adjust comments.

Fri, Apr 9, 3:12 AM · Restricted Project
lkail updated the diff for D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Fri, Apr 9, 2:23 AM · Restricted Project
lkail updated the summary of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Fri, Apr 9, 2:04 AM · Restricted Project
lkail updated the summary of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Fri, Apr 9, 2:02 AM · Restricted Project
lkail updated the summary of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Fri, Apr 9, 2:02 AM · Restricted Project
lkail updated the summary of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Fri, Apr 9, 2:01 AM · Restricted Project
lkail requested review of D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback.
Fri, Apr 9, 2:01 AM · Restricted Project

Thu, Apr 1

lkail added a comment to D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.

Ping.

Thu, Apr 1, 10:05 PM · Restricted Project

Sun, Mar 28

lkail updated the diff for D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

Do not early return in PPCInstrInfo::replaceInstrOperandWithImm.

Sun, Mar 28, 7:27 AM · Restricted Project

Tue, Mar 23

lkail planned changes to D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI().

This fix looks not in a proper direction. If I remove lines llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.cpp:[2259-2261) in https://reviews.llvm.org/D56078, the test in this patch gets passed.
I tried dump MI and its explicit_operands, the output looks not what I expected.
Code modification

if (SpecialShift32 || SpecialShift64) {
  MI.dump();
  for (auto &op : MI.explicit_operands()) {
    op.dump();
  }
Tue, Mar 23, 9:49 PM · Restricted Project

Mar 18 2021

lkail added a reviewer for D98659: [MachineCopyPropagation] Do more backward copy propagations: craig.topper.
Mar 18 2021, 4:56 AM · Restricted Project
lkail added reviewers for D98659: [MachineCopyPropagation] Do more backward copy propagations: qcolombet, efriedma, bogner, jmorse, lkail.
Mar 18 2021, 4:54 AM · Restricted Project
lkail added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Thanks for your review. There is a test case in https://reviews.llvm.org/D98401, which is quite big. I wasn't able to reduce it further, is it OK to just include that as test case?

Mar 18 2021, 4:53 AM · Restricted Project

Mar 17 2021

lkail added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

Since this patch already changed output of many test cases, do we still need a test case specifically for this patch?

Mar 17 2021, 9:18 PM · Restricted Project
lkail added a comment to D98659: [MachineCopyPropagation] Do more backward copy propagations.

I haven't looked into implementation details. There are some coding style issues need to be fixed.

Mar 17 2021, 9:06 PM · Restricted Project

Mar 15 2021

lkail added a comment to D98401: [CodeGen] Fix backward copy propagation with -g.
renamable $rbx = nuw LEA64r %stack.5.agg.tmp.i, 1, $noreg, 8, $noreg
DBG_VALUE $rbp, $noreg, !"this", !DIExpression(), debug-location !293; hot.cpp:0 @[ hot.cpp:84:39 @[ hot.cpp:108:11 ] ] line no:0

Shouldn't the $rbp in DBG_VALUE be updated as well?

Mar 15 2021, 4:41 AM · Restricted Project
lkail committed rTe4defee7cbb2: [test-suite][AIX] Enable profiling via hpmcount on AIX (authored by lkail).
[test-suite][AIX] Enable profiling via hpmcount on AIX
Mar 15 2021, 2:00 AM
lkail closed D96002: [test-suite][AIX] Enable profiling via hpmcount on AIX.
Mar 15 2021, 2:00 AM

Mar 14 2021

lkail added a reviewer for D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops: nemanjai.
Mar 14 2021, 10:26 PM · Restricted Project
lkail updated the diff for D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.

@RKSimon Sorry for late response. I have moved the transformation into PPCISelLowering.

Mar 14 2021, 10:26 PM · Restricted Project

Mar 10 2021

lkail added reviewers for D98340: [PowerPC] Fix infinite loop in peephole CR optimization (PR49509): nemanjai, jsji.
Mar 10 2021, 6:47 AM · Restricted Project

Feb 25 2021

lkail added a reviewer for D97455: [PowerPC][AIX] Enable moving stack update for AIX: stefanp.
Feb 25 2021, 2:28 AM · Restricted Project
lkail requested review of D97455: [PowerPC][AIX] Enable moving stack update for AIX.
Feb 25 2021, 2:26 AM · Restricted Project

Feb 17 2021

lkail added a comment to D96002: [test-suite][AIX] Enable profiling via hpmcount on AIX.

Ping

Feb 17 2021, 6:05 PM
lkail added reviewers for D96002: [test-suite][AIX] Enable profiling via hpmcount on AIX: MatzeB, peter.smith, homerdin, eizan.
Feb 17 2021, 6:05 PM

Feb 5 2021

lkail updated subscribers of D96002: [test-suite][AIX] Enable profiling via hpmcount on AIX.
Feb 5 2021, 6:42 PM
lkail added a reviewer for D96004: [AArch64] Stack probing for function prologues: jonpa.
Feb 5 2021, 2:18 AM · Restricted Project
lkail added a reviewer for D96004: [AArch64] Stack probing for function prologues: efriedma.
Feb 5 2021, 2:15 AM · Restricted Project

Feb 4 2021

lkail retitled D96002: [test-suite][AIX] Enable profiling via hpmcount on AIX from [test-suite] Enable profiling via hpmcount on AIX to [test-suite][AIX] Enable profiling via hpmcount on AIX.
Feb 4 2021, 1:03 AM
lkail requested review of D96002: [test-suite][AIX] Enable profiling via hpmcount on AIX.
Feb 4 2021, 12:57 AM

Jan 10 2021

lkail added reviewers for D94385: [NFC] Disallow unused prefixes in CodeGen/PowerPC tests.: nemanjai, Restricted Project.
Jan 10 2021, 10:33 PM · Restricted Project

Jan 3 2021

lkail committed rGf6515b05205d: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is… (authored by lkail).
[PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is…
Jan 3 2021, 11:54 PM
lkail closed D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Jan 3 2021, 11:54 PM · Restricted Project

Dec 29 2020

lkail updated the diff for D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Dec 29 2020, 7:03 PM · Restricted Project
lkail updated the diff for D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.

Update comment and I've pre-commit a mir test https://github.com/llvm/llvm-project/commit/e3e25cfb44bc2a35e3b53d62d37c27b7d13157b6 to demonstrate the situation when equalityOnly is true. The codegen of the test case doesn't change with this patch.

Dec 29 2020, 6:56 PM · Restricted Project
lkail committed rGe3e25cfb44bc: [PowerPC] Add mir test to show effect of `optimizeCompareInstr` when… (authored by lkail).
[PowerPC] Add mir test to show effect of `optimizeCompareInstr` when…
Dec 29 2020, 6:29 PM
lkail committed rGf904d50c29f2: [PowerPC] Remaining KnownBits should be constant when performing non-sign… (authored by lkail).
[PowerPC] Remaining KnownBits should be constant when performing non-sign…
Dec 29 2020, 6:01 PM
lkail closed D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Dec 29 2020, 6:01 PM · Restricted Project
lkail retitled D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison from [PowerPC] KnownBits should be constant when performing non-sign comparison to [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Dec 29 2020, 4:40 AM · Restricted Project
lkail updated the diff for D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Dec 29 2020, 4:38 AM · Restricted Project
lkail updated the diff for D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.

@nemanjai 's solution can make code more compact. Thanks.

Dec 29 2020, 4:36 AM · Restricted Project
lkail added inline comments to D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Dec 29 2020, 4:08 AM · Restricted Project

Dec 23 2020

lkail abandoned D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Functionality of this patch can be covered by https://reviews.llvm.org/D93191.

Dec 23 2020, 6:14 PM · Restricted Project

Dec 17 2020

lkail added inline comments to D92405: [VirtRegRewriter] Insert missing killed flags when tracking subregister liveness.
Dec 17 2020, 1:32 AM · Restricted Project
lkail added inline comments to D90349: [DAGCombiner] Improve shift by select of constant.
Dec 17 2020, 12:05 AM · Restricted Project

Dec 16 2020

lkail added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 16 2020, 7:32 PM · Restricted Project
lkail added inline comments to D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA..
Dec 16 2020, 6:44 PM · Restricted Project
lkail added inline comments to D93370: [PowerPC] Add new infrastructure to select load/store instructions, update P8/P9 load/store patterns..
Dec 16 2020, 4:55 AM · Restricted Project, Restricted Project

Dec 13 2020

lkail requested review of D93191: [PowerPC] Fold select_cc constants when comparing zero into trivial ops.
Dec 13 2020, 9:41 PM · Restricted Project

Dec 11 2020

lkail added a reviewer for D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison: hfinkel.
Dec 11 2020, 12:49 AM · Restricted Project
lkail requested review of D93092: [PowerPC] Remaining KnownBits should be constant when performing non-sign comparison.
Dec 11 2020, 12:45 AM · Restricted Project

Dec 7 2020

lkail committed rG44bd8ea167f2: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation (authored by lkail).
[DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation
Dec 7 2020, 7:24 PM
lkail closed D92637: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation.
Dec 7 2020, 7:24 PM · Restricted Project
lkail updated the diff for D92637: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation.

Per @RKSimon 's suggestion.

Dec 7 2020, 1:59 AM · Restricted Project

Dec 4 2020

lkail requested review of D92637: [DAGCombine][PowerPC] Simplify nabs by using legal `smin` operation.
Dec 4 2020, 12:04 AM · Restricted Project

Dec 3 2020

lkail committed rGf5d52916ce34: [PowerPC] Pre-commit neg abs test for vector. NFC. (authored by lkail).
[PowerPC] Pre-commit neg abs test for vector. NFC.
Dec 3 2020, 10:53 PM

Dec 1 2020

lkail updated the summary of D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.
Dec 1 2020, 1:47 AM · Restricted Project

Nov 25 2020

lkail added a reviewer for D92156: [PowerPC] Add support for "tlbiel" with two arguments: nemanjai.
Nov 25 2020, 11:11 PM · Restricted Project
lkail planned changes to D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

Gonna to add more patterns and refine current code.

Nov 25 2020, 9:52 PM · Restricted Project

Nov 24 2020

lkail committed rG97e7ce3b15cc: [PowerPC] Probe the gap between stackptr and realigned stackptr (authored by lkail).
[PowerPC] Probe the gap between stackptr and realigned stackptr
Nov 24 2020, 11:02 PM
lkail closed D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.
Nov 24 2020, 11:01 PM · Restricted Project
lkail updated the diff for D90156: [PowerPC] Do not fold `cmp(d|w)` and `subf` instruction to `subf.` if `nsw` is not present.

Rebased.

Nov 24 2020, 8:52 PM · Restricted Project
lkail committed rG8e6d92026c62: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding… (authored by lkail).
[DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding…
Nov 24 2020, 8:39 PM
lkail closed D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.
Nov 24 2020, 8:39 PM · Restricted Project
lkail updated the diff for D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

Reformat code.

Nov 24 2020, 7:33 PM · Restricted Project
lkail updated the diff for D88078: [PowerPC] Probe the gap between stackptr and realigned stackptr.

Refined comments.

Nov 24 2020, 7:22 PM · Restricted Project
lkail added a comment to D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

Gentle ping.

Nov 24 2020, 1:52 AM · Restricted Project
lkail committed rG5931be60b523: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops (authored by lkail).
[DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops
Nov 24 2020, 1:44 AM
lkail closed D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 24 2020, 1:43 AM · Restricted Project
lkail added a comment to D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Removed parent revision, since this patch doesn't rely on opt's abs canonicalization.

Nov 24 2020, 12:39 AM · Restricted Project

Nov 23 2020

lkail committed rGda3bc99bdd77: [PowerPC] Pre-commit more tests for `select` codegen. NFC. (authored by lkail).
[PowerPC] Pre-commit more tests for `select` codegen. NFC.
Nov 23 2020, 10:38 PM

Nov 19 2020

lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Rebased on Simon's commit.

Nov 19 2020, 9:31 PM · Restricted Project

Nov 18 2020

lkail added inline comments to D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 18 2020, 7:24 PM · Restricted Project
lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Removed the hook and added test cases for other arch.

Nov 18 2020, 6:43 PM · Restricted Project
lkail committed rG5f0ae23e71df: [X86][AArch64][RISCV] Pre-commit negated abs test case. NFC. (authored by lkail).
[X86][AArch64][RISCV] Pre-commit negated abs test case. NFC.
Nov 18 2020, 6:32 PM

Nov 17 2020

lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 17 2020, 1:48 AM · Restricted Project
lkail committed rGc2460c3254a0: [PowerPC] Add negated abs test using llvm.abs intrinsic. NFC. (authored by lkail).
[PowerPC] Add negated abs test using llvm.abs intrinsic. NFC.
Nov 17 2020, 1:31 AM

Nov 13 2020

lkail updated the diff for D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Pre-committed test case and rebased.

Nov 13 2020, 12:14 AM · Restricted Project
lkail committed rG96ff53fbaead: [PowerPC] Add test case for negated abs. NFC. (authored by lkail).
[PowerPC] Add test case for negated abs. NFC.
Nov 13 2020, 12:07 AM

Nov 12 2020

lkail added a comment to D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.

Note that we are planning to canonicalize IR to the abs() intrinsic - D87188.
Assuming that comes through relatively soon (cc @nikic), should we hold off adding what would probably become dead code in the backend?

Nov 12 2020, 11:32 PM · Restricted Project

Nov 9 2020

lkail requested review of D91120: [DAGCombine][PowerPC] Convert negated abs to trivial arithmetic ops.
Nov 9 2020, 9:28 PM · Restricted Project

Nov 6 2020

lkail updated subscribers of D90901: [DAGCombiner] Don't fold ((fma (fneg X), Y, (fneg Z)) to fneg (fma X, Y, Z)).
Nov 6 2020, 1:24 AM · Restricted Project

Nov 5 2020

lkail added a comment to D89938: [DAG][PowerPC] Fix dropped `nsw` flag in `SimplifySetCC` by adding `doesNodeExist` helper.

Ping.

Nov 5 2020, 7:29 PM · Restricted Project

Nov 3 2020

lkail updated the diff for D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.
Nov 3 2020, 9:28 PM · Restricted Project
lkail added a comment to D89084: [PowerPC] Combine select_cc (x, 0, t, f, lt) to avoid generating `isel`.

I guess this opt should also be profitable for opcode SELECT, is there any reason we don't do this?

Nov 3 2020, 9:26 PM · Restricted Project