Page MenuHomePhabricator
Feed Advanced Search

Today

gchatelet committed rG98cb8db836b1: [NFC] remove unused functions (authored by gchatelet).
[NFC] remove unused functions
Mon, Sep 16, 7:51 AM
gchatelet committed rL371994: [NFC] remove unused functions.
[NFC] remove unused functions
Mon, Sep 16, 7:47 AM
gchatelet closed D67616: [NFC] remove unused functions.
Mon, Sep 16, 7:47 AM · Restricted Project
gchatelet created D67620: [Alignment][NFC] Remove LogAlignment functions.
Mon, Sep 16, 7:37 AM · Restricted Project
gchatelet created D67616: [NFC] remove unused functions.
Mon, Sep 16, 6:22 AM · Restricted Project
gchatelet added a comment to D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.

A gentle ping @majnemer

Mon, Sep 16, 1:34 AM · Restricted Project

Fri, Sep 13

gchatelet committed rG36202635323b: [Alignment] Introduce llvm::Align to MCSection (authored by gchatelet).
[Alignment] Introduce llvm::Align to MCSection
Fri, Sep 13, 2:29 AM
gchatelet committed rL371831: [Alignment] Introduce llvm::Align to MCSection.
[Alignment] Introduce llvm::Align to MCSection
Fri, Sep 13, 2:29 AM
gchatelet closed D67486: [Alignment] Introduce llvm::Align to MCSection.
Fri, Sep 13, 2:29 AM · Restricted Project
gchatelet updated the diff for D67486: [Alignment] Introduce llvm::Align to MCSection.
  • rebase
Fri, Sep 13, 2:24 AM · Restricted Project

Thu, Sep 12

gchatelet updated subscribers of D64790: [LLVM][NFC] Adding an Alignment type to LLVM.

Thanks for looking at this. I haven't looked at this or the related patches at all, and I know this has landed already. I haven't really looked at the details of the patch, but I did want to highlight a possible conflict in interpretation of 0 alignment. In the elf gABI, the two alignment fields (sh_addralign and p_align) both have the statement "Values 0 and 1 mean no alignment is required". In other words, 0 is not technically an undefined alignment any more than 1 is, at least in the ELF context. That being said, if you are always treating an alignment of 0 as an alignment of 1, I don't think there's any issue.

Thu, Sep 12, 8:50 AM · Restricted Project
gchatelet updated the diff for D67486: [Alignment] Introduce llvm::Align to MCSection.
  • Address comments and rebase
Thu, Sep 12, 8:29 AM · Restricted Project
gchatelet committed rGaf11cc7eb5da: [Alignment] Move OffsetToAlignment to Alignment.h (authored by gchatelet).
[Alignment] Move OffsetToAlignment to Alignment.h
Thu, Sep 12, 8:20 AM
gchatelet committed rL371742: [Alignment] Move OffsetToAlignment to Alignment.h.
[Alignment] Move OffsetToAlignment to Alignment.h
Thu, Sep 12, 8:19 AM
gchatelet closed D67499: [Alignment] Move OffsetToAlignment to Alignment.h.
Thu, Sep 12, 8:19 AM · Restricted Project, Restricted Project
gchatelet updated the diff for D67499: [Alignment] Move OffsetToAlignment to Alignment.h.
  • Address comments
Thu, Sep 12, 8:02 AM · Restricted Project, Restricted Project
gchatelet created D67499: [Alignment] Move OffsetToAlignment to Alignment.h.
Thu, Sep 12, 7:37 AM · Restricted Project, Restricted Project
gchatelet created D67486: [Alignment] Introduce llvm::Align to MCSection.
Thu, Sep 12, 2:57 AM · Restricted Project

Wed, Sep 11

gchatelet committed rG97264366fbad: [Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment (authored by gchatelet).
[Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment
Wed, Sep 11, 6:43 AM
gchatelet committed rL371616: [Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment.
[Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment
Wed, Sep 11, 6:36 AM
gchatelet closed D67443: [Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment.
Wed, Sep 11, 6:36 AM · Restricted Project
gchatelet updated the diff for D67443: [Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment.
  • Address comments and rebase
Wed, Sep 11, 6:26 AM · Restricted Project
gchatelet created D67443: [Alignment][NFC] use llvm::Align for AsmPrinter::EmitAlignment.
Wed, Sep 11, 6:11 AM · Restricted Project
gchatelet committed rG48904e9452de: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir… (authored by gchatelet).
[Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir…
Wed, Sep 11, 4:19 AM
gchatelet committed rL371608: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir….
[Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir…
Wed, Sep 11, 4:19 AM
gchatelet closed D67433: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir parsing.
Wed, Sep 11, 4:16 AM · Restricted Project
gchatelet updated the diff for D67433: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir parsing.
  • Address comments
Wed, Sep 11, 3:56 AM · Restricted Project
gchatelet updated the summary of D67433: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir parsing.
Wed, Sep 11, 3:49 AM · Restricted Project
gchatelet created D67433: [Alignment] Use llvm::Align in MachineFunction and TargetLowering - fixes mir parsing.
Wed, Sep 11, 2:42 AM · Restricted Project
gchatelet abandoned D67394: [NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF.

Yes rL371513 is the way to go. Thx for the review, I'll abandon this patch.

Wed, Sep 11, 12:42 AM · Restricted Project

Tue, Sep 10

gchatelet removed reviewers for D67394: [NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF: jfb, courbet.
Tue, Sep 10, 8:11 AM · Restricted Project
gchatelet added a reviewer for D67394: [NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF: rnk.
Tue, Sep 10, 8:11 AM · Restricted Project
gchatelet updated the diff for D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
  • Address comments
Tue, Sep 10, 8:08 AM · Restricted Project
gchatelet added inline comments to D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
Tue, Sep 10, 8:07 AM · Restricted Project
gchatelet added a reviewer for D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align: majnemer.
Tue, Sep 10, 8:04 AM · Restricted Project
gchatelet updated the summary of D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
Tue, Sep 10, 7:55 AM · Restricted Project
gchatelet updated the diff for D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
  • Format
Tue, Sep 10, 7:51 AM · Restricted Project
gchatelet created D67400: [Alignment][NFC] migrate DataLayout internal struct to llvm::Align.
Tue, Sep 10, 7:46 AM · Restricted Project
gchatelet added a reviewer for D67394: [NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF: courbet.
Tue, Sep 10, 6:00 AM · Restricted Project
gchatelet created D67394: [NFC] Explicitly state that llvm/test/MC/AsmParser/preserve-comments-crlf.s must be CRLF.
Tue, Sep 10, 5:55 AM · Restricted Project
gchatelet committed rG3729b17cff53: [Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment (authored by gchatelet).
[Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment
Tue, Sep 10, 5:00 AM
gchatelet committed rL371511: [Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment.
[Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment
Tue, Sep 10, 4:59 AM
gchatelet closed D67386: [Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment.
Tue, Sep 10, 4:59 AM · Restricted Project
gchatelet updated the diff for D67386: [Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment.
  • rebase
Tue, Sep 10, 4:25 AM · Restricted Project
gchatelet committed rGb6722af06863: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment (authored by gchatelet).
[Alignment] Use Align for TargetLowering::MinStackArgumentAlignment
Tue, Sep 10, 2:04 AM
gchatelet committed rL371498: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
[Alignment] Use Align for TargetLowering::MinStackArgumentAlignment
Tue, Sep 10, 2:03 AM
gchatelet closed D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
Tue, Sep 10, 2:03 AM · Restricted Project
gchatelet updated the diff for D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
  • Address comments && rebase
Tue, Sep 10, 1:54 AM · Restricted Project
gchatelet created D67386: [Alignment][NFC] Use llvm::Align for TargetLowering::getPrefLoopAlignment.
Tue, Sep 10, 1:26 AM · Restricted Project

Mon, Sep 9

gchatelet updated the diff for D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
  • rebase
Mon, Sep 9, 2:35 AM · Restricted Project

Sun, Sep 8

gchatelet added a comment to rL371200: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.

FYI, AVR, as experimental backend, wasn't updated. I did it in https://reviews.llvm.org/rL371293 to unbreak the build.

Sun, Sep 8, 12:50 AM

Fri, Sep 6

gchatelet created D67288: [Alignment] Use Align for TargetLowering::MinStackArgumentAlignment.
Fri, Sep 6, 10:07 AM · Restricted Project
gchatelet committed rGad1cea0ddafe: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment (authored by gchatelet).
[Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment
Fri, Sep 6, 8:03 AM
gchatelet committed rL371212: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.
[Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment
Fri, Sep 6, 8:02 AM
gchatelet closed D67267: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.
Fri, Sep 6, 8:02 AM · Restricted Project
gchatelet added a comment to D67267: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.

Thx!

Fri, Sep 6, 8:02 AM · Restricted Project
gchatelet updated the diff for D67267: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.
  • rebase
Fri, Sep 6, 8:01 AM · Restricted Project
gchatelet committed rG9fcf066d0cd2: [Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment (authored by gchatelet).
[Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment
Fri, Sep 6, 7:52 AM
gchatelet committed rL371210: [Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment.
[Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment
Fri, Sep 6, 7:52 AM
gchatelet closed D67278: [Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment.
Fri, Sep 6, 7:52 AM · Restricted Project
gchatelet added a comment to D67278: [Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment.

Thx !

Fri, Sep 6, 7:52 AM · Restricted Project
gchatelet created D67278: [Alignment][NFC] Use Align with TargetLowering::setPrefLoopAlignment.
Fri, Sep 6, 7:42 AM · Restricted Project
gchatelet committed rG5d870c2ec0a6: [Alignment] fix dubious min function alignment (authored by gchatelet).
[Alignment] fix dubious min function alignment
Fri, Sep 6, 6:58 AM
gchatelet added a comment to D67271: [Alignment] fix dubious min function alignment.

Thx!

Fri, Sep 6, 6:58 AM · Restricted Project
gchatelet committed rL371204: [Alignment] fix dubious min function alignment.
[Alignment] fix dubious min function alignment
Fri, Sep 6, 6:52 AM
gchatelet closed D67271: [Alignment] fix dubious min function alignment.
Fri, Sep 6, 6:52 AM · Restricted Project
gchatelet created D67271: [Alignment] fix dubious min function alignment.
Fri, Sep 6, 6:06 AM · Restricted Project
gchatelet updated the diff for D67267: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.
  • rebase
Fri, Sep 6, 5:54 AM · Restricted Project
gchatelet committed rG4fc3ad9e1359: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment (authored by gchatelet).
[Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment
Fri, Sep 6, 5:49 AM
gchatelet committed rL371200: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.
[Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment
Fri, Sep 6, 5:49 AM
gchatelet closed D67229: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.
Fri, Sep 6, 5:49 AM · Restricted Project
gchatelet updated the diff for D67229: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.
  • Added const
Fri, Sep 6, 5:45 AM · Restricted Project
gchatelet created D67267: [Alignment][NFC] Use Align with TargetLowering::setPrefFunctionAlignment.
Fri, Sep 6, 5:42 AM · Restricted Project

Thu, Sep 5

gchatelet added inline comments to D67229: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.
Thu, Sep 5, 9:19 AM · Restricted Project
gchatelet created D67229: [Alignment][NFC] Use Align with TargetLowering::setMinFunctionAlignment.
Thu, Sep 5, 9:17 AM · Restricted Project
gchatelet committed rGf9f31ce6a906: [Alignment][NFC] Change internal representation of TargetLowering.h (authored by gchatelet).
[Alignment][NFC] Change internal representation of TargetLowering.h
Thu, Sep 5, 8:44 AM
gchatelet committed rL371082: [Alignment][NFC] Change internal representation of TargetLowering.h.
[Alignment][NFC] Change internal representation of TargetLowering.h
Thu, Sep 5, 8:43 AM
gchatelet closed D67226: [Alignment][NFC] Change internal representation of TargetLowering.h.
Thu, Sep 5, 8:43 AM · Restricted Project
gchatelet updated the summary of D67226: [Alignment][NFC] Change internal representation of TargetLowering.h.
Thu, Sep 5, 7:53 AM · Restricted Project
gchatelet retitled D67226: [Alignment][NFC] Change internal representation of TargetLowering.h from [LLVM][Alignment] Change internal representation of TargetLowering.h to [Alignment][NFC] Change internal representation of TargetLowering.h.
Thu, Sep 5, 7:53 AM · Restricted Project
gchatelet created D67226: [Alignment][NFC] Change internal representation of TargetLowering.h.
Thu, Sep 5, 7:42 AM · Restricted Project
gchatelet committed rG9cef6400014a: [LLVM][Alignment][NFC] Fixing wrong documentation (authored by gchatelet).
[LLVM][Alignment][NFC] Fixing wrong documentation
Thu, Sep 5, 7:18 AM
gchatelet committed rL371073: [LLVM][Alignment][NFC] Fixing wrong documentation.
[LLVM][Alignment][NFC] Fixing wrong documentation
Thu, Sep 5, 7:15 AM
gchatelet committed rG33671ceffa63: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align (authored by gchatelet).
[LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align
Thu, Sep 5, 6:12 AM
gchatelet committed rL371063: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align.
[LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align
Thu, Sep 5, 6:12 AM
gchatelet closed D67223: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align.
Thu, Sep 5, 6:12 AM · Restricted Project
gchatelet updated the diff for D67223: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align.
  • Assert if alignment is not set
Thu, Sep 5, 5:55 AM · Restricted Project
gchatelet created D67223: [LLVM][Alignment] Convert isLegalNTStore/isLegalNTLoad to llvm::Align.
Thu, Sep 5, 5:34 AM · Restricted Project
gchatelet committed rGaff45e4b235d: [LLVM][Alignment] Make functions using log of alignment explicit (authored by gchatelet).
[LLVM][Alignment] Make functions using log of alignment explicit
Thu, Sep 5, 3:01 AM
gchatelet committed rL371045: [LLVM][Alignment] Make functions using log of alignment explicit.
[LLVM][Alignment] Make functions using log of alignment explicit
Thu, Sep 5, 3:00 AM
gchatelet closed D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Thu, Sep 5, 2:59 AM · Restricted Project
gchatelet added a comment to D65945: [LLVM][Alignment] Make functions using log of alignment explicit.

Thx @thegameg and @lattner , I'll commit shortly!

Thu, Sep 5, 2:38 AM · Restricted Project
gchatelet updated the diff for D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
  • Rebasing
  • Update documentation flags.
  • Add missing renames
  • Use powers of 2 for alignment in YAMLized mir files
  • Make sure YAML MIR has align as Powers of 2. Fix tests.
  • Added documentation in MIRLangRef.rst
Thu, Sep 5, 2:30 AM · Restricted Project

Wed, Sep 4

gchatelet added a reviewer for D65945: [LLVM][Alignment] Make functions using log of alignment explicit: thegameg.
Wed, Sep 4, 12:43 PM · Restricted Project
gchatelet updated subscribers of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.

Renaming this to LogAlignment is much more clear throughout the core infra, thank you! Please get someone who knows the Yaml stuff to approve as well.

Wed, Sep 4, 12:43 PM · Restricted Project
gchatelet added a comment to D65945: [LLVM][Alignment] Make functions using log of alignment explicit.

@lattner I've added you to this review because I get no feedback from the authors (and you seem to be the OWNER).
The rename exposed a bug in the way alignment of basic blocks and function arguments are serialized for YAML mir.
From this patch and the parseAlignment code it is clear that the serialized form expects powers of two, but the internal structures receiving the alignment deal with log2 of alignments (MachineFunction and MachineBasicBlock).

Wed, Sep 4, 8:05 AM · Restricted Project
gchatelet updated the summary of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
Wed, Sep 4, 8:03 AM · Restricted Project
gchatelet updated the diff for D65945: [LLVM][Alignment] Make functions using log of alignment explicit.
  • Rebasing
  • Update documentation flags.
  • Add missing renames
  • Use powers of 2 for alignment in YAMLized mir files
  • Make sure YAML MIR has align as Powers of 2. Fix tests.
Wed, Sep 4, 7:38 AM · Restricted Project
gchatelet added a comment to D64146: [Clang Interpreter] Initial patch for the constexpr interpreter.

This patch broke my build as well (discovered by runnin git bisect), command line

cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=/usr/local/bin/clang -DCMAKE_ASM_COMPILER=/usr/local/bin/clang -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DBUILD_SHARED_LIBS=ON -DLLVM_USE_SPLIT_DWARF=ON -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=ARC -DLLVM_ENABLE_PROJECTS=clang -DLLVM_BUILD_TESTS=ON -DLLVM_BUILD_DOCS=ON -DLLVM_ENABLE_WERROR=ON -H/redacted/git/llvm-project/llvm -B/tmp/llvm-project_dbg_compiled-with-clang -GNinja
ninja -C /tmp/llvm-project_dbg_compiled-with-clang

Wed, Sep 4, 2:57 AM · Restricted Project, Restricted Project

Fri, Aug 30

gchatelet updated subscribers of D65945: [LLVM][Alignment] Make functions using log of alignment explicit.

@arphaman do you mind having a look at the MIR parser / writer parts?
How is alignment supposed to be serialized for MIR? As power of two or a log of alignment?

Fri, Aug 30, 8:08 AM · Restricted Project