For the email please user firstname.lastname@example.org and for the author please use "Liad Mordekoviz",
Again thank you very much for all the kind help!
Feb 11 2020
Fixed failed tests
Feb 2 2020
Thank you all for your help with this patch, I do not have permissions to merge, how can I get this merged?
Jan 31 2020
Added local test to rela as well
Jan 30 2020
Fixed file header
Fixed missing newline and aligned values with spaces
Jan 29 2020
Added RELA and removed trailing newline at end of file
Fixed commit message yet again and minimized the YAML for the ELF32 test
Updated commit message
The previous diff was the wrong one
Update formatting and test names
Jan 25 2020
Updated required changes, removed unnecessary additions of --strict-whitespace, I did not change the content of the ELF32 test because there was no conclusive decision to whether I should or shouldn't remove the extra relocations on that test.
Jan 23 2020
Jan 22 2020
Jan 21 2020
Updated with the requested changes and with new tests added and updated
I've updated the relocations-elf.test file with the new headers, they seem to recognize the headers quite well, however, the relocations on my machine come out different than the test expects, so the other parts of the test fail...
Are there any requirements for the machine I am running my test on?
I'm not aware of any specific requirements for this test. How are you running the test? Have you remembered to build the other tools in LLVM that it uses? (yaml2obj, llvm-objdump, FileCheck?). What is the output you get when you run the test?
Jan 20 2020
Thanks for the patch!
It looks like you haven't run the tests. Please make sure to run the check-all target, to run all the tests. In particular, I expect to see many tests that will fail, because they do not expect the extra line for the headers. Also, please make sure to update the llvm/test/tools/llvm-objdump/elf-relocations.test to check this works. You will need to add a 32-bit test case probably, to show that the 16 versus 8 space padding decision is made correctly. If you need help writing these tests, please let me know, and I'll be happy to help out.