Page MenuHomePhabricator
Feed Advanced Search

Yesterday

arichardson updated the diff for D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
  • Use !s.isFunc() && s.type != STT_NOTYPE
  • Update test case
Tue, Nov 19, 9:01 AM · Restricted Project
arichardson added a child revision for D70428: [UptestTestChecks][NFC] Share some common command line options code: D70432: [UpdateTestChecks] Share the code to parse RUN: lines between all scripts.
Tue, Nov 19, 4:28 AM · Restricted Project
arichardson created D70432: [UpdateTestChecks] Share the code to parse RUN: lines between all scripts.
Tue, Nov 19, 4:28 AM · Restricted Project
arichardson added inline comments to D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
Tue, Nov 19, 4:04 AM · Restricted Project
arichardson abandoned D70362: Fix fatal linker error on R_MIPS_JALR against a local TLS symbol.

No longer required after integrating test into D70406

Tue, Nov 19, 4:04 AM · Restricted Project
arichardson created D70429: [update_cc_test_checks.py] Add the --function-signature flag.
Tue, Nov 19, 3:18 AM · Restricted Project
arichardson created D70428: [UptestTestChecks][NFC] Share some common command line options code.
Tue, Nov 19, 3:18 AM · Restricted Project

Mon, Nov 18

arichardson added a comment to D70362: Fix fatal linker error on R_MIPS_JALR against a local TLS symbol.

This change is no longer necessary after https://reviews.llvm.org/D70406. I wonder if the testcase is still useful?

Mon, Nov 18, 10:14 AM · Restricted Project
arichardson created D70406: Ignore R_MIPS_JALR relocations against non-function symbols.
Mon, Nov 18, 10:14 AM · Restricted Project
arichardson created D70389: [update_cc_test_checks.py] Handle extern "C" and namespaces.
Mon, Nov 18, 4:17 AM · Restricted Project

Sun, Nov 17

arichardson updated the diff for D70362: Fix fatal linker error on R_MIPS_JALR against a local TLS symbol.

Add .set noreorder to avoid excessive nops and make test more readable

Sun, Nov 17, 11:32 AM · Restricted Project
arichardson updated the diff for D70362: Fix fatal linker error on R_MIPS_JALR against a local TLS symbol.

Check objdump output

Sun, Nov 17, 11:32 AM · Restricted Project
arichardson created D70362: Fix fatal linker error on R_MIPS_JALR against a local TLS symbol.
Sun, Nov 17, 11:17 AM · Restricted Project
arichardson added inline comments to D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Sun, Nov 17, 9:40 AM · Restricted Project

Fri, Nov 15

arichardson added inline comments to D67631: Add AutoUpgrade function to add new address space datalayout string to existing datalayouts..
Fri, Nov 15, 5:44 PM · Restricted Project
arichardson added a comment to D69564: Include the mangled name in -ast-dump=json.

@arphaman Should be fixed by rG09c7e51283dafbfd122cc0d7ab251476c451c9f5

Fri, Nov 15, 12:28 PM · Restricted Project

Thu, Nov 14

arichardson added inline comments to D70119: Improve gen_ast_dump_json_test.py.
Thu, Nov 14, 3:22 PM · Restricted Project

Tue, Nov 12

arichardson created D70119: Improve gen_ast_dump_json_test.py.
Tue, Nov 12, 4:16 AM · Restricted Project
arichardson added a comment to D69564: Include the mangled name in -ast-dump=json.

I've split out the update script changes into D70119 to make this easier to review

Tue, Nov 12, 4:16 AM · Restricted Project

Wed, Nov 6

arichardson added a comment to D69564: Include the mangled name in -ast-dump=json.

Ping. Does this seem an acceptable change to the JSON output @aaron.ballman ?

Wed, Nov 6, 3:44 AM · Restricted Project

Sun, Nov 3

arichardson added inline comments to D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Sun, Nov 3, 2:45 PM · Restricted Project, Restricted Project
arichardson added inline comments to D69765: [compiler-rt] Support more CPUs in LSan Allocator Address Space.
Sun, Nov 3, 8:49 AM · Restricted Project, Restricted Project

Fri, Nov 1

arichardson added a comment to D69701: [Utils] Allow "on-the-fly" argument changes for update_test_check scripts.

This seems useful, thanks! Another case that would be nice is if there was a way to keep comments inside the autogenerated CHECK lines.

Fri, Nov 1, 2:13 AM · Restricted Project

Thu, Oct 31

arichardson updated the summary of D69611: [update_cc_test_checks.py] Pass the builtin include dir to clang.
Thu, Oct 31, 4:49 AM · Restricted Project
arichardson added inline comments to D69610: Fix compiler-rt build on macOS without XCode.
Thu, Oct 31, 4:49 AM · Restricted Project, Restricted Project
arichardson created D69659: [compiler-rt] Use xcrun instead of xcodebuild to find the SDK directory.
Thu, Oct 31, 4:49 AM · Restricted Project, Restricted Project
arichardson updated the diff for D69610: Fix compiler-rt build on macOS without XCode.

Use xcrun instead of xcodebuild

Thu, Oct 31, 4:39 AM · Restricted Project, Restricted Project
arichardson added a comment to D69610: Fix compiler-rt build on macOS without XCode.

As I don't have XCode installed, it would be great if someone who does can confirm that this still works as expected.

Thu, Oct 31, 4:39 AM · Restricted Project, Restricted Project
arichardson updated the summary of D69564: Include the mangled name in -ast-dump=json.
Thu, Oct 31, 4:21 AM · Restricted Project
arichardson updated the diff for D69611: [update_cc_test_checks.py] Pass the builtin include dir to clang.

Improve commit message

Thu, Oct 31, 4:21 AM · Restricted Project
arichardson updated the summary of D69564: Include the mangled name in -ast-dump=json.
Thu, Oct 31, 4:21 AM · Restricted Project
arichardson added a comment to D68819: [Utils] Allow update_test_checks to check function arguments.

It also seems to break update_cc_test_checks.py

Thu, Oct 31, 4:21 AM · Restricted Project

Wed, Oct 30

arichardson added a comment to D69611: [update_cc_test_checks.py] Pass the builtin include dir to clang.

This makes sense, but can you add a comment in Phabricator, or if it is short, add it to the git description? It helps understanding for posterity.

Wed, Oct 30, 10:54 AM · Restricted Project
arichardson created D69611: [update_cc_test_checks.py] Pass the builtin include dir to clang.
Wed, Oct 30, 2:12 AM · Restricted Project
arichardson created D69610: Fix compiler-rt build on macOS without XCode.
Wed, Oct 30, 2:03 AM · Restricted Project, Restricted Project
arichardson added a comment to D68292: [CMake] Disable building all Darwin libraries (except builtins) for macOS i386 when the SDK is >= 10.15..

This breaks the build for me. I don't have XCode installed. Can we get the same information using xcrun instead?

Wed, Oct 30, 2:03 AM · Restricted Project, Restricted Project
arichardson added inline comments to D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.
Wed, Oct 30, 1:53 AM · Restricted Project
arichardson updated the diff for D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.

Use python 3.5 unpacking syntax

Wed, Oct 30, 1:53 AM · Restricted Project
arichardson added inline comments to D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.
Wed, Oct 30, 1:44 AM · Restricted Project
arichardson updated the diff for D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.

Address comments

Wed, Oct 30, 1:44 AM · Restricted Project

Tue, Oct 29

arichardson updated the diff for D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.

Address review commments

Tue, Oct 29, 10:07 AM · Restricted Project
arichardson added a parent revision for D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name: D69564: Include the mangled name in -ast-dump=json.
Tue, Oct 29, 7:51 AM · Restricted Project
arichardson added a child revision for D69564: Include the mangled name in -ast-dump=json: D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.
Tue, Oct 29, 7:51 AM · Restricted Project
arichardson created D69565: [update_cc_test_checks.py] Use -ast-dump=json to get mangled name.
Tue, Oct 29, 7:48 AM · Restricted Project
arichardson created D69564: Include the mangled name in -ast-dump=json.
Tue, Oct 29, 6:55 AM · Restricted Project

Oct 9 2019

arichardson added a comment to D68146: [FileCheck] Implement --ignore-case option..

LGTM

Oct 9 2019, 6:42 AM · Restricted Project

Oct 7 2019

arichardson added a comment to D68542: [Mips] Always save RA when disabling frame pointer elimination.

I don't think you can have frame-pointer based stack unwinding under current Mips ABIs, albeit this might be useful for some stack scan based unwind. Not sure tho.

You can most of the time, you just have to scan backwards to find the function prologue. Yes, it can break, but unless you have full DWARF info you can't do much better. Both FreeBSD (sys/mips/mips/db_trace.c) and Linux (arch/mips/kernel/process.c) do instruction-based unwinding on MIPS to get a good-enough backtrace on panic, so without this they can end up terminating the backtrace early. In particular, if you want a specific instance of the issue that motivated this patch, on FreeBSD, they have a panic which calls vpanic (much like printf vs vprintf), but due to being marked noreturn, $ra is dead and thus being clobbered by the call doesn't force a save like normal, so *every* panic ends up with a useless backtrace terminating at panic.

Oct 7 2019, 10:09 AM · Restricted Project

Oct 1 2019

arichardson added a comment to D68275: [libcxx] [test] Query the target platform, not the host one.

Looks good to me but I'm not sure about the PATH changes.

Oct 1 2019, 11:51 AM · Restricted Project

Sep 30 2019

arichardson added inline comments to D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
Sep 30 2019, 11:18 AM · Restricted Project, Restricted Project
arichardson added inline comments to D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned).
Sep 30 2019, 6:41 AM · Restricted Project, Restricted Project

Sep 18 2019

Herald added a project to D49091: Warn about usage of __has_include/__has_include_next in macro expansions: Restricted Project.

Ping? I'm not sure if this is still required now that D63508 has been committed?

Sep 18 2019, 2:21 PM · Restricted Project
arichardson accepted D66795: [Mips] Use appropriate private label prefix based on Mips ABI.

Looks good to me but I guess someone else should give the final approval.

Sep 18 2019, 10:49 AM · Restricted Project, Restricted Project, Restricted Project

Sep 17 2019

arichardson added inline comments to D67649: [FileCheck] Move private interface to its own header.
Sep 17 2019, 2:16 AM · Restricted Project

Sep 3 2019

arichardson committed rL370820: Fix error in last commit.
Fix error in last commit
Sep 3 2019, 2:02 PM
arichardson committed rL370819: Request commit access for arichardson.
Request commit access for arichardson
Sep 3 2019, 1:57 PM

Aug 28 2019

arichardson committed rG83d2f0e7993a: Further relax checks in asan-symbolize-bad-path.cpp (authored by arichardson).
Further relax checks in asan-symbolize-bad-path.cpp
Aug 28 2019, 11:38 AM
arichardson committed rL370243: Further relax checks in asan-symbolize-bad-path.cpp.
Further relax checks in asan-symbolize-bad-path.cpp
Aug 28 2019, 11:37 AM

Aug 27 2019

arichardson added a comment to D66141: [FileCheck] Forbid using var defined on same line.

LGTM except for one minor issue.

Hi Alexander,

Was your intention to approve the patch or did you intentionally leave it to others to approve?

Best regards.

Aug 27 2019, 2:20 PM · Restricted Project
arichardson committed rL370110: Fix asan-symbolize-bad-path.cpp on Darwin.
Fix asan-symbolize-bad-path.cpp on Darwin
Aug 27 2019, 2:19 PM
arichardson committed rG79f3459deb70: Fix asan-symbolize-bad-path.cpp on Darwin (authored by arichardson).
Fix asan-symbolize-bad-path.cpp on Darwin
Aug 27 2019, 2:14 PM
arichardson added a comment to D66795: [Mips] Use appropriate private label prefix based on Mips ABI.

Would it be possible to require a const MCTargetOptions &Options when creating MCAsmInfo?
If MCTargetOptions isn't always available, how about passing an Optional<MCTargetOptions> to MCAsmInfo? That would be equivalent to the current approach but make it harder to forget calling adjustPrefixes()

That would look something like this https://reviews.llvm.org/differential/diff/217420/ . I've already tested this solution earlier (except using Optional<>) but decided against it because of changes to MCAsmInfo for every target. Yes, the advantage is that it would be harder to forget about 'adjustPrefixes()' vs some more changes in code. Let me know which way you prefer.

Aug 27 2019, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
arichardson added a comment to D66795: [Mips] Use appropriate private label prefix based on Mips ABI.
  • adjustPrefixes() is not called after every call of createMCAsmInfo(), only where MCTargetOptions is available since this is what tells us if ABI is given as argument.
  • StringRef CPU could be removed from adjustPrefixes() since MipsABIInfo::computeTargetABI() does not use it in it's implementation and an empty string could be passed. We could remove Triple as well and use MCTargetOptions.ABIName only and read it manualy, but this way we would keep it consistent with other uses of MipsABIInfo.
Aug 27 2019, 4:39 AM · Restricted Project, Restricted Project, Restricted Project
arichardson committed rL370025: [asan_symbolize] Fix broken pipe handling for python 2.7.
[asan_symbolize] Fix broken pipe handling for python 2.7
Aug 27 2019, 12:36 AM
arichardson committed rG677c6ddd33da: [asan_symbolize] Fix broken pipe handling for python 2.7 (authored by arichardson).
[asan_symbolize] Fix broken pipe handling for python 2.7
Aug 27 2019, 12:31 AM
arichardson abandoned D42748: [ELF] Don't create a .dynamic section when linking with -Bstatic.

FreeBSD libc should be fixed instead.

Aug 27 2019, 12:27 AM · Restricted Project
arichardson added a comment to D65322: [asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line.

I believe I fixed this problem in https://reviews.llvm.org/rL369929

It seems like address %t+0x0 is valid on that builder. Maybe it defaults to -pie. Should be fixable by using an address that is more likely to be invalid.

But it's still a problem in python code which is not going to work on on python 2.7

Aug 27 2019, 12:05 AM · Restricted Project, Restricted Project
arichardson committed rL370021: Relax test introduced in D65322.
Relax test introduced in D65322
Aug 27 2019, 12:03 AM
arichardson committed rG23a12fc3ac4b: Relax test introduced in D65322 (authored by arichardson).
Relax test introduced in D65322
Aug 27 2019, 12:02 AM

Aug 26 2019

arichardson added a comment to D65322: [asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line.

I believe I fixed this problem in https://reviews.llvm.org/rL369929

Aug 26 2019, 11:42 PM · Restricted Project, Restricted Project
arichardson committed rL369929: [asan_symbolize] Attempt to fix build-bot failure after latest change.
[asan_symbolize] Attempt to fix build-bot failure after latest change
Aug 26 2019, 2:13 PM
arichardson committed rG2511b5a4638a: [asan_symbolize] Attempt to fix build-bot failure after latest change (authored by arichardson).
[asan_symbolize] Attempt to fix build-bot failure after latest change
Aug 26 2019, 10:23 AM
arichardson committed rL369924: [asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line.
[asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line
Aug 26 2019, 9:33 AM
arichardson committed rGe320db434ed1: [asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line (authored by arichardson).
[asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line
Aug 26 2019, 9:30 AM
arichardson closed D65322: [asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line.
Aug 26 2019, 9:26 AM · Restricted Project, Restricted Project

Aug 23 2019

arichardson accepted D66640: [FileCheck] Make NumericVariable ctor explicit.
Aug 23 2019, 8:21 AM · Restricted Project

Aug 22 2019

arichardson added a comment to D65322: [asan_symbolize] Avoid blocking when llvm-symbolizer is installed as addr2line.

Ping? This breaks unit test when building with -DLLVM_INSTALL_BINUTILS_SYMLINKS=ON

Aug 22 2019, 3:33 PM · Restricted Project, Restricted Project
arichardson added a comment to D66141: [FileCheck] Forbid using var defined on same line.

LGTM except for one minor issue.

Aug 22 2019, 8:33 AM · Restricted Project

Aug 19 2019

arichardson added a comment to D66274: [ELF][Hexagon] Replace R_HEXAGON_GOT with R_GOTPLT.

Nice! Thank you for doing this.

The remaining bits of RelExpr are a scarce recourse now... R_RISCV_PC_INDIRECT == 61. @sidneym Do you need more than 3 bits?

It shouldn't be too hard to extend oneOf so that the function uses two words instead of one word as a bitmap, but yeah, we should first try to reduce the number of relocation types if possible.

Aug 19 2019, 2:17 AM · Restricted Project

Aug 9 2019

arichardson accepted D65772: Add support for FreeBSD's LD_32_LIBRARY_PATH.

LGTM. This reduces the check-asan-dynamic test failures from 209 to 50 if I also apply the -pthread patch.

Aug 9 2019, 9:06 AM · Restricted Project, Restricted Project

Aug 6 2019

arichardson committed rG0b168ffdc3ff: [TSAN] Fix tsan on FreeBSD after D54889 (authored by arichardson).
[TSAN] Fix tsan on FreeBSD after D54889
Aug 6 2019, 3:31 PM
arichardson committed rL368103: [TSAN] Fix tsan on FreeBSD after D54889.
[TSAN] Fix tsan on FreeBSD after D54889
Aug 6 2019, 3:31 PM
arichardson closed D65705: [TSAN] Fix tsan on FreeBSD after D54889.
Aug 6 2019, 3:30 PM · Restricted Project, Restricted Project

Aug 3 2019

arichardson created D65705: [TSAN] Fix tsan on FreeBSD after D54889.
Aug 3 2019, 3:02 PM · Restricted Project, Restricted Project

Jul 31 2019

arichardson committed rGa4ea27de9287: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD (authored by arichardson).
[Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD
Jul 31 2019, 9:33 AM
arichardson committed rL367442: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
[Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD
Jul 31 2019, 9:32 AM
arichardson closed D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 31 2019, 9:32 AM · Restricted Project, Restricted Project
arichardson updated the diff for D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Move the cast to dlsym() return value rather than the function pointer call

Jul 31 2019, 2:17 AM · Restricted Project, Restricted Project
arichardson updated the diff for D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Used decltype now. Should be a bit shorter than the using declaration.
I still need the casts, otherwise the build fails when building the i368 RTSanitizerCommon.i386.dir/sanitizer_linux.cc.o:

/exports/users/alr48/sources/upstream-llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:786:57: error: cannot initialize a parameter of type 'size_t *' (aka 'unsigned int *') with an lvalue of type '__sanitizer::uptr *' (aka 'unsigned long *')
Jul 31 2019, 1:16 AM · Restricted Project, Restricted Project

Jul 30 2019

arichardson added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 30 2019, 1:16 PM · Restricted Project, Restricted Project

Jul 29 2019

arichardson added a reviewer for D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD: Restricted Project.
Jul 29 2019, 7:36 AM · Restricted Project, Restricted Project

Jul 28 2019

arichardson updated the diff for D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Remove mention of FreeBSD from comment

Jul 28 2019, 3:07 AM · Restricted Project, Restricted Project
arichardson updated the diff for D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

git-clang-format

Jul 28 2019, 3:06 AM · Restricted Project, Restricted Project

Jul 27 2019

arichardson committed rG51bfb84852e5: [compiler-rt] Fix running tests on macOS when XCode is not installed (authored by arichardson).
[compiler-rt] Fix running tests on macOS when XCode is not installed
Jul 27 2019, 5:33 AM
arichardson committed rL367170: [compiler-rt] Fix running tests on macOS when XCode is not installed.
[compiler-rt] Fix running tests on macOS when XCode is not installed
Jul 27 2019, 5:32 AM
arichardson closed D65323: [compiler-rt] Fix running tests on macOS when XCode is not installed.
Jul 27 2019, 5:32 AM · Restricted Project, Restricted Project

Jul 26 2019

arichardson retitled D65323: [compiler-rt] Fix running tests on macOS when XCode is not installed from If XCode is not installed, `xcodebuild -version -sdk macosx Path` will give xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance In this case... to [compiler-rt] Fix running tests on macOS when XCode is not installed.
Jul 26 2019, 12:52 PM · Restricted Project, Restricted Project
arichardson updated the diff for D65323: [compiler-rt] Fix running tests on macOS when XCode is not installed.

Always use xcrun

Jul 26 2019, 12:52 PM · Restricted Project, Restricted Project
arichardson updated the diff for D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Use the more portable dlsym() instead of dlfunc()

Jul 26 2019, 12:44 PM · Restricted Project, Restricted Project
arichardson added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 26 2019, 3:21 AM · Restricted Project, Restricted Project
arichardson added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 26 2019, 3:17 AM · Restricted Project, Restricted Project