Page MenuHomePhabricator
Feed Advanced Search

Yesterday

paulsemel retitled D63671: [llvm-profdata] Avoid keeping reference to every files from [llvm-profdata] [NFC] Avoir keeping reference to every files to [llvm-profdata] Avoid keeping reference to every files.
Mon, Jun 24, 4:32 PM · Restricted Project
paulsemel updated the diff for D63671: [llvm-profdata] Avoid keeping reference to every files.

Add comment to describe why we need this string table
Add one test case.

Mon, Jun 24, 4:07 PM · Restricted Project
paulsemel added a comment to D63671: [llvm-profdata] Avoid keeping reference to every files.
In D63671#1554457, @wmi wrote:

We had better have a test for it. It is not a strict NFC and we best verify it works as we expect -- like if we miss any place which still uses StringRef refering to string in file data buffer, we may have dangling pointer after we free the buffer.

Mon, Jun 24, 4:05 PM · Restricted Project

Fri, Jun 21

paulsemel created D63671: [llvm-profdata] Avoid keeping reference to every files.
Fri, Jun 21, 2:06 PM · Restricted Project

Apr 3 2019

paulsemel committed rG0c27bc2e1fe3: [DWARF] check whether the DIE is valid before querying for information (authored by paulsemel).
[DWARF] check whether the DIE is valid before querying for information
Apr 3 2019, 10:12 AM
paulsemel committed rL357607: [DWARF] check whether the DIE is valid before querying for information.
[DWARF] check whether the DIE is valid before querying for information
Apr 3 2019, 10:12 AM
paulsemel closed D60147: [DWARF] check whether the DIE is valid before querying for information.
Apr 3 2019, 10:12 AM · Restricted Project

Apr 2 2019

paulsemel added inline comments to D60147: [DWARF] check whether the DIE is valid before querying for information.
Apr 2 2019, 5:24 PM · Restricted Project
paulsemel updated the diff for D60147: [DWARF] check whether the DIE is valid before querying for information.

Add comment describing the bug.

Apr 2 2019, 5:21 PM · Restricted Project
paulsemel updated the diff for D60147: [DWARF] check whether the DIE is valid before querying for information.

Add correct output of llvm-dwarfdump

Apr 2 2019, 4:28 PM · Restricted Project
paulsemel updated the diff for D60147: [DWARF] check whether the DIE is valid before querying for information.

Add test case.

Apr 2 2019, 2:46 PM · Restricted Project
paulsemel added reviewers for D60147: [DWARF] check whether the DIE is valid before querying for information: dblaikie, JDevlieghere.
Apr 2 2019, 12:58 PM · Restricted Project
paulsemel created D60147: [DWARF] check whether the DIE is valid before querying for information.
Apr 2 2019, 12:55 PM · Restricted Project

Aug 9 2018

paulsemel added a comment to D50463: [llvm-objcopy] Add --prefix-sections option.

I've got some comments that I'll send through a bit later today, but as things stand, this doesn't match GNU objcopy's behaviour for relocation sections at the very least - the "prefix" is placed between the end of ".rela" and the start of the section name so that they have the name ".rela<prefixed relocated section name>"

Aug 9 2018, 12:21 PM
paulsemel committed rL339362: [llvm-objcopy] Add --prefix-symbols option.
[llvm-objcopy] Add --prefix-symbols option
Aug 9 2018, 10:49 AM
paulsemel closed D50381: [llvm-objcopy] Add --prefix-symbols option.
Aug 9 2018, 10:49 AM
paulsemel committed rL339358: [llvm-objcopy] Add --dump-section.
[llvm-objcopy] Add --dump-section
Aug 9 2018, 10:06 AM
paulsemel closed D49979: [llvm-objcopy] Add --dump-section.
Aug 9 2018, 10:06 AM

Aug 8 2018

paulsemel created D50463: [llvm-objcopy] Add --prefix-sections option.
Aug 8 2018, 10:23 AM
paulsemel updated the diff for D50381: [llvm-objcopy] Add --prefix-symbols option.

Give ownership of Symbols names to symbol itself.

Aug 8 2018, 9:32 AM

Aug 7 2018

paulsemel updated the diff for D50381: [llvm-objcopy] Add --prefix-symbols option.

Changed option name (to start -> to the start)

Aug 7 2018, 9:27 AM
paulsemel added inline comments to D50381: [llvm-objcopy] Add --prefix-symbols option.
Aug 7 2018, 9:27 AM
paulsemel added inline comments to D50381: [llvm-objcopy] Add --prefix-symbols option.
Aug 7 2018, 4:43 AM
paulsemel created D50381: [llvm-objcopy] Add --prefix-symbols option.
Aug 7 2018, 4:41 AM
paulsemel added a comment to D49979: [llvm-objcopy] Add --dump-section.

ping @jakehehrlich

Aug 7 2018, 4:08 AM

Aug 6 2018

paulsemel updated the diff for D49979: [llvm-objcopy] Add --dump-section.

Added Jame's suggestions

Aug 6 2018, 10:52 AM

Aug 4 2018

paulsemel added a comment to D49979: [llvm-objcopy] Add --dump-section.

Should I land this guys ?

Aug 4 2018, 1:45 AM

Aug 3 2018

paulsemel added inline comments to D50204: [llvm-objdump] Label calls to the PLT.
Aug 3 2018, 1:21 PM
paulsemel added inline comments to D50204: [llvm-objdump] Label calls to the PLT.
Aug 3 2018, 10:30 AM
paulsemel updated the diff for D49979: [llvm-objcopy] Add --dump-section.

Added James suggested tests

Aug 3 2018, 9:14 AM
paulsemel added inline comments to D50203: Find PLT entries for x86, x86_64, and AArch64.
Aug 3 2018, 1:32 AM
paulsemel added inline comments to D50204: [llvm-objdump] Label calls to the PLT.
Aug 3 2018, 1:32 AM
paulsemel updated the diff for D49979: [llvm-objcopy] Add --dump-section.

Added Jake's suggestions.

Aug 3 2018, 1:11 AM

Aug 2 2018

paulsemel added a comment to D49979: [llvm-objcopy] Add --dump-section.

So should I go for it guys ?

Aug 2 2018, 9:23 AM

Aug 1 2018

paulsemel updated the diff for D49979: [llvm-objcopy] Add --dump-section.

Added OriginData field as suggested by Jake

Aug 1 2018, 2:41 AM

Jul 31 2018

paulsemel updated the diff for D49979: [llvm-objcopy] Add --dump-section.

Added Jake and James' suggestions

Jul 31 2018, 3:36 AM
paulsemel added inline comments to D49979: [llvm-objcopy] Add --dump-section.
Jul 31 2018, 3:35 AM

Jul 30 2018

paulsemel added a comment to D49979: [llvm-objcopy] Add --dump-section.

I know that there is this only-keep option that is supposed to be able to have similar behavior but :

  • It doesn't work at all (segfault). I made it work only with the dump-section.test, otherwise with real binaries it segfault.
  • This one is compliant with GNU binutils command line, and is not file format dependent. (even tho llvm-objcopy only handles ELF for the moment)
Jul 30 2018, 5:14 AM
paulsemel created D49979: [llvm-objcopy] Add --dump-section.
Jul 30 2018, 5:12 AM

Jul 25 2018

paulsemel committed rL337902: [llvm-objdump] Add dynamic section printing to private-headers option.
[llvm-objdump] Add dynamic section printing to private-headers option
Jul 25 2018, 4:09 AM
paulsemel closed D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 25 2018, 4:09 AM
paulsemel committed rL337896: [llvm-readobj] Generic hex-dump option.
[llvm-readobj] Generic hex-dump option
Jul 25 2018, 3:05 AM
paulsemel closed D49545: [llvm-readobj] Generic hex-dump option.
Jul 25 2018, 3:05 AM

Jul 24 2018

paulsemel updated the diff for D49545: [llvm-readobj] Generic hex-dump option.

Added a WAsm test

Jul 24 2018, 12:04 PM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 24 2018, 3:07 AM

Jul 23 2018

paulsemel committed rL337725: [yaml2obj] Add default sh_entsize for dynamic sections.
[yaml2obj] Add default sh_entsize for dynamic sections
Jul 23 2018, 11:49 AM
paulsemel closed D49619: [yaml2obj] Add default sh_entsize for dynamic sections.
Jul 23 2018, 11:49 AM
paulsemel added inline comments to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 23 2018, 11:18 AM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Added Jame's suggestions.

Jul 23 2018, 11:17 AM
paulsemel added a reviewer for D49619: [yaml2obj] Add default sh_entsize for dynamic sections: ruiu.
Jul 23 2018, 9:40 AM
paulsemel added a comment to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

I haven't copied the whole thing, most of the code is from me actually.. Why can't I just land this one and refactor the other one right after ?
I'm not sure this is that much a big deal to do this way, is it ?

Jul 23 2018, 9:18 AM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Added Jame's suggestions

Jul 23 2018, 9:18 AM

Jul 20 2018

paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Added Jame's suggestions.
I managed to do one of the two real test cases with only yaml2obj. The first one definitely needs too much things to be a yaml2obj test.

Jul 20 2018, 3:33 PM
paulsemel added a comment to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Ok, I think the way I'm now getting the dynamic string table is good !

Jul 20 2018, 3:33 PM
paulsemel created D49619: [yaml2obj] Add default sh_entsize for dynamic sections.
Jul 20 2018, 3:05 PM
paulsemel added inline comments to D49545: [llvm-readobj] Generic hex-dump option.
Jul 20 2018, 1:37 PM
paulsemel updated the summary of D49545: [llvm-readobj] Generic hex-dump option.
Jul 20 2018, 1:03 PM
paulsemel updated the diff for D49545: [llvm-readobj] Generic hex-dump option.

Fixed the behavior between ELF and other file formats.

Jul 20 2018, 1:02 PM

Jul 19 2018

paulsemel created D49545: [llvm-readobj] Generic hex-dump option.
Jul 19 2018, 7:26 AM

Jul 18 2018

paulsemel closed D49402: [STLExtras] Add size() for arrays.

I agree with James !

Jul 18 2018, 11:24 AM
paulsemel committed rL337408: [llvm-readobj] Generic -string-dump option.
[llvm-readobj] Generic -string-dump option
Jul 18 2018, 11:06 AM
paulsemel closed D49470: [llvm-readobj] Generic -string-dump option.
Jul 18 2018, 11:06 AM
paulsemel committed rL337401: [llvm-objdump] Add -demangle (-C) option.
[llvm-objdump] Add -demangle (-C) option
Jul 18 2018, 9:44 AM
paulsemel closed D49043: [llvm-objdump] Add -demangle (-C) option.
Jul 18 2018, 9:44 AM
paulsemel updated the diff for D49043: [llvm-objdump] Add -demangle (-C) option.

Move test to X86 folder to make it x86 specific

Jul 18 2018, 9:10 AM
paulsemel added a comment to D49043: [llvm-objdump] Add -demangle (-C) option.

Ok, I think I actually have to move this test to the X86 folder, but I don't need this REQUIRES thing.

Jul 18 2018, 9:06 AM
paulsemel closed D48271: [llvm-readobj] Fix printing format.

Closed due to to duplicate

Jul 18 2018, 3:32 AM
paulsemel created D49470: [llvm-readobj] Generic -string-dump option.
Jul 18 2018, 3:31 AM

Jul 17 2018

paulsemel added a comment to D49402: [STLExtras] Add size() for arrays.

This appears to be identical to llvm::array_lengthof; do you plan to deprecate that function?

Jul 17 2018, 1:11 PM
paulsemel added inline comments to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 17 2018, 7:17 AM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Alright.. Again, there was a lot of changes I wanted to do, so sorry if I messed smth @jhenderson.
I eventually moved some code from llvm-readobj to libObject, and I will refactor llvm-readobj similar code in another PR !

Jul 17 2018, 7:14 AM
paulsemel added inline comments to D49402: [STLExtras] Add size() for arrays.
Jul 17 2018, 5:10 AM
paulsemel updated the diff for D49402: [STLExtras] Add size() for arrays.

Added Jame's suggestions

Jul 17 2018, 3:23 AM

Jul 16 2018

paulsemel created D49402: [STLExtras] Add size() for arrays.
Jul 16 2018, 2:10 PM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Added Jame's suggestions.

Jul 16 2018, 1:19 PM
paulsemel added inline comments to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 16 2018, 1:19 PM
paulsemel added inline comments to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 16 2018, 1:18 PM
paulsemel added a comment to D49043: [llvm-objdump] Add -demangle (-C) option.

LGTM, with the caveat that I don't know for certain if that was the original issue, without looking at the failing job and what was going on.

If you need to make minor changes to get the build bots working, no need for further review from my point of view.

Jul 16 2018, 3:31 AM
paulsemel updated the diff for D49043: [llvm-objdump] Add -demangle (-C) option.

Added Jame's suggestions

Jul 16 2018, 2:30 AM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Added Jame's suggestions

Jul 16 2018, 2:05 AM
paulsemel added a comment to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Little follow-up. I'm pretty sure it would require changes to yaml2obj to get this test written in yaml format.
Why not creating my own binary for the moment, and wait for someone (me if I have time ?) to implement this feature ?

Jul 16 2018, 2:05 AM

Jul 13 2018

paulsemel added a comment to D49043: [llvm-objdump] Add -demangle (-C) option.

The buildbots were not passing. Again it seemed to be because of the disassembling option on other architectures (arm etc..).
If someone have any insight about what to do to test this disassembling option, I'll be glad :)

Is the problem as simple as adding a "REQUIRES: x86" to the test? Do the arm build bots etc have x86 target support?

Jul 13 2018, 5:52 AM
paulsemel added a comment to D49043: [llvm-objdump] Add -demangle (-C) option.

ping @davide @jhenderson

Jul 13 2018, 12:25 AM
paulsemel reopened D49043: [llvm-objdump] Add -demangle (-C) option.

The buildbots were not passing. Again it seemed to be because of the disassembling option on other architectures (arm etc..).
If someone have any insight about what to do to test this disassembling option, I'll be glad :)

Jul 13 2018, 12:24 AM

Jul 11 2018

paulsemel committed rL336829: Revert "[llvm-objdump] Add -demangle (-C) option".
Revert "[llvm-objdump] Add -demangle (-C) option"
Jul 11 2018, 11:15 AM
paulsemel committed rL336821: Fix llvm-objdump demangle test (added triple option).
Fix llvm-objdump demangle test (added triple option)
Jul 11 2018, 9:36 AM
paulsemel committed rL336816: [llvm-objdump] Add -demangle (-C) option.
[llvm-objdump] Add -demangle (-C) option
Jul 11 2018, 8:30 AM
paulsemel closed D49043: [llvm-objdump] Add -demangle (-C) option.
Jul 11 2018, 8:30 AM
paulsemel committed rL336782: [llvm-readobj] Add -hex-dump (-x) option.
[llvm-readobj] Add -hex-dump (-x) option
Jul 11 2018, 3:05 AM
paulsemel closed D48281: [llvm-readobj] Add -hex-dump (-x) option.
Jul 11 2018, 3:05 AM
paulsemel added a comment to D48281: [llvm-readobj] Add -hex-dump (-x) option.

Ok I'm going to land this one, so that I can refactor the (-p) option, with the helpers created in this patch !

Jul 11 2018, 2:59 AM
paulsemel added inline comments to D49043: [llvm-objdump] Add -demangle (-C) option.
Jul 11 2018, 1:49 AM
paulsemel added inline comments to D48271: [llvm-readobj] Fix printing format.
Jul 11 2018, 1:36 AM
paulsemel added inline comments to D49016: [llvm-objdump] Add dynamic section printing to private-headers option.
Jul 11 2018, 1:30 AM
paulsemel updated the diff for D49016: [llvm-objdump] Add dynamic section printing to private-headers option.

Added Jame's suggestions. Refactor code.

Jul 11 2018, 1:30 AM
paulsemel added a comment to D49043: [llvm-objdump] Add -demangle (-C) option.

ping @davide

Jul 11 2018, 12:58 AM

Jul 10 2018

paulsemel added inline comments to D49043: [llvm-objdump] Add -demangle (-C) option.
Jul 10 2018, 2:46 PM
paulsemel updated the diff for D49043: [llvm-objdump] Add -demangle (-C) option.

Added Jame's suggestions

Jul 10 2018, 2:45 PM
paulsemel updated the diff for D48271: [llvm-readobj] Fix printing format.

Rebased the failing version.

Jul 10 2018, 10:35 AM
paulsemel updated the diff for D49043: [llvm-objdump] Add -demangle (-C) option.

Added "warning" to the test to ensure this is printed as a warning.

Jul 10 2018, 7:06 AM