Page MenuHomePhabricator
Feed Advanced Search

Oct 26 2018

kongyi closed D53742: [XRay] Use std::errc::invalid_argument instead of std::errc::bad_message.
Oct 26 2018, 11:28 AM

Oct 25 2018

kongyi created D53742: [XRay] Use std::errc::invalid_argument instead of std::errc::bad_message.
Oct 25 2018, 6:27 PM

Sep 19 2018

kongyi committed rCRT342608: [builtins] Add __emutls_unregister_key function.
[builtins] Add __emutls_unregister_key function
Sep 19 2018, 6:05 PM
kongyi committed rL342608: [builtins] Add __emutls_unregister_key function.
[builtins] Add __emutls_unregister_key function
Sep 19 2018, 6:05 PM
kongyi closed D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 6:05 PM
kongyi closed D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 6:05 PM
kongyi added inline comments to D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 4:38 PM
kongyi updated the diff for D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 4:37 PM
kongyi added inline comments to D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 3:01 PM
kongyi updated the diff for D52251: [builtins] Add __emutls_unregister_key function.
Sep 19 2018, 3:00 PM

Sep 18 2018

kongyi created D52251: [builtins] Add __emutls_unregister_key function.
Sep 18 2018, 3:23 PM

Jul 11 2018

kongyi committed rLLD336826: Also search BitcodeFiles for exclude-lib symbols.
Also search BitcodeFiles for exclude-lib symbols
Jul 11 2018, 10:50 AM
kongyi committed rL336826: Also search BitcodeFiles for exclude-lib symbols.
Also search BitcodeFiles for exclude-lib symbols
Jul 11 2018, 10:50 AM
kongyi closed D48857: Also search BitcodeFiles for exclude-lib symbols.
Jul 11 2018, 10:50 AM

Jul 10 2018

kongyi added a comment to D48857: Also search BitcodeFiles for exclude-lib symbols.

ping...

Jul 10 2018, 2:11 PM

Jul 5 2018

kongyi updated the diff for D48857: Also search BitcodeFiles for exclude-lib symbols.
Jul 5 2018, 4:20 PM

Jul 2 2018

kongyi updated the diff for D48857: Also search BitcodeFiles for exclude-lib symbols.
Jul 2 2018, 6:19 PM
kongyi added a reviewer for D48857: Also search BitcodeFiles for exclude-lib symbols: pcc.
Jul 2 2018, 4:40 PM
kongyi created D48857: Also search BitcodeFiles for exclude-lib symbols.
Jul 2 2018, 4:25 PM

Dec 28 2017

kongyi committed rCRT321543: Ignore the DISPATCH_NOESCAPE if not defined.
Ignore the DISPATCH_NOESCAPE if not defined
Dec 28 2017, 3:08 PM
kongyi committed rL321543: Ignore the DISPATCH_NOESCAPE if not defined.
Ignore the DISPATCH_NOESCAPE if not defined
Dec 28 2017, 3:07 PM
kongyi closed D41601: Ignore the DISPATCH_NOESCAPE if not defined.
Dec 28 2017, 3:07 PM
kongyi added a comment to D41601: Ignore the DISPATCH_NOESCAPE if not defined.

Thanks for fixing this.

Can you make this simpler by defining DISPATCH_NOESCAPE only when it hasn't been defined?

#ifndef DISPATCH_NOESCAPE
#define DISPATCH_NOESCAPE
#endif
Dec 28 2017, 2:15 PM
kongyi updated the diff for D41601: Ignore the DISPATCH_NOESCAPE if not defined.
Dec 28 2017, 2:15 PM

Dec 27 2017

kongyi added a reviewer for D41601: Ignore the DISPATCH_NOESCAPE if not defined: aaron.ballman.
Dec 27 2017, 3:54 PM
kongyi created D41601: Ignore the DISPATCH_NOESCAPE if not defined.
Dec 27 2017, 3:27 PM
kongyi abandoned D40590: [LibFuzzer] Allow fuzzer to be built standalone.
Dec 27 2017, 1:46 PM

Dec 14 2017

kongyi committed rL320753: [ThreadSafetyAnalysis] Fix isCapabilityExpr.
[ThreadSafetyAnalysis] Fix isCapabilityExpr
Dec 14 2017, 2:25 PM
kongyi committed rC320753: [ThreadSafetyAnalysis] Fix isCapabilityExpr.
[ThreadSafetyAnalysis] Fix isCapabilityExpr
Dec 14 2017, 2:25 PM
kongyi closed D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr.
Dec 14 2017, 2:25 PM · Restricted Project
kongyi added a comment to D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr.

Hi.
I don't want to hijack the thread, but is PR32954 likely unrelated to this fix, and the problem (if it is a bug) is likely elsewhere?

Dec 14 2017, 11:36 AM · Restricted Project
kongyi added reviewers for D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr: jmgao, pirama, srhines.
Dec 14 2017, 12:18 AM · Restricted Project
kongyi created D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr.
Dec 14 2017, 12:17 AM · Restricted Project

Nov 28 2017

kongyi committed rL319296: Revert change for LibFuzzer target archs.
Revert change for LibFuzzer target archs
Nov 28 2017, 11:03 PM
kongyi committed rL319288: [LibFuzzer] Add Android to LibFuzzer's supported OSes.
[LibFuzzer] Add Android to LibFuzzer's supported OSes
Nov 28 2017, 7:53 PM
kongyi closed D40592: [LibFuzzer] Add Android to LibFuzzer's supported OSes by committing rL319288: [LibFuzzer] Add Android to LibFuzzer's supported OSes.
Nov 28 2017, 7:53 PM
kongyi created D40592: [LibFuzzer] Add Android to LibFuzzer's supported OSes.
Nov 28 2017, 5:39 PM
kongyi created D40590: [LibFuzzer] Allow fuzzer to be built standalone.
Nov 28 2017, 5:15 PM

Nov 17 2017

kongyi accepted D40190: llvm-demangle-fuzzer: Link in Support.

LGTM, thanks for fixing this.

Nov 17 2017, 12:40 PM
kongyi added a comment to rL318409: [FuzzMutate] Fix windows build after rL318407..

My local clang build is failing after r318407 and r318409, can you please take a look?

I had the same problem and submitted D40190. Can you take a look if that also works for you?

Nov 17 2017, 12:36 PM

Nov 16 2017

kongyi added a comment to rL318409: [FuzzMutate] Fix windows build after rL318407..

My local clang build is failing after r318407 and r318409, can you please take a look?

Nov 16 2017, 7:06 PM
kongyi committed rL318472: [ARM] 't' asm constraint should accept i32.
[ARM] 't' asm constraint should accept i32
Nov 16 2017, 3:38 PM
kongyi closed D40137: [ARM] 't' asm constraint should accept i32 by committing rL318472: [ARM] 't' asm constraint should accept i32.
Nov 16 2017, 3:38 PM
kongyi updated the diff for D40137: [ARM] 't' asm constraint should accept i32.
Nov 16 2017, 2:57 PM
kongyi updated the diff for D40137: [ARM] 't' asm constraint should accept i32.
Nov 16 2017, 2:39 PM
kongyi added a comment to D40137: [ARM] 't' asm constraint should accept i32.

Is the T constraint only used for movs?

Nov 16 2017, 1:53 PM
kongyi created D40137: [ARM] 't' asm constraint should accept i32.
Nov 16 2017, 10:03 AM

Nov 10 2017

kongyi abandoned D39883: [sanitizer] Set cxx-abi library for ubsan_minimal.
Nov 10 2017, 5:23 PM
kongyi updated subscribers of D39883: [sanitizer] Set cxx-abi library for ubsan_minimal.
Nov 10 2017, 2:08 PM

Nov 9 2017

kongyi added a comment to D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support.
In D37993#893466, @pcc wrote:

Is it a good idea to support cache pruning in the gold plugin? As I mentioned in D31063 there are some unavoidable race conditions due to limitations in the plugin API.

Nov 9 2017, 7:16 PM
kongyi created D39883: [sanitizer] Set cxx-abi library for ubsan_minimal.
Nov 9 2017, 5:15 PM

Sep 25 2017

kongyi committed rL314124: [Sema] Null check in BuildDeclarationNameExpr.
[Sema] Null check in BuildDeclarationNameExpr
Sep 25 2017, 10:38 AM
kongyi closed D38158: [Sema] Null check in BuildDeclarationNameExpr by committing rL314124: [Sema] Null check in BuildDeclarationNameExpr.
Sep 25 2017, 10:38 AM · Restricted Project
kongyi added a comment to D38158: [Sema] Null check in BuildDeclarationNameExpr.

ping...

Sep 25 2017, 10:15 AM · Restricted Project
kongyi added a reviewer for D38158: [Sema] Null check in BuildDeclarationNameExpr: rjmccall.
Sep 25 2017, 5:02 AM · Restricted Project

Sep 21 2017

kongyi created D38158: [Sema] Null check in BuildDeclarationNameExpr.
Sep 21 2017, 3:13 PM · Restricted Project

Sep 18 2017

kongyi added inline comments to D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support.
Sep 18 2017, 5:24 PM
kongyi committed rL313592: [ThinLTO/gold] Implement ThinLTO cache pruning support.
[ThinLTO/gold] Implement ThinLTO cache pruning support
Sep 18 2017, 4:26 PM
kongyi added a comment to D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support.

LGTM

Sep 18 2017, 4:26 PM
kongyi closed D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support by committing rL313592: [ThinLTO/gold] Implement ThinLTO cache pruning support.
Sep 18 2017, 4:26 PM
kongyi committed rL313591: [Docs] Document cache pruning support for gold.
[Docs] Document cache pruning support for gold
Sep 18 2017, 4:25 PM
kongyi closed D37995: [Docs] Document cache pruning support for gold by committing rL313591: [Docs] Document cache pruning support for gold.
Sep 18 2017, 4:25 PM · Restricted Project
kongyi added a comment to D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support.

Thanks for working on adding this missing feature! Please add a test and include an update to the info on where cache pruning is supported in ThinLTO.rst (for examples of both, see https://reviews.llvm.org/D37607, where it was added to lld).

Sep 18 2017, 2:28 PM
kongyi updated the diff for D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support.

Tests added.

Sep 18 2017, 2:27 PM
kongyi created D37995: [Docs] Document cache pruning support for gold.
Sep 18 2017, 1:43 PM · Restricted Project
kongyi created D37993: [ThinLTO/gold] Implement ThinLTO cache pruning support.
Sep 18 2017, 12:52 PM

Jul 14 2017

kongyi committed rL308060: [AArch64] Avoid selecting XZR inline ASM memory operand.
[AArch64] Avoid selecting XZR inline ASM memory operand
Jul 14 2017, 2:46 PM
kongyi closed D34999: [AArch64] Avoid selecting XZR inline ASM memory operand by committing rL308060: [AArch64] Avoid selecting XZR inline ASM memory operand.
Jul 14 2017, 2:46 PM
kongyi added a comment to D34999: [AArch64] Avoid selecting XZR inline ASM memory operand.

Is this really the best place to solve this issue?

PowerPC has a similar problem (r0 can't be used for memory addresses); the PPC backend solves it in PPCDAGToDAGISel::SelectInlineAsmMemoryOperand.

For non-memory inline asm operands, SelectionDAGBuilder::visitInlineAsm has code to constrain the register classes.

Jul 14 2017, 2:08 PM
kongyi updated the diff for D34999: [AArch64] Avoid selecting XZR inline ASM memory operand.
Jul 14 2017, 2:07 PM

Jul 5 2017

kongyi created D34999: [AArch64] Avoid selecting XZR inline ASM memory operand.
Jul 5 2017, 1:23 AM

Jul 4 2017

kongyi abandoned D34368: [AArch64] PointerRegClass should be GPR64spRegClass.

Will combine the changes into a single patch.

Jul 4 2017, 6:58 PM

Jun 22 2017

kongyi updated the diff for D34368: [AArch64] PointerRegClass should be GPR64spRegClass.
Jun 22 2017, 5:07 PM

Jun 19 2017

kongyi added a comment to D34368: [AArch64] PointerRegClass should be GPR64spRegClass.

Testcase? (I think this affects inline asm.)

Jun 19 2017, 3:28 PM
kongyi added a reviewer for D34368: [AArch64] PointerRegClass should be GPR64spRegClass: mcrosier.
Jun 19 2017, 2:38 PM
kongyi created D34368: [AArch64] PointerRegClass should be GPR64spRegClass.
Jun 19 2017, 2:35 PM

Jun 13 2017

kongyi committed rL305315: Fix spurious Wunused-lambda-capture warning.
Fix spurious Wunused-lambda-capture warning
Jun 13 2017, 11:39 AM
kongyi closed D33526: Fix spurious Wunused-lambda-capture warning by committing rL305315: Fix spurious Wunused-lambda-capture warning.
Jun 13 2017, 11:39 AM
kongyi added a comment to D33526: Fix spurious Wunused-lambda-capture warning.

For normal captures, variables are safe to eliminate if they are non-ODR used or totally unused. However for init captures, non-ODR usage still depends on the capture; they are only safe to eliminate if totally unused.

Jun 13 2017, 3:53 AM

Jun 9 2017

kongyi updated the diff for D33526: Fix spurious Wunused-lambda-capture warning.
Jun 9 2017, 4:49 PM

May 26 2017

kongyi added inline comments to D33526: Fix spurious Wunused-lambda-capture warning.
May 26 2017, 4:45 PM

May 24 2017

kongyi added a reviewer for D33526: Fix spurious Wunused-lambda-capture warning: aaron.ballman.
May 24 2017, 5:22 PM
kongyi created D33526: Fix spurious Wunused-lambda-capture warning.
May 24 2017, 5:14 PM

Apr 17 2017

kongyi added a reviewer for D32076: [ARM] Add big.LITTLE mcpu tuning options: kristof.beyls.
Apr 17 2017, 11:43 AM

Apr 14 2017

kongyi added inline comments to D32076: [ARM] Add big.LITTLE mcpu tuning options.
Apr 14 2017, 11:24 AM
kongyi updated the diff for D32076: [ARM] Add big.LITTLE mcpu tuning options.

Added FeatureFPAO

Apr 14 2017, 11:22 AM
kongyi added a comment to D32076: [ARM] Add big.LITTLE mcpu tuning options.

arc merged these two changes together... Will commit them separately for ARM and Aarch64.

Apr 14 2017, 12:20 AM
kongyi created D32076: [ARM] Add big.LITTLE mcpu tuning options.
Apr 14 2017, 12:17 AM

Apr 11 2017

kongyi committed rL300003: Remove xgene1 from host detection.
Remove xgene1 from host detection
Apr 11 2017, 3:52 PM

Apr 6 2017

kongyi committed rL299724: Revert "Revert "[ARM] Add Kryo to available targets"".
Revert "Revert "[ARM] Add Kryo to available targets""
Apr 6 2017, 4:00 PM
kongyi added a comment to D31775: [ARM] Add Kryo to available targets.

I see the following failure in the bootstrap Clang build:

/usr/local/google/home/krasin/src/llvm.org/llvm/lib/Target/ARM/ARMSubtarget.cpp:244:11: error: enumeration value 'Kryo' not handled in switch [-Werror,-Wswitch]
  switch (ARMProcFamily) {

Looks like a bug to me.

Apr 6 2017, 1:54 PM
kongyi committed rL299689: Revert "[ARM] Add Kryo to available targets".
Revert "[ARM] Add Kryo to available targets"
Apr 6 2017, 12:29 PM
kongyi committed rL299674: [ARM] Add Kryo to available targets.
[ARM] Add Kryo to available targets
Apr 6 2017, 11:23 AM
kongyi closed D31775: [ARM] Add Kryo to available targets by committing rL299674: [ARM] Add Kryo to available targets.
Apr 6 2017, 11:22 AM
kongyi created D31775: [ARM] Add Kryo to available targets.
Apr 6 2017, 11:05 AM

Apr 4 2017

kongyi committed rL299458: Implement host CPU detection for AArch64.
Implement host CPU detection for AArch64
Apr 4 2017, 12:18 PM
kongyi closed D31675: Implement host CPU detection for AArch64 by committing rL299458: Implement host CPU detection for AArch64.
Apr 4 2017, 12:18 PM
kongyi updated the diff for D31675: Implement host CPU detection for AArch64.
Apr 4 2017, 12:03 PM
kongyi created D31675: Implement host CPU detection for AArch64.
Apr 4 2017, 11:41 AM

Mar 21 2017

kongyi committed rL298379: Test commit access.
Test commit access
Mar 21 2017, 8:01 AM