Page MenuHomePhabricator
Feed Advanced Search

Dec 20 2018

danalbert created D55953: Android is not GNU, so don't claim that it is..
Dec 20 2018, 1:21 PM

Dec 18 2018

danalbert committed rC349570: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
[Driver] Also obey -nostdlib++ when rewriting -lstdc++.
Dec 18 2018, 3:33 PM
danalbert committed rL349570: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
[Driver] Also obey -nostdlib++ when rewriting -lstdc++.
Dec 18 2018, 3:33 PM
danalbert closed D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:32 PM
danalbert updated the diff for D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:32 PM
danalbert created D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:02 PM

Nov 5 2018

danalbert committed rC346167: [Driver] Reland again again: Default Android toolchains to libc++..
[Driver] Reland again again: Default Android toolchains to libc++.
Nov 5 2018, 1:01 PM
danalbert committed rL346167: [Driver] Reland again again: Default Android toolchains to libc++..
[Driver] Reland again again: Default Android toolchains to libc++.
Nov 5 2018, 1:01 PM

Nov 2 2018

danalbert closed D53711: [compiler-rt] Workaround using new Clang with an old NDK..

r346051

Nov 2 2018, 4:01 PM
danalbert committed rL346051: Workaround using new Clang with an old NDK..
Workaround using new Clang with an old NDK.
Nov 2 2018, 4:00 PM
danalbert committed rCRT346051: Workaround using new Clang with an old NDK..
Workaround using new Clang with an old NDK.
Nov 2 2018, 4:00 PM
danalbert added a comment to D53711: [compiler-rt] Workaround using new Clang with an old NDK..

Thanks, hadn't found that file. Much cleaner.

Nov 2 2018, 2:51 PM
danalbert updated the diff for D53711: [compiler-rt] Workaround using new Clang with an old NDK..
Nov 2 2018, 2:50 PM

Nov 1 2018

danalbert committed rL345900: Fix test assumption that Linux implies glibc..
Fix test assumption that Linux implies glibc.
Nov 1 2018, 3:38 PM
danalbert committed rCXX345900: Fix test assumption that Linux implies glibc..
Fix test assumption that Linux implies glibc.
Nov 1 2018, 3:38 PM
danalbert closed D53956: Fix test assumption that Linux implies glibc..
Nov 1 2018, 3:38 PM

Oct 31 2018

danalbert created D53956: Fix test assumption that Linux implies glibc..
Oct 31 2018, 3:52 PM

Oct 25 2018

danalbert created D53711: [compiler-rt] Workaround using new Clang with an old NDK..
Oct 25 2018, 9:35 AM

Oct 22 2018

danalbert committed rL344963: Revert "[Driver] Reland again: Default Android toolchains to libc++.".
Revert "[Driver] Reland again: Default Android toolchains to libc++."
Oct 22 2018, 3:01 PM
danalbert committed rC344963: Revert "[Driver] Reland again: Default Android toolchains to libc++.".
Revert "[Driver] Reland again: Default Android toolchains to libc++."
Oct 22 2018, 3:01 PM
danalbert committed rC344946: [Driver] Reland again: Default Android toolchains to libc++..
[Driver] Reland again: Default Android toolchains to libc++.
Oct 22 2018, 1:18 PM
danalbert committed rL344946: [Driver] Reland again: Default Android toolchains to libc++..
[Driver] Reland again: Default Android toolchains to libc++.
Oct 22 2018, 1:18 PM
danalbert accepted D53463: [Driver] allow Android triples to alias for non Android targets.

LGTM

Oct 22 2018, 12:28 PM

Oct 19 2018

danalbert committed rL344806: Revert "[Driver] Reland: Default Android toolchains to libc++.".
Revert "[Driver] Reland: Default Android toolchains to libc++."
Oct 19 2018, 12:25 PM
danalbert committed rC344806: Revert "[Driver] Reland: Default Android toolchains to libc++.".
Revert "[Driver] Reland: Default Android toolchains to libc++."
Oct 19 2018, 12:25 PM
danalbert committed rC344795: [Driver] Reland: Default Android toolchains to libc++..
[Driver] Reland: Default Android toolchains to libc++.
Oct 19 2018, 11:08 AM
danalbert committed rL344795: [Driver] Reland: Default Android toolchains to libc++..
[Driver] Reland: Default Android toolchains to libc++.
Oct 19 2018, 11:08 AM

Oct 18 2018

danalbert committed rL344753: [Zorg] Reland "Fix Android sanitizer flags.".
[Zorg] Reland "Fix Android sanitizer flags."
Oct 18 2018, 12:36 PM
danalbert committed rCRT344751: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
[compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.
Oct 18 2018, 11:08 AM
danalbert committed rL344751: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
[compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS.
Oct 18 2018, 11:06 AM
danalbert closed D53335: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
Oct 18 2018, 11:06 AM

Oct 16 2018

danalbert created D53344: [Driver] Use --warn-shared-textrel for Android..
Oct 16 2018, 3:32 PM · Restricted Project
danalbert created D53343: [Driver] Default Android toolchains to noexecstack..
Oct 16 2018, 3:19 PM · Restricted Project
danalbert created D53335: [compiler-rt] Don't explicitly set CMAKE_CXX_FLAGS..
Oct 16 2018, 12:09 PM
danalbert committed rL344640: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..
[Zorg] Use CMAKE_ASM_FLAGS with compiler-rt.
Oct 16 2018, 12:08 PM
danalbert closed D53301: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..
Oct 16 2018, 12:08 PM · Restricted Project

Oct 15 2018

danalbert updated the diff for D53301: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..

Accidentally uploaded the patch with an underlying revert that included step 2. Pulled that out.

Oct 15 2018, 4:09 PM · Restricted Project
danalbert created D53301: [Zorg] Use CMAKE_ASM_FLAGS with compiler-rt..
Oct 15 2018, 2:59 PM · Restricted Project

Oct 12 2018

danalbert committed rL344420: Revert "[Zorg] Explicitly use `-stdlib=libstdc++` for Android.".
Revert "[Zorg] Explicitly use `-stdlib=libstdc++` for Android."
Oct 12 2018, 2:40 PM
danalbert committed rL344419: Revert "[Zorg] Fix Android sanitizer flags.".
Revert "[Zorg] Fix Android sanitizer flags."
Oct 12 2018, 2:40 PM
danalbert committed rL344380: [Zorg] Fix Android sanitizer flags..
[Zorg] Fix Android sanitizer flags.
Oct 12 2018, 10:42 AM
danalbert committed rL344370: [Zorg] Explicitly use `-stdlib=libstdc++` for Android..
[Zorg] Explicitly use `-stdlib=libstdc++` for Android.
Oct 12 2018, 10:15 AM
danalbert closed D53182: [Zorg] Explicitly use `-stdlib=libstdc++` for Android..
Oct 12 2018, 10:15 AM · Restricted Project
danalbert committed rL344367: [Driver] Add defaults for Android ARM FPUs..
[Driver] Add defaults for Android ARM FPUs.
Oct 12 2018, 10:08 AM
danalbert committed rC344367: [Driver] Add defaults for Android ARM FPUs..
[Driver] Add defaults for Android ARM FPUs.
Oct 12 2018, 10:08 AM
danalbert closed D53121: [Driver] Add defaults for Android ARM FPUs..
Oct 12 2018, 10:08 AM

Oct 11 2018

danalbert created D53182: [Zorg] Explicitly use `-stdlib=libstdc++` for Android..
Oct 11 2018, 4:11 PM · Restricted Project
danalbert committed rL344297: Revert "[Driver] Default Android toolchains to libc++.".
Revert "[Driver] Default Android toolchains to libc++."
Oct 11 2018, 2:30 PM
danalbert committed rC344297: Revert "[Driver] Default Android toolchains to libc++.".
Revert "[Driver] Default Android toolchains to libc++."
Oct 11 2018, 2:30 PM
danalbert committed rC344296: [Driver] Default Android toolchains to libc++..
[Driver] Default Android toolchains to libc++.
Oct 11 2018, 2:00 PM
danalbert committed rL344296: [Driver] Default Android toolchains to libc++..
[Driver] Default Android toolchains to libc++.
Oct 11 2018, 2:00 PM
danalbert closed D53109: [Driver] Default Android toolchains to libc++..
Oct 11 2018, 2:00 PM
danalbert committed rL344295: [Driver] Default to `-z now` and `-z relro` on Android..
[Driver] Default to `-z now` and `-z relro` on Android.
Oct 11 2018, 2:00 PM
danalbert committed rC344295: [Driver] Default to `-z now` and `-z relro` on Android..
[Driver] Default to `-z now` and `-z relro` on Android.
Oct 11 2018, 1:59 PM
danalbert closed D53117: [Driver] Default to `-z now` and `-z relro` on Android..
Oct 11 2018, 1:59 PM
danalbert committed rC344293: [Driver] Fix --hash-style choice for Android..
[Driver] Fix --hash-style choice for Android.
Oct 11 2018, 1:42 PM
danalbert committed rL344293: [Driver] Fix --hash-style choice for Android..
[Driver] Fix --hash-style choice for Android.
Oct 11 2018, 1:42 PM
danalbert closed D53118: [Driver] Fix --hash-style choice for Android..
Oct 11 2018, 1:42 PM
danalbert updated the diff for D53121: [Driver] Add defaults for Android ARM FPUs..

Addressed review comments.

Oct 11 2018, 1:21 PM
danalbert added inline comments to D53121: [Driver] Add defaults for Android ARM FPUs..
Oct 11 2018, 1:20 PM

Oct 10 2018

danalbert added a comment to D53121: [Driver] Add defaults for Android ARM FPUs..

Related to this but something I was less sure we should do: Android no longer supports ARMv5. Should we make arm-linux-androideabi targets auto pull up to armv7 if there's no -march flag?

Oct 10 2018, 5:43 PM
danalbert created D53121: [Driver] Add defaults for Android ARM FPUs..
Oct 10 2018, 5:42 PM
danalbert created D53118: [Driver] Fix --hash-style choice for Android..
Oct 10 2018, 5:25 PM
danalbert created D53117: [Driver] Default to `-z now` and `-z relro` on Android..
Oct 10 2018, 5:19 PM
danalbert updated the diff for D53109: [Driver] Default Android toolchains to libc++..

Fixed bad merge conflict resolution.

Oct 10 2018, 2:33 PM
danalbert planned changes to D53109: [Driver] Default Android toolchains to libc++..

Oops, ignore this for a moment. Accidentally ran check-cxx instead of check-clang.

Oct 10 2018, 2:27 PM
danalbert created D53109: [Driver] Default Android toolchains to libc++..
Oct 10 2018, 2:19 PM

Jul 9 2018

danalbert added inline comments to D46558: Condition usage of locale stdlib functions on Android API version.
Jul 9 2018, 11:41 AM

Jun 28 2018

danalbert accepted D48731: Configure ELAST for MinGW.
Jun 28 2018, 10:57 AM

May 16 2018

danalbert accepted D46558: Condition usage of locale stdlib functions on Android API version.
May 16 2018, 3:34 PM

May 15 2018

danalbert added inline comments to D46558: Condition usage of locale stdlib functions on Android API version.
May 15 2018, 11:18 AM

May 10 2018

danalbert accepted D46558: Condition usage of locale stdlib functions on Android API version.
May 10 2018, 11:29 AM

May 7 2018

danalbert added a comment to D46558: Condition usage of locale stdlib functions on Android API version.

So now the libc++ headers depend on an unreleased (?) NDK, which doesn't seem great.

May 7 2018, 10:34 PM

May 2 2018

danalbert committed rC331390: [Driver] Infer Android sysroot location..
[Driver] Infer Android sysroot location.
May 2 2018, 12:42 PM
danalbert committed rL331390: [Driver] Infer Android sysroot location..
[Driver] Infer Android sysroot location.
May 2 2018, 12:42 PM
danalbert closed D45291: [Driver] Infer Android sysroot location..
May 2 2018, 12:42 PM
danalbert committed rL331389: [Driver] Obey computed sysroot when finding libc++ headers..
[Driver] Obey computed sysroot when finding libc++ headers.
May 2 2018, 12:34 PM
danalbert committed rC331389: [Driver] Obey computed sysroot when finding libc++ headers..
[Driver] Obey computed sysroot when finding libc++ headers.
May 2 2018, 12:34 PM
danalbert closed D45292: [Driver] Obey computed sysroot when finding libc++ headers..
May 2 2018, 12:34 PM

Apr 30 2018

danalbert added a comment to D45291: [Driver] Infer Android sysroot location..

Ping.

Apr 30 2018, 11:49 AM
danalbert added a comment to D45292: [Driver] Obey computed sysroot when finding libc++ headers..

Ping.

Apr 30 2018, 11:49 AM

Apr 25 2018

danalbert committed rC330873: [Driver] Reland "Android triples are not aliases for other triples.".
[Driver] Reland "Android triples are not aliases for other triples."
Apr 25 2018, 2:29 PM
danalbert committed rL330873: [Driver] Reland "Android triples are not aliases for other triples.".
[Driver] Reland "Android triples are not aliases for other triples."
Apr 25 2018, 2:29 PM

Apr 24 2018

danalbert committed rC330780: Revert "[Driver] Android triples are not aliases for other triples.".
Revert "[Driver] Android triples are not aliases for other triples."
Apr 24 2018, 3:10 PM
danalbert committed rL330780: Revert "[Driver] Android triples are not aliases for other triples.".
Revert "[Driver] Android triples are not aliases for other triples."
Apr 24 2018, 3:10 PM
danalbert committed rC330770: [Driver] Android triples are not aliases for other triples..
[Driver] Android triples are not aliases for other triples.
Apr 24 2018, 2:23 PM
danalbert committed rL330770: [Driver] Android triples are not aliases for other triples..
[Driver] Android triples are not aliases for other triples.
Apr 24 2018, 2:23 PM
danalbert closed D45597: [Driver] Android triples are not aliases for other triples..
Apr 24 2018, 2:23 PM

Apr 23 2018

danalbert added a comment to D45597: [Driver] Android triples are not aliases for other triples..

Ping.

Apr 23 2018, 11:51 AM
danalbert added a comment to D45291: [Driver] Infer Android sysroot location..

Ping.

Apr 23 2018, 11:50 AM
danalbert added a comment to D45292: [Driver] Obey computed sysroot when finding libc++ headers..

Ping.

Apr 23 2018, 11:50 AM

Apr 17 2018

danalbert added a comment to D45291: [Driver] Infer Android sysroot location..

Ping?

Apr 17 2018, 2:16 PM
danalbert added a comment to D45292: [Driver] Obey computed sysroot when finding libc++ headers..

Ping?

Apr 17 2018, 2:13 PM
danalbert added reviewers for D45597: [Driver] Android triples are not aliases for other triples.: george.burgess.iv, eugenis.
Apr 17 2018, 2:12 PM
danalbert accepted D44945: Always have std::condition_variable wait on CLOCK_MONOTONIC on Android.

LGTM

Apr 17 2018, 1:57 PM
danalbert committed rL330213: [Driver] Use the per-API level Android library directories..
[Driver] Use the per-API level Android library directories.
Apr 17 2018, 1:47 PM
danalbert committed rC330213: [Driver] Use the per-API level Android library directories..
[Driver] Use the per-API level Android library directories.
Apr 17 2018, 1:47 PM
danalbert closed D45290: [Driver] Use the per-API level Android library directories..
Apr 17 2018, 1:46 PM
danalbert added inline comments to D45290: [Driver] Use the per-API level Android library directories..
Apr 17 2018, 1:19 PM

Apr 12 2018

danalbert created D45597: [Driver] Android triples are not aliases for other triples..
Apr 12 2018, 3:34 PM