Page MenuHomePhabricator
Feed Advanced Search

Tue, Jan 28

danalbert accepted D73516: [libcxx] Link against android_support when needed.
Tue, Jan 28, 12:58 PM · Restricted Project
danalbert added inline comments to D73516: [libcxx] Link against android_support when needed.
Tue, Jan 28, 10:21 AM · Restricted Project
danalbert added a comment to D73516: [libcxx] Link against android_support when needed.

We don't build the NDK's libc++ with CMake. What's the motivation for this?

Tue, Jan 28, 9:40 AM · Restricted Project

Jan 6 2020

danalbert accepted D71848: Allow the discovery of Android NDK's triple-prefixed binaries..

Just to clarify, this is needed for the triple-prefixed tools, but the triple-specific directory worked fine before this patch? If I'm understanding that correctly then LGTM, otherwise I'm confused as to why I haven't seen this problem before.

Jan 6 2020, 9:47 AM · Restricted Project

Dec 6 2019

danalbert accepted D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 5:11 PM · Restricted Project
danalbert requested changes to D71154: Driver: Don't look for libc++ headers in the install directory on Android..
Dec 6 2019, 4:53 PM · Restricted Project

Nov 18 2019

danalbert committed rG19fd9039ca24: Fix _LIBCPP_HAS_ definitions for Android. (authored by danalbert).
Fix _LIBCPP_HAS_ definitions for Android.
Nov 18 2019, 12:30 PM
danalbert closed D69929: Fix _LIBCPP_HAS_ definitions for Android..

https://github.com/llvm/llvm-project/commit/19fd9039ca242f408493b5c662f9d908eab8555e

Nov 18 2019, 12:30 PM · Restricted Project
danalbert committed rG626260cfe3c7: Update the docs for building libc++. (authored by danalbert).
Update the docs for building libc++.
Nov 18 2019, 12:21 PM
danalbert closed D69917: Update the docs for building libc++..

https://github.com/llvm/llvm-project/commit/626260cfe3c7a5d9747f0bf13d87fa1855eb74bb

Nov 18 2019, 12:21 PM · Restricted Project

Nov 6 2019

danalbert accepted D69929: Fix _LIBCPP_HAS_ definitions for Android..

LGTM

Nov 6 2019, 11:01 PM · Restricted Project
danalbert added a reviewer for D69929: Fix _LIBCPP_HAS_ definitions for Android.: EricWF.
Nov 6 2019, 11:01 PM · Restricted Project
danalbert updated the diff for D69917: Update the docs for building libc++..

Fix a couple missing bits in the instructions.

Nov 6 2019, 2:01 PM · Restricted Project
danalbert created D69917: Update the docs for building libc++..
Nov 6 2019, 12:29 PM · Restricted Project

Oct 17 2019

danalbert updated subscribers of D68968: [android/process info] Introduce display_name.

Independently, I am wondering if there's a better way to link the process id to a bundle. Using argv[0] might be ok if we're using it just for display purposes, but if we're going to be doing other stuff based on that identifier, it would be better to get it from a more reliable source. Unfortunately, I was not able to find a more "reasonable source", but maybe @danalbert has an idea.

Oct 17 2019, 12:54 PM · Restricted Project

Oct 15 2019

danalbert accepted D68972: [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic.
Oct 15 2019, 9:16 PM · Restricted Project

Oct 4 2019

danalbert added a comment to D68269: [libc++abi] Do not define new/delete by default.

The alternative would be to only provide new/delete inside libc++abi, not in libc++ (by default). So, vendors (@phosek @srhines @danalbert @dim @emaste), are you OK with the default becoming that libc++abi provides new/delete, and libc++ DOES NOT (by default). If you want to keep shipping new/delete as part of libc++, you'll need to specify -DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=ON at CMake configure time.

Oct 4 2019, 1:54 PM · Restricted Project

Oct 3 2019

danalbert added a comment to D68269: [libc++abi] Do not define new/delete by default.

If the Android and FreeBSD folks are ok with this, I'm fine with it

Oct 3 2019, 12:55 PM · Restricted Project
danalbert updated subscribers of D68269: [libc++abi] Do not define new/delete by default.
Oct 3 2019, 12:55 PM · Restricted Project

Sep 26 2019

danalbert added a reviewer for D68048: [WIP][RFC] Improve fetching the process list on the android platform: emrekultursay.
Sep 26 2019, 12:28 PM · Restricted Project

Sep 18 2019

danalbert committed rG85e26f56cbf3: Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()… (authored by danalbert).
Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()…
Sep 18 2019, 11:17 AM
danalbert added a reverting change for rGc1c519d2f1a6: Revert "Implement std::condition_variable via pthread_cond_clockwait() where…: rG85e26f56cbf3: Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()….
Sep 18 2019, 11:17 AM
danalbert committed rL372242: Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()….
Revert "Revert "Implement std::condition_variable via pthread_cond_clockwait()…
Sep 18 2019, 11:16 AM

Sep 16 2019

danalbert updated subscribers of rL372016: Implement std::condition_variable via pthread_cond_clockwait() where available.

Thanks for the heads up. I've reverted the patch.

Sep 16 2019, 2:27 PM
danalbert committed rGc1c519d2f1a6: Revert "Implement std::condition_variable via pthread_cond_clockwait() where… (authored by danalbert).
Revert "Implement std::condition_variable via pthread_cond_clockwait() where…
Sep 16 2019, 2:27 PM
danalbert added a reverting change for rG5e37d7f9ff25: Implement std::condition_variable via pthread_cond_clockwait() where available: rGc1c519d2f1a6: Revert "Implement std::condition_variable via pthread_cond_clockwait() where….
Sep 16 2019, 2:26 PM
danalbert committed rL372034: Revert "Implement std::condition_variable via pthread_cond_clockwait() where….
Revert "Implement std::condition_variable via pthread_cond_clockwait() where…
Sep 16 2019, 2:19 PM
danalbert committed rGa7e9059967c4: Open fstream files in O_CLOEXEC mode when possible. (authored by danalbert).
Open fstream files in O_CLOEXEC mode when possible.
Sep 16 2019, 12:30 PM
danalbert committed rL372027: Open fstream files in O_CLOEXEC mode when possible..
Open fstream files in O_CLOEXEC mode when possible.
Sep 16 2019, 12:30 PM
danalbert closed D59839: Open fstream files in O_CLOEXEC mode when possible..
Sep 16 2019, 12:30 PM · Restricted Project, Restricted Project
danalbert closed D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

Closed by https://reviews.llvm.org/rL372016

Sep 16 2019, 11:07 AM
danalbert committed rG5e37d7f9ff25: Implement std::condition_variable via pthread_cond_clockwait() where available (authored by danalbert).
Implement std::condition_variable via pthread_cond_clockwait() where available
Sep 16 2019, 11:01 AM
danalbert committed rL372016: Implement std::condition_variable via pthread_cond_clockwait() where available.
Implement std::condition_variable via pthread_cond_clockwait() where available
Sep 16 2019, 10:56 AM

Sep 9 2019

danalbert accepted D65339: Implement std::condition_variable via pthread_cond_clockwait() where available.

LGTM. @EricWF any further comments before I submit this?

Sep 9 2019, 12:41 PM

Sep 5 2019

danalbert added a comment to D67200: Add -static-openmp driver option.

Otherwise LGTM

Sep 5 2019, 11:24 AM · Restricted Project, Restricted Project

Jul 22 2019

danalbert added a reviewer for D65000: [ARM] Set default alignment to 64bits: pirama.
Jul 22 2019, 11:07 AM · Restricted Project, Restricted Project

Jul 16 2019

danalbert accepted D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads.

MSan won't currently help us on Android (and I don't think there's a plan to support that any time soon, but eugenis would know better).

Jul 16 2019, 9:58 PM
danalbert added reviewers for D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads: yabinc, eugenis.
Jul 16 2019, 12:51 PM

Jul 15 2019

danalbert added a comment to D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads.

I think for Android we'd rather have the debuggability, but +enh for a second opinion.

Jul 15 2019, 8:57 PM
danalbert added a reviewer for D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads: enh.
Jul 15 2019, 8:51 PM

Jul 11 2019

danalbert added inline comments to D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android.
Jul 11 2019, 1:42 PM · Restricted Project
danalbert added inline comments to D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android.
Jul 11 2019, 12:55 PM · Restricted Project
danalbert added inline comments to D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android.
Jul 11 2019, 11:47 AM · Restricted Project
danalbert added a reviewer for D64427: [Test-Suite] Support Cross-Compilation and Cross-execution targeting arm64-linux-android: jmgao.
Jul 11 2019, 11:46 AM · Restricted Project

Jul 2 2019

danalbert added a comment to D64089: [Driver] Introduce -stdlib++-isystem.

For example, when we're building against the Android NDK, we might want to use the NDK's C++ headers (which have a custom inline namespace) even if we have C++ headers installed next to the driver.

Jul 2 2019, 12:40 PM · Restricted Project, Restricted Project

May 6 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

@EricWF ping

May 6 2019, 11:16 AM · Restricted Project, Restricted Project

May 1 2019

danalbert committed rGdfa7af5b6b15: Add missing locale requirement to test. (authored by danalbert).
Add missing locale requirement to test.
May 1 2019, 2:02 PM
danalbert committed rL359726: Add missing locale requirement to test..
Add missing locale requirement to test.
May 1 2019, 2:02 PM
danalbert committed rCXX359726: Add missing locale requirement to test..
Add missing locale requirement to test.
May 1 2019, 2:02 PM

Apr 16 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

@EricWF Any concerns, or can I merge this?

Apr 16 2019, 1:41 PM · Restricted Project, Restricted Project

Apr 2 2019

danalbert added inline comments to D59839: Open fstream files in O_CLOEXEC mode when possible..
Apr 2 2019, 12:43 PM · Restricted Project, Restricted Project
danalbert updated the diff for D59839: Open fstream files in O_CLOEXEC mode when possible..

Only opt-in for bionic

Apr 2 2019, 12:43 PM · Restricted Project, Restricted Project

Apr 1 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

I'm not really sure who speaks for glibc platforms. @EricWF? Like I said, if we're not comfortable making this change for glibc I don't have a problem backing that out, but I do think this is a more useful default behavior. It's fairly convoluted to pass a file descriptor from an fstream across an exec boundary intentionally so I somewhat doubt anyone is doing so intentionally. Anyone doing so unintentionally is just leaking an fd and any use of it on the other side of the exec is probably a bug.

Apr 1 2019, 1:46 PM · Restricted Project, Restricted Project
danalbert updated the diff for D59839: Open fstream files in O_CLOEXEC mode when possible..

Add a comment explaining _LIBCPP_FOPEN_CLOEXEC_MODE.

Apr 1 2019, 1:27 PM · Restricted Project, Restricted Project
danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

Ping?

Apr 1 2019, 11:19 AM · Restricted Project, Restricted Project

Mar 29 2019

danalbert added a comment to D60005: [libc++abi] Don't set POSITION_INDEPENDENT_CODE when building static library.

Android maintains its own build scripts, so this won't harm us, but I think the problem in general remains. Seems like it would be better for the webasm target to opt out of the behavior than for all targets to do it (or maybe just provide an option so maintainers can choose what they want for their platform).

Mar 29 2019, 4:33 PM · Restricted Project, Restricted Project
danalbert committed rG50e18a250fbe: [Driver] Use --warn-shared-textrel for Android. (authored by danalbert).
[Driver] Use --warn-shared-textrel for Android.
Mar 29 2019, 11:33 AM
danalbert committed rL357296: [Driver] Use --warn-shared-textrel for Android..
[Driver] Use --warn-shared-textrel for Android.
Mar 29 2019, 11:33 AM
danalbert committed rC357296: [Driver] Use --warn-shared-textrel for Android..
[Driver] Use --warn-shared-textrel for Android.
Mar 29 2019, 11:33 AM
danalbert closed D53344: [Driver] Use --warn-shared-textrel for Android..
Mar 29 2019, 11:33 AM · Restricted Project
danalbert added a reviewer for D53344: [Driver] Use --warn-shared-textrel for Android.: pirama.
Mar 29 2019, 10:35 AM · Restricted Project

Mar 28 2019

danalbert committed rG2715b2871653: [Driver] Default Android toolchains to noexecstack. (authored by danalbert).
[Driver] Default Android toolchains to noexecstack.
Mar 28 2019, 11:11 AM
danalbert committed rL357197: [Driver] Default Android toolchains to noexecstack..
[Driver] Default Android toolchains to noexecstack.
Mar 28 2019, 11:11 AM
danalbert committed rC357197: [Driver] Default Android toolchains to noexecstack..
[Driver] Default Android toolchains to noexecstack.
Mar 28 2019, 11:11 AM
danalbert closed D53343: [Driver] Default Android toolchains to noexecstack..
Mar 28 2019, 11:11 AM · Restricted Project

Mar 27 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

I'm mostly worried about the change in behavior breaking existing programs.

Mar 27 2019, 1:14 PM · Restricted Project, Restricted Project

Mar 26 2019

danalbert added a comment to D59839: Open fstream files in O_CLOEXEC mode when possible..

How did you decide which modes fell into "when possible"?

Mar 26 2019, 2:56 PM · Restricted Project, Restricted Project
danalbert created D59839: Open fstream files in O_CLOEXEC mode when possible..
Mar 26 2019, 1:12 PM · Restricted Project, Restricted Project

Feb 21 2019

danalbert committed rG475042d5b1be: [Driver] Fix float ABI default for Android ARMv8. (authored by danalbert).
[Driver] Fix float ABI default for Android ARMv8.
Feb 21 2019, 1:13 PM
danalbert committed rC354622: [Driver] Fix float ABI default for Android ARMv8..
[Driver] Fix float ABI default for Android ARMv8.
Feb 21 2019, 1:13 PM
danalbert committed rL354622: [Driver] Fix float ABI default for Android ARMv8..
[Driver] Fix float ABI default for Android ARMv8.
Feb 21 2019, 1:13 PM
danalbert closed D58477: [Driver] Fix float ABI default for Android ARMv8..
Feb 21 2019, 1:13 PM · Restricted Project, Restricted Project
danalbert added inline comments to D58314: [Driver] Sync ARM behavior between clang-as and gas..
Feb 21 2019, 12:53 PM · Restricted Project

Feb 20 2019

danalbert created D58477: [Driver] Fix float ABI default for Android ARMv8..
Feb 20 2019, 2:14 PM · Restricted Project, Restricted Project
danalbert added inline comments to D58314: [Driver] Sync ARM behavior between clang-as and gas..
Feb 20 2019, 1:56 PM · Restricted Project
danalbert updated the diff for D58314: [Driver] Sync ARM behavior between clang-as and gas..

Updated to address some review comments:

Feb 20 2019, 1:56 PM · Restricted Project

Feb 15 2019

danalbert created D58314: [Driver] Sync ARM behavior between clang-as and gas..
Feb 15 2019, 5:00 PM · Restricted Project
danalbert committed rGdf89c6ffa373: [Driver] Default all Android ARM targets to NEON. (authored by danalbert).
[Driver] Default all Android ARM targets to NEON.
Feb 15 2019, 12:32 PM
danalbert committed rC354166: [Driver] Default all Android ARM targets to NEON..
[Driver] Default all Android ARM targets to NEON.
Feb 15 2019, 12:31 PM
danalbert committed rL354166: [Driver] Default all Android ARM targets to NEON..
[Driver] Default all Android ARM targets to NEON.
Feb 15 2019, 12:31 PM
danalbert closed D58153: [Driver] Default all Android ARM targets to NEON..
Feb 15 2019, 12:31 PM · Restricted Project, Restricted Project

Feb 13 2019

danalbert added a comment to D58153: [Driver] Default all Android ARM targets to NEON..

The official documentation still says "Your app must perform runtime detection to confirm that NEON-capable machine code can be run on the target device" (https://developer.android.com/ndk/guides/cpu-arm-neon#runtime_detection). Is that wrong?

Feb 13 2019, 12:31 PM · Restricted Project, Restricted Project

Feb 12 2019

danalbert created D58153: [Driver] Default all Android ARM targets to NEON..
Feb 12 2019, 3:25 PM · Restricted Project, Restricted Project

Jan 15 2019

danalbert added inline comments to D38430: Enable -pie and --enable-new-dtags by default on Android..
Jan 15 2019, 4:07 PM
danalbert committed rCXX351226: Fix size_t/off_t mixup in std::filesystem..
Fix size_t/off_t mixup in std::filesystem.
Jan 15 2019, 11:20 AM
danalbert committed rL351226: Fix size_t/off_t mixup in std::filesystem..
Fix size_t/off_t mixup in std::filesystem.
Jan 15 2019, 11:20 AM
danalbert closed D56578: Fix size_t/off_t mixup in std::filesystem..
Jan 15 2019, 11:20 AM
danalbert committed rCXX351225: Add large file support to create_file for 32-bit..
Add large file support to create_file for 32-bit.
Jan 15 2019, 11:18 AM
danalbert committed rL351225: Add large file support to create_file for 32-bit..
Add large file support to create_file for 32-bit.
Jan 15 2019, 11:18 AM
danalbert closed D56619: Add large file support to create_file for 32-bit..
Jan 15 2019, 11:18 AM

Jan 11 2019

danalbert created D56619: Add large file support to create_file for 32-bit..
Jan 11 2019, 2:03 PM
danalbert updated the diff for D56578: Fix size_t/off_t mixup in std::filesystem..

Added reference to spec in comment.

Jan 11 2019, 10:25 AM

Jan 10 2019

danalbert created D56578: Fix size_t/off_t mixup in std::filesystem..
Jan 10 2019, 9:40 PM

Jan 8 2019

danalbert committed rC350668: [Driver] Default to -fno-addrsig on Android..
[Driver] Default to -fno-addrsig on Android.
Jan 8 2019, 2:38 PM
danalbert committed rL350668: [Driver] Default to -fno-addrsig on Android..
[Driver] Default to -fno-addrsig on Android.
Jan 8 2019, 2:37 PM
danalbert closed D56456: [Driver] Default to -fno-addrsig on Android..
Jan 8 2019, 2:37 PM
danalbert committed rL350664: Android is not GNU, so don't claim that it is..
Android is not GNU, so don't claim that it is.
Jan 8 2019, 2:35 PM
danalbert committed rC350664: Android is not GNU, so don't claim that it is..
Android is not GNU, so don't claim that it is.
Jan 8 2019, 2:35 PM
danalbert closed D55953: Android is not GNU, so don't claim that it is..
Jan 8 2019, 2:35 PM
danalbert created D56456: [Driver] Default to -fno-addrsig on Android..
Jan 8 2019, 2:25 PM