Page MenuHomePhabricator
Feed Advanced Search

Mon, Jul 19

kaz7 committed rG4ee28b4fecad: [VE] Set getExtendForAtomicOps to ISD::ANY_EXTEND (authored by kaz7).
[VE] Set getExtendForAtomicOps to ISD::ANY_EXTEND
Mon, Jul 19, 3:59 AM
kaz7 closed D106225: [VE] Set getExtendForAtomicOps to ISD::ANY_EXTEND.
Mon, Jul 19, 3:59 AM · Restricted Project, Restricted Project
kaz7 committed rGb28e5b791064: [VE] Disable relative lookup table converter pass for VE (authored by kaz7).
[VE] Disable relative lookup table converter pass for VE
Mon, Jul 19, 3:26 AM
kaz7 closed D106224: [VE] Disable relative lookup table converter pass for VE.
Mon, Jul 19, 3:25 AM · Restricted Project, Restricted Project

Sun, Jul 18

kaz7 added a comment to D106225: [VE] Set getExtendForAtomicOps to ISD::ANY_EXTEND.

This fixes a problem caused in atomic_load.ll regression test.

Sun, Jul 18, 9:16 AM · Restricted Project, Restricted Project

Sat, Jul 17

kaz7 requested review of D106225: [VE] Set getExtendForAtomicOps to ISD::ANY_EXTEND.
Sat, Jul 17, 1:02 PM · Restricted Project, Restricted Project
kaz7 requested review of D106224: [VE] Disable relative lookup table converter pass for VE.
Sat, Jul 17, 12:41 PM · Restricted Project, Restricted Project

Wed, Jul 14

kaz7 added a comment to D101509: An attempt to abandon omptarget out-of-tree builds..

Thank you for the clarify. As far as I know, our build system for omptarget for VE generates libomptarget.so for VE. Maybe it's the source of problem. I'll discuss with people who implement it for VE about the possibility of separating omptarget itself and runtime. Thanks.

Wed, Jul 14, 7:17 PM · Restricted Project
kaz7 added a comment to D101509: An attempt to abandon omptarget out-of-tree builds..

I've noticed this patch breaks libomptarget for VE. The VE is an accelarator, so we create and install clang/llvm for VE as a cross compiler. Then, we build libomptarget for VE using this cross compiler.

Wed, Jul 14, 10:05 AM · Restricted Project

Tue, Jun 29

kaz7 added a comment to D96681: [RISCV][LegalizeTypes] Try to expand BITREVERSE before promoting if the promoted BITREVERSE would expand anyway..

I just commited 913229983633cd4c19b9e5534018f9a42e274b30 which restores VE's previous codegen for i8 and i16 bitreverse. I restored bitreverse.ll to its previous state.

Tue, Jun 29, 5:05 PM · Restricted Project
kaz7 added a comment to D96681: [RISCV][LegalizeTypes] Try to expand BITREVERSE before promoting if the promoted BITREVERSE would expand anyway..

Is it possible to disable this expansion on a architecture which has 64 bit bitreverse and want to promote 32 bit bitreverse to 64 bit?

Tue, Jun 29, 5:19 AM · Restricted Project

Feb 1 2021

kaz7 committed rG4648098f97fa: [VE] Change inetger constants 32-bit friendly (authored by kaz7).
[VE] Change inetger constants 32-bit friendly
Feb 1 2021, 2:01 AM
kaz7 closed D95724: [VE] Change inetger constants 32-bit friendly.
Feb 1 2021, 2:01 AM · Restricted Project, Restricted Project

Jan 29 2021

kaz7 requested review of D95724: [VE] Change inetger constants 32-bit friendly.
Jan 29 2021, 8:01 PM · Restricted Project, Restricted Project

Jan 24 2021

kaz7 added inline comments to D31639: [CMake][libcxxabi] Use -nodefaultlibs for CMake checks .
Jan 24 2021, 5:36 AM

Jan 19 2021

kaz7 added inline comments to D31639: [CMake][libcxxabi] Use -nodefaultlibs for CMake checks .
Jan 19 2021, 3:47 PM
kaz7 added a comment to D31639: [CMake][libcxxabi] Use -nodefaultlibs for CMake checks .

Hi, I have a question about this patch. I appreciate any answers. Thanks!

Jan 19 2021, 5:11 AM

Jan 18 2021

kaz7 added a comment to D94909: [VE] Define FUTEX values.

Thanks for your contribution. However, it would be useful to have more information before going forward. The goal is to avoid adding random bits of complexity to the library for a system that isn't officially supported and maintained.

  • What is VEOS?
  • Is this part of an effort to port libc++ to that OS?
  • What parts of the library are working on the OS and what parts are not working? Do you plan to subset the library using knobs like LIBCXX_ENABLE_LOCALIZATION=OFF?
  • Are you able to provide CI for that OS?

Generally speaking, more information about what prompts this patch is welcome.

Jan 18 2021, 4:34 PM · Restricted Project, Restricted Project
kaz7 requested review of D94909: [VE] Define FUTEX values.
Jan 18 2021, 4:48 AM · Restricted Project, Restricted Project

Jan 16 2021

kaz7 committed rG3cbd476c5488: [VE] Support VE in libunwind (authored by kaz7).
[VE] Support VE in libunwind
Jan 16 2021, 10:35 PM
kaz7 closed D94591: [VE] Support VE in libunwind.
Jan 16 2021, 10:35 PM · Restricted Project, Restricted Project, Restricted Project

Jan 14 2021

kaz7 updated the diff for D94591: [VE] Support VE in libunwind.

Update following suggestions and clang-format.

Jan 14 2021, 12:02 AM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2021

kaz7 added inline comments to D94591: [VE] Support VE in libunwind.
Jan 13 2021, 11:30 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 requested review of D94591: [VE] Support VE in libunwind.
Jan 13 2021, 4:48 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2021

kaz7 committed rG24faa87075ac: [VE] Update VELIntrinsic tests (authored by kaz7).
[VE] Update VELIntrinsic tests
Jan 12 2021, 7:13 AM
kaz7 closed D94490: [VE] Update VELIntrinsic tests.
Jan 12 2021, 7:13 AM · Restricted Project, Restricted Project
kaz7 requested review of D94490: [VE] Update VELIntrinsic tests.
Jan 12 2021, 4:46 AM · Restricted Project, Restricted Project

Jan 11 2021

kaz7 committed rG70474dfebcd9: [VE][compiler-rt] Add VE as a target of crt (authored by kaz7).
[VE][compiler-rt] Add VE as a target of crt
Jan 11 2021, 5:20 PM
kaz7 closed D92748: [VE][compiler-rt] Add VE as a target of crt.
Jan 11 2021, 5:20 PM · Restricted Project, Restricted Project
kaz7 committed rGd02de1393248: [VE] Support additional VMRGW and VMV intrinsic instructions (authored by kaz7).
[VE] Support additional VMRGW and VMV intrinsic instructions
Jan 11 2021, 3:50 AM
kaz7 closed D94300: [VE] Support additional VMRGW and VMV intrinsic instructions.
Jan 11 2021, 3:50 AM · Restricted Project, Restricted Project
kaz7 committed rGb72ca799823e: [VE] Support intrinsic to isnert/extract_subreg of v512i1 (authored by kaz7).
[VE] Support intrinsic to isnert/extract_subreg of v512i1
Jan 11 2021, 3:40 AM
kaz7 closed D94298: [VE] Support intrinsic to isnert/extract_subreg of v512i1.
Jan 11 2021, 3:40 AM · Restricted Project, Restricted Project

Jan 8 2021

kaz7 added a comment to D92748: [VE][compiler-rt] Add VE as a target of crt.

LGTM

Jan 8 2021, 6:07 AM · Restricted Project, Restricted Project
kaz7 committed rG5ead757f1d89: [VE] Support pack_f32p and pack_f32a intrinsic instructions (authored by kaz7).
[VE] Support pack_f32p and pack_f32a intrinsic instructions
Jan 8 2021, 5:59 AM
kaz7 closed D94296: [VE] Support pack_f32p and pack_f32a intrinsic instructions.
Jan 8 2021, 5:59 AM · Restricted Project, Restricted Project
kaz7 requested review of D94300: [VE] Support additional VMRGW and VMV intrinsic instructions.
Jan 8 2021, 5:34 AM · Restricted Project, Restricted Project
kaz7 requested review of D94298: [VE] Support intrinsic to isnert/extract_subreg of v512i1.
Jan 8 2021, 5:23 AM · Restricted Project, Restricted Project
kaz7 requested review of D94296: [VE] Support pack_f32p and pack_f32a intrinsic instructions.
Jan 8 2021, 4:57 AM · Restricted Project, Restricted Project
kaz7 committed rG99c84af1a25a: [VE][NFC] Clean ISel patterns for LSV and LVS (authored by kaz7).
[VE][NFC] Clean ISel patterns for LSV and LVS
Jan 8 2021, 4:48 AM
kaz7 closed D94291: [VE][NFC] Clean ISel patterns for LSV and LVS.
Jan 8 2021, 4:48 AM · Restricted Project, Restricted Project
kaz7 accepted D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and.

LGTM also.

Jan 8 2021, 4:46 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 requested review of D94291: [VE][NFC] Clean ISel patterns for LSV and LVS.
Jan 8 2021, 3:01 AM · Restricted Project, Restricted Project
kaz7 accepted D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT.

LGTM

Jan 8 2021, 2:33 AM · Restricted Project, Restricted Project
kaz7 committed rG12167632bc5c: [VE] Add SVOB intrinsic instruction (authored by kaz7).
[VE] Add SVOB intrinsic instruction
Jan 8 2021, 1:49 AM
kaz7 closed D94279: [VE] Add SVOB intrinsic instruction.
Jan 8 2021, 1:49 AM · Restricted Project, Restricted Project

Jan 7 2021

kaz7 requested review of D94279: [VE] Add SVOB intrinsic instruction.
Jan 7 2021, 5:38 PM · Restricted Project, Restricted Project
kaz7 added a comment to D92748: [VE][compiler-rt] Add VE as a target of crt.

Not sure what is the problem... Remove profile support to make this patch as simple as possible.

Jan 7 2021, 6:03 AM · Restricted Project, Restricted Project
kaz7 retitled D92748: [VE][compiler-rt] Add VE as a target of crt from [VE][compiler-rt] Add VE as a candidate of crt/profile to [VE][compiler-rt] Add VE as a target of crt.
Jan 7 2021, 6:02 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D92748: [VE][compiler-rt] Add VE as a target of crt.

Remove modification on the candidates of profilers.
Leave only modification on the candidates of crt and rebase.
Add explanations too.

Jan 7 2021, 6:01 AM · Restricted Project, Restricted Project

Jan 6 2021

kaz7 committed rG3bfc9bb8ef22: [VE][NFC] Update comments to match the generated instructions (authored by kaz7).
[VE][NFC] Update comments to match the generated instructions
Jan 6 2021, 10:14 PM

Jan 5 2021

kaz7 added inline comments to D93759: [VE] Expand single-element BUILD_VECTOR to INSERT_VECTOR_ELT.
Jan 5 2021, 5:57 AM · Restricted Project, Restricted Project
kaz7 accepted D93687: [VE] Extract & insert vector element isel.

Thanks! LGTM.

Jan 5 2021, 5:51 AM · Restricted Project, Restricted Project
kaz7 added a comment to D93687: [VE] Extract & insert vector element isel.

A few more modificating candidates to make code better.

Jan 5 2021, 5:30 AM · Restricted Project, Restricted Project
kaz7 committed rG489000d8516d: [VE] Change clang to support SjLj Lowering (authored by kaz7).
[VE] Change clang to support SjLj Lowering
Jan 5 2021, 5:19 AM
kaz7 closed D94076: [VE] Change clang to support SjLj Lowering.
Jan 5 2021, 5:19 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 added a comment to D94076: [VE] Change clang to support SjLj Lowering.

Thanks!

Jan 5 2021, 5:18 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 retitled D94076: [VE] Change clang to support SjLj Lowering from [VE] Change clang to support SjLj Loweirng to [VE] Change clang to support SjLj Lowering.
Jan 5 2021, 5:17 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 requested review of D94076: [VE] Change clang to support SjLj Lowering.
Jan 5 2021, 3:20 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 committed rGf784be0777f3: [VE] Support SJLJ exception related instructions (authored by kaz7).
[VE] Support SJLJ exception related instructions
Jan 5 2021, 3:19 AM
kaz7 closed D94071: [VE] Support SJLJ exception related instructions.
Jan 5 2021, 3:19 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D93687: [VE] Extract & insert vector element isel.
Jan 5 2021, 3:12 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D94071: [VE] Support SJLJ exception related instructions.

Update comments in header file comment which I've forgotten to modify.

Jan 5 2021, 2:01 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D94071: [VE] Support SJLJ exception related instructions.

Change following suggestions. Also rebase to main.

Jan 5 2021, 1:58 AM · Restricted Project, Restricted Project
kaz7 retitled D94071: [VE] Support SJLJ exception related instructions from [VE] Support SJLJ stuff to [VE] Support SJLJ exception related instructions.
Jan 5 2021, 1:58 AM · Restricted Project, Restricted Project
kaz7 committed rG53a341a61d1f: [VE][NFC] Fix typo in comments (authored by kaz7).
[VE][NFC] Fix typo in comments
Jan 5 2021, 1:56 AM
kaz7 added a comment to D94071: [VE] Support SJLJ exception related instructions.

"Stuff" is unspecific. How about we go by "[VE] SJLJ isel" or something along those lines for the title?

Jan 5 2021, 1:52 AM · Restricted Project, Restricted Project
kaz7 added a comment to D92748: [VE][compiler-rt] Add VE as a target of crt.

Hi @kaz7,

If I understand correctly, this is a chicken-egg problem. You can't upstream the back-end without the RT changes because you have no other RT to rely on (unlike other targets that can use the GCC toolchain). In this case, I think it makes sense that we merge at least some bootstrapping code in RT before the back-end.

Jan 5 2021, 1:30 AM · Restricted Project, Restricted Project
kaz7 requested review of D94071: [VE] Support SJLJ exception related instructions.
Jan 5 2021, 1:18 AM · Restricted Project, Restricted Project
kaz7 committed rG2654f33c47f4: [VE] Support llvm.eh.sjlj.lsda (authored by kaz7).
[VE] Support llvm.eh.sjlj.lsda
Jan 5 2021, 1:06 AM
kaz7 closed D93811: [VE] Support llvm.eh.sjlj.lsda.
Jan 5 2021, 1:06 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D93811: [VE] Support llvm.eh.sjlj.lsda.
Jan 5 2021, 1:03 AM · Restricted Project, Restricted Project

Jan 4 2021

kaz7 added inline comments to D93687: [VE] Extract & insert vector element isel.
Jan 4 2021, 7:50 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D93811: [VE] Support llvm.eh.sjlj.lsda.
Jan 4 2021, 7:02 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D93811: [VE] Support llvm.eh.sjlj.lsda.

Change to use Op.getSimpleValueType() as suggested.

Jan 4 2021, 6:58 AM · Restricted Project, Restricted Project
kaz7 committed rGc287f90ccd33: [VE] Change default CPU name to "generic" (authored by kaz7).
[VE] Change default CPU name to "generic"
Jan 4 2021, 3:10 AM
kaz7 closed D93836: [VE] Change default CPU name to "generic".
Jan 4 2021, 3:10 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D93836: [VE] Change default CPU name to "generic".

Update following suggestions.

Jan 4 2021, 2:12 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D93811: [VE] Support llvm.eh.sjlj.lsda.

Update following suggestions. Use TLI.getPoitnerTy() this time since
lsda expansion uses machine value type (MVT) instead of value type
structure (EVT) here. Using EVT may require some conversions later.

Jan 4 2021, 1:50 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D93811: [VE] Support llvm.eh.sjlj.lsda.
Jan 4 2021, 1:33 AM · Restricted Project, Restricted Project
kaz7 committed rG74e7cb26b9a3: [VE] Remove VA.needsCustom checks (authored by kaz7).
[VE] Remove VA.needsCustom checks
Jan 4 2021, 1:19 AM
kaz7 closed D93847: [VE] Remove VA.needsCustom checks.
Jan 4 2021, 1:19 AM · Restricted Project, Restricted Project

Dec 27 2020

kaz7 requested review of D93847: [VE] Remove VA.needsCustom checks.
Dec 27 2020, 6:21 PM · Restricted Project, Restricted Project
kaz7 requested review of D93836: [VE] Change default CPU name to "generic".
Dec 27 2020, 6:30 AM · Restricted Project, Restricted Project

Dec 26 2020

kaz7 added a comment to D88905: [Clang] Allow "ext_vector_type" applied to Booleans.

We are using this patch in llvm/clang for VE and the patch is really helpful to implement intrinsic instructions using vector mask registers. This works fine in backend since backend supports vXi1. I wish people working on clang think this patch is reasonable.

Dec 26 2020, 5:11 AM · Restricted Project

Dec 25 2020

kaz7 added a comment to D93766: [VP] ISD helper functions [VE] isel for vp_add, vp_and.

I think we need more reviewer working on not only VVP but also VP to review this patch.

Dec 25 2020, 4:11 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 requested review of D93811: [VE] Support llvm.eh.sjlj.lsda.
Dec 25 2020, 4:05 AM · Restricted Project, Restricted Project

Dec 23 2020

kaz7 accepted D93709: [VE] Vector 'and' isel and tests.

LGTM.

Dec 23 2020, 4:11 AM · Restricted Project, Restricted Project

Dec 22 2020

kaz7 added a comment to D92748: [VE][compiler-rt] Add VE as a target of crt.

ping

Dec 22 2020, 1:26 AM · Restricted Project, Restricted Project

Dec 21 2020

kaz7 committed rG8c2ad9e85f67: [VE] Correct VMP allocation in calling conv (authored by kaz7).
[VE] Correct VMP allocation in calling conv
Dec 21 2020, 5:42 AM
kaz7 closed D93570: [VE] Correct VMP allocation in calling conv.
Dec 21 2020, 5:42 AM · Restricted Project, Restricted Project
kaz7 added a comment to D93534: [VP] Improve the VP intrinsic unittests.

This is what I feel when I see this test. Just a thought. Not a requirement. But, I think it's possible to improve this test in that way.

Dec 21 2020, 5:40 AM · Restricted Project, Restricted Project
kaz7 committed rGa3a896d1cdc0: [VE] Optimize LEA combinations (authored by kaz7).
[VE] Optimize LEA combinations
Dec 21 2020, 5:21 AM
kaz7 closed D93627: [VE] Optimize LEA combinations.
Dec 21 2020, 5:21 AM · Restricted Project, Restricted Project
kaz7 added reviewers for D93570: [VE] Correct VMP allocation in calling conv: simoll, k-ishizaka.
Dec 21 2020, 5:19 AM · Restricted Project, Restricted Project
kaz7 requested review of D93627: [VE] Optimize LEA combinations.
Dec 21 2020, 3:57 AM · Restricted Project, Restricted Project
kaz7 committed rG5e273b845bc4: [VE] Support STACKSAVE and STACKRESTORE (authored by kaz7).
[VE] Support STACKSAVE and STACKRESTORE
Dec 21 2020, 3:16 AM
kaz7 closed D93539: [VE] Support STACKSAVE and STACKRESTORE.
Dec 21 2020, 3:16 AM · Restricted Project, Restricted Project
kaz7 committed rGd99e4a4840d8: [VE] Support RETURNADDR (authored by kaz7).
[VE] Support RETURNADDR
Dec 21 2020, 3:06 AM
kaz7 closed D93545: [VE] Support RETURNADDR.
Dec 21 2020, 3:06 AM · Restricted Project, Restricted Project