Page MenuHomePhabricator
Feed Advanced Search

Dec 15 2020

csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Rebase.

Dec 15 2020, 10:21 PM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Rebase.

Dec 15 2020, 12:53 PM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Add test.

Dec 15 2020, 12:15 PM · Restricted Project

Dec 14 2020

csigg added a reverting change for rG6f271e921ba4: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: rG0cf7e4b252fe: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir….
Dec 14 2020, 1:47 PM
csigg committed rG0cf7e4b252fe: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir… (authored by csigg).
Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir…
Dec 14 2020, 1:47 PM
csigg added a reverting change for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: rG0cf7e4b252fe: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir….
Dec 14 2020, 1:47 PM · Restricted Project
csigg closed D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:47 PM · Restricted Project
csigg added a reverting change for rG6f271e921ba4: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:46 PM
csigg requested review of D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:46 PM · Restricted Project
csigg added a reverting change for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.: D93242: Revert "[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.".
Dec 14 2020, 1:46 PM · Restricted Project
csigg committed rG6f271e921ba4: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation. (authored by csigg).
[mlir] Remove methods from mlir::OpState that just forward to mlir::Operation.
Dec 14 2020, 12:26 PM
csigg closed D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..
Dec 14 2020, 12:26 PM · Restricted Project
csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

Rebase.

Dec 14 2020, 11:30 AM · Restricted Project
csigg committed rGa1eb154421a0: [flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation. (authored by csigg).
[flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation.
Dec 14 2020, 11:05 AM
csigg closed D93194: [flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation..
Dec 14 2020, 11:05 AM · Restricted Project
csigg updated the diff for D93156: [mlir] Fix for gpu-async-region pass..

Thanks for the review!

Dec 14 2020, 5:56 AM · Restricted Project
csigg added a comment to D93156: [mlir] Fix for gpu-async-region pass..

There should be some test that captures this.

Dec 14 2020, 5:55 AM · Restricted Project
csigg requested review of D93204: [mlir] Lower gpu.memcpy to GPU runtime calls..
Dec 14 2020, 4:12 AM · Restricted Project
csigg updated the diff for D93197: [mlir] Add gpu.memcpy op..

Swap %src and %dst, doh.

Dec 14 2020, 1:31 AM · Restricted Project
csigg requested review of D93197: [mlir] Add gpu.memcpy op..
Dec 14 2020, 1:24 AM · Restricted Project
csigg updated the diff for D93194: [flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation..

Fix clang-tidy warning.

Dec 14 2020, 12:21 AM · Restricted Project

Dec 13 2020

csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

Moving the remaining call site changes to a separate revision (D93194).

Dec 13 2020, 11:38 PM · Restricted Project
csigg requested review of D93194: [flang] Use mlir::OpState::operator->() to get to methods of mlir::Operation..
Dec 13 2020, 11:35 PM · Restricted Project
csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

More flang changes.

Dec 13 2020, 1:00 PM · Restricted Project
csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

Changing call sites I missed in FIROps.td.

Dec 13 2020, 12:14 PM · Restricted Project
csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

Rebase.

Dec 13 2020, 11:17 AM · Restricted Project
csigg updated the diff for D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..

Include a few few fixes that I missed.

Dec 13 2020, 10:43 AM · Restricted Project
csigg requested review of D93176: [mlir] Remove methods from mlir::OpState that just forward to mlir::Operation..
Dec 13 2020, 1:07 AM · Restricted Project
csigg committed rG1ffc1aaa0967: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. (authored by csigg).
[mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation.
Dec 13 2020, 12:58 AM
csigg closed D93098: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation..
Dec 13 2020, 12:58 AM · Restricted Project
csigg added inline comments to D93098: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation..
Dec 13 2020, 12:46 AM · Restricted Project

Dec 12 2020

csigg updated the diff for D93098: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation..

More fixes.

Dec 12 2020, 1:51 AM · Restricted Project

Dec 11 2020

csigg updated the diff for D93098: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation..

Fix op-attribute.td test.

Dec 11 2020, 10:38 PM · Restricted Project
csigg requested review of D93156: [mlir] Fix for gpu-async-region pass..
Dec 11 2020, 10:35 PM · Restricted Project
csigg requested review of D93098: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation..
Dec 11 2020, 2:43 AM · Restricted Project

Dec 9 2020

csigg committed rG0bf4a82a5a2b: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. (authored by csigg).
[mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation.
Dec 9 2020, 3:12 AM
csigg closed D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..
Dec 9 2020, 3:11 AM · Restricted Project
csigg updated the diff for D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..

Fix clang-tidy error.

Dec 9 2020, 2:50 AM · Restricted Project
csigg updated the diff for D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..

Update op-attribute.td test.

Dec 9 2020, 1:39 AM · Restricted Project
csigg updated the diff for D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..

Replace getOperation()-> with (*this)-> across FIROps.td.

Dec 9 2020, 12:47 AM · Restricted Project
csigg updated the diff for D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..

Rebase.

Dec 9 2020, 12:43 AM · Restricted Project
csigg updated the diff for D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..

Change getOperation()-> to (*this)->.

Dec 9 2020, 12:42 AM · Restricted Project

Dec 8 2020

csigg requested review of D92878: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState..
Dec 8 2020, 12:43 PM · Restricted Project
csigg added a reverting change for D92670: [mlir] Tighten access of RewritePattern methods.: rG2a9840900ccc: [mlir] Revert "Tighten access of RewritePattern methods.".
Dec 8 2020, 8:41 AM · Restricted Project
csigg added a reverting change for rG02c9050155df: [mlir] Tighten access of RewritePattern methods.: rG2a9840900ccc: [mlir] Revert "Tighten access of RewritePattern methods.".
Dec 8 2020, 8:41 AM
csigg committed rG2a9840900ccc: [mlir] Revert "Tighten access of RewritePattern methods." (authored by csigg).
[mlir] Revert "Tighten access of RewritePattern methods."
Dec 8 2020, 8:41 AM
csigg closed D92855: [mlir] Revert "Tighten access of RewritePattern methods.".
Dec 8 2020, 8:41 AM · Restricted Project
csigg added a reverting change for rG02c9050155df: [mlir] Tighten access of RewritePattern methods.: D92855: [mlir] Revert "Tighten access of RewritePattern methods.".
Dec 8 2020, 8:40 AM
csigg requested review of D92855: [mlir] Revert "Tighten access of RewritePattern methods.".
Dec 8 2020, 8:40 AM · Restricted Project
csigg added a reverting change for D92670: [mlir] Tighten access of RewritePattern methods.: D92855: [mlir] Revert "Tighten access of RewritePattern methods.".
Dec 8 2020, 8:40 AM · Restricted Project
csigg committed rG02c9050155df: [mlir] Tighten access of RewritePattern methods. (authored by csigg).
[mlir] Tighten access of RewritePattern methods.
Dec 8 2020, 7:45 AM
csigg closed D92670: [mlir] Tighten access of RewritePattern methods..
Dec 8 2020, 7:45 AM · Restricted Project

Dec 4 2020

csigg retitled D92670: [mlir] Tighten access of RewritePattern methods. from [mlir] Tighten scopes of RewritePattern methods. to [mlir] Tighten access of RewritePattern methods..
Dec 4 2020, 11:48 AM · Restricted Project
csigg requested review of D92670: [mlir] Tighten access of RewritePattern methods..
Dec 4 2020, 10:18 AM · Restricted Project
csigg committed rGdcec2ca5bd3d: Remove typeConverter from ConvertToLLVMPattern and use the existing one in… (authored by csigg).
Remove typeConverter from ConvertToLLVMPattern and use the existing one in…
Dec 4 2020, 5:27 AM
csigg closed D92564: Remove typeConverter from ConvertToLLVMPattern and use the existing one in ConversionPattern..
Dec 4 2020, 5:27 AM · Restricted Project

Dec 3 2020

csigg requested review of D92564: Remove typeConverter from ConvertToLLVMPattern and use the existing one in ConversionPattern..
Dec 3 2020, 3:34 AM · Restricted Project
csigg abandoned D78640: [MLIR][Prototype] async gpu ops.
Dec 3 2020, 1:45 AM · Restricted Project, Restricted Project
csigg committed rG48f7ca187944: Fix forward for rGd9adde5ae216: adding missing dependency. (authored by csigg).
Fix forward for rGd9adde5ae216: adding missing dependency.
Dec 3 2020, 1:17 AM
csigg closed D92552: Fix forward for rGd9adde5ae216: adding missing dependency..
Dec 3 2020, 1:17 AM · Restricted Project
csigg requested review of D92552: Fix forward for rGd9adde5ae216: adding missing dependency..
Dec 3 2020, 1:08 AM · Restricted Project

Dec 2 2020

csigg committed rGd9adde5ae216: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies. (authored by csigg).
[mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies.
Dec 2 2020, 11:52 PM
csigg closed D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..
Dec 2 2020, 11:52 PM · Restricted Project
csigg committed rGc4a04059026b: Add `Operation* OpState::operator->()` to provide more convenient access to… (authored by csigg).
Add `Operation* OpState::operator->()` to provide more convenient access to…
Dec 2 2020, 6:46 AM
csigg closed D92266: Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation..
Dec 2 2020, 6:46 AM · Restricted Project
csigg added a comment to D92266: Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation..

Much nicer, thanks!! We could probably remove some of the duplicated methods from Op now, the duplication doesn't bring a huge benefit IMO.

Dec 2 2020, 6:44 AM · Restricted Project
csigg added inline comments to D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..
Dec 2 2020, 12:50 AM · Restricted Project
csigg updated the diff for D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..

Add some additional comments, drop getOperation().

Dec 2 2020, 12:50 AM · Restricted Project

Nov 30 2020

csigg added 1 blocking reviewer(s) for D92266: Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation.: rriddle.
Nov 30 2020, 4:09 AM · Restricted Project
csigg committed rGffaba24c75ed: Add `using ConvertToLLVMPattern::match/matchAndRewrite` to avoid 'hiding… (authored by csigg).
Add `using ConvertToLLVMPattern::match/matchAndRewrite` to avoid 'hiding…
Nov 30 2020, 2:41 AM
csigg closed D92303: Add `using ConvertToLLVMPattern::match/matchAndRewrite` to avoid 'hiding overload' warning..
Nov 30 2020, 2:40 AM · Restricted Project
csigg requested review of D92303: Add `using ConvertToLLVMPattern::match/matchAndRewrite` to avoid 'hiding overload' warning..
Nov 30 2020, 2:34 AM · Restricted Project

Nov 28 2020

csigg requested review of D92266: Add `Operation* OpState::operator->()` to provide more convenient access to members of Operation..
Nov 28 2020, 5:03 AM · Restricted Project
csigg committed rGe9e45b3887ca: [mlir] Fix bad rebase landed in acb69f3b7c83. (authored by csigg).
[mlir] Fix bad rebase landed in acb69f3b7c83.
Nov 28 2020, 4:57 AM
csigg closed D92265: [mlir] Fix bad rebase landed in acb69f3b7c83..
Nov 28 2020, 4:57 AM · Restricted Project
csigg requested review of D92265: [mlir] Fix bad rebase landed in acb69f3b7c83..
Nov 28 2020, 4:56 AM · Restricted Project
csigg committed rGacb69f3b7c83: [mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete… (authored by csigg).
[mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete…
Nov 28 2020, 4:09 AM
csigg closed D92111: [mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete operand type..
Nov 28 2020, 4:09 AM · Restricted Project

Nov 27 2020

csigg updated the diff for D92111: [mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete operand type..

Undo matchAndRewriter -> rewrite.

Nov 27 2020, 12:10 PM · Restricted Project
csigg added a comment to D92111: [mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete operand type..

If you have time, maybe we can also consider passing in a SourceOp::Adaptor instead of raw operands?

Nov 27 2020, 11:58 AM · Restricted Project
csigg updated the diff for D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..

Rest of reviewer comments.

Nov 27 2020, 5:05 AM · Restricted Project
csigg added inline comments to D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..
Nov 27 2020, 5:05 AM · Restricted Project
csigg updated the diff for D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..

Apply reviewer comments and adjust to latest async dialect changes.

Nov 27 2020, 4:49 AM · Restricted Project
csigg added a comment to D92111: [mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete operand type..

Thanks Stephan for the review. These comments are all good points. This change is primarily about changing the interface. I would prefer to do the clean up in follow-up changes, which can be done in smaller chunks.

Nov 27 2020, 12:52 AM · Restricted Project
csigg committed rG5535696c386b: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime… (authored by csigg).
[mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime…
Nov 27 2020, 12:41 AM
csigg closed D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..
Nov 27 2020, 12:41 AM · Restricted Project

Nov 25 2020

csigg requested review of D92111: [mlir] Change ConvertOpToLLVMPattern::matchAndRewrite argument to concrete operand type..
Nov 25 2020, 9:47 AM · Restricted Project

Nov 24 2020

csigg added inline comments to D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..
Nov 24 2020, 1:09 PM · Restricted Project
csigg updated the diff for D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..

Thanks for the review!

Nov 24 2020, 1:08 PM · Restricted Project

Nov 18 2020

csigg requested review of D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..
Nov 18 2020, 4:26 AM · Restricted Project
csigg committed rG8b97e17d161a: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr(). (authored by csigg).
[mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr().
Nov 18 2020, 2:52 AM
csigg closed D91599: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr()..
Nov 18 2020, 2:52 AM · Restricted Project

Nov 17 2020

csigg updated the diff for D91599: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr()..

Rebase.

Nov 17 2020, 10:23 AM · Restricted Project
csigg committed rGbedaad44953a: [mlir] Simplify std.alloc lowering to LLVM. (authored by csigg).
[mlir] Simplify std.alloc lowering to LLVM.
Nov 17 2020, 9:56 AM
csigg closed D91549: [mlir] Simplify std.alloc lowering to LLVM..
Nov 17 2020, 9:55 AM · Restricted Project
csigg added inline comments to D91549: [mlir] Simplify std.alloc lowering to LLVM..
Nov 17 2020, 9:02 AM · Restricted Project
csigg updated the diff for D91549: [mlir] Simplify std.alloc lowering to LLVM..

Extend documentation.

Nov 17 2020, 9:02 AM · Restricted Project
csigg committed rG43ede0e2a7ff: [mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts(). (authored by csigg).
[mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts().
Nov 17 2020, 8:26 AM
csigg closed D91594: [mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts()..
Nov 17 2020, 8:25 AM · Restricted Project
csigg requested review of D91599: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr()..
Nov 17 2020, 1:23 AM · Restricted Project