Page MenuHomePhabricator
Feed Advanced Search

Aug 19 2017

vleschuk committed rL311262: Set init value for ScalarEvolution::BackedgeTakenInfo::MaxOrZero.
Set init value for ScalarEvolution::BackedgeTakenInfo::MaxOrZero
Aug 19 2017, 2:06 PM
vleschuk committed rL311238: revert failing test.
revert failing test
Aug 19 2017, 5:25 AM
vleschuk committed rL311236: Add temporary test to verify that win10 builder hangs on error.
Add temporary test to verify that win10 builder hangs on error
Aug 19 2017, 5:03 AM
vleschuk committed rL311230: Temporary mark lit :: shtest-format as unsupported on windows.
Temporary mark lit :: shtest-format as unsupported on windows
Aug 19 2017, 1:00 AM

Aug 18 2017

vleschuk committed rL311149: Remove useless default case in switch.
Remove useless default case in switch
Aug 18 2017, 2:03 AM

Aug 17 2017

vleschuk committed rL311089: Mark Verifier/invalid-eh.ll as unsupported on windows.
Mark Verifier/invalid-eh.ll as unsupported on windows
Aug 17 2017, 8:10 AM

Aug 15 2017

vleschuk accepted D36730: [buildbot] Raise the test-suite runtime limit for the avx512-sde builder..

LGTM

Aug 15 2017, 3:13 AM

Aug 14 2017

vleschuk accepted rL310833: Another attempt to fix the env issue for the avx512-sde bot.

LGTM

Aug 14 2017, 6:53 AM

Aug 3 2017

vleschuk committed rL310021: Un-revert r310014: false revert, it wasn't the cause of build break.
Un-revert r310014: false revert, it wasn't the cause of build break
Aug 3 2017, 9:52 PM
vleschuk committed rL310020: Revert r310014 as it breaks build lld-x86_64-darwin13.
Revert r310014 as it breaks build lld-x86_64-darwin13
Aug 3 2017, 9:44 PM
vleschuk accepted D36263: [lit] check-lit compatibility with multi-config CMake generators.
Aug 3 2017, 5:09 AM
vleschuk added a comment to D36263: [lit] check-lit compatibility with multi-config CMake generators.

LGTM

Aug 3 2017, 5:08 AM

Aug 2 2017

vleschuk added a comment to D36212: [lit] Use Visual Studio build config when testing.

Yup, I've tried reverting D36026 locally, and after doing so check-lit no longer dirties my source tree. I'll comment there with next steps. IMHO reverting and then applying the changes you suggested might be a good way to go!

Aug 2 2017, 8:58 PM
vleschuk added inline comments to D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 2 2017, 8:54 PM

Aug 1 2017

vleschuk added inline comments to D36203: [zorg] Add buildbot with reverse iteration enabled.
Aug 1 2017, 9:30 PM

Jul 31 2017

vleschuk added a comment to rL309576: Exclude more unused functions from release build..

Looks like this fixes the broken build and should be closed.

Jul 31 2017, 10:11 AM

Jul 29 2017

vleschuk committed rL309484: Fix incorrect assertion condition..
Fix incorrect assertion condition.
Jul 29 2017, 1:19 AM

Mar 1 2017

vleschuk closed D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.

r296691

Mar 1 2017, 2:27 PM
vleschuk committed rL296691: [DebugInfo] [DWARFv5] Unique abbrevs for DIEs with different implicit_const….
[DebugInfo] [DWARFv5] Unique abbrevs for DIEs with different implicit_const…
Mar 1 2017, 2:25 PM
vleschuk added inline comments to D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.
Mar 1 2017, 1:24 PM
vleschuk updated the diff for D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.

Extended test to verify that two DIEs with equal values refer to the same abbrev, and third DIE with another value refers to another abbrev.

Mar 1 2017, 1:23 PM
vleschuk updated the diff for D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.
  • Discarded changes in dwarfgen API
  • Modified test: verify generated DWARF abbrevs using MemoryBuffer and verify dump format using raw_string_ostream
  • Small style changes:

change

DW_FORM_implicit_const == getForm()

to

getForm() == DW_FORM_implicit_const
Mar 1 2017, 6:29 AM

Feb 28 2017

vleschuk added inline comments to D30448: [DebugInfo] Show implicit_const values when dumping .debug_info section.
Feb 28 2017, 9:39 AM
vleschuk added inline comments to D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.
Feb 28 2017, 9:26 AM
vleschuk added a child revision for D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values: D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen.
Feb 28 2017, 6:03 AM
vleschuk added a parent revision for D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen: D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.
Feb 28 2017, 6:03 AM
vleschuk added a child revision for D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values: D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types.
Feb 28 2017, 6:02 AM
vleschuk added a parent revision for D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types: D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.
Feb 28 2017, 6:02 AM
vleschuk created D30456: [DebugInfo] Unique abbrevs for DIEs with different implicit_const values.
Feb 28 2017, 6:00 AM
vleschuk added a parent revision for D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types: D30448: [DebugInfo] Show implicit_const values when dumping .debug_info section.
Feb 28 2017, 12:56 AM
vleschuk added a child revision for D30448: [DebugInfo] Show implicit_const values when dumping .debug_info section: D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types.
Feb 28 2017, 12:56 AM
vleschuk created D30448: [DebugInfo] Show implicit_const values when dumping .debug_info section.
Feb 28 2017, 12:54 AM

Feb 27 2017

vleschuk added inline comments to D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen.
Feb 27 2017, 11:31 AM

Feb 25 2017

vleschuk added a parent revision for D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen: D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types.
Feb 25 2017, 7:29 AM
vleschuk added a child revision for D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types: D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen.
Feb 25 2017, 7:29 AM
vleschuk created D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen.
Feb 25 2017, 7:29 AM
vleschuk created D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types.
Feb 25 2017, 7:26 AM
vleschuk committed rL296253: [DebugInfo] Skip implicit_const attributes when dumping .debug_info. NFC..
[DebugInfo] Skip implicit_const attributes when dumping .debug_info. NFC.
Feb 25 2017, 5:27 AM

Jan 10 2017

vleschuk committed rL291601: Correct object file for implicit const test.
Correct object file for implicit const test
Jan 10 2017, 1:41 PM
vleschuk committed rL291599: DebugInfo: support for DW_FORM_implicit_const.
DebugInfo: support for DW_FORM_implicit_const
Jan 10 2017, 1:29 PM
vleschuk closed D28456: DebugInfo: support for DW_FORM_implicit_const by committing rL291599: DebugInfo: support for DW_FORM_implicit_const.
Jan 10 2017, 1:29 PM
vleschuk updated the diff for D28456: DebugInfo: support for DW_FORM_implicit_const.
  • Classify DW_FORM_implicit_const as DWARFFormValue::FC_Constant
  • Get rid of unnecessary assert()
Jan 10 2017, 3:02 AM

Jan 9 2017

vleschuk updated the diff for D28456: DebugInfo: support for DW_FORM_implicit_const.
  • DWARFAbbreviationDeclaration::AttributeSpec struct now uses 1 64bit field for both ByteSize and implicit const attribute value (depends on Form == DW_FORM_implicit_const).
  • Fixed few mistypes and reordered switch statements to be more logical.
Jan 9 2017, 10:54 PM
vleschuk added inline comments to D28456: DebugInfo: support for DW_FORM_implicit_const.
Jan 9 2017, 11:30 AM

Jan 8 2017

vleschuk updated the diff for D28456: DebugInfo: support for DW_FORM_implicit_const.

Fix mistype in unittest.

Jan 8 2017, 1:59 PM

Jan 7 2017

vleschuk retitled D28456: DebugInfo: support for DW_FORM_implicit_const from to DebugInfo: support for DW_FORM_implicit_const.
Jan 7 2017, 11:43 PM

Oct 31 2016

vleschuk committed rL285625: DebugInfo: support for DW_TAG_atomic_type.
DebugInfo: support for DW_TAG_atomic_type
Oct 31 2016, 12:19 PM
vleschuk closed D26145: DebugInfo: support for DW_TAG_atomic_type by committing rL285625: DebugInfo: support for DW_TAG_atomic_type.
Oct 31 2016, 12:19 PM
vleschuk committed rL285624: DebugInfo: make DW_TAG_atomic_type valid.
DebugInfo: make DW_TAG_atomic_type valid
Oct 31 2016, 12:19 PM
vleschuk closed D26144: DebugInfo: make DW_TAG_atomic_type valid by committing rL285624: DebugInfo: make DW_TAG_atomic_type valid.
Oct 31 2016, 12:19 PM
vleschuk added a child revision for D26144: DebugInfo: make DW_TAG_atomic_type valid: D26145: DebugInfo: support for DW_TAG_atomic_type.
Oct 31 2016, 10:39 AM
vleschuk added a parent revision for D26145: DebugInfo: support for DW_TAG_atomic_type: D26144: DebugInfo: make DW_TAG_atomic_type valid.
Oct 31 2016, 10:39 AM
vleschuk updated the diff for D26145: DebugInfo: support for DW_TAG_atomic_type.

Made test more strict: it now checks that variable i is atomic.

Oct 31 2016, 10:24 AM
vleschuk added inline comments to D26145: DebugInfo: support for DW_TAG_atomic_type.
Oct 31 2016, 10:11 AM
vleschuk updated the diff for D26144: DebugInfo: make DW_TAG_atomic_type valid.
  • Reverted CodeView-related changes, replaced with TODO comments instead
  • Made DW_TAG_atomic_type available only with DwarfVersion >= 5 (otherwise do not emit it)
  • Updated test to match all type tree (also changed dwarf version in test IR to 5)
Oct 31 2016, 10:09 AM
vleschuk added inline comments to D26144: DebugInfo: make DW_TAG_atomic_type valid.
Oct 31 2016, 8:59 AM
vleschuk retitled D26145: DebugInfo: support for DW_TAG_atomic_type from to DebugInfo: support for DW_TAG_atomic_type.
Oct 31 2016, 5:37 AM
vleschuk retitled D26144: DebugInfo: make DW_TAG_atomic_type valid from to DebugInfo: make DW_TAG_atomic_type valid.
Oct 31 2016, 5:31 AM

Oct 26 2016

vleschuk committed rL285242: DebugInfo: fix incorrect alignment type (NFC).
DebugInfo: fix incorrect alignment type (NFC)
Oct 26 2016, 2:42 PM
vleschuk committed rL285189: DebugInfo: support for DWARFv5 DW_AT_alignment attribute.
DebugInfo: support for DWARFv5 DW_AT_alignment attribute
Oct 26 2016, 5:08 AM
vleschuk committed rL285181: DebugInfo: support for DWARFv5 DW_AT_alignment attribute.
DebugInfo: support for DWARFv5 DW_AT_alignment attribute
Oct 26 2016, 2:05 AM
vleschuk closed D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute by committing rL285181: DebugInfo: support for DWARFv5 DW_AT_alignment attribute.
Oct 26 2016, 2:04 AM
vleschuk committed rL285179: DebugInfo: add bitcode upgrade test for alignment .
DebugInfo: add bitcode upgrade test for alignment
Oct 26 2016, 1:43 AM

Oct 19 2016

vleschuk committed rL284683: Upgrade debug-info-vla test: we do not pass default alignment now.
Upgrade debug-info-vla test: we do not pass default alignment now
Oct 19 2016, 5:46 PM
vleschuk committed rL284682: DebugInfo: remove broken bitcode upgrade test.
DebugInfo: remove broken bitcode upgrade test
Oct 19 2016, 5:35 PM
vleschuk committed rL284679: DebugInfo: pass alignment value only if it was forced.
DebugInfo: pass alignment value only if it was forced
Oct 19 2016, 5:23 PM
vleschuk committed rL284678: DebugInfo: preparation to implement DW_AT_alignment.
DebugInfo: preparation to implement DW_AT_alignment
Oct 19 2016, 5:22 PM
vleschuk closed D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced by committing rL284679: DebugInfo: pass alignment value only if it was forced.
Oct 19 2016, 5:22 PM
vleschuk closed D25073: [DebugInfo]: preparation to implement DW_AT_alignment by committing rL284678: DebugInfo: preparation to implement DW_AT_alignment.
Oct 19 2016, 5:22 PM
vleschuk committed rL284651: DebugInfo: use uint32_t for alignment variables..
DebugInfo: use uint32_t for alignment variables.
Oct 19 2016, 3:20 PM
vleschuk closed D25621: DebugInfo: use uin32_t for alignment by committing rL284651: DebugInfo: use uint32_t for alignment variables..
Oct 19 2016, 3:20 PM
vleschuk added a comment to D25621: DebugInfo: use uin32_t for alignment.

This patch is conflating two set of changes:
(1) NFC: rename all occurrences of unsigned for alignment purposes in the frontend with uint32_t
(2) shrink all debug-info-related alignment variables from uint64_t -> unint32_t.

I think this patch should only be doing the changes in (2).

Oct 19 2016, 6:56 AM
vleschuk updated the diff for D25621: DebugInfo: use uin32_t for alignment.
  • Removed all changes non-related to CGDebugInfo: will post them in separate NFC patch which will switch all unsigned alignment entries to uint32_t.
Oct 19 2016, 6:55 AM

Oct 18 2016

vleschuk added a comment to D25621: DebugInfo: use uin32_t for alignment.

Can anyone take a look at this please? =)

Oct 18 2016, 3:13 PM
vleschuk committed rL284482: DebugInfo: change alignment type from uint64_t to uint32_t to save space..
DebugInfo: change alignment type from uint64_t to uint32_t to save space.
Oct 18 2016, 7:41 AM
vleschuk closed D25620: DebugInfo: use uint32_t instead of uint64_t for alignment by committing rL284482: DebugInfo: change alignment type from uint64_t to uint32_t to save space..
Oct 18 2016, 7:40 AM
vleschuk added a comment to D25620: DebugInfo: use uint32_t instead of uint64_t for alignment.

Small nitpicks inline, but otherwise this looks good to me!

Oct 18 2016, 6:52 AM

Oct 17 2016

vleschuk updated D25621: DebugInfo: use uin32_t for alignment.
Oct 17 2016, 2:02 PM
vleschuk retitled D25621: DebugInfo: use uin32_t for alignment from DebugInfo: use DIAlignment type. to DebugInfo: use uin32_t for alignment.
Oct 17 2016, 2:01 PM
vleschuk updated the diff for D25621: DebugInfo: use uin32_t for alignment.
  • Use uint32_t directly for alignment instead of creating typedef ofr it
  • Get rid of DebugInfo dependency in AST
Oct 17 2016, 2:01 PM
vleschuk updated the diff for D25620: DebugInfo: use uint32_t instead of uint64_t for alignment.
  • Use uint32_t directly instead of new typedef
  • Place uint32_t alignment member after all uint64_t members in DIType class
Oct 17 2016, 1:58 PM
vleschuk added inline comments to D25621: DebugInfo: use uin32_t for alignment.
Oct 17 2016, 9:48 AM
vleschuk added a comment to D25620: DebugInfo: use uint32_t instead of uint64_t for alignment.

After letting this sit for a few days, I think that using an unsigned (there doesn't seem to be much precedent for uint32_t) is the way to go. It's more readable than an opaque DIAlignment type (whose size isn't obvious from the name).

Oct 17 2016, 9:43 AM
vleschuk added inline comments to D25621: DebugInfo: use uin32_t for alignment.
Oct 17 2016, 4:36 AM
vleschuk added a comment to D25620: DebugInfo: use uint32_t instead of uint64_t for alignment.

I support this.

One question: What happens when we read bitcode that contains an alignment field with a value larger > 2^32?
Does the bitcode reader throw an error? Do we even care to support a non-breaking upgrade path for this?

Oct 17 2016, 4:01 AM
vleschuk added inline comments to D25620: DebugInfo: use uint32_t instead of uint64_t for alignment.
Oct 17 2016, 3:17 AM

Oct 14 2016

vleschuk updated the diff for D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute.
  • Use DIAlignment type instead of uint64_t for alignment in DebugInfo
Oct 14 2016, 7:44 AM
vleschuk updated the diff for D25073: [DebugInfo]: preparation to implement DW_AT_alignment.
  • Use DIAlignment type instead of uin64_t
  • Fix mistype in comment
  • HasAlignmentFlag in BitcodeReader is now not static
Oct 14 2016, 7:42 AM
vleschuk updated the diff for D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced.

Use DIAlignment type instead of uint64_t for alignment in DebugInfo.

Oct 14 2016, 7:39 AM
vleschuk added a child revision for D25621: DebugInfo: use uin32_t for alignment: D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced.
Oct 14 2016, 7:38 AM
vleschuk added a parent revision for D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced: D25621: DebugInfo: use uin32_t for alignment.
Oct 14 2016, 7:38 AM
vleschuk retitled D25621: DebugInfo: use uin32_t for alignment from to DebugInfo: use DIAlignment type..
Oct 14 2016, 7:38 AM
vleschuk added a parent revision for D25073: [DebugInfo]: preparation to implement DW_AT_alignment: D25620: DebugInfo: use uint32_t instead of uint64_t for alignment.
Oct 14 2016, 7:36 AM
vleschuk added a child revision for D25620: DebugInfo: use uint32_t instead of uint64_t for alignment: D25073: [DebugInfo]: preparation to implement DW_AT_alignment.
Oct 14 2016, 7:36 AM
vleschuk retitled D25620: DebugInfo: use uint32_t instead of uint64_t for alignment from to DebugInfo: introduce DIAlignment type.
Oct 14 2016, 7:35 AM

Oct 10 2016

vleschuk updated the diff for D25073: [DebugInfo]: preparation to implement DW_AT_alignment.
  • Fix indentation in comment.
Oct 10 2016, 1:39 PM
vleschuk added inline comments to D25073: [DebugInfo]: preparation to implement DW_AT_alignment.
Oct 10 2016, 1:31 PM
vleschuk updated the diff for D25073: [DebugInfo]: preparation to implement DW_AT_alignment.
  • Fixed the comment for DILocalVariable in BitcodeWriter to be more self-descriptive.
Oct 10 2016, 1:31 PM
vleschuk updated the diff for D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute.
  • Fix mistype in SourceLevelDebugging.rst (attribute() -> attribute__()).
Oct 10 2016, 2:55 AM
vleschuk added inline comments to D24425: DebugInfo: support for DWARFv5 DW_AT_alignment attribute.
Oct 10 2016, 2:54 AM