Just finished testing, seems OK with latest submitted version
Nov 15 2017
Sorry, I forgot to test it with all of the backends. Now changed failing tests as they did not support many remarks at once.
Though I haven't checked all the tests yet since I am still waiting for the local build to finish.
Nov 14 2017
Thanks for your time, anemet. I've just fixed these issues you told.
Can you please commit this patch? I haven't got r+w access.
Fixed minor issues
Nov 13 2017
Nov 3 2017
Moved the code of one remark under the closure
Also by any chance, did you run this on some real code base? Some of these may trigger quite a bit and I want to make sure they are not on the top of the list. You can use opt-viewer/opt-stats.py to get a sense how frequently your remark is generated.
Reworked with closure API
Fixed code style, reworked tests to check YAML output
Sep 28 2017
Thanks for your patch! Please include the full context for the diff and add llvm-commits as subscriber; that should be done when creating the review, otherwise the mailing list does not get the complete picture. See http://llvm.org/docs/Phabricator.html for more details.
Please start a new review cc'ing llvm-commit (from the get-go).
Fixed code style, reworked tests completely. Uploaded diffs with context now.