Page MenuHomePhabricator
Feed Advanced Search

Jan 25 2021

kevans added a comment to D95370: [ELF] Infer OSABI from input files for -m options without explicit OSABI.

@bsdjhb has been intending to fix ldd to recognise the ELF note rather than requiring the OSABI be FreeBSD. The only reason to set the OSABI to FreeBSD is so that the various FOO_LOOS-FOO_HIOS can be interpreted correctly.

Jan 25 2021, 8:51 AMRestricted Project

Jul 2 2020

kevans removed a reviewer for D82786: [llvm-ar] Unsupport test on FreeBSD: kevans91.
Jul 2 2020, 5:17 PMRestricted Project
kevans updated subscribers of D82786: [llvm-ar] Unsupport test on FreeBSD.

We're just waiting on someone with access with a FreeBSD system to confirm this works before pushing this.

Jul 2 2020, 5:17 PMRestricted Project

Jun 29 2020

kevans added a comment to D80838: [llvm-ar] Add more tests for errors in opening archives.

Seems like FreeBSD allows for reading directories. In that case would the issue be resolved in case I add the following line to the test:
# UNSUPPORTED: system-freebsd

or perhaps

# XFAIL: system-freebsd

I'll update the test accordingly then. Thanks a lot!

# UNSUPPORTED would be the right approach - I don't think the FreeBSD behaviour is something we're likely to "fix" either in FreeBSD or llvm-ar so that the test will pass. I don't know if freebsd is a "system" that can easily be identified though.

Jun 29 2020, 11:21 AMRestricted Project
kevans added a comment to D82786: [llvm-ar] Unsupport test on FreeBSD.

Hi everyone, sorry I am a little confused by the comments 馃様 What exactly should I be doing? For reference, the issue was reported for the diff D80838. Thanks!

Jun 29 2020, 11:21 AMRestricted Project
kevans added a comment to D82786: [llvm-ar] Unsupport test on FreeBSD.

This depends on the underlying file system and FreeBSD version. However, I guess marking it as unsupported is the simplest solution to avoid test failures.

Jun 29 2020, 10:48 AMRestricted Project

May 2 2020

kevans updated the diff for D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.

Sure; I have no strong preference.

May 2 2020, 8:27 AMRestricted Project

May 1 2020

kevans created D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches.
May 1 2020, 5:08 PMRestricted Project

Dec 16 2019

kevans added inline comments to D71101: [lld][RISCV] Use an e_flags of 0 if there are only binary input files..
Dec 16 2019, 8:54 PMRestricted Project