Page MenuHomePhabricator
Feed Advanced Search

Wed, May 5

oontvoo accepted D101954: [lld-macho] Support loading of zippered dylibs.
Wed, May 5, 8:05 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D101954: [lld-macho] Support loading of zippered dylibs.
Wed, May 5, 4:11 PM · Restricted Project, Restricted Project
oontvoo committed rG23233ad139f4: [lld-macho] Check simulator platforms to avoid issuing false positive errors. (authored by oontvoo).
[lld-macho] Check simulator platforms to avoid issuing false positive errors.
Wed, May 5, 3:09 PM
oontvoo closed D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Wed, May 5, 3:08 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Wed, May 5, 2:59 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..

increase version in test to preseve "simulator" + use removeSimulator() approach

Wed, May 5, 2:59 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..

-o /dev/null

Wed, May 5, 2:42 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Wed, May 5, 2:40 PM · Restricted Project, Restricted Project
oontvoo accepted D101224: [lld-macho] Have --reproduce account for path rerooting.

LGTM

Wed, May 5, 9:42 AM · Restricted Project, Restricted Project

Tue, May 4

oontvoo added inline comments to D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Tue, May 4, 5:42 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..

add more tests

Tue, May 4, 5:42 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..

comment

Tue, May 4, 3:20 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Tue, May 4, 3:20 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..

cleanup

Tue, May 4, 3:18 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Tue, May 4, 3:10 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..

added some tests

Tue, May 4, 3:06 PM · Restricted Project, Restricted Project
oontvoo updated the summary of D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Tue, May 4, 1:25 PM · Restricted Project, Restricted Project
oontvoo requested review of D101855: [lld-macho] Check simulator platforms to avoid issuing false positive errors..
Tue, May 4, 1:25 PM · Restricted Project, Restricted Project

Fri, Apr 23

oontvoo accepted D101175: [lld-macho] Fix use-after-free in loadDylib().

LGTM - good catch! Is there not any sanitizers build that would've caught this?

Fri, Apr 23, 9:18 AM · Restricted Project, Restricted Project

Thu, Apr 22

oontvoo accepted D101119: [lld-macho] Have tests default to targeting macos 10.15.

Thanks!

Thu, Apr 22, 6:02 PM · Restricted Project, Restricted Project
oontvoo added a comment to D101072: [lld] reformat multi-line error messages in source code.

Hm, I'd prefer not to have to see spurious clang-format messages.

It also means that I can't just clang-format -i the entire directory any more. I know there's clang-format-diff, but sometimes cleaning up the whole directory is what's needed...

How about introducing a multilineError function that takes multiple string parameters instead and adds the appropriate \n and >>> bits?

Thu, Apr 22, 2:37 PM · Restricted Project

Mon, Apr 12

oontvoo accepted D100357: [lld-macho] Have toString() emit full path to archive files.
Mon, Apr 12, 6:30 PM · Restricted Project, Restricted Project

Apr 8 2021

oontvoo added inline comments to D100011: [lld-macho] Make time-trace* options more permissive..
Apr 8 2021, 11:37 AM · Restricted Project, Restricted Project

Apr 7 2021

oontvoo accepted D100082: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols.

LGTM

Apr 7 2021, 7:40 PM · Restricted Project, Restricted Project
oontvoo committed rGdb851dfb4958: [lld-macho] Make time-trace* options more permissive. (authored by oontvoo).
[lld-macho] Make time-trace* options more permissive.
Apr 7 2021, 1:01 PM
oontvoo closed D100011: [lld-macho] Make time-trace* options more permissive..
Apr 7 2021, 1:00 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D100011: [lld-macho] Make time-trace* options more permissive..

updated diff

Apr 7 2021, 12:38 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D100011: [lld-macho] Make time-trace* options more permissive..
Apr 7 2021, 12:38 PM · Restricted Project, Restricted Project
oontvoo committed rGffc65824f0ee: [lld-macho][nfc] Minor refactoring + clang-tidy fixes (authored by oontvoo).
[lld-macho][nfc] Minor refactoring + clang-tidy fixes
Apr 7 2021, 10:58 AM
oontvoo closed D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
Apr 7 2021, 10:58 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
Apr 7 2021, 10:57 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.

rebase

Apr 7 2021, 10:56 AM · Restricted Project, Restricted Project
oontvoo added a comment to D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.

I actually snuck in a clang-format cleanup yesterday :) https://github.com/llvm/llvm-project/commit/174deb0539ee4af7d20bfead9f73055782e878e3 (so just update the commit title I guess)

Apr 7 2021, 9:53 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.

removed unnecessary braces

Apr 7 2021, 9:53 AM · Restricted Project, Restricted Project

Apr 6 2021

oontvoo requested review of D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
Apr 6 2021, 10:53 PM · Restricted Project, Restricted Project
oontvoo requested review of D100011: [lld-macho] Make time-trace* options more permissive..
Apr 6 2021, 8:46 PM · Restricted Project, Restricted Project
oontvoo accepted D99874: [lld-macho][nfc] Remove HelpHidden from aliases to implemented flags.

LGTM

Apr 6 2021, 11:11 AM · Restricted Project, Restricted Project

Apr 3 2021

oontvoo accepted D99807: [lld-macho][nfc] Rename some tests.

LGTM!

Apr 3 2021, 11:15 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D99385: [lld-macho] Add addition debug info.

updated diff:

  • stop excluding debug sessions from reloc-parsing (cos we need the info)
  • added some test
Apr 3 2021, 11:13 AM · Restricted Project, Restricted Project

Apr 2 2021

oontvoo accepted D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.

LGTM = stamp? :)

Apr 2 2021, 11:07 AM · Restricted Project, Restricted Project
oontvoo added a comment to D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.

LGTM!

Apr 2 2021, 9:45 AM · Restricted Project, Restricted Project

Apr 1 2021

oontvoo planned changes to D99385: [lld-macho] Add addition debug info.
Apr 1 2021, 10:10 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.
Apr 1 2021, 9:15 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.
Apr 1 2021, 8:20 AM · Restricted Project, Restricted Project

Mar 30 2021

oontvoo accepted D99279: [lld-macho] Parallelize UUID hash computation.

LGTM

Mar 30 2021, 10:13 AM · Restricted Project, Restricted Project
oontvoo accepted D99215: [lld-macho][nfc] Test that -ObjC will import bitcode with category sections.

Looks fairly straightforward to me

Mar 30 2021, 9:30 AM · Restricted Project, Restricted Project

Mar 29 2021

oontvoo accepted D99389: [lld-macho] Implement -segprot.
Mar 29 2021, 11:05 AM · Restricted Project, Restricted Project
oontvoo accepted D99389: [lld-macho] Implement -segprot.
Mar 29 2021, 10:09 AM · Restricted Project, Restricted Project

Mar 25 2021

oontvoo added a comment to D99385: [lld-macho] Add addition debug info.

This is for https://bugs.llvm.org/show_bug.cgi?id=49282 right? For testing you could create a file with an undefined symbol. See e.g. test/ELF/undef.s.

Yeah. Thanks

Mar 25 2021, 3:52 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D99385: [lld-macho] Add addition debug info.

updated diff to include the whole patch

Mar 25 2021, 3:50 PM · Restricted Project, Restricted Project
oontvoo added a comment to D99385: [lld-macho] Add addition debug info.

@int3: not sure how to write a good test for this ?

Mar 25 2021, 3:10 PM · Restricted Project, Restricted Project
oontvoo requested review of D99385: [lld-macho] Add addition debug info.
Mar 25 2021, 3:10 PM · Restricted Project, Restricted Project
oontvoo closed D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Mar 25 2021, 1:48 PM · Restricted Project, Restricted Project
oontvoo committed rGdee5787d3ee5: Reland [lld-macho][nfc] minor clean up, follow up to D98559 (authored by oontvoo).
Reland [lld-macho][nfc] minor clean up, follow up to D98559
Mar 25 2021, 1:47 PM
oontvoo added a reverting change for rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559": rGdee5787d3ee5: Reland [lld-macho][nfc] minor clean up, follow up to D98559.
Mar 25 2021, 1:47 PM
oontvoo committed rGe2f34cc330e2: [lld-macho][nfc] Removed unnecessary static_cast (authored by oontvoo).
[lld-macho][nfc] Removed unnecessary static_cast
Mar 25 2021, 12:08 PM
oontvoo closed D99365: [lld-macho][nfc] Removed unnecessary static_cast.
Mar 25 2021, 12:08 PM · Restricted Project, Restricted Project
oontvoo requested review of D99365: [lld-macho][nfc] Removed unnecessary static_cast.
Mar 25 2021, 12:01 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D99210: [lld-macho][nfc] minor clean up, follow up to D98559.

updated diff

Mar 25 2021, 11:37 AM · Restricted Project, Restricted Project
oontvoo accepted D99311: [lld-macho] Add more TimeTraceScopes.

The detailed graph looks nice! Thanks!

Mar 25 2021, 11:08 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D99311: [lld-macho] Add more TimeTraceScopes.
Mar 25 2021, 10:06 AM · Restricted Project, Restricted Project
oontvoo accepted D99318: [lld-macho] Add time tracing for LTO.

Cool!

Mar 25 2021, 9:59 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D99210: [lld-macho][nfc] minor clean up, follow up to D98559.

rebase

Mar 25 2021, 8:26 AM · Restricted Project, Restricted Project

Mar 24 2021

oontvoo committed rGd988ffc34fcb: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory. (authored by oontvoo).
[lld-macho][nfc] Fixed test so it output to %t/ rather than current directory.
Mar 24 2021, 1:56 PM
oontvoo closed D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..
Mar 24 2021, 1:56 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..

updated diff

Mar 24 2021, 12:55 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..
Mar 24 2021, 12:55 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D99279: [lld-macho] Parallelize UUID hash computation.
Mar 24 2021, 12:49 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D99279: [lld-macho] Parallelize UUID hash computation.
Mar 24 2021, 10:52 AM · Restricted Project, Restricted Project
oontvoo requested review of D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..
Mar 24 2021, 8:50 AM · Restricted Project, Restricted Project

Mar 23 2021

oontvoo updated the diff for D99210: [lld-macho][nfc] minor clean up, follow up to D98559.

Updated path-expectations to accept both backslash and forwardslash.

Mar 23 2021, 8:00 PM · Restricted Project, Restricted Project
oontvoo reopened D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Mar 23 2021, 7:59 PM · Restricted Project, Restricted Project
oontvoo added a comment to D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. On Fuchsia, it's called Fuchsia LLD.

@smeenai Thanks for the fix!

Mar 23 2021, 4:44 PM · Restricted Project, Restricted Project
oontvoo committed rGaa6e4cdd7300: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. (authored by oontvoo).
[lld-macho] Fixed lld-version expectation in test so it works on Fuchsia.
Mar 23 2021, 2:57 PM
oontvoo closed D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. On Fuchsia, it's called Fuchsia LLD.
Mar 23 2021, 2:56 PM · Restricted Project, Restricted Project
oontvoo requested review of D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. On Fuchsia, it's called Fuchsia LLD.
Mar 23 2021, 2:52 PM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG1bc33eb6a32b: [lld-macho][nfc] minor clean up, follow up to D98559: rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559".
Mar 23 2021, 2:16 PM
oontvoo committed rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559" (authored by oontvoo).
Revert "[lld-macho][nfc] minor clean up, follow up to D98559"
Mar 23 2021, 2:16 PM
oontvoo added a reverting change for D99210: [lld-macho][nfc] minor clean up, follow up to D98559: rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559".
Mar 23 2021, 2:16 PM · Restricted Project, Restricted Project
oontvoo committed rG1bc33eb6a32b: [lld-macho][nfc] minor clean up, follow up to D98559 (authored by oontvoo).
[lld-macho][nfc] minor clean up, follow up to D98559
Mar 23 2021, 1:13 PM
oontvoo closed D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Mar 23 2021, 1:13 PM · Restricted Project, Restricted Project
oontvoo added a comment to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

I've sent D99210

Mar 23 2021, 12:55 PM · Restricted Project, Restricted Project
oontvoo requested review of D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Mar 23 2021, 12:55 PM · Restricted Project, Restricted Project
oontvoo closed D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Mar 23 2021, 11:54 AM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG4876ba5b2d6a: Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info…: rGf499b932bfc4: Revert "Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement….
Mar 23 2021, 11:51 AM
oontvoo committed rGf499b932bfc4: Revert "Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement… (authored by oontvoo).
Revert "Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement…
Mar 23 2021, 11:51 AM
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

Updated diff. rebase.

Mar 23 2021, 9:54 AM · Restricted Project, Restricted Project

Mar 22 2021

oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

Updated diff: explicitly specified "signed char" to avoid ambiguity

Mar 22 2021, 8:26 PM · Restricted Project, Restricted Project
oontvoo added a comment to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

Thanks for the revert! May be this patch is cursed 😕

Mar 22 2021, 8:25 PM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG9670d2e4af4c: Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially…: rG3c21166a94ea: Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info….
Mar 22 2021, 4:35 PM
oontvoo committed rG3c21166a94ea: Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info… (authored by oontvoo).
Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info…
Mar 22 2021, 4:35 PM
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Mar 22 2021, 2:06 PM · Restricted Project, Restricted Project
oontvoo planned changes to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

bot still unhappy ... reverting again: https://reviews.llvm.org/rG9670d2e4af4c996098089e31b03ca138bc8d27e9

Mar 22 2021, 11:55 AM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG5ad2c225f353: Revert "Revert "[lld-macho] Implement -dependency_info (partially - more…: rG9670d2e4af4c: Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially….
Mar 22 2021, 11:54 AM
oontvoo committed rG9670d2e4af4c: Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially… (authored by oontvoo).
Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially…
Mar 22 2021, 11:54 AM
oontvoo added a reverting change for rG2554b95db57c: Revert "[lld-macho] Implement -dependency_info (partially - more opcodes…: rG5ad2c225f353: Revert "Revert "[lld-macho] Implement -dependency_info (partially - more….
Mar 22 2021, 11:42 AM
oontvoo committed rG5ad2c225f353: Revert "Revert "[lld-macho] Implement -dependency_info (partially - more… (authored by oontvoo).
Revert "Revert "[lld-macho] Implement -dependency_info (partially - more…
Mar 22 2021, 11:42 AM
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

updated diff

Mar 22 2021, 11:41 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Mar 22 2021, 11:04 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

moved inline functions to header

Mar 22 2021, 10:20 AM · Restricted Project, Restricted Project