Anyone have any remaining thoughts?
Mon, Aug 12
Mon, Aug 5
wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!
- Run a pep8 formatter.
- Address other comments from code review.
Thu, Aug 1
Jul 13 2019
From the failure mode I was seeing, any value at all for VERSION will be fine, as long as it is a valid preprocessor string.
Jul 12 2019
The revert is at https://reviews.llvm.org/D64687, which I will commit shortly if there are no objections.
This revision breaks python 2.7.16 builds, which are still supported by upstream python for a few more months. I'm preparing a revert.
After this revision lib/Transforms/Scalar/IndVarSimplify.cpp:2630 defines "Latch" which is only used inside an assert. This makes builds with -DNDEBUG fail with unused variable warnings.
Jul 10 2019
Committed as r365713.
Remove other forward declaration also in the added header.
Jul 9 2019
This revision violates some rules about the build structure.
Jun 10 2019
I am absolutely not the right person to review the math. I think we need to trust that the author has it correct. The logic looks reasonable and the tests look basically thorough. I am inclined to accept it.
May 30 2019
The number is the argument count plus one for return value. So this function should be named
I can't speak to how useful this would be and for whom, but I'm not opposed to including it if Fuschia has a use for it.
May 21 2019
May 13 2019
May 10 2019
Any of the previous reviewers have a comment before I commit?
May 9 2019
- Make LIBUNWIND_WEAK_PTHREAD a formal Cmake option.
May 8 2019
I've now put the weak-reference version behind a non-default build option. Is this acceptable?
- Add an option to make pthread symbol references weak.
Apr 23 2019
Hi Nick--hope your vacation was good.
Apr 15 2019
Nick, what do you think about adding weak symbols just for achieving this?
Apr 9 2019
Apr 5 2019
This is better than a no-op RWMutex because then the same binary works both when the application is multi-threaded and when it isn't. Therefore the build doesn't have to distinguish between the two cases.
Apr 4 2019
Mar 26 2019
Mar 21 2019
Mar 20 2019
Thanks. I've hidden a couple more symbols Please take another look.
Make cpu_model a hidden symbol, to match libgcc.
Also cpu_features2 and __cpu_indicator_init.
- Also hide __cpu_inicator_init for similar reasons.
Mar 19 2019
Mar 18 2019
I have now switched it to use --unwindlib=[libgcc|libunwind]
- Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
- Change option argument --unwindlib= from "compiler-rt" to "libunwind".
- Fix tests syntax and driver checks for --unwindlib=
- Undo cpu model change.
Mar 14 2019
This looks correct to me, thanks for the fix.
Mar 13 2019
rsmith: Do you have any comments on the naming here?
Mar 11 2019
Mar 8 2019
Mar 7 2019
Feb 20 2019
Jan 29 2019
This was rolled back with r352524. I'll work out something better.
Sorry for the breakage everyone, I'm preparing a rollback now.
Jan 28 2019
Jan 25 2019
- Correct help text for --unwindlib options.
Jan 23 2019
Jan 10 2019
Committed with r350900.
Nov 28 2018
Nov 26 2018
Committed as r347614.
Add a test case.