Page MenuHomePhabricator
Feed Advanced Search

Sep 21 2018

tromey added a comment to D52340: Ensure that variant part discriminator is read by MetadataLoader.

Could someone please land this for me? Thank you.

Sep 21 2018, 4:59 AM

Sep 20 2018

tromey added a reviewer for D52340: Ensure that variant part discriminator is read by MetadataLoader: aprantl.
Sep 20 2018, 10:16 PM
tromey created D52340: Ensure that variant part discriminator is read by MetadataLoader.
Sep 20 2018, 10:16 PM

May 31 2018

tromey added a comment to D47481: Initialize FunctionCaller::m_struct_valid.

I don't have write access so someone will have to land this for me. Thanks.

May 31 2018, 12:33 PM
tromey added a reviewer for D47481: Initialize FunctionCaller::m_struct_valid: clayborg.
May 31 2018, 8:15 AM

May 29 2018

tromey updated subscribers of D47481: Initialize FunctionCaller::m_struct_valid.
May 29 2018, 8:13 AM
tromey created D47481: Initialize FunctionCaller::m_struct_valid.
May 29 2018, 8:12 AM

May 16 2018

tromey added a comment to D46885: Remove append parameter to FindGlobalVariables.

I don't have commit access, so could someone please land this for me?

May 16 2018, 6:48 AM

May 15 2018

tromey updated subscribers of D46885: Remove append parameter to FindGlobalVariables.
May 15 2018, 8:58 AM
tromey created D46885: Remove append parameter to FindGlobalVariables.
May 15 2018, 8:56 AM

Mar 29 2018

tromey added a comment to D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &).

Can you add this to the patch for the rust plug-in then?

Mar 29 2018, 10:48 AM
tromey added a comment to D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &).

I only found this because I tried to use it in my rust plugin. So, I would rather implement it, because if I removed it, I would have to find a new way to do this.

Mar 29 2018, 10:16 AM
tromey added a comment to D44907: Remove Scalar::Cast.

@tromey thanks! do you need somebody to commit this for you?

Mar 29 2018, 10:16 AM
tromey added a reviewer for D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &): clayborg.
Mar 29 2018, 9:12 AM
tromey added a reviewer for D44907: Remove Scalar::Cast: clayborg.
Mar 29 2018, 9:12 AM

Mar 26 2018

tromey updated subscribers of D44907: Remove Scalar::Cast.
Mar 26 2018, 1:10 PM
tromey created D44907: Remove Scalar::Cast.
Mar 26 2018, 1:10 PM

Mar 23 2018

tromey added a comment to D44693: Correctly handle float division in Scalar.

LGTM, thanks. Do you have commit access or you need somebody to commit this on your behalf?

Mar 23 2018, 11:48 AM
tromey updated the diff for D44693: Correctly handle float division in Scalar.

Add unit test

Mar 23 2018, 11:10 AM

Mar 21 2018

tromey updated subscribers of D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &).
Mar 21 2018, 12:57 PM
tromey created D44752: Implement TypeAndOrName::TypeAndOrName(const CompilerType &).
Mar 21 2018, 12:50 PM
tromey added a comment to D44693: Correctly handle float division in Scalar.

I've also noticed that int->float conversion in Scalar seems incorrect. At least, Scalar.h claims that Scalar follows C promotion rules, but int->float conversion is done using bitwise reinterpretation rather than preserving the value. I have a patch for this, but I don't know whether or not it's correct to change.

Mar 21 2018, 9:09 AM

Mar 20 2018

tromey updated subscribers of D44693: Correctly handle float division in Scalar.
Mar 20 2018, 11:15 AM
tromey created D44693: Correctly handle float division in Scalar.
Mar 20 2018, 11:11 AM

Feb 6 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.

Could someone land this for me? I don't have access to do that. Thanks!

Feb 6 2018, 12:08 PM · debug-info

Jan 31 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.
Jan 31 2018, 9:26 AM · debug-info
tromey updated the diff for D42082: Add DWARF for discriminated unions.

Rebased & added hashing test.

Jan 31 2018, 6:40 AM · debug-info
tromey added a comment to D42082: Add DWARF for discriminated unions.

As far as the metadata changes are concerned this looks mostly good, what's missing is a

  • round-trip test of the assembler (similar to test/Assembler/dicompositetype-members.ll )\
Jan 31 2018, 5:31 AM · debug-info

Jan 30 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.

As far as the metadata changes are concerned this looks mostly good, what's missing is a

  • round-trip test of the assembler (similar to test/Assembler/dicompositetype-members.ll )\
Jan 30 2018, 12:00 PM · debug-info

Jan 26 2018

tromey updated the diff for D42082: Add DWARF for discriminated unions.

Updates according to review. This then pointed out a buglet in
dwarfdump, now fixed.

Jan 26 2018, 10:52 AM · debug-info
tromey added a comment to D42084: Fix some regular expressions in llvm-mode.el.

LGTM with a redacted commit message. Do you have commit access or you need me to commit it on your behalf?

Jan 26 2018, 9:34 AM
tromey updated the diff for D42084: Fix some regular expressions in llvm-mode.el.

Updated the commit message.

Jan 26 2018, 9:34 AM

Jan 25 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.
Jan 25 2018, 3:52 PM · debug-info

Jan 24 2018

tromey updated the diff for D42082: Add DWARF for discriminated unions.

This is a new version of the discriminated union patch.

Jan 24 2018, 11:03 AM · debug-info

Jan 19 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.

FWIW, I had forgotten about this, but when I was first writing this patch I did find a dwarf-discuss thread about the discriminant placement issue: http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2006-August/001710.html

Jan 19 2018, 2:34 PM · debug-info

Jan 18 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.

Having the DIE shape conform to DWARF seems easy in this patch -- just a reordering in DwarfUnit::constructDiscriminatorDIE. However I don't see how to nicely support univariant Rust enums; the variant part is triggered by having a discriminator, but these objects don't have enumerators.

Jan 18 2018, 2:26 PM · debug-info
tromey added a comment to D42082: Add DWARF for discriminated unions.

I filed a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83935, and contacted a friend at AdaCore to see what they think.

Jan 18 2018, 1:43 PM · debug-info
tromey added a comment to D42082: Add DWARF for discriminated unions.

Another thing to consider is that this is really just the first patch in a larger project. There are other things in Rust that will require new debuginfo. Some of these can be mapped to existing DWARF (e.g., traits can probably use DW_TAG_interface pretty comfortably); but some cannot (e.g., the distinction between tuples and structs).

Jan 18 2018, 10:37 AM · debug-info
tromey added a comment to D42082: Add DWARF for discriminated unions.

Well, you'll want an actual enumeration_type for the type of the struct's field, and if enums don't otherwise occur naturally in Rust, that seems like a pretty good indication all by itself.

Jan 18 2018, 10:32 AM · debug-info

Jan 17 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.

That said, I'm happy to support a proposal to move the discriminant's member description out from under TAG_variant_part. Especially given GCC's practice, which probably is the same for Pascal as it is for Ada.

Jan 17 2018, 1:50 PM · debug-info
tromey added a comment to D42082: Add DWARF for discriminated unions.

The DWARF spec says: "If the variant part has a discriminant, the discriminant is represented by a separate debugging information entry which is a child of the variant part entry. This entry has the form of a structure data member entry. The variant part entry will have a DW_AT_descr attribute whose value is a reference to the member entry for the discriminant."

I read this as saying the discriminant goes under the variant_part; it seems slightly redundant to have it both as a child and with a reference, but that's what it says. If you want you can bring it up on dwarf-discuss and see if anyone else thinks the discriminant ought to go outside the variant_part, but as it stands I think that would not be syntactically valid.

Jan 17 2018, 11:45 AM · debug-info
tromey added a comment to D42082: Add DWARF for discriminated unions.

As I poke around the web looking for how a Rust enum-with-value works, it appears that Rust has what in Pascal would be a tagged variant record with no invariant part and no default variant.

Jan 17 2018, 7:27 AM · debug-info

Jan 16 2018

tromey added a comment to D42082: Add DWARF for discriminated unions.

DWARF discriminated unions were likely designed to support Pascal variant records, which do allow multiple fields per variant. If we're going to support discriminated unions (which seems reasonable) then it ought to be general enough to handle the Pascal case.

Jan 16 2018, 11:46 AM · debug-info

Jan 15 2018

tromey added a reviewer for D42084: Fix some regular expressions in llvm-mode.el: rafael.

Adding you for review because I think you reviewed earlier changes to this file.

Jan 15 2018, 11:16 AM
tromey created D42084: Fix some regular expressions in llvm-mode.el.
Jan 15 2018, 11:14 AM
tromey created D42082: Add DWARF for discriminated unions.
Jan 15 2018, 11:00 AM · debug-info

Nov 8 2017

tromey added a comment to D39503: Let replaceVTableHolder accept any type.

Thanks for the reviews. I don't have commit access, so could someone please check this in for me?

Nov 8 2017, 1:32 PM

Nov 2 2017

tromey updated the diff for D39503: Let replaceVTableHolder accept any type.

Add a test based on rustc output

Nov 2 2017, 11:23 AM
tromey added inline comments to D39503: Let replaceVTableHolder accept any type.
Nov 2 2017, 11:19 AM
tromey added inline comments to D39503: Let replaceVTableHolder accept any type.
Nov 2 2017, 9:57 AM
tromey updated the diff for D39503: Let replaceVTableHolder accept any type.

Address review comments

Nov 2 2017, 9:20 AM
tromey added inline comments to D39503: Let replaceVTableHolder accept any type.
Nov 2 2017, 7:45 AM

Nov 1 2017

tromey added a reviewer for D39503: Let replaceVTableHolder accept any type: echristo.
Nov 1 2017, 1:11 PM
tromey updated subscribers of D39503: Let replaceVTableHolder accept any type.
Nov 1 2017, 1:09 PM
tromey created D39503: Let replaceVTableHolder accept any type.
Nov 1 2017, 1:05 PM