Page MenuHomePhabricator
Feed Advanced Search

Fri, Aug 7

tra updated the summary of D85575: [ARM] Speed up arm-cortex-cpus.c test.
Fri, Aug 7, 5:32 PM · Restricted Project
tra requested review of D85575: [ARM] Speed up arm-cortex-cpus.c test.
Fri, Aug 7, 5:30 PM · Restricted Project
tra committed rGcd01980f308a: [OpenMP] Split OpenMP/target_map_codegen test [NFC] (authored by tra).
[OpenMP] Split OpenMP/target_map_codegen test [NFC]
Fri, Aug 7, 1:48 PM
tra closed D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC].
Fri, Aug 7, 1:48 PM · Restricted Project
tra added inline comments to D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC].
Fri, Aug 7, 1:34 PM · Restricted Project
tra added a comment to D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC].

Wow, cool. I imagine it was hard to split this given the manual check lines. We really need to start using the upgrade scripts here.

I'm fine with this, @ABataev WDYT?

Fri, Aug 7, 1:29 PM · Restricted Project
tra requested review of D85551: [OpenMP] Split OpenMP/target_map_codegen test [NFC].
Fri, Aug 7, 1:14 PM · Restricted Project

Thu, Aug 6

tra added a comment to D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions.

I added a Deferrable bit to the diagnostics which can be specified in td files. This can be added to individual diagnostic defs or added to a bunch of diagnostic defs all together.

This field is used to control whether a diagnostic message can be deferred.

Thu, Aug 6, 3:38 PM
tra added inline comments to D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions..
Thu, Aug 6, 10:53 AM · Restricted Project
tra added a comment to D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions..

Do we need to disable pgo and coverage mapping for device compilation? Or it is already disabled?

Thu, Aug 6, 9:28 AM · Restricted Project

Wed, Aug 5

tra committed rG7d057efddc00: [CUDA] Work around a bug in rint/nearbyint caused by a broken implementation… (authored by tra).
[CUDA] Work around a bug in rint/nearbyint caused by a broken implementation…
Wed, Aug 5, 1:14 PM
tra closed D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA..
Wed, Aug 5, 1:14 PM · Restricted Project
tra updated the diff for D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA..

Also fixed the same bug in nearbyint().

Wed, Aug 5, 12:49 PM · Restricted Project
tra requested review of D85352: [CUDA, test-suite] More test cases for rint() and nearint().
Wed, Aug 5, 12:47 PM
tra requested review of D85349: [CUDA, test-suite] Prevent constant folding of the test inputs..
Wed, Aug 5, 12:44 PM
tra added inline comments to D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions..
Wed, Aug 5, 10:50 AM · Restricted Project
tra added a comment to D85276: [PGO][CUDA][HIP] Skip generating profile on the device stub and wrong-side functions..

LGTM for CUDA.

Wed, Aug 5, 9:42 AM · Restricted Project

Tue, Aug 4

tra requested review of D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA..
Tue, Aug 4, 12:05 PM · Restricted Project
tra accepted D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.

What is expected to happen to device statics in anonymous name spaces? It may be worth adding them to the tests.

Tue, Aug 4, 11:02 AM · Restricted Project

Wed, Jul 29

tra accepted D84824: [HIP] Emit target-id module flag.
Wed, Jul 29, 11:27 AM
tra added a comment to D71726: Let clang atomic builtins fetch add/sub support floating point types.

LGTM, modulo couple of nits.

Wed, Jul 29, 10:45 AM
tra added a comment to D84743: [Clang][AMDGCN] Universal device offloading macros header.

Also, do we need the header at all?
It would be much easier to just get clang itself to add normalized macros without trying to reconstruct them from the existing macros.

Wed, Jul 29, 10:12 AM · Restricted Project

Tue, Jul 28

tra added a comment to D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.

I think Sam's approach is reasonable.

Tue, Jul 28, 11:44 AM · Restricted Project
tra added a comment to D84743: [Clang][AMDGCN] Universal device offloading macros header.

I'm not sure it's particularly useful, to be honest. CUDA code still needs to be compatible with NVCC so it can't be used in portable code like TF or other currently used CUDA libraries.
It could be useful internally, though, so I'm fine with it for that purpose.

Tue, Jul 28, 11:11 AM · Restricted Project

Mon, Jul 27

tra added a comment to D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.

It's a good point. Perhaps this is one of the cases where we should *not* follow nvcc.
We can't have our cake (preserve static behavior) and eat it (treat it as non-static in case something on the host side may decide to use an API which uses symbol names). Something's got to give. While we could make it work in some cases, I don't think we can make it work consistently.
I think it would be reasonable to restrict APIs that access symbols by name to be applicable to visible symbols only.

Mon, Jul 27, 3:15 PM · Restricted Project

Fri, Jul 24

tra updated the diff for D84258: [buildbot] Added config files for CUDA build bots.

Updated directory structure.

Fri, Jul 24, 12:11 PM
tra added a comment to D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

Phabricator seems to be confused by the renames. The change just moved terraform -> terraform/buildbot-mlir-nvidia
The directory structure looks like this now:

Fri, Jul 24, 12:02 PM
tra updated the diff for D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

Really updated directory structure.

Fri, Jul 24, 11:54 AM
tra updated the diff for D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

Updated directory structure.

Fri, Jul 24, 11:53 AM
tra added a comment to D84258: [buildbot] Added config files for CUDA build bots.

I would not run multiple containers on one VM. As you said, k8s cannot share one GPUs across containers. I would rather create one "build slave" per VM (or a group of "build slaves" each in a separate VM) in buildbot and then have that VM(s) execute a set of "builders". We could have an m:n mapping of "build slaves" and "builders".

My mlir-nvidia builder is not very picky. It would probably run on any of your machines as long as it has an Nvidia card. Sorry about the non-inclusive wording here, but that's what buildbot calls them in the UI.

Fri, Jul 24, 11:18 AM

Thu, Jul 23

tra added a comment to D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.

The problem is not whether we have solution to tell them but when we need to add that. Not all static device variables need to be visible to the host side. Externalizing them adds the overhead for the linker and may pose additional restrictions on aggressive optimizations. Do we have to support every ambiguous usage in the burden of the compiler change?

Thu, Jul 23, 2:59 PM · Restricted Project
tra added a comment to D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions.
In D84364#2170244, @tra wrote:

I'm going to try the patch on our CUDA code and see how it fares. Stay tuned.

Thu, Jul 23, 2:31 PM
tra added a comment to D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.
In D80858#2170547, @tra wrote:

Would it work if we generate a globally unique visible aliases for the static vars and use the alias' name to register device-side entities without changing their visibility?

We still need to define how a static device variable should be visible on the host side.

Thu, Jul 23, 1:50 PM · Restricted Project
tra added a comment to D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.

Would it work if we generate a globally unique visible aliases for the static vars and use the alias' name to register device-side entities without changing their visibility?

Thu, Jul 23, 1:02 PM · Restricted Project
tra added a comment to D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions.

I'm going to try the patch on our CUDA code and see how it fares. Stay tuned.

Thu, Jul 23, 11:12 AM

Wed, Jul 22

tra added a comment to D83503: [buildbot] Annotated builder tweaks.

Ok. Let’s see how this will work in the reality.

Wed, Jul 22, 5:04 PM
tra committed rZORGddbbbd3e88c0: [buildbot] Add Builders and slaves for the new CUDA bot. (authored by tra).
[buildbot] Add Builders and slaves for the new CUDA bot.
Wed, Jul 22, 4:53 PM
tra closed D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..
Wed, Jul 22, 4:53 PM
tra committed rZORG521b2cea3e93: [buildbot] Annotated builder tweaks (authored by tra).
[buildbot] Annotated builder tweaks
Wed, Jul 22, 4:53 PM
tra closed D83503: [buildbot] Annotated builder tweaks.
Wed, Jul 22, 4:53 PM
tra updated the diff for D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Updated status.py with the new builder names.

Wed, Jul 22, 4:37 PM
tra added a comment to D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

I don't have this context so I was just seeing this revision alone which setup google/mlir/docker/ and still has google/docker.
It makes sense if after your stack of revisions if there is no google/docker left.

Wed, Jul 22, 3:40 PM
tra updated subscribers of D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions.

It's an interesting idea and it may be needed to handle wider range of implicitly-HD functions.
However it's likely to have interesting consequences, not all of them desirable.
It may be worth considering hiding the new behavior behind a flag, make it optional at first, give it some soak time and only then make it the default.
Summoning @rsmith for the big picture input.

Wed, Jul 22, 3:19 PM
tra added a comment to D84362: [NFC] Add missing functions to PartialDiagnostic.

FYI, the patch does not compile:

Wed, Jul 22, 2:37 PM
tra added a comment to D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

What is strange to me right now is the asymmetry:

google/docker/...
google/mlir/docker/...

google/terraform/
google/mlir/terraform/

Wed, Jul 22, 1:27 PM
tra added a comment to D71227: [cuda][hip] Fix function overload resolution in the global initiailizer..

Is this patch still actual?

Wed, Jul 22, 11:58 AM · Restricted Project
tra added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Hello Artem,

Good. Now, since you are done with the experiments, please make sure all your scripts are in llvm-zorg, and update this patch accordingly.

Wed, Jul 22, 11:14 AM
tra added a comment to D84258: [buildbot] Added config files for CUDA build bots.

Why do you want to double the config files and scripts?

Wed, Jul 22, 11:13 AM
tra added a comment to D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.

Sorry I did not understand why do you want to move these files.
Why not keep the new docker files for the existing machines right next to the existing ones?

So my thought on the directory structure was:

  • /buildbot/google/
    • docker/
      • mlir-nvidia/
      • win32/
      • your-docker-dir/
      • some-other-bot/
      • <common scripting>
Wed, Jul 22, 10:58 AM

Tue, Jul 21

tra added inline comments to D60620: [HIP] Support target id by --offload-arch.
Tue, Jul 21, 2:23 PM · Restricted Project
tra added a comment to D83503: [buildbot] Annotated builder tweaks.

A script could be "external" as long as it is a part of the LLVM code base, i.e. committed under https://github.com/llvm to be available to others for review, use, and improve according to the "Apache 2.0 License with LLVM exceptions” and the Developer Policy.

Tue, Jul 21, 12:26 PM
tra created D84258: [buildbot] Added config files for CUDA build bots.
Tue, Jul 21, 11:49 AM
tra created D84256: [buildbot] Moved MLIR buildbot config under buildbot/google/mlir.
Tue, Jul 21, 11:24 AM

Mon, Jul 20

tra committed rGbf66003a4f91: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives. (authored by tra).
[MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives.
Mon, Jul 20, 9:19 PM
tra closed D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Mon, Jul 20, 9:19 PM · Restricted Project
tra updated the summary of D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Mon, Jul 20, 9:16 PM · Restricted Project

Fri, Jul 17

tra added a comment to D84068: AMDGPU/clang: Search resource directory for device libraries.

Could you walk me through how you see this working in practice?

Fri, Jul 17, 1:13 PM

Thu, Jul 16

tra accepted D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference.

LGTM.

Thu, Jul 16, 3:03 PM · Restricted Project

Wed, Jul 15

tra updated subscribers of D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference.

This is different from nvcc behavior, where it is diagnosed only if the function is really emitted:

Wed, Jul 15, 12:27 PM · Restricted Project

Tue, Jul 14

tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Tue, Jul 14, 1:11 PM · Restricted Project
tra updated the diff for D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..

Print negative values as hex.

Tue, Jul 14, 1:11 PM · Restricted Project
tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Tue, Jul 14, 12:42 PM · Restricted Project
tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Tue, Jul 14, 12:29 PM · Restricted Project
tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Tue, Jul 14, 12:19 PM · Restricted Project
tra added a comment to D83503: [buildbot] Annotated builder tweaks.

Please make sure all the scripts annotated builder could run are in zorg.

Tue, Jul 14, 12:13 PM
tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Tue, Jul 14, 11:17 AM · Restricted Project
tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Tue, Jul 14, 10:08 AM · Restricted Project
tra updated the diff for D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..

Mask out unwanted bits in the unsigned representation of the Value.

Tue, Jul 14, 10:05 AM · Restricted Project

Mon, Jul 13

tra updated the diff for D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..

Use std::make_unsigned to find the matching unsigned type.

Mon, Jul 13, 7:27 PM · Restricted Project
tra added inline comments to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..
Mon, Jul 13, 7:23 PM · Restricted Project
tra added a comment to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..

Ping!

Mon, Jul 13, 3:56 PM · Restricted Project
tra added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

@gkistanova : I think the bots are in a reasonable shape now and are ready to move to the normal build master.
This patch simplifies things a bit based on the changes I've added in D83503 which lets annotated builder use external scripts (sounds like that's what you may have done on the staging bot already) and added an option to control whether the source repo is checked out.

Mon, Jul 13, 10:16 AM
tra updated the diff for D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Removed external.py

Mon, Jul 13, 10:13 AM

Fri, Jul 10

tra accepted D83591: [OpenMP][CUDA] Fix std::complex in GPU regions.

LGTM.

Fri, Jul 10, 6:12 PM · Restricted Project
tra added a comment to D83591: [OpenMP][CUDA] Fix std::complex in GPU regions.

I did not know they are using __clang_cuda headers. (Site note, we should rename them then.)

I also did not know that. I am repeatedly caught out by things named 'cuda', 'nvptx' or '__nv' being used by amdgpu.

Fri, Jul 10, 6:11 PM · Restricted Project
tra added a comment to D83591: [OpenMP][CUDA] Fix std::complex in GPU regions.

Fine by me. Let's get nvptx working properly in tree now and work out how to wire up amdgcn subsequently. I'm sure a reasonable abstraction will present itself.

Fri, Jul 10, 4:47 PM · Restricted Project

Jul 10 2020

tra accepted D82930: [HIP] Fix rocm detection.

LGTM in principle. Few style comments.

Jul 10 2020, 11:43 AM · Restricted Project

Jul 9 2020

tra updated the diff for D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Updated CUDA bot setup.

Jul 9 2020, 1:14 PM
tra created D83503: [buildbot] Annotated builder tweaks.
Jul 9 2020, 1:13 PM

Jul 8 2020

tra updated the diff for D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives..

Updated existing test which produced data directive w/ negative value.

Jul 8 2020, 4:07 PM · Restricted Project
tra added a comment to D82881: [DEBUGINFO]Fix debug info for packed bitfields..

I've sent D83423 to make sure NVPTX can handle negative values.

Jul 8 2020, 1:47 PM · debug-info, Restricted Project
Herald added a project to D83423: [MC,NVPTX] Add MCAsmPrinter support for unsigned-only data directives.: Restricted Project.
Jul 8 2020, 1:36 PM · Restricted Project
tra added a comment to D82881: [DEBUGINFO]Fix debug info for packed bitfields..

I have a patch for it already. It is quite simple, just need to set the Form to DW_FORM_udata and everything work. I can update this patch, if you want to try the fix.

Jul 8 2020, 10:53 AM · debug-info, Restricted Project
tra added a comment to D82881: [DEBUGINFO]Fix debug info for packed bitfields..

The bug I'm trying to fix is the incompatibility with NVPTX ptxas compiler. It does not allow signed integers in debug sections. Would it be good to emit bit_offset as DW_FORM_udata for NVPTX target to fix incompatibility? Checked that it works with ptxas.

Jul 8 2020, 10:36 AM · debug-info, Restricted Project
tra accepted D78655: [CUDA][HIP] Let lambda be host device by default.

LGTM.

Jul 8 2020, 9:31 AM · Restricted Project

Jul 7 2020

tra added inline comments to D78655: [CUDA][HIP] Let lambda be host device by default.
Jul 7 2020, 3:57 PM · Restricted Project
tra added inline comments to D82930: [HIP] Fix rocm detection.
Jul 7 2020, 11:58 AM · Restricted Project
tra added inline comments to D82930: [HIP] Fix rocm detection.
Jul 7 2020, 10:18 AM · Restricted Project
tra accepted D80897: [OpenMP] Initial support for std::complex in target regions.

LGTM.

Jul 7 2020, 9:38 AM · Restricted Project

Jul 6 2020

tra added inline comments to D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc.
Jul 6 2020, 2:24 PM · Restricted Project
tra added inline comments to D82930: [HIP] Fix rocm detection.
Jul 6 2020, 1:57 PM · Restricted Project
tra added inline comments to D78655: [CUDA][HIP] Let lambda be host device by default.
Jul 6 2020, 1:33 PM · Restricted Project
tra accepted D82873: Initial buildbot image for Windows with Visual Studio 2019.
Jul 6 2020, 11:12 AM

Jun 30 2020

tra added inline comments to D78655: [CUDA][HIP] Let lambda be host device by default.
Jun 30 2020, 2:41 PM · Restricted Project

Jun 25 2020

tra accepted D82579: [NFC] Extract unifyTargetFeatures.
Jun 25 2020, 2:11 PM · Restricted Project
tra added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..
In D81118#2115258, @tra wrote:

AFAICT, revision hash is not available in the environment, so there's no way for me to check out the correct revision.

Jun 25 2020, 1:39 PM
tra added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..
Jun 25 2020, 1:05 PM
tra added inline comments to D82579: [NFC] Extract unifyTargetFeatures.
Jun 25 2020, 12:28 PM · Restricted Project
tra added inline comments to D82579: [NFC] Extract unifyTargetFeatures.
Jun 25 2020, 10:46 AM · Restricted Project
tra accepted D82506: [HIP] Add missing options for lto.

LGTM.

Jun 25 2020, 10:46 AM · Restricted Project