Page MenuHomePhabricator
Feed Advanced Search

Mon, Nov 15

jozefl added a comment to D110240: [MSP430] Implement PUSHM and POPM instructions.

Ping.

Mon, Nov 15, 6:14 AM · Restricted Project
jozefl added a comment to D110725: [MSP430] Add codegen support for MSP430X shift instructions.

Ping.

Mon, Nov 15, 6:14 AM · Restricted Project
jozefl added a comment to D110724: [MSP430] Add support for the `rpt` assembler directive.

Ping.

Mon, Nov 15, 6:13 AM · Restricted Project
jozefl added a comment to D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.

Ping.

Mon, Nov 15, 6:13 AM · Restricted Project
jozefl added a comment to D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Ping.

Mon, Nov 15, 6:13 AM · Restricted Project, Restricted Project
jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Ping.

Mon, Nov 15, 6:12 AM · Restricted Project, Restricted Project

Oct 28 2021

jozefl added a comment to D110240: [MSP430] Implement PUSHM and POPM instructions.

Ping.

Oct 28 2021, 6:40 AM · Restricted Project
jozefl added a comment to D110725: [MSP430] Add codegen support for MSP430X shift instructions.

Ping.

Oct 28 2021, 6:40 AM · Restricted Project
jozefl added a comment to D110724: [MSP430] Add support for the `rpt` assembler directive.

Ping.

Oct 28 2021, 6:38 AM · Restricted Project
jozefl added a comment to D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.

Ping.

Oct 28 2021, 6:38 AM · Restricted Project
jozefl added a comment to D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Ping.

Oct 28 2021, 6:37 AM · Restricted Project, Restricted Project
jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Ping.

Oct 28 2021, 6:37 AM · Restricted Project, Restricted Project

Oct 18 2021

jozefl added a comment to D110240: [MSP430] Implement PUSHM and POPM instructions.

Ping.

Oct 18 2021, 6:04 AM · Restricted Project
jozefl added a comment to D110725: [MSP430] Add codegen support for MSP430X shift instructions.

Ping.

Oct 18 2021, 6:03 AM · Restricted Project
jozefl added a comment to D110724: [MSP430] Add support for the `rpt` assembler directive.

Ping.

Oct 18 2021, 3:44 AM · Restricted Project
jozefl added a comment to D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.

Ping.

Oct 18 2021, 3:44 AM · Restricted Project
jozefl added a comment to D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Ping.

Oct 18 2021, 3:43 AM · Restricted Project, Restricted Project
jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Ping.

Oct 18 2021, 3:41 AM · Restricted Project, Restricted Project

Oct 13 2021

jozefl updated the diff for D110725: [MSP430] Add codegen support for MSP430X shift instructions.

Rebase to fix pre-merge tests.

Oct 13 2021, 2:01 AM · Restricted Project
jozefl updated the diff for D110240: [MSP430] Implement PUSHM and POPM instructions.

Rebase to fix pre-merge tests.

Oct 13 2021, 1:57 AM · Restricted Project

Oct 12 2021

jozefl updated the diff for D110724: [MSP430] Add support for the `rpt` assembler directive.

Rebase onto new base revision to fix pre-merge tests.

Oct 12 2021, 9:04 AM · Restricted Project
jozefl updated the diff for D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.

Rebase onto new base revision to fix pre-merge tests.

Oct 12 2021, 8:19 AM · Restricted Project
jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Rebase onto new base revision to fix pre-merge tests.

Oct 12 2021, 7:38 AM · Restricted Project, Restricted Project
jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Rebase onto new base revision to fix pre-merge tests.

Oct 12 2021, 6:30 AM · Restricted Project, Restricted Project

Oct 7 2021

jozefl updated the diff for D110240: [MSP430] Implement PUSHM and POPM instructions.

Rebase.

Oct 7 2021, 8:39 AM · Restricted Project

Oct 4 2021

jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Ping.

Oct 4 2021, 7:51 AM · Restricted Project, Restricted Project

Sep 29 2021

jozefl added inline comments to D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.
Sep 29 2021, 9:07 AM · Restricted Project
jozefl abandoned D109324: [MSP430] Add support for MSP430X extended shift instructions.

Abandoning revision as the patch has been split into https://reviews.llvm.org/D110723 https://reviews.llvm.org/D110724 https://reviews.llvm.org/D110725

Sep 29 2021, 8:55 AM · Restricted Project
jozefl added a comment to D109324: [MSP430] Add support for MSP430X extended shift instructions.

Will it be possible to split this patch into 3:

  1. Addition of rpt
  2. Addition of shift instructions
  3. Codegen

Thanks!

Sep 29 2021, 8:54 AM · Restricted Project
jozefl requested review of D110725: [MSP430] Add codegen support for MSP430X shift instructions.
Sep 29 2021, 8:51 AM · Restricted Project
jozefl requested review of D110724: [MSP430] Add support for the `rpt` assembler directive.
Sep 29 2021, 8:34 AM · Restricted Project
jozefl updated the summary of D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.
Sep 29 2021, 8:30 AM · Restricted Project
jozefl requested review of D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.
Sep 29 2021, 8:22 AM · Restricted Project
jozefl updated subscribers of D110691: [MSP430] Recognize Bi as an indirect branch in analyzeBranch. NFC..

OK, I will try your suggestions, but:

Bi is a direct, unconditional branch like JMP

then why does the Bi instruction have "isIndirectBranch = 1"?

Sep 29 2021, 6:35 AM · Restricted Project
jozefl added a comment to D110691: [MSP430] Recognize Bi as an indirect branch in analyzeBranch. NFC..

Instead of just ignoring Bi, I think we can handle it as we do with JMP. Bi is a direct, unconditional branch like JMP, it just has longer range.
See inline comments for suggestions.

Sep 29 2021, 3:53 AM · Restricted Project
jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Rebase after updates to parent revision D108301.

Sep 29 2021, 1:57 AM · Restricted Project, Restricted Project

Sep 28 2021

jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Thanks, good points, I have addressed them in this updated patch.

Sep 28 2021, 12:35 PM · Restricted Project, Restricted Project
jozefl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Thanks for the review, and committing the patch for me.

Sep 28 2021, 12:50 AM · Restricted Project

Sep 23 2021

jozefl updated the diff for D110240: [MSP430] Implement PUSHM and POPM instructions.

Fix clang-tidy warnings.

Sep 23 2021, 1:31 AM · Restricted Project

Sep 22 2021

jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Rebase to fix patch application failure for
clang/test/Misc/target-invalid-cpu-note.c.

Sep 22 2021, 9:23 AM · Restricted Project, Restricted Project
jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Undo incorrect rebase.

Sep 22 2021, 9:13 AM · Restricted Project, Restricted Project
jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Rebase to fix patch application failure for
clang/test/Misc/target-invalid-cpu-note.c.

Sep 22 2021, 6:14 AM · Restricted Project, Restricted Project
jozefl requested review of D110240: [MSP430] Implement PUSHM and POPM instructions.
Sep 22 2021, 6:06 AM · Restricted Project

Sep 21 2021

jozefl added inline comments to D110145: [mlir] Move duplicated function getSingleOpOfType into BlockUtilities.h.
Sep 21 2021, 5:43 AM · Restricted Project

Sep 20 2021

jozefl added a comment to D109324: [MSP430] Add support for MSP430X extended shift instructions.

Pinging for review.

Sep 20 2021, 1:36 AM · Restricted Project
jozefl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Pinging for review of the MSP430-specific yaml2obj test.

Sep 20 2021, 1:35 AM · Restricted Project
jozefl added a comment to D108299: [MSP430][Clang] Remove support for -mmcu=msp430.

Pinging for review.

Sep 20 2021, 1:33 AM · Restricted Project
jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Pinging for review.

Sep 20 2021, 1:33 AM · Restricted Project, Restricted Project
jozefl added a comment to D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Pinging for review.

Sep 20 2021, 1:32 AM · Restricted Project, Restricted Project

Sep 7 2021

jozefl added inline comments to D109324: [MSP430] Add support for MSP430X extended shift instructions.
Sep 7 2021, 6:21 AM · Restricted Project
jozefl updated the diff for D109324: [MSP430] Add support for MSP430X extended shift instructions.

Fixed one of the TODOs:

Sep 7 2021, 6:14 AM · Restricted Project

Sep 6 2021

jozefl requested review of D109324: [MSP430] Add support for MSP430X extended shift instructions.
Sep 6 2021, 7:10 AM · Restricted Project

Sep 3 2021

jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Rebase.

Sep 3 2021, 2:03 AM · Restricted Project, Restricted Project
jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Fix the msp430-toolchain.c test by adding some more Windows path separators to
the match patterns.

Sep 3 2021, 12:49 AM · Restricted Project, Restricted Project

Sep 2 2021

jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Updated patch to use hasFeature() to check for msp430x support, instead of a
new function.

Sep 2 2021, 12:48 PM · Restricted Project, Restricted Project
jozefl updated the diff for D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.

Rebased onto current upstream.

Sep 2 2021, 11:56 AM · Restricted Project, Restricted Project
jozefl requested review of D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=.
Sep 2 2021, 10:33 AM · Restricted Project, Restricted Project

Sep 1 2021

jozefl added a comment to D108299: [MSP430][Clang] Remove support for -mmcu=msp430.

Pinging for review.

Sep 1 2021, 8:22 AM · Restricted Project
jozefl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Ping.
If the added yaml2obj test is acceptable, I would appreciate it if someone would "arc land" the patch for me, as I do not have commit access.

Thanks,
Jozef

Hi @jozefl,

The general assumption in LLVM is that someone has commit access to land their own work after an LGTM on the patch has been received, unless they specifically say so. Also, I personally don't use "arc" for landing patches, so I'll need your preferred email address and name for the commit message if you want me (or someone else) to land it for you. Alternatively, if you've already contributed a few patches, you can request commit access for yourself.

Sep 1 2021, 12:52 AM · Restricted Project

Aug 31 2021

jozefl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Ping.
If the added yaml2obj test is acceptable, I would appreciate it if someone would "arc land" the patch for me, as I do not have commit access.

Aug 31 2021, 8:29 AM · Restricted Project
jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Pinging for review.

Aug 31 2021, 5:24 AM · Restricted Project, Restricted Project

Aug 24 2021

jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Here's an updated patch that fixes some minor nits.

Aug 24 2021, 8:02 AM · Restricted Project, Restricted Project

Aug 20 2021

jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Here's an updated patch to fix the win64 failure.

Aug 20 2021, 9:15 AM · Restricted Project, Restricted Project
jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Here's an updated patch that stores the HWMult and CPU data for each MCU as
strings instead of enums. This simplifies the patch as string conversions to
and from enums are no longer required.

Aug 20 2021, 2:06 AM · Restricted Project, Restricted Project

Aug 19 2021

jozefl added a comment to D108301: [MSP430][Clang] Update hard-coded MCU data.

Now that I am in the process of implementing the processing of the "CPU"
feature, I've realized the decision to store the CPU and HWMult information as
enums instead of strings has some downsides that may outweigh the benefits:

  • All string values passed to options need to be first converted to enums before they can be processed
  • Enums need to be converted back to strings in for use in diagnostics
  • Additional code is required to perform these conversions
Aug 19 2021, 9:54 AM · Restricted Project, Restricted Project
jozefl updated the diff for D108301: [MSP430][Clang] Update hard-coded MCU data.

Fixed clang-tidy warnings.

Aug 19 2021, 4:38 AM · Restricted Project, Restricted Project

Aug 18 2021

jozefl added a reviewer for D108301: [MSP430][Clang] Update hard-coded MCU data: atrosinenko.
Aug 18 2021, 7:32 AM · Restricted Project, Restricted Project
jozefl requested review of D108301: [MSP430][Clang] Update hard-coded MCU data.
Aug 18 2021, 7:24 AM · Restricted Project, Restricted Project
jozefl added a reviewer for D108299: [MSP430][Clang] Remove support for -mmcu=msp430: asl.
Aug 18 2021, 7:10 AM · Restricted Project
jozefl requested review of D108299: [MSP430][Clang] Remove support for -mmcu=msp430.
Aug 18 2021, 7:09 AM · Restricted Project
jozefl updated the diff for D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Thanks, fixed the nits.

Aug 18 2021, 1:59 AM · Restricted Project
jozefl added a comment to D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

@MaskRay thanks!

Aug 18 2021, 1:24 AM · Restricted Project

Aug 17 2021

jozefl updated the diff for D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Added yaml2obj tests that create SHT_MSP430_ATTRIBUTES sections by
directly specifying the raw contents of the section.

Aug 17 2021, 9:50 AM · Restricted Project
jozefl added a comment to D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

Thanks for the reviews!

Aug 17 2021, 4:56 AM · Restricted Project
jozefl updated the diff for D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

Added a readobj test for ARM.

Aug 17 2021, 4:49 AM · Restricted Project
jozefl updated the diff for D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

Fixed in the attached.

Aug 17 2021, 3:30 AM · Restricted Project
jozefl added a comment to D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

Ah yes that makes sense. My mistake was assuming there were other targets with
unimplemented ELF attribute support when in fact, MSP430 is the only one.

I wouldn't assume that there aren't others, but at this point, we can't know which machine kinds might still be missing an implementation, so we can't really warn for them.

Aug 17 2021, 2:43 AM · Restricted Project
jozefl updated the diff for D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

Ah yes that makes sense. My mistake was assuming there were other targets with
unimplemented ELF attribute support when in fact, MSP430 is the only one.

Aug 17 2021, 2:12 AM · Restricted Project

Aug 16 2021

jozefl updated the diff for D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

Thanks @jhenderson, good point. Fixed in the updated diff.

Aug 16 2021, 8:12 AM · Restricted Project

Aug 12 2021

jozefl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

I don't have commit access, so if this patch is OK, I would appreciate if some would apply it for me.
Thanks.

Aug 12 2021, 8:48 AM · Restricted Project
jozefl added a comment to D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

I don't have commit access, so if this patch is OK, I would appreciate if some would apply it for me.
Thanks.

Aug 12 2021, 8:48 AM · Restricted Project
jozefl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

This patch relies on https://reviews.llvm.org/D107968, hence the patch application failure.
Is there a way to link these patches in some way? I've added that revision as a parent of this revision.
Thanks,
Jozef

Aug 12 2021, 8:46 AM · Restricted Project
jozefl added a reviewer for D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes: asl.
Aug 12 2021, 8:43 AM · Restricted Project
jozefl requested review of D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.
Aug 12 2021, 8:42 AM · Restricted Project
jozefl added reviewers for D107968: [llvm-readobj] Refactor ELFDumper::printAttributes(): Hsiang-Kai, grimar.
Aug 12 2021, 8:41 AM · Restricted Project
jozefl requested review of D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().
Aug 12 2021, 8:39 AM · Restricted Project