Page MenuHomePhabricator
Feed Advanced Search

Yesterday

krytarowski added inline comments to D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName().
Wed, Oct 28, 5:25 AM

Mon, Oct 26

krytarowski accepted D90139: libcxx: Fix a few warnings.

Looks OK from the NetBSD point of view.

Mon, Oct 26, 5:35 PM · Restricted Project

Sun, Oct 25

krytarowski accepted D90128: [lldb] [Process/FreeBSDRemote] Fix #include for i386 compat.
Sun, Oct 25, 6:45 PM · Restricted Project

Sat, Oct 24

krytarowski accepted D90105: [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs.
Sat, Oct 24, 10:57 PM · Restricted Project

Fri, Oct 23

krytarowski accepted D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers.
Fri, Oct 23, 11:08 AM · Restricted Project

Wed, Oct 21

krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Wed, Oct 21, 10:47 AM
krytarowski added inline comments to D89874: [lldb] Split out NetBSD/x86 watchpoint impl for unification.
Wed, Oct 21, 8:56 AM · Restricted Project
krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Wed, Oct 21, 8:20 AM
krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Wed, Oct 21, 6:44 AM

Tue, Oct 20

krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Tue, Oct 20, 2:57 PM
krytarowski requested changes to D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.

Host a LLVM buildbot for DragonFly first, otherwise it will be even not ever build-tested.

Tue, Oct 20, 5:20 AM · Restricted Project

Mon, Oct 19

krytarowski added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Mon, Oct 19, 1:24 PM · Restricted Project

Sun, Oct 18

krytarowski added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Sun, Oct 18, 6:53 AM · Restricted Project
krytarowski accepted D89640: [Sanitizers] Remove OpenBSD support.
Sun, Oct 18, 6:46 AM · Restricted Project
krytarowski added a comment to D89640: [Sanitizers] Remove OpenBSD support.

Please leave builtins intact. ubsan might work, but removing it too is fine.

Sun, Oct 18, 6:23 AM · Restricted Project

Sat, Oct 17

krytarowski added a comment to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

Please, First remove unused + unusable code for already introduced OS. At most cutting it to ubsan.

Sat, Oct 17, 1:25 PM · Restricted Project
krytarowski requested changes to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?

Sat, Oct 17, 1:19 PM · Restricted Project

Thu, Oct 15

krytarowski accepted D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.
Thu, Oct 15, 4:57 AM · Restricted Project

Wed, Oct 14

krytarowski accepted D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Wed, Oct 14, 6:47 AM · Restricted Project

Tue, Oct 13

krytarowski committed rGd4b040473291: [compiler-rt] [lldb] Mark syscall_acquire and syscall_release as USED (authored by krytarowski).
[compiler-rt] [lldb] Mark syscall_acquire and syscall_release as USED
Tue, Oct 13, 6:57 PM
krytarowski added inline comments to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Tue, Oct 13, 11:08 AM · Restricted Project

Mon, Oct 12

krytarowski added a comment to D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL.

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

Mon, Oct 12, 3:33 AM · Restricted Project

Sat, Oct 10

krytarowski added a reviewer for D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE: bsdjhb.

+ @bsdjhb John, could you have a look?

Sat, Oct 10, 12:27 PM · Restricted Project
krytarowski resigned from D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.
Sat, Oct 10, 3:17 AM · Restricted Project
krytarowski accepted D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*.
Sat, Oct 10, 2:40 AM · Restricted Project
krytarowski accepted D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL.
Sat, Oct 10, 2:40 AM · Restricted Project

Tue, Oct 6

krytarowski accepted D88796: [lldb] Initial version of FreeBSD remote process plugin.
Tue, Oct 6, 1:07 PM · Restricted Project

Mon, Oct 5

krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Mon, Oct 5, 7:47 AM · Restricted Project

Sun, Oct 4

krytarowski added a comment to D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin.

Can we rename the register names in the darwin plugin?

Sun, Oct 4, 2:54 PM · Restricted Project
krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Sun, Oct 4, 9:53 AM · Restricted Project
krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Sun, Oct 4, 7:09 AM · Restricted Project

Fri, Oct 2

krytarowski accepted D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs.
Fri, Oct 2, 11:15 AM · Restricted Project
krytarowski accepted D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers.
Fri, Oct 2, 10:50 AM · Restricted Project
krytarowski added inline comments to D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers.
Fri, Oct 2, 10:31 AM · Restricted Project
krytarowski added inline comments to D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs.
Fri, Oct 2, 10:30 AM · Restricted Project
krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Confirmed to work.

Fri, Oct 2, 8:24 AM · Restricted Project, Restricted Project
krytarowski accepted D76665: [asan] Stop instrumenting user-defined ELF sections.
Fri, Oct 2, 8:23 AM · Restricted Project, Restricted Project
krytarowski committed rG2a9ce60de98e: [compiler-rt] [netbsd] Improve the portability of ThreadSelfTlsTcb (authored by krytarowski).
[compiler-rt] [netbsd] Improve the portability of ThreadSelfTlsTcb
Fri, Oct 2, 7:33 AM

Sep 17 2020

krytarowski committed rG7b2dd58eb09d: [compiler-rt] [scudo] Fix typo in function attribute (authored by krytarowski).
[compiler-rt] [scudo] Fix typo in function attribute
Sep 17 2020, 7:59 AM
krytarowski committed rGe7de267910e9: [compiler-rt] [hwasan] Replace INLINE with inline (authored by krytarowski).
[compiler-rt] [hwasan] Replace INLINE with inline
Sep 17 2020, 7:47 AM
krytarowski committed rG72c5feeed8d8: [compiler-rt] [netbsd] Include <sys/dkbad.h> (authored by krytarowski).
[compiler-rt] [netbsd] Include <sys/dkbad.h>
Sep 17 2020, 7:36 AM
krytarowski committed rG9339f68f21fa: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT (authored by krytarowski).
[compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT
Sep 17 2020, 7:29 AM
krytarowski closed D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.
Sep 17 2020, 7:28 AM · Restricted Project
krytarowski committed rG85e578f53ad1: [compiler-rt] Replace INLINE with inline (authored by krytarowski).
[compiler-rt] Replace INLINE with inline
Sep 17 2020, 7:24 AM
krytarowski closed D87562: [compiler-rt] Replace INLINE with inline.
Sep 17 2020, 7:24 AM · Restricted Project
krytarowski committed rG69516ddd028e: [compiler-rt] Avoid pulling libatomic to sanitizer tests (authored by krytarowski).
[compiler-rt] Avoid pulling libatomic to sanitizer tests
Sep 17 2020, 7:04 AM
krytarowski closed D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Sep 17 2020, 7:04 AM · Restricted Project

Sep 16 2020

krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

Can you please clang format it as well

Sep 16 2020, 2:25 PM · Restricted Project

Sep 14 2020

krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

I prefer we use just "inline"

Sep 14 2020, 8:54 AM · Restricted Project
krytarowski updated the diff for D87562: [compiler-rt] Replace INLINE with inline.
Sep 14 2020, 4:51 AM · Restricted Project
krytarowski requested review of D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.
Sep 14 2020, 1:44 AM · Restricted Project
krytarowski committed rG0008fb343704: [compiler-rt] [netbsd] Use internal_ptrace() instead of ptrace() (authored by krytarowski).
[compiler-rt] [netbsd] Use internal_ptrace() instead of ptrace()
Sep 14 2020, 1:12 AM

Sep 12 2020

krytarowski added a comment to D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.

std::atomic_is_lock_free or an reimplementation of it (without pulling C++ runtime), testing a type and asserting that in runtime or build time that it is lockfree.

Sep 12 2020, 4:28 PM · Restricted Project
krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

I've verified that this symbol has unlikely any clashes with 3rd party software now. https://grep.app/search?q=ATTR_INLINE&case=true&words=true

Sep 12 2020, 2:08 PM · Restricted Project
krytarowski requested review of D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Sep 12 2020, 1:47 PM · Restricted Project
krytarowski requested review of D87562: [compiler-rt] Replace INLINE with inline.
Sep 12 2020, 10:02 AM · Restricted Project

Sep 10 2020

krytarowski committed rG00460ae520e2: [compiler-rt] [netbsd] Regenerate syscall hooks (authored by krytarowski).
[compiler-rt] [netbsd] Regenerate syscall hooks
Sep 10 2020, 11:17 AM
krytarowski committed rGbba736e5036f: [compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk (authored by krytarowski).
[compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk
Sep 10 2020, 11:17 AM
krytarowski committed rGb85c085c846c: [compiler-rt] [netbsd] Improve code formatting (authored by krytarowski).
[compiler-rt] [netbsd] Improve code formatting
Sep 10 2020, 10:39 AM
krytarowski committed rGcb8cb28ed90a: [compiler-rt] [netbsd] Add fallback definitions for MKISCSI=no (authored by krytarowski).
[compiler-rt] [netbsd] Add fallback definitions for MKISCSI=no
Sep 10 2020, 10:39 AM
krytarowski committed rG52f42720b26a: [lldb] [netbsd] Avoid comparison of signed and unsigned integers (authored by krytarowski).
[lldb] [netbsd] Avoid comparison of signed and unsigned integers
Sep 10 2020, 6:49 AM
krytarowski committed rGf51e55e09eef: [compiler-rt] [netbsd] Reintroduce __sanitizer_protoent (authored by krytarowski).
[compiler-rt] [netbsd] Reintroduce __sanitizer_protoent
Sep 10 2020, 2:47 AM
krytarowski added inline comments to D82424: sanitizers: Add interceptors for getproto{ent,byname,bynumber}_r.
Sep 10 2020, 2:43 AM · Restricted Project

Sep 9 2020

krytarowski added a comment to D87120: [MemProf] Memory profiling runtime support.

These "linux" files will be ported to BSD so we might pick better names now.

Sep 9 2020, 9:20 AM · Restricted Project

Sep 8 2020

krytarowski added a comment to D85820: Use find_library for ncurses.

Please note that ncurses is not the only supported curses library. NetBSD uses its original BSD curses for LLVM projects.

Sep 8 2020, 3:35 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.
In D76665#2140245, @kcc wrote:

Will adding attribute((no_sanitize("address"))) to your global solve the problem you are trying to solve?
(sorry for being too terse last time)

It does not work (last time I checked).

Does not work how?

Also GCC does the same thing of not instrumenting user defined sections.

Sep 5 2020, 12:57 PM · Restricted Project, Restricted Project

Aug 25 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Ping?

Aug 25 2020, 12:25 PM · Restricted Project, Restricted Project

Aug 6 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Ping?

Aug 6 2020, 4:38 AM · Restricted Project, Restricted Project

Jul 20 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

@glider + @pcc please have a look!

Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project
krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.
In D76665#2140245, @kcc wrote:

Will adding attribute((no_sanitize("address"))) to your global solve the problem you are trying to solve?
(sorry for being too terse last time)

Jul 20 2020, 5:48 AM · Restricted Project, Restricted Project

Jun 3 2020

krytarowski added a comment to D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
In D81105#2072158, @jfb wrote:

Please clarify what this is adding in the patch description.

Jun 3 2020, 7:17 PM · Restricted Project
krytarowski updated the diff for D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
Jun 3 2020, 10:26 AM · Restricted Project
krytarowski updated the diff for D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
Jun 3 2020, 9:53 AM · Restricted Project
krytarowski created D81105: [compiler-rt] [builtin] Implement __atomic_fetch_nand_* builtins.
Jun 3 2020, 8:46 AM · Restricted Project

Jun 2 2020

krytarowski added inline comments to D76665: [asan] Stop instrumenting user-defined ELF sections.
Jun 2 2020, 5:31 AM · Restricted Project, Restricted Project

May 28 2020

krytarowski added a reviewer for D80469: Add OpenBSD support in lib/tsan/go/buildgo.sh: dvyukov.

It looks fine to me, but I will defer it to @dvyukov

May 28 2020, 12:07 PM · Restricted Project

May 14 2020

krytarowski abandoned D79846: [compiler-rt] [builtin] Add public functions prototypes.

OK, we will need to live with -Wno*.

May 14 2020, 6:25 AM · Restricted Project

May 13 2020

krytarowski added a comment to D79846: [compiler-rt] [builtin] Add public functions prototypes.

Example error:

May 13 2020, 5:54 AM · Restricted Project
krytarowski added a comment to D79846: [compiler-rt] [builtin] Add public functions prototypes.

It should already be buildable out of the box. The missing prototypes warning is opt-in. I am not particularly in favour of changes motivated solely by an external build system that explicitly opts in to warnings that don't make sense for a particular compilation unit.

May 13 2020, 5:54 AM · Restricted Project
krytarowski committed rGf61f6ffe1126: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n… (authored by krytarowski).
[compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n…
May 13 2020, 5:22 AM
krytarowski closed D79845: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n to bool.
May 13 2020, 5:21 AM · Restricted Project
krytarowski added a comment to D79846: [compiler-rt] [builtin] Add public functions prototypes.

I'm guessing that this is explicitly enabling the missing prototypes warning. I'm not a huge fan of that for compilation units that don't have public headers, it makes the code more complex and doesn't catch any bugs. It's valuable only when you have a public header and want to ensure that it's in sync with the implementation.

May 13 2020, 5:21 AM · Restricted Project
krytarowski added a comment to D79845: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n to bool.

https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html

May 13 2020, 5:21 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

I've separated two independent changes out of this revision into a separate review.
D79845 + D79846.

May 13 2020, 3:43 AM · Restricted Project
krytarowski created D79846: [compiler-rt] [builtin] Add public functions prototypes.
May 13 2020, 3:43 AM · Restricted Project
krytarowski created D79845: [compiler-rt] [builtin] Switch the return type of __atomic_compare_exchange_##n to bool.
May 13 2020, 3:43 AM · Restricted Project

May 12 2020

krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

will be "stuck" making sure that libatomic builds on GCC forever.

Generally... we [used to] build everything in compiler-rt with GCC except this single file.

Interesting! Where is the corresponding build system change in this patch?

May 12 2020, 3:04 PM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

will be "stuck" making sure that libatomic builds on GCC forever.

May 12 2020, 1:27 PM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

I rewrote this code again to support GCC. This time without removal of _Atomic().

May 12 2020, 11:16 AM · Restricted Project
krytarowski updated the diff for D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 12 2020, 11:16 AM · Restricted Project
krytarowski added inline comments to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 12 2020, 8:01 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

it's quite easy to define a C++ template that switches from lock-free to having an inline lock

May 12 2020, 4:15 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

To give some background (please correct me if I'm wrong): This is initially motivated by having snmalloc working on NetBSD.

May 12 2020, 4:15 AM · Restricted Project
krytarowski updated the diff for D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
  • drop ABI change in __atomic_compare_exchange_##n
May 12 2020, 3:43 AM · Restricted Project

May 11 2020

krytarowski added inline comments to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 12:22 PM · Restricted Project
krytarowski added inline comments to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 11:17 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
In D79713#2029514, @jfb wrote:

Without looking at the details, this generally seems fine... but why is this desirable? The commit message should have that information. If there's not really a reason then I'd rather leave it alone and not change something that's fine.

May 11 2020, 9:07 AM · Restricted Project
krytarowski updated the diff for D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 8:34 AM · Restricted Project
krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

I don't think that this should be including <stdatomic.h>. These routines are used to implement interfaces in <stdatomic.h> and it would be completely valid for a conforming implementation to use _Generic macros to directly call these functions from things in <stdatomic.h> that we then depend call, giving a circular dependency.

I don't particularly object to moving this to using the GCC builtins, since clang supports both the GCC ones and the __c11 ones, but the only two valid implementations of the routines in this file are to use compiler builtins or inline assembly.

May 11 2020, 8:34 AM · Restricted Project
krytarowski created D79713: [compiler-rt] [builtins] Port atomic.c to GCC.
May 11 2020, 5:52 AM · Restricted Project