Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2020

pestctrl added a comment to D79945: [Sema] Comparison of pointers to complete and incomplete types.

Benson Chu <bensonchu457@gmail.com>

Jun 17 2020, 2:02 PM · Restricted Project

Jun 16 2020

pestctrl added a comment to D79945: [Sema] Comparison of pointers to complete and incomplete types.

@rsmith @efriedma Any more comments?

Jun 16 2020, 6:37 AM · Restricted Project

Jun 11 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Moved the extension to C11 group

Jun 11 2020, 7:42 AM · Restricted Project
pestctrl added inline comments to D79945: [Sema] Comparison of pointers to complete and incomplete types.
Jun 11 2020, 7:42 AM · Restricted Project

Jun 10 2020

pestctrl added inline comments to D79945: [Sema] Comparison of pointers to complete and incomplete types.
Jun 10 2020, 2:28 PM · Restricted Project
pestctrl added inline comments to D79945: [Sema] Comparison of pointers to complete and incomplete types.
Jun 10 2020, 8:12 AM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Don't diagnose outside of C99

Jun 10 2020, 6:32 AM · Restricted Project

Jun 9 2020

pestctrl added inline comments to D79945: [Sema] Comparison of pointers to complete and incomplete types.
Jun 9 2020, 7:05 AM · Restricted Project

Jun 8 2020

pestctrl added a comment to D79945: [Sema] Comparison of pointers to complete and incomplete types.

@efriedma Any more comments?

Jun 8 2020, 8:11 AM · Restricted Project

Jun 2 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Copy pasted error messages

Jun 2 2020, 12:37 PM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Copy pasted error message

Jun 2 2020, 12:05 PM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Tests need to contain the full error message

Jun 2 2020, 10:25 AM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Updated test with new error message

Jun 2 2020, 9:19 AM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Updated warning message to be more descriptive

Jun 2 2020, 7:08 AM · Restricted Project

May 28 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

clang-format for the test file

May 28 2020, 8:07 AM · Restricted Project

May 27 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

ext_typecheck_compare_complete_incomplete_pointers:

  • Moved to group C11.
May 27 2020, 1:36 PM · Restricted Project
pestctrl added inline comments to D79945: [Sema] Comparison of pointers to complete and incomplete types.
May 27 2020, 1:36 PM · Restricted Project

May 26 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Forgot to add a comma >_<

May 26 2020, 8:06 AM · Restricted Project

May 25 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Rebase on master?

May 25 2020, 4:37 PM · Restricted Project

May 23 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Rebase on master.

May 23 2020, 10:17 PM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Both extension and extwarn need to be in the c99-extensions group

May 23 2020, 8:41 PM · Restricted Project
pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Added warning to group c99-extensions, only enable warning when C99 or less

May 23 2020, 4:27 PM · Restricted Project

May 22 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Changed error to warning, only emit during a relational operation

May 22 2020, 3:34 PM · Restricted Project
pestctrl added a comment to D79945: [Sema] Comparison of pointers to complete and incomplete types.

Hey @efriedma, thanks again for the comments.

May 22 2020, 3:34 PM · Restricted Project

May 21 2020

pestctrl added a comment to D79945: [Sema] Comparison of pointers to complete and incomplete types.

Ah, you're right. I don't see the clause in the C11 standard. I'll see what I can do. Thanks!

May 21 2020, 8:03 AM · Restricted Project

May 20 2020

pestctrl added a comment to D79945: [Sema] Comparison of pointers to complete and incomplete types.

@efriedma I think you were the last person to touch this code regarding cases where pointer comparisons are invalid. Could you have a look at my changes and gimme some feedback?

May 20 2020, 2:18 PM · Restricted Project
pestctrl added reviewers for D79945: [Sema] Comparison of pointers to complete and incomplete types: efriedma, rjmccall.
May 20 2020, 2:18 PM · Restricted Project

May 18 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Rebased on top of master using arc

May 18 2020, 12:27 PM · Restricted Project

May 14 2020

pestctrl updated the diff for D79945: [Sema] Comparison of pointers to complete and incomplete types.

Updated test to also expect a warning along with the newly added error.

May 14 2020, 2:08 PM · Restricted Project
pestctrl created D79945: [Sema] Comparison of pointers to complete and incomplete types.
May 14 2020, 8:38 AM · Restricted Project