Page MenuHomePhabricator
Feed Advanced Search

Aug 13 2019

xiaobai closed D66102: [Symbol] Decouple clang from CompilerType.
Aug 13 2019, 12:41 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Aug 13 2019, 10:34 AM · Restricted Project, Restricted Project

Aug 12 2019

xiaobai committed rGf4446f177505: [Symbol] Remove redundant include (authored by xiaobai).
[Symbol] Remove redundant include
Aug 12 2019, 5:27 PM
xiaobai committed rL368638: [Symbol] Remove redundant include.
[Symbol] Remove redundant include
Aug 12 2019, 5:25 PM
xiaobai created D66102: [Symbol] Decouple clang from CompilerType.
Aug 12 2019, 11:55 AM · Restricted Project, Restricted Project
xiaobai added a reviewer for D66102: [Symbol] Decouple clang from CompilerType: labath.
Aug 12 2019, 11:55 AM · Restricted Project, Restricted Project
xiaobai accepted D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..

I appreciate you adding more error handling. Thank you!

Aug 12 2019, 11:11 AM · Restricted Project, Restricted Project

Aug 7 2019

xiaobai committed rG4cd04547f52e: [Symbol] Remove commented out code from CompileUnit (authored by xiaobai).
[Symbol] Remove commented out code from CompileUnit
Aug 7 2019, 1:52 PM
xiaobai committed rL368205: [Symbol] Remove commented out code from CompileUnit.
[Symbol] Remove commented out code from CompileUnit
Aug 7 2019, 1:50 PM

Aug 6 2019

xiaobai committed rG5fdf10bae878: [SymbolFile] Remove commented out method (authored by xiaobai).
[SymbolFile] Remove commented out method
Aug 6 2019, 12:47 PM
xiaobai committed rL368075: [SymbolFile] Remove commented out method.
[SymbolFile] Remove commented out method
Aug 6 2019, 12:46 PM

Aug 5 2019

xiaobai accepted D65782: [CompilerType] Simplify the interface a bit more...
Aug 5 2019, 4:35 PM · Restricted Project, Restricted Project
xiaobai accepted D65781: [CompilerType] Remove an unused function..
Aug 5 2019, 4:16 PM · Restricted Project, Restricted Project

Jul 31 2019

xiaobai added a reviewer for D65548: Make JITDylib ignore Exported flag: lhames.
Jul 31 2019, 4:43 PM · Restricted Project
xiaobai committed rG70402bfc46e0: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai).
[API] Remove use of ClangASTContext from SBTarget
Jul 31 2019, 1:49 PM
xiaobai committed rL367480: [API] Remove use of ClangASTContext from SBTarget.
[API] Remove use of ClangASTContext from SBTarget
Jul 31 2019, 1:47 PM
xiaobai closed D64964: [API] Remove use of ClangASTContext from SBTarget.
Jul 31 2019, 1:47 PM · Restricted Project

Jul 30 2019

xiaobai updated the diff for D64964: [API] Remove use of ClangASTContext from SBTarget.

Removed argument to GetScratchTypeSystems from SBTarget

Jul 30 2019, 5:54 PM · Restricted Project
xiaobai updated the diff for D64964: [API] Remove use of ClangASTContext from SBTarget.

Update GetScatchTypeSystems to account for changes to TypeSystem usage

Jul 30 2019, 5:50 PM · Restricted Project
xiaobai committed rGc1210c7e96fe: [SymbolFilePDB] Fix windows bots after rL367360 (authored by xiaobai).
[SymbolFilePDB] Fix windows bots after rL367360
Jul 30 2019, 4:48 PM
xiaobai committed rL367368: [SymbolFilePDB] Fix windows bots after rL367360.
[SymbolFilePDB] Fix windows bots after rL367360
Jul 30 2019, 4:47 PM
xiaobai committed rG0e252e38ef84: [Symbol] Use llvm::Expected when getting TypeSystems (authored by xiaobai).
[Symbol] Use llvm::Expected when getting TypeSystems
Jul 30 2019, 3:13 PM
xiaobai committed rL367360: [Symbol] Use llvm::Expected when getting TypeSystems.
[Symbol] Use llvm::Expected when getting TypeSystems
Jul 30 2019, 3:12 PM
xiaobai closed D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 30 2019, 3:11 PM · Restricted Project
xiaobai committed rG072317311473: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module (authored by xiaobai).
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module
Jul 30 2019, 2:23 PM
xiaobai committed rL367358: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module.
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module
Jul 30 2019, 2:23 PM
xiaobai accepted D65450: Add llvm-style RTTI to ObjectFile hierarchy.

LGTM

Jul 30 2019, 10:50 AM · Restricted Project

Jul 29 2019

xiaobai added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

I think this change has introduced a dependence on x64.

I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp.
This is because the version of _CONTEXT included by winnt.h is for x32 and not x64.

i.e., llvm-project\lldb\source\plugins\process\windows\common\x64\registercontextwindows_x64.cpp(297): error C2039: 'Rax': is not a member of '_CONTEXT'

Jul 29 2019, 5:53 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 29 2019, 2:44 PM · Restricted Project
xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Small logic change in SBModule

Jul 29 2019, 2:44 PM · Restricted Project
xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

I have one remark about the consumeError+LLDB_LOG pattern. As for whether this is better than status quo or not, I still don't have an opinion on that. :)

Jul 29 2019, 12:10 PM · Restricted Project
xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Fix incorrect error logging pattern

Jul 29 2019, 12:07 PM · Restricted Project

Jul 26 2019

xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Address comments:

  • Use Expected<TypeSystem&>
  • Did some formatting
  • Made error checking more explicit
Jul 26 2019, 5:53 PM · Restricted Project
xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

I'm going to update this diff with what I changed to give y'all a better idea of what has been changed. I shoulda done that to begin with... :P

Jul 26 2019, 11:17 AM · Restricted Project

Jul 25 2019

xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

After going through this and modifying this patch, I can't help but wonder if llvm::Optional<TypeSystem &> would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move on. I am conflicted because I like how Expected forces you to be more rigorous with error handling but I can't help but feel it is the wrong abstraction. Thoughts?

Jul 25 2019, 7:52 PM · Restricted Project
xiaobai accepted D65185: Let tablegen generate property definitions.

I think this is fine. Using .def files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter

Jul 25 2019, 12:32 PM · Restricted Project, Restricted Project

Jul 24 2019

xiaobai committed rGeb6782758a54: [Symbol] Fix some botched logic in Variable::GetLanguage (authored by xiaobai).
[Symbol] Fix some botched logic in Variable::GetLanguage
Jul 24 2019, 3:14 PM
xiaobai committed rL366950: [Symbol] Fix some botched logic in Variable::GetLanguage.
[Symbol] Fix some botched logic in Variable::GetLanguage
Jul 24 2019, 3:14 PM
xiaobai closed D65165: [Symbol] Fix some botched logic in Variable::GetLanguage.
Jul 24 2019, 3:14 PM · Restricted Project
xiaobai updated the diff for D65165: [Symbol] Fix some botched logic in Variable::GetLanguage.

Implement suggestion

Jul 24 2019, 3:14 PM · Restricted Project

Jul 23 2019

xiaobai added inline comments to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 23 2019, 3:57 PM · Restricted Project
xiaobai added reviewers for D65165: [Symbol] Fix some botched logic in Variable::GetLanguage: JDevlieghere, jingham.
Jul 23 2019, 3:40 PM · Restricted Project
xiaobai committed rG45a3fd206fb0: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 (authored by xiaobai).
[lldb][test_suite] Update tests with unexpected pass on Android aarch64
Jul 23 2019, 3:15 PM
xiaobai committed rL366858: [lldb][test_suite] Update tests with unexpected pass on Android aarch64.
[lldb][test_suite] Update tests with unexpected pass on Android aarch64
Jul 23 2019, 3:15 PM
xiaobai closed D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64.
Jul 23 2019, 3:15 PM · Restricted Project, Restricted Project
xiaobai created D65165: [Symbol] Fix some botched logic in Variable::GetLanguage.
Jul 23 2019, 1:31 PM · Restricted Project
xiaobai added a comment to D65155: [lldb] Remove Xcode project legacy.

Not directly related, but there's some other legacy cruft I figure are valid for removal. e.g.

utils/sync-source
misc/grep-svn-log.py
git-svn/convert.py

r366827.

Jul 23 2019, 10:44 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D64042: [Symbol] Improve Variable::GetLanguage.
Jul 23 2019, 10:36 AM · Restricted Project

Jul 22 2019

xiaobai committed rGc7f9bfb0e4ba: [lldb][test_suite] Fix skipIfTargetAndroid decorator (authored by xiaobai).
[lldb][test_suite] Fix skipIfTargetAndroid decorator
Jul 22 2019, 5:42 PM
xiaobai committed rL366771: [lldb][test_suite] Fix skipIfTargetAndroid decorator.
[lldb][test_suite] Fix skipIfTargetAndroid decorator
Jul 22 2019, 5:41 PM
xiaobai closed D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator.
Jul 22 2019, 5:41 PM · Restricted Project, Restricted Project
xiaobai committed rGe5001fe5c1ac: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up (authored by xiaobai).
[lldb][test_suite] skip tests of `libstdcpp` on Android and clean up
Jul 22 2019, 5:29 PM
xiaobai committed rL366770: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up.
[lldb][test_suite] skip tests of `libstdcpp` on Android and clean up
Jul 22 2019, 5:29 PM
xiaobai closed D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up.
Jul 22 2019, 5:29 PM · Restricted Project, Restricted Project
xiaobai accepted D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590.

Thanks for restoring them.

Jul 22 2019, 3:58 PM · Restricted Project, Restricted Project
xiaobai created D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 22 2019, 3:40 PM · Restricted Project
xiaobai committed rG4de5d9d61213: [Symbol] Improve Variable::GetLanguage (authored by xiaobai).
[Symbol] Improve Variable::GetLanguage
Jul 22 2019, 1:15 PM
xiaobai committed rL366733: [Symbol] Improve Variable::GetLanguage.
[Symbol] Improve Variable::GetLanguage
Jul 22 2019, 1:15 PM
xiaobai closed D64042: [Symbol] Improve Variable::GetLanguage.
Jul 22 2019, 1:15 PM · Restricted Project

Jul 19 2019

xiaobai abandoned D65025: [Symbol] Improve TypeSystemMap mutex safety.

Actually from the looks of it, I completely misunderstood what's going on here. It looks like AddToMap should only be called by things that hold the mutex, meaning that this change isn't actually necessary. I do think that makes this code kind of frustrating to understand though. Closing.

Jul 19 2019, 4:04 PM
xiaobai added a comment to D64042: [Symbol] Improve Variable::GetLanguage.

ping

Jul 19 2019, 3:34 PM · Restricted Project
xiaobai created D65025: [Symbol] Improve TypeSystemMap mutex safety.
Jul 19 2019, 3:30 PM
xiaobai accepted D64994: [CMake] Align debugserver with lldb-server on Darwin.

Excellent, thanks for taking care of this! :)

Jul 19 2019, 10:57 AM · Restricted Project, Restricted Project

Jul 18 2019

xiaobai added a comment to D64964: [API] Remove use of ClangASTContext from SBTarget.

All uses of this new function drop the error on the ground. Does that mean it doesn't matter? If it does, should we return an expected instead? Should we stop on the first error, or is it fine to overwrite when iterating over languages_for_expressions? It seems like the error handling needs some more work here.

Jul 18 2019, 10:48 PM · Restricted Project
xiaobai committed rGbb0896970afa: [NFC] Remove instances of unused ClangASTContext header (authored by xiaobai).
[NFC] Remove instances of unused ClangASTContext header
Jul 18 2019, 5:40 PM
xiaobai committed rL366519: [NFC] Remove instances of unused ClangASTContext header.
[NFC] Remove instances of unused ClangASTContext header
Jul 18 2019, 5:39 PM
xiaobai committed rG3e4a13a7f0b0: [Commands] Remove unused header from CommandObjectFrame (authored by xiaobai).
[Commands] Remove unused header from CommandObjectFrame
Jul 18 2019, 5:27 PM
xiaobai committed rL366517: [Commands] Remove unused header from CommandObjectFrame.
[Commands] Remove unused header from CommandObjectFrame
Jul 18 2019, 5:26 PM
xiaobai created D64964: [API] Remove use of ClangASTContext from SBTarget.
Jul 18 2019, 5:11 PM · Restricted Project
xiaobai added inline comments to D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one.
Jul 18 2019, 5:07 PM · Restricted Project, Restricted Project
xiaobai accepted D64959: [cmake] Update NATIVE build variables to account for standalone changes.

LGTM

Jul 18 2019, 4:37 PM · Restricted Project
xiaobai committed rG79976b379001: [Breakpoint] Replace use of ClangASTContext with TypeSystem (authored by xiaobai).
[Breakpoint] Replace use of ClangASTContext with TypeSystem
Jul 18 2019, 1:59 PM
xiaobai committed rL366495: [Breakpoint] Replace use of ClangASTContext with TypeSystem.
[Breakpoint] Replace use of ClangASTContext with TypeSystem
Jul 18 2019, 1:58 PM

Jul 17 2019

xiaobai added a comment to D64844: [Target] Remove Target::GetScratchClangASTContext.

Yes, I agree that replacing ClangASTContext uses with TypeSystem would be the right thing to do, and it's what I plan on doing next. There are instances where you really do want a ClangASTContext (e.g. in plugins related to clang expression parsing and objc), and so having a convenience function like this means you don't have to cast the result of every call. This is similar to ObjCLanguageRuntime::Get. I don't mind abandoning this patch though.

Jul 17 2019, 12:50 PM · Restricted Project
xiaobai added a comment to D64844: [Target] Remove Target::GetScratchClangASTContext.

This seems partly wrong to me. The point is that the Target holds scratch AST contexts for all the languages it supports. They are the central repository for the accumulation of effects of expressions evaluated while that target is alive. For instance, all the user defined types and variables go there. The Target also manages its lifecycle. For instance, in the swift case if there's a module that we can't import, we have to fall back to making an AST Context for each module we can successfully import and dispatching expressions to the appropriate one of those.

So all the Scratch AST Contexts are properly owned by the target.

This move doesn't keep all the clients from knowing they are getting their hands on a ClangASTContext, so it doesn't seem like it achieves much hiding. All it does is conceal the ownership of the scratch AST context for C-family languages.

Jul 17 2019, 11:28 AM · Restricted Project
xiaobai accepted D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator.

LGTM

Jul 17 2019, 11:13 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D64823: [CMake] Use LLVM_DIR and Clang_DIR for standalone builds..
Jul 17 2019, 11:10 AM · Restricted Project, Restricted Project
xiaobai accepted D64847: Only build lldb-tblgen if it's not a current target.

This is a pretty interesting use case to say the least. I don't see an issue with it though, so go for it.

Jul 17 2019, 11:04 AM
xiaobai added a comment to D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one.

I think that this is a good change overall to do but the name LLDB_USE_SYSTEM_DEBUGSERVER is kind of a confusing to me. The name itself doesn't really convey to me that the system debugserver is going to be used for just testing. Before this change, that flag indicated that the system debugserver was going to be used for everything. Maybe you could change it to something like LLDB_TEST_WITH_SYSTEM_DEBUGSERVER?

Jul 17 2019, 11:01 AM · Restricted Project, Restricted Project
xiaobai committed rGfc1c8f5d7d47: [Target][NFCI] Remove commented out code (authored by xiaobai).
[Target][NFCI] Remove commented out code
Jul 17 2019, 12:14 AM
xiaobai committed rL366295: [Target][NFCI] Remove commented out code.
[Target][NFCI] Remove commented out code
Jul 17 2019, 12:13 AM
xiaobai committed rGe574f8b3d891: [Target][NFCI] Rename variable (authored by xiaobai).
[Target][NFCI] Rename variable
Jul 17 2019, 12:04 AM
xiaobai committed rL366292: [Target][NFCI] Rename variable.
[Target][NFCI] Rename variable
Jul 17 2019, 12:03 AM

Jul 16 2019

xiaobai updated the diff for D64844: [Target] Remove Target::GetScratchClangASTContext.

Remove ClangASTContext header from Target.cpp

Jul 16 2019, 6:37 PM · Restricted Project
xiaobai created D64844: [Target] Remove Target::GetScratchClangASTContext.
Jul 16 2019, 6:33 PM · Restricted Project
xiaobai accepted D64822: Don't require python exe and lib versions to match while crosscompiling.
Jul 16 2019, 4:51 PM · Restricted Project
xiaobai committed rG0e534de4fef8: [Symbol] Remove unused fields from ClangASTContext (authored by xiaobai).
[Symbol] Remove unused fields from ClangASTContext
Jul 16 2019, 2:06 PM
xiaobai committed rL366261: [Symbol] Remove unused fields from ClangASTContext.
[Symbol] Remove unused fields from ClangASTContext
Jul 16 2019, 2:05 PM
xiaobai accepted D64812: [CMake] Fail when Python interpreter doesn't match Python libraries version .

This definitely caused me some pain a few months ago. Thanks for adding this!

Jul 16 2019, 11:20 AM · Restricted Project, Restricted Project

Jul 15 2019

xiaobai committed rG0d121273181f: [Target] Remove unused method Target::GetDefaultClangModuleSearchPaths (authored by xiaobai).
[Target] Remove unused method Target::GetDefaultClangModuleSearchPaths
Jul 15 2019, 6:03 PM
xiaobai committed rL366161: [Target] Remove unused method Target::GetDefaultClangModuleSearchPaths.
[Target] Remove unused method Target::GetDefaultClangModuleSearchPaths
Jul 15 2019, 6:03 PM
xiaobai committed rGb5701710a429: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin (authored by xiaobai).
[LanguageRuntime] Move ObjCLanguageRuntime into a plugin
Jul 15 2019, 3:57 PM
xiaobai committed rL366148: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin.
[LanguageRuntime] Move ObjCLanguageRuntime into a plugin
Jul 15 2019, 3:56 PM
xiaobai closed D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin.
Jul 15 2019, 3:56 PM · Restricted Project
xiaobai created D64763: [LanguageRuntime] Move ObjCLanguageRuntime into a plugin.
Jul 15 2019, 11:22 AM · Restricted Project

Jul 12 2019

xiaobai committed rGe0678ca5473d: [LanguageRuntime] Move CPPLanguageRuntime into a plugin (authored by xiaobai).
[LanguageRuntime] Move CPPLanguageRuntime into a plugin
Jul 12 2019, 1:11 PM
xiaobai committed rL365951: [LanguageRuntime] Move CPPLanguageRuntime into a plugin.
[LanguageRuntime] Move CPPLanguageRuntime into a plugin
Jul 12 2019, 1:11 PM
xiaobai closed D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin.
Jul 12 2019, 1:10 PM · Restricted Project
xiaobai accepted D64661: [ObjectContainerBSDArchive] Simplify a few things (NFC).

LGTM

Jul 12 2019, 1:04 PM · Restricted Project, Restricted Project
xiaobai committed rG24604ec799e0: [Core] Generalize ValueObject::MaybeCalculateCompleteType (authored by xiaobai).
[Core] Generalize ValueObject::MaybeCalculateCompleteType
Jul 12 2019, 11:36 AM