Page MenuHomePhabricator
Feed Advanced Search

Fri, Jan 17

xiaobai added a comment to D72946: [lldb] Remove ClangASTImporter reference from Target.

I wish we could do this without a global map. Also the ClangASTImporter shouldn't have a dependency on Target (I'm actually surprised this compiles without an additional include).

I'm not sure where the perfect place for the Target's ClangASTImporter is, but putting it in the ClangPersistentVariables would solve your problem of getting it out of Target and doesn't need a global map. Also in general the ClangASTImporter of the Target is used for copying stuff to the scratch context, so having it in the ClangPersistentVariables makes some sense.

Fri, Jan 17, 3:58 PM · Restricted Project
xiaobai created D72946: [lldb] Remove ClangASTImporter reference from Target.
Fri, Jan 17, 12:18 PM · Restricted Project

Thu, Jan 16

xiaobai committed rG9dbd395b9b8b: [lldb] Remove ClangASTContext.h inclusion in Target.cpp (authored by xiaobai).
[lldb] Remove ClangASTContext.h inclusion in Target.cpp
Thu, Jan 16, 10:53 PM
xiaobai accepted D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.
Thu, Jan 16, 12:56 PM · Restricted Project

Tue, Jan 14

xiaobai added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

We might also want to move these into lldb/source/Plugins/TypeSystem as well to complete this refactor?

Tue, Jan 14, 1:19 PM · Restricted Project
xiaobai added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

I like this idea quite a bit, but have no preference for ClangTypeSystem or TypeSystemClang. +1 from me.

Tue, Jan 14, 11:02 AM · Restricted Project

Mon, Jan 13

xiaobai committed rG6d57511e0b6f: [lldb-server] Prefer target_include_directories (authored by xiaobai).
[lldb-server] Prefer target_include_directories
Mon, Jan 13, 2:58 PM
xiaobai added a comment to D69820: [Symbol] Add TypeSystem::GetClassName.

Let me know what everyone thinks of adding a "fully_qualified" argument to the TypeSystem::GetClassName()?

Mon, Jan 13, 12:00 PM · Restricted Project
xiaobai committed rG2bb154591fab: [lldb-server] Remove dead CMake code (authored by xiaobai).
[lldb-server] Remove dead CMake code
Mon, Jan 13, 11:50 AM

Fri, Jan 10

xiaobai updated the diff for D69820: [Symbol] Add TypeSystem::GetClassName.

Rebase

Fri, Jan 10, 3:31 PM · Restricted Project
xiaobai accepted D72541: [lldb/Utils] Remove vim-lldb.

The only things that have touched vim-lldb in the past 5-6 years have been the result of repository-wide changes (e.g. reformatting, documentation changes, python compatability and version transitions, etc).

Fri, Jan 10, 2:16 PM · Restricted Project

Wed, Jan 8

xiaobai committed rGa63af915288a: [lldb] Remove various dead Compare functions (authored by xiaobai).
[lldb] Remove various dead Compare functions
Wed, Jan 8, 6:33 PM

Thu, Jan 2

xiaobai added a comment to D72107: [lldb/CMake] Autodetect Python dependency.

Do you mean forcing LLDB_ENABLE_PYTHON to on so that it fails in case the logic changes and Python isn't found?

Thu, Jan 2, 2:13 PM · Restricted Project
xiaobai added a comment to D72107: [lldb/CMake] Autodetect Python dependency.

It's nice to consolidate the logic into one place. I think you will probably need to make an appropriate change on the buildbot side as well (if you haven't done that already).

Thu, Jan 2, 2:00 PM · Restricted Project

Mon, Dec 23

xiaobai committed rG187f66bcac66: [lldb/CMake] Always set a value for find_package when finding optional… (authored by xiaobai).
[lldb/CMake] Always set a value for find_package when finding optional…
Mon, Dec 23, 1:40 PM

Dec 17 2019

xiaobai committed rGb3f789e037cb: [perf-training] Change profile file pattern string to use %4m instead of %p (authored by xinxinw1).
[perf-training] Change profile file pattern string to use %4m instead of %p
Dec 17 2019, 12:23 PM
xiaobai closed D71585: [perf-training] Change profile file pattern string to use %4m instead of %p.
Dec 17 2019, 12:23 PM · Restricted Project
xiaobai added a reviewer for D71585: [perf-training] Change profile file pattern string to use %4m instead of %p: vsk.

Adding @vsk since he added the code that you're referencing in your summary.

Dec 17 2019, 10:44 AM · Restricted Project

Dec 16 2019

xiaobai committed rGd6777207b4fd: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps (authored by xinxinw1).
[llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps
Dec 16 2019, 5:03 PM
xiaobai closed D71430: [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps.
Dec 16 2019, 5:03 PM · Restricted Project
xiaobai committed rGf5bbe387e885: [llvm] Add llvm-lipo dependency to runtimes (authored by xinxinw1).
[llvm] Add llvm-lipo dependency to runtimes
Dec 16 2019, 4:07 PM
xiaobai closed D71429: [llvm] Add llvm-lipo dependency to runtimes.
Dec 16 2019, 4:07 PM · Restricted Project
xiaobai committed rG3fbe518a102a: [lldb] Respect previously set values of LLDB_TABLEGEN_EXE (authored by xiaobai).
[lldb] Respect previously set values of LLDB_TABLEGEN_EXE
Dec 16 2019, 2:39 PM

Dec 12 2019

xiaobai committed rG3031818a2e9f: [Target] Remove Target::GetScratchClangASTContext (authored by xiaobai).
[Target] Remove Target::GetScratchClangASTContext
Dec 12 2019, 3:55 PM
xiaobai committed rG44d12bcc4471: Replace last uses of llvm::index_sequence{,_for} (authored by xiaobai).
Replace last uses of llvm::index_sequence{,_for}
Dec 12 2019, 2:33 PM
xiaobai committed rG48837a3a4450: Remove merge marker (authored by xiaobai).
Remove merge marker
Dec 12 2019, 2:32 PM
xiaobai closed D64844: [Target] Remove Target::GetScratchClangASTContext.
Dec 12 2019, 12:03 PM · Restricted Project
xiaobai added a comment to D64844: [Target] Remove Target::GetScratchClangASTContext.

Landed as commit 3031818a2e9fca1e53cd882ccfcc3718699991b4

Dec 12 2019, 12:03 PM · Restricted Project

Dec 11 2019

xiaobai added a comment to D71306: [RFC] Change how we deal with optional dependencies.

I personally prefer the third approach. To make sure I understand correctly, I'll write it in my own words so you can correct me if I misunderstood.
Try to find the dependency, and if we find it then use it. If not, then we can print out something like "Didn't find DEPENDENCY" and continue on our merry way. If the user overwrites the values and something goes wrong, send a fatal error and tell them that what the value they set isn't going to work without further work (e.g. explicitly enable python support but didn't find python? tell the user that you couldn't find python and maybe suggest setting some other CMake variables to help CMake find python).

How exactly does this "overwriting" work? Could you point me to the code that does this? I don't remember seeing anything like this, but the llvm build is not entirely consistent either, so it's possible we're looking at different things...

Dec 11 2019, 10:39 AM · Restricted Project

Dec 10 2019

xiaobai added a comment to D71306: [RFC] Change how we deal with optional dependencies.

I personally prefer the third approach. To make sure I understand correctly, I'll write it in my own words so you can correct me if I misunderstood.
Try to find the dependency, and if we find it then use it. If not, then we can print out something like "Didn't find DEPENDENCY" and continue on our merry way. If the user overwrites the values and something goes wrong, send a fatal error and tell them that what the value they set isn't going to work without further work (e.g. explicitly enable python support but didn't find python? tell the user that you couldn't find python and maybe suggest setting some other CMake variables to help CMake find python).

Dec 10 2019, 3:38 PM · Restricted Project
xiaobai updated the diff for D69820: [Symbol] Add TypeSystem::GetClassName.

Add fixme

Dec 10 2019, 11:42 AM · Restricted Project

Dec 9 2019

xiaobai added inline comments to D71237: [FormatEntity] Add mangled function name support.
Dec 9 2019, 5:16 PM · Restricted Project
xiaobai added inline comments to D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype.
Dec 9 2019, 5:07 PM · Restricted Project
xiaobai added a comment to D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter.

I'm really excited to see where this goes! :D

Dec 9 2019, 5:07 PM · Restricted Project
xiaobai added inline comments to D69820: [Symbol] Add TypeSystem::GetClassName.
Dec 9 2019, 5:01 PM · Restricted Project
xiaobai updated the diff for D69820: [Symbol] Add TypeSystem::GetClassName.

Address feedback from @teemperor

Dec 9 2019, 4:43 PM · Restricted Project
xiaobai added a comment to D64844: [Target] Remove Target::GetScratchClangASTContext.

ping @jingham @teemperor any issues with this going in? I'd like to land this soon.

Dec 9 2019, 1:40 PM · Restricted Project
xiaobai updated the diff for D64844: [Target] Remove Target::GetScratchClangASTContext.

Rebase

Dec 9 2019, 1:40 PM · Restricted Project

Nov 14 2019

xiaobai updated the diff for D64844: [Target] Remove Target::GetScratchClangASTContext.

Rebased
Moved this change to the monorepo layout
Moved ClangASTContext::GetScratch to the ClangASTContext header

Nov 14 2019, 2:54 PM · Restricted Project

Nov 11 2019

xiaobai accepted D70074: [lldb][NFC] Remove unused CompilerType::IsPossibleCPlusPlusDynamicType.
Nov 11 2019, 10:31 AM · Restricted Project

Nov 6 2019

xiaobai committed rGa6b5daa701d3: [test] Fix apple_simulator_test decorator when simulators are unavailable (authored by xiaobai).
[test] Fix apple_simulator_test decorator when simulators are unavailable
Nov 6 2019, 3:15 PM

Nov 5 2019

xiaobai committed rG40f3d1307cfd: [TestMTCSimple] Disable the test if you don't have libMTC (authored by xiaobai).
[TestMTCSimple] Disable the test if you don't have libMTC
Nov 5 2019, 2:20 PM

Nov 4 2019

xiaobai created D69820: [Symbol] Add TypeSystem::GetClassName.
Nov 4 2019, 1:00 PM · Restricted Project

Oct 31 2019

xiaobai committed rGdb542455dc0f: [Symbol] Change ClangASTContext::GetCXXClassName return type (authored by xiaobai).
[Symbol] Change ClangASTContext::GetCXXClassName return type
Oct 31 2019, 12:06 PM
xiaobai closed D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type.
Oct 31 2019, 12:06 PM · Restricted Project

Oct 30 2019

xiaobai updated the diff for D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type.

Use llvm::Optional

Oct 30 2019, 3:27 PM · Restricted Project
xiaobai added a comment to D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type.

Could this return an Optional<std::string> or Expected<std::string>? It's not clear from a std::string return value that the method can fail and it will return an empty string on error.

Oct 30 2019, 2:12 PM · Restricted Project
xiaobai created D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type.
Oct 30 2019, 2:02 PM · Restricted Project

Oct 25 2019

xiaobai accepted D69412: build: avoid hardcoding the libxml2 library name.
Oct 25 2019, 3:15 PM · Restricted Project

Oct 24 2019

xiaobai accepted D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER.

I thought this option was so that you could specify which compilers to use to build from a cache or command line? I don't think you just want to set LLDB_TEST_COMPILER to clang since clang++ is what is used to compile C++ code. Maybe I'm mis-remembering or mistaken here.

Yes, that's indeed the point. However, dotest expects you to set the C compiler and then infers the C++ compiler from it, which for clang is just appending ++ at the end. I'm sure it must do something sensible for gcc as well, as I believe people are running the test suite with that compiler.

Oct 24 2019, 2:40 PM · Restricted Project
xiaobai added a comment to D69407: build: remove `LLVM_CXX_STD` extension point.

Why do you want LLVM_CXX_STD to be removed? I suppose somebody will eventually add LLVM_ENABLE_CXX2A, which will require additional logic to ensure that somebody doesn't set LLVM_ENABLE_CXX2A and LLVM_ENABLE_CXX1Z at the same time. I think this can be avoided by removing LLVM_ENABLE_CXX1Z entirely and going through LLVM_CXX_STD entirely.

Oct 24 2019, 2:38 PM · Restricted Project
xiaobai added inline comments to D69407: build: remove `LLVM_CXX_STD` extension point.
Oct 24 2019, 2:38 PM · Restricted Project
xiaobai added a comment to D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER.

I thought this option was so that you could specify which compilers to use to build from a cache or command line? I don't think you just want to set LLDB_TEST_COMPILER to clang since clang++ is what is used to compile C++ code. Maybe I'm mis-remembering or mistaken here.

Oct 24 2019, 2:14 PM · Restricted Project

Oct 11 2019

xiaobai committed rG03fbde6d8470: [NativePDB] Remove unused references to ClangASTImporter (authored by xiaobai).
[NativePDB] Remove unused references to ClangASTImporter
Oct 11 2019, 1:15 PM
xiaobai committed rL374587: [NativePDB] Remove unused references to ClangASTImporter.
[NativePDB] Remove unused references to ClangASTImporter
Oct 11 2019, 1:14 PM

Oct 10 2019

xiaobai committed rG887707e29d31: [lldb-test] Remove unused header (authored by xiaobai).
[lldb-test] Remove unused header
Oct 10 2019, 3:49 PM
xiaobai committed rL374468: [lldb-test] Remove unused header.
[lldb-test] Remove unused header
Oct 10 2019, 3:49 PM

Oct 8 2019

xiaobai accepted D68614: [LLDB] Remove standalone build dep on llvm-strip.

LGTM

Oct 8 2019, 3:28 PM · Restricted Project
xiaobai closed D68613: [CMake] Fix building without python on Windows.

rL374100

Oct 8 2019, 3:28 PM · Restricted Project
xiaobai committed rG28fcc033c883: [CMake] Fix building without python on Windows (authored by xiaobai).
[CMake] Fix building without python on Windows
Oct 8 2019, 11:44 AM
xiaobai committed rL374100: [CMake] Fix building without python on Windows.
[CMake] Fix building without python on Windows
Oct 8 2019, 11:44 AM

Oct 7 2019

xiaobai committed rGf4c7345b88f8: [Symbol] Remove unused method ClangASTContext::GetObjCClassName (authored by xiaobai).
[Symbol] Remove unused method ClangASTContext::GetObjCClassName
Oct 7 2019, 10:24 PM
xiaobai committed rL373990: [Symbol] Remove unused method ClangASTContext::GetObjCClassName.
[Symbol] Remove unused method ClangASTContext::GetObjCClassName
Oct 7 2019, 10:23 PM
xiaobai added a reviewer for D68614: [LLDB] Remove standalone build dep on llvm-strip: JDevlieghere.

@JDevlieghere has been touching similar things today. You should coordinate with him on this change.

Oct 7 2019, 5:40 PM · Restricted Project
xiaobai created D68613: [CMake] Fix building without python on Windows.
Oct 7 2019, 5:30 PM · Restricted Project
xiaobai accepted D68612: [CMake] Track test dependencies with add_lldb_test_dependency.

Looks good to me. I find it interesting that we had an lldb-test-deps custom target before but most things were depending on ${LLDB_TEST_DEPS} anyway.

Oct 7 2019, 5:15 PM · Restricted Project, Restricted Project
xiaobai accepted D68606: [test] Split LLDB tests into filecheck, unittest and dotest..
Oct 7 2019, 4:51 PM · Restricted Project

Oct 4 2019

xiaobai committed rG9627b26c40a1: [libc++] Guard cxx_experimental settings behind… (authored by xiaobai).
[libc++] Guard cxx_experimental settings behind…
Oct 4 2019, 4:10 PM
xiaobai committed rL373809: [libc++] Guard cxx_experimental settings behind….
[libc++] Guard cxx_experimental settings behind…
Oct 4 2019, 4:07 PM

Sep 27 2019

xiaobai committed rG92f151738bfe: [Core] Remove unused dependency on clangAST (authored by xiaobai).
[Core] Remove unused dependency on clangAST
Sep 27 2019, 5:27 PM
xiaobai committed rL373134: [Core] Remove unused dependency on clangAST.
[Core] Remove unused dependency on clangAST
Sep 27 2019, 5:27 PM

Sep 26 2019

xiaobai committed rG7dfb095b882d: [lldb-vscode] correctly handle multiple sourceMap entries (authored by xiaobai).
[lldb-vscode] correctly handle multiple sourceMap entries
Sep 26 2019, 2:25 PM
xiaobai committed rL373016: [lldb-vscode] correctly handle multiple sourceMap entries.
[lldb-vscode] correctly handle multiple sourceMap entries
Sep 26 2019, 2:16 PM
xiaobai closed D67569: [lldb-vscode] correctly handle multiple sourceMap entries.
Sep 26 2019, 2:16 PM · Restricted Project
xiaobai added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Sep 26 2019, 11:04 AM · Restricted Project, Restricted Project

Sep 25 2019

xiaobai added inline comments to D68048: [WIP][RFC] Improve fetching the process list on the android platform.
Sep 25 2019, 4:28 PM · Restricted Project
xiaobai added a comment to D68048: [WIP][RFC] Improve fetching the process list on the android platform.

There are some things still left.

architecture:
I don't know if we can simply reuse an existing variable and set it for all processes, or if we should really find the architecture of each process.

The only time we might run into an issue is when we have arm32 running on arm64. Not sure if that can be detected. For now we can deduce the devices architecture and apply to all?

Sep 25 2019, 4:16 PM · Restricted Project
xiaobai accepted D68040: [lldb] Excludes private headers from SWIG dependency..
Sep 25 2019, 11:16 AM · Restricted Project, Restricted Project
xiaobai accepted D68039: [lit] Do a better job at parsing unsupported tests..

LGTM

Sep 25 2019, 11:13 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D68007: [lldb] Move swig call from python code to cmake.
Sep 25 2019, 11:00 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D68007: [lldb] Move swig call from python code to cmake.
Sep 25 2019, 10:55 AM · Restricted Project, Restricted Project

Sep 24 2019

xiaobai added inline comments to D67994: Modify lldb-test to print out ASTs from symbol file.
Sep 24 2019, 4:06 PM · Restricted Project
xiaobai accepted D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER.

No objections from me.

Sep 24 2019, 3:36 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER.
Sep 24 2019, 3:30 PM · Restricted Project, Restricted Project

Sep 23 2019

xiaobai committed rG86c3af90296a: [NFCI] Return PathSensitiveBugReport where appropriate (authored by xiaobai).
[NFCI] Return PathSensitiveBugReport where appropriate
Sep 23 2019, 3:30 PM
xiaobai committed rL372668: [NFCI] Return PathSensitiveBugReport where appropriate.
[NFCI] Return PathSensitiveBugReport where appropriate
Sep 23 2019, 3:27 PM

Sep 19 2019

xiaobai committed rG466fb68fce10: [NFCI] Always initialize const members of AttributeCommonInfo (authored by xiaobai).
[NFCI] Always initialize const members of AttributeCommonInfo
Sep 19 2019, 5:21 PM
xiaobai committed rL372363: [NFCI] Always initialize const members of AttributeCommonInfo.
[NFCI] Always initialize const members of AttributeCommonInfo
Sep 19 2019, 5:14 PM
xiaobai added a comment to D67569: [lldb-vscode] correctly handle multiple sourceMap entries.

@rmaz: I can land this for you if you would like me to.

Sep 19 2019, 1:56 PM · Restricted Project

Sep 13 2019

xiaobai added a comment to D67569: [lldb-vscode] correctly handle multiple sourceMap entries.

Looks fine to me. Any objections @clayborg?

Sep 13 2019, 2:03 PM · Restricted Project

Sep 12 2019

xiaobai committed rG5b2b38e053b4: [Target] Move InferiorCall to Process (authored by xiaobai).
[Target] Move InferiorCall to Process
Sep 12 2019, 5:05 PM
xiaobai committed rL371796: [Target] Move InferiorCall to Process.
[Target] Move InferiorCall to Process
Sep 12 2019, 5:01 PM
xiaobai closed D67472: [Target] Move InferiorCall to Process.
Sep 12 2019, 5:01 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67472: [Target] Move InferiorCall to Process.

Rename function in question to CallVoidArgVoidPtrReturn

Sep 12 2019, 3:56 PM · Restricted Project, Restricted Project
xiaobai updated the summary of D67472: [Target] Move InferiorCall to Process.
Sep 12 2019, 3:34 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67472: [Target] Move InferiorCall to Process.

Rename InferiorCall to CallNoArgNoReturnFunc
make CallNoArgReturnFunc public

Sep 12 2019, 3:34 PM · Restricted Project, Restricted Project

Sep 11 2019

xiaobai created D67472: [Target] Move InferiorCall to Process.
Sep 11 2019, 3:38 PM · Restricted Project, Restricted Project
xiaobai committed rG1b385a180250: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX (authored by xiaobai).
[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
Sep 11 2019, 1:40 PM
xiaobai committed rL371654: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
Sep 11 2019, 1:35 PM
xiaobai closed D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
Sep 11 2019, 1:35 PM · Restricted Project, Restricted Project