Page MenuHomePhabricator
Feed Advanced Search

Thu, Aug 22

xiaobai committed rGcb68bd726db4: [Symbol] Decouple clang from DeclVendor (authored by xiaobai).
[Symbol] Decouple clang from DeclVendor
Thu, Aug 22, 11:11 PM
xiaobai committed rL369735: [Symbol] Decouple clang from DeclVendor.
[Symbol] Decouple clang from DeclVendor
Thu, Aug 22, 11:10 PM
xiaobai closed D66628: [Symbol] Decouple clang from DeclVendor.
Thu, Aug 22, 11:10 PM · Restricted Project, Restricted Project
xiaobai created D66628: [Symbol] Decouple clang from DeclVendor.
Thu, Aug 22, 6:07 PM · Restricted Project, Restricted Project

Tue, Aug 20

xiaobai committed rG7719495e2cae: [Symbol] Remove unused clang headers from Type (authored by xiaobai).
[Symbol] Remove unused clang headers from Type
Tue, Aug 20, 9:57 PM
xiaobai committed rL369494: [Symbol] Remove unused clang headers from Type.
[Symbol] Remove unused clang headers from Type
Tue, Aug 20, 9:56 PM
xiaobai added a comment to D66102: [Symbol] Decouple clang from CompilerType.

I wouldn't mind adding something to reduce boilerplate, but I'm not sure it would actually look too different. A wrapper function or subclass constructor would need to take a ClangASTContext and a clang::QualType so we could avoid calls to getAsOpaquePtr() everywhere but that's about it I think?

Tue, Aug 20, 4:02 PM · Restricted Project, Restricted Project
xiaobai committed rGb2232a1af321: [Symbol] Move VerifyDecl to ClangASTContext (authored by xiaobai).
[Symbol] Move VerifyDecl to ClangASTContext
Tue, Aug 20, 3:08 PM
xiaobai committed rL369456: [Symbol] Move VerifyDecl to ClangASTContext.
[Symbol] Move VerifyDecl to ClangASTContext
Tue, Aug 20, 3:08 PM
xiaobai committed rGcb40f89c6e22: [Symbol][NFC] Remove references to clang in TypeMap (authored by xiaobai).
[Symbol][NFC] Remove references to clang in TypeMap
Tue, Aug 20, 1:46 PM
xiaobai committed rL369436: [Symbol][NFC] Remove references to clang in TypeMap.
[Symbol][NFC] Remove references to clang in TypeMap
Tue, Aug 20, 1:46 PM
xiaobai committed rG1271521ed887: [ClangExpressionParser] Add ClangDeclVendor (authored by xiaobai).
[ClangExpressionParser] Add ClangDeclVendor
Tue, Aug 20, 11:53 AM
xiaobai committed rL369424: [ClangExpressionParser] Add ClangDeclVendor.
[ClangExpressionParser] Add ClangDeclVendor
Tue, Aug 20, 11:46 AM
xiaobai closed D66451: [ClangExpressionParser] Add ClangDeclVendor.
Tue, Aug 20, 11:46 AM · Restricted Project, Restricted Project

Mon, Aug 19

xiaobai added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Mon, Aug 19, 4:42 PM · Restricted Project, Restricted Project
xiaobai created D66451: [ClangExpressionParser] Add ClangDeclVendor.
Mon, Aug 19, 4:09 PM · Restricted Project, Restricted Project
xiaobai accepted D66448: Include "windows" Instead of "Windows".

Case-sensitive filesystems lol

Mon, Aug 19, 3:39 PM · Restricted Project
xiaobai committed rG3b4ce731fbcc: [lldb-vscode] add `launchCommands` to handle launch specific commands (authored by xiaobai).
[lldb-vscode] add `launchCommands` to handle launch specific commands
Mon, Aug 19, 1:18 PM
xiaobai committed rL369296: [lldb-vscode] add `launchCommands` to handle launch specific commands.
[lldb-vscode] add `launchCommands` to handle launch specific commands
Mon, Aug 19, 1:17 PM
xiaobai closed D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands.
Mon, Aug 19, 1:17 PM · Restricted Project, Restricted Project

Wed, Aug 14

xiaobai committed rG0630bbc7fe03: [NFCI] Always initialize BugReport const fields (authored by xiaobai).
[NFCI] Always initialize BugReport const fields
Wed, Aug 14, 6:00 PM
xiaobai committed rL368950: [NFCI] Always initialize BugReport const fields.
[NFCI] Always initialize BugReport const fields
Wed, Aug 14, 5:58 PM
xiaobai closed D66265: [NFCI] Always initialize BugReport const fields.
Wed, Aug 14, 5:58 PM · Restricted Project, Restricted Project
xiaobai created D66265: [NFCI] Always initialize BugReport const fields.
Wed, Aug 14, 5:30 PM · Restricted Project, Restricted Project
xiaobai added a comment to D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex.

I like the idea of using something from llvm instead of rolling our own. The code changes look relatively simple and straightforward, so that's good.

Wed, Aug 14, 10:37 AM · Restricted Project, Restricted Project

Tue, Aug 13

xiaobai committed rG21872bc9bf37: [analyzer] Don't delete TaintConfig copy constructor (authored by xiaobai).
[analyzer] Don't delete TaintConfig copy constructor
Tue, Aug 13, 6:10 PM
xiaobai committed rL368779: [analyzer] Don't delete TaintConfig copy constructor.
[analyzer] Don't delete TaintConfig copy constructor
Tue, Aug 13, 6:08 PM
xiaobai closed D66192: [analyzer] Don't delete TaintConfig copy constructor.
Tue, Aug 13, 6:08 PM · Restricted Project, Restricted Project
xiaobai created D66192: [analyzer] Don't delete TaintConfig copy constructor.
Tue, Aug 13, 5:58 PM · Restricted Project, Restricted Project
xiaobai committed rGb809187a6b42: [NFCI] Explicitly provide user-defined constructor for SectionRef (authored by xiaobai).
[NFCI] Explicitly provide user-defined constructor for SectionRef
Tue, Aug 13, 3:18 PM
xiaobai committed rL368758: [NFCI] Explicitly provide user-defined constructor for SectionRef.
[NFCI] Explicitly provide user-defined constructor for SectionRef
Tue, Aug 13, 3:18 PM
xiaobai committed rGbddab07d4a21: [Symbol] Decouple clang from CompilerType (authored by xiaobai).
[Symbol] Decouple clang from CompilerType
Tue, Aug 13, 12:42 PM
xiaobai committed rL368741: [Symbol] Decouple clang from CompilerType.
[Symbol] Decouple clang from CompilerType
Tue, Aug 13, 12:42 PM
xiaobai closed D66102: [Symbol] Decouple clang from CompilerType.
Tue, Aug 13, 12:41 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D59555: [analyzer] Add yaml parser to GenericTaintChecker.
Tue, Aug 13, 10:34 AM · Restricted Project, Restricted Project

Mon, Aug 12

xiaobai committed rGf4446f177505: [Symbol] Remove redundant include (authored by xiaobai).
[Symbol] Remove redundant include
Mon, Aug 12, 5:27 PM
xiaobai committed rL368638: [Symbol] Remove redundant include.
[Symbol] Remove redundant include
Mon, Aug 12, 5:25 PM
xiaobai created D66102: [Symbol] Decouple clang from CompilerType.
Mon, Aug 12, 11:55 AM · Restricted Project, Restricted Project
xiaobai added a reviewer for D66102: [Symbol] Decouple clang from CompilerType: labath.
Mon, Aug 12, 11:55 AM · Restricted Project, Restricted Project
xiaobai accepted D66093: [Symbol] GetTypeBitAlign() should return None in case of failure..

I appreciate you adding more error handling. Thank you!

Mon, Aug 12, 11:11 AM · Restricted Project, Restricted Project

Wed, Aug 7

xiaobai committed rG4cd04547f52e: [Symbol] Remove commented out code from CompileUnit (authored by xiaobai).
[Symbol] Remove commented out code from CompileUnit
Wed, Aug 7, 1:52 PM
xiaobai committed rL368205: [Symbol] Remove commented out code from CompileUnit.
[Symbol] Remove commented out code from CompileUnit
Wed, Aug 7, 1:50 PM

Tue, Aug 6

xiaobai committed rG5fdf10bae878: [SymbolFile] Remove commented out method (authored by xiaobai).
[SymbolFile] Remove commented out method
Tue, Aug 6, 12:47 PM
xiaobai committed rL368075: [SymbolFile] Remove commented out method.
[SymbolFile] Remove commented out method
Tue, Aug 6, 12:46 PM

Mon, Aug 5

xiaobai accepted D65782: [CompilerType] Simplify the interface a bit more...
Mon, Aug 5, 4:35 PM · Restricted Project, Restricted Project
xiaobai accepted D65781: [CompilerType] Remove an unused function..
Mon, Aug 5, 4:16 PM · Restricted Project, Restricted Project

Wed, Jul 31

xiaobai added a reviewer for D65548: Make JITDylib ignore Exported flag: lhames.
Wed, Jul 31, 4:43 PM · Restricted Project
xiaobai committed rG70402bfc46e0: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai).
[API] Remove use of ClangASTContext from SBTarget
Wed, Jul 31, 1:49 PM
xiaobai committed rL367480: [API] Remove use of ClangASTContext from SBTarget.
[API] Remove use of ClangASTContext from SBTarget
Wed, Jul 31, 1:47 PM
xiaobai closed D64964: [API] Remove use of ClangASTContext from SBTarget.
Wed, Jul 31, 1:47 PM · Restricted Project

Tue, Jul 30

xiaobai updated the diff for D64964: [API] Remove use of ClangASTContext from SBTarget.

Removed argument to GetScratchTypeSystems from SBTarget

Tue, Jul 30, 5:54 PM · Restricted Project
xiaobai updated the diff for D64964: [API] Remove use of ClangASTContext from SBTarget.

Update GetScatchTypeSystems to account for changes to TypeSystem usage

Tue, Jul 30, 5:50 PM · Restricted Project
xiaobai committed rGc1210c7e96fe: [SymbolFilePDB] Fix windows bots after rL367360 (authored by xiaobai).
[SymbolFilePDB] Fix windows bots after rL367360
Tue, Jul 30, 4:48 PM
xiaobai committed rL367368: [SymbolFilePDB] Fix windows bots after rL367360.
[SymbolFilePDB] Fix windows bots after rL367360
Tue, Jul 30, 4:47 PM
xiaobai committed rG0e252e38ef84: [Symbol] Use llvm::Expected when getting TypeSystems (authored by xiaobai).
[Symbol] Use llvm::Expected when getting TypeSystems
Tue, Jul 30, 3:13 PM
xiaobai committed rL367360: [Symbol] Use llvm::Expected when getting TypeSystems.
[Symbol] Use llvm::Expected when getting TypeSystems
Tue, Jul 30, 3:12 PM
xiaobai closed D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Tue, Jul 30, 3:11 PM · Restricted Project
xiaobai committed rG072317311473: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module (authored by xiaobai).
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module
Tue, Jul 30, 2:23 PM
xiaobai committed rL367358: [SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module.
[SymbolFile] SymbolFileDWARF::ParseLineTable should lock its module
Tue, Jul 30, 2:23 PM
xiaobai accepted D65450: Add llvm-style RTTI to ObjectFile hierarchy.

LGTM

Tue, Jul 30, 10:50 AM · Restricted Project

Mon, Jul 29

xiaobai added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

I think this change has introduced a dependence on x64.

I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp.
This is because the version of _CONTEXT included by winnt.h is for x32 and not x64.

i.e., llvm-project\lldb\source\plugins\process\windows\common\x64\registercontextwindows_x64.cpp(297): error C2039: 'Rax': is not a member of '_CONTEXT'

Mon, Jul 29, 5:53 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Mon, Jul 29, 2:44 PM · Restricted Project
xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Small logic change in SBModule

Mon, Jul 29, 2:44 PM · Restricted Project
xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

I have one remark about the consumeError+LLDB_LOG pattern. As for whether this is better than status quo or not, I still don't have an opinion on that. :)

Mon, Jul 29, 12:10 PM · Restricted Project
xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Fix incorrect error logging pattern

Mon, Jul 29, 12:07 PM · Restricted Project

Fri, Jul 26

xiaobai updated the diff for D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

Address comments:

  • Use Expected<TypeSystem&>
  • Did some formatting
  • Made error checking more explicit
Fri, Jul 26, 5:53 PM · Restricted Project
xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

I'm going to update this diff with what I changed to give y'all a better idea of what has been changed. I shoulda done that to begin with... :P

Fri, Jul 26, 11:17 AM · Restricted Project

Thu, Jul 25

xiaobai added a comment to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.

After going through this and modifying this patch, I can't help but wonder if llvm::Optional<TypeSystem &> would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move on. I am conflicted because I like how Expected forces you to be more rigorous with error handling but I can't help but feel it is the wrong abstraction. Thoughts?

Thu, Jul 25, 7:52 PM · Restricted Project
xiaobai accepted D65185: Let tablegen generate property definitions.

I think this is fine. Using .def files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter

Thu, Jul 25, 12:32 PM · Restricted Project, Restricted Project

Jul 24 2019

xiaobai committed rGeb6782758a54: [Symbol] Fix some botched logic in Variable::GetLanguage (authored by xiaobai).
[Symbol] Fix some botched logic in Variable::GetLanguage
Jul 24 2019, 3:14 PM
xiaobai committed rL366950: [Symbol] Fix some botched logic in Variable::GetLanguage.
[Symbol] Fix some botched logic in Variable::GetLanguage
Jul 24 2019, 3:14 PM
xiaobai closed D65165: [Symbol] Fix some botched logic in Variable::GetLanguage.
Jul 24 2019, 3:14 PM · Restricted Project
xiaobai updated the diff for D65165: [Symbol] Fix some botched logic in Variable::GetLanguage.

Implement suggestion

Jul 24 2019, 3:14 PM · Restricted Project

Jul 23 2019

xiaobai added inline comments to D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 23 2019, 3:57 PM · Restricted Project
xiaobai added reviewers for D65165: [Symbol] Fix some botched logic in Variable::GetLanguage: JDevlieghere, jingham.
Jul 23 2019, 3:40 PM · Restricted Project
xiaobai committed rG45a3fd206fb0: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 (authored by xiaobai).
[lldb][test_suite] Update tests with unexpected pass on Android aarch64
Jul 23 2019, 3:15 PM
xiaobai committed rL366858: [lldb][test_suite] Update tests with unexpected pass on Android aarch64.
[lldb][test_suite] Update tests with unexpected pass on Android aarch64
Jul 23 2019, 3:15 PM
xiaobai closed D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64.
Jul 23 2019, 3:15 PM · Restricted Project, Restricted Project
xiaobai created D65165: [Symbol] Fix some botched logic in Variable::GetLanguage.
Jul 23 2019, 1:31 PM · Restricted Project
xiaobai added a comment to D65155: [lldb] Remove Xcode project legacy.

Not directly related, but there's some other legacy cruft I figure are valid for removal. e.g.

utils/sync-source
misc/grep-svn-log.py
git-svn/convert.py

r366827.

Jul 23 2019, 10:44 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D64042: [Symbol] Improve Variable::GetLanguage.
Jul 23 2019, 10:36 AM · Restricted Project

Jul 22 2019

xiaobai committed rGc7f9bfb0e4ba: [lldb][test_suite] Fix skipIfTargetAndroid decorator (authored by xiaobai).
[lldb][test_suite] Fix skipIfTargetAndroid decorator
Jul 22 2019, 5:42 PM
xiaobai committed rL366771: [lldb][test_suite] Fix skipIfTargetAndroid decorator.
[lldb][test_suite] Fix skipIfTargetAndroid decorator
Jul 22 2019, 5:41 PM
xiaobai closed D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator.
Jul 22 2019, 5:41 PM · Restricted Project, Restricted Project
xiaobai committed rGe5001fe5c1ac: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up (authored by xiaobai).
[lldb][test_suite] skip tests of `libstdcpp` on Android and clean up
Jul 22 2019, 5:29 PM
xiaobai committed rL366770: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up.
[lldb][test_suite] skip tests of `libstdcpp` on Android and clean up
Jul 22 2019, 5:29 PM
xiaobai closed D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up.
Jul 22 2019, 5:29 PM · Restricted Project, Restricted Project
xiaobai accepted D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590.

Thanks for restoring them.

Jul 22 2019, 3:58 PM · Restricted Project, Restricted Project
xiaobai created D65122: [Symbol] Use llvm::Expected when getting TypeSystems.
Jul 22 2019, 3:40 PM · Restricted Project
xiaobai committed rG4de5d9d61213: [Symbol] Improve Variable::GetLanguage (authored by xiaobai).
[Symbol] Improve Variable::GetLanguage
Jul 22 2019, 1:15 PM
xiaobai committed rL366733: [Symbol] Improve Variable::GetLanguage.
[Symbol] Improve Variable::GetLanguage
Jul 22 2019, 1:15 PM
xiaobai closed D64042: [Symbol] Improve Variable::GetLanguage.
Jul 22 2019, 1:15 PM · Restricted Project

Jul 19 2019

xiaobai abandoned D65025: [Symbol] Improve TypeSystemMap mutex safety.

Actually from the looks of it, I completely misunderstood what's going on here. It looks like AddToMap should only be called by things that hold the mutex, meaning that this change isn't actually necessary. I do think that makes this code kind of frustrating to understand though. Closing.

Jul 19 2019, 4:04 PM
xiaobai added a comment to D64042: [Symbol] Improve Variable::GetLanguage.

ping

Jul 19 2019, 3:34 PM · Restricted Project
xiaobai created D65025: [Symbol] Improve TypeSystemMap mutex safety.
Jul 19 2019, 3:30 PM
xiaobai accepted D64994: [CMake] Align debugserver with lldb-server on Darwin.

Excellent, thanks for taking care of this! :)

Jul 19 2019, 10:57 AM · Restricted Project, Restricted Project

Jul 18 2019

xiaobai added a comment to D64964: [API] Remove use of ClangASTContext from SBTarget.

All uses of this new function drop the error on the ground. Does that mean it doesn't matter? If it does, should we return an expected instead? Should we stop on the first error, or is it fine to overwrite when iterating over languages_for_expressions? It seems like the error handling needs some more work here.

Jul 18 2019, 10:48 PM · Restricted Project
xiaobai committed rGbb0896970afa: [NFC] Remove instances of unused ClangASTContext header (authored by xiaobai).
[NFC] Remove instances of unused ClangASTContext header
Jul 18 2019, 5:40 PM
xiaobai committed rL366519: [NFC] Remove instances of unused ClangASTContext header.
[NFC] Remove instances of unused ClangASTContext header
Jul 18 2019, 5:39 PM
xiaobai committed rG3e4a13a7f0b0: [Commands] Remove unused header from CommandObjectFrame (authored by xiaobai).
[Commands] Remove unused header from CommandObjectFrame
Jul 18 2019, 5:27 PM