Page MenuHomePhabricator
Feed Advanced Search

Fri, Oct 11

xiaobai committed rG03fbde6d8470: [NativePDB] Remove unused references to ClangASTImporter (authored by xiaobai).
[NativePDB] Remove unused references to ClangASTImporter
Fri, Oct 11, 1:15 PM
xiaobai committed rL374587: [NativePDB] Remove unused references to ClangASTImporter.
[NativePDB] Remove unused references to ClangASTImporter
Fri, Oct 11, 1:14 PM

Thu, Oct 10

xiaobai committed rG887707e29d31: [lldb-test] Remove unused header (authored by xiaobai).
[lldb-test] Remove unused header
Thu, Oct 10, 3:49 PM
xiaobai committed rL374468: [lldb-test] Remove unused header.
[lldb-test] Remove unused header
Thu, Oct 10, 3:49 PM

Tue, Oct 8

xiaobai accepted D68614: [LLDB] Remove standalone build dep on llvm-strip.

LGTM

Tue, Oct 8, 3:28 PM · Restricted Project
xiaobai closed D68613: [CMake] Fix building without python on Windows.

rL374100

Tue, Oct 8, 3:28 PM · Restricted Project
xiaobai committed rG28fcc033c883: [CMake] Fix building without python on Windows (authored by xiaobai).
[CMake] Fix building without python on Windows
Tue, Oct 8, 11:44 AM
xiaobai committed rL374100: [CMake] Fix building without python on Windows.
[CMake] Fix building without python on Windows
Tue, Oct 8, 11:44 AM

Mon, Oct 7

xiaobai committed rGf4c7345b88f8: [Symbol] Remove unused method ClangASTContext::GetObjCClassName (authored by xiaobai).
[Symbol] Remove unused method ClangASTContext::GetObjCClassName
Mon, Oct 7, 10:24 PM
xiaobai committed rL373990: [Symbol] Remove unused method ClangASTContext::GetObjCClassName.
[Symbol] Remove unused method ClangASTContext::GetObjCClassName
Mon, Oct 7, 10:23 PM
xiaobai added a reviewer for D68614: [LLDB] Remove standalone build dep on llvm-strip: JDevlieghere.

@JDevlieghere has been touching similar things today. You should coordinate with him on this change.

Mon, Oct 7, 5:40 PM · Restricted Project
xiaobai created D68613: [CMake] Fix building without python on Windows.
Mon, Oct 7, 5:30 PM · Restricted Project
xiaobai accepted D68612: [CMake] Track test dependencies with add_lldb_test_dependency.

Looks good to me. I find it interesting that we had an lldb-test-deps custom target before but most things were depending on ${LLDB_TEST_DEPS} anyway.

Mon, Oct 7, 5:15 PM · Restricted Project, Restricted Project
xiaobai accepted D68606: [test] Split LLDB tests into filecheck, unittest and dotest..
Mon, Oct 7, 4:51 PM · Restricted Project

Fri, Oct 4

xiaobai committed rG9627b26c40a1: [libc++] Guard cxx_experimental settings behind… (authored by xiaobai).
[libc++] Guard cxx_experimental settings behind…
Fri, Oct 4, 4:10 PM
xiaobai committed rL373809: [libc++] Guard cxx_experimental settings behind….
[libc++] Guard cxx_experimental settings behind…
Fri, Oct 4, 4:07 PM

Fri, Sep 27

xiaobai committed rG92f151738bfe: [Core] Remove unused dependency on clangAST (authored by xiaobai).
[Core] Remove unused dependency on clangAST
Fri, Sep 27, 5:27 PM
xiaobai committed rL373134: [Core] Remove unused dependency on clangAST.
[Core] Remove unused dependency on clangAST
Fri, Sep 27, 5:27 PM

Thu, Sep 26

xiaobai committed rG7dfb095b882d: [lldb-vscode] correctly handle multiple sourceMap entries (authored by xiaobai).
[lldb-vscode] correctly handle multiple sourceMap entries
Thu, Sep 26, 2:25 PM
xiaobai committed rL373016: [lldb-vscode] correctly handle multiple sourceMap entries.
[lldb-vscode] correctly handle multiple sourceMap entries
Thu, Sep 26, 2:16 PM
xiaobai closed D67569: [lldb-vscode] correctly handle multiple sourceMap entries.
Thu, Sep 26, 2:16 PM · Restricted Project
xiaobai added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Thu, Sep 26, 11:04 AM · Restricted Project, Restricted Project

Wed, Sep 25

xiaobai added inline comments to D68048: [WIP][RFC] Improve fetching the process list on the android platform.
Wed, Sep 25, 4:28 PM · Restricted Project
xiaobai added a comment to D68048: [WIP][RFC] Improve fetching the process list on the android platform.

There are some things still left.

architecture:
I don't know if we can simply reuse an existing variable and set it for all processes, or if we should really find the architecture of each process.

The only time we might run into an issue is when we have arm32 running on arm64. Not sure if that can be detected. For now we can deduce the devices architecture and apply to all?

Wed, Sep 25, 4:16 PM · Restricted Project
xiaobai accepted D68040: [lldb] Excludes private headers from SWIG dependency..
Wed, Sep 25, 11:16 AM · Restricted Project, Restricted Project
xiaobai accepted D68039: [lit] Do a better job at parsing unsupported tests..

LGTM

Wed, Sep 25, 11:13 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D68007: [lldb] Move swig call from python code to cmake.
Wed, Sep 25, 11:00 AM · Restricted Project, Restricted Project
xiaobai added inline comments to D68007: [lldb] Move swig call from python code to cmake.
Wed, Sep 25, 10:55 AM · Restricted Project, Restricted Project

Tue, Sep 24

xiaobai added inline comments to D67994: Modify lldb-test to print out ASTs from symbol file.
Tue, Sep 24, 4:06 PM · Restricted Project
xiaobai accepted D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER.

No objections from me.

Tue, Sep 24, 3:36 PM · Restricted Project, Restricted Project
xiaobai added inline comments to D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER.
Tue, Sep 24, 3:30 PM · Restricted Project, Restricted Project

Mon, Sep 23

xiaobai committed rG86c3af90296a: [NFCI] Return PathSensitiveBugReport where appropriate (authored by xiaobai).
[NFCI] Return PathSensitiveBugReport where appropriate
Mon, Sep 23, 3:30 PM
xiaobai committed rL372668: [NFCI] Return PathSensitiveBugReport where appropriate.
[NFCI] Return PathSensitiveBugReport where appropriate
Mon, Sep 23, 3:27 PM

Sep 19 2019

xiaobai committed rG466fb68fce10: [NFCI] Always initialize const members of AttributeCommonInfo (authored by xiaobai).
[NFCI] Always initialize const members of AttributeCommonInfo
Sep 19 2019, 5:21 PM
xiaobai committed rL372363: [NFCI] Always initialize const members of AttributeCommonInfo.
[NFCI] Always initialize const members of AttributeCommonInfo
Sep 19 2019, 5:14 PM
xiaobai added a comment to D67569: [lldb-vscode] correctly handle multiple sourceMap entries.

@rmaz: I can land this for you if you would like me to.

Sep 19 2019, 1:56 PM · Restricted Project

Sep 13 2019

xiaobai added a comment to D67569: [lldb-vscode] correctly handle multiple sourceMap entries.

Looks fine to me. Any objections @clayborg?

Sep 13 2019, 2:03 PM · Restricted Project

Sep 12 2019

xiaobai committed rG5b2b38e053b4: [Target] Move InferiorCall to Process (authored by xiaobai).
[Target] Move InferiorCall to Process
Sep 12 2019, 5:05 PM
xiaobai committed rL371796: [Target] Move InferiorCall to Process.
[Target] Move InferiorCall to Process
Sep 12 2019, 5:01 PM
xiaobai closed D67472: [Target] Move InferiorCall to Process.
Sep 12 2019, 5:01 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67472: [Target] Move InferiorCall to Process.

Rename function in question to CallVoidArgVoidPtrReturn

Sep 12 2019, 3:56 PM · Restricted Project, Restricted Project
xiaobai updated the summary of D67472: [Target] Move InferiorCall to Process.
Sep 12 2019, 3:34 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67472: [Target] Move InferiorCall to Process.

Rename InferiorCall to CallNoArgNoReturnFunc
make CallNoArgReturnFunc public

Sep 12 2019, 3:34 PM · Restricted Project, Restricted Project

Sep 11 2019

xiaobai created D67472: [Target] Move InferiorCall to Process.
Sep 11 2019, 3:38 PM · Restricted Project, Restricted Project
xiaobai committed rG1b385a180250: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX (authored by xiaobai).
[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
Sep 11 2019, 1:40 PM
xiaobai committed rL371654: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
[Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX
Sep 11 2019, 1:35 PM
xiaobai closed D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
Sep 11 2019, 1:35 PM · Restricted Project, Restricted Project

Sep 10 2019

xiaobai created D67427: [Plugins/Process] Remove direct use of ClangASTContext from InferiorCallPOSIX.
Sep 10 2019, 5:54 PM · Restricted Project, Restricted Project

Sep 9 2019

xiaobai committed rG1dbee8f0437f: [Expression] Remove unused header from LLVMUserExpression (authored by xiaobai).
[Expression] Remove unused header from LLVMUserExpression
Sep 9 2019, 5:05 PM
xiaobai committed rL371472: [Expression] Remove unused header from LLVMUserExpression.
[Expression] Remove unused header from LLVMUserExpression
Sep 9 2019, 5:04 PM
xiaobai committed rG9e86561878dc: [Symbol] Give ClangASTContext a PersistentExpressionState instead of a… (authored by xiaobai).
[Symbol] Give ClangASTContext a PersistentExpressionState instead of a…
Sep 9 2019, 4:11 PM
xiaobai committed rL371470: [Symbol] Give ClangASTContext a PersistentExpressionState instead of a….
[Symbol] Give ClangASTContext a PersistentExpressionState instead of a…
Sep 9 2019, 4:11 PM

Sep 6 2019

xiaobai committed rGb482db6dfeda: [Core] Remove use of ClangASTContext in DumpDataExtractor (authored by xiaobai).
[Core] Remove use of ClangASTContext in DumpDataExtractor
Sep 6 2019, 2:06 PM
xiaobai committed rL371258: [Core] Remove use of ClangASTContext in DumpDataExtractor.
[Core] Remove use of ClangASTContext in DumpDataExtractor
Sep 6 2019, 2:04 PM
xiaobai closed D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.
Sep 6 2019, 2:04 PM · Restricted Project, Restricted Project
xiaobai updated the diff for D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.

Refactored slightly to be a bit safer

Sep 6 2019, 11:05 AM · Restricted Project, Restricted Project

Sep 5 2019

xiaobai added a comment to D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.

Hmm, good question. If you call GetAPInt with a byte_size of 0, it should assert when trying to read 0 bytes with the DataExtractor. In the worst case, it gives you a broken APInt. I think guarded the call to GetAPInt to protect against this, but I think that it would also be a good idea to make GetAPInt return llvm::None in that case.

Sep 5 2019, 3:35 PM · Restricted Project, Restricted Project
xiaobai created D67239: [Core] Remove use of ClangASTContext in DumpDataExtractor.
Sep 5 2019, 2:34 PM · Restricted Project, Restricted Project

Aug 28 2019

xiaobai committed rG3e45e3ba959f: [Core] Use GetAPInt instead of constructing APInts in place (authored by xiaobai).
[Core] Use GetAPInt instead of constructing APInts in place
Aug 28 2019, 1:16 PM
xiaobai committed rL370255: [Core] Use GetAPInt instead of constructing APInts in place.
[Core] Use GetAPInt instead of constructing APInts in place
Aug 28 2019, 1:16 PM
xiaobai accepted D66858: POSIX DYLD: add workaround for android L loader.

LGTM, small typo tho

Aug 28 2019, 10:27 AM · Restricted Project

Aug 27 2019

xiaobai accepted D66811: [dotest] Remove results port.

LGTM

Aug 27 2019, 11:12 AM · Restricted Project, Restricted Project
xiaobai removed an edge from rL370075: [JITLink] Add timers and -show-times option to llvm-jitlink.: D66811: [dotest] Remove results port.
Aug 27 2019, 11:12 AM
xiaobai removed 1 commit(s) for D66811: [dotest] Remove results port: rL370075: [JITLink] Add timers and -show-times option to llvm-jitlink..
Aug 27 2019, 11:12 AM · Restricted Project, Restricted Project

Aug 26 2019

xiaobai committed rL369970: [Core] GetAPInt should return an Optional.
[Core] GetAPInt should return an Optional
Aug 26 2019, 2:15 PM
xiaobai committed rG5e777e1ed288: [Core] GetAPInt should return an Optional (authored by xiaobai).
[Core] GetAPInt should return an Optional
Aug 26 2019, 2:14 PM
xiaobai added inline comments to D66249: [JIT][Breakpoint] Add "BreakpointInjectedSite" and FCB Trampoline.
Aug 26 2019, 12:52 PM · Restricted Project

Aug 22 2019

xiaobai committed rGcb68bd726db4: [Symbol] Decouple clang from DeclVendor (authored by xiaobai).
[Symbol] Decouple clang from DeclVendor
Aug 22 2019, 11:11 PM
xiaobai committed rL369735: [Symbol] Decouple clang from DeclVendor.
[Symbol] Decouple clang from DeclVendor
Aug 22 2019, 11:10 PM
xiaobai closed D66628: [Symbol] Decouple clang from DeclVendor.
Aug 22 2019, 11:10 PM · Restricted Project, Restricted Project
xiaobai created D66628: [Symbol] Decouple clang from DeclVendor.
Aug 22 2019, 6:07 PM · Restricted Project, Restricted Project

Aug 20 2019

xiaobai committed rG7719495e2cae: [Symbol] Remove unused clang headers from Type (authored by xiaobai).
[Symbol] Remove unused clang headers from Type
Aug 20 2019, 9:57 PM
xiaobai committed rL369494: [Symbol] Remove unused clang headers from Type.
[Symbol] Remove unused clang headers from Type
Aug 20 2019, 9:56 PM
xiaobai added a comment to D66102: [Symbol] Decouple clang from CompilerType.

I wouldn't mind adding something to reduce boilerplate, but I'm not sure it would actually look too different. A wrapper function or subclass constructor would need to take a ClangASTContext and a clang::QualType so we could avoid calls to getAsOpaquePtr() everywhere but that's about it I think?

Aug 20 2019, 4:02 PM · Restricted Project, Restricted Project
xiaobai committed rGb2232a1af321: [Symbol] Move VerifyDecl to ClangASTContext (authored by xiaobai).
[Symbol] Move VerifyDecl to ClangASTContext
Aug 20 2019, 3:08 PM
xiaobai committed rL369456: [Symbol] Move VerifyDecl to ClangASTContext.
[Symbol] Move VerifyDecl to ClangASTContext
Aug 20 2019, 3:08 PM
xiaobai committed rGcb40f89c6e22: [Symbol][NFC] Remove references to clang in TypeMap (authored by xiaobai).
[Symbol][NFC] Remove references to clang in TypeMap
Aug 20 2019, 1:46 PM
xiaobai committed rL369436: [Symbol][NFC] Remove references to clang in TypeMap.
[Symbol][NFC] Remove references to clang in TypeMap
Aug 20 2019, 1:46 PM
xiaobai committed rG1271521ed887: [ClangExpressionParser] Add ClangDeclVendor (authored by xiaobai).
[ClangExpressionParser] Add ClangDeclVendor
Aug 20 2019, 11:53 AM
xiaobai committed rL369424: [ClangExpressionParser] Add ClangDeclVendor.
[ClangExpressionParser] Add ClangDeclVendor
Aug 20 2019, 11:46 AM
xiaobai closed D66451: [ClangExpressionParser] Add ClangDeclVendor.
Aug 20 2019, 11:46 AM · Restricted Project, Restricted Project

Aug 19 2019

xiaobai added inline comments to D66451: [ClangExpressionParser] Add ClangDeclVendor.
Aug 19 2019, 4:42 PM · Restricted Project, Restricted Project
xiaobai created D66451: [ClangExpressionParser] Add ClangDeclVendor.
Aug 19 2019, 4:09 PM · Restricted Project, Restricted Project
xiaobai accepted D66448: Include "windows" Instead of "Windows".

Case-sensitive filesystems lol

Aug 19 2019, 3:39 PM · Restricted Project
xiaobai committed rG3b4ce731fbcc: [lldb-vscode] add `launchCommands` to handle launch specific commands (authored by xiaobai).
[lldb-vscode] add `launchCommands` to handle launch specific commands
Aug 19 2019, 1:18 PM
xiaobai committed rL369296: [lldb-vscode] add `launchCommands` to handle launch specific commands.
[lldb-vscode] add `launchCommands` to handle launch specific commands
Aug 19 2019, 1:17 PM
xiaobai closed D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands.
Aug 19 2019, 1:17 PM · Restricted Project, Restricted Project

Aug 14 2019

xiaobai committed rG0630bbc7fe03: [NFCI] Always initialize BugReport const fields (authored by xiaobai).
[NFCI] Always initialize BugReport const fields
Aug 14 2019, 6:00 PM
xiaobai committed rL368950: [NFCI] Always initialize BugReport const fields.
[NFCI] Always initialize BugReport const fields
Aug 14 2019, 5:58 PM
xiaobai closed D66265: [NFCI] Always initialize BugReport const fields.
Aug 14 2019, 5:58 PM · Restricted Project, Restricted Project
xiaobai created D66265: [NFCI] Always initialize BugReport const fields.
Aug 14 2019, 5:30 PM · Restricted Project, Restricted Project
xiaobai added a comment to D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex.

I like the idea of using something from llvm instead of rolling our own. The code changes look relatively simple and straightforward, so that's good.

Aug 14 2019, 10:37 AM · Restricted Project, Restricted Project

Aug 13 2019

xiaobai committed rG21872bc9bf37: [analyzer] Don't delete TaintConfig copy constructor (authored by xiaobai).
[analyzer] Don't delete TaintConfig copy constructor
Aug 13 2019, 6:10 PM
xiaobai committed rL368779: [analyzer] Don't delete TaintConfig copy constructor.
[analyzer] Don't delete TaintConfig copy constructor
Aug 13 2019, 6:08 PM
xiaobai closed D66192: [analyzer] Don't delete TaintConfig copy constructor.
Aug 13 2019, 6:08 PM · Restricted Project, Restricted Project
xiaobai created D66192: [analyzer] Don't delete TaintConfig copy constructor.
Aug 13 2019, 5:58 PM · Restricted Project, Restricted Project
xiaobai committed rGb809187a6b42: [NFCI] Explicitly provide user-defined constructor for SectionRef (authored by xiaobai).
[NFCI] Explicitly provide user-defined constructor for SectionRef
Aug 13 2019, 3:18 PM
xiaobai committed rL368758: [NFCI] Explicitly provide user-defined constructor for SectionRef.
[NFCI] Explicitly provide user-defined constructor for SectionRef
Aug 13 2019, 3:18 PM
xiaobai committed rGbddab07d4a21: [Symbol] Decouple clang from CompilerType (authored by xiaobai).
[Symbol] Decouple clang from CompilerType
Aug 13 2019, 12:42 PM
xiaobai committed rL368741: [Symbol] Decouple clang from CompilerType.
[Symbol] Decouple clang from CompilerType
Aug 13 2019, 12:42 PM