Page MenuHomePhabricator
Feed Advanced Search

Today

RKSimon added a reviewer for D72944: [InstCombine] Fix worklist management when simplifying demanded bits (PR44541): majnemer.
Fri, Jan 17, 2:33 PM · Restricted Project
RKSimon added a comment to D72582: [X86] Don't inherit 32-bit calling conventions in 64-bit mode..

Is there a bz for this?

Fri, Jan 17, 9:53 AM · Restricted Project
RKSimon accepted D72524: [X86] Try to avoid casts around logical vector ops recursively..

LGTM - I don't have a problem with keeping PromoteMaskArithmetic tbh

Fri, Jan 17, 9:15 AM · Restricted Project
RKSimon committed rGd1b32f328e4a: Revert rGb6437b352db9 - "Fix gcc9 "moving a local object in a return statement… (authored by RKSimon).
Revert rGb6437b352db9 - "Fix gcc9 "moving a local object in a return statement…
Fri, Jan 17, 8:06 AM
RKSimon committed rG88cdeaa5313a: Revert rGff3fe145fe48 "Fix gcc9 "moving a local object in a return statement… (authored by RKSimon).
Revert rGff3fe145fe48 "Fix gcc9 "moving a local object in a return statement…
Fri, Jan 17, 8:06 AM
RKSimon added a reverting change for rGb6437b352db9: Fix gcc9 "moving a local object in a return statement prevents copy elision"…: rGd1b32f328e4a: Revert rGb6437b352db9 - "Fix gcc9 "moving a local object in a return statement….
Fri, Jan 17, 8:06 AM
RKSimon added a reverting change for rGff3fe145fe48: Fix gcc9 "moving a local object in a return statement prevents copy elision"…: rG88cdeaa5313a: Revert rGff3fe145fe48 "Fix gcc9 "moving a local object in a return statement….
Fri, Jan 17, 8:06 AM
RKSimon committed rGff3fe145fe48: Fix gcc9 "moving a local object in a return statement prevents copy elision"… (authored by RKSimon).
Fix gcc9 "moving a local object in a return statement prevents copy elision"…
Fri, Jan 17, 7:56 AM
RKSimon committed rGb6437b352db9: Fix gcc9 "moving a local object in a return statement prevents copy elision"… (authored by RKSimon).
Fix gcc9 "moving a local object in a return statement prevents copy elision"…
Fri, Jan 17, 7:56 AM
RKSimon committed rG8eb4d25a0943: [X86] Split X87/SSE compare classes into WriteFCom + WriteFComX (authored by RKSimon).
[X86] Split X87/SSE compare classes into WriteFCom + WriteFComX
Fri, Jan 17, 6:21 AM
RKSimon committed rG1dc2f257903d: [SelectionDAG] ComputeKnownBits - assert we're computing the 0'th (difference)… (authored by RKSimon).
[SelectionDAG] ComputeKnownBits - assert we're computing the 0'th (difference)…
Fri, Jan 17, 6:21 AM
RKSimon added inline comments to D72805: [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together..
Fri, Jan 17, 5:41 AM · Restricted Project
RKSimon accepted D72575: [x86] try harder to form 256-bit unpck*.

LGTM - technically this is a limited version of a "lowerShuffleAsLanePermuteAndUNPCK" pattern that we might want to investigate in the future, but its a more controllable initial implementation.

Fri, Jan 17, 5:41 AM · Restricted Project
RKSimon committed rGf61115835085: [SelectionDAG] Better ISD::ANY_EXTEND/ISD::ANY_EXTEND_VECTOR_INREG… (authored by RKSimon).
[SelectionDAG] Better ISD::ANY_EXTEND/ISD::ANY_EXTEND_VECTOR_INREG…
Fri, Jan 17, 3:39 AM
RKSimon committed rG25afe91fd1b8: Fix Wparentheses warning. NFCI. (authored by RKSimon).
Fix Wparentheses warning. NFCI.
Fri, Jan 17, 3:30 AM

Yesterday

RKSimon added a reviewer for D72870: [SelectionDag] Updated FoldConstantArithmetic method signature in preparation for merge with FoldConstantVectorArithmetic: spatel.
Thu, Jan 16, 1:35 PM · Restricted Project
RKSimon added a comment to D70837: [RISCV] Support ABI checking with per function target-features.

@khchen We have a load of EXPENSIVE_CHECKS RISCV MC + asm failures, a lot of which appear to be related to these changes to RISCVAsmParser please can you take a look?

Thu, Jan 16, 11:49 AM · Restricted Project
RKSimon added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Hi @RKSimon!

I'm trying to figure that out, the change is supposed to be off by default except the added test case and shouldn't affect anyone functionally.
What's LLVM policy in such cases - revert?

Thu, Jan 16, 8:47 AM · Restricted Project
RKSimon added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

@ashlykov This is failing on EXPENSIVE_CHECKS builds - revert? http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/1493/

Thu, Jan 16, 8:09 AM · Restricted Project
RKSimon committed rG23a887b0dd48: Fix unused variable warning. NFCI. (authored by RKSimon).
Fix unused variable warning. NFCI.
Thu, Jan 16, 5:05 AM
RKSimon committed rG19c5057e8df6: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Thu, Jan 16, 5:05 AM
RKSimon added a comment to D72824: [X86] Add combination for fma and fneg on X86 under strict FP..

FMA4 tests?

Thu, Jan 16, 12:26 AM · Restricted Project

Wed, Jan 15

RKSimon abandoned D45336: Apply accumulator to fadd/fmul experimental vector reductions (PR36734).
Wed, Jan 15, 12:42 PM · Restricted Project
RKSimon added a comment to D72740: [SLP] Don't allow Div/Rem as alternate opcodes.

This (and D72739) should be in 10.0 - please can you raise a bug and block https://bugs.llvm.org/show_bug.cgi?id=44555

Wed, Jan 15, 8:45 AM · Restricted Project
RKSimon accepted D72739: [SLP] Add a test showing miscompilation in AltOpcode support.

LGTM

Wed, Jan 15, 8:45 AM · Restricted Project
RKSimon reopened D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.

reverted due to EXPENSIVE_CHECKS fails: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/1917

Wed, Jan 15, 4:47 AM · Restricted Project
RKSimon requested changes to D65656: AArch64: support @llvm.{return,frame}address in GlobalISel.
Wed, Jan 15, 4:47 AM · Restricted Project
RKSimon committed rGe26a78e70857: Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 - "[AArch64][GlobalISel]… (authored by RKSimon).
Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 - "[AArch64][GlobalISel]…
Wed, Jan 15, 4:39 AM
RKSimon added a reverting change for rG6078f2fedcac: [AArch64][GlobalISel]: Support @llvm.{return,frame}address selection.: rGe26a78e70857: Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 - "[AArch64][GlobalISel]….
Wed, Jan 15, 4:39 AM
RKSimon committed rGeb82226f3352: Fix Wdocumentation warning. NFC. (authored by RKSimon).
Fix Wdocumentation warning. NFC.
Wed, Jan 15, 4:20 AM
RKSimon committed rG0b64400e0b3d: RegisterClassInfo::computePSetLimit - assert that we actually find a register. (authored by RKSimon).
RegisterClassInfo::computePSetLimit - assert that we actually find a register.
Wed, Jan 15, 4:20 AM
RKSimon committed rG7b1586522510: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Wed, Jan 15, 4:20 AM
RKSimon updated subscribers of rG6078f2fedcac: [AArch64][GlobalISel]: Support @llvm.{return,frame}address selection..

This is causing EXPENSIVE_CHECKS failures - revert this? http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/1917

Wed, Jan 15, 4:19 AM
RKSimon updated subscribers of D59973: [SLP] Refactoring of the operand reordering code..
Wed, Jan 15, 1:42 AM · Restricted Project

Tue, Jan 14

RKSimon committed rGab9dbc1d124c: Fix "pointer is null" clang static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" clang static analyzer warnings. NFCI.
Tue, Jan 14, 8:41 AM
RKSimon committed rGcfd366ba74c5: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Tue, Jan 14, 8:41 AM
RKSimon committed rG1d6b964ed1f7: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Tue, Jan 14, 6:08 AM
RKSimon committed rG591cd4058430: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Tue, Jan 14, 6:08 AM
RKSimon committed rG9d905e8ceddd: Remove duplicate variable. NFCI. (authored by RKSimon).
Remove duplicate variable. NFCI.
Tue, Jan 14, 6:08 AM
RKSimon committed rG7ec7a6e5bfa7: Fix "null pointer passed to nonnull argument" clang static analyzer warnings. (authored by RKSimon).
Fix "null pointer passed to nonnull argument" clang static analyzer warnings.
Tue, Jan 14, 6:07 AM
RKSimon committed rGcc8a15042837: Merge isa<> and getAs<> calls to fix "pointer is null" static analyzer warnings. (authored by RKSimon).
Merge isa<> and getAs<> calls to fix "pointer is null" static analyzer warnings.
Tue, Jan 14, 6:07 AM
RKSimon committed rG25dc5c7cd159: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Tue, Jan 14, 6:07 AM
RKSimon accepted D72307: [X86] Directly emit a BROADCAST_LOAD from constant pool in lowerUINT_TO_FP_vXi32 to avoid double loads seen in D71971.

OK - LGTM

Tue, Jan 14, 5:16 AM · Restricted Project
RKSimon added a comment to D69334: [MathExtras] Add intrinsic for the PopulationCounter in Visual Studio.

TBH I don't think this is worth it unless you can demonstrate actual reductions in compile time - once C++20 lands and we're allowed to use its features we can move to using std::popcount and avoid all of this.

Tue, Jan 14, 4:20 AM · Restricted Project
RKSimon committed rG31aed2e0dad2: Fix "MIParser::getIRValue(unsigned int)’ defined but not used" warning. NFCI. (authored by RKSimon).
Fix "MIParser::getIRValue(unsigned int)’ defined but not used" warning. NFCI.
Tue, Jan 14, 4:00 AM
RKSimon committed rGc05a11108b9a: [SelectionDAG] ComputeKnownBits - merge getValidMinimumShiftAmountConstant()… (authored by RKSimon).
[SelectionDAG] ComputeKnownBits - merge getValidMinimumShiftAmountConstant()…
Tue, Jan 14, 3:53 AM
RKSimon committed rGfd42a4ac7a69: [X86][SSE] Add add(shl(and(x,c1),c2),c3) test case with non-uniform shift value (authored by RKSimon).
[X86][SSE] Add add(shl(and(x,c1),c2),c3) test case with non-uniform shift value
Tue, Jan 14, 3:43 AM
RKSimon committed rGa43b0065c5c7: [SelectionDAG] ComputeKnownBits - merge getValidMinimumShiftAmountConstant()… (authored by RKSimon).
[SelectionDAG] ComputeKnownBits - merge getValidMinimumShiftAmountConstant()…
Tue, Jan 14, 3:43 AM

Mon, Jan 13

RKSimon added inline comments to D72575: [x86] try harder to form 256-bit unpck*.
Mon, Jan 13, 11:59 AM · Restricted Project
RKSimon added inline comments to rGef5debac4302: [SelectionDAG] ComputeKnownBits add getValidMinimumShiftAmountConstant() ISD….
Mon, Jan 13, 10:35 AM
RKSimon committed rGc6fcd5d115b6: [SelectionDAG] ComputeNumSignBits add getValidMaximumShiftAmountConstant() for… (authored by RKSimon).
[SelectionDAG] ComputeNumSignBits add getValidMaximumShiftAmountConstant() for…
Mon, Jan 13, 10:07 AM
RKSimon committed rGffc05d0dbc88: [X86][SSE] Add sitofp(shl(sext(x),y)) test case with non-uniform shift value (authored by RKSimon).
[X86][SSE] Add sitofp(shl(sext(x),y)) test case with non-uniform shift value
Mon, Jan 13, 9:38 AM
RKSimon committed rG38e2c01221a9: [SelectionDAG] ComputeNumSignBits add getValidMinimumShiftAmountConstant() ISD… (authored by RKSimon).
[SelectionDAG] ComputeNumSignBits add getValidMinimumShiftAmountConstant() ISD…
Mon, Jan 13, 9:09 AM
RKSimon committed rG7afaa0099b90: [X86][SSE] Add sitofp(ashr(x,y)) test case with non-uniform shift value (authored by RKSimon).
[X86][SSE] Add sitofp(ashr(x,y)) test case with non-uniform shift value
Mon, Jan 13, 9:09 AM
RKSimon committed rGee4aa1a228b3: [X86] Add AVX2 known signbits codegen tests (authored by RKSimon).
[X86] Add AVX2 known signbits codegen tests
Mon, Jan 13, 9:09 AM
RKSimon added inline comments to D72575: [x86] try harder to form 256-bit unpck*.
Mon, Jan 13, 8:31 AM · Restricted Project
RKSimon added inline comments to rGef5debac4302: [SelectionDAG] ComputeKnownBits add getValidMinimumShiftAmountConstant() ISD….
Mon, Jan 13, 7:44 AM
RKSimon committed rGb11027a08620: Fix cppcheck uninitialized variable in DiffTree() constructor warning. NFCI. (authored by RKSimon).
Fix cppcheck uninitialized variable in DiffTree() constructor warning. NFCI.
Mon, Jan 13, 7:16 AM
RKSimon committed rG4647aae72f33: Merge isVectorType() and getAs<VectorType> calls to silence clang static… (authored by RKSimon).
Merge isVectorType() and getAs<VectorType> calls to silence clang static…
Mon, Jan 13, 7:16 AM
RKSimon committed rG025941785faf: Fix some cppcheck shadow variable warnings. NFCI. (authored by RKSimon).
Fix some cppcheck shadow variable warnings. NFCI.
Mon, Jan 13, 7:16 AM
RKSimon committed rG40311f972495: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Mon, Jan 13, 7:16 AM
RKSimon committed rG7af67259cdd6: Sema::getOwningModule - take const Decl* type. (authored by RKSimon).
Sema::getOwningModule - take const Decl* type.
Mon, Jan 13, 7:16 AM
RKSimon added inline comments to D72573: [SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526).
Mon, Jan 13, 6:44 AM · Restricted Project
RKSimon committed rG376bc39c829f: [SelectionDAG] ComputeNumSignBits - Use getValidShiftAmountConstant for shift… (authored by RKSimon).
[SelectionDAG] ComputeNumSignBits - Use getValidShiftAmountConstant for shift…
Mon, Jan 13, 6:16 AM
RKSimon committed rG6d1a8fd44793: [SelectionDAG] ComputeKnownBits - Add DemandedElts support to… (authored by RKSimon).
[SelectionDAG] ComputeKnownBits - Add DemandedElts support to…
Mon, Jan 13, 6:16 AM
RKSimon committed rG89ba150240a4: [X86] Add knownbits tests showing missing shift amount demanded elts handling. (authored by RKSimon).
[X86] Add knownbits tests showing missing shift amount demanded elts handling.
Mon, Jan 13, 6:16 AM
RKSimon committed rG7efc7ca8edf6: [X86][SSE] Add knownbits test showing missing… (authored by RKSimon).
[X86][SSE] Add knownbits test showing missing…
Mon, Jan 13, 4:06 AM
RKSimon committed rGef5debac4302: [SelectionDAG] ComputeKnownBits add getValidMinimumShiftAmountConstant() ISD… (authored by RKSimon).
[SelectionDAG] ComputeKnownBits add getValidMinimumShiftAmountConstant() ISD…
Mon, Jan 13, 4:06 AM
RKSimon committed rG8f49204f26ea: [SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in… (authored by RKSimon).
[SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in…
Mon, Jan 13, 3:10 AM
RKSimon closed D72573: [SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526).
Mon, Jan 13, 3:10 AM · Restricted Project
RKSimon committed rG7f1cf7d5f658: [X86] Fix MSVC "truncation from 'int' to 'bool'" warning. NFCI. (authored by RKSimon).
[X86] Fix MSVC "truncation from 'int' to 'bool'" warning. NFCI.
Mon, Jan 13, 3:10 AM

Sun, Jan 12

RKSimon committed rG54b2914accb4: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Sun, Jan 12, 2:09 PM
RKSimon committed rGada22c804cd9: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Sun, Jan 12, 1:57 PM
RKSimon added inline comments to D72573: [SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526).
Sun, Jan 12, 9:44 AM · Restricted Project
RKSimon added a reviewer for D72573: [SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526): arsenm.
Sun, Jan 12, 9:26 AM · Restricted Project
RKSimon created D72573: [SelectionDAG] ComputeKnownBits - minimum leading/trailing zero bits in LSHR/SHL (PR44526).
Sun, Jan 12, 9:20 AM · Restricted Project
RKSimon committed rGad201691d5cc: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Sun, Jan 12, 7:53 AM
RKSimon added a comment to rGce35010d782c: [X86][AVX] Add lowerShuffleAsLanePermuteAndSHUFP lowering.

I haven't looked at v8f32 shuffles yet (only the cases that widen to v4f64 get handled) - but I've just added binary v4f64 support in rG66e39067edbf

Sun, Jan 12, 6:59 AM
RKSimon committed rG065eefcfe969: [AMDGPU] Regenerate shl shift tests (authored by RKSimon).
[AMDGPU] Regenerate shl shift tests
Sun, Jan 12, 6:37 AM
RKSimon committed rGa888277897f7: [MIPS] Regenerate shl/lshr shift tests (authored by RKSimon).
[MIPS] Regenerate shl/lshr shift tests
Sun, Jan 12, 6:37 AM
RKSimon committed rG66e39067edbf: [X86][AVX] Use lowerShuffleAsLanePermuteAndSHUFP to lower binary v4f64 shuffles. (authored by RKSimon).
[X86][AVX] Use lowerShuffleAsLanePermuteAndSHUFP to lower binary v4f64 shuffles.
Sun, Jan 12, 4:36 AM
RKSimon committed rGb375f28b0ec1: [X86][AVX] lowerShuffleAsLanePermuteAndSHUFP - only set the demanded elements… (authored by RKSimon).
[X86][AVX] lowerShuffleAsLanePermuteAndSHUFP - only set the demanded elements…
Sun, Jan 12, 1:46 AM

Sat, Jan 11

RKSimon committed rGfce887beb797: GlobalModuleIndex - Fix use-after-move clang static analyzer warning. (authored by RKSimon).
GlobalModuleIndex - Fix use-after-move clang static analyzer warning.
Sat, Jan 11, 8:47 AM
RKSimon committed rG93431f96a7b1: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Sat, Jan 11, 8:10 AM
RKSimon committed rGbf03944d5d9a: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Sat, Jan 11, 8:10 AM
RKSimon committed rGd87a76c9dae3: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Sat, Jan 11, 8:10 AM
RKSimon committed rGded237b58d56: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Sat, Jan 11, 8:10 AM
RKSimon committed rG16c53ffcb9d0: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Sat, Jan 11, 8:10 AM
RKSimon committed rG2740b2d5d5f0: Fix uninitialized value clang static analyzer warning. NFC. (authored by RKSimon).
Fix uninitialized value clang static analyzer warning. NFC.
Sat, Jan 11, 8:10 AM
RKSimon committed rGa8ed86b5c705: moveOperands - assert Src/Dst MachineOperands are non-null. (authored by RKSimon).
moveOperands - assert Src/Dst MachineOperands are non-null.
Sat, Jan 11, 6:39 AM
RKSimon committed rG24763734e7f4: [X86] Fix outdated comment (authored by RKSimon).
[X86] Fix outdated comment
Sat, Jan 11, 6:39 AM
RKSimon committed rG08275a52d83e: Fix copy+paste typo in shuffle test name (authored by RKSimon).
Fix copy+paste typo in shuffle test name
Sat, Jan 11, 4:57 AM
RKSimon committed rGce35010d782c: [X86][AVX] Add lowerShuffleAsLanePermuteAndSHUFP lowering (authored by RKSimon).
[X86][AVX] Add lowerShuffleAsLanePermuteAndSHUFP lowering
Sat, Jan 11, 4:56 AM

Fri, Jan 10

RKSimon added a comment to D72524: [X86] Try to avoid casts around logical vector ops recursively..

Not sure if its reusable but we already have signExtendBitcastSrcVector which we use for the (i16 bitcast (v16i1 x)) combine

Fri, Jan 10, 11:58 AM · Restricted Project
RKSimon committed rGfd8ded99fe6e: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Fri, Jan 10, 9:43 AM
RKSimon committed rGcce4676d6d78: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Fri, Jan 10, 9:24 AM
RKSimon committed rGcdc9592bf1ac: Fix "pointer is null" static analyzer warning. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warning. NFCI.
Fri, Jan 10, 9:23 AM
RKSimon committed rGa5bdada09def: [X86][AVX] lowerShuffleAsLanePermuteAndShuffle - consistently normalize multi… (authored by RKSimon).
[X86][AVX] lowerShuffleAsLanePermuteAndShuffle - consistently normalize multi…
Fri, Jan 10, 9:23 AM
RKSimon committed rG870f6917936f: Fix "pointer is null" static analyzer warnings. NFCI. (authored by RKSimon).
Fix "pointer is null" static analyzer warnings. NFCI.
Fri, Jan 10, 3:22 AM
RKSimon committed rGf3849f739e52: Fix Wdocumentation warning. NFCI. (authored by RKSimon).
Fix Wdocumentation warning. NFCI.
Fri, Jan 10, 2:47 AM