Page MenuHomePhabricator
Feed Advanced Search

Today

RKSimon added inline comments to D138790: [DAG] Attempt to replace a mul node with an existing umul_lohi/smul_lohi node (PR59217).
Mon, Nov 28, 10:03 AM · Restricted Project, Restricted Project
RKSimon requested review of D138832: [llvm-exegesis][x86] Add option to prevent use of xmm8-xmm15 upper SSE registers.
Mon, Nov 28, 9:59 AM · Restricted Project, Restricted Project
RKSimon committed rGf51170bffd50: [X86] Fix SLM ldmxcsr/stmxcsr schedule classes (authored by RKSimon).
[X86] Fix SLM ldmxcsr/stmxcsr schedule classes
Mon, Nov 28, 9:44 AM · Restricted Project, Restricted Project
RKSimon added a comment to D138819: [SLP]Fix PR59230: Use actual vector factor when sorting entries..

Have you checked if all other Scalars.size() calls are correct?

Mon, Nov 28, 9:20 AM · Restricted Project, Restricted Project
RKSimon committed rGc65d5d4aecc3: [X86] Remove unnecessary (V)?PBLENDW(Y)?rm overrides (authored by RKSimon).
[X86] Remove unnecessary (V)?PBLENDW(Y)?rm overrides
Mon, Nov 28, 8:33 AM · Restricted Project, Restricted Project
RKSimon retitled D138790: [DAG] Attempt to replace a mul node with an existing umul_lohi/smul_lohi node (PR59217) from [DAG] Attempt to replace a mul nodes with an existing umul_lohi/smul_lohi node (PR59217) to [DAG] Attempt to replace a mul node with an existing umul_lohi/smul_lohi node (PR59217).
Mon, Nov 28, 8:26 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D138811: [AArch64] SelectionDag codegen for gpr CTZ instruction.
Mon, Nov 28, 8:25 AM · Restricted Project, Restricted Project
RKSimon requested review of D138790: [DAG] Attempt to replace a mul node with an existing umul_lohi/smul_lohi node (PR59217).
Mon, Nov 28, 4:17 AM · Restricted Project, Restricted Project

Yesterday

RKSimon committed rG026df9514ead: [X86] Remove unnecessary VBLENDWYrr overrides (authored by RKSimon).
[X86] Remove unnecessary VBLENDWYrr overrides
Sun, Nov 27, 8:55 AM · Restricted Project, Restricted Project
RKSimon committed rG23b261377e10: [X86] Add test coverage for Issue #59217 (authored by RKSimon).
[X86] Add test coverage for Issue #59217
Sun, Nov 27, 8:37 AM · Restricted Project, Restricted Project
RKSimon committed rG2285ba9acca4: [X86] Fix uops counts for SLM extract/extract-store instructions (authored by RKSimon).
[X86] Fix uops counts for SLM extract/extract-store instructions
Sun, Nov 27, 8:17 AM · Restricted Project, Restricted Project

Fri, Nov 25

RKSimon added inline comments to D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..
Fri, Nov 25, 9:41 AM · Restricted Project, Restricted Project
RKSimon committed rGc757780c62ab: [X86] lowerShuffleAsDecomposedShuffleMerge - try to match unpck(permute(x)… (authored by RKSimon).
[X86] lowerShuffleAsDecomposedShuffleMerge - try to match unpck(permute(x)…
Fri, Nov 25, 8:25 AM · Restricted Project, Restricted Project
RKSimon committed rGe95c119c3f94: [X86] oddshuffles.ll - update check-prefixes (authored by RKSimon).
[X86] oddshuffles.ll - update check-prefixes
Fri, Nov 25, 8:13 AM · Restricted Project, Restricted Project
RKSimon added a reviewer for D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.: pengfei.

@deadalnix Please can you rebase?

Fri, Nov 25, 7:37 AM · Restricted Project, Restricted Project
RKSimon committed rG38275ab1b398: [X86] Move lowerShuffleAsPermuteAndUnpack earlier in the source next to similar… (authored by RKSimon).
[X86] Move lowerShuffleAsPermuteAndUnpack earlier in the source next to similar…
Fri, Nov 25, 6:57 AM · Restricted Project, Restricted Project
RKSimon committed rG6fd0ae39be79: [X86] combineScalarAndWithMaskSetcc - handle (concat_vectors (and (vYi1 setcc… (authored by RKSimon).
[X86] combineScalarAndWithMaskSetcc - handle (concat_vectors (and (vYi1 setcc…
Fri, Nov 25, 3:29 AM · Restricted Project, Restricted Project
RKSimon committed rGb883e9f3929c: [X86] Add test case for (any_extend (bitcast (concat_vectors (and (vYi1 setcc… (authored by RKSimon).
[X86] Add test case for (any_extend (bitcast (concat_vectors (and (vYi1 setcc…
Fri, Nov 25, 3:29 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..
Fri, Nov 25, 3:14 AM · Restricted Project, Restricted Project

Thu, Nov 24

RKSimon committed rGdbe2f4431680: [X86] combineScalarAndWithMaskSetcc - optionally peek through (oneuse)… (authored by RKSimon).
[X86] combineScalarAndWithMaskSetcc - optionally peek through (oneuse)…
Thu, Nov 24, 8:37 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order..
Thu, Nov 24, 7:59 AM · Restricted Project, Restricted Project
RKSimon committed rG25ea6fa484bf: [X86] Replace InstRW instregex single matches with instrs entries (authored by RKSimon).
[X86] Replace InstRW instregex single matches with instrs entries
Thu, Nov 24, 6:09 AM · Restricted Project, Restricted Project
RKSimon committed rG51d5fd432123: Fix MSVC "signed/unsigned mismatch" warning. NFC. (authored by RKSimon).
Fix MSVC "signed/unsigned mismatch" warning. NFC.
Thu, Nov 24, 6:09 AM · Restricted Project, Restricted Project
RKSimon requested changes to D134982: [X86] Add support for "light" AVX.

Still not a tuning flag

Thu, Nov 24, 4:12 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D138521: [X86] Support ANDNP combine through broadcast instructions with scalar input.
Thu, Nov 24, 2:38 AM · Restricted Project, Restricted Project
RKSimon committed rG6f11c395f589: [X86] combine-and.ll - add AVX2/AVX512 test coverage (authored by RKSimon).
[X86] combine-and.ll - add AVX2/AVX512 test coverage
Thu, Nov 24, 2:38 AM · Restricted Project, Restricted Project

Wed, Nov 23

RKSimon accepted D138427: [CostModel][X86] Fix permute latency cost.

LGTM

Wed, Nov 23, 2:53 AM · Restricted Project, Restricted Project
RKSimon planned changes to D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.

About to go on PTO - I will try to get these changes applied soon.

Wed, Nov 23, 2:15 AM · Restricted Project, Restricted Project
RKSimon added a comment to D138427: [CostModel][X86] Fix permute latency cost.

Have you confirmed that this passes the whole of check-llvm? Sometime these cost changes have effects in transforms/codegen you don't expect

Wed, Nov 23, 2:10 AM · Restricted Project, Restricted Project

Tue, Nov 22

RKSimon accepted D138428: [X86] Use lock add/sub/or/and/xor for cases that we only care about the EFLAGS (negated cases).

LGTM

Tue, Nov 22, 10:22 AM · Restricted Project, Restricted Project
RKSimon committed rG629f17c51637: [DAG] isGuaranteedNotToBeUndefOrPoison - handle FrameIndex/TargetFrameIndex (authored by RKSimon).
[DAG] isGuaranteedNotToBeUndefOrPoison - handle FrameIndex/TargetFrameIndex
Tue, Nov 22, 10:16 AM · Restricted Project, Restricted Project
RKSimon committed rG8fa57a715d56: [X86] Cleanup WriteBlend classes to match (V)PLENDW instruction (authored by RKSimon).
[X86] Cleanup WriteBlend classes to match (V)PLENDW instruction
Tue, Nov 22, 9:56 AM · Restricted Project, Restricted Project
RKSimon added a reviewer for D138185: [InstCombine] Look through bitcast if possible: RKSimon.
Tue, Nov 22, 8:22 AM · Restricted Project, Restricted Project
RKSimon accepted D138485: [CostModel][X86] Add CostKinds test coverage for shufflevector instruction.
Tue, Nov 22, 7:36 AM · Restricted Project, Restricted Project
RKSimon added a comment to D138485: [CostModel][X86] Add CostKinds test coverage for shufflevector instruction.

LGTM - these often end up with missing CHECKS for some RUN combos (and the update scripts sometime fail to warn you) but I can't see any

Tue, Nov 22, 7:35 AM · Restricted Project, Restricted Project
RKSimon requested changes to D138427: [CostModel][X86] Fix permute latency cost.

we don't yet have codesize/latency/sizelatency variants of the shuffle cost tests - these need adding first - it should be as simple as copying the core analysis/costmodel/x86/shuffle-* test files and testing for each cost kind (look at something like the arith-int* files for reference)

Tue, Nov 22, 12:17 AM · Restricted Project, Restricted Project

Mon, Nov 21

RKSimon committed rG746cf4f13fea: [X86] Synchronise scheduler classes of VPERM2F128/VBROADCASTF128/VEXTRACTF128/V… (authored by RKSimon).
[X86] Synchronise scheduler classes of VPERM2F128/VBROADCASTF128/VEXTRACTF128/V…
Mon, Nov 21, 9:16 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D138428: [X86] Use lock add/sub/or/and/xor for cases that we only care about the EFLAGS (negated cases).
Mon, Nov 21, 6:22 AM · Restricted Project, Restricted Project
RKSimon added a comment to D133919: [InstCombine] Fold ((x?1:4)&(y?1:4))==0 to x^y.

@marcauberer reverse ping - what's happening with this patch please?

Mon, Nov 21, 4:49 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D138401: [DAGCombiner] fold or (xor x, y),? patterns.
Mon, Nov 21, 3:20 AM · Restricted Project, Restricted Project
RKSimon accepted D138398: [DAGCombiner] fold or (and x, y), x --> x.

LGTM

Mon, Nov 21, 3:18 AM · Restricted Project, Restricted Project
RKSimon added a comment to D138353: [Passes][VectorCombine] enable early run generally and try load folds.

LGTM - any other comments?

Mon, Nov 21, 3:13 AM · Restricted Project, Restricted Project

Sun, Nov 20

RKSimon added a comment to D138349: [X86][NFC] Minor improvement in X86InstrInfo::optimizeCompareInstr.

please can you add a patch summary

Sun, Nov 20, 1:52 PM · Restricted Project, Restricted Project
RKSimon committed rG89365b159eae: [X86] IceLakeServer - PACKS instructions take latency 3cy (authored by RKSimon).
[X86] IceLakeServer - PACKS instructions take latency 3cy
Sun, Nov 20, 11:29 AM · Restricted Project, Restricted Project
RKSimon added a comment to rG7524db4d447a: [llvm] Remove unused forward declarations (NFC).

@kazu Out of interest - how were you able to identify these?

Sun, Nov 20, 10:25 AM · Restricted Project, Restricted Project
RKSimon committed rG7de156d1cc05: [MCA][X86] Add missing test coverage for BWI instructions (authored by RKSimon).
[MCA][X86] Add missing test coverage for BWI instructions
Sun, Nov 20, 9:21 AM · Restricted Project, Restricted Project
RKSimon committed rG421bdc119a64: [MCA][X86] Add test coverage for IFMA instructions (authored by RKSimon).
[MCA][X86] Add test coverage for IFMA instructions
Sun, Nov 20, 9:21 AM · Restricted Project, Restricted Project
RKSimon committed rG4695f5982a9d: [X86] Remove unnecessary SHLD32rri8/SHRD16rri8 instruction override from bdver2… (authored by RKSimon).
[X86] Remove unnecessary SHLD32rri8/SHRD16rri8 instruction override from bdver2…
Sun, Nov 20, 6:18 AM · Restricted Project, Restricted Project
RKSimon committed rGdd9a900a50f4: [X86] Remove unnecessary XGETBV instruction overrides from znver1/znver2 models (authored by RKSimon).
[X86] Remove unnecessary XGETBV instruction overrides from znver1/znver2 models
Sun, Nov 20, 6:18 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.
Sun, Nov 20, 6:08 AM · Restricted Project, Restricted Project
RKSimon committed rG6a8fabf5c316: [MCA][X86] Add test coverage for XSAVE instructions (authored by RKSimon).
[MCA][X86] Add test coverage for XSAVE instructions
Sun, Nov 20, 5:56 AM · Restricted Project, Restricted Project
RKSimon committed rGa6686aae38c5: [X86] Remove unnecessary RDPMC/RDTSC instruction overrides from znver1/znver2… (authored by RKSimon).
[X86] Remove unnecessary RDPMC/RDTSC instruction overrides from znver1/znver2…
Sun, Nov 20, 5:20 AM · Restricted Project, Restricted Project
RKSimon committed rG9148aeac0072: [X86] Remove unnecessary string instruction overrides from znver1/znver2 models (authored by RKSimon).
[X86] Remove unnecessary string instruction overrides from znver1/znver2 models
Sun, Nov 20, 4:58 AM · Restricted Project, Restricted Project
RKSimon committed rG611db1c78fcb: [X86] Remove unnecessary bit test instruction overrides from znver2 model (authored by RKSimon).
[X86] Remove unnecessary bit test instruction overrides from znver2 model
Sun, Nov 20, 4:22 AM · Restricted Project, Restricted Project
RKSimon committed rG357f1c4ef133: [X86] Improve LOOP/LOOPE/LOOPNE schedule on SandyBridge model (authored by RKSimon).
[X86] Improve LOOP/LOOPE/LOOPNE schedule on SandyBridge model
Sun, Nov 20, 4:13 AM · Restricted Project, Restricted Project
RKSimon committed rG420d02bb55d9: [MCA][X86] Add test coverage for LOOP/LOOPE/LOOPNE instructions (authored by RKSimon).
[MCA][X86] Add test coverage for LOOP/LOOPE/LOOPNE instructions
Sun, Nov 20, 3:35 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.

cleanup comment

Sun, Nov 20, 2:57 AM · Restricted Project, Restricted Project
RKSimon updated the diff for D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.

Remove "NumReadAdvanceEntries == 0" test code

Sun, Nov 20, 2:56 AM · Restricted Project, Restricted Project
RKSimon committed rG94d240a44a52: [X86] Remove unnecessary zmm shuffle instruction overrides from IceLake model (authored by RKSimon).
[X86] Remove unnecessary zmm shuffle instruction overrides from IceLake model
Sun, Nov 20, 2:55 AM · Restricted Project, Restricted Project
RKSimon committed rG13fd7373b6a9: [X86] znver2 - (V)EXTRACTPSrr takes 2 uops (authored by RKSimon).
[X86] znver2 - (V)EXTRACTPSrr takes 2 uops
Sun, Nov 20, 2:55 AM · Restricted Project, Restricted Project
RKSimon added a comment to D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.
Sun, Nov 20, 2:54 AM · Restricted Project, Restricted Project
RKSimon added a comment to D137440: [RISCV][llvm-mca] Use LMUL Instruments to provide more accurate reports on RISCV.

@michaelmaitland I've raised https://github.com/llvm/llvm-project/issues/59091 as we're seeing some MSVC warnings due to multiple inheritance

Sun, Nov 20, 2:42 AM · Restricted Project, Restricted Project

Sat, Nov 19

RKSimon committed rG474e41f1b9ff: [MCA][X86] Add test coverage for BF16 instructions (authored by RKSimon).
[MCA][X86] Add test coverage for BF16 instructions
Sat, Nov 19, 1:48 PM · Restricted Project, Restricted Project
RKSimon committed rGba5714d77352: [MCA][X86] Add test coverage for VP2INTERSECT instructions (authored by RKSimon).
[MCA][X86] Add test coverage for VP2INTERSECT instructions
Sat, Nov 19, 1:48 PM · Restricted Project, Restricted Project
RKSimon committed rG420d0d3aa6b1: [MCA][X86] Add test coverage for VAES instructions (authored by RKSimon).
[MCA][X86] Add test coverage for VAES instructions
Sat, Nov 19, 1:02 PM · Restricted Project, Restricted Project
RKSimon added a comment to D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.

Just how more extra noisy does it become?

Sat, Nov 19, 11:23 AM · Restricted Project, Restricted Project
RKSimon updated the summary of D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.
Sat, Nov 19, 11:22 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.
Sat, Nov 19, 11:22 AM · Restricted Project, Restricted Project
RKSimon committed rG8033141140fe: [X86] Remove unnecessary STC instruction overrides (authored by RKSimon).
[X86] Remove unnecessary STC instruction overrides
Sat, Nov 19, 10:16 AM · Restricted Project, Restricted Project
RKSimon committed rG90702f47cf5c: [X86] Remove unnecessary STD + CLD instruction overrides (authored by RKSimon).
[X86] Remove unnecessary STD + CLD instruction overrides
Sat, Nov 19, 10:16 AM · Restricted Project, Restricted Project
RKSimon requested review of D138359: [TableGen] CheckSchedClassTables - check for unnecessary scheduler overrides.
Sat, Nov 19, 9:42 AM · Restricted Project, Restricted Project
RKSimon committed rG5acc03cdf34b: [TableGen] SubtargetEmitter.cpp - clang-format includes sorting. NFC. (authored by RKSimon).
[TableGen] SubtargetEmitter.cpp - clang-format includes sorting. NFC.
Sat, Nov 19, 8:49 AM · Restricted Project, Restricted Project
RKSimon committed rGe8ea92d24e2b: [X86] Remove some unnecessary cvt overrides (authored by RKSimon).
[X86] Remove some unnecessary cvt overrides
Sat, Nov 19, 7:38 AM · Restricted Project, Restricted Project
RKSimon committed rG88be0a21975b: [X86] Ensure we're testing the misched-matrix.ll tests with the generic cpu (authored by RKSimon).
[X86] Ensure we're testing the misched-matrix.ll tests with the generic cpu
Sat, Nov 19, 6:39 AM · Restricted Project, Restricted Project
RKSimon committed rG3ad13ca278a5: [X86] Regenerate memcpy-2.ll test checks (authored by RKSimon).
[X86] Regenerate memcpy-2.ll test checks
Sat, Nov 19, 6:30 AM · Restricted Project, Restricted Project
RKSimon committed rGaae08b1d372a: [MCA][X86] Add test coverage for BITALG instructions (authored by RKSimon).
[MCA][X86] Add test coverage for BITALG instructions
Sat, Nov 19, 4:05 AM · Restricted Project, Restricted Project
RKSimon accepted D138294: [X86] Use lock or/and/xor for cases that we only care about the EFLAGS.

LGTM

Sat, Nov 19, 3:58 AM · Restricted Project, Restricted Project

Fri, Nov 18

RKSimon committed rG91deae999a1a: [MCA][X86] Add test coverage for VPCLMULQDQ instructions (authored by RKSimon).
[MCA][X86] Add test coverage for VPCLMULQDQ instructions
Fri, Nov 18, 1:23 PM · Restricted Project, Restricted Project
RKSimon committed rGffe05b8f57d9: [MCA][X86] Add missing IceLake test coverage for VPOPCNTDQ instructions (authored by RKSimon).
[MCA][X86] Add missing IceLake test coverage for VPOPCNTDQ instructions
Fri, Nov 18, 1:00 PM · Restricted Project, Restricted Project
RKSimon committed rG4c854120c2b1: [MCA][X86] Add test coverage for AVX512CD instructions (authored by RKSimon).
[MCA][X86] Add test coverage for AVX512CD instructions
Fri, Nov 18, 1:00 PM · Restricted Project, Restricted Project

Thu, Nov 17

RKSimon committed rG6faf5d72459a: Fix MSVC "not all control paths return a value" warning. NFC. (authored by RKSimon).
Fix MSVC "not all control paths return a value" warning. NFC.
Thu, Nov 17, 9:20 AM · Restricted Project, Restricted Project
RKSimon added a comment to D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

@sdardis Any thoughts on the MIPS changes?

Thu, Nov 17, 9:13 AM · Restricted Project, Restricted Project
RKSimon accepted D137711: [X86] Use lock add/sub for cases that we only care about the EFLAGS.

LGTM (with the test precommit) - cheers

Thu, Nov 17, 7:00 AM · Restricted Project, Restricted Project
RKSimon added a comment to D138186: InstCombine: Simplify vector load based on demanded elements.

Agreed - as it is this patch puts even more strain on the DAG to load combine back to legality.

Thu, Nov 17, 6:53 AM · Restricted Project, Restricted Project

Wed, Nov 16

RKSimon committed rGbecf7b2259d6: [X86] Remove unnecessary override GFNI AFFINE reg-reg overrides from AlderlakeP… (authored by RKSimon).
[X86] Remove unnecessary override GFNI AFFINE reg-reg overrides from AlderlakeP…
Wed, Nov 16, 9:46 AM · Restricted Project, Restricted Project
RKSimon committed rGc6a838e9c89a: [MCA][X86] Add test coverage for VBMI instructions (authored by RKSimon).
[MCA][X86] Add test coverage for VBMI instructions
Wed, Nov 16, 9:00 AM · Restricted Project, Restricted Project
RKSimon committed rGa92f5a08a1eb: [DAG] simplifySelect - add support for vselect(0, T, F) -> F fold (authored by RKSimon).
[DAG] simplifySelect - add support for vselect(0, T, F) -> F fold
Wed, Nov 16, 5:11 AM · Restricted Project, Restricted Project
RKSimon committed rGff252e6b13ec: [X86] combineConcatVectorOps - don't concat(vselect,vselect) if the… (authored by RKSimon).
[X86] combineConcatVectorOps - don't concat(vselect,vselect) if the…
Wed, Nov 16, 3:49 AM · Restricted Project, Restricted Project
RKSimon committed rG5ea7b6b78ff6: [X86] vselect-avx.ll - add AVX512 test coverage (authored by RKSimon).
[X86] vselect-avx.ll - add AVX512 test coverage
Wed, Nov 16, 3:12 AM · Restricted Project, Restricted Project

Tue, Nov 15

RKSimon accepted D137913: [X86] Rewrite `getScalarizationOverhead()`.

LGTM - cheers

Tue, Nov 15, 10:02 AM · Restricted Project, Restricted Project
RKSimon added a comment to D137913: [X86] Rewrite `getScalarizationOverhead()`.

I think the FIXME would be more useful if it was added to the code than forgotten in a commit message?

Tue, Nov 15, 7:20 AM · Restricted Project, Restricted Project
RKSimon accepted D137963: DAG: Fix assert on load casted to vector with attached range metadata.

LGTM

Tue, Nov 15, 4:03 AM · Restricted Project, Restricted Project
RKSimon committed rG896271dbea18: [MCA][X86] Ensure the avx512 gfni tests use the upper xmm/ymm registers (authored by RKSimon).
[MCA][X86] Ensure the avx512 gfni tests use the upper xmm/ymm registers
Tue, Nov 15, 3:07 AM · Restricted Project, Restricted Project

Mon, Nov 14

RKSimon added inline comments to D137963: DAG: Fix assert on load casted to vector with attached range metadata.
Mon, Nov 14, 10:12 AM · Restricted Project, Restricted Project
RKSimon committed rG7e786857526e: [MCA][X86] Ensure the avx512 vnni tests use the upper xmm/ymm registers (authored by RKSimon).
[MCA][X86] Ensure the avx512 vnni tests use the upper xmm/ymm registers
Mon, Nov 14, 8:31 AM · Restricted Project, Restricted Project
RKSimon committed rGd7208b04045b: [MCA][X86] Add test coverage for VBMI2 instructions (authored by RKSimon).
[MCA][X86] Add test coverage for VBMI2 instructions
Mon, Nov 14, 8:30 AM · Restricted Project, Restricted Project
RKSimon committed rG814267e3ee11: [X86] Remove unnecessary overrides for CBW/CWDE/CDQE/CMC instructions (authored by RKSimon).
[X86] Remove unnecessary overrides for CBW/CWDE/CDQE/CMC instructions
Mon, Nov 14, 7:12 AM · Restricted Project, Restricted Project
RKSimon added a comment to D137913: [X86] Rewrite `getScalarizationOverhead()`.

Thanks - almost there! Please can you tidyup the patch summary?

Mon, Nov 14, 6:53 AM · Restricted Project, Restricted Project
RKSimon added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Mon, Nov 14, 4:35 AM · Restricted Project, Restricted Project
RKSimon added a comment to D137913: [X86] Rewrite `getScalarizationOverhead()`.

please can you recreate the diffs with context?

Mon, Nov 14, 4:29 AM · Restricted Project, Restricted Project