Page MenuHomePhabricator
Feed Advanced Search

Today

dsanders added a comment to D69836: [MIR] Target specific MIR formating and parsing.

Thanks for doing this. It should make a lot of things easier to read.

Wed, Nov 13, 11:14 AM · Restricted Project

Thu, Nov 7

dsanders committed rG25ee861372f1: [debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils (authored by dsanders).
[debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils
Thu, Nov 7, 2:45 PM
dsanders closed D69926: [debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils.
Thu, Nov 7, 2:45 PM · Restricted Project

Wed, Nov 6

dsanders created D69926: [debugify] Move the Debugify pass from tools/opt to lib/Transform/Utils.
Wed, Nov 6, 4:11 PM · Restricted Project

Tue, Nov 5

dsanders committed rGe0dd8f36ce49: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode… (authored by dsanders).
[globalisel][docs] Rework GMIR documentation and add an early GenericOpcode…
Tue, Nov 5, 3:51 PM
dsanders committed rGad0dfb0a2534: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode… (authored by dsanders).
[globalisel][docs] Rework GMIR documentation and add an early GenericOpcode…
Tue, Nov 5, 3:24 PM
dsanders closed D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Tue, Nov 5, 3:24 PM · Restricted Project
dsanders committed rG7060840bc9cc: [globalisel][docs] Add a section about debugging with the block extractor (authored by dsanders).
[globalisel][docs] Add a section about debugging with the block extractor
Tue, Nov 5, 2:56 PM
dsanders closed D69645: [globalisel][docs] Add a section about debugging with the block extractor.
Tue, Nov 5, 2:56 PM · Restricted Project
dsanders added a comment to D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

Thanks.

I realized I missed a couple things in this patch this morning:

  • Filenames containing 'gep'
  • Functions named buildGep() and similar I'll fix both of this this before pushing

If you're fixing names of instructions, that buildUndef doesn't match the G_IMPLICIT_DEF name has bothered me. I'm not sure which should be renamed

Tue, Nov 5, 12:20 PM · Restricted Project
dsanders committed rGe74c5b96610d: [globalisel] Rename G_GEP to G_PTR_ADD (authored by dsanders).
[globalisel] Rename G_GEP to G_PTR_ADD
Tue, Nov 5, 10:38 AM
dsanders closed D69734: [globalisel] Rename G_GEP to G_PTR_ADD.
Tue, Nov 5, 10:38 AM · Restricted Project
dsanders added a comment to D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

... this this ...

Tue, Nov 5, 10:29 AM · Restricted Project
dsanders added a comment to D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

I realized I missed a couple things in this patch this morning:

  • Filenames containing 'gep'
  • Functions named buildGep() and similar

I'll fix both of this this before pushing

Tue, Nov 5, 10:19 AM · Restricted Project
dsanders committed rG312932a33463: [globalisel][docs] Add KnownBits Analysis documentation (authored by dsanders).
[globalisel][docs] Add KnownBits Analysis documentation
Tue, Nov 5, 10:01 AM
dsanders closed D69644: [globalisel][docs] Add KnownBits Analysis documentation.
Tue, Nov 5, 10:01 AM · Restricted Project
dsanders added inline comments to D69644: [globalisel][docs] Add KnownBits Analysis documentation.
Tue, Nov 5, 10:01 AM · Restricted Project

Mon, Nov 4

dsanders added a comment to D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.

FWIW I too would prefer generating this automatically (e.g. as is done for clang's AST Matchers) but I don't know the caveats involved in doing that. I suppose we could start with this and automate later (similarly to how we started with hand-written code and then moved to TableGen).

Mon, Nov 4, 12:04 PM · Restricted Project
dsanders updated the diff for D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.

Updated MachineIRBuilder function to match GenericOpcodes.td

Mon, Nov 4, 11:54 AM · Restricted Project
dsanders updated the diff for D69644: [globalisel][docs] Add KnownBits Analysis documentation.

s/llvm-mir-body/none/g properly

Mon, Nov 4, 11:26 AM · Restricted Project
dsanders added inline comments to D69644: [globalisel][docs] Add KnownBits Analysis documentation.
Mon, Nov 4, 10:58 AM · Restricted Project
dsanders updated the diff for D69644: [globalisel][docs] Add KnownBits Analysis documentation.

Fix the two nits.
Also s/llvm-mir-body/none/g as the upstream bot treats warnings as errors.

Mon, Nov 4, 10:58 AM · Restricted Project

Fri, Nov 1

dsanders created D69734: [globalisel] Rename G_GEP to G_PTR_ADD.
Fri, Nov 1, 1:19 PM · Restricted Project

Thu, Oct 31

dsanders added inline comments to D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Thu, Oct 31, 5:21 PM · Restricted Project
dsanders updated the diff for D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.

Fix the various typos (except the 'treat' one which I didn't understand)

Thu, Oct 31, 2:15 PM · Restricted Project

Wed, Oct 30

dsanders committed rG204a529cb0d6: [globalisel][docs] Add the tutorial to the Porting document (authored by dsanders).
[globalisel][docs] Add the tutorial to the Porting document
Wed, Oct 30, 2:59 PM
dsanders created D69645: [globalisel][docs] Add a section about debugging with the block extractor.
Wed, Oct 30, 2:49 PM · Restricted Project
dsanders added a child revision for D69644: [globalisel][docs] Add KnownBits Analysis documentation: D69645: [globalisel][docs] Add a section about debugging with the block extractor.
Wed, Oct 30, 2:49 PM · Restricted Project
dsanders created D69644: [globalisel][docs] Add KnownBits Analysis documentation.
Wed, Oct 30, 2:30 PM · Restricted Project
dsanders added a child revision for D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference: D69644: [globalisel][docs] Add KnownBits Analysis documentation.
Wed, Oct 30, 2:30 PM · Restricted Project
dsanders committed rG2d098bea0361: [globalisel][docs] Rework the Legalizer page slightly (authored by dsanders).
[globalisel][docs] Rework the Legalizer page slightly
Wed, Oct 30, 1:44 PM
dsanders updated the diff for D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.

Fix for Diana's review comments

Wed, Oct 30, 12:19 PM · Restricted Project
dsanders committed rG91e2151d04cc: [globalisel][docs] Add a pass index (authored by dsanders).
[globalisel][docs] Add a pass index
Wed, Oct 30, 12:10 PM
dsanders committed rG443f99eae268: [globalisel][docs] Fix a label that was renamed (authored by dsanders).
[globalisel][docs] Fix a label that was renamed
Wed, Oct 30, 11:50 AM

Tue, Oct 29

dsanders committed rG3260fa2cb09b: [globalisel][docs] Fix warning treated as error (authored by dsanders).
[globalisel][docs] Fix warning treated as error
Tue, Oct 29, 5:44 PM
dsanders committed rG6f665fc7868b: [globalisel][docs] Rewrite the IRTranslator documentation (authored by dsanders).
[globalisel][docs] Rewrite the IRTranslator documentation
Tue, Oct 29, 5:44 PM
dsanders closed D69457: [globalisel][docs] Rewrite the IRTranslator documentation.
Tue, Oct 29, 5:44 PM · Restricted Project
dsanders added a child revision for D69457: [globalisel][docs] Rewrite the IRTranslator documentation: D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Tue, Oct 29, 1:20 PM · Restricted Project
dsanders added a parent revision for D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference: D69457: [globalisel][docs] Rewrite the IRTranslator documentation.
Tue, Oct 29, 1:20 PM · Restricted Project
dsanders added a comment to D69456: [globalisel][docs] Rewrite the pipeline overview.

Thanks. llvm.org doesn't seem to be have the previous changes yet so I've asked on llvm-dev about that. Maybe the update mechanism is broken

Tue, Oct 29, 12:00 PM · Restricted Project
dsanders committed rG1765f31f5adf: [globalisel][docs] Rewrite the pipeline overview (authored by dsanders).
[globalisel][docs] Rewrite the pipeline overview
Tue, Oct 29, 11:23 AM
dsanders closed D69456: [globalisel][docs] Rewrite the pipeline overview.
Tue, Oct 29, 11:23 AM · Restricted Project

Mon, Oct 28

dsanders added inline comments to D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Mon, Oct 28, 8:49 PM · Restricted Project
dsanders created D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Mon, Oct 28, 7:13 PM · Restricted Project
dsanders added inline comments to D69457: [globalisel][docs] Rewrite the IRTranslator documentation.
Mon, Oct 28, 12:51 PM · Restricted Project
dsanders updated the diff for D69457: [globalisel][docs] Rewrite the IRTranslator documentation.

Fixed the review comments
Strengthened the caution on the CallLowering section as Matt confirmed it's no longer accurate

Mon, Oct 28, 12:47 PM · Restricted Project
dsanders updated the diff for D69456: [globalisel][docs] Rewrite the pipeline overview.

Fix the image too

Mon, Oct 28, 11:26 AM · Restricted Project
dsanders updated the diff for D69456: [globalisel][docs] Rewrite the pipeline overview.

Updated for review comments (except the picture, that will follow shortly)

Mon, Oct 28, 11:24 AM · Restricted Project
dsanders added a comment to D69456: [globalisel][docs] Rewrite the pipeline overview.

Thanks for writing this up! I just have a few suggestions and one small bug to point out (I can't figure out how to comment on a png file, so I'll write it here).

llvm/docs/GlobalISel/testing-pass-level.png: Between the Register Bank Selector and the Instruction Selector, it should be gMIR + MIR (right now it's just MIR).

Mon, Oct 28, 11:23 AM · Restricted Project

Fri, Oct 25

dsanders created D69457: [globalisel][docs] Rewrite the IRTranslator documentation.
Fri, Oct 25, 7:56 PM · Restricted Project
dsanders added a child revision for D69456: [globalisel][docs] Rewrite the pipeline overview: D69457: [globalisel][docs] Rewrite the IRTranslator documentation.
Fri, Oct 25, 7:56 PM · Restricted Project
dsanders created D69456: [globalisel][docs] Rewrite the pipeline overview.
Fri, Oct 25, 6:19 PM · Restricted Project
dsanders committed rGfeab0334f57d: [globalisel] Restructure the GlobalISel documentation (authored by dsanders).
[globalisel] Restructure the GlobalISel documentation
Fri, Oct 25, 3:52 PM
dsanders committed rG27887bc1e7a1: [globalisel] Fix typo in 'Add LLVMDev 2019 talks and links for the 2017 talks' (authored by dsanders).
[globalisel] Fix typo in 'Add LLVMDev 2019 talks and links for the 2017 talks'
Fri, Oct 25, 3:06 PM
dsanders committed rG7913126a08e5: [globalisel] Add LLVMDev 2019 talks and links for the 2017 talks (authored by dsanders).
[globalisel] Add LLVMDev 2019 talks and links for the 2017 talks
Fri, Oct 25, 2:57 PM
dsanders updated the diff for D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

Merge LLVM_DEBUG's

Fri, Oct 25, 1:53 PM · Restricted Project
dsanders added a comment to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

Is there a mechanism here for supporting hasOneUse checks?

Fri, Oct 25, 1:52 PM · Restricted Project
dsanders added a comment to D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.

Ping

Fri, Oct 25, 1:06 PM · Restricted Project
dsanders committed rGa6e1de4afc51: [gicombiner] Add parse failure tests for defs/match (authored by dsanders).
[gicombiner] Add parse failure tests for defs/match
Fri, Oct 25, 12:57 PM

Thu, Oct 24

dsanders accepted D69367: [GlobalISel][AArch64][AMDGPU][X86] Teach LegalizationArtifactCombiner to combine trunc(g_constant)..

LGTM too

Thu, Oct 24, 8:03 PM · Restricted Project

Thu, Oct 17

dsanders created D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Thu, Oct 17, 6:39 PM · Restricted Project
dsanders added a child revision for D69151: [gicombiner] Import tryCombineIndexedLoadStore(): D69152: [gicombiner] Add GIMatchTree and use it for the code generation.
Thu, Oct 17, 6:39 PM · Restricted Project
dsanders created D69151: [gicombiner] Import tryCombineIndexedLoadStore().
Thu, Oct 17, 5:36 PM · Restricted Project
dsanders added a child revision for D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply: D69151: [gicombiner] Import tryCombineIndexedLoadStore().
Thu, Oct 17, 5:36 PM · Restricted Project
dsanders created D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.
Thu, Oct 17, 3:34 PM · Restricted Project
dsanders added a child revision for D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots: D69147: [gicombiner] Add support for arbitrary match data being passed from match to apply.
Thu, Oct 17, 3:34 PM · Restricted Project
dsanders added inline comments to D68438: [gicombiner] Add the run-time rule disable option.
Thu, Oct 17, 10:23 AM · Restricted Project
dsanders added inline comments to D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Thu, Oct 17, 10:04 AM · Restricted Project
dsanders added a child revision for D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input: D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Thu, Oct 17, 9:55 AM · Restricted Project
dsanders created D69117: [gicombiner] Process the MatchDag such that every node is reachable from the roots.
Thu, Oct 17, 9:55 AM · Restricted Project

Wed, Oct 16

dsanders created D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input.
Wed, Oct 16, 6:36 PM · Restricted Project
dsanders committed rG6150093e2281: Correct placement of #ifndef NDEBUG in r375067 (authored by dsanders).
Correct placement of #ifndef NDEBUG in r375067
Wed, Oct 16, 6:27 PM
dsanders committed rG149a02042531: Fix unused variable in r375066 (authored by dsanders).
Fix unused variable in r375066
Wed, Oct 16, 6:27 PM
dsanders committed rL375071: Correct placement of #ifndef NDEBUG in r375067.
Correct placement of #ifndef NDEBUG in r375067
Wed, Oct 16, 6:27 PM
dsanders committed rL375070: Fix unused variable in r375066.
Fix unused variable in r375066
Wed, Oct 16, 6:27 PM
dsanders committed rG329e748c8c3b: [gicombiner] Add the run-time rule disable option (authored by dsanders).
[gicombiner] Add the run-time rule disable option
Wed, Oct 16, 5:39 PM
dsanders committed rL375067: [gicombiner] Add the run-time rule disable option.
[gicombiner] Add the run-time rule disable option
Wed, Oct 16, 5:38 PM
dsanders closed D68438: [gicombiner] Add the run-time rule disable option.
Wed, Oct 16, 5:38 PM · Restricted Project
dsanders committed rGec5208fd6566: [gicombiner] Hoist pure C++ combine into the tablegen definition (authored by dsanders).
[gicombiner] Hoist pure C++ combine into the tablegen definition
Wed, Oct 16, 5:01 PM
dsanders committed rL375057: [gicombiner] Hoist pure C++ combine into the tablegen definition.
[gicombiner] Hoist pure C++ combine into the tablegen definition
Wed, Oct 16, 5:01 PM
dsanders closed D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Wed, Oct 16, 5:01 PM · Restricted Project
dsanders updated the diff for D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.

Rename the variable holding the fixup code block

Wed, Oct 16, 3:54 PM · Restricted Project
dsanders added inline comments to D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Wed, Oct 16, 3:36 PM · Restricted Project

Tue, Oct 15

dsanders updated the diff for D68438: [gicombiner] Add the run-time rule disable option.
  • setRuleDisabled wasn't quite right w.r.t disabling by id either
Tue, Oct 15, 4:50 PM · Restricted Project
dsanders added inline comments to D68438: [gicombiner] Add the run-time rule disable option.
Tue, Oct 15, 4:32 PM · Restricted Project
dsanders updated the diff for D68438: [gicombiner] Add the run-time rule disable option.
  • Fix up nits
Tue, Oct 15, 4:32 PM · Restricted Project

Oct 8 2019

dsanders committed rG4b7cabf1e16f: [tblgen] Add getOperatorAsDef() to Record (authored by dsanders).
[tblgen] Add getOperatorAsDef() to Record
Oct 8 2019, 11:44 AM
dsanders closed D68424: [tblgen] Add getOperatorAsDef() to Record.
Oct 8 2019, 11:44 AM · Restricted Project
dsanders committed rL374101: [tblgen] Add getOperatorAsDef() to Record.
[tblgen] Add getOperatorAsDef() to Record
Oct 8 2019, 11:44 AM

Oct 7 2019

dsanders accepted D68538: GlobalISel: Partially implement lower for G_INSERT.

LGTM

Oct 7 2019, 10:44 AM

Oct 3 2019

dsanders created D68438: [gicombiner] Add the run-time rule disable option.
Oct 3 2019, 6:02 PM · Restricted Project
dsanders added a child revision for D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition: D68438: [gicombiner] Add the run-time rule disable option.
Oct 3 2019, 6:02 PM · Restricted Project
dsanders created D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Oct 3 2019, 2:44 PM · Restricted Project
dsanders added a child revision for D68424: [tblgen] Add getOperatorAsDef() to Record: D68426: [gicombiner] Hoist pure C++ combine into the tablegen definition.
Oct 3 2019, 2:44 PM · Restricted Project
dsanders created D68424: [tblgen] Add getOperatorAsDef() to Record.
Oct 3 2019, 2:20 PM · Restricted Project
dsanders added inline comments to D68288: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
Oct 3 2019, 1:27 PM · Restricted Project
dsanders committed rG18350af15930: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion (authored by dsanders).
[gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion
Oct 3 2019, 12:14 PM
dsanders committed rL373651: [gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion.
[gicombiner] Add a CodeExpander to handle C++ fragments with variable expansion
Oct 3 2019, 12:13 PM

Oct 2 2019

dsanders committed rG45f682f47129: [gicombiner] Make rL373551 compatible with older cmakes (authored by dsanders).
[gicombiner] Make rL373551 compatible with older cmakes
Oct 2 2019, 6:54 PM
dsanders committed rL373555: [gicombiner] Make rL373551 compatible with older cmakes.
[gicombiner] Make rL373551 compatible with older cmakes
Oct 2 2019, 6:47 PM