Page MenuHomePhabricator
Feed Advanced Search

Today

aminya awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Party Time token.
Fri, Nov 26, 1:35 PM · Restricted Project, Restricted Project

Sat, Nov 13

csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

I don't have commit access, so please submit this change on my behalf.

Sat, Nov 13, 12:27 PM · Restricted Project, Restricted Project
csmulhern added inline comments to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sat, Nov 13, 8:06 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sat, Nov 13, 8:01 AM · Restricted Project, Restricted Project

Thu, Nov 11

csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

Any further feedback on the latest iteration?

Thu, Nov 11, 8:54 PM · Restricted Project, Restricted Project

Oct 25 2021

csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Oct 25 2021, 6:47 AM · Restricted Project, Restricted Project

Oct 23 2021

csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

Absent feedback, I have gone ahead and added a BlockIndent option to AlignAfterOpenBracket.

Oct 23 2021, 4:17 PM · Restricted Project, Restricted Project
csmulhern retitled D109557: Adds a BlockIndent option to AlignAfterOpenBracket from Adds a BreakBeforeClosingParen option to Adds a BlockIndent option to AlignAfterOpenBracket.
Oct 23 2021, 4:14 PM · Restricted Project, Restricted Project

Oct 17 2021

maksim awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Love token.
Oct 17 2021, 5:45 AM · Restricted Project, Restricted Project

Oct 15 2021

csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

Do you think this is going to need some other capability to put the break after the opening paren? e.g. BreakAfterOpeningParen

if (
    ^
Oct 15 2021, 7:45 AM · Restricted Project, Restricted Project

Oct 14 2021

xgupta awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Pterodactyl token.
Oct 14 2021, 10:22 PM · Restricted Project, Restricted Project
jeevcat awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Like token.
Oct 14 2021, 9:26 PM · Restricted Project, Restricted Project
fdwr awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Love token.
Oct 14 2021, 10:49 AM · Restricted Project, Restricted Project
reupen awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Like token.
Oct 14 2021, 4:52 AM · Restricted Project, Restricted Project
csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

The you quoted would, in my mind, be formatted like this:

void foo() {
    if (
        quitelongarg != (alsolongarg - 1)
    ) { // ABC is a very longgggggggggggg comment
        return;
    }
}

This is because I don't allow breaking the closing paren without breaking after the opening paren, but this might be only my own style.

Yes, this is not what you are going to get with this revision, we need to decide if that is what is expected

Oct 14 2021, 4:24 AM · Restricted Project, Restricted Project
kring awarded D109557: Adds a BlockIndent option to AlignAfterOpenBracket a Love token.
Oct 14 2021, 3:25 AM · Restricted Project, Restricted Project

Sep 24 2021

csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

We would need your name and email address to commit this for you in the form git commit --amend --author="John Doe <jdoe@llvm.org>"

See https://llvm.org/docs/DeveloperPolicy.html

Sep 24 2021, 3:49 AM · Restricted Project, Restricted Project

Sep 21 2021

csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

This seems ok, might be worth adding a release note

Sep 21 2021, 5:40 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 21 2021, 5:39 AM · Restricted Project, Restricted Project

Sep 20 2021

csmulhern added inline comments to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 20 2021, 2:26 PM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 20 2021, 2:26 PM · Restricted Project, Restricted Project

Sep 18 2021

csmulhern added inline comments to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 18 2021, 7:17 AM · Restricted Project, Restricted Project

Sep 16 2021

csmulhern added inline comments to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 16 2021, 9:43 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 16 2021, 9:43 AM · Restricted Project, Restricted Project

Sep 15 2021

csmulhern added inline comments to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 15 2021, 4:07 PM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 15 2021, 4:07 PM · Restricted Project, Restricted Project
csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

I haven't looked too much into it, my main point is that there should be tests for both variants of that option for braces, parenthesis, and angular braces, if they are handled by that option. Otherwise the documentation (and naming?) should be adapted. If the defaults differ, the option has to be reworked, for a finer control.

Sep 15 2021, 10:43 AM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 15 2021, 10:40 AM · Restricted Project, Restricted Project

Sep 13 2021

csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 13 2021, 4:38 PM · Restricted Project, Restricted Project
csmulhern updated the diff for D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

Adds more context to the diff.

Sep 13 2021, 4:27 PM · Restricted Project, Restricted Project
csmulhern added a comment to D109557: Adds a BlockIndent option to AlignAfterOpenBracket.

I've added more information to my original message. Please let me know if further context is desired.

Sep 13 2021, 10:08 AM · Restricted Project, Restricted Project
csmulhern updated the summary of D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 13 2021, 10:07 AM · Restricted Project, Restricted Project

Sep 9 2021

csmulhern requested review of D109557: Adds a BlockIndent option to AlignAfterOpenBracket.
Sep 9 2021, 5:37 PM · Restricted Project, Restricted Project