Let's document the option as well under: https://clang.llvm.org/docs/ClangCommandLineReference.html#powerpc

Fix bug: StringRef::lower() returns a std::string as a temporary, and Twine doesn't own the memory of the substrings.
The temporary should be used in the same C++ statement so that there's no lifetime issues.

Is there any reason to require an even number of hex digits? Or to convert the hex string to lower case?

add new test

add "<0xHEXSTRING>" to the option documentation.

LGTM. Would be nice to get @daltenty 's approval too.

testcase?

LGTM

Fixed by D136192

I wasn't included as a reviewer on D124857 and I missed that change so couldn't comment there, but I'm not a fan of including the AIX support in InstrProfilingPlatformLinux.c. AIX is neither Linux nor ELF-based and big chunks of that file are now #ifdefed out making it harder to comprehend which part is used where. I'd prefer introducing InstrProfilingPlatformAIX.c, moving the AIX-specific logic there, and then figuring out how to possibly share common parts between InstrProfilingPlatformLinux.c and InstrProfilingPlatformAIX.c, for example by moving them to an .inc file.

@phosek @MaskRay If you can kindly review this patch as it affects non-AIX platforms with the changes in compiler-rt/lib/profile/InstrProfilingRuntime.cpp. I'm hoping the change are like for like but I cannot be sure for all platforms.

Don't move around code in InstrProfilingPlatformLinux.c

Improve the current patch and integrate D134253 into it.

@MaskRay please let me know if you have any comments. This affect AIX only, but might reduce readability with the introduction of the #if's

replace %clang -fprofile-generate with %clang_pgogen in the testcase.

@hubert.reinterpretcast do you think we shud add the "keep()" testcase as a LIT?

Redo the variable retainment mechanism based on offline discussion with @hubert.reinterpretcast that followed his code review comments.

LGTM

In D134222#3815956, @jansvoboda11 wrote:

In D134222#3815793, @w2yehia wrote:

@jansvoboda11
FYI, this is breaking AIX buildbot:
https://lab.llvm.org/buildbot/#/builders/214/builds/3436/steps/6/logs/FAIL__Clang__modules-header-sharing_m

Thanks for reporting this and sorry for the breakage. Should be fixed in 8df1f3bc19d7.

@jansvoboda11
FYI, this is breaking AIX buildbot:
https://lab.llvm.org/buildbot/#/builders/214/builds/3436/steps/6/logs/FAIL__Clang__modules-header-sharing_m

Address code review comments.

add testcase

Looks good. Thanks.

In D129401#3655316, @quinnp wrote:

I've realized that getExplicitDataSections() interacts with ...

LGTM

use update_test_checks.py to generate the CHECKs

@nikic any chance you can review this today? thanks!

As per review, remove !OBI->hasNoSignedWrap() from the early exit condition. Also the original fix is no longer needed so remove it as well.

Address one comment.