Page MenuHomePhabricator
Feed Advanced Search

Yesterday

mstorsjo added a comment to D61892: [AArch64] Treat x18 as callee-saved in functions with windows calling convention on non-windows OSes.

@rnk - if you have time before you go on your leave - could you have a look at this one?

Mon, May 25, 9:37 AM · Restricted Project
mstorsjo added a comment to D61892: [AArch64] Treat x18 as callee-saved in functions with windows calling convention on non-windows OSes.
Mon, May 25, 9:06 AM · Restricted Project
mstorsjo committed rG760f45eacadb: [CMake] Properly handle the LTO cache arguments for MinGW (authored by thieta).
[CMake] Properly handle the LTO cache arguments for MinGW
Mon, May 25, 1:02 AM
mstorsjo closed D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.
Mon, May 25, 1:02 AM · Restricted Project

Sun, May 24

mstorsjo added a reviewer for D80492: Avoid linking libdl unless needed: beanz.

I think this is ok, but adding @beanz who knows the cmake conventions better than me.

Sun, May 24, 12:16 PM · Restricted Project
mstorsjo accepted D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.

Note that this will break when building with LTO and a older lld than what ships before the addition of that option in the tree. We could add logic for checking if the linker flags are correct - but I think when using LTO multi-stage builds are not uncommon.

Sun, May 24, 11:12 AM · Restricted Project
mstorsjo added a comment to D80425: Fix LLVM/Clang builds with mingw toolchain.

I am planning to revise this one now that we have thinlto-cache-dir option landed here are my plans:

  • Keep the libdl patch as is (seems like there are no more comments on this).
  • Remove the symlink patch for now and potentially move that to another patch
  • Rework the cache-dir option so that it passes the same option as we pass to ELF lld.

    Is that what everyone would expect?
Sun, May 24, 6:23 AM · Restricted Project, Restricted Project
mstorsjo committed rGf794808bb9ec: [LLD/MinGW]: Expose --thinlto-cache-dir (authored by thieta).
[LLD/MinGW]: Expose --thinlto-cache-dir
Sun, May 24, 2:40 AM
mstorsjo closed D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.
Sun, May 24, 2:40 AM · Restricted Project, lld

Sat, May 23

mstorsjo added a comment to D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.

Could you commit this for me Martin? I don't have access yet.

Sat, May 23, 2:19 PM · Restricted Project, lld
mstorsjo added inline comments to D80425: Fix LLVM/Clang builds with mingw toolchain.
Sat, May 23, 1:15 PM · Restricted Project, Restricted Project
mstorsjo accepted D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.

LGTM, thanks!

Sat, May 23, 12:43 PM · Restricted Project, lld

Fri, May 22

mstorsjo added inline comments to D80425: Fix LLVM/Clang builds with mingw toolchain.
Fri, May 22, 2:30 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.

Looks great in general, a couple nitpicks

Fri, May 22, 1:27 PM · Restricted Project, lld
mstorsjo added a comment to D80425: Fix LLVM/Clang builds with mingw toolchain.

Super-nitpick: If you want to capitalize mingw, it's MinGW (minimalist gnu for windows) 😛 But as that's rather annoying to type, the all-lowercase version is quite fine as well.

Fri, May 22, 3:00 AM · Restricted Project, Restricted Project

Thu, May 21

mstorsjo abandoned D79934: [RFC] [LLD] [COFF] Support options for enabling/disabling autoimport and pseudo relocs in .drectve sections.

Yeah, let's shelve this one for now.

Thu, May 21, 1:32 PM · Restricted Project

Tue, May 19

mstorsjo updated the diff for D61892: [AArch64] Treat x18 as callee-saved in functions with windows calling convention on non-windows OSes.

Removing the RFC marking from this one, with the intention of getting it merged. It's a pretty non-intrusive (and cheap) fix and for maintaining x18 across wine built in functions - I've tested it in daily use for a month now and the fix does seem to behave as intended. Wine builds most DLLs as PE DLLs these days, so callbacks is no longer an issue for the built-in modules built as PE DLLs.

Tue, May 19, 3:45 AM · Restricted Project

Mon, May 18

mstorsjo added a reviewer for D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names: fhahn.
Mon, May 18, 2:39 PM · Restricted Project
mstorsjo committed rG54a85240709e: [compiler-rt] Don't error out on missing builtins when builting builtins… (authored by mstorsjo).
[compiler-rt] Don't error out on missing builtins when builting builtins…
Mon, May 18, 1:34 AM
mstorsjo added a comment to D79470: [Compiler-rt] Emit error if builtins library cannot be found.

Because when building the builtins themselves, we can't expect to find builtins, right? (Alternatively the check against clang_rt.builtins could be moved down to the NOTFOUND case.)

You're right, we shouldn't fail the build for standalone clang_rt.builtins target. Please submit your change.

Mon, May 18, 1:34 AM · Restricted Project
mstorsjo added a comment to D79470: [Compiler-rt] Emit error if builtins library cannot be found.

This broke bootstrapping compiler-rt builtins for me.

Mon, May 18, 12:29 AM · Restricted Project

Fri, May 15

mstorsjo added a comment to D79999: [lldb] [Windows] Provide vasprintf only for MSVC.

Perhaps you are building with Clang?
I don't remember the message but GCC emits error about incompatible definition and declaration of vasprintf. I can build it without the patch and paste the error if you want.

Fri, May 15, 11:25 AM · Restricted Project
mstorsjo added reviewers for D79999: [lldb] [Windows] Provide vasprintf only for MSVC: labath, amccarth, mstorsjo.

+1 from me on this, I'm ok with this change. I'm a bit curious as I haven't seen any issues regarding this myself though. I wonder if it something very MSYS2-specific, or is the difference in building with gcc vs clang?

Fri, May 15, 10:51 AM · Restricted Project
mstorsjo added a reviewer for D79995: [clang] [MinGW] Fix libunwind extension: rnk.

So, using -l:libunwind.dll.a is definitely more correct than -l:libunwind.so on this platform, so in that sense this is good.

Fri, May 15, 10:51 AM · Restricted Project

Thu, May 14

mstorsjo committed rGb0969be4dfbb: [LLD] [COFF] Try to fix test errors from 7f0e6c31c255303 on windows (authored by mstorsjo).
[LLD] [COFF] Try to fix test errors from 7f0e6c31c255303 on windows
Thu, May 14, 4:15 AM
mstorsjo created D79934: [RFC] [LLD] [COFF] Support options for enabling/disabling autoimport and pseudo relocs in .drectve sections.
Thu, May 14, 3:42 AM · Restricted Project
mstorsjo committed rG7f0e6c31c255: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs (authored by mstorsjo).
[LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs
Thu, May 14, 3:10 AM
mstorsjo closed D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.
Thu, May 14, 3:10 AM · Restricted Project
mstorsjo added a comment to D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names.

Ping @t.p.northover

Thu, May 14, 1:01 AM · Restricted Project

Wed, May 13

mstorsjo added a comment to D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.

Ping @rnk, can you have another look?

Wed, May 13, 11:57 AM · Restricted Project
mstorsjo accepted D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI.

LGTM

Wed, May 13, 10:50 AM · Restricted Project, Restricted Project
mstorsjo committed rGf8972662bc3b: [examples] Skip building the Bye pass plugin on windows (authored by mstorsjo).
[examples] Skip building the Bye pass plugin on windows
Wed, May 13, 3:44 AM
mstorsjo closed D79771: [examples] Skip building the Bye pass plugin on windows.
Wed, May 13, 3:44 AM · Restricted Project

Tue, May 12

mstorsjo added a comment to D79771: [examples] Skip building the Bye pass plugin on windows.

Windows doesn't properly support pass plugins (as a shared library can't have undefined references, which pass plugins assume, being loaded into a host process that contains provides them)

This sounds like a problem with the plugin design. Is this patch intended as a temporary workaround until the inherent layering problem is resolved?

Tue, May 12, 10:11 AM · Restricted Project
mstorsjo created D79771: [examples] Skip building the Bye pass plugin on windows.
Tue, May 12, 2:07 AM · Restricted Project

Mon, May 11

mstorsjo committed rG1f707cc99081: Partially revert "[CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw" (authored by mstorsjo).
Partially revert "[CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw"
Mon, May 11, 10:39 PM
mstorsjo committed rG609ef948387b: [CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw (authored by mstorsjo).
[CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw
Mon, May 11, 2:03 PM
mstorsjo added a comment to D73840: [CMake] Add missing component dependencies, to fix building for mingw with BUILD_SHARED_LIBS.

@mstorsjo Ever since this commit there's an issue on some buildbots: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62031

Any ideas?

Mon, May 11, 2:01 PM · Restricted Project

Sun, May 10

mstorsjo accepted D79694: [tests][Driver] Set `--sysroot=""` to allow `DEFAULT_SYSROOT` build.

LGTM

Sun, May 10, 11:00 PM · Restricted Project
mstorsjo committed rGed0a57f753a3: [LLD] [COFF] Fix def file exporting of symbols containing periods (authored by mstorsjo).
[LLD] [COFF] Fix def file exporting of symbols containing periods
Sun, May 10, 1:50 PM
mstorsjo closed D79619: [LLD] [COFF] Fix def file exporting of symbols containing periods.
Sun, May 10, 1:50 PM · Restricted Project

Sat, May 9

mstorsjo requested review of D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.

@rnk - can you have another look? I changed it a bit more than just touch-ups since the first review.

Sat, May 9, 9:33 AM · Restricted Project

Fri, May 8

mstorsjo created D79619: [LLD] [COFF] Fix def file exporting of symbols containing periods.
Fri, May 8, 1:34 AM · Restricted Project

Thu, May 7

mstorsjo updated the diff for D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.

Split out the support for these options in .drectve to a later patch, to get that discussed separately/explicitly.

Thu, May 7, 3:54 AM · Restricted Project

Wed, May 6

mstorsjo added a comment to D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.
In D78923#2021685, @rnk wrote:

lgtm

Wed, May 6, 2:09 PM · Restricted Project
mstorsjo added inline comments to D76997: Fix StringRef::strLen in windows with clang++ C++17.
Wed, May 6, 12:25 PM · Restricted Project

Tue, May 5

mstorsjo committed rG5a1c30177faa: [LLD] [COFF] Fix a typo in an assert message. NFC. (authored by mstorsjo).
[LLD] [COFF] Fix a typo in an assert message. NFC.
Tue, May 5, 2:06 AM

Wed, Apr 29

mstorsjo created D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names.
Wed, Apr 29, 12:54 PM · Restricted Project
mstorsjo committed rG613d86637434: [lldb] Remove a redundant semicolon, fixing GCC warnings. NFC. (authored by mstorsjo).
[lldb] Remove a redundant semicolon, fixing GCC warnings. NFC.
Wed, Apr 29, 11:17 AM
mstorsjo committed rGa0e53de472c5: [clang] [MinGW] Add the compiler rt libdirs to the search path (authored by mstorsjo).
[clang] [MinGW] Add the compiler rt libdirs to the search path
Wed, Apr 29, 11:17 AM
mstorsjo committed rG239fcda22dee: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas (authored by mstorsjo).
[llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas
Wed, Apr 29, 11:17 AM
mstorsjo committed rG23e35f7c8854: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads (authored by mstorsjo).
[llvm-objcopy] [COFF] Fix a misconception about debug directory payloads
Wed, Apr 29, 11:17 AM
mstorsjo closed D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path.
Wed, Apr 29, 11:16 AM · Restricted Project
mstorsjo closed D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads.
Wed, Apr 29, 11:16 AM · Restricted Project
mstorsjo closed D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas.
Wed, Apr 29, 11:16 AM · Restricted Project
mstorsjo created D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path.
Wed, Apr 29, 2:39 AM · Restricted Project
mstorsjo added inline comments to D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas.
Wed, Apr 29, 1:34 AM · Restricted Project
mstorsjo added inline comments to D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads.
Wed, Apr 29, 1:34 AM · Restricted Project
mstorsjo updated the diff for D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads.

Added comments to the testcases, changed -R into --remove-section in the tests, changed the variable name Rva into RVA.

Wed, Apr 29, 1:02 AM · Restricted Project
mstorsjo added inline comments to D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads.
Wed, Apr 29, 1:02 AM · Restricted Project

Tue, Apr 28

mstorsjo added inline comments to D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads.
Tue, Apr 28, 2:34 PM · Restricted Project
mstorsjo updated the diff for D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas.

Added a comment to the test file.

Tue, Apr 28, 3:43 AM · Restricted Project
mstorsjo added a comment to D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas.

What happens currently without this change? I'm guessing it tries to read something bad?

Tue, Apr 28, 3:43 AM · Restricted Project

Mon, Apr 27

mstorsjo added a comment to D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms..

Ping, @rnk?

Mon, Apr 27, 6:57 AM · Restricted Project
mstorsjo added inline comments to D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.
Mon, Apr 27, 6:25 AM · Restricted Project
mstorsjo created D78923: [LLD] [COFF] Add options for disabling auto import and runtime pseudo relocs.
Mon, Apr 27, 6:25 AM · Restricted Project
mstorsjo created D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads.
Mon, Apr 27, 6:25 AM · Restricted Project
mstorsjo created D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas.
Mon, Apr 27, 5:52 AM · Restricted Project

Apr 25 2020

mstorsjo committed rG6fb80d9383e4: libclang: Add static build support for Windows (authored by cristian.adam).
libclang: Add static build support for Windows
Apr 25 2020, 10:37 AM
mstorsjo closed D75068: libclang: Add static build support for Windows .
Apr 25 2020, 10:36 AM · Restricted Project

Apr 24 2020

mstorsjo added a comment to D78157: [AArch64InstrInfo] Ignore debug insts in areCFlagsAccessedBetweenInstrs [6/10].

This caused a misoptimization for me. With https://martin.st/temp/scene_sad-preproc.c as reproducible source for the issue, I have the following case:

Apr 24 2020, 2:06 AM · Restricted Project

Apr 21 2020

mstorsjo added a reviewer for D75068: libclang: Add static build support for Windows : rnk.
Apr 21 2020, 9:41 AM · Restricted Project

Apr 20 2020

mstorsjo added a reviewer for D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.: rnk.
Apr 20 2020, 12:27 PM · Restricted Project

Apr 19 2020

mstorsjo added a comment to D77387: [ARM] Fix conditions for lowering to S[LR]I.

Filed it as a bug at https://bugs.llvm.org/show_bug.cgi?id=45610 as well.

Apr 19 2020, 11:45 AM · Restricted Project
mstorsjo added a comment to D77387: [ARM] Fix conditions for lowering to S[LR]I.

This seems to cause misoptimizations for me:

Apr 19 2020, 11:45 AM · Restricted Project

Apr 16 2020

mstorsjo added a comment to D66443: [LifetimeAnalysis] Add [[gsl::Pointer]] to llvm::StringRef.

This revision leads a pervasive warning from StringRef.h (on the release build with Clang/Clang++ 9.0.1):

llvm/include/llvm/ADT/StringRef.h:57:11: warning: unknown attribute 'Pointer' ignored [-Wunknown-attributes]
Apr 16 2020, 1:33 AM · Restricted Project
mstorsjo added a comment to D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them..

This triggers failed asserts:

$ cat dcpdecrypt.cpp
extern "C" __inline__ __attribute__((__gnu_inline__)) void *
memcpy(void *, const void *, unsigned) {}
void *memcpy(void *, const void *, unsigned);
void a() { memcpy; }
$ clang++ -c dcpdecrypt.cpp -target i686-linux-gnu
clang++: ../tools/clang/lib/AST/Decl.cpp:3436: bool clang::FunctionDecl::isInlineDefinitionExternallyVisible() const: Assertion `(doesThisDeclarationHaveABody() || willHaveBody() || hasAttr<AliasAttr>()) && "Must be
a function definition"' failed.
Apr 16 2020, 1:33 AM · Restricted Project

Apr 14 2020

mstorsjo added inline comments to D78110: [LLVM/tools][test] - Remove/fix dead check prefixes..
Apr 14 2020, 8:33 AM · Restricted Project

Apr 13 2020

mstorsjo updated subscribers of D77796: [LLD] [COFF] Fix alignment of thunks for ARM/ARM64.

@tstellar - I think this one would be good for a backport to 10.0.1 - is it enough to tag you here, or do you want me to open a bug for backporting it?

Apr 13 2020, 2:07 PM · Restricted Project
mstorsjo committed rG12c9e2f1110a: [LLD] [COFF] Fix alignment of thunks for ARM/ARM64 (authored by mstorsjo).
[LLD] [COFF] Fix alignment of thunks for ARM/ARM64
Apr 13 2020, 1:38 PM
mstorsjo closed D77796: [LLD] [COFF] Fix alignment of thunks for ARM/ARM64.
Apr 13 2020, 1:38 PM · Restricted Project
mstorsjo added a comment to D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers.

Ping - any update on this one? Are you waiting on @rsmith for input on where to place a testcase?

Apr 13 2020, 12:59 PM · Restricted Project
mstorsjo added a comment to D77796: [LLD] [COFF] Fix alignment of thunks for ARM/ARM64.
In D77796#1972959, @rnk wrote:

I seem to recall we had some logic for boosting the alignment of known executable sections. Is it appropriate to reuse that for these thunks? It seems like each ISA has its own minimum code alignment.

Hmm, I don't think I remember seeing that - do you remember more in detail where that would be?

Apr 13 2020, 11:52 AM · Restricted Project
mstorsjo accepted D77733: [libunwind] Enable the new libc++ testing format by default.

LGTM

Apr 13 2020, 10:12 AM · Restricted Project, Restricted Project

Apr 9 2020

mstorsjo accepted D77359: [libunwind] add hexagon support.

Looks good to me now

Apr 9 2020, 10:17 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D77359: [libunwind] add hexagon support.
Apr 9 2020, 3:16 PM · Restricted Project, Restricted Project
mstorsjo accepted D77829: [libunwind] Clean up __arm64__.

LGTM

Apr 9 2020, 3:16 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D77796: [LLD] [COFF] Fix alignment of thunks for ARM/ARM64.
In D77796#1972959, @rnk wrote:

I seem to recall we had some logic for boosting the alignment of known executable sections. Is it appropriate to reuse that for these thunks? It seems like each ISA has its own minimum code alignment.

Apr 9 2020, 2:43 PM · Restricted Project
mstorsjo created D77796: [LLD] [COFF] Fix alignment of thunks for ARM/ARM64.
Apr 9 2020, 6:28 AM · Restricted Project
mstorsjo added inline comments to D77359: [libunwind] add hexagon support.
Apr 9 2020, 4:18 AM · Restricted Project, Restricted Project

Apr 7 2020

mstorsjo accepted D77679: [libunwind] Fix UB in EHHeaderParser::findFDE.

LGTM

Apr 7 2020, 2:43 PM · Restricted Project, Restricted Project

Apr 6 2020

mstorsjo accepted D77501: [libunwind] Support the new libc++ test format.

SGTM

Apr 6 2020, 1:04 PM · Restricted Project, Restricted Project

Apr 5 2020

mstorsjo added inline comments to D77359: [libunwind] add hexagon support.
Apr 5 2020, 3:30 PM · Restricted Project, Restricted Project

Apr 2 2020

Herald added a project to D77099: Exit unwinding early when at the top of the stack and additional info won't be found.: Restricted Project.

Is @mstorsjo, @phosek and @compnerd a suitable set of members? I'll coordinate with @benhamilton to create it (he's the Phabricator magician).

Apr 2 2020, 11:22 AM · Restricted Project, Restricted Project

Apr 1 2020

mstorsjo committed rGaa786b881fc8: [lldb] [PECOFF] Only use PECallFrameInfo on the one supported architecture (authored by mstorsjo).
[lldb] [PECOFF] Only use PECallFrameInfo on the one supported architecture
Apr 1 2020, 2:45 AM
mstorsjo closed D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.
Apr 1 2020, 2:44 AM · Restricted Project

Mar 31 2020

mstorsjo added a comment to D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

@labath @aleksandr.urakov Does this version look good to you?

Mar 31 2020, 4:23 AM · Restricted Project
mstorsjo added reviewers for D77099: Exit unwinding early when at the top of the stack and additional info won't be found.: ldionne, EricWF.

+1 the change looks sensible to me - but I'd leave it to someone else of the runtime projects' maintainers (@mclow.lists @ldionne @EricWF) to approve.

Mar 31 2020, 2:10 AM · Restricted Project, Restricted Project

Mar 30 2020

mstorsjo updated the diff for D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

Moved the check up to ObjectFilePECOFF.

Mar 30 2020, 4:17 AM · Restricted Project
mstorsjo added a comment to D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture.

Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one?

Mar 30 2020, 4:17 AM · Restricted Project