Page MenuHomePhabricator
Feed Advanced Search

Today

mstorsjo added a comment to D59727: [libc++] Fix return value of snprintf_l() on Windows when buffer is too small.

FWIW, this will break mingw builds that use the old msvcrt.dll. Since a couple years, mingw-w64 also supports the UCRT, but this is not the default configuration upstream yet (while it is in my own builds).

Tue, Mar 26, 12:11 AM

Yesterday

mstorsjo added a comment to D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size.
In D59797#1442365, @rnk wrote:

I used the VS memory profiling tool and used the type view to see the most commonly allocated types. "void" just means allocations whose type wasn't determined, and a lot of it comes from vectors, specifically the new RelocTargets vector @mstorsjo added.

Mon, Mar 25, 3:00 PM · Restricted Project, Restricted Project

Sun, Mar 24

mstorsjo added reviewers for D59694: [PPC64][libunwind] Fix r2 not properly restored: EricWF, mclow.lists, ldionne.
Sun, Mar 24, 4:32 AM · Restricted Project

Sat, Mar 23

mstorsjo created D59742: [llvm-dlltool] Set a proper machine type for weak symbol object files.
Sat, Mar 23, 1:45 PM · Restricted Project

Wed, Mar 20

mstorsjo added a comment to D59619: Allow disabling of filesystem library..

Looks sensible to me, modulo the option description.

Wed, Mar 20, 3:33 PM · Restricted Project
mstorsjo added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

This commit also broke compilation of some files for me, for ARM, where compilation now doesn't finish (files that normally compile within a second now doesn't finish after half an hour. See https://bugs.llvm.org/show_bug.cgi?id=41160 for details and a reproduction sample.

Wed, Mar 20, 1:24 PM · Restricted Project

Tue, Mar 19

mstorsjo added a comment to D59530: [LLD][COFF] Fix /linkrepro with options that take a filename or path.

Aren't all of /implib, /pdband /out output files? In that sense it doesn't matter where they are written in the repro case (and writing them locally instead of somewhere else with an absolute path probably is more convenient?).

Yes, however our build system generates cmd-lines with full or relative paths for these options, which makes the response unusable, unless you edit it (because the paths aren't there on the reproducer's machine)

Are you suggesting that we strip those options from their path, and only kept the filename? That would be a good alternative.

Tue, Mar 19, 6:07 AM · Restricted Project
mstorsjo added a comment to D59530: [LLD][COFF] Fix /linkrepro with options that take a filename or path.

Aren't all of /implib, /pdband /out output files? In that sense it doesn't matter where they are written in the repro case (and writing them locally instead of somewhere else with an absolute path probably is more convenient?).

Tue, Mar 19, 5:54 AM · Restricted Project
mstorsjo added a reviewer for D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header . : rnk.
Tue, Mar 19, 12:31 AM · Restricted Project

Fri, Mar 15

mstorsjo accepted D59410: [ARM] Remove EarlyCSE from backend.

Sounds ok to me

Fri, Mar 15, 6:07 AM · Restricted Project
mstorsjo added a comment to D59257: [ARM] Run ARMParallelDSP in the IRPasses phase.

This broke compilation of libcxx for armv7 mingw for me, see https://bugs.llvm.org/show_bug.cgi?id=41081 for details.

Fri, Mar 15, 3:22 AM · Restricted Project

Tue, Mar 12

mstorsjo added a comment to D59273: [compiler-rt] Windows: fix crt_initializer.cc test uses wrong pragma to declare crt initializer..

No objection from the mingw perspective. Sanitizers on mingw are only supported by clang+lld, not by gcc/ld.bfd, and then it's built by clang in mingw mode with -fms-extensions, so most msvc specific extensions are available. Additionally, I haven't even yet a full setup for running compiler-rt/libcxx runtime tests, so I'm not sure if there are other things that need to be fixed wrt mingw in the tests.

Tue, Mar 12, 2:41 PM · Restricted Project, Restricted Project

Wed, Mar 6

mstorsjo added inline comments to D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects.
Wed, Mar 6, 2:02 PM · Restricted Project
mstorsjo added a comment to D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects.

Well, link.exe seems to get "confused" it doesn't print any error messages and produce a very big file that is not really an executable. Without any messages or symbols for it its a bit difficult to see what is happening. As I mostly did the same as the gnu-link option does, I guess those obj files should have the same problem.

Wed, Mar 6, 1:55 PM · Restricted Project

Tue, Mar 5

mstorsjo committed rG826624f00a8c: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either (authored by mstorsjo).
[sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
Tue, Mar 5, 4:50 AM
mstorsjo committed rL355397: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either.
[sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
Tue, Mar 5, 4:50 AM
mstorsjo committed rCRT355397: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either.
[sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either
Tue, Mar 5, 4:50 AM
mstorsjo closed D58958: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either.
Tue, Mar 5, 4:50 AM · Restricted Project, Restricted Project
mstorsjo created D58958: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either.
Tue, Mar 5, 3:40 AM · Restricted Project, Restricted Project

Fri, Mar 1

mstorsjo committed rGad596c8d8c4f: [CMake] Don't use llvm_replace_compiler_option (authored by mstorsjo).
[CMake] Don't use llvm_replace_compiler_option
Fri, Mar 1, 2:30 PM
mstorsjo committed rG05394af3ffd9: [sanitizers] Don't use Windows Trace Logging on MinGW (authored by mstorsjo).
[sanitizers] Don't use Windows Trace Logging on MinGW
Fri, Mar 1, 2:30 PM
mstorsjo committed rL355237: [CMake] Don't use llvm_replace_compiler_option.
[CMake] Don't use llvm_replace_compiler_option
Fri, Mar 1, 2:30 PM
mstorsjo committed rL355236: [sanitizers] Don't use Windows Trace Logging on MinGW.
[sanitizers] Don't use Windows Trace Logging on MinGW
Fri, Mar 1, 2:30 PM
mstorsjo committed rCRT355237: [CMake] Don't use llvm_replace_compiler_option.
[CMake] Don't use llvm_replace_compiler_option
Fri, Mar 1, 2:30 PM
mstorsjo closed D58767: [compiler-rt] [CMake] Don't use llvm_replace_compiler_option.
Fri, Mar 1, 2:29 PM · Restricted Project, Restricted Project
mstorsjo committed rCRT355236: [sanitizers] Don't use Windows Trace Logging on MinGW.
[sanitizers] Don't use Windows Trace Logging on MinGW
Fri, Mar 1, 2:29 PM
mstorsjo closed D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.
Fri, Mar 1, 2:29 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D58767: [compiler-rt] [CMake] Don't use llvm_replace_compiler_option.

Changed to do the same thing with a regex.

Fri, Mar 1, 1:12 AM · Restricted Project, Restricted Project
mstorsjo updated the diff for D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.

Factorized the condition to a macro. As sanitizer_common.h is inclued only later, I had to move the include of traceloggingprovider.h out from the standard include block into a later conditional.

Fri, Mar 1, 12:37 AM · Restricted Project, Restricted Project
mstorsjo committed rG90641b5581b2: [sanitizers] Explicitly use GetModuleFileNameW with wchar_t (authored by mstorsjo).
[sanitizers] Explicitly use GetModuleFileNameW with wchar_t
Fri, Mar 1, 12:08 AM
mstorsjo committed rCRT355180: [sanitizers] Explicitly use GetModuleFileNameW with wchar_t.
[sanitizers] Explicitly use GetModuleFileNameW with wchar_t
Fri, Mar 1, 12:08 AM
mstorsjo committed rL355180: [sanitizers] Explicitly use GetModuleFileNameW with wchar_t.
[sanitizers] Explicitly use GetModuleFileNameW with wchar_t
Fri, Mar 1, 12:08 AM
mstorsjo closed D58766: [sanitizers] Explicitly use GetModuleFileNameW with wchar_t.
Fri, Mar 1, 12:08 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.

@rnk that suggestion works. I'll start testing mingw along with msvc before I commit in the future.

Fri, Mar 1, 12:08 AM · Restricted Project, Restricted Project

Thu, Feb 28

mstorsjo added a comment to D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.
In D58765#1414310, @rnk wrote:

Should this be factored into some general define in some header (which one?) like SANITIZER_WIN_TRACE or so, to avoid duplicating the condition all over the place?

I just noticed that this breaks clang-cl builds of asan because clang-cl doesn't support some weird pre-processor patterns used by TraceLoggingProvider.h:
https://bugs.llvm.org/show_bug.cgi?id=32021

Thu, Feb 28, 11:55 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D58767: [compiler-rt] [CMake] Don't use llvm_replace_compiler_option.
In D58767#1413871, @rnk wrote:

I'd prefer to keep the same /Zi vs. /Z7 setting in the standalone build. Does the standalone build not have access to the installed LLVM cmake modules?

Thu, Feb 28, 10:41 AM · Restricted Project, Restricted Project
mstorsjo created D58767: [compiler-rt] [CMake] Don't use llvm_replace_compiler_option.
Thu, Feb 28, 2:47 AM · Restricted Project, Restricted Project
mstorsjo created D58766: [sanitizers] Explicitly use GetModuleFileNameW with wchar_t.
Thu, Feb 28, 2:44 AM · Restricted Project, Restricted Project
mstorsjo created D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.
Thu, Feb 28, 2:41 AM · Restricted Project, Restricted Project
mstorsjo updated subscribers of D58651: [NFC][Sanitizer] Pull up GetStackTrace into sanitizer_common.

It turns out that the fix for Windows in rL355052 didn't turn out to help either: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/42624/steps/stage%201%20build/logs/stdio

Thu, Feb 28, 2:18 AM · Restricted Project, Restricted Project

Feb 19 2019

mstorsjo committed rG9705898bf33e: [MinGW] Hook up the --exclude-all-symbols option (authored by mstorsjo).
[MinGW] Hook up the --exclude-all-symbols option
Feb 19 2019, 2:01 PM
mstorsjo committed rG272d8c18e0a3: [COFF] Add -exclude-all-symbols for MinGW (authored by mstorsjo).
[COFF] Add -exclude-all-symbols for MinGW
Feb 19 2019, 2:01 PM
mstorsjo committed rL354387: [MinGW] Hook up the --exclude-all-symbols option.
[MinGW] Hook up the --exclude-all-symbols option
Feb 19 2019, 2:00 PM
mstorsjo committed rLLD354387: [MinGW] Hook up the --exclude-all-symbols option.
[MinGW] Hook up the --exclude-all-symbols option
Feb 19 2019, 2:00 PM
mstorsjo committed rLLD354386: [COFF] Add -exclude-all-symbols for MinGW.
[COFF] Add -exclude-all-symbols for MinGW
Feb 19 2019, 2:00 PM
mstorsjo committed rL354386: [COFF] Add -exclude-all-symbols for MinGW.
[COFF] Add -exclude-all-symbols for MinGW
Feb 19 2019, 2:00 PM
mstorsjo closed D58380: [LLD] [COFF] Add -exclude-all-symbols for MinGW.
Feb 19 2019, 2:00 PM · Restricted Project
mstorsjo accepted D58395: Move MinGW-specific code out of LinkerDriver::link. NFC..

LGTM when rebased on top of D58380.

Feb 19 2019, 11:40 AM · Restricted Project
mstorsjo updated the diff for D58380: [LLD] [COFF] Add -exclude-all-symbols for MinGW.

Changed the condition as requested.

Feb 19 2019, 11:34 AM · Restricted Project
mstorsjo added inline comments to D58380: [LLD] [COFF] Add -exclude-all-symbols for MinGW.
Feb 19 2019, 11:11 AM · Restricted Project
mstorsjo created D58380: [LLD] [COFF] Add -exclude-all-symbols for MinGW.
Feb 19 2019, 1:10 AM · Restricted Project

Feb 15 2019

mstorsjo added a comment to D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers..

This broke compilation with GCC 5.4 on Ubuntu 16.04:

Feb 15 2019, 1:51 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D58283: [X86] Fix LowerAsmOutputForConstraint..

I tested and it seems good, I can build the whole mingw-w64 runtime again with this applied.

Feb 15 2019, 11:36 AM · Restricted Project
mstorsjo added a comment to D57394: [X86] Add clang support for X86 flag output parameters..

This change broke compiling the mingw-w64 runtime, which uses GCC_ASM_FLAG_OUTPUTS to enable newer forms of inline assembly. See PR40737 for details.

Feb 15 2019, 12:45 AM · Restricted Project

Feb 13 2019

mstorsjo added a comment to D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.

Please add a check for this new option in COFF/COFFObjCopy.cpp for the "Option not supported by llvm-objcopy for COFF" error, to avoid giving the illusion that the option is handled with that backend.

Feb 13 2019, 5:46 AM · Restricted Project
mstorsjo committed rGf81f7f3ef691: [test] Tweak driver test from r353917 and r353922 to pass with a nondefault… (authored by mstorsjo).
[test] Tweak driver test from r353917 and r353922 to pass with a nondefault…
Feb 13 2019, 5:14 AM
mstorsjo committed rC353946: [test] Tweak driver test from r353917 and r353922 to pass with a nondefault….
[test] Tweak driver test from r353917 and r353922 to pass with a nondefault…
Feb 13 2019, 5:13 AM
mstorsjo committed rL353946: [test] Tweak driver test from r353917 and r353922 to pass with a nondefault….
[test] Tweak driver test from r353917 and r353922 to pass with a nondefault…
Feb 13 2019, 5:13 AM
mstorsjo added a comment to D58107: [MinGW] Add the profiling library when necessary.

This change breaks building/testing the compiler with CLANG_DEFAULT_LINKER set to lld. Was this intentional? What should people do if they want to use CLANG_DEFAULT_LINKER and run the test suite?

Feb 13 2019, 5:10 AM · Restricted Project, Restricted Project

Feb 12 2019

mstorsjo committed rG84c0db859f94: [test] Fix the test from SVN r353917 when running without lld available (authored by mstorsjo).
[test] Fix the test from SVN r353917 when running without lld available
Feb 12 2019, 11:51 PM
mstorsjo committed rL353922: [test] Fix the test from SVN r353917 when running without lld available.
[test] Fix the test from SVN r353917 when running without lld available
Feb 12 2019, 11:51 PM
mstorsjo committed rC353922: [test] Fix the test from SVN r353917 when running without lld available.
[test] Fix the test from SVN r353917 when running without lld available
Feb 12 2019, 11:51 PM
mstorsjo committed rG7eb4ec2879ed: [profile] Provide lprofGetHostName for all windows environments (authored by mstorsjo).
[profile] Provide lprofGetHostName for all windows environments
Feb 12 2019, 11:27 PM
mstorsjo committed rG73ec0034d067: [MinGW] Add the profiling library when necessary (authored by mstorsjo).
[MinGW] Add the profiling library when necessary
Feb 12 2019, 11:27 PM
mstorsjo committed rC353917: [MinGW] Add the profiling library when necessary.
[MinGW] Add the profiling library when necessary
Feb 12 2019, 11:27 PM
mstorsjo committed rCRT353918: [profile] Provide lprofGetHostName for all windows environments.
[profile] Provide lprofGetHostName for all windows environments
Feb 12 2019, 11:26 PM
mstorsjo committed rL353918: [profile] Provide lprofGetHostName for all windows environments.
[profile] Provide lprofGetHostName for all windows environments
Feb 12 2019, 11:26 PM
mstorsjo closed D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments.
Feb 12 2019, 11:26 PM · Restricted Project, Restricted Project
mstorsjo committed rL353917: [MinGW] Add the profiling library when necessary.
[MinGW] Add the profiling library when necessary
Feb 12 2019, 11:26 PM
mstorsjo closed D58107: [MinGW] Add the profiling library when necessary.
Feb 12 2019, 11:26 PM · Restricted Project, Restricted Project
mstorsjo set the repository for D58107: [MinGW] Add the profiling library when necessary to rC Clang.
Feb 12 2019, 12:48 AM · Restricted Project, Restricted Project
mstorsjo created D58107: [MinGW] Add the profiling library when necessary.
Feb 12 2019, 12:47 AM · Restricted Project, Restricted Project
mstorsjo created D58106: [compiler-rt] [profile] Provide lprofGetHostName for all windows environments.
Feb 12 2019, 12:28 AM · Restricted Project, Restricted Project

Feb 11 2019

mstorsjo added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Feb 11 2019, 2:19 PM · Restricted Project
mstorsjo added a comment to D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).

Thanks, looks good to me now. I'll leave someone else to do the overall approval though.

Feb 11 2019, 6:16 AM · Restricted Project
mstorsjo added inline comments to D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).
Feb 11 2019, 5:00 AM · Restricted Project
mstorsjo added inline comments to D58027: [llvm-objcopy] Add --strip-unneeded-symbol(s).
Feb 11 2019, 3:29 AM · Restricted Project

Feb 8 2019

mstorsjo added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Feb 8 2019, 1:26 AM · Restricted Project

Feb 7 2019

mstorsjo committed rGbb3b372aa118: [clang-cl] support /Oy- on aarch64 (authored by mstorsjo).
[clang-cl] support /Oy- on aarch64
Feb 7 2019, 4:47 AM
mstorsjo committed rL353402: [clang-cl] support /Oy- on aarch64.
[clang-cl] support /Oy- on aarch64
Feb 7 2019, 4:47 AM
mstorsjo committed rC353402: [clang-cl] support /Oy- on aarch64.
[clang-cl] support /Oy- on aarch64
Feb 7 2019, 4:47 AM
mstorsjo closed D57838: [clang-cl] support /Oy- on aarch64.
Feb 7 2019, 4:47 AM · Restricted Project
mstorsjo committed rG829bb6fd5a80: [docs] Update the release notes for the backported feature with thunks for ARM64 (authored by mstorsjo).
[docs] Update the release notes for the backported feature with thunks for ARM64
Feb 7 2019, 3:30 AM
mstorsjo committed rL353397: [docs] Update the release notes for the backported feature with thunks for ARM64.
[docs] Update the release notes for the backported feature with thunks for ARM64
Feb 7 2019, 3:30 AM

Feb 6 2019

mstorsjo accepted D57838: [clang-cl] support /Oy- on aarch64.

LGTM

Feb 6 2019, 11:56 PM · Restricted Project
mstorsjo committed rGdfb2fcd224fd: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option (authored by mstorsjo).
[MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option
Feb 6 2019, 1:06 PM
mstorsjo committed rL353342: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option.
[MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option
Feb 6 2019, 1:05 PM
mstorsjo committed rLLD353342: [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option.
[MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option
Feb 6 2019, 1:05 PM
mstorsjo closed D57808: [LLD] [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option.
Feb 6 2019, 1:05 PM · Restricted Project
mstorsjo added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Feb 6 2019, 12:55 PM · Restricted Project
mstorsjo created D57808: [LLD] [MinGW] Add --insert-timestamp as complement to the --no-insert-timestamp option.
Feb 6 2019, 12:20 AM · Restricted Project
mstorsjo added inline comments to D57625: [TargetLibraryInfo] Update run time support for Windows.
Feb 6 2019, 12:11 AM · Restricted Project

Feb 5 2019

mstorsjo added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.
In D57625#1386061, @rnk wrote:

Do we know when most of these were added? Did the all arrive in more or less the same version? It would be nice to make this conditional on a new enough environment version. That gives users a way to indicate that they are targetting an old CRT if they need to.

Feb 5 2019, 2:28 PM · Restricted Project
mstorsjo added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.

Thanks, this looks much more readable!

Feb 5 2019, 2:23 PM · Restricted Project
mstorsjo accepted D57772: [MC] Don't error on numberless .file directives on MachO.

LGTM

Feb 5 2019, 11:39 AM · Restricted Project
mstorsjo added a comment to D57625: [TargetLibraryInfo] Update run time support for Windows.

(And it also works with mingw which normally uses an ancient msvcrt.)

Indeed, this change only affects Windows proper, as both Cygwin and MinGW were already excluded from this selection of supported math functions.

Feb 5 2019, 4:11 AM · Restricted Project
mstorsjo committed rGccd4e5e01684: [COFF] Avoid O(n^2) accesses into PartialSections (authored by mstorsjo).
[COFF] Avoid O(n^2) accesses into PartialSections
Feb 5 2019, 12:17 AM
mstorsjo committed rG537a718fcbbc: [MinGW] Hook up the --no-insert-timestamp option (authored by mstorsjo).
[MinGW] Hook up the --no-insert-timestamp option
Feb 5 2019, 12:17 AM
mstorsjo committed rLLD353146: [COFF] Avoid O(n^2) accesses into PartialSections.
[COFF] Avoid O(n^2) accesses into PartialSections
Feb 5 2019, 12:16 AM
mstorsjo committed rLLD353145: [MinGW] Hook up the --no-insert-timestamp option.
[MinGW] Hook up the --no-insert-timestamp option
Feb 5 2019, 12:16 AM