Page MenuHomePhabricator
Feed Advanced Search

Fri, Nov 15

rovka committed rG5f0c3bad2f03: Fix TestFormatters.py stepping too far (authored by rovka).
Fix TestFormatters.py stepping too far
Fri, Nov 15, 5:26 AM
rovka closed D70303: Fix TestFormatters.py stepping too far.
Fri, Nov 15, 5:26 AM · Restricted Project
rovka accepted D66871: [SVE] MVT scalable size queries.

I don't see anything else wrong with this. LGTM if you rename the LE predicate.

Fri, Nov 15, 5:16 AM · Restricted Project
rovka updated the diff for D70303: Fix TestFormatters.py stepping too far.

Addressed @labath's comment (test run in progress). Thanks for having a look!

Fri, Nov 15, 4:19 AM · Restricted Project
rovka created D70303: Fix TestFormatters.py stepping too far.
Fri, Nov 15, 3:59 AM · Restricted Project

Thu, Nov 14

rovka committed rGe03a06b348ba: Fix typos in docs. NFC (authored by rovka).
Fix typos in docs. NFC
Thu, Nov 14, 3:26 AM

Wed, Nov 13

rovka added a comment to D66871: [SVE] MVT scalable size queries.

Regarding the change to return const, I'm not convinced that's a good idea (we actually have a clang-tidy check that warns about that). I think it would be better to either name those temporaries or use std::make_tuple instead of std::tie (whichever you prefer).

Wed, Nov 13, 3:47 AM · Restricted Project

Tue, Nov 12

rovka committed rG7f1dcc8952e6: [InstCombine] Skip scalable vectors in combineLoadToOperationType (authored by rovka).
[InstCombine] Skip scalable vectors in combineLoadToOperationType
Tue, Nov 12, 3:29 AM
rovka closed D70075: [InstCombine] Skip scalable vectors in combineLoadToOperationType.
Tue, Nov 12, 3:29 AM · Restricted Project
rovka updated the diff for D70075: [InstCombine] Skip scalable vectors in combineLoadToOperationType.

Update test checks. Also brush it up a bit so it fits better with the rest of the tests in the file.

Tue, Nov 12, 1:33 AM · Restricted Project
rovka added inline comments to D70075: [InstCombine] Skip scalable vectors in combineLoadToOperationType.
Tue, Nov 12, 1:32 AM · Restricted Project

Mon, Nov 11

rovka created D70075: [InstCombine] Skip scalable vectors in combineLoadToOperationType.
Mon, Nov 11, 5:02 AM · Restricted Project

Tue, Nov 5

rovka accepted D69644: [globalisel][docs] Add KnownBits Analysis documentation.

LGTM

Tue, Nov 5, 12:49 AM · Restricted Project

Mon, Nov 4

rovka accepted D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.

The text itself LGTM.

Mon, Nov 4, 1:27 AM · Restricted Project
rovka added inline comments to D69644: [globalisel][docs] Add KnownBits Analysis documentation.
Mon, Nov 4, 1:09 AM · Restricted Project
rovka accepted D69734: [globalisel] Rename G_GEP to G_PTR_ADD.

LGTM.

Mon, Nov 4, 1:09 AM · Restricted Project

Thu, Oct 31

rovka added a comment to D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.

Just a few more typos and stuff.

Thu, Oct 31, 2:58 AM · Restricted Project

Tue, Oct 29

rovka added inline comments to D66871: [SVE] MVT scalable size queries.
Tue, Oct 29, 3:37 AM · Restricted Project
rovka added inline comments to D69545: [globalisel][docs] Rework GMIR documentation and add an early GenericOpcode reference.
Tue, Oct 29, 3:09 AM · Restricted Project
rovka accepted D69457: [globalisel][docs] Rewrite the IRTranslator documentation.

LGTM.

Tue, Oct 29, 2:23 AM · Restricted Project
rovka accepted D69456: [globalisel][docs] Rewrite the pipeline overview.

Thanks, looks great!

Tue, Oct 29, 2:13 AM · Restricted Project

Mon, Oct 28

rovka added inline comments to D69457: [globalisel][docs] Rewrite the IRTranslator documentation.
Mon, Oct 28, 2:30 AM · Restricted Project
rovka added a comment to D69456: [globalisel][docs] Rewrite the pipeline overview.

Thanks for writing this up! I just have a few suggestions and one small bug to point out (I can't figure out how to comment on a png file, so I'll write it here).

Mon, Oct 28, 2:14 AM · Restricted Project

Oct 18 2019

rovka accepted D69064: [ARM] Add dependency on GlobalISel for unit tests to fix shared libs build.

Thanks, LGTM then!

Oct 18 2019, 9:06 AM · Restricted Project

Oct 17 2019

rovka added a comment to D69064: [ARM] Add dependency on GlobalISel for unit tests to fix shared libs build.

Could you be a little more specific? I just ran a build with BUILD_SHARED_LIBS=ON and it seemed to work.

Oct 17 2019, 1:57 AM · Restricted Project

Oct 2 2019

rovka accepted D53137: Scalable vector core instruction support + size queries.

This looks good to me, maybe wait a while to see if anyone else has any further comments.

Oct 2 2019, 3:06 AM · Restricted Project, Restricted Project

Oct 1 2019

rovka committed rGc2c377ea584d: Fixup r373278: Move test to X86 directory (authored by rovka).
Fixup r373278: Move test to X86 directory
Oct 1 2019, 2:27 AM
rovka committed rL373314: Fixup r373278: Move test to X86 directory.
Fixup r373278: Move test to X86 directory
Oct 1 2019, 2:27 AM

Sep 25 2019

rovka accepted D67732: Fix arm build failure with libgcc.

I'm not very familiar with this area, but it seems like a sensible fix.

Sep 25 2019, 1:25 AM · Restricted Project

Sep 24 2019

rovka added a comment to D53137: Scalable vector core instruction support + size queries.

I suspect 'ScalableSize' is the wrong term now; 'TypeSize' may be better. Thoughts?

Sep 24 2019, 2:26 AM · Restricted Project, Restricted Project

Sep 16 2019

rovka added inline comments to D67549: [IntrinsicEmitter] Add overloaded types for SVE intrinsics (Subdivide2 & Subdivide4).
Sep 16 2019, 9:53 AM · Restricted Project
rovka accepted D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers.

I think all the outstanding comments have been addressed. LGTM.

Sep 16 2019, 2:05 AM · Restricted Project

Sep 4 2019

rovka committed rL370867: Request commit access for rovka.
Request commit access for rovka
Sep 4 2019, 3:03 AM

Sep 2 2019

rovka added a comment to D66524: [SVE][Inline-Asm] Add constraints for SVE predicate registers.

Just some drive-by suggestions :)

Sep 2 2019, 2:24 AM · Restricted Project

Aug 30 2019

rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Does anyone like Sander's suggestion to make ScalableSize (or whatever we end up naming it) the return value for all size queries and provide an overloaded cast operator to transparently work with existing code comparing against unsigned values? Or is it preferable to keep the current split?

Aug 30 2019, 1:28 AM · Restricted Project, Restricted Project

Aug 1 2019

rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Several more general comments:

  • Should all the getXSize assert when called on a scalable type? I see that for MVT::getSizeInBits and for Type::getPrimitiveSize, but not for the others. This should also be made clear in the comments for each of them.
  • Great test for the IR, thanks!
  • I don't see any test for the CodeGen stuff though. Is it possible to add one? (If not, maybe add the changes to EVT etc when we can actually test them).
  • Ditto for TableGen (or if that's too difficult/hairy to test, just update the commit message to explain exactly why the change belongs in this patch).
Aug 1 2019, 5:01 AM · Restricted Project, Restricted Project

Jul 31 2019

rovka committed rG7117881fdb2f: [docs] Add cmake to Software requirements (authored by rovka).
[docs] Add cmake to Software requirements
Jul 31 2019, 1:49 AM
rovka committed rL367395: [docs] Add cmake to Software requirements.
[docs] Add cmake to Software requirements
Jul 31 2019, 1:49 AM
rovka closed D65438: [docs] Add cmake to Software requirements.
Jul 31 2019, 1:49 AM · Restricted Project

Jul 30 2019

rovka created D65438: [docs] Add cmake to Software requirements.
Jul 30 2019, 4:49 AM · Restricted Project
rovka added a comment to D65436: [docs] Add note about git version to git-llvm section.

Some people might be interested just in compiling LLVM (e.g. fetching some release sources from releases.llvm.org and building them). We should probably keep the package list here focused on that. If we want to add git at all, we should probably mention it somewhere else. I'm not sure where that would be - I suppose somewhere where it makes sense to worry about the minimum version, e.g. where the git-llvm script is concerned. Do we have any other reason to bind ourselves to a certain minimum version of git?

Jul 30 2019, 4:32 AM · Restricted Project, Restricted Project

Jul 26 2019

rovka accepted D65321: [MIPS GlobalISel] Fix check for void return during lowerCall.

LGTM

Jul 26 2019, 1:09 AM · Restricted Project

Jul 23 2019

rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Hi Diana,

Thanks for the comments.

I think this patch is difficult to review. It covers many different source files with only a small unit test to check the correctness. This isn't very robust against future changes and it makes it hard to know exactly what is and isn't supported.

Yeah, I was worried about that -- this is basically the size queries alone without anything actually using scalable vectors. It demonstrates roughly where changes will be needed, but doesn't actually change the surrounding code to use e.g. getElementCount instead of getNumElements.

I would find it much easier to review with an incremental strategy based on regression tests. For instance, with ToT opt, the attached testcase fails (error: '%r' defined with type '<4 x i1>' but expected '<vscale x 4 x i1>'). I would add a patch to fix that, and maybe other similar, really simple cases. We could then proceed to more complex examples, run some of the passes that come after the vectorizer on them, and progressively fix the places required to make them pass, with focused tests for each hurdle that we run into. It shouldn't be too hard to reduce such snippets from the tests you've already been running.

An incremental approach sounds good; assuming nobody objects, I'll remove most of the code in this patch and just leave the core mechanism behind (in enforcing mode) and add in that test case. We can fill in the other cases as we enable codegen/acle/autovec in separate patches.

Jul 23 2019, 4:21 AM · Restricted Project, Restricted Project
rovka added a comment to D53137: Scalable vector core instruction support + size queries.

Hi Graham,

Jul 23 2019, 2:22 AM · Restricted Project, Restricted Project

Jul 22 2019

rovka added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Jul 22 2019, 3:45 AM · Restricted Project, Restricted Project

Jul 19 2019

rovka added a comment to D62960: Add SVE opaque built-in types.

FWIW, I think the tests look great. Would be nice if someone more experienced with clang could also have a look though.

Jul 19 2019, 2:41 AM · Restricted Project, Restricted Project

Jul 18 2019

rovka added inline comments to D64739: [SVE][Inline-Asm] Add support to specify SVE registers in the clobber list.
Jul 18 2019, 2:51 AM · Restricted Project, Restricted Project
rovka committed rGf26706fa1c15: Fixup r366333 (require x86 in test) (authored by rovka).
Fixup r366333 (require x86 in test)
Jul 18 2019, 1:32 AM
rovka committed rL366416: Fixup r366333 (require x86 in test).
Fixup r366333 (require x86 in test)
Jul 18 2019, 1:32 AM

Jul 17 2019

rovka committed rG37e403d18c1a: [ARM GlobalISel] Cleanup CallLowering. NFC (authored by rovka).
[ARM GlobalISel] Cleanup CallLowering. NFC
Jul 17 2019, 3:06 AM
rovka committed rL366308: [ARM GlobalISel] Cleanup CallLowering. NFC.
[ARM GlobalISel] Cleanup CallLowering. NFC
Jul 17 2019, 3:05 AM

Jul 15 2019

rovka committed rG0bf0b8ff7c7e: [libFuzzer] Disable fork.test on AArch64 (authored by rovka).
[libFuzzer] Disable fork.test on AArch64
Jul 15 2019, 4:35 AM
rovka committed rL366055: [libFuzzer] Disable fork.test on AArch64.
[libFuzzer] Disable fork.test on AArch64
Jul 15 2019, 4:35 AM

Jul 2 2019

rovka added a comment to D62960: Add SVE opaque built-in types.

This looks much better, thanks! Shouldn't there be more tests, e.g. for mangling and maybe the ASTImporter?

Jul 2 2019, 3:23 AM · Restricted Project, Restricted Project

Jul 1 2019

rovka added a comment to D63905: Fix ASAN error caused by commit r364512.

Thanks, committed in r364778!

Jul 1 2019, 8:16 AM · Restricted Project
rovka committed rG2ba16011c139: Fixup r364512 (authored by rovka).
Fixup r364512
Jul 1 2019, 8:10 AM
rovka committed rL364778: Fixup r364512.
Fixup r364512
Jul 1 2019, 8:08 AM

Jun 28 2019

rovka added a comment to D63905: Fix ASAN error caused by commit r364512.

Looks good to me, please commit

(@rovka - this is at least a short-term fix, I'm approving this to unbreak LLVM's mainline - feel free to refix with other ideas if you have any (also happy to discuss this further with you here, IRC, or elsewhere on the mailing lists)

Jun 28 2019, 3:08 AM · Restricted Project

Jun 27 2019

rovka added a comment to D62960: Add SVE opaque built-in types.

Just a few nits/suggestions.

Jun 27 2019, 4:59 AM · Restricted Project, Restricted Project
rovka committed rG74a50a723bfd: [GlobalISel] Remove [un]packRegs from IRTranslator (authored by rovka).
[GlobalISel] Remove [un]packRegs from IRTranslator
Jun 27 2019, 2:50 AM
rovka committed rL364514: [GlobalISel] Remove [un]packRegs from IRTranslator.
[GlobalISel] Remove [un]packRegs from IRTranslator
Jun 27 2019, 2:49 AM
rovka committed rG253b53b2ecf6: [AArch64 GlobalISel] Cleanup CallLowering. NFCI (authored by rovka).
[AArch64 GlobalISel] Cleanup CallLowering. NFCI
Jun 27 2019, 2:27 AM
rovka committed rL364513: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
[AArch64 GlobalISel] Cleanup CallLowering. NFCI
Jun 27 2019, 2:26 AM
rovka closed D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
Jun 27 2019, 2:26 AM · Restricted Project
rovka committed rG43fb5ae50c53: [GlobalISel] Accept multiple vregs for lowerCall's args (authored by rovka).
[GlobalISel] Accept multiple vregs for lowerCall's args
Jun 27 2019, 2:21 AM
rovka committed rL364512: [GlobalISel] Accept multiple vregs for lowerCall's args.
[GlobalISel] Accept multiple vregs for lowerCall's args
Jun 27 2019, 2:21 AM
rovka committed rG8138996128cd: [GlobalISel] Accept multiple vregs for lowerCall's result (authored by rovka).
[GlobalISel] Accept multiple vregs for lowerCall's result
Jun 27 2019, 2:21 AM
rovka committed rL364511: [GlobalISel] Accept multiple vregs for lowerCall's result.
[GlobalISel] Accept multiple vregs for lowerCall's result
Jun 27 2019, 2:21 AM
rovka closed D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 27 2019, 2:21 AM · Restricted Project
rovka closed D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 27 2019, 2:21 AM · Restricted Project
rovka committed rGc3dbe2397792: [GlobalISel] Accept multiple vregs in lowerFormalArgs (authored by rovka).
[GlobalISel] Accept multiple vregs in lowerFormalArgs
Jun 27 2019, 1:55 AM
rovka committed rL364510: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
[GlobalISel] Accept multiple vregs in lowerFormalArgs
Jun 27 2019, 1:55 AM
rovka closed D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 27 2019, 1:54 AM · Restricted Project
rovka committed rG69ce1c131963: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC (authored by rovka).
[GlobalISel] Allow multiple VRegs in ArgInfo. NFC
Jun 27 2019, 1:52 AM
rovka committed rL364509: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
[GlobalISel] Allow multiple VRegs in ArgInfo. NFC
Jun 27 2019, 1:51 AM
rovka closed D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
Jun 27 2019, 1:51 AM · Restricted Project

Jun 25 2019

rovka added a comment to D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

Hi Amara,

Jun 25 2019, 3:43 AM · Restricted Project

Jun 24 2019

rovka added a comment to D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.

Thanks so much for working on these patches Diana! It's tricky business, can you be sure to run test suites thoroughly before committing if you haven't already.

Jun 24 2019, 1:42 AM · Restricted Project
rovka added a comment to D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

LGTM too if we remove the last packRegs use and delete the IRTranslator pack/unpackRegs() implementations.

Jun 24 2019, 1:37 AM · Restricted Project

Jun 20 2019

rovka accepted D63585: [ARM GlobalISel] Add support for s64 G_ADD and G_SUB..

LGTM, thanks!

Jun 20 2019, 3:24 AM · Restricted Project
rovka updated the diff for D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.

More context.

Jun 20 2019, 2:38 AM · Restricted Project
rovka updated the diff for D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.

Thanks for the review! More context for posterity though :)

Jun 20 2019, 2:38 AM · Restricted Project
rovka updated the diff for D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.

More context.

Jun 20 2019, 2:34 AM · Restricted Project
rovka updated the diff for D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.

More context.

Jun 20 2019, 2:33 AM · Restricted Project
rovka updated the diff for D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.

Oops! Fixed :)

Jun 20 2019, 2:33 AM · Restricted Project

Jun 19 2019

rovka retitled D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments from [GlobalISel] Accept multiple vregs for lowerCall's result to [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:06 AM · Restricted Project
rovka added a parent revision for D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs: D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC: D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs: D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a parent revision for D63550: [GlobalISel] Accept multiple vregs for lowerCall's result: D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63550: [GlobalISel] Accept multiple vregs for lowerCall's result: D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a parent revision for D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments: D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a parent revision for D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI: D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:03 AM · Restricted Project
rovka added a child revision for D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments: D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
Jun 19 2019, 7:03 AM · Restricted Project
rovka created D63551: [GlobalISel] Accept multiple vregs for lowerCall's arguments.
Jun 19 2019, 7:01 AM · Restricted Project
rovka created D63552: [AArch64 GlobalISel] Cleanup CallLowering. NFCI.
Jun 19 2019, 7:01 AM · Restricted Project
rovka created D63550: [GlobalISel] Accept multiple vregs for lowerCall's result.
Jun 19 2019, 6:57 AM · Restricted Project
rovka created D63549: [GlobalISel] Accept multiple vregs in lowerFormalArgs.
Jun 19 2019, 6:54 AM · Restricted Project
rovka created D63548: [GlobalISel] Allow multiple VRegs in ArgInfo. NFC.
Jun 19 2019, 6:51 AM · Restricted Project

May 27 2019

rovka committed rGc675215f6799: [ARM GlobalISel] Un-XFAIL some tests. NFC (authored by rovka).
[ARM GlobalISel] Un-XFAIL some tests. NFC
May 27 2019, 3:31 AM