Page MenuHomePhabricator
Feed Advanced Search

Aug 24 2022

fmayer added a reviewer for D132611: [ASan] rename left/right to before/after.: eugenis.
Aug 24 2022, 2:53 PM · Restricted Project, Restricted Project
fmayer added a comment to D132611: [ASan] rename left/right to before/after..

not arguing for or against, but I wonder how many output parsers will break.

Aug 24 2022, 2:49 PM · Restricted Project, Restricted Project
fmayer updated the diff for D132611: [ASan] rename left/right to before/after..

test update

Aug 24 2022, 2:47 PM · Restricted Project, Restricted Project
fmayer requested review of D132611: [ASan] rename left/right to before/after..
Aug 24 2022, 2:45 PM · Restricted Project, Restricted Project

Aug 15 2022

fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 15 2022, 10:07 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D128998: [libunwind] Handle G in personality string.

About __unw_clean_step:

libunwind/src/libunwind_ext.h provides a bunch of API which are not implemented by https://github.com/libunwind/libunwind .
Before we settle on an API there, it's worth raising an issue on https://github.com/libunwind/libunwind and giving them some time for the API design.

Aug 15 2022, 10:06 AM · Restricted Project, Restricted Project, Restricted Project

Aug 5 2022

fmayer added a reviewer for D128998: [libunwind] Handle G in personality string: MaskRay.
Aug 5 2022, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Aug 5 2022, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

address comments

Aug 5 2022, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

add comment

Aug 5 2022, 1:24 PM · Restricted Project, Restricted Project, Restricted Project
fmayer committed rG29ff262761af: [HWASan] Remove incorrect unreachable. (authored by fmayer).
[HWASan] Remove incorrect unreachable.
Aug 5 2022, 1:14 PM · Restricted Project, Restricted Project
fmayer closed D131279: [HWASan] Remove incorrect unreachable..
Aug 5 2022, 1:14 PM · Restricted Project, Restricted Project
fmayer added inline comments to D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions.
Aug 5 2022, 12:44 PM · Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Aug 5 2022, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions.
Aug 5 2022, 12:21 PM · Restricted Project, Restricted Project
fmayer added a comment to D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions.

Hi folks,

I've been working on support hwasan for risc-v and I believe I've found an issue with the existing lit tests this commit causes.
Tests stack-{oob,uar,uas}.c check for correct backtrace being printed. From the code and comments the idea is to not to print any hwasan related frames(see the code and comments below).

void HandleTagMismatch(AccessInfo ai, uptr pc, uptr frame, void *uc,                                
                       uptr *registers_frame) {                                                     
  InternalMmapVector<BufferedStackTrace> stack_buffer(1);                                           
  BufferedStackTrace *stack = stack_buffer.data();                                                  
  stack->Reset();                                                                                   
  stack->Unwind(pc, frame, uc, common_flags()->fast_unwind_on_fatal);                               
                                                                                                    
  // The second stack frame contains the failure __hwasan_check function, as                        
  // we have a stack frame for the registers saved in __hwasan_tag_mismatch that                    
  // we wish to ignore. This (currently) only occurs on AArch64, as x64                      
  // implementations use SIGTRAP to implement the failure, and thus do not go                       
  // through the stack saver.                                                                       
  if (registers_frame && stack->trace && stack->size > 0) {                                         
    stack->trace++;                                                                              
    stack->size--;                                                                               
  }

Before this commit the return address and frame pointer to were taken directly from hwasan_tag_mismatch4, while after the commit those addresses are calculated after another function being called from hwasan_tag_mismatch4 (the HwasanTagMismatch one).
So, if I understand it correctly, now it looks like 2 stack frames must be ignored(for hwasan_tag_mismatch4 and HwasanTagMismatch) to get a proper backtrace.
What do you think?

Thanks

Aug 5 2022, 12:20 PM · Restricted Project, Restricted Project
fmayer published D131279: [HWASan] Remove incorrect unreachable. for review.
Aug 5 2022, 12:18 PM · Restricted Project, Restricted Project

Aug 4 2022

fmayer committed rGfc6a6ee507ec: [libunwind] undef NDEBUG for assert.h in tests. (authored by fmayer).
[libunwind] undef NDEBUG for assert.h in tests.
Aug 4 2022, 7:56 PM · Restricted Project
fmayer closed D131210: [libunwind] undef NDEBUG for assert.h in tests..
Aug 4 2022, 7:55 PM · Restricted Project, Restricted Project, Restricted Project
fmayer published D128998: [libunwind] Handle G in personality string for review.

In addition to the test described in the message, I ran the libunwind test suites on FVP with SANITIZE_TARGET=memtag-stack and they still pass.

Aug 4 2022, 7:32 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D131210: [libunwind] undef NDEBUG for assert.h in tests.: MaskRay.
Aug 4 2022, 3:06 PM · Restricted Project, Restricted Project, Restricted Project
fmayer requested review of D131210: [libunwind] undef NDEBUG for assert.h in tests..
Aug 4 2022, 3:05 PM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

fmayer added a comment to D130956: [X86][MC] Always emit `rep` prefix for `bsf`.

I'll revert, I'll have to do a fixup for a dependent patch that I committed after this.

Aug 3 2022, 2:50 PM · Restricted Project, Restricted Project
fmayer added a comment to D130956: [X86][MC] Always emit `rep` prefix for `bsf`.

This seems related to an error we see on our sanitizer bots: https://lab.llvm.org/buildbot/#/builders/37/builds/15446/steps/33/logs/stdio

Aug 3 2022, 2:39 PM · Restricted Project, Restricted Project

Aug 2 2022

fmayer accepted D131017: Fix use-after-free in clang-apply-replacements.
Aug 2 2022, 1:33 PM · Restricted Project, Restricted Project
fmayer added a comment to D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC.

This CL seems to have an MSAN violation: https://lab.llvm.org/buildbot/#/builders/74/builds/12529/steps/11/logs/stdio

Aug 2 2022, 1:23 PM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2022

fmayer added a comment to rG9028966a7172: [clang] Don't create executable in test.
Aug 1 2022, 5:22 PM · Restricted Project, Restricted Project
fmayer added a comment to rG9028966a7172: [clang] Don't create executable in test.

This broke the sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/168/builds/7879/steps/11/logs/stdio

Aug 1 2022, 4:59 PM · Restricted Project, Restricted Project

Jul 29 2022

fmayer added a comment to D130718: [compiler-rt] [builtins] Detect _Float16 support at compile time.

I think this broke the sanitizer-windows buildbot: https://lab.llvm.org/buildbot/#/builders/127/builds/33583/steps/4/logs/stdio

Jul 29 2022, 5:23 PM · Restricted Project, Restricted Project

Jul 1 2022

fmayer accepted D128873: [NFC][sanitizer] Minor change: eliminate loop.

Looks good! Please add "[NFC]" to the commit message to indicate this change is non-functional.

Jul 1 2022, 9:07 AM · Restricted Project, Restricted Project
fmayer added inline comments to D128958: Add assembler plumbing for sanitize_memtag.
Jul 1 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

fmayer updated subscribers of D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC.
Jun 27 2022, 2:52 PM · Restricted Project, Restricted Project

Jun 24 2022

fmayer added a comment to D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC.

FWIW this is not really NFC, I found this as the culprit in bisecting the Android LLVM toolchain build, causing the following error:

Jun 24 2022, 4:23 PM · Restricted Project, Restricted Project

Jun 22 2022

fmayer committed rG9320a32bb91b: [MTE] [HWASan] Use LoopInfo for reachability queries. (authored by fmayer).
[MTE] [HWASan] Use LoopInfo for reachability queries.
Jun 22 2022, 3:29 PM · Restricted Project, Restricted Project
fmayer closed D127917: [MTE] [HWASan] Use LoopInfo for reachability queries..
Jun 22 2022, 3:28 PM · Restricted Project, Restricted Project
fmayer added a comment to D127917: [MTE] [HWASan] Use LoopInfo for reachability queries..

Could you add a test?

Jun 22 2022, 2:10 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127917: [MTE] [HWASan] Use LoopInfo for reachability queries..

add test

Jun 22 2022, 2:10 PM · Restricted Project, Restricted Project
fmayer committed rG476ced4b8959: [MTE] [HWASan] Support diamond lifetimes. (authored by fmayer).
[MTE] [HWASan] Support diamond lifetimes.
Jun 22 2022, 11:17 AM · Restricted Project, Restricted Project
fmayer closed D127905: [MTE] [HWASan] Support diamond lifetimes..
Jun 22 2022, 11:16 AM · Restricted Project, Restricted Project
fmayer committed rGacc9721e3866: [NFC] [HWASan] Remove indirection for getting analyses. (authored by fmayer).
[NFC] [HWASan] Remove indirection for getting analyses.
Jun 22 2022, 10:53 AM · Restricted Project, Restricted Project
fmayer closed D127913: [NFC] [HWASan] Remove indirection for getting analyses..
Jun 22 2022, 10:53 AM · Restricted Project, Restricted Project

Jun 21 2022

fmayer added a comment to D127913: [NFC] [HWASan] Remove indirection for getting analyses..

Mostly LG. Just curious if the analysis results would be invalidated between GetDT/GetPDT calls (in the original code)?

Jun 21 2022, 2:32 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127913: [NFC] [HWASan] Remove indirection for getting analyses..

address comments.

Jun 21 2022, 2:13 PM · Restricted Project, Restricted Project
fmayer added a comment to D127913: [NFC] [HWASan] Remove indirection for getting analyses..

Gentle ping.

Jun 21 2022, 11:48 AM · Restricted Project, Restricted Project

Jun 15 2022

fmayer added a reviewer for D127917: [MTE] [HWASan] Use LoopInfo for reachability queries.: eugenis.
Jun 15 2022, 4:32 PM · Restricted Project, Restricted Project
fmayer requested review of D127917: [MTE] [HWASan] Use LoopInfo for reachability queries..
Jun 15 2022, 4:32 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D127913: [NFC] [HWASan] Remove indirection for getting analyses.: eugenis.
Jun 15 2022, 3:58 PM · Restricted Project, Restricted Project
fmayer requested review of D127913: [NFC] [HWASan] Remove indirection for getting analyses..
Jun 15 2022, 3:57 PM · Restricted Project, Restricted Project
fmayer published D127905: [MTE] [HWASan] Support diamond lifetimes. for review.
Jun 15 2022, 3:37 PM · Restricted Project, Restricted Project

Jun 9 2022

fmayer added inline comments to D127257: [libcxx] improve LIBCXX_ABI_NAMESPACE error message.
Jun 9 2022, 8:50 AM · Restricted Project, Restricted Project
fmayer committed rG4110c2c657b3: [NFC] change error message wording. (authored by fmayer).
[NFC] change error message wording.
Jun 9 2022, 8:49 AM · Restricted Project, Restricted Project
fmayer committed rGd7e438c016e5: [libcxx] improve LIBCXX_ABI_NAMESPACE error message (authored by fmayer).
[libcxx] improve LIBCXX_ABI_NAMESPACE error message
Jun 9 2022, 8:48 AM · Restricted Project, Restricted Project
fmayer closed D127257: [libcxx] improve LIBCXX_ABI_NAMESPACE error message.
Jun 9 2022, 8:48 AM · Restricted Project, Restricted Project

Jun 8 2022

fmayer committed rGf6b1bfb7d5cc: [ELF] Support 'G' in .eh_frame (authored by fmayer).
[ELF] Support 'G' in .eh_frame
Jun 8 2022, 2:29 PM · Restricted Project
fmayer closed D127148: [ELF] Support 'G' in .eh_frame.
Jun 8 2022, 2:29 PM · Restricted Project, Restricted Project
fmayer committed rGa2695c3fe1b7: [DWARF] Support 'G' in dwarf parser (authored by fmayer).
[DWARF] Support 'G' in dwarf parser
Jun 8 2022, 2:28 PM · Restricted Project, Restricted Project
fmayer closed D127171: [DWARF] Support 'G' in dwarf parser.
Jun 8 2022, 2:28 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

add requires aarch64

Jun 8 2022, 2:25 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127171: [DWARF] Support 'G' in dwarf parser.

require aarch64-registered-target

Jun 8 2022, 2:21 PM · Restricted Project, Restricted Project
fmayer reopened D127171: [DWARF] Support 'G' in dwarf parser.

Tests broke on windows.

Jun 8 2022, 1:53 PM · Restricted Project, Restricted Project
fmayer added a reverting change for rG4c71c3386c5c: [DWARF] Support 'G' in dwarf parser: rG0d54a874ee24: Revert "[DWARF] Support 'G' in dwarf parser".
Jun 8 2022, 1:53 PM · Restricted Project, Restricted Project
fmayer committed rG0d54a874ee24: Revert "[DWARF] Support 'G' in dwarf parser" (authored by fmayer).
Revert "[DWARF] Support 'G' in dwarf parser"
Jun 8 2022, 1:53 PM · Restricted Project, Restricted Project
fmayer reopened D127148: [ELF] Support 'G' in .eh_frame.

Tests broke on windows.

Jun 8 2022, 1:53 PM · Restricted Project, Restricted Project
fmayer added a reverting change for rG40f34fe4a87d: [ELF] Support 'G' in .eh_frame: rG6fb4fe728590: Revert "[ELF] Support 'G' in .eh_frame".
Jun 8 2022, 1:53 PM · Restricted Project
fmayer committed rG6fb4fe728590: Revert "[ELF] Support 'G' in .eh_frame" (authored by fmayer).
Revert "[ELF] Support 'G' in .eh_frame"
Jun 8 2022, 1:53 PM · Restricted Project
fmayer added a reverting change for D127171: [DWARF] Support 'G' in dwarf parser: rG0d54a874ee24: Revert "[DWARF] Support 'G' in dwarf parser".
Jun 8 2022, 1:53 PM · Restricted Project, Restricted Project
fmayer added a reverting change for D127148: [ELF] Support 'G' in .eh_frame: rG6fb4fe728590: Revert "[ELF] Support 'G' in .eh_frame".
Jun 8 2022, 1:53 PM · Restricted Project, Restricted Project
fmayer committed rG40f34fe4a87d: [ELF] Support 'G' in .eh_frame (authored by fmayer).
[ELF] Support 'G' in .eh_frame
Jun 8 2022, 1:40 PM · Restricted Project
fmayer closed D127148: [ELF] Support 'G' in .eh_frame.
Jun 8 2022, 1:40 PM · Restricted Project, Restricted Project
fmayer committed rG4c71c3386c5c: [DWARF] Support 'G' in dwarf parser (authored by fmayer).
[DWARF] Support 'G' in dwarf parser
Jun 8 2022, 12:40 PM · Restricted Project, Restricted Project
fmayer closed D127171: [DWARF] Support 'G' in dwarf parser.
Jun 8 2022, 12:39 PM · Restricted Project, Restricted Project
fmayer committed rG0593ce5f0bbb: [MC] Add 'G' to augmentation string for MTE instrumented functions (authored by fmayer).
[MC] Add 'G' to augmentation string for MTE instrumented functions
Jun 8 2022, 12:37 PM · Restricted Project, Restricted Project
fmayer closed D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.
Jun 8 2022, 12:36 PM · Restricted Project, Restricted Project
fmayer accepted D127327: [MSAN] Add comment regarding why pthread_getaffinity_np is not supported on Android..
Jun 8 2022, 11:31 AM · Restricted Project, Restricted Project

Jun 7 2022

fmayer updated the diff for D127257: [libcxx] improve LIBCXX_ABI_NAMESPACE error message.

Consistency

Jun 7 2022, 3:34 PM · Restricted Project, Restricted Project
fmayer requested review of D127257: [libcxx] improve LIBCXX_ABI_NAMESPACE error message.
Jun 7 2022, 3:26 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

remove comments

Jun 7 2022, 1:58 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127171: [DWARF] Support 'G' in dwarf parser.

address comment

Jun 7 2022, 1:57 PM · Restricted Project, Restricted Project
fmayer updated subscribers of D127171: [DWARF] Support 'G' in dwarf parser.
Jun 7 2022, 1:37 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

address comment

Jun 7 2022, 1:26 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

rebase

Jun 7 2022, 1:26 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127171: [DWARF] Support 'G' in dwarf parser.

test

Jun 7 2022, 1:24 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

address comments

Jun 7 2022, 1:21 PM · Restricted Project, Restricted Project
fmayer added inline comments to D127171: [DWARF] Support 'G' in dwarf parser.
Jun 7 2022, 1:20 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127171: [DWARF] Support 'G' in dwarf parser.

address comments

Jun 7 2022, 1:18 PM · Restricted Project, Restricted Project
fmayer added inline comments to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.
Jun 7 2022, 1:11 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

add another test

Jun 7 2022, 1:11 PM · Restricted Project, Restricted Project

Jun 6 2022

fmayer added a reviewer for D127171: [DWARF] Support 'G' in dwarf parser: MaskRay.
Jun 6 2022, 6:07 PM · Restricted Project, Restricted Project
fmayer added a comment to D127148: [ELF] Support 'G' in .eh_frame.

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code can be tested with llvm-objdump/llvm-dwarfdump but should have a test in test/DebugInfo.

lld doesn't use llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp code. It's inappropriate to rely on lld/test/ELF to provide the test coverage.

You should move llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp into another patch with a test/DebugInfo patch.

Jun 6 2022, 6:06 PM · Restricted Project, Restricted Project
fmayer retitled D127148: [ELF] Support 'G' in .eh_frame from [ELF] Support 'G' in lld and dwarf parser to [ELF] Support 'G' in lld.
Jun 6 2022, 6:04 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

remove dwarf test

Jun 6 2022, 6:04 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

remove DWARF parser

Jun 6 2022, 6:03 PM · Restricted Project, Restricted Project
fmayer abandoned D127172: [ELF] Support 'G' in lld.

Accidentally duplicated this.

Jun 6 2022, 6:03 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127172: [ELF] Support 'G' in lld.

test no REQUIRES

Jun 6 2022, 6:01 PM · Restricted Project, Restricted Project
fmayer requested review of D127172: [ELF] Support 'G' in lld.
Jun 6 2022, 6:01 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127171: [DWARF] Support 'G' in dwarf parser.

test

Jun 6 2022, 5:59 PM · Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

It may be better to move the DebugInfo change from the lld patch into this patch.

Jun 6 2022, 5:58 PM · Restricted Project, Restricted Project