Page MenuHomePhabricator
Feed Advanced Search

Jun 6 2022

fmayer requested review of D127171: [DWARF] Support 'G' in dwarf parser.
Jun 6 2022, 5:57 PM · Restricted Project, Restricted Project
fmayer added inline comments to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.
Jun 6 2022, 5:49 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127148: [ELF] Support 'G' in .eh_frame.

test more

Jun 6 2022, 5:42 PM · Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

Should we have a test for the augmentation string, through llvm-readelf?

We have that test the follow-up CL that does the change to lld (as requested to be split by MaskRay).

Hmm ok. This tests does not really need to involve lld at all, but that's fine.

It does, because we need LLD so we can get an ELF file (which we then can readelf or, as the test does objdump).

Jun 6 2022, 5:42 PM · Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

Should we have a test for the augmentation string, through llvm-readelf?

We have that test the follow-up CL that does the change to lld (as requested to be split by MaskRay).

Hmm ok. This tests does not really need to involve lld at all, but that's fine.

Jun 6 2022, 5:28 PM · Restricted Project, Restricted Project
fmayer added inline comments to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.
Jun 6 2022, 5:22 PM · Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

Should we have a test for the augmentation string, through llvm-readelf?

Jun 6 2022, 5:20 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D127148: [ELF] Support 'G' in .eh_frame: eugenis.
Jun 6 2022, 1:41 PM · Restricted Project, Restricted Project
fmayer requested review of D127148: [ELF] Support 'G' in .eh_frame.
Jun 6 2022, 1:40 PM · Restricted Project, Restricted Project
fmayer updated the diff for D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

format

Jun 6 2022, 1:15 PM · Restricted Project, Restricted Project
fmayer retitled D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions from [llvm] Add 'G' to augmentation string for MTE instrumented functions. to [MC] Add 'G' to augmentation string for MTE instrumented functions.
Jun 6 2022, 10:35 AM · Restricted Project, Restricted Project
fmayer updated the diff for D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

address comments

Jun 6 2022, 10:12 AM · Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

Thanks for starting the GCC thread! I think the implementation is reasonable.

Turns out this is already part of ARM's ABI:
https://github.com/ARM-software/abi-aa/blob/main/aadwarf64/aadwarf64.rst#id22

Jun 6 2022, 9:44 AM · Restricted Project, Restricted Project

Jun 3 2022

fmayer updated the diff for D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

split off lld / dwarf parser change.

Jun 3 2022, 5:10 PM · Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

Reached out to GCC here: https://gcc.gnu.org/pipermail/gcc/2022-June/238813.html

Jun 3 2022, 4:53 PM · Restricted Project, Restricted Project
fmayer committed rG53c1584063e8: [NFC] [libunwind] turn assert into static_assert (authored by fmayer).
[NFC] [libunwind] turn assert into static_assert
Jun 3 2022, 4:33 PM · Restricted Project
fmayer closed D126987: [NFC] [libunwind] turn assert into static_assert.
Jun 3 2022, 4:32 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.

This was agreed on in https://lists.llvm.org/pipermail/llvm-dev/2020-May/141345.html.

This agreement is insufficient for the broad Linux community.

Linux Standard Base Core Specification, Generic Part defines augmentation string characters. Essentially this needs some GCC agreement, otherwise there could be potential future conflict.

Jun 3 2022, 4:04 PM · Restricted Project, Restricted Project
fmayer committed rGf60875254bf7: [DWARF] Show which augmentation character was unrecognized. (authored by fmayer).
[DWARF] Show which augmentation character was unrecognized.
Jun 3 2022, 3:36 PM · Restricted Project, Restricted Project
fmayer closed D127003: [DWARF] Show which augmentation character was unrecognized..
Jun 3 2022, 3:35 PM · Restricted Project, Restricted Project
fmayer updated subscribers of D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.
Jun 3 2022, 3:29 PM · Restricted Project, Restricted Project
fmayer published D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions for review.
Jun 3 2022, 3:24 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D127003: [DWARF] Show which augmentation character was unrecognized.: MaskRay.
Jun 3 2022, 2:12 PM · Restricted Project, Restricted Project
fmayer requested review of D127003: [DWARF] Show which augmentation character was unrecognized..
Jun 3 2022, 2:10 PM · Restricted Project, Restricted Project
fmayer retitled D126987: [NFC] [libunwind] turn assert into static_assert from [NFC] turn assert into static_assert to [NFC] [libunwind] turn assert into static_assert.
Jun 3 2022, 11:47 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D126987: [NFC] [libunwind] turn assert into static_assert: MaskRay.
Jun 3 2022, 11:46 AM · Restricted Project, Restricted Project, Restricted Project
fmayer requested review of D126987: [NFC] [libunwind] turn assert into static_assert.
Jun 3 2022, 11:46 AM · Restricted Project, Restricted Project, Restricted Project
fmayer committed rG7e48dae5a180: [LLVM] [NFC] remove unnecessary, confusing scope (authored by fmayer).
[LLVM] [NFC] remove unnecessary, confusing scope
Jun 3 2022, 10:10 AM · Restricted Project, Restricted Project
fmayer closed D126935: [LLVM] [NFC] remove unnecessary, confusing scope.
Jun 3 2022, 10:10 AM · Restricted Project, Restricted Project

Jun 2 2022

fmayer retitled D126935: [LLVM] [NFC] remove unnecessary, confusing scope from [LLVM] [NFC] remove unnecssary, confusing scope to [LLVM] [NFC] remove unnecessary, confusing scope.
Jun 2 2022, 6:16 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D126935: [LLVM] [NFC] remove unnecessary, confusing scope: dmgreen.
Jun 2 2022, 6:16 PM · Restricted Project, Restricted Project
fmayer requested review of D126935: [LLVM] [NFC] remove unnecessary, confusing scope.
Jun 2 2022, 6:12 PM · Restricted Project, Restricted Project

Jun 1 2022

fmayer committed rG13b8bfc51451: [libunwind] Add more information to eh_frame_hdr version error (authored by fmayer).
[libunwind] Add more information to eh_frame_hdr version error
Jun 1 2022, 7:48 PM · Restricted Project
fmayer closed D126841: [libunwind] Add more information to eh_frame_hdr version error.
Jun 1 2022, 7:48 PM · Restricted Project, Restricted Project, Restricted Project
fmayer retitled D126841: [libunwind] Add more information to eh_frame_hdr version error from [libunwind] Add more information to eh_frame_hdr version error. to [libunwind] Add more information to eh_frame_hdr version error.
Jun 1 2022, 6:11 PM · Restricted Project, Restricted Project, Restricted Project
fmayer removed 1 blocking reviewer(s) for D126841: [libunwind] Add more information to eh_frame_hdr version error: phosek.
Jun 1 2022, 6:10 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D126841: [libunwind] Add more information to eh_frame_hdr version error.

fixes

Jun 1 2022, 6:10 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D126841: [libunwind] Add more information to eh_frame_hdr version error.

Thanks for adding more information, but In ehdr at is incorrect. .eh_frame_hdr is a section. Its content is not in the ELF header.

Jun 1 2022, 5:32 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D126841: [libunwind] Add more information to eh_frame_hdr version error.

simplify string

Jun 1 2022, 5:31 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D126841: [libunwind] Add more information to eh_frame_hdr version error.

change string

Jun 1 2022, 5:30 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D126841: [libunwind] Add more information to eh_frame_hdr version error: phosek.
Jun 1 2022, 5:23 PM · Restricted Project, Restricted Project, Restricted Project
fmayer requested review of D126841: [libunwind] Add more information to eh_frame_hdr version error.
Jun 1 2022, 5:20 PM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

fmayer committed rGde67bc8edb81: [HWASan symbolize] Write error to stderr. (authored by fmayer).
[HWASan symbolize] Write error to stderr.
May 10 2022, 5:01 PM · Restricted Project, Restricted Project
fmayer committed rGbe17d18ae8e4: [HWASan] deflake hwasan_symbolize test more. (authored by fmayer).
[HWASan] deflake hwasan_symbolize test more.
May 10 2022, 4:58 PM · Restricted Project, Restricted Project

May 9 2022

fmayer committed rGb77d16f7f392: [HWASan] deflake hwasan_symbolize test (authored by fmayer).
[HWASan] deflake hwasan_symbolize test
May 9 2022, 2:12 PM · Restricted Project, Restricted Project
fmayer closed D125143: [HWASan] deflake hwasan_symbolize test.
May 9 2022, 2:12 PM · Restricted Project, Restricted Project

May 6 2022

fmayer updated the diff for D125143: [HWASan] deflake hwasan_symbolize test.

style

May 6 2022, 4:24 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D125143: [HWASan] deflake hwasan_symbolize test: eugenis.
May 6 2022, 4:21 PM · Restricted Project, Restricted Project
fmayer retitled D125143: [HWASan] deflake hwasan_symbolize test from [HWASan] deflake hwasan_symbolize test. Also enable on X86_64. to [HWASan] deflake hwasan_symbolize test.
May 6 2022, 4:20 PM · Restricted Project, Restricted Project
fmayer requested review of D125143: [HWASan] deflake hwasan_symbolize test.
May 6 2022, 4:15 PM · Restricted Project, Restricted Project
fmayer committed rG68cd47e0caff: [HWASan] Clean up hwasan_symbolize. (authored by fmayer).
[HWASan] Clean up hwasan_symbolize.
May 6 2022, 3:46 PM · Restricted Project, Restricted Project
fmayer closed D125032: [HWASan] Clean up hwasan_symbolize..
May 6 2022, 3:46 PM · Restricted Project, Restricted Project
fmayer committed rGd8564dcbcf72: [HWASan] Allow to linkify symbolizer output. (authored by fmayer).
[HWASan] Allow to linkify symbolizer output.
May 6 2022, 3:45 PM · Restricted Project, Restricted Project
fmayer closed D124950: [HWASan] Allow to linkify symbolizer output..
May 6 2022, 3:44 PM · Restricted Project, Restricted Project
fmayer added inline comments to D124950: [HWASan] Allow to linkify symbolizer output..
May 6 2022, 3:43 PM · Restricted Project, Restricted Project
fmayer added inline comments to D124950: [HWASan] Allow to linkify symbolizer output..
May 6 2022, 3:16 PM · Restricted Project, Restricted Project
fmayer updated the diff for D124950: [HWASan] Allow to linkify symbolizer output..

fix test.

May 6 2022, 3:13 PM · Restricted Project, Restricted Project
fmayer reopened D125032: [HWASan] Clean up hwasan_symbolize..
May 6 2022, 11:14 AM · Restricted Project, Restricted Project
fmayer planned changes to D124950: [HWASan] Allow to linkify symbolizer output..
May 6 2022, 11:14 AM · Restricted Project, Restricted Project
fmayer reopened D124950: [HWASan] Allow to linkify symbolizer output..
May 6 2022, 11:14 AM · Restricted Project, Restricted Project
fmayer added a comment to D124950: [HWASan] Allow to linkify symbolizer output..

I'm running python 3.9.10.

As far as I can tell, there are 2 distinct errors:

  1. the import html error on https://lab.llvm.org/buildbot/#/builders/37/builds/13022
  2. FileCheck error seen on @dyung's internal bot, on my machine, and on my bot
May 6 2022, 8:36 AM · Restricted Project, Restricted Project
fmayer added a comment to D124950: [HWASan] Allow to linkify symbolizer output..

And also our internal linux buildbot is reporting a failure after this commit:

*snip*

I'm seeing this same failure when I run ninja check-hwasan in my local, fairly vanilla, cmake build.

I'm also seeing it on http://45.33.8.238/linux/75461/step_10.txt . Given the other report of breakage, I'll revert this for now until things are sorted out.

May 6 2022, 8:31 AM · Restricted Project, Restricted Project

May 5 2022

fmayer committed rG6ca1df61d29c: [HWASan] Clean up hwasan_symbolize. (authored by fmayer).
[HWASan] Clean up hwasan_symbolize.
May 5 2022, 4:41 PM · Restricted Project, Restricted Project
fmayer closed D125032: [HWASan] Clean up hwasan_symbolize..
May 5 2022, 4:41 PM · Restricted Project, Restricted Project
fmayer committed rG4af9392e13a2: [HWASan] Allow to linkify symbolizer output. (authored by fmayer).
[HWASan] Allow to linkify symbolizer output.
May 5 2022, 4:40 PM · Restricted Project, Restricted Project
fmayer closed D124950: [HWASan] Allow to linkify symbolizer output..
May 5 2022, 4:40 PM · Restricted Project, Restricted Project
fmayer updated the diff for D125032: [HWASan] Clean up hwasan_symbolize..

rebase

May 5 2022, 2:57 PM · Restricted Project, Restricted Project
fmayer updated the diff for D124950: [HWASan] Allow to linkify symbolizer output..

address comment

May 5 2022, 2:56 PM · Restricted Project, Restricted Project
fmayer added inline comments to D124950: [HWASan] Allow to linkify symbolizer output..
May 5 2022, 2:49 PM · Restricted Project, Restricted Project
fmayer added inline comments to D124950: [HWASan] Allow to linkify symbolizer output..
May 5 2022, 2:48 PM · Restricted Project, Restricted Project
fmayer updated the diff for D125032: [HWASan] Clean up hwasan_symbolize..

address comment

May 5 2022, 2:04 PM · Restricted Project, Restricted Project
fmayer published D125032: [HWASan] Clean up hwasan_symbolize. for review.
May 5 2022, 11:57 AM · Restricted Project, Restricted Project

May 4 2022

fmayer added a comment to D124950: [HWASan] Allow to linkify symbolizer output..

This script is starting to get complex. Perhaps we should write tests?

May 4 2022, 9:43 PM · Restricted Project, Restricted Project
fmayer updated the diff for D124950: [HWASan] Allow to linkify symbolizer output..

Add test

May 4 2022, 9:42 PM · Restricted Project, Restricted Project
fmayer added a comment to D124950: [HWASan] Allow to linkify symbolizer output..

The approach looks fine. Should we also put a <html></html> pair around the output, or do you want to treat it as a snippet?

May 4 2022, 4:00 PM · Restricted Project, Restricted Project
fmayer added a comment to D124950: [HWASan] Allow to linkify symbolizer output..

This script is starting to get complex. Perhaps we should write tests?

May 4 2022, 3:54 PM · Restricted Project, Restricted Project
fmayer published D124950: [HWASan] Allow to linkify symbolizer output. for review.
May 4 2022, 2:40 PM · Restricted Project, Restricted Project
fmayer committed rG1b2704f93553: [HWASan] cleanup imports in hwasan_symbolize. (authored by fmayer).
[HWASan] cleanup imports in hwasan_symbolize.
May 4 2022, 11:23 AM · Restricted Project, Restricted Project

Apr 13 2022

fmayer committed rGffd656a2fe5d: [HWASan] symbolize: use buildid index for locals. (authored by fmayer).
[HWASan] symbolize: use buildid index for locals.
Apr 13 2022, 7:09 PM · Restricted Project, Restricted Project
fmayer closed D123644: [HWASan] symbolize: use buildid index for locals..
Apr 13 2022, 7:09 PM · Restricted Project, Restricted Project
fmayer updated the diff for D123644: [HWASan] symbolize: use buildid index for locals..

comment

Apr 13 2022, 7:07 PM · Restricted Project, Restricted Project
fmayer updated the diff for D123644: [HWASan] symbolize: use buildid index for locals..

format2

Apr 13 2022, 9:44 AM · Restricted Project, Restricted Project
fmayer updated the diff for D123644: [HWASan] symbolize: use buildid index for locals..

format

Apr 13 2022, 9:41 AM · Restricted Project, Restricted Project

Apr 12 2022

fmayer updated the diff for D123644: [HWASan] symbolize: use buildid index for locals..

oformat

Apr 12 2022, 4:39 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D123644: [HWASan] symbolize: use buildid index for locals.: eugenis.
Apr 12 2022, 4:26 PM · Restricted Project, Restricted Project
fmayer requested review of D123644: [HWASan] symbolize: use buildid index for locals..
Apr 12 2022, 4:26 PM · Restricted Project, Restricted Project

Apr 11 2022

fmayer committed rGa0570e7750fc: [HWASan] allow symbolizer script to index binaries by build id. (authored by fmayer).
[HWASan] allow symbolizer script to index binaries by build id.
Apr 11 2022, 2:13 PM · Restricted Project, Restricted Project
fmayer closed D123437: [HWASan] allow symbolizer script to index binaries by build id..
Apr 11 2022, 2:12 PM · Restricted Project, Restricted Project
fmayer added inline comments to D123437: [HWASan] allow symbolizer script to index binaries by build id..
Apr 11 2022, 1:17 PM · Restricted Project, Restricted Project
fmayer updated the diff for D123437: [HWASan] allow symbolizer script to index binaries by build id..

clarify comment

Apr 11 2022, 1:17 PM · Restricted Project, Restricted Project

Apr 8 2022

fmayer added a reviewer for D123437: [HWASan] allow symbolizer script to index binaries by build id.: eugenis.
Apr 8 2022, 8:26 PM · Restricted Project, Restricted Project
fmayer retitled D123437: [HWASan] allow symbolizer script to index binaries by build id. from [HWASan] allow symbolizer script to index binaries by build id. Tested on an example callstack with misplaced binaries from Android. Tested Regex against callstack without Build ID to confirm it still works. to [HWASan] allow symbolizer script to index binaries by build id..
Apr 8 2022, 8:25 PM · Restricted Project, Restricted Project
fmayer requested review of D123437: [HWASan] allow symbolizer script to index binaries by build id..
Apr 8 2022, 8:25 PM · Restricted Project, Restricted Project

Mar 18 2022

fmayer committed rG078b546555bf: [HWASan] do not replace lifetime intrinsics with tagged address. (authored by fmayer).
[HWASan] do not replace lifetime intrinsics with tagged address.
Mar 18 2022, 10:40 AM · Restricted Project
fmayer closed D121835: [HWASan] do not replace lifetime intrinsics with tagged address..
Mar 18 2022, 10:40 AM · Restricted Project, Restricted Project
fmayer updated the diff for D121835: [HWASan] do not replace lifetime intrinsics with tagged address..

skip if aarch64 target is not registered

Mar 18 2022, 10:35 AM · Restricted Project, Restricted Project
fmayer added a reverting change for rG208b923e74fe: [HWASan] do not replace lifetime intrinsics with tagged address.: rGdbc918b64979: Revert "[HWASan] do not replace lifetime intrinsics with tagged address.".
Mar 18 2022, 10:05 AM · Restricted Project
fmayer committed rGdbc918b64979: Revert "[HWASan] do not replace lifetime intrinsics with tagged address." (authored by fmayer).
Revert "[HWASan] do not replace lifetime intrinsics with tagged address."
Mar 18 2022, 10:05 AM · Restricted Project
fmayer reopened D121835: [HWASan] do not replace lifetime intrinsics with tagged address..
Mar 18 2022, 10:05 AM · Restricted Project, Restricted Project
fmayer added a reverting change for D121835: [HWASan] do not replace lifetime intrinsics with tagged address.: rGdbc918b64979: Revert "[HWASan] do not replace lifetime intrinsics with tagged address.".
Mar 18 2022, 10:05 AM · Restricted Project, Restricted Project