Page MenuHomePhabricator
Feed Advanced Search

Mon, Nov 28

fmayer accepted D128958: Add assembler plumbing for sanitize_memtag.
Mon, Nov 28, 10:01 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Nov 23

fmayer added inline comments to D128958: Add assembler plumbing for sanitize_memtag.
Wed, Nov 23, 2:20 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 18

fmayer accepted D137352: [scudo] Detect double free when running with MTE..
Fri, Nov 18, 12:54 PM · Restricted Project, Restricted Project
fmayer added inline comments to D137352: [scudo] Detect double free when running with MTE..
Fri, Nov 18, 11:04 AM · Restricted Project, Restricted Project

Tue, Nov 1

fmayer added a comment to D137136: [Sanitizers] Modified __aarch64__ to use the 64 bit version of the allocator..

Is it possible that this broke this fuzzer?

Tue, Nov 1, 4:10 PM · Restricted Project, Restricted Project
fmayer added a comment to rG6de41e6d7652: [ValueLattice] Fix getCompare() for undef values.

This also seems to break our ASAN bootstrap bot: https://lab.llvm.org/buildbot/#/builders/168/builds/9838/steps/13/logs/stdio

Tue, Nov 1, 12:11 PM · Restricted Project, Restricted Project

Oct 31 2022

fmayer added a reverting change for rGbc886e9b587b: [InstCombine] fold mul with decremented "shl -1" factor: rGe1de7ac20ff3: Revert "[InstCombine] fold mul with decremented "shl -1" factor".
Oct 31 2022, 6:27 PM · Restricted Project, Restricted Project
fmayer committed rGe1de7ac20ff3: Revert "[InstCombine] fold mul with decremented "shl -1" factor" (authored by fmayer).
Revert "[InstCombine] fold mul with decremented "shl -1" factor"
Oct 31 2022, 6:27 PM · Restricted Project, Restricted Project
fmayer added a comment to rGbc886e9b587b: [InstCombine] fold mul with decremented "shl -1" factor.

This seems to have broken our buildbot: https://lab.llvm.org/buildbot/#/builders/74/builds/14667

Oct 31 2022, 5:38 PM · Restricted Project, Restricted Project
fmayer added a comment to D135898: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names.

I'll submit a fix for this.

Oct 31 2022, 4:44 PM · Restricted Project, Restricted Project
fmayer committed rG2390bb234770: [NFC] use has_value instead of hasValue (authored by fmayer).
[NFC] use has_value instead of hasValue
Oct 31 2022, 4:44 PM · Restricted Project
fmayer added a comment to D135898: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names.
Oct 31 2022, 4:36 PM · Restricted Project, Restricted Project
fmayer added a comment to D135898: [wasm-ld] Allow importing/exporting the output module's memory with arbitrary names.

This broke our build bots: https://lab.llvm.org/buildbot/#/builders/19/builds/13332/steps/25/logs/stdio

Oct 31 2022, 4:22 PM · Restricted Project, Restricted Project
fmayer added inline comments to D136897: [tsan] re-exec when ASLR is enabled for x86_64 as well.
Oct 31 2022, 3:00 PM · Restricted Project, Restricted Project

Oct 21 2022

fmayer added a comment to D135688: [mlir][index] Add boilerplate for the `index` dialect.

This has broken our sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/28427/steps/9/logs/stdio

Oct 21 2022, 11:35 AM · Restricted Project, Restricted Project

Oct 18 2022

fmayer added a comment to D115757: [SLP]Generalize cost model..

It was already reverted and then committed back with a fix.

Oct 18 2022, 4:43 PM · Restricted Project, Restricted Project
fmayer added a comment to D115757: [SLP]Generalize cost model..

This seems to have an MSAN error: https://lab.llvm.org/buildbot/#/builders/74/builds/14338/steps/13/logs/stdio

Oct 18 2022, 4:34 PM · Restricted Project, Restricted Project
fmayer committed rGb96cbbd901d4: [sanitizer] Let internal symbolizer use toupper and tolower (authored by fmayer).
[sanitizer] Let internal symbolizer use toupper and tolower
Oct 18 2022, 4:19 PM · Restricted Project, Restricted Project

Oct 12 2022

fmayer committed rG2966acd1217a: [MC] only run ELF/AArch64 if supported (authored by fmayer).
[MC] only run ELF/AArch64 if supported
Oct 12 2022, 3:54 PM · Restricted Project, Restricted Project
fmayer committed rG42cdec1134cb: [MC] Consider IsMTETaggedFrame in CIEKey (authored by fmayer).
[MC] Consider IsMTETaggedFrame in CIEKey
Oct 12 2022, 2:52 PM · Restricted Project, Restricted Project
fmayer committed rGab25678ca5ae: [MC] Also sort on IsBKeyFrame (authored by fmayer).
[MC] Also sort on IsBKeyFrame
Oct 12 2022, 2:51 PM · Restricted Project, Restricted Project
fmayer closed D135639: [MC] Consider IsMTETaggedFrame in CIEKey.
Oct 12 2022, 2:51 PM · Restricted Project, Restricted Project
fmayer closed D135638: [MC] Also sort on IsBKeyFrame.
Oct 12 2022, 2:51 PM · Restricted Project, Restricted Project
fmayer updated the diff for D135639: [MC] Consider IsMTETaggedFrame in CIEKey.

messed up rebase before

Oct 12 2022, 1:59 PM · Restricted Project, Restricted Project
fmayer published D135639: [MC] Consider IsMTETaggedFrame in CIEKey for review.
Oct 12 2022, 12:44 PM · Restricted Project, Restricted Project

Oct 11 2022

fmayer added inline comments to D135638: [MC] Also sort on IsBKeyFrame.
Oct 11 2022, 12:51 PM · Restricted Project, Restricted Project
fmayer published D135638: [MC] Also sort on IsBKeyFrame for review.
Oct 11 2022, 12:38 PM · Restricted Project, Restricted Project
fmayer committed rG37b68bc362e4: [MC] [NFC] replace tabs with space in test (authored by fmayer).
[MC] [NFC] replace tabs with space in test
Oct 11 2022, 12:38 PM · Restricted Project, Restricted Project

Sep 30 2022

fmayer committed rGf5c9931fefca: [libunwind] Fix compile error with CROSS_UNWINDING (authored by fmayer).
[libunwind] Fix compile error with CROSS_UNWINDING
Sep 30 2022, 12:04 PM · Restricted Project
fmayer closed D134969: [libunwind] Fix compile error with CROSS_UNWINDING.
Sep 30 2022, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D134969: [libunwind] Fix compile error with CROSS_UNWINDING.

Phabricator doesn't work like other review systems where you use WANT_LGTM=all. There is usually no need to remove a reviewer except a few cases, e.g. a reviewer is apparently not involved in llvm-project for a long time, a reviewer removes themselves from the reviewer list.
Not for this case: sometimes removing a reviewer can be perceived negatively, e.g. whether the patch author wants to bypass someone's opinion.

Sep 30 2022, 11:51 AM · Restricted Project, Restricted Project, Restricted Project
fmayer removed a reviewer for D134969: [libunwind] Fix compile error with CROSS_UNWINDING: compnerd.
Sep 30 2022, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D128998: [libunwind] Handle G in personality string.

This change broke building with -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON:

Sep 30 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D134969: [libunwind] Fix compile error with CROSS_UNWINDING: compnerd.
Sep 30 2022, 10:17 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D134969: [libunwind] Fix compile error with CROSS_UNWINDING.

format

Sep 30 2022, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
fmayer requested review of D134969: [libunwind] Fix compile error with CROSS_UNWINDING.
Sep 30 2022, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Sep 28 2022

fmayer committed rGe06c9b63bc7b: [NFC] [HWASan] remove unnecessary cast (authored by fmayer).
[NFC] [HWASan] remove unnecessary cast
Sep 28 2022, 5:48 PM · Restricted Project, Restricted Project
fmayer accepted D134796: [StackLifetime] More efficient loop for LivenessType::Must.
Sep 28 2022, 4:14 PM · Restricted Project, Restricted Project
fmayer committed rG0401dc2913cd: [MTE] [HWASan] unify isInterestingAlloca (authored by fmayer).
[MTE] [HWASan] unify isInterestingAlloca
Sep 28 2022, 3:53 PM · Restricted Project, Restricted Project
fmayer closed D134779: [MTE] [HWASan] unify isInterestingAlloca.
Sep 28 2022, 3:52 PM · Restricted Project, Restricted Project
fmayer added inline comments to D134796: [StackLifetime] More efficient loop for LivenessType::Must.
Sep 28 2022, 12:56 PM · Restricted Project, Restricted Project

Sep 27 2022

fmayer committed rG979db5343f01: [HWASan] [NFC] use auto* over auto& for pointers (authored by fmayer).
[HWASan] [NFC] use auto* over auto& for pointers
Sep 27 2022, 6:24 PM · Restricted Project, Restricted Project
fmayer requested review of D134779: [MTE] [HWASan] unify isInterestingAlloca.
Sep 27 2022, 6:16 PM · Restricted Project, Restricted Project

Sep 21 2022

fmayer committed rGa3153381af48: [libunwind] Handle G in personality string (authored by fmayer).
[libunwind] Handle G in personality string
Sep 21 2022, 2:14 PM · Restricted Project
fmayer closed D128998: [libunwind] Handle G in personality string.
Sep 21 2022, 2:13 PM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

comment

Sep 20 2022, 2:48 PM · Restricted Project, Restricted Project, Restricted Project

Sep 19 2022

fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

naming

Sep 19 2022, 5:15 PM · Restricted Project, Restricted Project, Restricted Project
fmayer edited reviewers for D128998: [libunwind] Handle G in personality string, added: compnerd; removed: MaskRay.
Sep 19 2022, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2022

fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Sep 16 2022, 1:51 PM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2022

fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Sep 15 2022, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Sep 15 2022, 3:02 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Sep 15 2022, 2:11 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D128998: [libunwind] Handle G in personality string.
Sep 15 2022, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D128998: [libunwind] Handle G in personality string.

comments

Sep 15 2022, 1:37 PM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2022

fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Sep 14 2022, 5:17 PM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2022

fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

nit

Sep 12 2022, 2:48 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D133582: [ASan] rename internal references to left of/right of..

PTAL. I'd like to merge this earlier rather than later if possible, to avoid merge conflicts.

Sep 12 2022, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D133582: [ASan] rename internal references to left of/right of..

PTAL. I'd like to merge this earlier rather than later if possible, to avoid merge conflicts.

Sep 12 2022, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

nit

Sep 12 2022, 2:13 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D133673: [NFC][msan] Convert some code to early returns.
Sep 12 2022, 11:49 AM · Restricted Project, Restricted Project

Sep 9 2022

fmayer added a comment to D132611: [ASan] rename left/right to before/after..

the same person also noticed that in the shadow map we dump shadow addresses rather than "real" addresses, which i'd never noticed because i just ignore that bit as being "for experts only". one day i might be brave enough to admit that i don't know whether i'm supposed to be using it, and if so, for what :-)

Sep 9 2022, 11:52 AM · Restricted Project, Restricted Project
fmayer updated subscribers of D133582: [ASan] rename internal references to left of/right of..
Sep 9 2022, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

typo

Sep 9 2022, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the diff for D133582: [ASan] rename internal references to left of/right of..

preceding -> front, succeeding -> back

Sep 9 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D133582: [ASan] rename internal references to left of/right of..

Another option (probably better, WDYT?): replace preceding/succeeding with front/back.

Sep 9 2022, 9:07 AM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D132611: [ASan] rename left/right to before/after..

If you want to update this, please do it everywhere.

(I don't think it's clearer and it broke a bunch of our tests, so I'm a bit grumpy about this change. Apologies.)

Sep 9 2022, 8:48 AM · Restricted Project, Restricted Project
fmayer requested review of D133582: [ASan] rename internal references to left of/right of..
Sep 9 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

fmayer accepted D133232: [msan] Disambiguate warnings debug location.
Sep 8 2022, 11:22 AM · Restricted Project, Restricted Project

Sep 7 2022

fmayer committed rG178554f3c8f9: [ASan] Show memory rather than tag addresses in tag dump (authored by fmayer).
[ASan] Show memory rather than tag addresses in tag dump
Sep 7 2022, 1:23 PM · Restricted Project, Restricted Project
fmayer closed D133391: [ASan] Show memory rather than tag addresses in tag dump.
Sep 7 2022, 1:23 PM · Restricted Project, Restricted Project
fmayer added a comment to D133391: [ASan] Show memory rather than tag addresses in tag dump.

LGTM

Maybe add a few compile-time checks that mem->shadow->mem returns the original value? At least the sparc equations are complicated enough.

Sep 7 2022, 1:05 PM · Restricted Project, Restricted Project
fmayer updated the diff for D133391: [ASan] Show memory rather than tag addresses in tag dump.

add static assert

Sep 7 2022, 12:51 PM · Restricted Project, Restricted Project
fmayer accepted D133392: [MTE] Add AArch64GlobalsTagging Pass.
Sep 7 2022, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D133392: [MTE] Add AArch64GlobalsTagging Pass.
Sep 7 2022, 11:04 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2022

fmayer added inline comments to D133392: [MTE] Add AArch64GlobalsTagging Pass.
Sep 6 2022, 6:19 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a reviewer for D133391: [ASan] Show memory rather than tag addresses in tag dump: eugenis.
Sep 6 2022, 6:05 PM · Restricted Project, Restricted Project
fmayer requested review of D133391: [ASan] Show memory rather than tag addresses in tag dump.
Sep 6 2022, 6:05 PM · Restricted Project, Restricted Project
fmayer committed rG4f5147a7cff5: [HWASan] Show memory rather than tag addresses in tag dump (authored by fmayer).
[HWASan] Show memory rather than tag addresses in tag dump
Sep 6 2022, 4:55 PM · Restricted Project, Restricted Project
fmayer closed D133380: [HWASan] Show memory rather than tag addresses in tag dump.
Sep 6 2022, 4:54 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D133380: [HWASan] Show memory rather than tag addresses in tag dump: eugenis.
Sep 6 2022, 3:52 PM · Restricted Project, Restricted Project
fmayer requested review of D133380: [HWASan] Show memory rather than tag addresses in tag dump.
Sep 6 2022, 3:19 PM · Restricted Project, Restricted Project
fmayer accepted D133336: [msan] Convert Msan to ModulePass.
Sep 6 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added inline comments to D133232: [msan] Disambiguate warnings debug location.
Sep 6 2022, 2:21 PM · Restricted Project, Restricted Project
fmayer committed rG9006b082a5e5: [HWASan] rename left/right to before/after. (authored by fmayer).
[HWASan] rename left/right to before/after.
Sep 6 2022, 1:52 PM · Restricted Project, Restricted Project
fmayer closed D132622: [HWASan] rename left/right to before/after..
Sep 6 2022, 1:52 PM · Restricted Project, Restricted Project
fmayer committed rGa51d19636cd6: [ASan] Fix libfuzzer test (authored by fmayer).
[ASan] Fix libfuzzer test
Sep 6 2022, 1:38 PM · Restricted Project, Restricted Project
fmayer committed rGbe366041fa65: [ASan] rename left/right to before/after. (authored by fmayer).
[ASan] rename left/right to before/after.
Sep 6 2022, 1:25 PM · Restricted Project, Restricted Project
fmayer closed D132611: [ASan] rename left/right to before/after..
Sep 6 2022, 1:25 PM · Restricted Project, Restricted Project

Sep 1 2022

fmayer added a comment to D132611: [ASan] rename left/right to before/after..

This is fine from my perspective, if we want to be extra cautious it might be worth sending an announcement to Discourse before landing this change.

Sep 1 2022, 2:14 PM · Restricted Project, Restricted Project
fmayer added a comment to D132622: [HWASan] rename left/right to before/after..

Ping

Sep 1 2022, 1:28 PM · Restricted Project, Restricted Project

Aug 29 2022

fmayer added a comment to D128998: [libunwind] Handle G in personality string.

The clean part in the name and the clean parameter feels unclear to me.

And this.

Aug 29 2022, 6:12 PM · Restricted Project, Restricted Project, Restricted Project
fmayer updated the summary of D128998: [libunwind] Handle G in personality string.
Aug 29 2022, 6:02 PM · Restricted Project, Restricted Project, Restricted Project
fmayer added a comment to D128998: [libunwind] Handle G in personality string.

About __unw_clean_step:

libunwind/src/libunwind_ext.h provides a bunch of API which are not implemented by https://github.com/libunwind/libunwind .
Before we settle on an API there, it's worth raising an issue on https://github.com/libunwind/libunwind and giving them some time for the API design.

AFAICT my change does not in fact expose a new API, because it does not use _LIBUNWIND_WEAK_ALIAS, so __unw_clean_step will remain hidden visiblity.

Aug 29 2022, 3:43 PM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

fmayer updated the diff for D132611: [ASan] rename left/right to before/after..

update

Aug 25 2022, 1:38 PM · Restricted Project, Restricted Project

Aug 24 2022

fmayer added a comment to D132611: [ASan] rename left/right to before/after..

https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/tests/test.py still passes if I change https://github.com/google/clusterfuzz/blob/master/src/clusterfuzz/tests/testdata/asan_stacktrace.txt to use the new format

Aug 24 2022, 6:09 PM · Restricted Project, Restricted Project
fmayer added a comment to D132622: [HWASan] rename left/right to before/after..
Aug 24 2022, 5:58 PM · Restricted Project, Restricted Project
fmayer updated the diff for D132611: [ASan] rename left/right to before/after..

fix tests

Aug 24 2022, 5:48 PM · Restricted Project, Restricted Project
fmayer planned changes to D132611: [ASan] rename left/right to before/after..

Need to fix tests, sorry, messed something up.

Aug 24 2022, 5:28 PM · Restricted Project, Restricted Project
fmayer added a reviewer for D132622: [HWASan] rename left/right to before/after.: eugenis.
Aug 24 2022, 4:41 PM · Restricted Project, Restricted Project
fmayer requested review of D132622: [HWASan] rename left/right to before/after..
Aug 24 2022, 4:40 PM · Restricted Project, Restricted Project