Page MenuHomePhabricator
Feed Advanced Search

Tue, Nov 30

fmayer added a reviewer for D114294: [sanitizers] include build ids in stacks on linux.: eugenis.
Tue, Nov 30, 10:43 AM · Restricted Project

Mon, Nov 29

fmayer updated the diff for D114294: [sanitizers] include build ids in stacks on linux..

fix errors on x86

Mon, Nov 29, 5:47 PM · Restricted Project
fmayer added inline comments to D114464: [sanitizer] Add Leb128 encoding/decoding.
Mon, Nov 29, 3:58 PM · Restricted Project

Tue, Nov 23

fmayer committed rG26d1edfb105b: [hwasan] support python3 in hwasan_sanitize (authored by fmayer).
[hwasan] support python3 in hwasan_sanitize
Tue, Nov 23, 3:30 PM
fmayer closed D114404: [hwasan] support python3 in hwasan_sanitize.
Tue, Nov 23, 3:30 PM · Restricted Project
fmayer committed rG6c06d8e310bd: [stack-safety] Check SCEV constraints at memory instructions. (authored by fmayer).
[stack-safety] Check SCEV constraints at memory instructions.
Tue, Nov 23, 3:29 PM
fmayer closed D113160: [stack-safety] Check SCEV constraints at memory instructions..
Tue, Nov 23, 3:29 PM · Restricted Project
fmayer added inline comments to D113160: [stack-safety] Check SCEV constraints at memory instructions..
Tue, Nov 23, 11:26 AM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

address comments

Tue, Nov 23, 11:25 AM · Restricted Project

Mon, Nov 22

fmayer added a reviewer for D114404: [hwasan] support python3 in hwasan_sanitize: hctim.
Mon, Nov 22, 4:38 PM · Restricted Project
fmayer updated the diff for D114404: [hwasan] support python3 in hwasan_sanitize.

formatting

Mon, Nov 22, 4:36 PM · Restricted Project
fmayer updated the diff for D114404: [hwasan] support python3 in hwasan_sanitize.

restore py2 unicode supp

Mon, Nov 22, 4:33 PM · Restricted Project
fmayer updated the summary of D114404: [hwasan] support python3 in hwasan_sanitize.
Mon, Nov 22, 4:30 PM · Restricted Project
fmayer updated the diff for D114404: [hwasan] support python3 in hwasan_sanitize.

nits

Mon, Nov 22, 4:29 PM · Restricted Project
fmayer requested review of D114404: [hwasan] support python3 in hwasan_sanitize.
Mon, Nov 22, 3:50 PM · Restricted Project
fmayer committed rGed8b5b37abb1: [hwasan] fix arguments to symbolizer. (authored by fmayer).
[hwasan] fix arguments to symbolizer.
Mon, Nov 22, 9:59 AM
fmayer closed D114303: [hwasan] fix arguments to symbolizer..
Mon, Nov 22, 9:59 AM · Restricted Project

Fri, Nov 19

fmayer added inline comments to D113160: [stack-safety] Check SCEV constraints at memory instructions..
Fri, Nov 19, 6:55 PM · Restricted Project
fmayer updated the summary of D114303: [hwasan] fix arguments to symbolizer..
Fri, Nov 19, 6:22 PM · Restricted Project
fmayer requested review of D114303: [hwasan] fix arguments to symbolizer..
Fri, Nov 19, 6:21 PM · Restricted Project
fmayer planned changes to D114294: [sanitizers] include build ids in stacks on linux..
Fri, Nov 19, 5:17 PM · Restricted Project
fmayer removed a reviewer for D114294: [sanitizers] include build ids in stacks on linux.: eugenis.
Fri, Nov 19, 5:17 PM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

formatting

Fri, Nov 19, 4:51 PM · Restricted Project
fmayer added inline comments to D113160: [stack-safety] Check SCEV constraints at memory instructions..
Fri, Nov 19, 4:49 PM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

address comments

Fri, Nov 19, 4:48 PM · Restricted Project
fmayer added a reviewer for D114294: [sanitizers] include build ids in stacks on linux.: eugenis.
Fri, Nov 19, 3:36 PM · Restricted Project
fmayer requested review of D114294: [sanitizers] include build ids in stacks on linux..
Fri, Nov 19, 3:30 PM · Restricted Project

Wed, Nov 17

fmayer added a comment to D113160: [stack-safety] Check SCEV constraints at memory instructions..

@vitalybuka friendly ping

Wed, Nov 17, 11:46 AM · Restricted Project

Fri, Nov 12

fmayer added inline comments to D113160: [stack-safety] Check SCEV constraints at memory instructions..
Fri, Nov 12, 11:45 AM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

format

Fri, Nov 12, 9:09 AM · Restricted Project

Thu, Nov 11

fmayer added inline comments to D113160: [stack-safety] Check SCEV constraints at memory instructions..
Thu, Nov 11, 7:29 PM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

address comments

Thu, Nov 11, 7:28 PM · Restricted Project

Wed, Nov 10

fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

rebase

Wed, Nov 10, 7:19 PM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

fix typo

Wed, Nov 10, 7:14 PM · Restricted Project
fmayer added inline comments to D113160: [stack-safety] Check SCEV constraints at memory instructions..
Wed, Nov 10, 5:42 PM · Restricted Project
fmayer updated the diff for D113160: [stack-safety] Check SCEV constraints at memory instructions..

improve naming

Wed, Nov 10, 5:42 PM · Restricted Project
fmayer added a comment to D113160: [stack-safety] Check SCEV constraints at memory instructions..

This looks nice. Any idea how much does it improve analysis success rate in practice?

Would be great to have a test with some loop, if it works.

Wed, Nov 10, 5:36 PM · Restricted Project

Thu, Nov 4

fmayer published D113160: [stack-safety] Check SCEV constraints at memory instructions. for review.
Thu, Nov 4, 4:45 PM · Restricted Project

Oct 28 2021

fmayer abandoned D105705: [hwasan] More realistic setjmp test..

I realised this is already tested in longjmp-setjmp-interception.c

Oct 28 2021, 5:29 PM · Restricted Project

Oct 27 2021

fmayer committed rGdd943ebc6d2e: [hwasan] print exact mismatch offset for short granules. (authored by fmayer).
[hwasan] print exact mismatch offset for short granules.
Oct 27 2021, 7:31 PM
fmayer closed D104463: [hwasan] print exact mismatch offset for short granules..
Oct 27 2021, 7:31 PM · Restricted Project
fmayer updated the diff for D104463: [hwasan] print exact mismatch offset for short granules..

do not check short granule if mem tag is 0.

Oct 27 2021, 7:21 PM · Restricted Project

Oct 21 2021

fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Oct 21 2021, 12:55 PM · Restricted Project, Restricted Project
fmayer added a comment to D112098: [ASan] Added stack safety support in address sanitizer..

I think you also want to use SSI->isSafe(AllocaInst*) in isInterestingAlloca to prevent use-after-scope instrumentation if all accesses are safe.

Oct 21 2021, 12:50 PM · Restricted Project, Restricted Project

Oct 20 2021

fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Oct 20 2021, 1:55 PM · Restricted Project, Restricted Project
fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Oct 20 2021, 1:52 PM · Restricted Project, Restricted Project

Oct 19 2021

fmayer added inline comments to D112098: [ASan] Added stack safety support in address sanitizer..
Oct 19 2021, 5:18 PM · Restricted Project, Restricted Project

Oct 14 2021

fmayer accepted D111841: [hwasan] Fix TestCases/thread-uaf.c..

lgtm

Oct 14 2021, 2:32 PM · Restricted Project

Sep 30 2021

fmayer committed rG9c8d8fc98fe7: [NFC] [hwasan] Remove unneeded member. (authored by fmayer).
[NFC] [hwasan] Remove unneeded member.
Sep 30 2021, 8:11 AM
fmayer closed D110791: [NFC] [hwasan] Remove unneeded member..
Sep 30 2021, 8:11 AM · Restricted Project

Sep 29 2021

fmayer added a reviewer for D110791: [NFC] [hwasan] Remove unneeded member.: hctim.
Sep 29 2021, 4:59 PM · Restricted Project
fmayer requested review of D110791: [NFC] [hwasan] Remove unneeded member..
Sep 29 2021, 4:58 PM · Restricted Project

Sep 27 2021

fmayer committed rG4f352d444ecf: [NFC] [PSI] explain encoding of PercentileCutoff. (authored by fmayer).
[NFC] [PSI] explain encoding of PercentileCutoff.
Sep 27 2021, 1:41 PM
fmayer closed D109764: [NFC] [PSI] explain encoding of PercentileCutoff..
Sep 27 2021, 1:41 PM · Restricted Project
fmayer added inline comments to D109764: [NFC] [PSI] explain encoding of PercentileCutoff..
Sep 27 2021, 1:09 PM · Restricted Project

Sep 22 2021

fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

add more tests

Sep 22 2021, 8:02 AM · Restricted Project, Restricted Project
fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

simplify

Sep 22 2021, 7:51 AM · Restricted Project, Restricted Project
fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

add store test

Sep 22 2021, 7:41 AM · Restricted Project, Restricted Project
fmayer added a reviewer for D110254: [hwasan] have callbacks for 32 and 64 byte ops: eugenis.
Sep 22 2021, 7:31 AM · Restricted Project, Restricted Project
fmayer updated the diff for D110254: [hwasan] have callbacks for 32 and 64 byte ops.

add test

Sep 22 2021, 7:29 AM · Restricted Project, Restricted Project
fmayer requested review of D110254: [hwasan] have callbacks for 32 and 64 byte ops.
Sep 22 2021, 7:25 AM · Restricted Project, Restricted Project
fmayer committed rG36daf074d997: [hwasan] also omit safe mem[cpy|mov|set]. (authored by fmayer).
[hwasan] also omit safe mem[cpy|mov|set].
Sep 22 2021, 3:10 AM
fmayer closed D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 22 2021, 3:09 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

resolve test confusion

Sep 22 2021, 3:07 AM · Restricted Project
fmayer added inline comments to D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 22 2021, 2:31 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

nit

Sep 22 2021, 2:30 AM · Restricted Project

Sep 21 2021

fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

I remember from the my C days that one of gotchas with memmove/memcpy is overlapping regions. Not sure if it is relevant the context of this change, just wanted to mention it.

Sep 21 2021, 9:53 AM · Restricted Project
fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

Sorry, still need to sort out the other stack safety IR tests.

Sep 21 2021, 7:34 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

fix tests

Sep 21 2021, 7:34 AM · Restricted Project
fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

Sorry, still need to sort out the other stack safety IR tests.

Sep 21 2021, 7:26 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

match logic to comment

Sep 21 2021, 5:40 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

address comment

Sep 21 2021, 2:33 AM · Restricted Project

Sep 20 2021

fmayer committed rG16b5f4502c5b: [NFC] [hwasan] Separate outline and inline instrumentation. (authored by fmayer).
[NFC] [hwasan] Separate outline and inline instrumentation.
Sep 20 2021, 1:49 PM
fmayer closed D110067: [NFC] [hwasan] Separate outline and inline instrumentation..
Sep 20 2021, 1:49 PM · Restricted Project
fmayer added a reviewer for D110067: [NFC] [hwasan] Separate outline and inline instrumentation.: eugenis.
Sep 20 2021, 6:03 AM · Restricted Project
fmayer requested review of D110067: [NFC] [hwasan] Separate outline and inline instrumentation..
Sep 20 2021, 6:02 AM · Restricted Project
fmayer added a comment to D109764: [NFC] [PSI] explain encoding of PercentileCutoff..

Ping

Sep 20 2021, 4:40 AM · Restricted Project
fmayer added inline comments to D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 20 2021, 2:51 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

more tests & comments

Sep 20 2021, 2:49 AM · Restricted Project

Sep 16 2021

fmayer committed rG95ba9f957aa9: [hwasan] print globals in symbolizer-friendly format. (authored by fmayer).
[hwasan] print globals in symbolizer-friendly format.
Sep 16 2021, 5:29 AM
fmayer closed D109698: [hwasan] print globals in symbolizer-friendly format..
Sep 16 2021, 5:29 AM · Restricted Project
fmayer added inline comments to D109816: [hwasan] also omit safe mem[cpy|mov|set]..
Sep 16 2021, 5:05 AM · Restricted Project
fmayer updated the diff for D109816: [hwasan] also omit safe mem[cpy|mov|set]..

use getDest/getSource

Sep 16 2021, 5:04 AM · Restricted Project

Sep 15 2021

fmayer added a comment to D109816: [hwasan] also omit safe mem[cpy|mov|set]..

This leads to a 20 % runtime improvement on PDFium, when stack instrumentation is disabled.

Sep 15 2021, 10:01 AM · Restricted Project
fmayer added inline comments to D109787: [HWASan] Catch cases where libc populated jmp_buf..
Sep 15 2021, 8:37 AM · Restricted Project
fmayer updated the diff for D109698: [hwasan] print globals in symbolizer-friendly format..

fix format

Sep 15 2021, 8:21 AM · Restricted Project
fmayer published D109816: [hwasan] also omit safe mem[cpy|mov|set]. for review.
Sep 15 2021, 6:35 AM · Restricted Project
fmayer updated the diff for D109764: [NFC] [PSI] explain encoding of PercentileCutoff..

mention it is decimal

Sep 15 2021, 1:40 AM · Restricted Project

Sep 14 2021

fmayer retitled D109764: [NFC] [PSI] explain encoding of PercentileCutoff. from [PSI] explain encoding of PercentileCutoff. to [NFC] [PSI] explain encoding of PercentileCutoff..
Sep 14 2021, 9:05 AM · Restricted Project
fmayer added a reviewer for D109764: [NFC] [PSI] explain encoding of PercentileCutoff.: mtrofin.
Sep 14 2021, 9:00 AM · Restricted Project
fmayer requested review of D109764: [NFC] [PSI] explain encoding of PercentileCutoff..
Sep 14 2021, 8:56 AM · Restricted Project

Sep 13 2021

fmayer committed rG0a22510f3e64: [value-tracking] see through returned attribute. (authored by fmayer).
[value-tracking] see through returned attribute.
Sep 13 2021, 12:53 PM
fmayer closed D109675: [value-tracking] see through returned attribute..
Sep 13 2021, 12:53 PM · Restricted Project
fmayer committed rG5b5d774f5d38: [hwasan] Respect returns attribute when tracking values. (authored by fmayer).
[hwasan] Respect returns attribute when tracking values.
Sep 13 2021, 12:53 PM
fmayer closed D109233: [hwasan] Respect returns attribute when tracking values..
Sep 13 2021, 12:52 PM · Restricted Project
fmayer added a reviewer for D109698: [hwasan] print globals in symbolizer-friendly format.: eugenis.
Sep 13 2021, 8:41 AM · Restricted Project
fmayer requested review of D109698: [hwasan] print globals in symbolizer-friendly format..
Sep 13 2021, 8:40 AM · Restricted Project
fmayer added a reviewer for D109675: [value-tracking] see through returned attribute.: vitalybuka.
Sep 13 2021, 4:30 AM · Restricted Project
fmayer requested review of D109675: [value-tracking] see through returned attribute..
Sep 13 2021, 2:31 AM · Restricted Project
fmayer added inline comments to D109233: [hwasan] Respect returns attribute when tracking values..
Sep 13 2021, 2:04 AM · Restricted Project