- Rebaseline, just to keep this up-to-date.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 2 2019
Feb 2 2019
Jun 1 2018
Jun 1 2018
May 30 2018
May 30 2018
dneilson committed rL333588: [IRBuilder] Add APIs for creating calls to atomic memmove and memset intrinsics..
[IRBuilder] Add APIs for creating calls to atomic memmove and memset intrinsics.
dneilson committed rL333551: [AliasSet] Teach the alias set how to handle atomic memcpy/memmove/memset.
[AliasSet] Teach the alias set how to handle atomic memcpy/memmove/memset
May 29 2018
May 29 2018
[BasicAA] Teach the analysis about atomic memcpy
May 11 2018
May 11 2018
[InstCombine] Handle atomic memset in the same way as regular memset
dneilson updated the diff for D46660: [InstCombine] Handle atomic memset in the same way as regular memset.
- Rebaseline prior to landing
dneilson committed rL332093: [InstCombine] Unify handling of atomic memtransfer with non-atomic memtransfer.
[InstCombine] Unify handling of atomic memtransfer with non-atomic memtransfer
May 10 2018
May 10 2018
dneilson committed rL331991: [DSE] Teach the pass about partial overwrite of atomic memory intrinsics.
[DSE] Teach the pass about partial overwrite of atomic memory intrinsics
May 9 2018
May 9 2018
dneilson updated the diff for D46658: [InstCombine] Unify handling of atomic memtransfer with non-atomic memtransfer.
- Don't multiply length by element size for atomic memtransfer intrinsics.
- Add tests to show proper behaviour in this case.
dneilson added a comment to D45584: [DSE] Teach the pass about partial overwrite of atomic memory intrinsics.
ping - any takers to review this? I'm fairly certain it's correct, but a sanity check would be nice.
May 8 2018
May 8 2018
Changing constants in a test (NFC)
May 3 2018
May 3 2018
dneilson updated the diff for D45584: [DSE] Teach the pass about partial overwrite of atomic memory intrinsics.
- Use mod operator instead of bit twiddling
dneilson added inline comments to D45584: [DSE] Teach the pass about partial overwrite of atomic memory intrinsics.
May 1 2018
May 1 2018
Yes, this was the cause of the break. Put an X86 test in the general-arch directory.
[LV] Move test/Transforms/LoopVectorize/pr23997.ll
[LV] Preserve inbounds on created GEPs
Apr 30 2018
Apr 30 2018
- Address latest review comment.
- Rebaseline.
- Also preserve inbounds when vectorizing interleaved groups.
Apr 27 2018
Apr 27 2018
[LV] Common duplicate vector load/store address calculation (NFC)
Apr 24 2018
Apr 24 2018
[CaptureTracking] Fixup const correctness of DomTree arg (NFC)
Apr 23 2018
Apr 23 2018
[DSE] Teach the pass that atomic memory intrinsics are stores.
In D45535#1075797, @efriedma wrote:LGTM
dneilson updated the diff for D45535: [DSE] Teach the pass that atomic memory intrinsics are stores..
- Deleted memtransferinst case in handleEndBlock.
dneilson added inline comments to D45535: [DSE] Teach the pass that atomic memory intrinsics are stores..
dneilson updated the diff for D45535: [DSE] Teach the pass that atomic memory intrinsics are stores..
- Update for reviewer comment.
[SelectionDAG] Refactor lowering of atomic memory intrinsics.
Apr 18 2018
Apr 18 2018
In D45535#1071336, @dmgreen wrote:Am I right in saying these are treated in the same way as unordered atomic stores are? In that they can be deleted by following non-atomic stores, even if they are "stronger" atomically? If so, this looks fine to me.
ping - any reviewers able to take a crack at this?
dneilson added a comment to D45584: [DSE] Teach the pass about partial overwrite of atomic memory intrinsics.
ping - any reviewers able to take a crack at this?
Apr 12 2018
Apr 12 2018
Apr 11 2018
Apr 11 2018
[DSE] Add tests for atomic memory intrinsics (NFC)
[DSE] Regenerate tests with update_test_checks.py (NFC)
[DSE] Regenerate tests with update_test_checks.py (NFC)
Apr 10 2018
Apr 10 2018
dneilson committed rL329753: [Verifier] Refactor duplicate code for atomic mem intrinsic verification (NFC).
[Verifier] Refactor duplicate code for atomic mem intrinsic verification (NFC)
[IR] Refactor memset inst classes (NFC)
[IR] Refactor memtransfer inst classes (NFC)
Apr 5 2018
Apr 5 2018
dneilson committed rL329331: [InstCombine] Properly change GEP type when reassociating loop invariant GEP….
[InstCombine] Properly change GEP type when reassociating loop invariant GEP…
dneilson updated the diff for D45287: [InstCombine] Properly change GEP type when reassociating loop invariant GEP chains.
- Make review copy match what will be landed.
dneilson updated the diff for D45287: [InstCombine] Properly change GEP type when reassociating loop invariant GEP chains.
- Change insertion point of replacement src GEP instruction.
dneilson added inline comments to D45287: [InstCombine] Properly change GEP type when reassociating loop invariant GEP chains.
Apr 4 2018
Apr 4 2018
Apr 3 2018
Apr 3 2018
dneilson committed rL329087: [InstCombine] Fold compare of int constant against a splatted vector of ints.
[InstCombine] Fold compare of int constant against a splatted vector of ints
dneilson updated the diff for D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
- Final updates suggested. Just updating the differential review to match what will be landed.
dneilson updated the diff for D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
- Simplify implementation
- Prune tests (remove redundant & unneccessary); all added tests have now been triple checked that they do not simplify/fold even a single instruction without this patch.
dneilson added inline comments to D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
Apr 2 2018
Apr 2 2018
dneilson retitled D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints from [InstCombine] Fold compare of int constant against an integer vector splat to [InstCombine] Fold compare of int constant against a splatted vector of ints.
dneilson updated the diff for D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
- Following spatel's suggestion -- making the pattern match a little more general by only matching the bitcast + shuffle.
Mar 29 2018
Mar 29 2018
dneilson added inline comments to D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
dneilson updated the diff for D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
- Generalize to predicates other than just (in)equality.
dneilson added a comment to D44997: [InstCombine] Fold compare of int constant against a splatted vector of ints.
In D44997#1051341, @mkazantsev wrote:Ah, I see the type mismatch, but still. What prevents us from doing the same for less, greater etc. comparisons? Arithmetics?
Mar 28 2018
Mar 28 2018
[PatternMatch] Add matchers for vector operations
Mar 23 2018
Mar 23 2018
dneilson committed rL328317: Remove the deprecated single-alignment IRBuilder API for memcpy/memmove (NFC).
Remove the deprecated single-alignment IRBuilder API for memcpy/memmove (NFC)
Remove deprecated MemIntrinsic methods (NFC)
Mar 22 2018
Mar 22 2018
[InstCombineCalls] Update deprecated API usage (NFC)
Mar 21 2018
Mar 21 2018
[MemCpyOpt] Update to new API for memory intrinsic alignment
Mar 14 2018
Mar 14 2018
Mar 13 2018
Mar 13 2018
dneilson committed rL327421: [SelectionDAGBuilder] Replace deprecated calls to MemoryIntrinsic::getAlignment….
[SelectionDAGBuilder] Replace deprecated calls to MemoryIntrinsic::getAlignment…
dneilson committed rL327398: [SROA] Take advantage of separate alignments for memcpy source and destination.
[SROA] Take advantage of separate alignments for memcpy source and destination
Mar 12 2018
Mar 12 2018
dneilson updated the diff for D42974: [SROA] Take advantage of separate alignments for memcpy source and destination.
Rebaseline & address review comment regarding reducing the usage of ternary operator
in creation of memcpy.
dneilson added inline comments to D42974: [SROA] Take advantage of separate alignments for memcpy source and destination.
dneilson added a comment to D42974: [SROA] Take advantage of separate alignments for memcpy source and destination.
Thank you for taking a look at this Eli! Very much appreciated
dneilson added a comment to D42974: [SROA] Take advantage of separate alignments for memcpy source and destination.
ping. Anyone able to review?
Mar 5 2018
Mar 5 2018
[RewriteStatepoints] Fix stale parse points
dneilson committed rL326730: [InstCombine] Don't blow up in foldICmpWithCastAndCast on vector icmp….
[InstCombine] Don't blow up in foldICmpWithCastAndCast on vector icmp…
dneilson added inline comments to D44063: [InstCombine] Don't blow up in foldICmpWithCastAndCast on vector icmp instructions..
dneilson added inline comments to D44063: [InstCombine] Don't blow up in foldICmpWithCastAndCast on vector icmp instructions..
Mar 2 2018
Mar 2 2018
Mar 1 2018
Mar 1 2018
dneilson requested changes to D43935: [RewriteStatepoints] Fix phis with different incoming Loads for the same incoming blocks.
Please add a test case that demonstrates the patch in action (and would prevent regressions).
Please add a test case that demonstrates the patch in action (and would prevent regressions).
Feb 28 2018
Feb 28 2018
dneilson added a comment to D42974: [SROA] Take advantage of separate alignments for memcpy source and destination.
ping
Feb 22 2018
Feb 22 2018
In D42789#1016252, @pcc wrote:Apologies for missing this patch. It seems to be fixing the same problem as D43132, but that patch also handles trampoline functions correctly, so I think we should go with that one.
dneilson committed rL325816: [AlignmentFromAssumptions] Set source and dest alignments of memory intrinsiscs….
[AlignmentFromAssumptions] Set source and dest alignments of memory intrinsiscs…
Not terribly familiar with this code, but my understanding from reading the construction of the CustomCI for WK_Custom...
dneilson updated the diff for D42974: [SROA] Take advantage of separate alignments for memcpy source and destination.
- Rebaseline
Feb 12 2018
Feb 12 2018
dneilson committed rL324960: [InstCombine] Simplify MemTransferInst's source and dest alignments separately.
[InstCombine] Simplify MemTransferInst's source and dest alignments separately