- Rebaseline, just to keep this up-to-date.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 2 2019
Jun 1 2018
May 30 2018
May 29 2018
May 11 2018
- Rebaseline prior to landing
May 10 2018
May 9 2018
- Don't multiply length by element size for atomic memtransfer intrinsics.
- Add tests to show proper behaviour in this case.
ping - any takers to review this? I'm fairly certain it's correct, but a sanity check would be nice.
May 8 2018
May 3 2018
- Use mod operator instead of bit twiddling
May 1 2018
Yes, this was the cause of the break. Put an X86 test in the general-arch directory.
Apr 30 2018
- Address latest review comment.
- Rebaseline.
- Also preserve inbounds when vectorizing interleaved groups.
Apr 27 2018
Apr 24 2018
Apr 23 2018
In D45535#1075797, @efriedma wrote:LGTM
- Deleted memtransferinst case in handleEndBlock.
- Update for reviewer comment.
Apr 18 2018
In D45535#1071336, @dmgreen wrote:Am I right in saying these are treated in the same way as unordered atomic stores are? In that they can be deleted by following non-atomic stores, even if they are "stronger" atomically? If so, this looks fine to me.
ping - any reviewers able to take a crack at this?
ping - any reviewers able to take a crack at this?
Apr 12 2018
Apr 11 2018
Apr 10 2018
Apr 5 2018
- Make review copy match what will be landed.
- Change insertion point of replacement src GEP instruction.
Apr 4 2018
Apr 3 2018
- Final updates suggested. Just updating the differential review to match what will be landed.
- Simplify implementation
- Prune tests (remove redundant & unneccessary); all added tests have now been triple checked that they do not simplify/fold even a single instruction without this patch.
Apr 2 2018
- Following spatel's suggestion -- making the pattern match a little more general by only matching the bitcast + shuffle.
Mar 29 2018
- Generalize to predicates other than just (in)equality.
In D44997#1051341, @mkazantsev wrote:Ah, I see the type mismatch, but still. What prevents us from doing the same for less, greater etc. comparisons? Arithmetics?
Mar 28 2018
Mar 23 2018
Mar 22 2018
Mar 21 2018
Mar 14 2018
Mar 13 2018
Mar 12 2018
Rebaseline & address review comment regarding reducing the usage of ternary operator
in creation of memcpy.
Thank you for taking a look at this Eli! Very much appreciated
ping. Anyone able to review?
Mar 5 2018
Mar 2 2018
Mar 1 2018
Please add a test case that demonstrates the patch in action (and would prevent regressions).
Please add a test case that demonstrates the patch in action (and would prevent regressions).
Feb 28 2018
ping
Feb 22 2018
In D42789#1016252, @pcc wrote:Apologies for missing this patch. It seems to be fixing the same problem as D43132, but that patch also handles trampoline functions correctly, so I think we should go with that one.
Not terribly familiar with this code, but my understanding from reading the construction of the CustomCI for WK_Custom...
- Rebaseline