I added the 'rm' after the test. Will upload another patch to fix that.

removed temporary file generated by the test.

ping?

unittest added

I will upload a test later.

Upload the right patch, fixed the option order in Options.td

ping?

ping?

Removed redundant 'if' statement

ping?

ping?

ping?

Makes the default value to /path/to/binary_dwo, when DWO_DIR is provided, make the path to DWO_DIR/path/to/binary_dwo

ping?

Use the option -gsplit-dwarf to make it more consistent.

It looks like this error comes from the mixing of LTO, debug fission and -fdebug-info-for-profiling.

ping?

ping?

I prefer to have a dedicated directory to store all the .dwo files. As dblaikie said, all the .dwo files are temporary files. In addition, in order to differentiate the .dwo files generated by different link stage with the same .o, we need to add
some suffixes to the .dwo file. So for a file a.o, we may need to generate a .dwo named a._${number}_${random_string}.dwo, which is not neat. Furthermore, we need to dealing with archive files. In this case, we may need to generate
multiple .dwo files for a single archive files.

Fix an indent error during rebase.

rebase to trunk.

You shouldn't need clang to test ThinLTO. See for example any of the tests in test/tools/gold/X86/thinlto*.ll.

Thanks, It seems I can to pass -shared to gold to avoid invoking clang. A test case was uploaded.

In D44792#1047010, @pcc wrote:

A reminder to add context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

Test cases please. Also I think you will need to add the dwo path and the task id to the cache key if split dwarf is enabled.

I have another one D44792 on LLVM side.

I've sent a reproduce test case to tejohnson.

This error happens when I try to triage a thinLTO failure on ARM.

A test case with 4K lines of code can show the difference. Reducing the compilation time from 3 seconds to instant on my desktop. Do you need that?
Could you please commit this for me? I still do not have the right to commit yet.

ping?

ping?

Applied Rafael's patch while still looking to see what is wrong of my git clang format.

I did not realize that git clang-format will modify the code directly. Updated.
Thanks

ping?

The clang-format check is done. The doc comment is updated.

Is there an example for the test case with timeout? Thanks

Some format changes.

ping?

I uploaded a test case.
Without the patch, the test case fails, with the patch, the test case passes.

Do you still have the test case?

What is your test case?
I followed the bug https://llvm.org/bugs/show_bug.cgi?id=12587

It seems this have not been checked in, could you please double check that?

I have done arc commit --revision D<Revision> in my local svn repository and it seems to be successful, did I miss some thing?
If it does not get committed, please commit it for me, thanks.