Page MenuHomePhabricator
Feed Advanced Search

Yesterday

hliao added inline comments to D68554: [clang-format] Proposal for clang-format to give compiler style warnings.
Thu, Oct 17, 4:51 PM · Restricted Project, Restricted Project, Restricted Project
hliao added a comment to D69124: [clang][driver] Print compilation phases with indentation..
In D69124#1713360, @tra wrote:

Could you give an example of before/after output?

Thu, Oct 17, 11:49 AM · Restricted Project
hliao added a comment to D69124: [clang][driver] Print compilation phases with indentation..
In D69124#1713360, @tra wrote:

Could you give an example of before/after output?

Thu, Oct 17, 11:40 AM · Restricted Project
hliao created D69124: [clang][driver] Print compilation phases with indentation..
Thu, Oct 17, 11:11 AM · Restricted Project
hliao added a comment to D69124: [clang][driver] Print compilation phases with indentation..

this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload compilation, a tree representation is more intuitive. Even though there are cross-subtree edges, they are rare and also noted in the corresponding actions.

Thu, Oct 17, 11:11 AM · Restricted Project
hliao updated the diff for D68818: [hip][cuda] Fix the extended lambda name mangling issue..

Force numbering on all lambdas in CUDA/HIP.

Thu, Oct 17, 9:46 AM · Restricted Project
hliao committed rL375112: Request commit access for .
Request commit access for
Thu, Oct 17, 6:03 AM

Wed, Oct 16

hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..

Broadly, I think it's reasonable to number additional lambda expressions in CUDA compilations. However:

  • This is (in theory) an ABI break on the host side, as it changes the lambda numbering in inline functions and function templates and the like. That could be mitigated by using a different numbering sequence for the lambdas that are only numbered for this reason.
  • Depending on whether the call operator is a device function is unstable. If I understand the CUDA rules correctly, then in practice, because constexpr functions are implicitly host device, all lambdas will get numbered in CUDA on C++14 onwards but not in CUDA on C++11, and we generally want those modes to be ABI-compatible. I'd suggest you simplify and stabilize this by simply numbering all lambdas in CUDA mode.
Wed, Oct 16, 1:49 PM · Restricted Project
hliao committed rGb4874226de61: [clangd] Add the missing dependency on `clangLex`. (authored by hliao).
[clangd] Add the missing dependency on `clangLex`.
Wed, Oct 16, 1:29 PM
hliao committed rL375039: [clangd] Add the missing dependency on `clangLex`..
[clangd] Add the missing dependency on `clangLex`.
Wed, Oct 16, 1:28 PM
hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..

PING for review

Wed, Oct 16, 6:03 AM · Restricted Project

Tue, Oct 15

hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..
In D68818#1709688, @tra wrote:

@rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules & ABI scare me. :-)

Tue, Oct 15, 9:15 AM · Restricted Project
hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..

PING for review

Tue, Oct 15, 6:00 AM · Restricted Project

Fri, Oct 11

hliao committed rG30c855d42aa2: Fix compilation warnings. NFC. (authored by hliao).
Fix compilation warnings. NFC.
Fri, Oct 11, 7:08 AM
hliao committed rL374554: Fix compilation warnings. NFC..
Fix compilation warnings. NFC.
Fri, Oct 11, 7:08 AM
hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..

PING for review, thanks

Fri, Oct 11, 6:14 AM · Restricted Project

Thu, Oct 10

hliao added a comment to D68660: [tooling] Teach Tooling to understand compilation with offloading..

This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt

Thu, Oct 10, 5:13 PM · Restricted Project
hliao committed rG6fa082fb00a1: Fix compilation warning due to typo. (authored by hliao).
Fix compilation warning due to typo.
Thu, Oct 10, 4:54 PM
hliao committed rL374479: Fix compilation warning due to typo..
Fix compilation warning due to typo.
Thu, Oct 10, 4:54 PM
hliao committed rG1f62ae863571: [tooling] Fix assertion on MacOSX. (authored by hliao).
[tooling] Fix assertion on MacOSX.
Thu, Oct 10, 4:45 PM
hliao committed rL374478: [tooling] Fix assertion on MacOSX..
[tooling] Fix assertion on MacOSX.
Thu, Oct 10, 4:45 PM
hliao added a comment to D68660: [tooling] Teach Tooling to understand compilation with offloading..

This makes tests assert on Mac: http://45.33.8.238/mac/1415/step_6.txt

Thu, Oct 10, 4:44 PM · Restricted Project
hliao committed rG1ccb39bbd87c: [tooling] Teach Tooling to understand compilation with offloading. (authored by hliao).
[tooling] Teach Tooling to understand compilation with offloading.
Thu, Oct 10, 4:08 PM
hliao committed rL374470: [tooling] Teach Tooling to understand compilation with offloading..
[tooling] Teach Tooling to understand compilation with offloading.
Thu, Oct 10, 4:07 PM
hliao closed D68660: [tooling] Teach Tooling to understand compilation with offloading..
Thu, Oct 10, 4:07 PM · Restricted Project
hliao updated the diff for D68660: [tooling] Teach Tooling to understand compilation with offloading..

revice comment.

Thu, Oct 10, 2:24 PM · Restricted Project
hliao added inline comments to D68660: [tooling] Teach Tooling to understand compilation with offloading..
Thu, Oct 10, 2:24 PM · Restricted Project
hliao added inline comments to D68660: [tooling] Teach Tooling to understand compilation with offloading..
Thu, Oct 10, 12:20 PM · Restricted Project
hliao updated the diff for D68660: [tooling] Teach Tooling to understand compilation with offloading..

add more assertions on offload compilation.

Thu, Oct 10, 12:18 PM · Restricted Project
hliao committed rGa121891a5536: Fix build by adding the missing dependency. (authored by hliao).
Fix build by adding the missing dependency.
Thu, Oct 10, 11:04 AM
hliao committed rL374406: Fix build by adding the missing dependency..
Fix build by adding the missing dependency.
Thu, Oct 10, 11:03 AM
hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..

minor comment to help review.

Thu, Oct 10, 10:32 AM · Restricted Project
hliao added a comment to D68818: [hip][cuda] Fix the extended lambda name mangling issue..

this's a patch address the same issue previously proposed to be worked around in https://reviews.llvm.org/D63164

Thu, Oct 10, 10:23 AM · Restricted Project
hliao created D68818: [hip][cuda] Fix the extended lambda name mangling issue..
Thu, Oct 10, 10:23 AM · Restricted Project
hliao accepted D68769: Revert "[AMDGPU] Run `unreachable-mbb-elimination` after isel to clean up PHIs.".

LGTM

Thu, Oct 10, 6:29 AM · Restricted Project

Wed, Oct 9

hliao committed rGc752f5bce4cc: [ast] Fix indentation. NFC. (authored by hliao).
[ast] Fix indentation. NFC.
Wed, Oct 9, 9:16 PM
hliao committed rL374276: [ast] Fix indentation. NFC..
[ast] Fix indentation. NFC.
Wed, Oct 9, 9:16 PM
hliao committed rGe398def94382: [sema] Revise `getCurrentMangleNumberContext` interface. NFC. (authored by hliao).
[sema] Revise `getCurrentMangleNumberContext` interface. NFC.
Wed, Oct 9, 8:22 PM
hliao committed rL374274: [sema] Revise `getCurrentMangleNumberContext` interface. NFC..
[sema] Revise `getCurrentMangleNumberContext` interface. NFC.
Wed, Oct 9, 8:13 PM
hliao committed rGfd18e94697c9: [mangle] Fix mangling where an extra mangle context is required. (authored by hliao).
[mangle] Fix mangling where an extra mangle context is required.
Wed, Oct 9, 12:13 PM
hliao committed rL374200: [mangle] Fix mangling where an extra mangle context is required..
[mangle] Fix mangling where an extra mangle context is required.
Wed, Oct 9, 12:13 PM
hliao closed D68715: [mangle] Fix mangling where an extra mangle context is required..
Wed, Oct 9, 12:13 PM · Restricted Project
hliao added inline comments to D68660: [tooling] Teach Tooling to understand compilation with offloading..
Wed, Oct 9, 12:13 PM · Restricted Project
hliao added a comment to D68715: [mangle] Fix mangling where an extra mangle context is required..

LGTM

Wed, Oct 9, 12:13 PM · Restricted Project
hliao added a comment to D68660: [tooling] Teach Tooling to understand compilation with offloading..

PING for review

Wed, Oct 9, 11:54 AM · Restricted Project
hliao added a comment to D68715: [mangle] Fix mangling where an extra mangle context is required..

s/code/core/ in last comment

Wed, Oct 9, 11:54 AM · Restricted Project
hliao added inline comments to D68715: [mangle] Fix mangling where an extra mangle context is required..
Wed, Oct 9, 11:54 AM · Restricted Project
hliao updated the diff for D68715: [mangle] Fix mangling where an extra mangle context is required..

remove refactoring code

Wed, Oct 9, 11:45 AM · Restricted Project
hliao created D68715: [mangle] Fix mangling where an extra mangle context is required..
Wed, Oct 9, 10:09 AM · Restricted Project
hliao committed rG2ae54aba03f2: [clang-offload-bundler] Support `.cui` and `.d`. (authored by hliao).
[clang-offload-bundler] Support `.cui` and `.d`.
Wed, Oct 9, 6:53 AM
hliao closed D68663: [clang-offload-bundler] Support `.cui` and `.d`..
Wed, Oct 9, 6:53 AM · Restricted Project
hliao committed rL374167: [clang-offload-bundler] Support `.cui` and `.d`..
[clang-offload-bundler] Support `.cui` and `.d`.
Wed, Oct 9, 6:52 AM
hliao added inline comments to D68660: [tooling] Teach Tooling to understand compilation with offloading..
Wed, Oct 9, 6:23 AM · Restricted Project

Tue, Oct 8

hliao added a comment to D68663: [clang-offload-bundler] Support `.cui` and `.d`..

Adding this support is aimed to prevent crashing or failure, it's not intended to be final output for -M or -E. So, hip fails on these options due to the unsupported type of clang-offload-bundler. Before we nail down the details on the expected output of -M or -E, especially -M, we at least should not fail them.

Tue, Oct 8, 1:31 PM · Restricted Project
hliao created D68663: [clang-offload-bundler] Support `.cui` and `.d`..
Tue, Oct 8, 1:25 PM · Restricted Project
hliao created D68660: [tooling] Teach Tooling to understand compilation with offloading..
Tue, Oct 8, 12:41 PM · Restricted Project
hliao abandoned D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`..

need to more clarification and re-design

Tue, Oct 8, 12:31 PM · Restricted Project
hliao added a comment to D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`..
In D68587#1700178, @tra wrote:

TL; DR;
+1 to formalizing how we want -M*/-E/-S/-emit-llvm/-fsyntax-only to behave.
OK with -M/-E/-S defaulting to host, and erroring out if applied to multiple sub-compilations.
I'm still convinced that the tooling issue with multiple subcompilations is orthogonal to this change and should be handled in libclang and that -fsyntax-only should not default to one sub-compilation.

Tue, Oct 8, 12:31 PM · Restricted Project
hliao committed rG6334a59454ef: [driver][hip] Skip bundler if host action is nothing. (authored by hliao).
[driver][hip] Skip bundler if host action is nothing.
Tue, Oct 8, 11:07 AM
hliao closed D68652: [driver][hip] Skip bundler if host action is nothing..
Tue, Oct 8, 11:07 AM · Restricted Project
hliao committed rL374097: [driver][hip] Skip bundler if host action is nothing..
[driver][hip] Skip bundler if host action is nothing.
Tue, Oct 8, 11:07 AM
hliao added inline comments to D68652: [driver][hip] Skip bundler if host action is nothing..
Tue, Oct 8, 10:57 AM · Restricted Project
hliao created D68652: [driver][hip] Skip bundler if host action is nothing..
Tue, Oct 8, 9:47 AM · Restricted Project

Mon, Oct 7

hliao added a comment to D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`..
In D68587#1698247, @tra wrote:

for most compilation tools, single input and single output are expected. Without assuming -fsyntax-only alone is host-compilation only, that at least run syntax checking twice.

I believe the driver will not run subsequent jobs if one of the device compilations fails. You may see duplicate warnings from multiple stages, but overall the error handling works in a fairly predictable way now.

Mon, Oct 7, 6:41 PM · Restricted Project
hliao added a comment to D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`..
In D68587#1698055, @tra wrote:

I'm fine with this for -E/-M,

I would argue that with -fsyntax-only we want to know whether our source code, which is common for all sub-compilations, has syntactic errors.
The way we compile HIP & CUDA sources, some of the errors will only be reported on one side of the compilation.
So, in order to make sure there are no syntax errors, we need to perform *all* sub-compilations with -fsyntax-only.

E.g. it would be rather surprising to see the compilation succeeding with -fsyntax-only, but then fail with a syntax error somewhere on the device side during a real compilation.

Mon, Oct 7, 1:29 PM · Restricted Project
hliao created D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`..
Mon, Oct 7, 12:25 PM · Restricted Project
hliao added inline comments to D68578: [HIP] Fix device stub name.
Mon, Oct 7, 9:48 AM

Thu, Oct 3

hliao committed rG691e44c146f3: [HIP] Enable specifying different default gpu arch for HIP/CUDA. (authored by hliao).
[HIP] Enable specifying different default gpu arch for HIP/CUDA.
Thu, Oct 3, 10:49 AM
hliao committed rL373634: [HIP] Enable specifying different default gpu arch for HIP/CUDA..
[HIP] Enable specifying different default gpu arch for HIP/CUDA.
Thu, Oct 3, 10:47 AM
hliao closed D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA..
Thu, Oct 3, 10:47 AM · Restricted Project, Restricted Project
hliao committed rG9c1503f66992: Fix build failure with GCC on identifier reusing. (authored by hliao).
Fix build failure with GCC on identifier reusing.
Thu, Oct 3, 10:47 AM
hliao committed rL373633: Fix build failure with GCC on identifier reusing..
Fix build failure with GCC on identifier reusing.
Thu, Oct 3, 10:45 AM
hliao added inline comments to D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA..
Thu, Oct 3, 9:32 AM · Restricted Project, Restricted Project
hliao added inline comments to D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA..
Thu, Oct 3, 7:32 AM · Restricted Project, Restricted Project
hliao created D68394: [HIP] Enable specifying different default gpu arch for HIP/CUDA..
Thu, Oct 3, 7:31 AM · Restricted Project, Restricted Project
hliao added inline comments to D68300: [HIP] Use option -nogpulib to disable linking device lib.
Thu, Oct 3, 6:59 AM · Restricted Project

Tue, Oct 1

hliao committed rGc3aab6eaaa0f: Fix GCC -Wreturn-type warnings. NFC. (authored by hliao).
Fix GCC -Wreturn-type warnings. NFC.
Tue, Oct 1, 9:12 PM
hliao committed rL373422: Fix GCC -Wreturn-type warnings. NFC..
Fix GCC -Wreturn-type warnings. NFC.
Tue, Oct 1, 9:11 PM
hliao committed rGd838cf76caca: Fix unused variable warning. NFCI. (authored by hliao).
Fix unused variable warning. NFCI.
Tue, Oct 1, 5:23 PM
hliao committed rL373410: Fix unused variable warning. NFCI..
Fix unused variable warning. NFCI.
Tue, Oct 1, 5:22 PM
hliao added a comment to D68157: [X86][ABI] Keep empty class argument passing by value compatible with GCC..

PING

Tue, Oct 1, 2:33 PM · Restricted Project

Mon, Sep 30

hliao accepted D68235: [Dominators][CodeGen] Add MachinePostDominatorTree verification.

LGTM

Mon, Sep 30, 12:06 PM · Restricted Project
hliao added a comment to D68157: [X86][ABI] Keep empty class argument passing by value compatible with GCC..

ping for review

Mon, Sep 30, 9:11 AM · Restricted Project

Fri, Sep 27

hliao created D68157: [X86][ABI] Keep empty class argument passing by value compatible with GCC..
Fri, Sep 27, 12:52 PM · Restricted Project

Wed, Sep 25

hliao committed rG24337db61666: [CUDA][HIP] Enable kernel function return type deduction. (authored by hliao).
[CUDA][HIP] Enable kernel function return type deduction.
Wed, Sep 25, 9:52 AM
hliao committed rL372898: [CUDA][HIP] Enable kernel function return type deduction..
[CUDA][HIP] Enable kernel function return type deduction.
Wed, Sep 25, 9:52 AM
hliao closed D68031: [CUDA][HIP] Enable kernel function return type deduction..
Wed, Sep 25, 9:52 AM · Restricted Project
hliao added a comment to D68031: [CUDA][HIP] Enable kernel function return type deduction..
In D68031#1682822, @tra wrote:

Nice. I'd mention in the commit message that NVCC does not support deduced return type for kernel functions.

Wed, Sep 25, 9:51 AM · Restricted Project
hliao created D68031: [CUDA][HIP] Enable kernel function return type deduction..
Wed, Sep 25, 8:40 AM · Restricted Project
hliao created D68030: [CUDA][HIP] Initial kernel return type relaxing..
Wed, Sep 25, 8:31 AM · Restricted Project
hliao abandoned D68030: [CUDA][HIP] Initial kernel return type relaxing..
Wed, Sep 25, 8:31 AM · Restricted Project

Tue, Sep 24

hliao accepted D67974: [Dominators][AMDGPU] Don't use virtual exit node in findNearestCommonDominator. Cleanup MachinePostDominators..

LGTM

Tue, Sep 24, 5:28 PM · Restricted Project, Restricted Project
hliao requested changes to D67974: [Dominators][AMDGPU] Don't use virtual exit node in findNearestCommonDominator. Cleanup MachinePostDominators..
Tue, Sep 24, 2:09 PM · Restricted Project, Restricted Project
hliao requested changes to D67974: [Dominators][AMDGPU] Don't use virtual exit node in findNearestCommonDominator. Cleanup MachinePostDominators..
Tue, Sep 24, 2:03 PM · Restricted Project, Restricted Project
hliao added inline comments to D67974: [Dominators][AMDGPU] Don't use virtual exit node in findNearestCommonDominator. Cleanup MachinePostDominators..
Tue, Sep 24, 12:22 PM · Restricted Project, Restricted Project
hliao committed rGca635d7d44fb: [TextAPI] Remove redundant checking causing warnings. NFC. (authored by hliao).
[TextAPI] Remove redundant checking causing warnings. NFC.
Tue, Sep 24, 7:51 AM
hliao committed rL372765: [TextAPI] Remove redundant checking causing warnings. NFC..
[TextAPI] Remove redundant checking causing warnings. NFC.
Tue, Sep 24, 7:51 AM
hliao committed rGd19fb46d40e5: [llvm-objcopy] Fix a warningon unused variable. NFC. (authored by hliao).
[llvm-objcopy] Fix a warningon unused variable. NFC.
Tue, Sep 24, 5:45 AM
hliao committed rL372745: [llvm-objcopy] Fix a warningon unused variable. NFC..
[llvm-objcopy] Fix a warningon unused variable. NFC.
Tue, Sep 24, 5:44 AM

Mon, Sep 23

hliao committed rG566b3164c51e: [Sema] Fix the atomic expr rebuilding order. (authored by hliao).
[Sema] Fix the atomic expr rebuilding order.
Mon, Sep 23, 11:51 AM